Commit Graph

3404 Commits

Author SHA1 Message Date
hengsin 95924e8578
IDEMPIERE-5103 Clear Parent Tax ID if a Tax Rate record is Summary (#1056) 2021-12-17 19:25:40 +01:00
hengsin 160db45e84
IDEMPIERE-5104 MLookup: Inconsistent use of TabNo (#1057) 2021-12-17 19:24:21 +01:00
Carlos Ruiz cafe018404
IDEMPIERE-4448 Autocomplete/Info Window doesn't work correctly with Search fields with Reference (#1055)
* Change 188 reftables to use the ID for display - this displays the reference based on the identifiers of the table, making it consistent with Search/Table without reference
* Use the MSysConfig.IDENTIFIER_SEPARATOR for the cases where reference is displaying value and another column
2021-12-17 13:44:55 +08:00
hengsin 52c423dfeb
IDEMPIERE-5102 Deactivate AD_Desktop and AD_Workbench (#1053) 2021-12-17 11:10:48 +08:00
hengsin d0d68de57b
IDEMPIERE-4723 Clean up iDempiere's code (#1054)
* IDEMPIERE-4723 Clean up iDempiere's code

* IDEMPIERE-4723 Clean up iDempiere's code
2021-12-16 10:58:24 +01:00
Carlos Ruiz 08c7775f77
IDEMPIERE-5099 Invoice Tax zero deleted wrongly when invoice line is updated before complete (#1050) 2021-12-16 14:53:18 +08:00
hengsin dc698ff655
IDEMPIERE-5073 M_InOutLineMA.DateMaterialPolicy should comes from MStorageOnHand or Shipment instead of through user entry (#1027) 2021-12-14 15:35:04 +01:00
Carlos Ruiz a12ba93869
IDEMPIERE-4186 allow workflow to be suspended until after commit of actual transaction (#1034)
* IDEMPIERE-4186 allow workflow to be suspended until after commit of actual  transaction / fix Split Join = AND

* Add unit test for Split AND

* Fix test case - commit and cleanup the changes to workflow
2021-12-14 10:53:43 +08:00
hengsin 74b6604d57
IDEMPIERE-5065 Material Receipt Line not available for matching after… (#1019)
* IDEMPIERE-5065 Material Receipt Line not available for matching after reversal of Match PO

* IDEMPIERE-5065 Material Receipt Line not available for matching after reversal of Match PO

Fix unit test

* IDEMPIERE-5065 Material Receipt Line not available for matching after reversal of Match PO

Remove unreliable and potentially dangerous match po consolidation
2021-12-13 18:48:48 +01:00
hengsin 1eedd3f5a6
IDEMPIERE-5098 MCost.get: new MCost created without trxName (#1048) 2021-12-13 18:41:21 +01:00
Carlos Ruiz e5344194a3
IDEMPIERE-4900 SQL statement added as an option to define WF Next Node Condition (#1049)
Fix wrong matches pattern -> eclipse 2021-12 complains with error
Invalid escape sequence (valid ones are  \b  \t  \n  \f  \r  \"  \'  \\ )
2021-12-13 21:41:35 +08:00
hengsin 1da4e41f0a
IDEMPIERE-5095 MAttributeSet: add getMAttributeUse method (#1044) 2021-12-11 15:46:32 +01:00
gsjeffen c895446af5
Don't log the table AD_WLISTBOX_CUSTOMIZATION (#1047)
Added the table AD_WLISTBOX_CUSTOMIZATION to dontLogTables array in Convert.java
2021-12-11 12:51:43 +08:00
Tony Snook 236608e1cd
IDEMPIERE-5078 - fix typo C_DocType should be C_DocType_ID (#1045) 2021-12-10 17:50:52 +08:00
PeterTakacs300 0dbbdcadab
IDEMPIERE-5078 - M_inout movementtype add to before save (#1038)
* IDEMPIERE-5078 - M_inout movementtype add to before save

* IDEMPIERE-5078 - shared logic between CalloutInOut.doctype and MInOut.getMovementType

* IDEMPIERE-5078 - javadoc added (#1038)

Co-authored-by: Igor Pojzl <igor.pojzl@cloudempiere.com>
2021-12-09 19:39:12 +08:00
Carlos Ruiz 4439765e22
IDEMPIERE-4871 Print Format Item Script Data Type Support (fix backward compatibility issue) (#1007) 2021-12-09 09:39:55 +08:00
hengsin 3530351601
IDEMPIERE-2172 Attribute set with mandatory type = When Shipping not … (#1040)
* IDEMPIERE-2172 Attribute set with mandatory type = When Shipping not working

Fix reversal and add more unit test

* IDEMPIERE-2172 Attribute set with mandatory type = When Shipping not working

Use constant for movement type checking
2021-12-08 16:18:44 +01:00
Diego Ruiz 5c675536cd
IDEMPIERE-4723 - Clean up dead code in compiere/print (#1039)
* IDEMPIERE-4723 - Clean up dead code in compiere/print

* IDEMPIERE-4723 - Clean up dead code in compiere/print
2021-12-08 21:48:44 +08:00
Carlos Ruiz 78296f9178
IDEMPIERE-5080 Dup key inserting in AD_PInstance_Log on certain workflows (#1032) 2021-12-08 17:14:15 +08:00
Carlos Ruiz 497398857e
IDEMPIERE-5079 Improvements for Workflow Editor (#1033) 2021-12-08 17:12:57 +08:00
hengsin db4087f878
IDEMPIERE-2172 Attribute set with mandatory type = When Shipping not … (#1014)
* IDEMPIERE-2172 Attribute set with mandatory type = When Shipping not working

* IDEMPIERE-2172 Attribute set with mandatory type = When Shipping not working

- added MTransaction
- added reversal handling
2021-12-07 14:10:19 +01:00
hengsin 055c614336
IDEMPIERE-5069 Completion of Shipment for Close Order produce inconsistent order line data (#1030) 2021-12-07 13:12:52 +01:00
hengsin 40462f674b
IDEMPIERE-5081 add IDocsPostProcess interface (#1035) 2021-12-07 12:32:14 +01:00
hengsin 6637f549d7
IDEMPIERE-5084 SQL error in MPaymentTransaction.getAuthorizationPaymentTransactionIDs method (#1036) 2021-12-07 12:14:20 +01:00
hengsin 5c2effc554
IDEMPIERE-5085 Credit card fields of Payment should be clear after change of tender type (#1037) 2021-12-07 11:56:26 +01:00
Diego Ruiz 1f1797ce5b
IDEMPIERE-5063 - Move AccessSqlParserTest class from model to org.ide… (#1028)
* IDEMPIERE-5063 - Move AccessSqlParserTest class from model to org.idempiere.test

* IDEMPIERE-5063 - Set right header in the Test class
2021-12-06 18:49:11 +08:00
Diego Ruiz a14ac5fbe2
IDEMPIERE-4723 - Clean up dead code (#1026) 2021-12-06 18:47:28 +08:00
Elaine Tan b85fecbf74
IDEMPIERE-5053 Minor variance (0.01) in secondary (USD) schema, GL Unallocated Cash, after payment fully allocated (#1020)
* IDEMPIERE-5053 Minor variance (0.01) in secondary (USD) schema, GL Unallocated Cash, after payment fully allocated
2021-12-06 18:46:19 +08:00
hengsin 935007d58a
IDEMPIERE-5061 Inconsistency in getLines Order By code (#1013) 2021-12-02 14:50:39 +01:00
hengsin 7b1c9322f9
IDEMPIERE-5066 Order Line Create Production not visible in the process toolbar dropdown (#1021) 2021-12-02 09:23:36 +08:00
Carlos Ruiz feebea8691
IDEMPIERE-5052 Date Min/Max Validation wrong with 5 digit years (#1016)
* IDEMPIERE-5052 Date Min/Max Validation wrong with 5 digit years

* IDEMPIERE-5052 Date Min/Max Validation wrong with 5 digit years / enable for Cost+Price and String
2021-12-01 09:46:53 +08:00
Carlos Ruiz 0e58458114
IDEMPIERE-5006 [Info Window] - MInfoProcess & MInfoRelated cached incorrectly (#1015) 2021-12-01 09:44:24 +08:00
hengsin ce83914f32
IDEMPIERE-5054 Order Line: Shouldn't allow change of ASI when Qty Reserved > 0 (#1006) 2021-11-29 16:11:54 +01:00
hengsin 05447b38ce
IDEMPIERE-5040 Stall M_InOutLine.QtyOverReceipt (#1005)
* IDEMPIERE-5040 Stall M_InOutLine.QtyOverReceipt

* IDEMPIERE-5040 Stall M_InOutLine.QtyOverReceipt

Drop the user of M_InOutLine.QtyOverReceipt column
2021-11-29 16:01:52 +01:00
Carlos Ruiz 744e84ccc5
IDEMPIERE-5059 Import the database view definition into dictionary (#1011) 2021-11-29 10:25:08 +08:00
Carlos Ruiz 143ef24a58
IDEMPIERE-5060 iDempiere dictionary view doesn't support UNION ALL (#1009) 2021-11-29 10:22:30 +08:00
hengsin 2b79a1a874
IDEMPIERE-5039 Negative Lost Sales Quantity (#1003)
fix unit test IDEMPIERE-4587
2021-11-25 14:09:49 +01:00
Saulo José Gil 9e2922c7c8
IDEMPIERE-5050 Service startup freeze (#996)
* IDEMPIERE-5050 Service startup freeze

Switched all annotation-based factories to asynchronous class scan.

* Deferred MIssue record creation

Log errors on the database after all model factories are initialized.

* Moved webservice model classes over to its own package

Model factories WS_ModelFactory and AnnotationBasedModelFactory were
overlapping on the org.compiere.model package. This produced class
loading problems since the base bundle has no visibility over the
webservices bundle (e.g.: MWebservice).

* Minor changes
2021-11-24 13:57:35 +08:00
Nicolas Micoud 2486ff8148
IDEMPIERE-4858 : Helper process "Make Table a Document" - fixes for t… (#990)
* IDEMPIERE-4858 : Helper process "Make Table a Document" - fixes for translation tables

see details in tickets

* IDEMPIERE-4858 : Helper process "Make Table a Document" - add TableIndex records

* IDEMPIERE-4858 : Helper process "Make Table a Document" - AD_Message / tick IsTranslated on main table

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* Delete pr990_PR.txt

commited by error

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-11-19 17:02:54 +01:00
hengsin ceb056e6d8
IDEMPIERE-5048 Minor fix for Scheduler and SvrProcess: set m_trx to null (#989) 2021-11-19 16:12:39 +01:00
hengsin 29f5186d41
IDEMPIERE-5047 iDempiere Server Monitor Improvements (#988) 2021-11-19 16:04:54 +01:00
hengsin 2c5efb3031
IDEMPIERE-5046 Implement background reset of expire cache (#987) 2021-11-19 15:55:04 +01:00
hengsin 5ccd54caf8
IDEMPIERE-4900 SQL statement added as an option to define WF Next Nod… (#981)
* IDEMPIERE-4900 SQL statement added as an option to define WF Next Node Condition

Base on pull request 813 (Anton Mostovenko) and patch from
IDEMPIERE-1832 (Deepak Pansheriya)

* IDEMPIERE-4900 SQL statement added as an option to define WF Next Node Condition

Incorporate patch from carlos

* IDEMPIERE-4900 SQL statement added as an option to define WF Next Node Condition

Incorporate patch from Carlos
2021-11-17 12:06:42 +01:00
hengsin 8db15d01d1
IDEMPIERE-2168 Product with ASI Mandatory Type = When Shipping is still mandatory on sales orders (#976) 2021-11-15 19:06:24 +01:00
hengsin f4764b1411
IDEMPIERE-5039 Negative Lost Sales Quantity (#978)
* IDEMPIERE-5039 Negative Lost Sales Quantity

* IDEMPIERE-5039 Negative Lost Sales Quantity

* IDEMPIERE-5039 Negative Lost Sales Quantity

add unit test
2021-11-15 20:32:17 +08:00
Deepak Pansheriya 9c747a6f0d
IDEMPIERE-4086: Allow Product without price list on some document type (#974) 2021-11-12 10:57:30 +01:00
hengsin f937cdbf35
IDEMPIERE-5029 User can make Shipment/Receipt Line Product different … (#968)
* IDEMPIERE-5029 User can make Shipment/Receipt Line Product different from Order Line Product

* IDEMPIERE-5029 User can make Shipment/Receipt Line Product different from Order Line Product

Merge patch from Carlos

* IDEMPIERE-5029 User can make Shipment/Receipt Line Product different from Order Line Product

Make consistent with previous patch - always use oLine.M_Product_ID for
reservation

* IDEMPIERE-5029 User can make Shipment/Receipt Line Product different from Order Line Product

add safe guard against oLine is Charge and sLine is Product.

* IDEMPIERE-5029 User can make Shipment/Receipt Line Product different from Order Line Product

- need to apply the oLine.getM_Product_ID changes to reservation log
too.

* IDEMPIERE-5029 User can make Shipment/Receipt Line Product different from Order Line Product

More fix for update of qtyreserved not using product id from oLine.

* IDEMPIERE-5029 User can make Shipment/Receipt Line Product different from Order Line Product

update of qtyreserved: should use warehouse and issotrx from order too
2021-11-11 18:48:27 +01:00
Carlos Ruiz 0f31a07f43
IDEMPIERE-5034 NPE and other problems when a file is removed from store attachment filesystem (#971) 2021-11-10 09:41:30 +08:00
hengsin d0340e70d5
IDEMPIERE-5031 Implement auto produce upon shipment for mfg light (#969)
* IDEMPIERE-5031 Implement auto produce upon shipment for mfg light

* IDEMPIERE-5031 Implement auto produce upon shipment for mfg light

Fix clean up of unit test
2021-11-09 14:23:49 +01:00
Saulo José Gil 4d93067d1a
IDEMPIERE-5025 Easier usage of process parameters (#963)
* IDEMPIERE-5025 Easier usage of process parameters

Created @Parameter annotation in order to tag process class attributes
as parameters and have them to have their values assigned automatically
without extra code.

* Minor changes
2021-11-06 14:50:14 +08:00
hengsin ea3b147fb1
IDEMPIERE-5021 Implement Storage Reservation Log (#961)
* IDEMPIERE-5021 Implement Storage Reservation Log

- implement log table for movement of QtyReserved and QtyOrdered

* IDEMPIERE-5021 Implement Storage Reservation Log

update javadoc and license header

* IDEMPIERE-5021 Implement Storage Reservation Log

increase documentno column length to 255

* IDEMPIERE-5021 Implement Storage Reservation Log

Fix migration script
2021-11-03 12:27:57 +01:00
hengsin ed4c1a81d0
IDEMPIERE-4472 Window Advanced Search - Allow select column from wind… (#959)
* IDEMPIERE-4472 Window Advanced Search - Allow select column from window tabs - 2pack compatibility

Based on pull request #170 from igorpojzl.
Difference from #170:
- use AD_Tab_UU instead of AD_Tab_ID
- use Combobox for table list

* IDEMPIERE-4472 Window Advanced Search - Allow select column from window tabs - 2pack compatibility

Fix attribute search

* IDEMPIERE-4472 Window Advanced Search - Allow select column from window tabs - 2pack compatibility

Merge patch from Carlos (increse length of AD_UserQuery.Code)
2021-11-01 22:05:49 +08:00
Carlos Ruiz 180b11bd65
IDEMPIERE-5020 Allow to show products without price in Info Product window (#957) 2021-10-29 15:35:40 +08:00
Carlos Ruiz 4e4a3d9bac
IDEMPIERE-4782 Multi-factor authentication (FHCA-2034) (#955)
- support for System user with access to multiple tenants
- default to re-register device when expired
2021-10-29 14:48:36 +08:00
hengsin 28638d075b
IDEMPIERE-5019 add org.adempiere.base.annotation.EventTopicDelegate annotation (#952) 2021-10-28 11:21:08 +02:00
hengsin 22c09368e6
IDEMPIERE-5015 add org.adempiere.base.annotation.Callout annotation (#948) 2021-10-27 12:15:58 +02:00
hengsin 85f640ffdf
IDEMPIERE-4966 Error in FinReport with List Sources and Native Postgr… (#945)
* IDEMPIERE-4966 Error in FinReport with List Sources and Native PostgreSQL

* IDEMPIERE-4966 Error in FinReport with List Sources and Native PostgreSQL

Incorporate suggestion from Carlos (replace DB.executeUpdate call with
DB.executeUpdateEx)
2021-10-26 16:35:08 +08:00
hengsin 633c2e240f
IDEMPIERE-5012 org.idempiere.ui.zk.annotation.Form annotation (#944) 2021-10-23 15:11:49 +02:00
hengsin 4759ae5c2b
IDEMPIERE-5001 add org.adempiere.base.annotation.Process annotation (#924)
* IDEMPIERE-5001 add org.adempiere.base.annotation.Process annotation

* IDEMPIERE-5001 add org.adempiere.base.annotation.Process annotation

minor refinement

* IDEMPIERE-5001 add org.adempiere.base.annotation.Process annotation

refine error handling

* IDEMPIERE-5001 add org.adempiere.base.annotation.Process annotation

refactor to follow closer the AnnotationBasedModelFactory naming
convention.
2021-10-22 12:38:10 +02:00
hengsin 4b923f4d03
IDEMPIERE-5004 add org.adempiere.base.Model annotation support to MappedModelFactory (#930) 2021-10-22 12:27:48 +02:00
hengsin a73ce05875
IDEMPIERE-4999 Advanced Lookup on sub-tab of a window triggers a PSQL Exception (#939)
- Integrate patch from Tony Snook to fix issue with "product category"
and "Chosen Multiple Selection List" field
2021-10-22 12:23:39 +02:00
hengsin eb82c679ca
IDEMPIERE-5003 Abort for workflow activity and process manage is not working (#925) 2021-10-22 12:18:20 +02:00
HideakiHagiwara 9f835c3e15
IDEMPIERE-5008 Performance improvement of "NF3.0 Tree On Any Table". (#938)
Co-authored-by: jpiere <h.hagiwara@compiere-distribution-lab.net>
2021-10-21 15:48:09 +08:00
Ricardo Santana 1970ee6539
IDEMPIERE-5002 RMA does not handle UoM properly (#928) 2021-10-21 15:23:17 +08:00
Diego Ruiz c9354bca85
IDEMPIERE-5000 Window Customization Field does not show fields that are not displayed in the Window>Tab>Field sytem record (#922) 2021-10-13 16:14:59 +02:00
Diego Ruiz 6dd60f30c7
IDEMPIERE-4723 - Clean up org.compiere.acct dead code (#921) 2021-10-13 13:19:18 +08:00
Nicolas Micoud 08b2c28207
IDEMPIERE-4998 : NPE when saving a SysConfig from code (#920)
* IDEMPIERE-4998 : NPE when saving a SysConfig from code

fix missing parenthesis and remove .bak file

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>
2021-10-12 17:16:44 +02:00
Carlos Ruiz 5f39c14e31
IDEMPIERE-4997 Allow to use product (or charge) in commissions configuration (#919) 2021-10-12 12:04:59 +02:00
Carlos Ruiz 68d2d7432e
IDEMPIERE-2624 Cant confirm 0 qty on Shipment Confirmation (#917) 2021-10-12 09:36:49 +08:00
gsjeffen eb3db56364
IDEMPIERE-4863 Enable save column width in WListBox (#883)
* IDEMPIERE-4863-1 Enable save column width in WListBox

This PR is the base for implementing save of column width of a wlistbox in forms and windows.

* IDEMPIERE-4863-1 Enable save column width in WListBox implementation example

This commit is showing examples implementation of this PR, it is for infoProductWindow and infoWindow
2021-10-12 09:27:26 +08:00
Diego Ruiz 859c30166b
IDEMPIERE-4964 - Status line message does not update when changing th… (#918)
* IDEMPIERE-4964 - Status line message does not update when changing the detail

* Update GridTab.java

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-10-11 20:06:01 +02:00
Diego Ruiz 7d7b2cf5b4
IDEMPIERE-4723 Clean code org.adempiere.base/ akunagroup/ adempiere /base/imexp/model/print/process/util org.compiere (#915) 2021-10-11 16:49:41 +08:00
Carlos Ruiz ca9aa33afb
IDEMPIERE-4986 Extend events to prefill email dialog variables from report window (#908)
* IDEMPIERE-4986 Extend events to prefill email dialog variables from report window

* IDEMPIERE-4986 Extend events to prefill email dialog variables from report window / also in new Attachment button

* IDEMPIERE-4986 Extend events to prefill email dialog variables from report window / change approach to constructor

* IDEMPIERE-4992 email from archive dialog
2021-10-08 16:28:45 +08:00
Nicolas Micoud 631e25b599
IDEMPIERE-4721 : Financial Report : exclude all adjustment periods - … (#904)
* IDEMPIERE-4721 : Financial Report : exclude all adjustment periods - fix NPE

reported by @CarlosRuiz-globalqss ; see https://idempiere.atlassian.net/browse/IDEMPIERE-4721?focusedCommentId=47539

* IDEMPIERE-4721 : Financial Report : exclude all adjustment periods - fix NPE

Using Carlos's suggestion

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-10-07 10:53:43 +02:00
hengsin 8fbac60b1a
IDEMPIERE-1250 Multiple BOM (formulas) support for mfg-light (#906)
* IDEMPIERE-1250 Multiple BOM (formulas) support for mfg-light

* IDEMPIERE-1250 Multiple BOM (formulas) support for mfg-light

Fix deprecation warnings

* Update 202109291600_IDEMPIERE-1250.sql

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-10-06 17:06:26 +02:00
Nicolas Micoud 080ba69967
IDEMPIERE-4982 : Methods to retrieve value from multiple process para… (#901)
* IDEMPIERE-4982 : Methods to retrieve value from multiple process parameters

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2021-09-30 15:56:58 +08:00
Carlos Ruiz 557c483fc9
IDEMPIERE-4968 Enable 2Pack to run java class or script (FHCA-3112 FHCA-3113) / Shell script (#891)
* IDEMPIERE-4968 Enable 2Pack to run java class or script (FHCA-3112 FHCA-3113) / Shell script

* IDEMPIERE-4968 Enable 2Pack to run java class or script (FHCA-3112 FHCA-3113) / Java Shell script -> beanshell/groovy

* IDEMPIERE-4968 Enable 2Pack to run java class or script (FHCA-3112 FHCA-3113) / Remove java class option, fixes for script

* IDEMPIERE-4968 Enable 2Pack to run java class or script (FHCA-3112 FHCA-3113) / rename to ScriptJSR223

* IDEMPIERE-4968 Enable 2Pack to run java class or script (FHCA-3112 FHCA-3113) / add audit information to SQL statements, shell and JSR223 scripts
2021-09-24 16:38:07 +08:00
Carlos Ruiz 80ed239ac2
IDEMPIERE-4979 ModelGenerator class generates entries for inactive ref lists (#898) 2021-09-23 22:58:21 +08:00
hengsin 164e6d15b6
IDEMPIERE-4842 Easier model registration (#895)
* IDEMPIERE-4842 Easier model registration

- Needs to enable jar scanning to support felix/console installation of
plugin jar.
- add rejectJars call to reduce startup delay after enable of jar
scanning. keep the list short to reduce future maintenance hazard.
- remove the not supported use of acceptPackagesNonRecursive and
acceptClasses together.
- change getAcceptClassesPatterns() default to X_* and M*. Withouut
acceptPackages, we need to scan both X and M classes.

* IDEMPIERE-4842 Easier model registration

- remove use of rejectJars since the performance difference is small and
need maintenance.
- remove warning for not overriding getPackages(). Plugin that doesn't
has many model class (< 100) doesn't have to override getPackages() as
performance is good enough with the use of acceptClasses(...).
2021-09-23 21:14:47 +08:00
Fr Jeremy Krieg 445ca8e0fa
Fix error in setting product resource type. (#897)
Signed-off-by: kriegfrj <fr.jkrieg@greekwelfaresa.org.au>
2021-09-23 15:11:03 +02:00
Saulo José Gil 2b4a2be5a2
IDEMPIERE-4842 Easier model registration (#893)
* IDEMPIERE-4842 Easier model registration

- Change from https://github.com/atteo/classindex to
https://github.com/classgraph/classgraph, remove annotation processor
config.

- Change service.ranking of DefaultModelFactory to -1 and
service.ranking of AnnotationBasedModelFactory to 0. This give
AnnotationBasedModelFactory higher priority over DefaultModelFactory and
allow plugins to have higher priority over AnnotationBasedModelFactory
with server.ranking of 1 (the common practise before the introduction of
AnnotationBasedModelFactory).

- Added resultset constructor to MTree. This is to allow the use of
MTree with model factory.

- Remove classindex annotation from org.adempiere.base.Model and X_*
model classes.

- Added unit test for table to model class mapping

- AnnotationBasedModelFactory: Change from using annotation processor to
runtime annotation scanning using the classgraph library. The default
setting scans all the X_* model class and travels the inheritance
hierarchy to discover the M* model class. Plugin needs to create a
subclass of AnnotationBasedModelFactory and register it as an OSGi
component to scan the plugin's annotated model classes (the plugin's
custom AnnotationBasedModelFactory component should have service.ranking
> 0).

* IDEMPIERE-4842 Easier model registration

minor refinement

* Minor changes

Co-authored-by: hengsin <hengsin@gmail.com>
2021-09-22 22:42:51 +08:00
Nicolas Micoud 86c21dafda
IDEMPIERE-4866 : Multiple smtp per tenant (#884)
* IDEMPIERE-4866 : Multiple smtp per tenant

Same PR as https://github.com/idempiere/idempiere/pull/783

* IDEMPIERE-4866 : Multiple smtp per tenant - various fixes

Fixes suggested by Carlos on https://github.com/idempiere/idempiere/pull/783 (remove System.out, change AD_Element name, tab in SingleRow mode) + fix NPE

* IDEMPIERE-4866 : Multiple smtp per tenant : implement cache

* IDEMPIERE-4866 : Multiple smtp per tenant : process EMailTest was not set on column

Fixes by Carlos

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-09-21 14:56:56 +02:00
Carlos Ruiz 078d130cd7
IDEMPIERE-4969 Clean non-working 2Pack Code for File and CodeSnippet (#886) 2021-09-19 15:31:18 +08:00
hengsin 5413f0c11d
IDEMPIERE-4842 Easier model registration (#888)
* IDEMPIERE-4842 Easier model registration

- Temporary disable AnnotationBasedModelFactory until getSubclasses()
doesn't work for subclass from different package is resolve.

* IDEMPIERE-4842 Easier model registration

- turn of annotation processing in editor which causes slow editor
performance
2021-09-19 13:16:53 +08:00
hengsin 2f8adb48c9
IDEMPIERE-4842 Easier model registration (#887)
- Temporary disable AnnotationBasedModelFactory until getSubclasses()
doesn't work for subclass from different package is resolve.
2021-09-18 15:36:50 +08:00
Saulo José Gil 602e450a93
IDEMPIERE-4842 Easier model registration (#877)
* Preliminary support for automatic model class registration

Model classes can be tagged with a new @Model annotation that allows for
easy/fast class scanning/registration, based on the ClassIndex library.
The list of annotated model classes is generated at compile time, thus
reducing reflection reliance to a bare minimum.

NOTE: Eclipse uses its own Java compiler which is not strictly standard
compliant and requires extra configuration. In Java Compiler ->
Annotation Processing -> Factory Path you need to add ClassIndex jar
file

* Annotation based model factory

* Improve classloader determination for annotation scanning

ClassIndex default annotation scanning method determines the classloader
to be used by calling Thread.currentThread().getContextClassLoader(),
which should not be used in an OSGi environment.

* Enable ClassIndex's annotation processor under Eclipse

Make sure annotation processing is enabled at Module Properties -> Java
Compiler -> Annotation Processing

* Refactoring annotation-based model class detection

Eliminated the need of annotating M* classes, by using ClassIndex's
@IndexSubclasses annotation.

* Minor change

* Minor changes

* Creation of AbstractModelFactory

* Documentation

* Make AnnotationBasedModelFactory extend AbstractModelFactory

* IDEMPIERE-4842 Easier model registration

- add annotation processor jdt settings
- fix @Component annotation for AnnotationBasedModelFactory
- fix generated x_* class missing "org.atteo.classindex.IndexSubclasses"
import

* Expose ClassIndex lib to other bundles

* Updated model classes

Co-authored-by: hengsin <hengsin@gmail.com>
2021-09-18 13:35:57 +08:00
Nicolas Micoud a1da95cfff
IDEMPIERE-4946 : Add IsShowInDashboard, SeqNo and ImageURL on AD_User… (#866)
* IDEMPIERE-4946 : Add IsShowInDashboard, SeqNo and ImageURL on AD_UserDef_Info

* IDEMPIERE-4946 : Add IsShowInDashboard, SeqNo and ImageURL on AD_UserDef_Info

Use customized image from tenant level when opening the panel

* IDEMPIERE-4946 : Add IsShowInDashboard, SeqNo and ImageURL on AD_UserDef_Info - fix migration scripts name
2021-09-17 15:56:44 +02:00
Carlos Ruiz 5979f65bbd
IDEMPIERE-2853 Panel tab as a factory - preserve AD_Tab.IsSortTab for backward compatibility (#885) 2021-09-17 21:07:50 +08:00
Nicolas Micoud e0a8637880
IDEMPIERE-4721 : Financial Report : exclude all adjustement periods (#872)
* IDEMPIERE-4721 : Financial Report : exclude all adjustement periods

* Change warning to info

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-09-15 14:29:11 +02:00
hengsin 5f22f7f495
IDEMPIERE-4961 Minor performance enhancement for AD Window (#878)
* IDEMPIERE-4961 Minor performance enhancement for AD Window

* IDEMPIERE-4961 Minor performance enhancement for AD Window

Fix potential mtab not found issue with 2pack import.
2021-09-15 13:00:28 +02:00
hengsin 309eb5366f
IDEMPIERE-4960 Performance improvement for the opening of info window (#876)
* IDEMPIERE-4960 Performance improvement for the opening of info window

* IDEMPIERE-4960 Performance improvement for the opening of info window

Query.scroll and Query.list basically offer the same db performance, the
previous change is unnecessary.
2021-09-14 16:16:07 +02:00
Carlos Ruiz a95983730f
IDEMPIERE-4963 Performance: avoid loop in X_ class interface getters (#880) 2021-09-14 21:17:45 +08:00
hengsin ab12354cb4
IDEMPIERE-4959 Performance improvement for the opening of form window (#875)
* IDEMPIERE-4959 Performance improvement for the opening of form window

* IDEMPIERE-4959 Performance improvement for the opening of form window

minor cache name change.
2021-09-14 15:04:06 +02:00
hengsin eedc3c6e35
IDEMPIERE-4924 Performance issue with indirect context (#863)
* IDEMPIERE-4924 Performance issue with indirect context

- added cache

* IDEMPIERE-4924 Performance issue with indirect context
2021-09-14 14:32:20 +02:00
hengsin 21c07785e8
IDEMPIERE-4958 Performance improvement for the opening of process dialog (#874)
* IDEMPIERE-4958 Performance improvement for the opening of process dialog

* IDEMPIERE-4958 Performance improvement for the opening of process dialog

Query.scroll and Query.list has similar db performance, the previous
change is not needed.
2021-09-14 14:09:55 +02:00
hengsin 0c5a0112e1
IDEMPIERE-4933 Platform update for 9.x (#870)
minor: remove unnecessary nature and build command from .project
2021-09-10 09:55:07 +02:00
hengsin f8c72c0451
IDEMPIERE-4949 Desktop tab enhancements (#868)
* IDEMPIERE-4949 Desktop tab enhancements
* ConfigurationLevel=C

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-09-08 13:40:00 +02:00
Xin Wang 7f09b1adc5
IDEMPIERE-4945 Selected row is changed after table sort in Swing UI (#865)
At the end of table sorting, trigger data status change event before UI
event, so that GridTab data is changed before UI refresh, which is
needed for Swing UI.
2021-09-07 20:10:09 +08:00
hengsin ae5a665dd8
IDEMPIERE-4933 Platform update for 9.x (#857)
* IDEMPIERE-4933 Platform update for 9.x

- WIP

* IDEMPIERE-4933 Platform update for 9.x

- project to repackaged some osgi bundles from maven

* IDEMPIERE-4933 Platform update for 9.x

- Fix target platform error

* IDEMPIERE-4933 Platform update for 9.x

* IDEMPIERE-4933 Platform update for 9.x

- minor eclipse setting fix
2021-09-04 16:12:10 +02:00
hengsin f1c663e100
IDEMPIERE-4937 Refreshing the GridTab after moving a node in the Tree (#860)
* IDEMPIERE-4937 Refreshing the GridTab after moving a node in the Tree

* IDEMPIERE-4937 Refreshing the GridTab after moving a node in the Tree

Use Trx object instead of context for event changes indicator.
2021-09-04 20:16:14 +08:00
Carlos Ruiz 39ad82ebf0
IDEMPIERE-4470 Window Advanced Search - New operator types: AND Not, Or Not (#850)
* IDEMPIERE-4470 Window Advanced Search - New operator types: AND Not, Or Not

Based on pull request 170
Co-authored-by: Igor Pojzl <igor.pojzl@cloudempiere.com>

* IDEMPIERE-4470 Window Advanced Search - New operator types: AND Not, Or Not

Rename migration scripts as suggested by Heng Sin
2021-09-03 22:20:50 +08:00
hengsin 48c6dd40d4
IDEMPIERE-4250 Implement optimistic locking support (#838)
* IDEMPIERE-4250 Implement optimistic locking support

* IDEMPIERE-4250 Implement optimistic locking support

- merge fix from Carlos.
2021-09-03 13:17:20 +08:00
Carlos Ruiz 22f47cd382
IDEMPIERE-4939 Implement ability to discover operating system environment variables when parsing context (FHCA-3026) (#853)
* IDEMPIERE-4939 Implement ability to discover operating system environment variables when parsing context (FHCA-3026)

* IDEMPIERE-4939 Add unit test
2021-08-31 14:24:19 +02:00
Carlos Ruiz cd849dc23b
IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system) / add context discovery to AD_AuthorizationCredential.AuthorizationRedirectURL (#854)
FHCA-3026
2021-08-30 18:25:41 +02:00
Carlos Ruiz fcef8e1c15
IDEMPIERE-4911 Silent fail when translated column is shorter than original column (FHCA-2888) / fix issue with 2Pack (#855) 2021-08-30 18:24:25 +02:00
Nicolas Micoud 0ace1aa246
IDEMPIERE-4936 : Add IsDisplayedGrid on UserDefWindow (#849) 2021-08-30 15:41:45 +02:00
Deepak Pansheriya 96baf0b7cd
IDEMPIERE-2853: Support for IADTabPanel as factory to add custom Tab … (#579)
* IDEMPIERE-2853: Support for IADTabPanel as factory to add custom Tab types
sh: q: command not found

* IDEMPIERE-2853: adding requested Java doc, fixing seq mismatch in oracle and postgresql, Using Interface method instead of manual isSortTab check,

* IDEMPIERE-2853: Adding default implementation for isEnableCustomizeButton in IADTabpanel

* IDEMPIERE-2853: renaming reference label and Added support for allowing implementor to update toolbar state.

* IDEMPIERE-2853: Fixing compilation issue due to merging to master branch
2021-08-30 13:56:34 +02:00
Martin Schönbeck 111eab35d3
Idempiere 4724 (#637)
* IDEMPIERE-4724
allow to concatenate parts at import
allow to prefix them which also is necessary to separate them when concatenating
allow to concatenate callouts and provide sort of parameters

* Update CalloutEngine.java

minor - typos in comments

* Update ImpFormatRow.java

is better to raise the exception when the callout cannot be found - the results can be unexpected for end users if the callouts are not called

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-08-27 11:22:18 +02:00
Diego Ruiz 2f0e426771
IDEMPIERE-4723 - Clean up code -> remaining org.adempiere.base/src/org/compiere/model/ classes (#846) 2021-08-21 15:21:35 +08:00
Carlos Ruiz 0167c91424
IDEMPIERE-4911 Silent fail when translated column is shorter than original column (FHCA-2888) (#844)
* IDEMPIERE-4911 Silent fail when translated column is shorter than original column (FHCA-2888)

Changes:
* Saving a value that doesn't fit in the translation now fails with a proper user understandable message
* Synchronize Doc Translation now fails with a user understandable message in case it fails because a value doesn't fit
* When updating a column on a translation table, check for the size of the original column and update the size accordingly
* When updating a translated column, show warnings to user about creating the table, or creating the column, or updating the column size

* IDEMPIERE-4911 Silent fail when translated column is shorter than original column (FHCA-2888)

Improve message for end user
2021-08-20 13:59:35 +02:00
hengsin f912cf2c21
IDEMPIERE-701 Implement solving indirect context (#828)
* IDEMPIERE-701 Implement solving indirect context

- implement for tab display logic and readonly logic

* IDEMPIERE-701 Implement solving indirect context

- make use of parent gridtab for indirect context resolution
2021-08-20 13:47:25 +08:00
Carlos Ruiz 68a5dc1456
IDEMPIERE-4918 Cannot use simple auth after used OAuth (FHCA-2014) (#842) 2021-08-18 14:51:44 +02:00
hengsin 8cc3a2a33f
IDEMPIERE-4915 Improvements to Preference Popup (#835)
* IDEMPIERE-4915 Improvements to Preference Popup

* IDEMPIERE-4915 Improvements to Preference Popup

- Move MY_PROFILE_MENU_ID to SystemIDs
2021-08-18 13:15:07 +08:00
hengsin 461b597c8e
IDEMPIERE-3494 Implement DocStatus/DocAction for Project Issue (#839) 2021-08-17 18:59:14 +02:00
hengsin ac01e77a40
IDEMPIERE-4880 Replace iText PDF with OpenPDF (#837) 2021-08-17 18:44:32 +02:00
hengsin e585d4417d
IDEMPIERE-2963 Error creating report after zoom across (#833)
- generate fully qualified where clause for generic zoom across
2021-08-17 16:10:52 +02:00
hengsin f8fbf5f3bb
IDEMPIERE-1351 Quick Entry when Field can not zoom to 2 different windows (#829) 2021-08-17 16:07:13 +02:00
alara123 7745d0f27e
IDEMPIERE-4914 #resolve (#832) 2021-08-14 15:28:30 +08:00
Carlos Ruiz 1af3cc0848
IDEMPIERE-4061 isTranslated is not set Yes on new Record default (#825) 2021-08-12 23:10:35 +02:00
Diego Ruiz ce689bbbc2
IDEMPIERE-4912 Set the product's UOM on beforesave when creating an order line (#827) 2021-08-12 23:21:16 +08:00
Carlos Ruiz 8ec5029e8e
IDEMPIERE-4909 Allow empty password when using OAuth2 - refactor to allow sending email without AD_User (FHCA-2892) (#824) 2021-08-12 23:06:44 +08:00
Carlos Ruiz 729fc4a61e
IDEMPIERE-4910 Performance - Discover of UUID column not cached in PO (#826) 2021-08-12 22:14:46 +08:00
hengsin 184e8191e6
IDEMPIERE-4904 Add custom query clause support to report parameter (#821) 2021-08-12 15:02:01 +02:00
Diego Ruiz 29343610ca
IDEMPIERE-4723 - Clean up code -> MT/MU/MW* classes (#823) 2021-08-11 19:36:27 +08:00
hengsin d3d1a735b0
IDEMPIERE-4899 Report: print product instance attribute name and valu… (#814)
* IDEMPIERE-4899 Report: print product instance attribute name and value as column

* IDEMPIERE-4899 Report: print product instance attribute name and value as column

- use parenthesis for display logic
- fixed display logic evaluation exception
- fixed index out of bound exception for xls and xlsx

* IDEMPIERE-4899 Report: print product instance attribute name and value as column

- Fix css for columns that have been shifted to the right
2021-08-06 11:12:05 +02:00
igorpojzl 2cee3ff007
IDEMPIERE-4895 Product Cost - Valid Combination Caching (#805) 2021-08-03 13:00:46 +08:00
hengsin 1fb4067c01
IDEMPIERE-4894 OSGi Interface to support custom header and footer (#804)
* IDEMPIERE-4894 OSGi Interface to support custom header and footer

* IDEMPIERE-4894 OSGi Interface to support custom header and footer

incorporate migration script fix from Carlos
2021-07-30 13:53:28 +02:00
Deepak Pansheriya 3c8e05c9d6
IDEMPIERE-4770: Cross tenant issue while broadcasting message to System tenant role (#806) 2021-07-30 11:17:43 +02:00
Diego Ruiz 62b90fe6ca
IDEMPIERE-4723 - Clean up code -> MQ/MR/MS* classes (#802) 2021-07-30 07:00:50 +08:00
Carlos Ruiz ac0c663309
IDEMPIERE-4889 Performance - Attachment management (#801) 2021-07-28 11:34:09 +02:00
Carlos Ruiz 83b383788e
IDEMPIERE-4889 Performance - Attachment management (#798)
* IDEMPIERE-4889 Performance - Attachment management

* IDEMPIERE-4889 Performance - Attachment management

Implement suggestion from hengsin

* IDEMPIERE-4889 Performance - Attachment management
2021-07-28 11:01:38 +08:00
Diego Ruiz 40e411f693
IDEMPIERE-4723 - Clean up code -> MP* classes (#796) 2021-07-27 13:34:04 +08:00
hengsin 8f758ed904
IDEMPIERE-1994 Ability to organise process and report parameters by F… (#791)
* IDEMPIERE-1994 Ability to organise process and report parameters by Field Group functionality

* IDEMPIERE-1994 Ability to organise process and report parameters by Field Group functionality

Fix collapsed by default not working.
2021-07-24 11:05:49 +02:00
Diego Ruiz 02d5263742
IDEMPIERE-4723 - Clean up code -> MI/MPa classes (#793) 2021-07-24 13:26:36 +08:00
Carlos Ruiz 298dbab9d0
IDEMPIERE-4801 Add IMediaView interface and Keikai implementation (#792)
Add preview for CSV on attachment window
2021-07-24 13:06:53 +08:00
Nicolas Micoud a4dfd191ec
IDEMPIERE-4858 : CreateTable process (#774)
* IDEMPIERE-4858 : CreateTable process

* IDEMPIERE-4858 : CreateTable process - fixes

Changes following Carlos's remarks - see details in the ticket

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-4858 : CreateTable process - fixes migration scripts

See details in ticket

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-4858 : CreateTable process - various fixes

fix migration scripts names / constants in uppercase / remove check of table length

* IDEMPIERE-4858 : CreateTable process - various fixes

default value for EntityType param / replace numeric name/value params by boolean ones / enhance creation of system element (name/print name/description)
see https://idempiere.atlassian.net/browse/IDEMPIERE-4858?focusedCommentId=47325

* IDEMPIERE-4858 : CreateTable process : optional columns

* IDEMPIERE-4858 : CreateTable process : remove wrong temporary migration scripts

* IDEMPIERE-4858 : CreateTable process :

add org.adempiere.base.process as required plugin (and not as imported package)
add missing content on migration scripts

* IDEMPIERE-4858 : CreateTable process : fixes / reordering / renaming

Failed creating Description column: ** Fill mandatory fields: : Length
Value and DocumentNo are not usually mandatory
Some minor reordering and renaming of variables

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-4858 : CreateTable process : can be used to add columns on existing table

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-4858 : CreateTable process - fix default value for TableName parameter

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-4858 : CreateTable process  - restore default value for Description, Name and AccessLevel parameters

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-07-23 15:37:22 +02:00
Diego Ruiz 3f52286bbe
IDEMPIERE-4723 - Clean up code -> MD/ME/MG/MF classes (#787) 2021-07-23 14:18:03 +08:00
hengsin 162c48ec4c
IDEMPIERE-4873 Jasper Report Starter Refactoring (#779) 2021-07-22 11:42:07 +02:00
hengsin 2975ff6429
IDEMPIERE-4881 CSS style anomaly - display logic (#786)
Fix regression (empty expression evaluation) introduce by previous
patch.

Pushing this through as the previous change set introduce a significant regression.
2021-07-20 21:47:17 +08:00
hengsin 6169d09924
IDEMPIERE-4881 CSS style anomaly - display logic (#782)
Fix equal evaluation for numeric expression
2021-07-20 11:25:08 +02:00
hengsin 287f41a067
IDEMPIERE-4801 Add IMediaView interface and Keikai implementation (#780)
Fix preview of xlsx not working at attachment viewer
2021-07-16 11:15:40 +02:00
hengsin 3dcef18868
IDEMPIERE-4841 Info Window: Implement auto hide empty columns (#781) 2021-07-15 17:03:33 +02:00
igorpojzl de2b29d129
IDEMPIERE-4871 Added Data Type for Script Column (#776)
* IDEMPIERE-4871 Added Data Type for Script Column

* IDEMPIERE-4871 Script Column -Fix Script Evaluation Data Type
2021-07-14 08:06:27 +08:00
Nicolas Micoud 19cfc2d07d
IDEMPIERE-4874 : Process customization must have effect on Menu and Tab title (#778) 2021-07-11 13:56:31 +08:00
Carlos Ruiz 0b3e307d86
IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system) (#773)
Make the table and record ID from MPInstanceLog accessible
related to IDEMPIERE-4678 too
2021-07-07 19:46:58 +02:00
Carlos Ruiz 16032399fa
IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system) (#772)
Save the ad_pinstance_log record out of the method to independize it from the pinstance
2021-07-07 19:25:08 +02:00
Carlos Ruiz 287f6bf91f
IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system) (#771)
* IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system)

Split processToken in two public methods to allow calling from external interfaces

* Add suggestion from druiz
2021-07-07 17:30:33 +02:00
Nicolas Micoud 8ef060d938
IDEMPIERE-3732 : MRefList.getList cannot allow to choose order by (#746)
* IDEMPIERE-3732 : MRefList.getList cannot allow to choose order by

* @nmicoud IDEMPIERE-3732 : MRefList.getList cannot allow to choose order by - ASP filter

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>
2021-07-07 10:44:07 +02:00
Deepak Pansheriya 72ba9fd9d3
IDEMPIERE-4837:on Product Info, only defaulting price list when window has UserPriceListInProductInfo ctx variable set. (#754) 2021-07-05 21:27:41 +02:00
Patric Massing bb2bbc710c
IDEMPIERE-4828-posting of Allocation with a AR Credit Memos with disc… (#745)
* IDEMPIERE-4828-posting of Allocation with a AR Credit Memos with discount, the tax-correction has the wrong sign

* IDEMPIERE-4828 - posting of Allocation with a AR Credit Memos with discount, the tax-correction has the wrong sign

check for DocBaseType
2021-07-05 21:02:44 +02:00
hengsin 93bc73c257
IDEMPIERE-4865 Find window enhancements (#766) 2021-07-05 20:37:28 +02:00
hengsin d7c0ebf980
IDEMPIERE-2682 Html Report >> locking/freeze header row (#761)
* IDEMPIERE-2682 Html Report >> locking/freeze header row

Fix printing
2021-07-05 20:24:42 +02:00
Diego Ruiz a74694f81e
IDEMPIERE-4723 - Clean up dead code -> MC* classes (#762) 2021-07-05 19:51:58 +08:00
Nicolas Micoud fbc4feaf08
IDEMPIERE-4860 : MRole.updateAccessRecords insert active records based on deactivated objects (#758) 2021-07-02 10:33:35 +08:00
Nicolas Micoud ffc9bf12fb
IDEMPIERE-4861 : GenerateModel / Reference List / Use Value for ordering (#759) 2021-07-02 10:31:21 +08:00
Carlos Ruiz 361edea318
IDEMPIERE-4578 generic DocAction (#736)
* IDEMPIERE-4578 generic DocAction

* IDEMPIERE-4578 generic DocAction

* IDEMPIERE-4578 generic DocAction

Refactor generic docaction implementation to a separate delegate class.
This should make it easier for any model class to implement the
DocAction interface using the DocActionDelegate class.

* IDEMPIERE-4578 generic DocAction

add generic type support

* IDEMPIERE-4578 generic DocAction

generic type should implements DocAction

* IDEMPIERE-4578 generic DocAction

Co-authored-by: hengsin <hengsin@gmail.com>
2021-07-02 10:25:30 +08:00
Carlos Ruiz 0e58005d6f
IDEMPIERE-4853 Process to copy a Packout definition (FHCA-859) (#756)
* IDEMPIERE-4853 Process to copy a Packout definition (FHCA-859)

* IDEMPIERE-4853 Process to copy a Packout definition (FHCA-859)

Do not copy inactive details (as suggested by hengsin)
2021-07-01 22:14:46 +08:00
hengsin 10812c486d
IDEMPIERE-4824 Boolean Logic Expression Enhancements (#748)
* IDEMPIERE-4824 Boolean Logic Expression Enhancements

Fix comparison operator not working for timestamp value
2021-06-29 16:36:50 +02:00
hengsin c33d0528a7
IDEMPIERE-4850 JasperReport: Implement ResourceBundle backed by AD_Message and AD_Element (#747)
* IDEMPIERE-4850 JasperReport: Implement ResourceBundle backed by AD_Message and AD_Element
2021-06-29 12:20:11 +02:00
Nicolas Micoud 0e6e5efc7d
IDEMPIERE-4829 - Add SeqNoGrid on UserDefWindow (#718)
* IDEMPIERE-4829 - Add SeqNoGrid on UserDefWindow

* IDEMPIERE-4829 : scripts moved to i8.2z
2021-06-28 16:11:42 +02:00
Nicolas Micoud e813d2cca4
IDEMPIERE-4843 : MInvoice.setBPartner method retrieves inactive contacts (#744) 2021-06-28 16:04:57 +02:00
hengsin adc9999d89
IDEMPIERE-2937 Html Report - Suppress Null checkbox doesn't work (#734) 2021-06-28 13:54:33 +02:00
hengsin df704cb236
IDEMPIERE-4227 Unable to use 2 print format item with the same AD_Column_ID and different formatting (#740)
* IDEMPIERE-4227 Unable to use 2 print format item with the same AD_Column_ID and different formatting

Fix function column
2021-06-28 13:47:20 +02:00
Andreas Sumerauer 0bfeb8c0b0
IDEMPIERE-4847 TableIndexValidate: include only active columns in table index (#741)
* TableIndexValidate: include only active columns in table index

* simplified MTableIndex.getColumns()

* MTableIndex.createDDL() - restored space positioning

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-06-26 19:32:50 +08:00
Andreas Sumerauer 73b389652f
IDEMPIERE-4849: fix for MProduction.createLines() storage issue (#743)
* fix for MProduction.createLines/( storage issue

* extended if clause to cover storage lines with the same AsiID

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-06-26 13:18:54 +08:00
hengsin ded9693163
IDEMPIERE-4835 Grid View: Implement optional hide empty column feature (#727)
* IDEMPIERE-4835 Grid View: Implement optional hide empty column feature

* IDEMPIERE-4835 Grid View: Implement optional hide empty column feature

- fix issue with save width saving 0px width to
ad_tab_customization.custom
- added ad_tab_customization.IsAutoHideEmptyColumn
2021-06-19 09:24:08 +02:00
hengsin d832d1f352
IDEMPIERE-4565 Report (XLSX output) : add header (#729)
sync xls and xlsx output
2021-06-18 22:22:36 +02:00
Diego Ruiz d5845fcffe
IDEMPIERE-4723 - Clean up dead code -> MA*/MB* classes (#726) 2021-06-18 10:34:11 +08:00
Nicolas Micoud 715bf4f856
IDEMPIERE-4833 : Impossible to display a report based on a table when no parameter (#721) 2021-06-16 15:30:09 +08:00
Diego Ruiz 756cf807f2
IDEMPIERE-4743 - Clean up dead code (#722) 2021-06-16 15:10:41 +08:00
hengsin e7ea517b99
IDEMPIERE-4824 Boolean Logic Expression Enhancements (#717)
Regenerated source with correct antlr4 version to remove deprecation
warnings.
2021-06-11 17:14:49 +08:00
hengsin d7153575e6
IDEMPIERE-4824 Boolean Logic Expression Enhancements (#716)
* IDEMPIERE-4824 Boolean Logic Expression Enhancements

* IDEMPIERE-4824 Boolean Logic Expression Enhancements

Fix handling of conditional variable (i.e @VariableName:DefaultValue@)

* IDEMPIERE-4824 Boolean Logic Expression Enhancements

Fix unit test launch configuration
2021-06-10 23:08:22 +08:00
Diego Ruiz 5811f87f19
IDEMPIERE-4743 - Clean up ImageDBStorageImpl, Lookup, M_Element, MAccount, MAcctProcessor,MAcctSchema,MAcctSchemaDefault,MAcctSchemaElement classes (#714) 2021-06-10 15:49:49 +08:00
Carlos Ruiz a4f67eb852
IDEMPIERE-4782 Multi-factor authentication (FHCA-2034) (#705)
* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Implement suggestions from Heng Sin

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Fix security warning advised by github/CodeQL

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Implement an incremental delay in zk when the validation code is wrong (to avoid brute-force attacks)
As suggested by Ricardo Santana:
* ensures one-time only use of an OTP
* Log failures in AuthFailure.log

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

* Log failures in AuthFailure.log - add case for login with email
* Implement incremental delay also for login panel
2021-06-08 19:49:46 +08:00
igorpojzl 3e64dc6737
IDEMPIERE-4479 - Allow define columnSql in AD_Field (#710)
* IDEMPIERE-4479 - Allow define columnSql in AD_Field

* IDEMPIERE-4479 Added View Update, ColumnSql fix FieldLength

* IDEMPIERE-4479 Updated AD_Field Model

* IDEMPIERE-4479 MFIeld update model logic

* IDEMPIERE-4479 Move Migration scripts to 8.2
2021-06-04 10:03:05 +02:00
Carlos Ruiz d9826c775f
IDEMPIERE-4813 Process Customization Cross Tenant Error (#707)
* Implement for Window, Process and Info Window Customization:
  * Change to non-updateable the columns that have related children
  * Change default to NULL in role, user and language
  * Disable the autofilling of name, description and help
2021-06-03 15:40:30 +02:00
igorpojzl 6da6bc1d85
IDEMPIERE-4796 Request EMail Processor - Html email processing type parameter (#696)
* IDEMPIERE-4796 EmailSrv Parse Html Images

* IDEMPIERE-4796  Request EMail Processor - Html email processing type parameter

* IDEMPIERE-4796 Migration Scripts Added

* IDEMPIERE-4796 Added Register_Migration_Script

* IDEMPIERE-4796 Html Attachment Type Variable Logic Update

* IDEMPIERE-4796 ImageList null check added
2021-06-03 21:05:22 +08:00
igorpojzl d45ee838e3
IDEMPIERE-4815 FIX Check C_Country_ID when getting cached data. (#708) 2021-06-03 16:19:54 +08:00
hengsin b928043646
IDEMPIERE-4801 Add IMediaView interface and Keikai implementation (#700)
* IDEMPIERE-4801 Add IMediaView interface and Keikai implementation

* IDEMPIERE-4801 Add IMediaView interface and Keikai implementation

- Fixed some dependency issues
- Uses guava mediatype class

* minor - fix NPE when empty CSV

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-05-29 11:54:12 +02:00
Carlos Ruiz 6d78119006
IDEMPIERE-4800 Performance - avoid multiple for in GridTab.getParentTabNo (#699) 2021-05-27 14:38:02 +08:00
igorpojzl 17a80a0beb
IDEMPIERE-4799 Fix Check Parent Column Name (#698) 2021-05-26 12:38:42 +02:00
Carlos Ruiz 590d03ae3b
IDEMPIERE-4798 Add Event Before Parse Status Line (#697) 2021-05-26 17:21:27 +08:00
hengsin beaaf31d9a
IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler (#679)
* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

Fix initial output type selection for csv. Fix handling of binary vs
text media type.

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

- Change AD_AuthorizationAccount scope from single value to multiple
selection list (AD_AuthorizationScopes replace AD_AuthorizationScope)

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

Fix isIntersectCSV db function

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

add back AD_AuthorizationScope Configured dynamic validation filter
2021-05-12 13:42:55 +02:00
hengsin 0da2eb5bd2
IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments (#682)
- Fix cache reset and unit test bugs
2021-05-11 14:18:48 +02:00
Deepak Pansheriya 4439a74c52
IDEMPIERE-2377: Add "Prepare" Document Action to all document type (#653)
* IDEMPIERE-2377: Add "Prepare" Document Action to all document type

* IDEMPIERE-2377: Adding Prepare action on prepared docs and removeing redundent actions
Co-authored-by: carg67@gmail.com
2021-05-11 13:24:20 +02:00
Carlos Ruiz 3211c449cb
IDEMPIERE-4777 New table whose name ends in "Line" and does not have a Header table (#675) 2021-05-07 12:23:38 +02:00
hengsin a79be8aad8
IDEMPIERE-4749 Allow to use OAuth2 libraries on plugins (#668)
* IDEMPIERE-4749 Allow to use OAuth2 libraries on plugins

- move oauth libraries and dependency to target platform
- require Tycho 2.3.0+ and Eclipse 2021-03+

* IDEMPIERE-4749 Allow to use OAuth2 libraries on plugins

Fix launch configuration.
2021-04-28 14:59:50 +02:00
Carlos Ruiz d80b915836
IDEMPIERE-4372 Performance: only add log record and sql statement to context if trace/debug level <= debug/info (#665)
Revert change to assign the variable _TabInfo_SQL just on some log level
2021-04-28 11:05:09 +02:00
Carlos Ruiz 91a9314a96
IDEMPIERE-4709 Print Format Item: implement script column (expression) (#664)
Fix issue when using spaces on the name of the print format item
2021-04-23 16:15:12 +02:00
Carlos Ruiz 713aa09a46
IDEMPIERE-4709 Print Format Item: implement script column (expression) (#663)
Peer review and tests
2021-04-22 21:15:40 +02:00
igorpojzl f74e6c7824
IDEMPIERE-4709 - Print Format Item: implement script column (expression) (#644)
* IDEMPIERE-4709 - Print Format Item: implement script column (expression)

* IDEMPIERE-4709 - Translated comments

* IDEMPIERE-4709 - Check Advanced Access, Null Script before save

* IDEMPIERE-4709 - Changed Naming

Changed Naming for Scripts.

* IDEMPIERE-4709 Remove Migration script mistake

* IDEMPIERE-4709 Logic and Value Name Fixes
2021-04-22 21:13:10 +02:00
igorpojzl ad3debdd0e
IDEMPIERE-4765 IMAPS limited to GMAIL (#656)
* IDEMPIERE-4765 IMAPS limited to GMAIL

* IDEMPIERE-4765 Added IMAPHost Protocol
2021-04-22 18:56:00 +02:00
Carlos Ruiz a9b224c25d
IDEMPIERE-4762 Add AD_StorageProvider_ID to AD_Attachment (FHCA-1165) (#662) 2021-04-22 15:13:33 +02:00
Carlos Ruiz 3be5c0ac92
IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy (#660)
* IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy

* IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy

* Fix wrong selection of material date policy, must take into account isUseGuaranteeDateForMPolicy
* Fix wrong material receipt, assigning material date policy based on inventory instead of document/ASI

* * Unit tests
2021-04-21 21:42:10 +08:00
Carlos Ruiz 73f0cea85a
IDEMPIERE-3062 Unable to complete MR with qty >1 with Attribute Set of Always Mandatory (#659)
Fix wrong query on M_InoutLineMA
2021-04-21 21:39:23 +08:00
Carlos Ruiz c0927beaa4
IDEMPIERE-4763 Add IsDefault to AD_StorageProvider and use it when creating a new tenant (FHCA-1165) (#657)
* IDEMPIERE-4763 Add IsDefault to AD_StorageProvider and use it when creating a new tenant (FHCA-1165)

* Add column/field AD_StorageProvider.IsDefault
* Includes a minor refactoring of Login.loadDefault to add the ID column to the order by, to make predictable the ID returned when there are more than one record marked as default
* Context variable #AD_StorageProvider_ID is not created

* * Model class modified
2021-04-19 21:15:47 +08:00
Carlos Ruiz 9d059b13fe
IDEMPIERE-1405 Locator Dialog allows to create locators without any check (#651)
IDEMPIERE-4442 Change Locator Dialog ListBox to Tabledirect (autocomplete)
* Fix an issue not setting the new locator created when returning
2021-04-19 20:45:21 +08:00
igorpojzl c803886d25
IDEMPIERE-4760 Credit check do not allow complete Customer Return (#652) 2021-04-19 20:44:02 +08:00
Carlos Ruiz 8f31506ac7
IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments (#655)
* IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments

- Change setting for all caches to be non-distributed

* IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments

* TC-324 Fix cache related monitoring and performance issues

- PO & GridTable call to CacheMgt reset should be async.

Co-authored-by: hengsin <hengsin@gmail.com>
2021-04-19 20:41:34 +08:00
Carlos Ruiz 4de94e3d21
IDEMPIERE-4759 Method to create Trx with other Connection (FHCA-2544) (#654) 2021-04-14 16:45:24 +02:00
Carlos Ruiz ad558ed7ce
IDEMPIERE-4756 2pack import problem (#648) 2021-04-09 12:38:41 +02:00
Diego Ruiz 9742c0dbc9
IDEMPIERE-4723 - Clean up MMatch*/MMeasure*/MMenu/MMovement*/ModelVal* classes code (#645) 2021-04-09 10:00:45 +08:00
Carlos Ruiz 932ed8f498
IDEMPIERE-4727 Movement Window: a new line can be created for a movement that is completed. (#634)
* IDEMPIERE-4727 Movement Window: a new line can be created for a movement that is completed.

* IDEMPIERE-4727 Movement Window: a new line can be created for a movement that is completed.

Fix the problem also in model, to cover case when trying to add/modify lines for example via webservices

* IDEMPIERE-4727 Movement Window: a new line can be created for a movement that is completed.

Fix the problem also in model, change approach to use isProcessed instead of isComplete
2021-04-08 22:40:27 +08:00
hengsin b22ceeabdf
IDEMPIERE-4747 Pass PO object from MWFProcess to MWFActivity (#646)
Fix unit test error.
2021-04-08 21:20:49 +08:00
igorpojzl cb53fbcce0
IDEMPIERE-4747 Pass PO object from MWFProcess to MWFActivity (#641) 2021-04-08 18:11:28 +08:00
Carlos Ruiz 1a5eb5ce22
IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex (#640)
* IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex

* Implementing suggestion from Andreas Sumerauer
* Fix issue in IDEMPIERE-3916 (Move Client) and IDEMPIERE-1026 (Create Window from Table)

* IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex

* Change approach to discover real columns

* * Rename method as suggested by Andreas Sumerauer
2021-04-07 21:34:37 +08:00
Diego Ruiz 7d1fec61fb
IDEMPIERE-4723 - Clean up MIssue*/MJournal*/MLandedC*/MLanguage/MLdapProcessor/Mloc*/MLookip*/Mlot* classes code (#635) 2021-03-23 10:19:34 +08:00
Carlos Ruiz c8fd9a8805
IDEMPIERE-4736 FHCA-2461 IDEMP - ad_column table - Framework query improvement (#628)
* IDEMPIERE-4736 FHCA-2461 IDEMP - ad_column table - Framework query improvement

* * Rename migration scripts to normal convention
2021-03-16 17:03:40 +08:00
Diego Ruiz 86bbb08bff
IDEMPIERE-4723 - Clean up MInOut*/MInterest* classes code (#632) 2021-03-16 08:30:23 +08:00
Elaine Tan 27f21e0384
IDEMPIERE-4696 Wrong GL Currency Balancing in payment allocation for payment reverse/accrual (#621)
* IDEMPIERE-4696 Wrong GL Currency Balancing in payment allocation for payment reverse/accrual
2021-03-15 21:18:25 +08:00
Diego Ruiz 61478ad594
IDEMPIERE-4723 - Clean up dead code on MInvoice*/MInventory* classes (#625)
* IDEMPIERE-4723 - Clean up dead code on MInvoice*/MInventory* classes

* IDEMPIERE-4723 - Clean up useless if in MInvoiceLine
2021-03-15 17:43:02 +08:00
Carlos Ruiz bef5e5ed3f
IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system) (#630)
* Fix hardcoded reference to EMail scope in the processToken method
2021-03-12 18:11:22 +01:00
Carlos Ruiz 2e4daa8930
IDEMPIERE-4566 Translation Import/Export - output message is not visible (#624)
* Fix problem with wrong management of parameters when changing from Import to Export
* Delete the deprecated class, this is unused (IDEMPIERE-4723)
2021-03-12 10:45:39 +01:00
Elaine Tan c7854316be
IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line (#619)
* IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line
2021-03-10 18:09:13 +08:00
Diego Ruiz e7681a767a
IDEMPIERE-4723 - Clean up dead code on MOrder* classes (#620) 2021-03-10 17:56:24 +08:00
Carlos Ruiz 14d982abae
IDEMPIERE-4714 email password changes being displayed in the change log (#615)
* IDEMPIERE-4714 email password changes being displayed in the change log

* * minor fix adding a line to script
2021-03-09 15:00:12 +08:00
Carlos Ruiz 5f2d71347d
IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system) (#593)
* IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system)

WIP - initial version working on zk with google apps mail using OAuth2 Authorization Code Flow and Client Type = web application

* Enable imap reading with OAuth2 in RequestEMailProcessor
* Simplify the code - tested plain and OAuth2 can use the same methods
* Add +SCOPE parameter to AddAuthorizationForm according to IDEMPIERE-4713
* Rename the form AddAuthorizationMailForm to AddAuthorizationForm as is now more generic

* IDEMPIERE-4713
* Rename migration scripts to make it newer than IDEMPIERE-4713
* Add list of scopes attended by a credential
* Change form to accept other scopes, if no scope parameter is passed, then a list is shown, change the menu to fix the EMail scope
* Add MAuthorizationAccount.refreshAndGetAccessToken
* Add translation for messages

* make call generic oauth, avoid using specific google API

* Tests with microsoft as OAuth2 provider
* Add record for microsoft as provider
* Increase size of tokens
* Define mandatory and secure columns
* Update refresh token when it comes on the refresh call
* Revoke endpoint is optional

* Change the approach to a process instead of a form (WIP)
* Implement servlet to process the OAuth2 code

* Solve context suggestion from hengsin

* Implement the form in an automatic popup approach for running on zkwebui

* i18n - add translations for all messages that are shown to user
* on the form opted for click to avoid the problem with browsers forbidding popups
* clean spaces and tabs on line endings

* avoid logging and copy of the secure columns

* Fix problem reported by @d-ruiz about hidden NPE when SMTP Authentication is disabled

* Add writing to AD_PInstance_Para and AD_PInstance_Log the results of processing the servlet
* Control to avoid using the same authorization URL twice
2021-03-06 11:49:39 +01:00
hengsin 1971b4f0dc
IDEMPIERE-4488 Remove .classpath from repository (#607)
* IDEMPIERE-4488 Remove .classpath from repository

* IDEMPIERE-4488 Remove .classpath from repository

add ignore for .classpath

* IDEMPIERE-4488 Remove .classpath from repository

remove ".settings/org.eclipse.jdt.core.prefs"

* IDEMPIERE-4488 Remove .classpath from repository

fix false status report for /bin and .project
2021-03-03 00:02:03 +01:00
Carlos Ruiz 47f7180eff
IDEMPIERE-4713 Allow definition of context variables to inject on menu and window definition (#600)
* IDEMPIERE-4713 Allow definition of context variables to inject on menu and window definition

* * Implement prefix "+" as suggested by @hengsin
* Clear the variable

* * Fix scope of methods and fix interface as suggested by @hengsin

* * Implement changes suggested by @hengsin
* Add control for clicking on new button on Favourites and menu
2021-02-23 16:24:39 +01:00
Carlos Ruiz ed68a01c74
IDEMPIERE-4710 NPE in ProcessInfo.getLastServerRebootDate() (#603)
* Add logging for possible severe issue
2021-02-23 13:04:39 +08:00
Nicolas Micoud bd7600fcd9
IDEMPIERE-4710 : NPE in ProcessInfo.getLastServerRebootDate() (#597) 2021-02-22 10:56:32 +08:00
Carlos Ruiz d188e563fc
IDEMPIERE-4358 Rename table issue (#590)
* IDEMPIERE-4358 Rename table issue

Rename the table also in whereclause and orderbyclause in AD_Tab and AD_Ref_Table

* * Fix issue with Sequence reported by @d-ruiz
* Improve log messages

* * Improve reference message
2021-02-19 17:52:33 +01:00
Nicolas Micoud a292fea5d9
IDEMPIERE-4712 : set MInvoice setReversal(boolean) method public (#598) 2021-02-19 22:05:16 +08:00
hengsin b1d3f9c8fd
IDEMPIERE-4705 Add grid toggle button to Detail Pane (#594) 2021-02-18 19:38:46 +01:00
hengsin 4ebf81b1d2
IDEMPIERE-4704 Add base interface and class that uses generic type and lambda function for osgi factory that create new instance by class name or a string key (#595)
Fix unit test error when running through maven/jenkin (mvn verify
-DskipTests=false)
2021-02-18 18:22:07 +01:00
Deepak Pansheriya 5ca8d44d48
IDEMPIERE-4606: Adding support for generic method to get model using … (#580)
* IDEMPIERE-4606: Adding support for generic method to get model using UUID

* IDEMPIERE-4606: Refactoring as per Hengsin's review comment.

* IDEMPIERE-4606: reverting issue in IMappedModelFactory.

* IDEMPIERE-4606: Fixing compilation errors

* IDEMPIERE-4606: Resetting ModelFactory Class to original, removed instance variable m_uuid and used to pass UU.

* IDEMPIERE-4606: Dropping constructor with UU argument from PO class.

* IDEMPIERE-4606: Refactoring as per Hengsin's feedback

* IDEMPIERE-4606: Correcting Java doc and updating serialized version.

* IDEMPIERE-4606: Fixing uuID passing

* IDEMPIERE-4606: Moving check for blank argument at top
2021-02-17 12:46:51 +08:00
hengsin 5e60c443d2
IDEMPIERE-4704 Add base interface and class that uses generic type and lambda function for osgi factory that create new instance by class name or a string key (#585) 2021-02-16 11:24:31 +01:00
hengsin 4b20720932
IDEMPIERE-4690 Add column callout factory base class backed by Map and Lambda functional object (#587)
Refactoring. Add unit test for gridtab and callout.
2021-02-16 11:20:42 +01:00
hengsin c91a13ee88
IDEMPIERE-4681 Can't use hidden column in display logic (#561)
* IDEMPIERE-4681 Can't use hidden column in display logic

* IDEMPIERE-4681 Can't use hidden column in display logic

handle @ColumnName:0@ and @ColumnName.xyz@
2021-02-16 11:14:30 +01:00
Diego Ruiz 51a081cbe7
IDEMPIERE-4701 Env.parseVariable is parsing boolean values wrong (#582) 2021-02-12 15:58:40 +01:00
Carlos Ruiz 92195c08a4
IDEMPIERE-4693 2Pack Hangs in 7.1+ / IDEMPIERE-2767 (#570)
* IDEMPIERE-4693 2Pack Hangs in 7.1+ / IDEMPIERE-2767

* Decrease log level to INFO

* Add javadoc note
2021-02-11 04:33:19 +08:00
hengsin ee77620186
IDEMPIERE-4694 Implement thread safe, annotation based osgi event han… (#571)
* IDEMPIERE-4694 Implement thread safe, annotation based osgi event handling

Make sure the component register in the event handler unit test cases
wouldn't have impact on other unit test cases.
2021-02-10 16:12:16 +01:00
hengsin c757fbaab7
IDEMPIERE-4695 Add document factory base class backed by Map and Lambda functional object (#576)
MappedDocumentFactoryTest fail when running idempiere.unit.test due to
document factory cache.
2021-02-10 16:02:13 +01:00
Martin Schönbeck 5e31c1fdb0
IDEMPIERE-4688 Adding Customs Tariff Number to products (#568)
* group1 and group2 also added to i_product
* Models generated for m_product and i_product, creating m_product from i_product extended with new fields.
2021-02-09 21:09:04 +01:00
Carlos Ruiz 79a3cd8c52
IDEMPIERE-4698 Load/Import Bank Statement issues (#573) 2021-02-09 20:11:00 +01:00
hengsin c159ce5325
IDEMPIERE-4695 Add document factory base class backed by Map and Lambda functional object (#572) 2021-02-09 19:17:15 +01:00
Nicolas Micoud 91fb2dacb9
IDEMPIERE-4683 : Report : missing logo for PDF output (#562) 2021-02-08 17:29:30 +01:00
hengsin ddd1c40eb2
IDEMPIERE-4690 Add column callout factory base class backed by Map an… (#567)
* IDEMPIERE-4690 Add column callout factory base class backed by Map and Lambda functional object

Fix column callout factory cache.

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-02-06 14:53:59 +01:00
hengsin 1c5a28aa0a
IDEMPIERE-4689 Add process factory base class backed by Map and Lambda functional object (#566) 2021-02-06 14:37:04 +01:00
Deepak Pansheriya 373225a62c
Idempiere 3340 (#505)
* IDEMPIERE-3340 : User favorite with tree structure

* IDEMPIERE-3340: Marking write operation to safe for cross tenant safe

* IDEMPIERE-3340: Fixing Cross tenant access issue

* IDEMPIERE-3340: refactoring as review comment, Fixing renaming folder issue, Auto launch window shows all items irrespective of access

* Sync with IDEMPIERE-4251

* Sync with IDEMPIERE-4251

* IDEMPIERE-3340: Refactoring as review comment for caching,
 toolbar button restriction method with ID, tooltip messages, font base theme,
 remove double click event, etc.

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-02-04 21:36:25 +01:00
hengsin 0f263f1c79
IDEMPIERE-4675 Add model factory base class backed by Map and Lambda … (#555)
- added interface and default mapped model factory service
- added unit test for default mapped model factory service
2021-02-01 15:29:13 +01:00
hengsin 4009c9c8ca
IDEMPIERE-4679 SvrProcess: ensure unlock and flushBufferLog happens after transaction commit and close (#560) 2021-02-01 15:25:34 +01:00
Carlos Ruiz e20e195c57
IDEMPIERE-4685 Cross tenant PO reading request detected from session for table AD_User Record_ID (#563) 2021-02-01 16:15:59 +08:00
Carlos Ruiz fd3fef9e7b
IDEMPIERE-4678 Save log informing Notice created when background job (#559)
* IDEMPIERE-4678 Save log informing Notice created when background job

* Added also a refactor for the INSERT INTO AD_PInstance_Log to use safer binding variables and add method saveEx

* - Implement suggestions from @hengsin
- Add some additional improvements
2021-01-29 08:57:15 +08:00
Carlos Ruiz 4493373b96
IDEMPIERE-4673 PackOut fails to export attachments with File storage provider (#554)
* IDEMPIERE-4673 PackOut fails to export attachments with File storage provider

* Implement similar solution for Image and Archive

* Simplify the nested ifs

Change approach for MAttachment as is not working for Data Single
2021-01-28 20:10:02 +08:00
Nicolas Micoud e32f971587
IDEMPIERE-4677 : Cross Tenant issues with AD_User/Role_OrgAccess (#556) 2021-01-28 12:42:00 +01:00
hengsin f5e9cd9336
IDEMPIERE-4654 Sales Order After Receipt Delivery Rule is not working (#536)
* IDEMPIERE-4654 Sales Order After Receipt Delivery Rule is not working

create shipment if it is fully paid and stock is available
use currencyconvertpayment
- rename after receipt to after payment
- added unit test for invoice payment

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-01-26 19:34:38 +08:00
Diego Ruiz 245b471d06
IDEMPIERE-4672 Improve the StatusBar Menupopup to render HTML text (#553) 2021-01-25 17:01:14 +01:00
hengsin f233e29432
IDEMPIERE-4662 Some problems of sort at window before save (#551)
* IDEMPIERE-4662 Some problems of sort at window before save

* IDEMPIERE-4662 Some problems of sort at window before save

Fixed the sequence of edit field -> sort -> edit field will wrongly
trigger save automatically.
2021-01-25 09:31:21 +01:00
hengsin 9370dbb77e
IDEMPIERE-4659 MStorageOnHand and MStorageReservation api improvements (#545) 2021-01-24 17:30:51 +01:00
hengsin 0046696a38
IDEMPIERE-4666 Close is an invalid Document Action for Draft, Invalid and In Progress Order (#547) 2021-01-24 17:25:54 +01:00
hengsin 72d66b8868
IDEMPIERE-4667 Project can not be printed using template print format (#550) 2021-01-24 17:13:47 +01:00
Carlos Ruiz 6c9e957e81
IDEMPIERE-4664 Cross tenant issue sending email with a System template (#543) 2021-01-22 13:16:36 +08:00
Carlos Ruiz 2d76f90f9c
IDEMPIERE-4660 Wrong code in virtual columns broke IDEMPIERE-2356 (#541)
IDEMPIERE-4087
IDEMPIERE-3760
2021-01-21 14:28:15 +01:00
Elaine Tan f3741b8f31
IDEMPIERE-4656 Incorrect rate in the MR postings when the currency type of the order is 'Company' (#537)
* IDEMPIERE-4656 Incorrect rate in the MR postings when the currency type of the order is 'Company'
2021-01-21 11:58:50 +08:00
Carlos Ruiz 24ccb86f16
IDEMPIERE-4653 Improve timeout handling of window tab (#539)
* IDEMPIERE-4653 Improve timeout handling of window tab

* Fixed a problem with IDEMPIERE-4130 that was not using role max query records
* GridTable was throwing NPEs because the arrays were disposed before closing
* Lowered log level on MRole to avoid clogging the console (I was testing with INFO level)
* Added more points of control for the timeout exception to give meaningful errors to the user and allow refining the query without closing the Find dialog
* Implemented a control to avoid repeating a slow initial query every time the dialog is open
* Added dialog when the find criteria doesn't return rows and allows the user to refine the query
* When the initial number of records is unknown, show a question mark instead of the count

* * Fix wrong role level pushed in first commit
2021-01-20 21:45:33 +08:00
hengsin e1ba21360f
IDEMPIERE-4653 Improve timeout handling of window tab (#534)
* IDEMPIERE-4653 Improve timeout handling of window tab

* IDEMPIERE-4653 Improve timeout handling of window tab

Fix error with find and refresh.
2021-01-20 13:27:58 +01:00
hengsin 59b83c3361
IDEMPIERE-4628 Implement configurable query timeout for info window (#532)
* IDEMPIERE-4628 Implement configurable query timeout for info window

* IDEMPIERE-4628 Implement configurable query timeout for info window

Move migration script from i8.2z to i8.2
2021-01-19 10:25:13 +08:00
hengsin 1afe4fe0c6
IDEMPIERE-4652 Remove Eclipse warnings (#533) 2021-01-18 17:32:25 +01:00
Carlos Ruiz 0cfa1c182a
IDEMPIERE-4650 Problems with Language Management in PO (#530)
* IDEMPIERE-4650 Problems with Language Management in PO

* * Set GardenWorld to use multi-lingual documents
2021-01-18 19:57:33 +08:00
hengsin ebcf4b3e1c
IDEMPIERE-4651 Max records for Search autocomplete list should be configurable (#531) 2021-01-18 11:52:12 +01:00
Carlos Ruiz fa8b7f1807
IDEMPIERE-4645 Search by special field types failing (#524)
* IDEMPIERE-4645 Search by special field types failing

* Set the advanced operators for Search for the special cases
2021-01-17 18:05:06 +08:00
Carlos Ruiz 0e366c9929
IDEMPIERE-4649 NPE when running Change base language with a fake language (as instructed) (#529) 2021-01-16 09:46:31 +08:00
Carlos Ruiz a1f39f9506
IDEMPIERE-4641 AD_ProcessPara.DisplayLogic is not accepting @Value_ID.ForeignColumn@ notation (#520) 2021-01-12 21:33:48 +08:00
Carlos Ruiz 402300a53e
IDEMPIERE-4639 Cross tenant issues with context help (#522) 2021-01-12 21:31:40 +08:00
hengsin d96199a2b6
IDEMPIERE-4251 Constant definition for all Env Context (#519)
* IDEMPIERE-4251 Constant definition for all Env Context

replace "#Date" with Env.DATE

* IDEMPIERE-4251 Constant definition for all Env Context

replace "#.." with constant at Env

* IDEMPIERE-4251 Constant definition for all Env Context

Merge patch from Carlos
2021-01-12 21:29:50 +08:00
Deepak Pansheriya e4ee47f92d
IDEMPIERE-4643: Cross Tenant issue when completing Requisition (#521) 2021-01-12 11:37:06 +01:00
igorpojzl b71e53e81c
IDEMPIERE-4637 Cross Tenant RMA, Tax Rate issue (#517) 2021-01-08 16:58:29 +01:00
Nicolas Micoud 326d210665
IDEMPIERE-4616 : Lead : add IsVendorLead (#500)
* IDEMPIERE-4616 : Lead : add IsVendorLead

* IDEMPIERE-4616 : Lead : add IsVendorLead

Fix description for Lead window
Add Display Logic for Opportunity parameters (now hidden if no opportunity)
Set BPartner.IsCustomer/IsVendor according to Lead.IsSales/VendorLead

* IDEMPIERE-4616 : Lead : add IsVendorLead

Move scripts from 8.2 to 8.2z
2021-01-07 18:48:25 +01:00
igorpojzl ba63dc4960
IDEMPIERE-4622 Cross Tenant UserDefInfo, Role (#503)
* IDEMPIERE-4622  Cross Tenant UserDefInfo, Role
2021-01-07 11:27:41 +01:00
Diego Ruiz 1d40ac7d6e
IDEMPIERE-4632 Print Invoices is not translating the invoice if the r… (#512)
* IDEMPIERE-4632 Print Invoices is not translating the invoice if the report is a Jasper Report

* IDEMPIERE-4632 Print Invoices is not translating the invoice if the report is a Jasper Report
2021-01-06 17:13:08 +01:00
Carlos Ruiz 2cfb699c6f
IDEMPIERE-4631 Lead window -> NPE GridFieldVO.loadLookupInfo: No LookupInfo for BP_Location_ID (#511) 2021-01-06 15:22:33 +01:00
Carlos Ruiz 05a7222828
IDEMPIERE-4602 Encrypt passwords on properties files (FHCA-1982) (#508)
Implement suggestions from Hiep
2021-01-06 12:12:09 +01:00
hengsin 3af7bc1351
IDEMPIERE-4626 Error message when opening FindWindow in Invoice(Custo… (#507)
* IDEMPIERE-4626 Error message when opening FindWindow in Invoice(Customer)

add Payment displaytype to isList

* IDEMPIERE-4626 Error message when opening FindWindow in Invoice(Customer)

merge suggestion from Carlos
2021-01-05 15:40:37 +01:00
Carlos Ruiz 47aee6fb02
IDEMPIERE-4602 Encrypt passwords on properties files (FHCA-1982) (#498)
* backward compatible with the previous idempiere.properties and idempiereEnv.properties version
* when the setup/console-setup is executed again the secret keys are stored obfuscated in a different file .idpass
  * Secret keys are ADEMPIERE_DB_PASSWORD, ADEMPIERE_DB_SYSTEM, ADEMPIERE_MAIL_PASSWORD
  * to add more is just adding keys to array ConfigurationData.secretVars
* the previous (unobfuscated) approach is still preserved passing -DIDEMPIERE_SECURE_PROPERTIES=false to the JVM in setup and server
* the approach just run on Linux - as is implemented using shell script, windows is out of the initial scope, but could be possible to implement .bat files to do similar
* the default approach is to use getVar.sh and setVar.sh that writes in .idpass obfuscated
  * is possible to extend and use custom secret managers implementing customSetVar.sh and customGetVar.sh
  * samples for amazon AWS secretsmanager are included
* avoid the email sent on setup sending the secret keys
* enclose all variables in myEnvironment.sh within quotes (this avoids problems with variables containing spaces)
* add coreutils as required for debian installer (as we use base64 now to obfuscate passwords)
* swing client is not affected as it saves the idempiere.properties encrypted in user home folder
2021-01-03 22:19:49 +08:00
Carlos Ruiz 11dc7a391f
IDEMPIERE-4623 Cash POS Sales Order is leaving wrong BP balance (#504) 2021-01-03 20:08:16 +08:00
hengsin 12009bf670
IDEMPIERE-4615 Cross Tenant Workflow Node cause - Cross tenant PO issue (#496) 2021-01-02 18:17:10 +01:00
igorpojzl afde8a0cf1
IDEMPIERE-4621 Cross Tenant Parent Tax Error (#502)
* IDEMPIERE-4621  Cross Tenant Parent Tax Error

* IDEMPIERE-4621 Add CLient Check on getTaxNodes
2020-12-31 20:21:04 +08:00
hengsin aa29cb6d7c
IDEMPIERE-4614 Reimplement Read Replica PreparedStatement using dynamic proxy (#491) 2020-12-30 15:07:27 +01:00
Carlos Ruiz 055ad2f0ae
IDEMPIERE-4619 Improve CLogger fallback when reaching 100 files in /log folder (#492) 2020-12-30 20:22:36 +08:00
Diego Ruiz da6d6b83aa
IDEMPIERE-4607 Cannot export windows via 2pack if any field has a Fie… (#483)
* IDEMPIERE-4607 Cannot export windows via 2pack if any field has a Field Group

* IDEMPIERE-4607 Implement changes discussed in JIRA - Add a new isList method to DisplayType

* IDEMPIERE-4607 Fixed typo

* IDEMPIERE-4607 Implement default method to return false by default - PR CarlosRuiz
2020-12-26 16:35:50 +01:00
Carlos Ruiz 8103ab0732 IDEMPIERE-4604 Release 8.2
Change references to new version
Create new migration folder
2020-12-20 10:15:20 +01:00
Carlos Ruiz 6390ce20cd IDEMPIERE-4604 Release 8.2
Fix warnings on MANIFEST.MF
2020-12-20 09:53:21 +01:00
Carlos Ruiz 3b1e4f2735 IDEMPIERE-4604 Release 8.2
Model generate classes
2020-12-20 09:51:58 +01:00
Carlos Ruiz 00a08236fc IDEMPIERE-4604 Release 8.2
Credits and version number
2020-12-20 09:25:13 +01:00
hengsin b80ed34d9c
IDEMPIERE-4599 Remove obsolete org.compiere.interfaces.* interface (#473)
* IDEMPIERE-4599 Remove obsolete org.compiere.interfaces.* interface

* IDEMPIERE-4599 Remove obsolete org.compiere.interfaces.* interface

remove warning.
2020-12-18 14:52:11 +01:00
Carlos Ruiz 2ab2211f81
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#468)
Extracting from @hengsin pull request 465
Fixes cross tenant readings in MUser MUserDefWin and MWorkflow
2020-12-16 09:08:11 +08:00
hengsin 1df6f63341
IDEMPIERE-4598 Disable obsolete IsServer* fields (#467)
* IDEMPIERE-4598 Disable obsolete IsServer* fields

* IDEMPIERE-4598 Disable obsolete IsServer* fields

- Fix wrong migration script name
2020-12-14 15:10:29 +01:00
hengsin 5e977d427c
IDEMPIERE-4287 Cache API not thread safe and inconsistent with context parameter (#466)
- Fix PO immutable exception with Workflow Validate process.
2020-12-14 14:53:55 +01:00
Carlos Ruiz fd947f4fef
IDEMPIERE-4581 Model generator should isn't dialog it should be window (#463)
* IDEMPIERE-4581 Model generator should isn't dialog it should be window

use shutdown asyn to shutdown framework when close Model generator window

one unhappy thing remain:
when use -console then framework is shutdown but jdk still hang because "pipe-gosh --login --noshutdown" still live (for https://bugs.eclipse.org/bugs/show_bug.cgi?id=362412)
work-around: use -console 1234
by that way we can't access osgi command from console but can use "telnet localhost 1234" to use osgi command

* IDEMPIERE-4581 Model generator should isn't dialog it should be window

Fix problem about program not closing
Improve layout

Co-authored-by: hieplq <hieplq@hasuvimex.vn>
2020-12-13 07:57:33 +08:00
Carlos Ruiz 5da1785572
IDEMPIERE-4596 Cannot create a product and an inventory document in t… (#459)
* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction

WIP - commit failing unit test

* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction

Implement solution suggested by @hengsin

* minor fix comment
2020-12-12 16:12:31 +01:00
Carlos Ruiz 9d6de521f2
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#456)
Extracting from @hengsin pull request 453
2020-12-11 16:48:16 +08:00
Carlos Ruiz f2c5ec429b
IDEMPIERE-4589 BUGS on PERFORMANCE ANALYSIS -> Accounting Rules ->Accounting Setup (#457) 2020-12-11 14:40:58 +08:00
Carlos Ruiz 4d96ac1f8e
IDEMPIERE-4593 Error completing a Standard Sales Order with Shipper and Calculated Freight Cost Rule (#454) 2020-12-10 13:57:25 +01:00
Carlos Ruiz 6fa0052834
IDEMPIERE-4588 Error in MOrder.setC_DocTypeTarget_ID (String DocSubTypeSO_x) when IsDefault=Y in a Purchase Order (#446) 2020-12-09 20:49:15 +01:00
Carlos Ruiz d654ed5791
IDEMPIERE-4587 Wrong ordered qty when reactivating a purchase order and setting a line to zero (#445) 2020-12-09 20:49:01 +01:00
Carlos Ruiz 34fec8c156
IDEMPIERE-4591 Load Bank Statement is not working in multi-tenant environments (#450)
IDEMPIERE-4268
2020-12-09 19:00:41 +01:00
Carlos Ruiz 46bc0e022f
IDEMPIERE-4358 Processes to drop some objects from database (#448)
Add process to rename a column directly from the Table and Column window
2020-12-09 15:31:13 +01:00
Carlos Ruiz 4c66c0018d
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#443)
Implement thread safe mechanism
https://mattermost.idempiere.org/idempiere/pl/hmpd8freutbhbgcjr9tu6ntitr
2020-12-09 14:28:49 +01:00
Carlos Ruiz 416d92a292
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#441)
Fix problem reported by ken.wang at
https://mattermost.idempiere.org/idempiere/pl/3wmpzg1o5i88dec5pifkjd3qfe
2020-12-07 22:59:23 +08:00