midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-5103 Clear Parent Tax ID if a Tax Rate record is Summary (#1056)

This commit is contained in:
hengsin 2021-12-18 02:25:40 +08:00 committed by GitHub
parent 160db45e84
commit 95924e8578
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 68 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
org.adempiere.base/src/org/compiere/model/MTax.java
View File

@ -381,7 +381,11 @@ public class MTax extends X_C_Tax implements ImmutablePOSupport
if (getTo_Country_ID() > 0 && getC_CountryGroupTo_ID() > 0) {
setTo_Country_ID(0);
}
if (isSummary()) {
if (getParent_Tax_ID() > 0) {
setParent_Tax_ID(0);
}
}
return super.beforeSave(newRecord);
}

63
org.idempiere.test/src/org/idempiere/test/model/MTaxTest.java Normal file
View File

@ -0,0 +1,63 @@
/***********************************************************************
* This file is part of iDempiere ERP Open Source *
* http://www.idempiere.org *
* *
* Copyright (C) Contributors *
* *
* This program is free software; you can redistribute it and/or *
* modify it under the terms of the GNU General Public License *
* as published by the Free Software Foundation; either version 2 *
* of the License, or (at your option) any later version. *
* *
* This program is distributed in the hope that it will be useful, *
* but WITHOUT ANY WARRANTY; without even the implied warranty of *
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the *
* GNU General Public License for more details. *
* *
* You should have received a copy of the GNU General Public License *
* along with this program; if not, write to the Free Software *
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, *
* MA 02110-1301, USA. *
* *
* Contributors: *
* - hengsin *
**********************************************************************/
package org.idempiere.test.model;
import static org.junit.jupiter.api.Assertions.assertEquals;
import org.compiere.model.MTax;
import org.compiere.util.Env;
import org.compiere.util.TimeUtil;
import org.idempiere.test.AbstractTestCase;
import org.junit.jupiter.api.Test;
/**
*
* @author hengsin
*
*/
public class MTaxTest extends AbstractTestCase {
private static final int STANDARD_TAX_ID = 104;
private static final int STANDARD_TAX_CATEGORY_ID=107;
public MTaxTest() {
}
@Test
public void testClearParentTaxId() {
MTax tax = new MTax(Env.getCtx(), 0, getTrxName());
tax.setName("testClearParentTaxId");
tax.setParent_Tax_ID(STANDARD_TAX_ID);
tax.setValidFrom(TimeUtil.getDay(null));
tax.setIsSummary(false);
tax.setC_TaxCategory_ID(STANDARD_TAX_CATEGORY_ID);
tax.saveEx();
assertEquals(STANDARD_TAX_ID, tax.getParent_Tax_ID(), "Unexpected parent tax id");
tax.setIsSummary(true);
tax.saveEx();
assertEquals(0, tax.getParent_Tax_ID(), "Unexpected parent tax id");
}
}