midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-4849: fix for MProduction.createLines() storage issue (#743) 

* fix for MProduction.createLines/( storage issue

* extended if clause to cover storage lines with the same AsiID

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
This commit is contained in:
Andreas Sumerauer 2021-06-26 07:18:54 +02:00 committed by GitHub
parent 0bb5aa70f6
commit 73b389652f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
org.adempiere.base/src/org/compiere/model/MProduction.java
View File

@ -254,8 +254,6 @@ public class MProduction extends X_M_Production implements DocAction {
int M_Warehouse_ID = finishedLocator.getM_Warehouse_ID();
int asi = 0;
// products used in production
String sql = "SELECT M_ProductBom_ID, BOMQty" + " FROM M_Product_BOM"
+ " WHERE M_Product_ID=" + finishedProduct.getM_Product_ID() + " ORDER BY Line";
@ -339,6 +337,7 @@ public class MProduction extends X_M_Production implements DocAction {
MProductionLine BOMLine = null;
int prevLoc = -1;
int previousAttribSet = -1;
int prevAsi = -1;
// Create lines from storage until qty is reached
for (int sl = 0; sl < storages.length; sl++) {
@ -350,11 +349,11 @@ public class MProduction extends X_M_Production implements DocAction {
int loc = storages[sl].getM_Locator_ID();
int slASI = storages[sl].getM_AttributeSetInstance_ID();
int locAttribSet = new MAttributeSetInstance(getCtx(), asi,
int locAttribSet = new MAttributeSetInstance(getCtx(), slASI,
get_TrxName()).getM_AttributeSet_ID();
// roll up costing attributes if in the same locator
if (locAttribSet == 0 && previousAttribSet == 0
if (((locAttribSet == 0 && previousAttribSet == 0) || (slASI == prevAsi))
&& prevLoc == loc) {
BOMLine.setQtyUsed(BOMLine.getQtyUsed()
.add(lineQty));
@ -379,6 +378,7 @@ public class MProduction extends X_M_Production implements DocAction {
}
prevLoc = loc;
previousAttribSet = locAttribSet;
prevAsi = slASI;
// enough ?
BOMMovementQty = BOMMovementQty.subtract(lineQty);
if (BOMMovementQty.signum() == 0)