Commit Graph

3204 Commits

Author SHA1 Message Date
hengsin 93bc73c257
IDEMPIERE-4865 Find window enhancements (#766) 2021-07-05 20:37:28 +02:00
hengsin d7c0ebf980
IDEMPIERE-2682 Html Report >> locking/freeze header row (#761)
* IDEMPIERE-2682 Html Report >> locking/freeze header row

Fix printing
2021-07-05 20:24:42 +02:00
Diego Ruiz a74694f81e
IDEMPIERE-4723 - Clean up dead code -> MC* classes (#762) 2021-07-05 19:51:58 +08:00
Nicolas Micoud fbc4feaf08
IDEMPIERE-4860 : MRole.updateAccessRecords insert active records based on deactivated objects (#758) 2021-07-02 10:33:35 +08:00
Nicolas Micoud ffc9bf12fb
IDEMPIERE-4861 : GenerateModel / Reference List / Use Value for ordering (#759) 2021-07-02 10:31:21 +08:00
Carlos Ruiz 361edea318
IDEMPIERE-4578 generic DocAction (#736)
* IDEMPIERE-4578 generic DocAction

* IDEMPIERE-4578 generic DocAction

* IDEMPIERE-4578 generic DocAction

Refactor generic docaction implementation to a separate delegate class.
This should make it easier for any model class to implement the
DocAction interface using the DocActionDelegate class.

* IDEMPIERE-4578 generic DocAction

add generic type support

* IDEMPIERE-4578 generic DocAction

generic type should implements DocAction

* IDEMPIERE-4578 generic DocAction

Co-authored-by: hengsin <hengsin@gmail.com>
2021-07-02 10:25:30 +08:00
Carlos Ruiz 0e58005d6f
IDEMPIERE-4853 Process to copy a Packout definition (FHCA-859) (#756)
* IDEMPIERE-4853 Process to copy a Packout definition (FHCA-859)

* IDEMPIERE-4853 Process to copy a Packout definition (FHCA-859)

Do not copy inactive details (as suggested by hengsin)
2021-07-01 22:14:46 +08:00
hengsin 10812c486d
IDEMPIERE-4824 Boolean Logic Expression Enhancements (#748)
* IDEMPIERE-4824 Boolean Logic Expression Enhancements

Fix comparison operator not working for timestamp value
2021-06-29 16:36:50 +02:00
hengsin c33d0528a7
IDEMPIERE-4850 JasperReport: Implement ResourceBundle backed by AD_Message and AD_Element (#747)
* IDEMPIERE-4850 JasperReport: Implement ResourceBundle backed by AD_Message and AD_Element
2021-06-29 12:20:11 +02:00
Nicolas Micoud 0e6e5efc7d
IDEMPIERE-4829 - Add SeqNoGrid on UserDefWindow (#718)
* IDEMPIERE-4829 - Add SeqNoGrid on UserDefWindow

* IDEMPIERE-4829 : scripts moved to i8.2z
2021-06-28 16:11:42 +02:00
Nicolas Micoud e813d2cca4
IDEMPIERE-4843 : MInvoice.setBPartner method retrieves inactive contacts (#744) 2021-06-28 16:04:57 +02:00
hengsin adc9999d89
IDEMPIERE-2937 Html Report - Suppress Null checkbox doesn't work (#734) 2021-06-28 13:54:33 +02:00
hengsin df704cb236
IDEMPIERE-4227 Unable to use 2 print format item with the same AD_Column_ID and different formatting (#740)
* IDEMPIERE-4227 Unable to use 2 print format item with the same AD_Column_ID and different formatting

Fix function column
2021-06-28 13:47:20 +02:00
Andreas Sumerauer 0bfeb8c0b0
IDEMPIERE-4847 TableIndexValidate: include only active columns in table index (#741)
* TableIndexValidate: include only active columns in table index

* simplified MTableIndex.getColumns()

* MTableIndex.createDDL() - restored space positioning

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-06-26 19:32:50 +08:00
Andreas Sumerauer 73b389652f
IDEMPIERE-4849: fix for MProduction.createLines() storage issue (#743)
* fix for MProduction.createLines/( storage issue

* extended if clause to cover storage lines with the same AsiID

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-06-26 13:18:54 +08:00
hengsin ded9693163
IDEMPIERE-4835 Grid View: Implement optional hide empty column feature (#727)
* IDEMPIERE-4835 Grid View: Implement optional hide empty column feature

* IDEMPIERE-4835 Grid View: Implement optional hide empty column feature

- fix issue with save width saving 0px width to
ad_tab_customization.custom
- added ad_tab_customization.IsAutoHideEmptyColumn
2021-06-19 09:24:08 +02:00
hengsin d832d1f352
IDEMPIERE-4565 Report (XLSX output) : add header (#729)
sync xls and xlsx output
2021-06-18 22:22:36 +02:00
Diego Ruiz d5845fcffe
IDEMPIERE-4723 - Clean up dead code -> MA*/MB* classes (#726) 2021-06-18 10:34:11 +08:00
Nicolas Micoud 715bf4f856
IDEMPIERE-4833 : Impossible to display a report based on a table when no parameter (#721) 2021-06-16 15:30:09 +08:00
Diego Ruiz 756cf807f2
IDEMPIERE-4743 - Clean up dead code (#722) 2021-06-16 15:10:41 +08:00
hengsin e7ea517b99
IDEMPIERE-4824 Boolean Logic Expression Enhancements (#717)
Regenerated source with correct antlr4 version to remove deprecation
warnings.
2021-06-11 17:14:49 +08:00
hengsin d7153575e6
IDEMPIERE-4824 Boolean Logic Expression Enhancements (#716)
* IDEMPIERE-4824 Boolean Logic Expression Enhancements

* IDEMPIERE-4824 Boolean Logic Expression Enhancements

Fix handling of conditional variable (i.e @VariableName:DefaultValue@)

* IDEMPIERE-4824 Boolean Logic Expression Enhancements

Fix unit test launch configuration
2021-06-10 23:08:22 +08:00
Diego Ruiz 5811f87f19
IDEMPIERE-4743 - Clean up ImageDBStorageImpl, Lookup, M_Element, MAccount, MAcctProcessor,MAcctSchema,MAcctSchemaDefault,MAcctSchemaElement classes (#714) 2021-06-10 15:49:49 +08:00
Carlos Ruiz a4f67eb852
IDEMPIERE-4782 Multi-factor authentication (FHCA-2034) (#705)
* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Implement suggestions from Heng Sin

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Fix security warning advised by github/CodeQL

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Implement an incremental delay in zk when the validation code is wrong (to avoid brute-force attacks)
As suggested by Ricardo Santana:
* ensures one-time only use of an OTP
* Log failures in AuthFailure.log

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

* Log failures in AuthFailure.log - add case for login with email
* Implement incremental delay also for login panel
2021-06-08 19:49:46 +08:00
igorpojzl 3e64dc6737
IDEMPIERE-4479 - Allow define columnSql in AD_Field (#710)
* IDEMPIERE-4479 - Allow define columnSql in AD_Field

* IDEMPIERE-4479 Added View Update, ColumnSql fix FieldLength

* IDEMPIERE-4479 Updated AD_Field Model

* IDEMPIERE-4479 MFIeld update model logic

* IDEMPIERE-4479 Move Migration scripts to 8.2
2021-06-04 10:03:05 +02:00
Carlos Ruiz d9826c775f
IDEMPIERE-4813 Process Customization Cross Tenant Error (#707)
* Implement for Window, Process and Info Window Customization:
  * Change to non-updateable the columns that have related children
  * Change default to NULL in role, user and language
  * Disable the autofilling of name, description and help
2021-06-03 15:40:30 +02:00
igorpojzl 6da6bc1d85
IDEMPIERE-4796 Request EMail Processor - Html email processing type parameter (#696)
* IDEMPIERE-4796 EmailSrv Parse Html Images

* IDEMPIERE-4796  Request EMail Processor - Html email processing type parameter

* IDEMPIERE-4796 Migration Scripts Added

* IDEMPIERE-4796 Added Register_Migration_Script

* IDEMPIERE-4796 Html Attachment Type Variable Logic Update

* IDEMPIERE-4796 ImageList null check added
2021-06-03 21:05:22 +08:00
igorpojzl d45ee838e3
IDEMPIERE-4815 FIX Check C_Country_ID when getting cached data. (#708) 2021-06-03 16:19:54 +08:00
hengsin b928043646
IDEMPIERE-4801 Add IMediaView interface and Keikai implementation (#700)
* IDEMPIERE-4801 Add IMediaView interface and Keikai implementation

* IDEMPIERE-4801 Add IMediaView interface and Keikai implementation

- Fixed some dependency issues
- Uses guava mediatype class

* minor - fix NPE when empty CSV

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-05-29 11:54:12 +02:00
Carlos Ruiz 6d78119006
IDEMPIERE-4800 Performance - avoid multiple for in GridTab.getParentTabNo (#699) 2021-05-27 14:38:02 +08:00
igorpojzl 17a80a0beb
IDEMPIERE-4799 Fix Check Parent Column Name (#698) 2021-05-26 12:38:42 +02:00
Carlos Ruiz 590d03ae3b
IDEMPIERE-4798 Add Event Before Parse Status Line (#697) 2021-05-26 17:21:27 +08:00
hengsin beaaf31d9a
IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler (#679)
* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

Fix initial output type selection for csv. Fix handling of binary vs
text media type.

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

- Change AD_AuthorizationAccount scope from single value to multiple
selection list (AD_AuthorizationScopes replace AD_AuthorizationScope)

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

Fix isIntersectCSV db function

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

add back AD_AuthorizationScope Configured dynamic validation filter
2021-05-12 13:42:55 +02:00
hengsin 0da2eb5bd2
IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments (#682)
- Fix cache reset and unit test bugs
2021-05-11 14:18:48 +02:00
Deepak Pansheriya 4439a74c52
IDEMPIERE-2377: Add "Prepare" Document Action to all document type (#653)
* IDEMPIERE-2377: Add "Prepare" Document Action to all document type

* IDEMPIERE-2377: Adding Prepare action on prepared docs and removeing redundent actions
Co-authored-by: carg67@gmail.com
2021-05-11 13:24:20 +02:00
Carlos Ruiz 3211c449cb
IDEMPIERE-4777 New table whose name ends in "Line" and does not have a Header table (#675) 2021-05-07 12:23:38 +02:00
hengsin a79be8aad8
IDEMPIERE-4749 Allow to use OAuth2 libraries on plugins (#668)
* IDEMPIERE-4749 Allow to use OAuth2 libraries on plugins

- move oauth libraries and dependency to target platform
- require Tycho 2.3.0+ and Eclipse 2021-03+

* IDEMPIERE-4749 Allow to use OAuth2 libraries on plugins

Fix launch configuration.
2021-04-28 14:59:50 +02:00
Carlos Ruiz d80b915836
IDEMPIERE-4372 Performance: only add log record and sql statement to context if trace/debug level <= debug/info (#665)
Revert change to assign the variable _TabInfo_SQL just on some log level
2021-04-28 11:05:09 +02:00
Carlos Ruiz 91a9314a96
IDEMPIERE-4709 Print Format Item: implement script column (expression) (#664)
Fix issue when using spaces on the name of the print format item
2021-04-23 16:15:12 +02:00
Carlos Ruiz 713aa09a46
IDEMPIERE-4709 Print Format Item: implement script column (expression) (#663)
Peer review and tests
2021-04-22 21:15:40 +02:00
igorpojzl f74e6c7824
IDEMPIERE-4709 - Print Format Item: implement script column (expression) (#644)
* IDEMPIERE-4709 - Print Format Item: implement script column (expression)

* IDEMPIERE-4709 - Translated comments

* IDEMPIERE-4709 - Check Advanced Access, Null Script before save

* IDEMPIERE-4709 - Changed Naming

Changed Naming for Scripts.

* IDEMPIERE-4709 Remove Migration script mistake

* IDEMPIERE-4709 Logic and Value Name Fixes
2021-04-22 21:13:10 +02:00
igorpojzl ad3debdd0e
IDEMPIERE-4765 IMAPS limited to GMAIL (#656)
* IDEMPIERE-4765 IMAPS limited to GMAIL

* IDEMPIERE-4765 Added IMAPHost Protocol
2021-04-22 18:56:00 +02:00
Carlos Ruiz a9b224c25d
IDEMPIERE-4762 Add AD_StorageProvider_ID to AD_Attachment (FHCA-1165) (#662) 2021-04-22 15:13:33 +02:00
Carlos Ruiz 3be5c0ac92
IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy (#660)
* IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy

* IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy

* Fix wrong selection of material date policy, must take into account isUseGuaranteeDateForMPolicy
* Fix wrong material receipt, assigning material date policy based on inventory instead of document/ASI

* * Unit tests
2021-04-21 21:42:10 +08:00
Carlos Ruiz 73f0cea85a
IDEMPIERE-3062 Unable to complete MR with qty >1 with Attribute Set of Always Mandatory (#659)
Fix wrong query on M_InoutLineMA
2021-04-21 21:39:23 +08:00
Carlos Ruiz c0927beaa4
IDEMPIERE-4763 Add IsDefault to AD_StorageProvider and use it when creating a new tenant (FHCA-1165) (#657)
* IDEMPIERE-4763 Add IsDefault to AD_StorageProvider and use it when creating a new tenant (FHCA-1165)

* Add column/field AD_StorageProvider.IsDefault
* Includes a minor refactoring of Login.loadDefault to add the ID column to the order by, to make predictable the ID returned when there are more than one record marked as default
* Context variable #AD_StorageProvider_ID is not created

* * Model class modified
2021-04-19 21:15:47 +08:00
Carlos Ruiz 9d059b13fe
IDEMPIERE-1405 Locator Dialog allows to create locators without any check (#651)
IDEMPIERE-4442 Change Locator Dialog ListBox to Tabledirect (autocomplete)
* Fix an issue not setting the new locator created when returning
2021-04-19 20:45:21 +08:00
igorpojzl c803886d25
IDEMPIERE-4760 Credit check do not allow complete Customer Return (#652) 2021-04-19 20:44:02 +08:00
Carlos Ruiz 8f31506ac7
IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments (#655)
* IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments

- Change setting for all caches to be non-distributed

* IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments

* TC-324 Fix cache related monitoring and performance issues

- PO & GridTable call to CacheMgt reset should be async.

Co-authored-by: hengsin <hengsin@gmail.com>
2021-04-19 20:41:34 +08:00
Carlos Ruiz 4de94e3d21
IDEMPIERE-4759 Method to create Trx with other Connection (FHCA-2544) (#654) 2021-04-14 16:45:24 +02:00
Carlos Ruiz ad558ed7ce
IDEMPIERE-4756 2pack import problem (#648) 2021-04-09 12:38:41 +02:00
Diego Ruiz 9742c0dbc9
IDEMPIERE-4723 - Clean up MMatch*/MMeasure*/MMenu/MMovement*/ModelVal* classes code (#645) 2021-04-09 10:00:45 +08:00
Carlos Ruiz 932ed8f498
IDEMPIERE-4727 Movement Window: a new line can be created for a movement that is completed. (#634)
* IDEMPIERE-4727 Movement Window: a new line can be created for a movement that is completed.

* IDEMPIERE-4727 Movement Window: a new line can be created for a movement that is completed.

Fix the problem also in model, to cover case when trying to add/modify lines for example via webservices

* IDEMPIERE-4727 Movement Window: a new line can be created for a movement that is completed.

Fix the problem also in model, change approach to use isProcessed instead of isComplete
2021-04-08 22:40:27 +08:00
hengsin b22ceeabdf
IDEMPIERE-4747 Pass PO object from MWFProcess to MWFActivity (#646)
Fix unit test error.
2021-04-08 21:20:49 +08:00
igorpojzl cb53fbcce0
IDEMPIERE-4747 Pass PO object from MWFProcess to MWFActivity (#641) 2021-04-08 18:11:28 +08:00
Carlos Ruiz 1a5eb5ce22
IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex (#640)
* IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex

* Implementing suggestion from Andreas Sumerauer
* Fix issue in IDEMPIERE-3916 (Move Client) and IDEMPIERE-1026 (Create Window from Table)

* IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex

* Change approach to discover real columns

* * Rename method as suggested by Andreas Sumerauer
2021-04-07 21:34:37 +08:00
Diego Ruiz 7d1fec61fb
IDEMPIERE-4723 - Clean up MIssue*/MJournal*/MLandedC*/MLanguage/MLdapProcessor/Mloc*/MLookip*/Mlot* classes code (#635) 2021-03-23 10:19:34 +08:00
Carlos Ruiz c8fd9a8805
IDEMPIERE-4736 FHCA-2461 IDEMP - ad_column table - Framework query improvement (#628)
* IDEMPIERE-4736 FHCA-2461 IDEMP - ad_column table - Framework query improvement

* * Rename migration scripts to normal convention
2021-03-16 17:03:40 +08:00
Diego Ruiz 86bbb08bff
IDEMPIERE-4723 - Clean up MInOut*/MInterest* classes code (#632) 2021-03-16 08:30:23 +08:00
Elaine Tan 27f21e0384
IDEMPIERE-4696 Wrong GL Currency Balancing in payment allocation for payment reverse/accrual (#621)
* IDEMPIERE-4696 Wrong GL Currency Balancing in payment allocation for payment reverse/accrual
2021-03-15 21:18:25 +08:00
Diego Ruiz 61478ad594
IDEMPIERE-4723 - Clean up dead code on MInvoice*/MInventory* classes (#625)
* IDEMPIERE-4723 - Clean up dead code on MInvoice*/MInventory* classes

* IDEMPIERE-4723 - Clean up useless if in MInvoiceLine
2021-03-15 17:43:02 +08:00
Carlos Ruiz bef5e5ed3f
IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system) (#630)
* Fix hardcoded reference to EMail scope in the processToken method
2021-03-12 18:11:22 +01:00
Carlos Ruiz 2e4daa8930
IDEMPIERE-4566 Translation Import/Export - output message is not visible (#624)
* Fix problem with wrong management of parameters when changing from Import to Export
* Delete the deprecated class, this is unused (IDEMPIERE-4723)
2021-03-12 10:45:39 +01:00
Elaine Tan c7854316be
IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line (#619)
* IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line
2021-03-10 18:09:13 +08:00
Diego Ruiz e7681a767a
IDEMPIERE-4723 - Clean up dead code on MOrder* classes (#620) 2021-03-10 17:56:24 +08:00
Carlos Ruiz 14d982abae
IDEMPIERE-4714 email password changes being displayed in the change log (#615)
* IDEMPIERE-4714 email password changes being displayed in the change log

* * minor fix adding a line to script
2021-03-09 15:00:12 +08:00
Carlos Ruiz 5f2d71347d
IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system) (#593)
* IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system)

WIP - initial version working on zk with google apps mail using OAuth2 Authorization Code Flow and Client Type = web application

* Enable imap reading with OAuth2 in RequestEMailProcessor
* Simplify the code - tested plain and OAuth2 can use the same methods
* Add +SCOPE parameter to AddAuthorizationForm according to IDEMPIERE-4713
* Rename the form AddAuthorizationMailForm to AddAuthorizationForm as is now more generic

* IDEMPIERE-4713
* Rename migration scripts to make it newer than IDEMPIERE-4713
* Add list of scopes attended by a credential
* Change form to accept other scopes, if no scope parameter is passed, then a list is shown, change the menu to fix the EMail scope
* Add MAuthorizationAccount.refreshAndGetAccessToken
* Add translation for messages

* make call generic oauth, avoid using specific google API

* Tests with microsoft as OAuth2 provider
* Add record for microsoft as provider
* Increase size of tokens
* Define mandatory and secure columns
* Update refresh token when it comes on the refresh call
* Revoke endpoint is optional

* Change the approach to a process instead of a form (WIP)
* Implement servlet to process the OAuth2 code

* Solve context suggestion from hengsin

* Implement the form in an automatic popup approach for running on zkwebui

* i18n - add translations for all messages that are shown to user
* on the form opted for click to avoid the problem with browsers forbidding popups
* clean spaces and tabs on line endings

* avoid logging and copy of the secure columns

* Fix problem reported by @d-ruiz about hidden NPE when SMTP Authentication is disabled

* Add writing to AD_PInstance_Para and AD_PInstance_Log the results of processing the servlet
* Control to avoid using the same authorization URL twice
2021-03-06 11:49:39 +01:00
hengsin 1971b4f0dc
IDEMPIERE-4488 Remove .classpath from repository (#607)
* IDEMPIERE-4488 Remove .classpath from repository

* IDEMPIERE-4488 Remove .classpath from repository

add ignore for .classpath

* IDEMPIERE-4488 Remove .classpath from repository

remove ".settings/org.eclipse.jdt.core.prefs"

* IDEMPIERE-4488 Remove .classpath from repository

fix false status report for /bin and .project
2021-03-03 00:02:03 +01:00
Carlos Ruiz 47f7180eff
IDEMPIERE-4713 Allow definition of context variables to inject on menu and window definition (#600)
* IDEMPIERE-4713 Allow definition of context variables to inject on menu and window definition

* * Implement prefix "+" as suggested by @hengsin
* Clear the variable

* * Fix scope of methods and fix interface as suggested by @hengsin

* * Implement changes suggested by @hengsin
* Add control for clicking on new button on Favourites and menu
2021-02-23 16:24:39 +01:00
Carlos Ruiz ed68a01c74
IDEMPIERE-4710 NPE in ProcessInfo.getLastServerRebootDate() (#603)
* Add logging for possible severe issue
2021-02-23 13:04:39 +08:00
Nicolas Micoud bd7600fcd9
IDEMPIERE-4710 : NPE in ProcessInfo.getLastServerRebootDate() (#597) 2021-02-22 10:56:32 +08:00
Carlos Ruiz d188e563fc
IDEMPIERE-4358 Rename table issue (#590)
* IDEMPIERE-4358 Rename table issue

Rename the table also in whereclause and orderbyclause in AD_Tab and AD_Ref_Table

* * Fix issue with Sequence reported by @d-ruiz
* Improve log messages

* * Improve reference message
2021-02-19 17:52:33 +01:00
Nicolas Micoud a292fea5d9
IDEMPIERE-4712 : set MInvoice setReversal(boolean) method public (#598) 2021-02-19 22:05:16 +08:00
hengsin b1d3f9c8fd
IDEMPIERE-4705 Add grid toggle button to Detail Pane (#594) 2021-02-18 19:38:46 +01:00
hengsin 4ebf81b1d2
IDEMPIERE-4704 Add base interface and class that uses generic type and lambda function for osgi factory that create new instance by class name or a string key (#595)
Fix unit test error when running through maven/jenkin (mvn verify
-DskipTests=false)
2021-02-18 18:22:07 +01:00
Deepak Pansheriya 5ca8d44d48
IDEMPIERE-4606: Adding support for generic method to get model using … (#580)
* IDEMPIERE-4606: Adding support for generic method to get model using UUID

* IDEMPIERE-4606: Refactoring as per Hengsin's review comment.

* IDEMPIERE-4606: reverting issue in IMappedModelFactory.

* IDEMPIERE-4606: Fixing compilation errors

* IDEMPIERE-4606: Resetting ModelFactory Class to original, removed instance variable m_uuid and used to pass UU.

* IDEMPIERE-4606: Dropping constructor with UU argument from PO class.

* IDEMPIERE-4606: Refactoring as per Hengsin's feedback

* IDEMPIERE-4606: Correcting Java doc and updating serialized version.

* IDEMPIERE-4606: Fixing uuID passing

* IDEMPIERE-4606: Moving check for blank argument at top
2021-02-17 12:46:51 +08:00
hengsin 5e60c443d2
IDEMPIERE-4704 Add base interface and class that uses generic type and lambda function for osgi factory that create new instance by class name or a string key (#585) 2021-02-16 11:24:31 +01:00
hengsin 4b20720932
IDEMPIERE-4690 Add column callout factory base class backed by Map and Lambda functional object (#587)
Refactoring. Add unit test for gridtab and callout.
2021-02-16 11:20:42 +01:00
hengsin c91a13ee88
IDEMPIERE-4681 Can't use hidden column in display logic (#561)
* IDEMPIERE-4681 Can't use hidden column in display logic

* IDEMPIERE-4681 Can't use hidden column in display logic

handle @ColumnName:0@ and @ColumnName.xyz@
2021-02-16 11:14:30 +01:00
Diego Ruiz 51a081cbe7
IDEMPIERE-4701 Env.parseVariable is parsing boolean values wrong (#582) 2021-02-12 15:58:40 +01:00
Carlos Ruiz 92195c08a4
IDEMPIERE-4693 2Pack Hangs in 7.1+ / IDEMPIERE-2767 (#570)
* IDEMPIERE-4693 2Pack Hangs in 7.1+ / IDEMPIERE-2767

* Decrease log level to INFO

* Add javadoc note
2021-02-11 04:33:19 +08:00
hengsin ee77620186
IDEMPIERE-4694 Implement thread safe, annotation based osgi event han… (#571)
* IDEMPIERE-4694 Implement thread safe, annotation based osgi event handling

Make sure the component register in the event handler unit test cases
wouldn't have impact on other unit test cases.
2021-02-10 16:12:16 +01:00
hengsin c757fbaab7
IDEMPIERE-4695 Add document factory base class backed by Map and Lambda functional object (#576)
MappedDocumentFactoryTest fail when running idempiere.unit.test due to
document factory cache.
2021-02-10 16:02:13 +01:00
Martin Schönbeck 5e31c1fdb0
IDEMPIERE-4688 Adding Customs Tariff Number to products (#568)
* group1 and group2 also added to i_product
* Models generated for m_product and i_product, creating m_product from i_product extended with new fields.
2021-02-09 21:09:04 +01:00
Carlos Ruiz 79a3cd8c52
IDEMPIERE-4698 Load/Import Bank Statement issues (#573) 2021-02-09 20:11:00 +01:00
hengsin c159ce5325
IDEMPIERE-4695 Add document factory base class backed by Map and Lambda functional object (#572) 2021-02-09 19:17:15 +01:00
Nicolas Micoud 91fb2dacb9
IDEMPIERE-4683 : Report : missing logo for PDF output (#562) 2021-02-08 17:29:30 +01:00
hengsin ddd1c40eb2
IDEMPIERE-4690 Add column callout factory base class backed by Map an… (#567)
* IDEMPIERE-4690 Add column callout factory base class backed by Map and Lambda functional object

Fix column callout factory cache.

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-02-06 14:53:59 +01:00
hengsin 1c5a28aa0a
IDEMPIERE-4689 Add process factory base class backed by Map and Lambda functional object (#566) 2021-02-06 14:37:04 +01:00
Deepak Pansheriya 373225a62c
Idempiere 3340 (#505)
* IDEMPIERE-3340 : User favorite with tree structure

* IDEMPIERE-3340: Marking write operation to safe for cross tenant safe

* IDEMPIERE-3340: Fixing Cross tenant access issue

* IDEMPIERE-3340: refactoring as review comment, Fixing renaming folder issue, Auto launch window shows all items irrespective of access

* Sync with IDEMPIERE-4251

* Sync with IDEMPIERE-4251

* IDEMPIERE-3340: Refactoring as review comment for caching,
 toolbar button restriction method with ID, tooltip messages, font base theme,
 remove double click event, etc.

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-02-04 21:36:25 +01:00
hengsin 0f263f1c79
IDEMPIERE-4675 Add model factory base class backed by Map and Lambda … (#555)
- added interface and default mapped model factory service
- added unit test for default mapped model factory service
2021-02-01 15:29:13 +01:00
hengsin 4009c9c8ca
IDEMPIERE-4679 SvrProcess: ensure unlock and flushBufferLog happens after transaction commit and close (#560) 2021-02-01 15:25:34 +01:00
Carlos Ruiz e20e195c57
IDEMPIERE-4685 Cross tenant PO reading request detected from session for table AD_User Record_ID (#563) 2021-02-01 16:15:59 +08:00
Carlos Ruiz fd3fef9e7b
IDEMPIERE-4678 Save log informing Notice created when background job (#559)
* IDEMPIERE-4678 Save log informing Notice created when background job

* Added also a refactor for the INSERT INTO AD_PInstance_Log to use safer binding variables and add method saveEx

* - Implement suggestions from @hengsin
- Add some additional improvements
2021-01-29 08:57:15 +08:00
Carlos Ruiz 4493373b96
IDEMPIERE-4673 PackOut fails to export attachments with File storage provider (#554)
* IDEMPIERE-4673 PackOut fails to export attachments with File storage provider

* Implement similar solution for Image and Archive

* Simplify the nested ifs

Change approach for MAttachment as is not working for Data Single
2021-01-28 20:10:02 +08:00
Nicolas Micoud e32f971587
IDEMPIERE-4677 : Cross Tenant issues with AD_User/Role_OrgAccess (#556) 2021-01-28 12:42:00 +01:00
hengsin f5e9cd9336
IDEMPIERE-4654 Sales Order After Receipt Delivery Rule is not working (#536)
* IDEMPIERE-4654 Sales Order After Receipt Delivery Rule is not working

create shipment if it is fully paid and stock is available
use currencyconvertpayment
- rename after receipt to after payment
- added unit test for invoice payment

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-01-26 19:34:38 +08:00
Diego Ruiz 245b471d06
IDEMPIERE-4672 Improve the StatusBar Menupopup to render HTML text (#553) 2021-01-25 17:01:14 +01:00
hengsin f233e29432
IDEMPIERE-4662 Some problems of sort at window before save (#551)
* IDEMPIERE-4662 Some problems of sort at window before save

* IDEMPIERE-4662 Some problems of sort at window before save

Fixed the sequence of edit field -> sort -> edit field will wrongly
trigger save automatically.
2021-01-25 09:31:21 +01:00
hengsin 9370dbb77e
IDEMPIERE-4659 MStorageOnHand and MStorageReservation api improvements (#545) 2021-01-24 17:30:51 +01:00
hengsin 0046696a38
IDEMPIERE-4666 Close is an invalid Document Action for Draft, Invalid and In Progress Order (#547) 2021-01-24 17:25:54 +01:00
hengsin 72d66b8868
IDEMPIERE-4667 Project can not be printed using template print format (#550) 2021-01-24 17:13:47 +01:00
Carlos Ruiz 6c9e957e81
IDEMPIERE-4664 Cross tenant issue sending email with a System template (#543) 2021-01-22 13:16:36 +08:00
Carlos Ruiz 2d76f90f9c
IDEMPIERE-4660 Wrong code in virtual columns broke IDEMPIERE-2356 (#541)
IDEMPIERE-4087
IDEMPIERE-3760
2021-01-21 14:28:15 +01:00
Elaine Tan f3741b8f31
IDEMPIERE-4656 Incorrect rate in the MR postings when the currency type of the order is 'Company' (#537)
* IDEMPIERE-4656 Incorrect rate in the MR postings when the currency type of the order is 'Company'
2021-01-21 11:58:50 +08:00
Carlos Ruiz 24ccb86f16
IDEMPIERE-4653 Improve timeout handling of window tab (#539)
* IDEMPIERE-4653 Improve timeout handling of window tab

* Fixed a problem with IDEMPIERE-4130 that was not using role max query records
* GridTable was throwing NPEs because the arrays were disposed before closing
* Lowered log level on MRole to avoid clogging the console (I was testing with INFO level)
* Added more points of control for the timeout exception to give meaningful errors to the user and allow refining the query without closing the Find dialog
* Implemented a control to avoid repeating a slow initial query every time the dialog is open
* Added dialog when the find criteria doesn't return rows and allows the user to refine the query
* When the initial number of records is unknown, show a question mark instead of the count

* * Fix wrong role level pushed in first commit
2021-01-20 21:45:33 +08:00
hengsin e1ba21360f
IDEMPIERE-4653 Improve timeout handling of window tab (#534)
* IDEMPIERE-4653 Improve timeout handling of window tab

* IDEMPIERE-4653 Improve timeout handling of window tab

Fix error with find and refresh.
2021-01-20 13:27:58 +01:00
hengsin 59b83c3361
IDEMPIERE-4628 Implement configurable query timeout for info window (#532)
* IDEMPIERE-4628 Implement configurable query timeout for info window

* IDEMPIERE-4628 Implement configurable query timeout for info window

Move migration script from i8.2z to i8.2
2021-01-19 10:25:13 +08:00
hengsin 1afe4fe0c6
IDEMPIERE-4652 Remove Eclipse warnings (#533) 2021-01-18 17:32:25 +01:00
Carlos Ruiz 0cfa1c182a
IDEMPIERE-4650 Problems with Language Management in PO (#530)
* IDEMPIERE-4650 Problems with Language Management in PO

* * Set GardenWorld to use multi-lingual documents
2021-01-18 19:57:33 +08:00
hengsin ebcf4b3e1c
IDEMPIERE-4651 Max records for Search autocomplete list should be configurable (#531) 2021-01-18 11:52:12 +01:00
Carlos Ruiz fa8b7f1807
IDEMPIERE-4645 Search by special field types failing (#524)
* IDEMPIERE-4645 Search by special field types failing

* Set the advanced operators for Search for the special cases
2021-01-17 18:05:06 +08:00
Carlos Ruiz 0e366c9929
IDEMPIERE-4649 NPE when running Change base language with a fake language (as instructed) (#529) 2021-01-16 09:46:31 +08:00
Carlos Ruiz a1f39f9506
IDEMPIERE-4641 AD_ProcessPara.DisplayLogic is not accepting @Value_ID.ForeignColumn@ notation (#520) 2021-01-12 21:33:48 +08:00
Carlos Ruiz 402300a53e
IDEMPIERE-4639 Cross tenant issues with context help (#522) 2021-01-12 21:31:40 +08:00
hengsin d96199a2b6
IDEMPIERE-4251 Constant definition for all Env Context (#519)
* IDEMPIERE-4251 Constant definition for all Env Context

replace "#Date" with Env.DATE

* IDEMPIERE-4251 Constant definition for all Env Context

replace "#.." with constant at Env

* IDEMPIERE-4251 Constant definition for all Env Context

Merge patch from Carlos
2021-01-12 21:29:50 +08:00
Deepak Pansheriya e4ee47f92d
IDEMPIERE-4643: Cross Tenant issue when completing Requisition (#521) 2021-01-12 11:37:06 +01:00
igorpojzl b71e53e81c
IDEMPIERE-4637 Cross Tenant RMA, Tax Rate issue (#517) 2021-01-08 16:58:29 +01:00
Nicolas Micoud 326d210665
IDEMPIERE-4616 : Lead : add IsVendorLead (#500)
* IDEMPIERE-4616 : Lead : add IsVendorLead

* IDEMPIERE-4616 : Lead : add IsVendorLead

Fix description for Lead window
Add Display Logic for Opportunity parameters (now hidden if no opportunity)
Set BPartner.IsCustomer/IsVendor according to Lead.IsSales/VendorLead

* IDEMPIERE-4616 : Lead : add IsVendorLead

Move scripts from 8.2 to 8.2z
2021-01-07 18:48:25 +01:00
igorpojzl ba63dc4960
IDEMPIERE-4622 Cross Tenant UserDefInfo, Role (#503)
* IDEMPIERE-4622  Cross Tenant UserDefInfo, Role
2021-01-07 11:27:41 +01:00
Diego Ruiz 1d40ac7d6e
IDEMPIERE-4632 Print Invoices is not translating the invoice if the r… (#512)
* IDEMPIERE-4632 Print Invoices is not translating the invoice if the report is a Jasper Report

* IDEMPIERE-4632 Print Invoices is not translating the invoice if the report is a Jasper Report
2021-01-06 17:13:08 +01:00
Carlos Ruiz 2cfb699c6f
IDEMPIERE-4631 Lead window -> NPE GridFieldVO.loadLookupInfo: No LookupInfo for BP_Location_ID (#511) 2021-01-06 15:22:33 +01:00
Carlos Ruiz 05a7222828
IDEMPIERE-4602 Encrypt passwords on properties files (FHCA-1982) (#508)
Implement suggestions from Hiep
2021-01-06 12:12:09 +01:00
hengsin 3af7bc1351
IDEMPIERE-4626 Error message when opening FindWindow in Invoice(Custo… (#507)
* IDEMPIERE-4626 Error message when opening FindWindow in Invoice(Customer)

add Payment displaytype to isList

* IDEMPIERE-4626 Error message when opening FindWindow in Invoice(Customer)

merge suggestion from Carlos
2021-01-05 15:40:37 +01:00
Carlos Ruiz 47aee6fb02
IDEMPIERE-4602 Encrypt passwords on properties files (FHCA-1982) (#498)
* backward compatible with the previous idempiere.properties and idempiereEnv.properties version
* when the setup/console-setup is executed again the secret keys are stored obfuscated in a different file .idpass
  * Secret keys are ADEMPIERE_DB_PASSWORD, ADEMPIERE_DB_SYSTEM, ADEMPIERE_MAIL_PASSWORD
  * to add more is just adding keys to array ConfigurationData.secretVars
* the previous (unobfuscated) approach is still preserved passing -DIDEMPIERE_SECURE_PROPERTIES=false to the JVM in setup and server
* the approach just run on Linux - as is implemented using shell script, windows is out of the initial scope, but could be possible to implement .bat files to do similar
* the default approach is to use getVar.sh and setVar.sh that writes in .idpass obfuscated
  * is possible to extend and use custom secret managers implementing customSetVar.sh and customGetVar.sh
  * samples for amazon AWS secretsmanager are included
* avoid the email sent on setup sending the secret keys
* enclose all variables in myEnvironment.sh within quotes (this avoids problems with variables containing spaces)
* add coreutils as required for debian installer (as we use base64 now to obfuscate passwords)
* swing client is not affected as it saves the idempiere.properties encrypted in user home folder
2021-01-03 22:19:49 +08:00
Carlos Ruiz 11dc7a391f
IDEMPIERE-4623 Cash POS Sales Order is leaving wrong BP balance (#504) 2021-01-03 20:08:16 +08:00
hengsin 12009bf670
IDEMPIERE-4615 Cross Tenant Workflow Node cause - Cross tenant PO issue (#496) 2021-01-02 18:17:10 +01:00
igorpojzl afde8a0cf1
IDEMPIERE-4621 Cross Tenant Parent Tax Error (#502)
* IDEMPIERE-4621  Cross Tenant Parent Tax Error

* IDEMPIERE-4621 Add CLient Check on getTaxNodes
2020-12-31 20:21:04 +08:00
hengsin aa29cb6d7c
IDEMPIERE-4614 Reimplement Read Replica PreparedStatement using dynamic proxy (#491) 2020-12-30 15:07:27 +01:00
Carlos Ruiz 055ad2f0ae
IDEMPIERE-4619 Improve CLogger fallback when reaching 100 files in /log folder (#492) 2020-12-30 20:22:36 +08:00
Diego Ruiz da6d6b83aa
IDEMPIERE-4607 Cannot export windows via 2pack if any field has a Fie… (#483)
* IDEMPIERE-4607 Cannot export windows via 2pack if any field has a Field Group

* IDEMPIERE-4607 Implement changes discussed in JIRA - Add a new isList method to DisplayType

* IDEMPIERE-4607 Fixed typo

* IDEMPIERE-4607 Implement default method to return false by default - PR CarlosRuiz
2020-12-26 16:35:50 +01:00
Carlos Ruiz 8103ab0732 IDEMPIERE-4604 Release 8.2
Change references to new version
Create new migration folder
2020-12-20 10:15:20 +01:00
Carlos Ruiz 6390ce20cd IDEMPIERE-4604 Release 8.2
Fix warnings on MANIFEST.MF
2020-12-20 09:53:21 +01:00
Carlos Ruiz 3b1e4f2735 IDEMPIERE-4604 Release 8.2
Model generate classes
2020-12-20 09:51:58 +01:00
Carlos Ruiz 00a08236fc IDEMPIERE-4604 Release 8.2
Credits and version number
2020-12-20 09:25:13 +01:00
hengsin b80ed34d9c
IDEMPIERE-4599 Remove obsolete org.compiere.interfaces.* interface (#473)
* IDEMPIERE-4599 Remove obsolete org.compiere.interfaces.* interface

* IDEMPIERE-4599 Remove obsolete org.compiere.interfaces.* interface

remove warning.
2020-12-18 14:52:11 +01:00
Carlos Ruiz 2ab2211f81
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#468)
Extracting from @hengsin pull request 465
Fixes cross tenant readings in MUser MUserDefWin and MWorkflow
2020-12-16 09:08:11 +08:00
hengsin 1df6f63341
IDEMPIERE-4598 Disable obsolete IsServer* fields (#467)
* IDEMPIERE-4598 Disable obsolete IsServer* fields

* IDEMPIERE-4598 Disable obsolete IsServer* fields

- Fix wrong migration script name
2020-12-14 15:10:29 +01:00
hengsin 5e977d427c
IDEMPIERE-4287 Cache API not thread safe and inconsistent with context parameter (#466)
- Fix PO immutable exception with Workflow Validate process.
2020-12-14 14:53:55 +01:00
Carlos Ruiz fd947f4fef
IDEMPIERE-4581 Model generator should isn't dialog it should be window (#463)
* IDEMPIERE-4581 Model generator should isn't dialog it should be window

use shutdown asyn to shutdown framework when close Model generator window

one unhappy thing remain:
when use -console then framework is shutdown but jdk still hang because "pipe-gosh --login --noshutdown" still live (for https://bugs.eclipse.org/bugs/show_bug.cgi?id=362412)
work-around: use -console 1234
by that way we can't access osgi command from console but can use "telnet localhost 1234" to use osgi command

* IDEMPIERE-4581 Model generator should isn't dialog it should be window

Fix problem about program not closing
Improve layout

Co-authored-by: hieplq <hieplq@hasuvimex.vn>
2020-12-13 07:57:33 +08:00
Carlos Ruiz 5da1785572
IDEMPIERE-4596 Cannot create a product and an inventory document in t… (#459)
* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction

WIP - commit failing unit test

* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction

Implement solution suggested by @hengsin

* minor fix comment
2020-12-12 16:12:31 +01:00
Carlos Ruiz 9d6de521f2
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#456)
Extracting from @hengsin pull request 453
2020-12-11 16:48:16 +08:00
Carlos Ruiz f2c5ec429b
IDEMPIERE-4589 BUGS on PERFORMANCE ANALYSIS -> Accounting Rules ->Accounting Setup (#457) 2020-12-11 14:40:58 +08:00
Carlos Ruiz 4d96ac1f8e
IDEMPIERE-4593 Error completing a Standard Sales Order with Shipper and Calculated Freight Cost Rule (#454) 2020-12-10 13:57:25 +01:00
Carlos Ruiz 6fa0052834
IDEMPIERE-4588 Error in MOrder.setC_DocTypeTarget_ID (String DocSubTypeSO_x) when IsDefault=Y in a Purchase Order (#446) 2020-12-09 20:49:15 +01:00
Carlos Ruiz d654ed5791
IDEMPIERE-4587 Wrong ordered qty when reactivating a purchase order and setting a line to zero (#445) 2020-12-09 20:49:01 +01:00
Carlos Ruiz 34fec8c156
IDEMPIERE-4591 Load Bank Statement is not working in multi-tenant environments (#450)
IDEMPIERE-4268
2020-12-09 19:00:41 +01:00
Carlos Ruiz 46bc0e022f
IDEMPIERE-4358 Processes to drop some objects from database (#448)
Add process to rename a column directly from the Table and Column window
2020-12-09 15:31:13 +01:00
Carlos Ruiz 4c66c0018d
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#443)
Implement thread safe mechanism
https://mattermost.idempiere.org/idempiere/pl/hmpd8freutbhbgcjr9tu6ntitr
2020-12-09 14:28:49 +01:00
Carlos Ruiz 416d92a292
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#441)
Fix problem reported by ken.wang at
https://mattermost.idempiere.org/idempiere/pl/3wmpzg1o5i88dec5pifkjd3qfe
2020-12-07 22:59:23 +08:00
Carlos Ruiz 02ce1f3c1f
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#436)
Two more points found about cross tenant readin in MClient and MUser
2020-12-05 12:42:43 +08:00
Carlos Ruiz b9964ce7ab
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#432)
Fixes:
org.adempiere.exceptions.AdempiereException: Cross tenant PO reading request detected from session 1009629 for table AD_UserDef_Win Record_ID=1000002
	at org.compiere.model.PO.checkValidClient(PO.java:5000)
	at org.compiere.model.PO.<init>(PO.java:212)
	at org.adempiere.model.GenericPO.<init>(GenericPO.java:81)
	at org.compiere.model.MTable.getPO(MTable.java:598)
	at org.compiere.model.Query.list(Query.java:286)
	at org.compiere.model.MUserDefWin.getAll(MUserDefWin.java:107)
	at org.compiere.model.MUserDefWin.getBestMatch(MUserDefWin.java:160)
2020-12-03 12:55:15 +01:00
Deepak Pansheriya 8b672a3a51
IDEMPIERE-2999 : refactoring as per Hengsin's review comments (#427)
* IDEMPIERE-2999 : refactoring as per Hengsin's review comments

* IDEMPIERE-2999: Fixing compilation issue

* IDEMPIERE-2999: Fixing as per Hengsin'e review
2020-12-02 22:59:23 +08:00
Carlos Ruiz bf65636e22
IDEMPIERE-4577 Problem creating an invoice vendor negative after the … (#428)
* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment

* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment

Add unit test
2020-12-02 21:08:41 +08:00
Carlos Ruiz 8cf16ba137
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#425)
Implement cross tenant check on foreign keys for insert and update
2020-12-01 07:16:22 +08:00
Carlos Ruiz 3a9b932df4
IDEMPIERE-4268 Fix recursive call to PO (#424)
* IDEMPIERE-4268 Fix recursive call to PO

Found a case where PO.checkValidClient fails, and then because of log.severe it tries to create a record with MIssue, and the PO.checkValidClient fails in MIssue, and is called recursively until it fails with a "Trx.run: Transaction timeout."

* IDEMPIERE-4268

- Improve error message
- Fix problem with valid cross-tenant reads in MRegion and MWorkflow
2020-11-30 21:36:51 +01:00
Carlos Ruiz 0eb4986513
IDEMPIERE-4575 Cannot complete Material Receipt from negative PO (#419) 2020-11-28 07:09:39 +08:00
Carlos Ruiz d885aaf4e6
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#415)
Co-authored-by: Heng Sin Low <hlow@trekglobal.com>
2020-11-26 20:22:18 +08:00
Carlos Ruiz 460f7116a2
IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong … (#414)
* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance

MAllocationHdr.updateBP was broken, the form Payment Allocation worked just because it was calling bpartner.setTotalOpenBalance() at the end
so, I refactored the MAllocationHdr.updateBP and before/afterDelete to call bpartner.setTotalOpenBalance instead if the broken algorithm

Unit test added for allocating and deleting a customer invoice, a vendor invoice, and a charge

* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance

- Fix peer review changes requested by @hengsin
- Detected double call to bpartner.setTotalOpenBalance in WAllocation
- Detected some business partners in GardenWorld with wrong TotalOpenBalance or SO_CreditUsed, added migration script to fix it, it made more complicate to write unit tests as the data was wrong
2020-11-26 17:08:05 +08:00
Carlos Ruiz 6eeabc49ba
IDEMPIERE-4566 Translation Import/Export - output message is not visible (#408)
- Deprecate zk form WTranslationDialog and controller TranslationController
- Move the logic to a java process org.idempiere.process.TranslationImpExp
- As a process works in mobile, can be called via webservices, tested with fitnesse, etc
- Importing leaves a better and readable log of each file processed
- Importing/Exporting gives feedback to the user about the file being processed

Side note:
- To standardize the menu - renamed the "Initial Client Setup Process" to "Initial Client Setup"

Improvements over the previous form:
- can process the files from the zip in root folder, or in internal folder with the name of the language
- can process a URL http/https to download the zip file
2020-11-26 16:20:17 +08:00
Carlos Ruiz 363f21993f
IDEMPIERE-4285 Cannot send mail while creating RfQ Response (#413)
Co-authored-by: Ray Lee <ray@iroses.tw>
2020-11-26 12:55:10 +08:00
Carlos Ruiz 2735131285
IDEMPIERE-4520 Attribute Instance not Refreshed on Create only on Update (#409) 2020-11-25 10:59:32 +01:00
Orlando Curieles b05b26d9f1
IDEMPIERE-4572 Fix NPE (#402) 2020-11-22 09:49:29 +08:00
Carlos Ruiz b778904d42
IDEMPIERE-4558 Copy GardenWorld into a new Client using Copy Client - failing in postgresql native (#399)
Fix the problem in postgresql native
2020-11-21 14:21:45 +08:00
AndreaCh83 530d5e7b9a
IDEMPIERE-4555 Incorrect price in intercompany document (#389)
* IDEMPIERE-4555 Incorrect price in intercompany document

* Update MOrder.java

* Update MOrder.java
2020-11-21 07:55:02 +08:00
Carlos Ruiz 611e1bbb8f
IDEMPIERE-4560 Autocomplete fills the value to be suggested to the user with the cache and does not support multilanguage (#397)
Fixes the problem about caching results from previously used language, breaking the usage of base language when another language was used previously
2020-11-21 07:49:57 +08:00
Carlos Ruiz 837c04f063
IDEMPIERE-4542 Cannot report from window _My Unprocessed Documents_ (#376) 2020-11-13 18:07:07 +08:00
Diego Ruiz ed7a7dcbde
IDEMPIERE-4525 Translate MailText in Print Invoices to the corresponding BP Language (#356) 2020-11-05 17:12:53 +01:00
Carlos Ruiz 210e54b05f IDEMPIERE-4521 Release 8.1 - RC
Change versions in pom and manifest files
2020-11-03 21:59:12 +01:00
Carlos Ruiz da49f81591 IDEMPIERE-4521 Release 8.1 - RC
Generate model - 4 steps:
"org.compiere.model" "D,EE05" "%"
"org.compiere.model" "D" "AD_UserMail" "D"
"org.eevolution.model" "EE01,EE04,EE02" "%"
"org.compiere.model" "D" "'AD_AllUsers_V','AD_AllClients_V'"
2020-11-03 21:59:12 +01:00
Carlos Ruiz 2753acac56 IDEMPIERE-4521 Release 8.1 - RC
Change references in files
2020-11-03 21:59:12 +01:00
hengsin 1e909ffb53
IDEMPIERE-4519 Zk: Implement optional defer rendering for Grid View (#350) 2020-11-03 15:40:36 +01:00
Carlos Ruiz 88dff840ac
IDEMPIERE-3340 (#351)
* Revert "IDEMPIERE-3340 Fixes for oracle migration scripts (#346)"

This reverts commit db7b9db43c.

* Revert "IDEMPIERE-3340: Tree Structurable User Favorite (#334)"

This reverts commit 01d52fbfef.
2020-11-03 15:40:17 +01:00
Deepak Pansheriya 01d52fbfef
IDEMPIERE-3340: Tree Structurable User Favorite (#334) 2020-11-02 19:28:03 +08:00
hengsin 03d668bf51
IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer (#345)
- log errors from background init.
- add explicit Env Context init for AdempiereMonitor thread and
Background init thread.
2020-11-02 11:23:24 +01:00
Carlos Ruiz c9a766c806
IDEMPIERE-4297 Improve test data (#344)
Fix error reported by @hengsin
Doc_Invoice.getValidCombination_ID: NO account Type=4

Make explicit the deprecation in code and hide the deprecated account fields on IDEMPIERE-362
2020-11-02 10:39:40 +08:00
hengsin b4c93c76b3
IDEMPIERE-4516 InvoiceCustomerTest show NPE at console (#342)
* IDEMPIERE-4516 InvoiceCustomerTest show NPE at console

add NPE check

* IDEMPIERE-4516 InvoiceCustomerTest show NPE at console

- add way to defer the immediate posting of doc that's means to be
posted in the processing of docpostprocess of the source document.
- add severe log check to InvoiceCustomerTest
- DocumentEngine should skip Doc from DocPostProcess that have been
posted
2020-11-01 12:43:36 +01:00
hengsin e1cf1ada4d
IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on th… (#332)
* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

remove unuse code.

* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

add sysconfig record for ZK_TOOLBAR_SHOW_MORE_VERTICAL
2020-10-29 13:30:00 +01:00
Martin Schönbeck b8225276a2
Idempiere 4452 (#271)
* IDEMPIERE-4452 Allow pricelist schema lines to be dependent of vendor categories and to use entries in m_product_po not marked as current vendor if vendor is selected.

* IDEMPIERE-4452 modified update removed
* don't check for accidently set IsIgnoreIsCurrentVendor where it doesn't change anything.

* IDEMPIERE-4452 set IsIgnoreIsCurrentVendor to false ('N') when no business partner given.
2020-10-28 22:15:01 +08:00
hengsin 00e94b12ef
IDEMPIERE-2902 UX: Implement Radio buttons (#326)
* IDEMPIERE-2902 UX: Implement Radio buttons

Integrate contribution from TrekGlobal
TC-188 Port RadioGroup field editor from AP2-19
added "Radio Group List" field type

* IDEMPIERE-2902 UX: Implement Radio buttons

Peer review
* Configure correctly wrong Validation Rule
* Fix wrong DisplayLogic from this ticket and also from other recently added features on fields:
Attribute > Attribute > Reference Key
Attribute > Attribute > Dynamic Validation
Info Window > Column > Reference Key
Info Window > Column > Dynamic Validation
Registration Attributes > Attribute > Reference Key
Table and Column > Column > Dynamic Validation
Table and Column > Column > Dynamic Validation (Lookup)
Table and Column > Column > Reference Key
Web Service Security > Web Service Field Input > Reference Key
Window Customization > Field Customization > Reference Key
Window Customization > Field Customization > Dynamic Validation
Window Customization > Field Customization > Dynamic Validation (Lookup)
Window, Tab & Field > Field > Reference Key
Window, Tab & Field > Field > Dynamic Validation
Window, Tab & Field > Field > Dynamic Validation (Lookup)
* For testing and UX, configure as Radio Group:
Broadcast Message > Broadcast Message > Target
Field Group > Field group > Field Group Type

* IDEMPIERE-2902 UX: Implement Radio buttons

* For testing and UX, configure as Radio Group in detail tab:
Info Window > Process > LayoutType

* IDEMPIERE-2902 UX: Implement Radio buttons

- Fix radio group editor lost track of selectedItem after page detached
and attached
- Standardized the construction of editors from editor factory
- Remove unnecessary refresh for list/lookup based readonly editors
created by grid view (fixed editor is not readonly during init())

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-10-27 19:17:56 +01:00
hengsin 9162b60af7
IDEMPIERE-4498 Performance: add cache for osgi services factory (#321)
* IDEMPIERE-4498 Performance: add cache for osgi services factory

add cache for tableName -> IModelFactory

* IDEMPIERE-4498 Performance: add cache for osgi services factory

implement cache for the discovery of osgi services

* IDEMPIERE-4498 Performance: add cache for osgi services factory

added unit test
2020-10-26 18:53:10 +01:00
Carlos Ruiz fa86359570
IDEMPIERE-2999 Attribute, Table Direct and date field support (#320)
Fix security issue about non advanced roles
2020-10-26 14:18:33 +01:00
hengsin 57e4e3fceb
IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency (#316)
- Fix error in setting the currency for source amount
- Improve unit test to check source amount precision as well
2020-10-22 20:48:07 +08:00
Elaine Tan c4b39eac8c
IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency (#313)
* IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency

* IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency - Added MatchInvTest.testMatReceiptPostingWithDiffCurrencyPrecision test case
2020-10-22 15:40:42 +08:00
Carlos Ruiz 014b45246f
Idempiere 4058 (#312)
* IDEMPIERE-4058 - tab editor: new options for editing and customizing fields (window customization)

* IDEMPIERE-4058 tab editor: new options for editing and customizing fields (window customization)

Fix issues with migration scripts

Co-authored-by: muriloht <muriloht@devcoffee.com.br>
2020-10-21 15:47:56 +02:00
Carlos Ruiz 350e9efe65
IDEMPIERE-4503 Hide non-working things in Window Customization (#310) 2020-10-21 14:49:02 +02:00
Deepak Pansheriya 78f388d450
IDempiere-2999: on Attribute adding all reference type support except… (#287)
* IDempiere-2999: on Attribute adding all reference type support except path, images.

* IDEMPIERE-2999 : Removing isQuickForm reference from migration script and fixing url issue.
2020-10-21 13:58:23 +02:00
Deepak Pansheriya 08f6fb17d3
IDEMPIERE-3981: FindWindow - Overwrite isSelection at field level, Va… (#249)
* IDEMPIERE-3981: FindWindow - Overwrite isSelection at field level, Validation Rule overwrite for Find window, Extended search and advanced hiding options.

* IDEMPIERE-3981: Correcting migration script as per Carlos' code review finding

* IDEMPIERE-3981: Fixing as per code review comment
Co-authored-by: muriloht muriloht@devcoffee.com.br

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-10-21 13:32:25 +02:00
Carlos Ruiz a60dd24533
IDEMPIERE-4495 github code scanning alerts (#308)
* IDEMPIERE-4495 github code scanning alerts

Failure to use secure cookies

* Failure to use secure cookies - one more

* Fix: Arbitrary file write during archive extraction ("Zip Slip")

* Fix: Resolving XML external entity in user-controlled data
2020-10-18 11:04:54 +08:00
hengsin e06938cedc
IDEMPIERE 4211 (#307)
* IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer

add 1 to 3 minute delay to wait for hazelcast service

* IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer

move waiting to background thread
add MONITOR_INITIAL_WAIT_FOR_CLUSTER_IN_SECONDS and
MONITOR_MAX_WAIT_FOR_CLUSTER_IN_SECONDS sysconfig
2020-10-17 22:33:59 +02:00
hengsin 2b9cb9bb2e
IDEMPIERE-4497 Mobile: Update PDF.JS (#306)
* IDEMPIERE-4497 Mobile: Update PDF.JS

* IDEMPIERE-4497 Mobile: Update PDF.JS

archive and simple pdf viewer

* IDEMPIERE-4497 Mobile: Update PDF.JS

change ZK_USE_PDF_JS_VIEWER sysconfig level to Client level (C)
2020-10-17 17:55:11 +02:00
Carlos Ruiz 9075b6d84b
IDEMPIERE-4495 github code scanning alerts (#305)
* IDEMPIERE-4495 github code scanning alerts

Failure to use secure cookies

* Query built without neutralizing special characters
2020-10-17 14:11:12 +08:00
Carlos Ruiz fcf7a168b4
IDEMPIERE-4287 Cache API not thread safe and inconsistent with context parameter (#302)
Fix issue with
java.lang.IllegalStateException: PO is Immutable: org.compiere.model.MRecentItem
	at org.compiere.model.PO.checkImmutable(PO.java:1573)
	at org.compiere.model.PO.set_Value(PO.java:733)
	at org.compiere.model.PO.set_Value(PO.java:721)
	at org.compiere.model.X_AD_RecentItem.setAD_Role_ID(X_AD_RecentItem.java:123)
	at org.compiere.model.MRecentItem.addModifiedField(MRecentItem.java:234)
2020-10-17 07:14:51 +08:00
Nicolas Micoud 4856ca67fc
IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility (#261)
* IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility

Search recipients in SysConfig and if not found, fallback on System.SupportEMail

* IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility

fixes suggested by @hengsin

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2020-10-16 23:22:19 +08:00
igorpojzl 3246bb8b1e
IDEMPIERE-4459 Info Window Customization (#259)
* IDEMPIERE-4459 Info Window Customization - Added Java Models

* IDEMPIERE-4459 Update Model AD_UserDef_Info_Column

* IDEMPIERE-4459 Added Migration scripts

* IDEMPIERE-4459 User Definition Info Column Added

Added Business Logic for Info Window Customization for Info Columns. Added InfoColumnVO for storing InfoColumn Data filtered with User Definition.

* IDEMPIERE-4459 Added Migration Scripts to Update Columns

Allow Update AD_Role_ID, AD_Language, AD_User_ID in AD_UserDef_Info table.

* IDEMPIERE-4459 Info Window Customisation - Updated Migration scripts

* IDEMPIERE-4459 Migration Script Fix

* IDEMPIERE-4459 Info Window Customization - Update Java Models

* IDEMPIERE-4459 Apply Migration Patch

* IDEMPIERE-4459 Info Window Customization - Update Models

* IDEMPIERE-4459 Apply Patch 2 fix.

* IDEMPIERE-4459 Info Related Cust. Added, Info Window Cust. Implementation..

* IDEMPIERE-4459 Info Related isDisplay added

* IDEMPIERE-4459 Added Display Logic for Info Related

* IDEMPIERE-4459 Fix SeqNo for InfoColumns

* IDEMPIERE-4459 Fix Patch 3
2020-10-16 11:41:50 +02:00
hengsin 91c72fd978
IDEMPIERE-4482 Mobile Improvements (#297)
* IDEMPIERE-4482 Mobile Improvements

* IDEMPIERE-4482 Mobile Improvements

minor line height fix for process dialog's message area

* IDEMPIERE-4482 Mobile Improvements

- fix issue with grid view column header height
- add customize grid view button to detail pane
- always show message as notifications for mobile
- fix some mobile layout issues
- default desktop font size to 14px
2020-10-14 11:07:18 +02:00
hengsin 5a83afb565
IDEMPIERE-4287 Fix for AD_Table caching (#296)
fix infinite loop
2020-10-13 12:01:39 +02:00
igorpojzl 4a0b44ac83
IDEMPIERE-4287 Fix for AD_Table caching. (#293) 2020-10-12 21:37:21 +08:00
Diego Ruiz edf407614f
IDEMPIERE-4490 Set default Contact/User in SO, Invoice, M_InOut (#289)
* IDEMPIERE-4490 Set default Contact/User in SO, Invoice, M_InOut

* Ran modelgenerator again with the new field = null

* IDEMPIERE 4490 - Update the migration scripts to 7.1 and set Bill_User_ID to null

* IDEMPIERE 4490 - Update the migration scripts to 7.1

* Change field name from Invoice Address to Invoice Contact / Ship Address to Ship Contact

* IDEMPIERE-4490 Add logic to CalloutOrder.bpartnerBill
2020-10-08 12:17:07 +02:00
hengsin e01e8a0f41 IDEMPIERE-3676 Incorrect stop of the schedulers
Base on patch from NikColonel<polkneket@gmail.com>
2020-10-01 17:23:40 +08:00
Ricardo Santana 2199aa078c
IDEMPIERE-1604 - Extend features for Window Customization (#274)
* IDEMPIERE-1604 - Extend features for Window Customization

* change oracle data type

* oracle replace at sign to chr 64

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-09-28 14:53:33 +02:00
Carlos Ruiz 6ff5fed0ec
IDEMPIERE-4474 Automatic calculation of freight charges (#277)
* IDEMPIERE-4474 Automatic calculation of freight charges

* IDEMPIERE-4474 Keep the getShippingProcessor private - avoid NPE in all getters

* IDEMPIERE-4474 Improve error messages and error management
2020-09-28 14:50:58 +02:00
Deepak Pansheriya 965048d168
IDEMPIERE-2955: Adding Attribute Set Type to use attribute set for di… (#264)
* IDEMPIERE-2955: Adding Attribute Set Type to use attribute set for different purpose

* IDEMPIERE-2955: Fixing migration files swept between Oracle and postgresql folder.

* IDEMPIERE-2955: Fixing oracle migration script having mistakenly deleted comments
2020-09-24 17:17:51 +02:00
igorpojzl 9cca6c08be
IDEMPIERE-4467 Window Customisation has not implemented caching (#268)
* IDEMPIERE-4467  Add caching to UserDefTab and UserDefField

* IDEMPIERE-4467 Change CCache to ImutablePOCache

* IDEMPIERE-4467 Window Customisation - Change cache Get and Put Methods

Change cache Get and Put methods to have consistency with ctx parameter.
2020-09-24 20:06:51 +08:00
Carlos Ruiz 1ddbe3eef5
IDEMPIERE-4213 Window Toolbar attached processes are doesn't validate role access (#265) 2020-09-22 10:52:46 +08:00
Carlos Ruiz c5079d5106
IDEMPIERE-4287 / minor - solve two deprecation warnings (#270) 2020-09-22 10:47:24 +08:00
hengsin 4c1ba12a3f
IDEMPIERE-3212 Quantity MatchPO wrong validation (#269)
Fix auto matching for matchpo and matchinv
2020-09-21 20:00:31 +02:00
Carlos Ruiz 1aa7565ad7
IDWS-8 Cannot update user info in WebStore (#267)
IDEMPIERE-4287
2020-09-21 18:01:21 +08:00
muriloht d875208a00
IDEMPIERE-3336 - Tables missing EntityType column (#258)
* IDEMPIERE-3336 - Tables missing EntityType column

* IDEMPIERE-3336 - fix PR review comments

* IDEMPIERE-3336 - fix PR review default value for entityType
2020-09-21 10:25:23 +02:00
hengsin dd2ef468b0
IDEMPIERE 4287 (#247)
* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
add support to make PO immutable

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added thread safe Immutable and Copy cache implementation for PO.
- migrate most of PO cache to immutable and copy cache.
- added pos sales order test.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- add test case for initial client setup and bank statement
- fix error for image editor, location editor, locator editor, initial
client setup, complete bank statement and migrate storage provider.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added ImmutablePOSupport interface. Model class implement this
interface for immutable PO support.
- remove usage of cache for transaction table (rfq, invoice, inventory).
- add getCopy method to some model class to support getting an
updateable copy of PO from the otherwise immutable PO cache.
- the added getCopy method is use to return updateable PO for indirect
PO reference, for e.g MColumn.getAD_Table() and MOrderLine.getProduct.
2020-09-21 14:03:00 +08:00
Nicolas Micoud 9509d95c7c
IDEMPIERE-4460 : User suggestions for field/context help : check perm… (#257)
* IDEMPIERE-4460 : User suggestions for field/context help : check permission

new method to check exclusion of a table for current role, used to determine if popups should be displayed or not

* IDEMPIERE-4460 : User suggestions for field/context help : check permission

Following @globalqss's recommandations : rename the method + add more controls inside

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-09-20 15:53:56 +02:00
Elaine Tan 79d6c1e903
IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line (#250)
* IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line
2020-09-18 20:58:14 +08:00
Carlos Ruiz 599e13dda3
IDEMPIERE-4462 (#263)
Integrate patch from Paul Bowden (Adaxa)

Co-authored-by: Paul Bowden <pbowden@adaxa.com>
2020-09-18 12:45:20 +02:00
Elaine Tan 236729e3f5
IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Re… (#239)
* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo

* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo - Added test case
2020-09-10 20:49:25 +08:00
Deepak Pansheriya e72dfd66c0
IDEMPIERE-4067 : Support for Under/Over line and Blank line in finaci… (#244)
* IDEMPIERE-4067 : Support for Under/Over line and Blank line in finacial report line.

* IDEMPIERE-4067 : Adding support for blank line export in CSV, HTML, Excel. Also allowing to show description if provided. fixed all review comments fron Carlos Ruiz
2020-09-08 12:59:19 +02:00
Deepak Pansheriya ee48ef2be4
Idempiere 4066 (#235)
* IDEMPIERE-4066: Adding 'Relative Period To' on financial report column which allow to specify period range to produce YoY. QoQ like comparision report.

* IDEMPIERE-4066: Fixing defaulting RelativePeriodTo to Null issue

* IDEMPIERE-4066: Fix as per Carlos review.
1. Fixing compilation issue
2. Moving Column ID constants to systemIDs
3. Updating serial version for MReportColumn.

* IDEMPIERE-4066: Reverted GridField class changes and configured defailt for RelativePeriodTo to be 'NULL'
2020-09-05 12:17:40 +02:00
Carlos Ruiz be525d178c
IDEMPIERE-4447 Add offset to Query (#243)
Add method Query.setRecordstoSkip
2020-09-04 21:42:14 +02:00
Carlos Ruiz e93cdcb38c
IDEMPIERE-4440 NPE in DocAllocationHdr (#241) 2020-09-04 21:38:20 +02:00
Carlos Ruiz dcd7d6a41e
IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confir… (#227)
* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Implement void for movement confirm

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Voiding the confirmation voids the inventory move too

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Similar case found in MInOut - cannot void because of catch-22
Allow to void MInOut -> it automatically voids all pending confirmations

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Set quantities in zero when voiding movement confirmation
2020-08-31 14:23:33 +08:00
Nicolas Micoud 3384819c49
IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo (#238)
* IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo

* IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo (javadoc)
2020-08-28 16:14:45 +02:00
hengsin 7324dde78e
IDEMPIERE-4187 implement the usage of workflows in processes (#236)
Implement chaining of workflow through the use of Process Action
Implement overwrite of Record_ID for Process through Node Parameter
2020-08-27 14:34:26 +02:00
hengsin 9d614b985e
IDEMPIERE-4424 (#222)
* IDEMPIERE-4424 Concurrent update not prevented in Grid View

Grid View - change click navigation to follow the same flow as toolbar
navigation.

* IDEMPIERE-4424 Concurrent update not prevented in Grid View

GridTable - added Updated and Processed concurrency checked against PO.

* IDEMPIERE-4424 Concurrent update not prevented in Grid View

Incorporate fix suggested by Carlos
2020-08-27 12:40:44 +02:00
igorpojzl f13313760c
IDEMPIERE-4433 - MTable error - ConcurrentModificationException (#237)
Fix Putting into Cache outside Synchronized methods.
2020-08-26 20:35:16 +08:00
Carlos Ruiz 02f4d526dc
IDEMPIERE-4429 BOM Drop to Invoice is throwing error (#228)
IDEMPIERE-1314 getDocumentInfo methods should return translated String
2020-08-26 15:49:22 +08:00
Carlos Ruiz 75dcde96b3
IDEMPIERE-1482 Invoice with Payment Schedule is not displayed in Invoice Not Realized Gain/Loss (#225)
Fix problem reported by Anozi Mada
Fix issue found when testing - postgresql was failing with error
   org.postgresql.util.PSQLException: ERROR: la columna «c_doctypereval_id» es de tipo numeric pero la expresión es de tipo text
Avoid creating empty journal
2020-08-26 14:50:10 +08:00
hengsin 0e9f36add9
IDEMPIERE-3197 Tab still keep editing indicator when move to next record (#229)
Update tab title after save
2020-08-24 18:39:27 +02:00
Carlos Ruiz b0fbbb7a16
IDEMPIERE-4425 Find Window improvements (#224)
* IDEMPIERE-4425 Find Window improvements

Fix for printing report parameters - it is printing OPERATOR_EQUAL on reports instead of =

* IDEMPIERE-4425 Find Window improvements

Previous commit broke the find function - must use SQL for Values
2020-08-24 23:08:07 +08:00
Carlos Ruiz 2ad8fdfb3e
IDEMPIERE-2216:when make a warehouse order (in counter document test)… (#226)
* IDEMPIERE-2216:when make a warehouse order (in counter document test). new document material receipt is link with warehouse order not link with purchase order. it's correct?

* IDEMPIERE-2240:when create "On Credit Order" in counter document mode. invoice vendor make wrong reference to sale order

* IDEMPIERE-2257:can't complete invoice (vendor) generate from "order credit" by counter.

Integrating patch from Hiep hieplq@hasuvimex.vn
Changed syntax to be more readable
Used Processed instead of checking list of DocStatus

Co-authored-by: hieplq@hasuvimex.vn <hieplq@hasuvimex.vn>
2020-08-22 20:55:44 +02:00
Carlos Ruiz a9d24a2d5b
IDEMPIERE-4427 Changelog window reference lists dksplayed in wrong language (#221)
Ref IDEMPIERE-1540 e9e7486473
2020-08-21 20:56:34 +08:00
Carlos Ruiz a68c5f1968
IDEMPIERE-4425 Find Window improvements (#219) 2020-08-21 13:07:01 +02:00
Nicolas Micoud 2322a79dda
IDEMPIERE-4422 : GL Distribution - add SeqNo (#217)
* IDEMPIERE-4422 : GL Distribution - add SeqNo

Add SeqNo column on GL Distribution to allow users to choose the lowest one when several records are retrieved.
Fix typo

* IDEMPIERE-4422 : GL Distribution - add SeqNo

Fix a missed typo
2020-08-21 11:20:33 +02:00
Carlos Ruiz 7892c54aa1
IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user (#188)
* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Allow saving Tab Customization for System user

* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Fix copy/paste error

* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Implement same suggestion on all the classes where setAD_User_ID must be allowed to explicitly set to System
There were already two classes with the Override approach: MUserPreference and MUserRoles, so this commit is to apply the same approach to all the classes with same approach
2020-08-13 18:20:59 +08:00
hengsin 60f4ea4215
IDEMPIERE-4406 Performance: PO Cache should not always reset all entr… (#212)
* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

PO update - reset cache by record id

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

refine unit test

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

add cache reset fix for delete

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

Fix exception when cache is empty
Expose hidden cache reset exception
2020-08-11 14:55:03 +02:00
hengsin 0ad8737829
IDEMPIERE-4405 Add basic cache statistics (#211)
fix wrong hit/miss count when cached value is null
2020-08-07 17:07:39 +02:00
hengsin 147eebb01b
IDEMPIERE-4405 Add basic cache statistics (#210)
add hit and miss count for cache
2020-08-07 13:05:34 +02:00
Carlos Ruiz a84adbad80
IDEMPIERE-4395 Cannot save valid strings in oracle - ORA-12899: value too large for column (#202) 2020-08-06 22:35:37 +08:00
hengsin c17f1ae733
IDEMPIERE-4389 (#206)
* IDEMPIERE-4389 Implement Copy Constructor support for PO

Implement PO support for copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

deprecate clone
replace clone with copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

add unit test for MPrintFormat copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

fix wrong import
2020-08-05 21:03:40 +02:00
Carlos Ruiz 59758e8a7e
IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation (#198)
* IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

* IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Add validations to avoid editing lines if there are pending confirmations, in movement and shipment/receipt
2020-08-03 20:45:08 +08:00
hengsin a3a86739c2
IDEMPIERE-4390 Error in the Workflow window (#201)
add keyword quote escape to gridtable and mquery
2020-08-03 13:43:38 +02:00
hengsin f010b10446
IDEMPIERE-4393 Replace Oracle outer join synax (+) with SQL standard outer join (#199)
add native postgresql unit test for GenericPaymentExport
remove unnecessary static and fix sql exception doesn't stop the export
replace Oracle (+) with standard sql outer joint
2020-08-03 12:04:53 +02:00
Carlos Ruiz 600d8efc70
IDEMPIERE-1804 Org of WF Process is Default(login) Organization. (#195)
Workflow org

Co-authored-by: Hideaki Hagiwara <hagiwara.hideaki@gmail.com>
2020-07-31 08:02:33 +08:00
Carlos Ruiz a143e63128
IDEMPIERE-1893 can't Reversed a complete document "move inventory with confirm" (#197)
Do not create confirmation for reversal
2020-07-31 07:58:10 +08:00
Carlos Ruiz 937eaaa6ce
IDEMPIERE-874 Suspense Account is Posted with Wrong Org on GL Journal (#190) 2020-07-30 23:06:14 +08:00
Carlos Ruiz 0fa717cf0a
IDEMPIERE-4083 currency rate by document or by transaction (#182)
Integrating a contribution from TrekGlobal developed by Heng Sin
2020-07-30 15:46:43 +08:00
Carlos Ruiz e79ef31cd5
IDEMPIERE-3897 export csv: reference column export like normal column (#189)
Fix issue that entity type and language are not being set when imported
2020-07-30 10:47:56 +08:00
hieplq 30ce8cc5be
IDEMPIERE-4376:order activity workflow by ID (also time it's created) (#187)
maybe order by seq-no of node link to activity is more stable than ID
2020-07-27 17:08:02 +02:00
hengsin 80146138ac
IDEMPIERE-4382 Locator Editor inconsistent in the application of filter (#183)
pass ValidationCode to MLocatorLookup
Fix dynamic display support
Fix filter for grid view
Fix locator dialog not open with the selected locator
2020-07-26 12:49:43 +02:00
hengsin 40efcea51e
IDEMPIERE-4381 Order Line QtyReserved not updated correctly for negative shipment (#180)
Fix update of QtyReserved
2020-07-26 10:48:55 +02:00
Carlos Ruiz 26d2e37339
IDEMPIERE-1848 can delete org, account record in "Account Schema Dime… (#150)
* IDEMPIERE-1848 can delete org, account record in "Account Schema Dimensions"

Set Accounting Schema > Account Schema Dimensions > Element Type readonly when the type is Account or Org

* IDEMPIERE-1848 can delete org, account record in "Account Schema Dimensions"

reverting https://github.com/idempiere/idempiere/commit/be8de78
from https://sourceforge.net/p/adempiere/bugs/773/
2020-07-22 15:22:23 +08:00
hengsin cc76e63d85
IDEMPIERE-4372 Performance: only add log record and sql statement to … (#172)
* IDEMPIERE-4372 Performance: only add log record and sql statement to context if trace/debug level <= debug/info

Minor clean up and thread safe fix for CLogErrorBuffer and MIssue
Only add LogRecord and SQL to context if TraceLevel is <= INFO

* IDEMPIERE-4372 Performance: only add log record and sql statement to context if trace/debug level <= debug/info

add back DB.isConnected check
remove redundant CLogErrorBuffer call from DB.isConnected
more fine grained synchronization
2020-07-21 12:25:20 +02:00