Commit Graph

2831 Commits

Author SHA1 Message Date
Deepak Pansheriya 01d52fbfef
IDEMPIERE-3340: Tree Structurable User Favorite (#334) 2020-11-02 19:28:03 +08:00
hengsin 03d668bf51
IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer (#345)
- log errors from background init.
- add explicit Env Context init for AdempiereMonitor thread and
Background init thread.
2020-11-02 11:23:24 +01:00
Carlos Ruiz c9a766c806
IDEMPIERE-4297 Improve test data (#344)
Fix error reported by @hengsin
Doc_Invoice.getValidCombination_ID: NO account Type=4

Make explicit the deprecation in code and hide the deprecated account fields on IDEMPIERE-362
2020-11-02 10:39:40 +08:00
hengsin b4c93c76b3
IDEMPIERE-4516 InvoiceCustomerTest show NPE at console (#342)
* IDEMPIERE-4516 InvoiceCustomerTest show NPE at console

add NPE check

* IDEMPIERE-4516 InvoiceCustomerTest show NPE at console

- add way to defer the immediate posting of doc that's means to be
posted in the processing of docpostprocess of the source document.
- add severe log check to InvoiceCustomerTest
- DocumentEngine should skip Doc from DocPostProcess that have been
posted
2020-11-01 12:43:36 +01:00
hengsin e1cf1ada4d
IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on th… (#332)
* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

remove unuse code.

* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

add sysconfig record for ZK_TOOLBAR_SHOW_MORE_VERTICAL
2020-10-29 13:30:00 +01:00
Martin Schönbeck b8225276a2
Idempiere 4452 (#271)
* IDEMPIERE-4452 Allow pricelist schema lines to be dependent of vendor categories and to use entries in m_product_po not marked as current vendor if vendor is selected.

* IDEMPIERE-4452 modified update removed
* don't check for accidently set IsIgnoreIsCurrentVendor where it doesn't change anything.

* IDEMPIERE-4452 set IsIgnoreIsCurrentVendor to false ('N') when no business partner given.
2020-10-28 22:15:01 +08:00
hengsin 00e94b12ef
IDEMPIERE-2902 UX: Implement Radio buttons (#326)
* IDEMPIERE-2902 UX: Implement Radio buttons

Integrate contribution from TrekGlobal
TC-188 Port RadioGroup field editor from AP2-19
added "Radio Group List" field type

* IDEMPIERE-2902 UX: Implement Radio buttons

Peer review
* Configure correctly wrong Validation Rule
* Fix wrong DisplayLogic from this ticket and also from other recently added features on fields:
Attribute > Attribute > Reference Key
Attribute > Attribute > Dynamic Validation
Info Window > Column > Reference Key
Info Window > Column > Dynamic Validation
Registration Attributes > Attribute > Reference Key
Table and Column > Column > Dynamic Validation
Table and Column > Column > Dynamic Validation (Lookup)
Table and Column > Column > Reference Key
Web Service Security > Web Service Field Input > Reference Key
Window Customization > Field Customization > Reference Key
Window Customization > Field Customization > Dynamic Validation
Window Customization > Field Customization > Dynamic Validation (Lookup)
Window, Tab & Field > Field > Reference Key
Window, Tab & Field > Field > Dynamic Validation
Window, Tab & Field > Field > Dynamic Validation (Lookup)
* For testing and UX, configure as Radio Group:
Broadcast Message > Broadcast Message > Target
Field Group > Field group > Field Group Type

* IDEMPIERE-2902 UX: Implement Radio buttons

* For testing and UX, configure as Radio Group in detail tab:
Info Window > Process > LayoutType

* IDEMPIERE-2902 UX: Implement Radio buttons

- Fix radio group editor lost track of selectedItem after page detached
and attached
- Standardized the construction of editors from editor factory
- Remove unnecessary refresh for list/lookup based readonly editors
created by grid view (fixed editor is not readonly during init())

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-10-27 19:17:56 +01:00
hengsin 9162b60af7
IDEMPIERE-4498 Performance: add cache for osgi services factory (#321)
* IDEMPIERE-4498 Performance: add cache for osgi services factory

add cache for tableName -> IModelFactory

* IDEMPIERE-4498 Performance: add cache for osgi services factory

implement cache for the discovery of osgi services

* IDEMPIERE-4498 Performance: add cache for osgi services factory

added unit test
2020-10-26 18:53:10 +01:00
Carlos Ruiz fa86359570
IDEMPIERE-2999 Attribute, Table Direct and date field support (#320)
Fix security issue about non advanced roles
2020-10-26 14:18:33 +01:00
hengsin 57e4e3fceb
IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency (#316)
- Fix error in setting the currency for source amount
- Improve unit test to check source amount precision as well
2020-10-22 20:48:07 +08:00
Elaine Tan c4b39eac8c
IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency (#313)
* IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency

* IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency - Added MatchInvTest.testMatReceiptPostingWithDiffCurrencyPrecision test case
2020-10-22 15:40:42 +08:00
Carlos Ruiz 014b45246f
Idempiere 4058 (#312)
* IDEMPIERE-4058 - tab editor: new options for editing and customizing fields (window customization)

* IDEMPIERE-4058 tab editor: new options for editing and customizing fields (window customization)

Fix issues with migration scripts

Co-authored-by: muriloht <muriloht@devcoffee.com.br>
2020-10-21 15:47:56 +02:00
Carlos Ruiz 350e9efe65
IDEMPIERE-4503 Hide non-working things in Window Customization (#310) 2020-10-21 14:49:02 +02:00
Deepak Pansheriya 78f388d450
IDempiere-2999: on Attribute adding all reference type support except… (#287)
* IDempiere-2999: on Attribute adding all reference type support except path, images.

* IDEMPIERE-2999 : Removing isQuickForm reference from migration script and fixing url issue.
2020-10-21 13:58:23 +02:00
Deepak Pansheriya 08f6fb17d3
IDEMPIERE-3981: FindWindow - Overwrite isSelection at field level, Va… (#249)
* IDEMPIERE-3981: FindWindow - Overwrite isSelection at field level, Validation Rule overwrite for Find window, Extended search and advanced hiding options.

* IDEMPIERE-3981: Correcting migration script as per Carlos' code review finding

* IDEMPIERE-3981: Fixing as per code review comment
Co-authored-by: muriloht muriloht@devcoffee.com.br

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-10-21 13:32:25 +02:00
Carlos Ruiz a60dd24533
IDEMPIERE-4495 github code scanning alerts (#308)
* IDEMPIERE-4495 github code scanning alerts

Failure to use secure cookies

* Failure to use secure cookies - one more

* Fix: Arbitrary file write during archive extraction ("Zip Slip")

* Fix: Resolving XML external entity in user-controlled data
2020-10-18 11:04:54 +08:00
hengsin e06938cedc
IDEMPIERE 4211 (#307)
* IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer

add 1 to 3 minute delay to wait for hazelcast service

* IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer

move waiting to background thread
add MONITOR_INITIAL_WAIT_FOR_CLUSTER_IN_SECONDS and
MONITOR_MAX_WAIT_FOR_CLUSTER_IN_SECONDS sysconfig
2020-10-17 22:33:59 +02:00
hengsin 2b9cb9bb2e
IDEMPIERE-4497 Mobile: Update PDF.JS (#306)
* IDEMPIERE-4497 Mobile: Update PDF.JS

* IDEMPIERE-4497 Mobile: Update PDF.JS

archive and simple pdf viewer

* IDEMPIERE-4497 Mobile: Update PDF.JS

change ZK_USE_PDF_JS_VIEWER sysconfig level to Client level (C)
2020-10-17 17:55:11 +02:00
Carlos Ruiz 9075b6d84b
IDEMPIERE-4495 github code scanning alerts (#305)
* IDEMPIERE-4495 github code scanning alerts

Failure to use secure cookies

* Query built without neutralizing special characters
2020-10-17 14:11:12 +08:00
Carlos Ruiz fcf7a168b4
IDEMPIERE-4287 Cache API not thread safe and inconsistent with context parameter (#302)
Fix issue with
java.lang.IllegalStateException: PO is Immutable: org.compiere.model.MRecentItem
	at org.compiere.model.PO.checkImmutable(PO.java:1573)
	at org.compiere.model.PO.set_Value(PO.java:733)
	at org.compiere.model.PO.set_Value(PO.java:721)
	at org.compiere.model.X_AD_RecentItem.setAD_Role_ID(X_AD_RecentItem.java:123)
	at org.compiere.model.MRecentItem.addModifiedField(MRecentItem.java:234)
2020-10-17 07:14:51 +08:00
Nicolas Micoud 4856ca67fc
IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility (#261)
* IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility

Search recipients in SysConfig and if not found, fallback on System.SupportEMail

* IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility

fixes suggested by @hengsin

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2020-10-16 23:22:19 +08:00
igorpojzl 3246bb8b1e
IDEMPIERE-4459 Info Window Customization (#259)
* IDEMPIERE-4459 Info Window Customization - Added Java Models

* IDEMPIERE-4459 Update Model AD_UserDef_Info_Column

* IDEMPIERE-4459 Added Migration scripts

* IDEMPIERE-4459 User Definition Info Column Added

Added Business Logic for Info Window Customization for Info Columns. Added InfoColumnVO for storing InfoColumn Data filtered with User Definition.

* IDEMPIERE-4459 Added Migration Scripts to Update Columns

Allow Update AD_Role_ID, AD_Language, AD_User_ID in AD_UserDef_Info table.

* IDEMPIERE-4459 Info Window Customisation - Updated Migration scripts

* IDEMPIERE-4459 Migration Script Fix

* IDEMPIERE-4459 Info Window Customization - Update Java Models

* IDEMPIERE-4459 Apply Migration Patch

* IDEMPIERE-4459 Info Window Customization - Update Models

* IDEMPIERE-4459 Apply Patch 2 fix.

* IDEMPIERE-4459 Info Related Cust. Added, Info Window Cust. Implementation..

* IDEMPIERE-4459 Info Related isDisplay added

* IDEMPIERE-4459 Added Display Logic for Info Related

* IDEMPIERE-4459 Fix SeqNo for InfoColumns

* IDEMPIERE-4459 Fix Patch 3
2020-10-16 11:41:50 +02:00
hengsin 91c72fd978
IDEMPIERE-4482 Mobile Improvements (#297)
* IDEMPIERE-4482 Mobile Improvements

* IDEMPIERE-4482 Mobile Improvements

minor line height fix for process dialog's message area

* IDEMPIERE-4482 Mobile Improvements

- fix issue with grid view column header height
- add customize grid view button to detail pane
- always show message as notifications for mobile
- fix some mobile layout issues
- default desktop font size to 14px
2020-10-14 11:07:18 +02:00
hengsin 5a83afb565
IDEMPIERE-4287 Fix for AD_Table caching (#296)
fix infinite loop
2020-10-13 12:01:39 +02:00
igorpojzl 4a0b44ac83
IDEMPIERE-4287 Fix for AD_Table caching. (#293) 2020-10-12 21:37:21 +08:00
Diego Ruiz edf407614f
IDEMPIERE-4490 Set default Contact/User in SO, Invoice, M_InOut (#289)
* IDEMPIERE-4490 Set default Contact/User in SO, Invoice, M_InOut

* Ran modelgenerator again with the new field = null

* IDEMPIERE 4490 - Update the migration scripts to 7.1 and set Bill_User_ID to null

* IDEMPIERE 4490 - Update the migration scripts to 7.1

* Change field name from Invoice Address to Invoice Contact / Ship Address to Ship Contact

* IDEMPIERE-4490 Add logic to CalloutOrder.bpartnerBill
2020-10-08 12:17:07 +02:00
hengsin e01e8a0f41 IDEMPIERE-3676 Incorrect stop of the schedulers
Base on patch from NikColonel<polkneket@gmail.com>
2020-10-01 17:23:40 +08:00
Ricardo Santana 2199aa078c
IDEMPIERE-1604 - Extend features for Window Customization (#274)
* IDEMPIERE-1604 - Extend features for Window Customization

* change oracle data type

* oracle replace at sign to chr 64

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-09-28 14:53:33 +02:00
Carlos Ruiz 6ff5fed0ec
IDEMPIERE-4474 Automatic calculation of freight charges (#277)
* IDEMPIERE-4474 Automatic calculation of freight charges

* IDEMPIERE-4474 Keep the getShippingProcessor private - avoid NPE in all getters

* IDEMPIERE-4474 Improve error messages and error management
2020-09-28 14:50:58 +02:00
Deepak Pansheriya 965048d168
IDEMPIERE-2955: Adding Attribute Set Type to use attribute set for di… (#264)
* IDEMPIERE-2955: Adding Attribute Set Type to use attribute set for different purpose

* IDEMPIERE-2955: Fixing migration files swept between Oracle and postgresql folder.

* IDEMPIERE-2955: Fixing oracle migration script having mistakenly deleted comments
2020-09-24 17:17:51 +02:00
igorpojzl 9cca6c08be
IDEMPIERE-4467 Window Customisation has not implemented caching (#268)
* IDEMPIERE-4467  Add caching to UserDefTab and UserDefField

* IDEMPIERE-4467 Change CCache to ImutablePOCache

* IDEMPIERE-4467 Window Customisation - Change cache Get and Put Methods

Change cache Get and Put methods to have consistency with ctx parameter.
2020-09-24 20:06:51 +08:00
Carlos Ruiz 1ddbe3eef5
IDEMPIERE-4213 Window Toolbar attached processes are doesn't validate role access (#265) 2020-09-22 10:52:46 +08:00
Carlos Ruiz c5079d5106
IDEMPIERE-4287 / minor - solve two deprecation warnings (#270) 2020-09-22 10:47:24 +08:00
hengsin 4c1ba12a3f
IDEMPIERE-3212 Quantity MatchPO wrong validation (#269)
Fix auto matching for matchpo and matchinv
2020-09-21 20:00:31 +02:00
Carlos Ruiz 1aa7565ad7
IDWS-8 Cannot update user info in WebStore (#267)
IDEMPIERE-4287
2020-09-21 18:01:21 +08:00
muriloht d875208a00
IDEMPIERE-3336 - Tables missing EntityType column (#258)
* IDEMPIERE-3336 - Tables missing EntityType column

* IDEMPIERE-3336 - fix PR review comments

* IDEMPIERE-3336 - fix PR review default value for entityType
2020-09-21 10:25:23 +02:00
hengsin dd2ef468b0
IDEMPIERE 4287 (#247)
* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
add support to make PO immutable

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added thread safe Immutable and Copy cache implementation for PO.
- migrate most of PO cache to immutable and copy cache.
- added pos sales order test.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- add test case for initial client setup and bank statement
- fix error for image editor, location editor, locator editor, initial
client setup, complete bank statement and migrate storage provider.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added ImmutablePOSupport interface. Model class implement this
interface for immutable PO support.
- remove usage of cache for transaction table (rfq, invoice, inventory).
- add getCopy method to some model class to support getting an
updateable copy of PO from the otherwise immutable PO cache.
- the added getCopy method is use to return updateable PO for indirect
PO reference, for e.g MColumn.getAD_Table() and MOrderLine.getProduct.
2020-09-21 14:03:00 +08:00
Nicolas Micoud 9509d95c7c
IDEMPIERE-4460 : User suggestions for field/context help : check perm… (#257)
* IDEMPIERE-4460 : User suggestions for field/context help : check permission

new method to check exclusion of a table for current role, used to determine if popups should be displayed or not

* IDEMPIERE-4460 : User suggestions for field/context help : check permission

Following @globalqss's recommandations : rename the method + add more controls inside

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-09-20 15:53:56 +02:00
Elaine Tan 79d6c1e903
IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line (#250)
* IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line
2020-09-18 20:58:14 +08:00
Carlos Ruiz 599e13dda3
IDEMPIERE-4462 (#263)
Integrate patch from Paul Bowden (Adaxa)

Co-authored-by: Paul Bowden <pbowden@adaxa.com>
2020-09-18 12:45:20 +02:00
Elaine Tan 236729e3f5
IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Re… (#239)
* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo

* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo - Added test case
2020-09-10 20:49:25 +08:00
Deepak Pansheriya e72dfd66c0
IDEMPIERE-4067 : Support for Under/Over line and Blank line in finaci… (#244)
* IDEMPIERE-4067 : Support for Under/Over line and Blank line in finacial report line.

* IDEMPIERE-4067 : Adding support for blank line export in CSV, HTML, Excel. Also allowing to show description if provided. fixed all review comments fron Carlos Ruiz
2020-09-08 12:59:19 +02:00
Deepak Pansheriya ee48ef2be4
Idempiere 4066 (#235)
* IDEMPIERE-4066: Adding 'Relative Period To' on financial report column which allow to specify period range to produce YoY. QoQ like comparision report.

* IDEMPIERE-4066: Fixing defaulting RelativePeriodTo to Null issue

* IDEMPIERE-4066: Fix as per Carlos review.
1. Fixing compilation issue
2. Moving Column ID constants to systemIDs
3. Updating serial version for MReportColumn.

* IDEMPIERE-4066: Reverted GridField class changes and configured defailt for RelativePeriodTo to be 'NULL'
2020-09-05 12:17:40 +02:00
Carlos Ruiz be525d178c
IDEMPIERE-4447 Add offset to Query (#243)
Add method Query.setRecordstoSkip
2020-09-04 21:42:14 +02:00
Carlos Ruiz e93cdcb38c
IDEMPIERE-4440 NPE in DocAllocationHdr (#241) 2020-09-04 21:38:20 +02:00
Carlos Ruiz dcd7d6a41e
IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confir… (#227)
* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Implement void for movement confirm

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Voiding the confirmation voids the inventory move too

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Similar case found in MInOut - cannot void because of catch-22
Allow to void MInOut -> it automatically voids all pending confirmations

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Set quantities in zero when voiding movement confirmation
2020-08-31 14:23:33 +08:00
Nicolas Micoud 3384819c49
IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo (#238)
* IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo

* IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo (javadoc)
2020-08-28 16:14:45 +02:00
hengsin 7324dde78e
IDEMPIERE-4187 implement the usage of workflows in processes (#236)
Implement chaining of workflow through the use of Process Action
Implement overwrite of Record_ID for Process through Node Parameter
2020-08-27 14:34:26 +02:00
hengsin 9d614b985e
IDEMPIERE-4424 (#222)
* IDEMPIERE-4424 Concurrent update not prevented in Grid View

Grid View - change click navigation to follow the same flow as toolbar
navigation.

* IDEMPIERE-4424 Concurrent update not prevented in Grid View

GridTable - added Updated and Processed concurrency checked against PO.

* IDEMPIERE-4424 Concurrent update not prevented in Grid View

Incorporate fix suggested by Carlos
2020-08-27 12:40:44 +02:00
igorpojzl f13313760c
IDEMPIERE-4433 - MTable error - ConcurrentModificationException (#237)
Fix Putting into Cache outside Synchronized methods.
2020-08-26 20:35:16 +08:00