* Replaced PostgreSQL and Oracle connection pools with HikariCP.
Replaced C3P0 with HikariCP. HikariCP is a Apache licensed connection pool with substantially better performance and better resilience to failure (DB disconnects, etc.) then C3P0. Read more about it here: https://github.com/brettwooldridge/HikariCP .
Cleaned up the `getCachedConnection` method. With HikariCP there is no need to retry to obtain a connection since getting an connection will block until a free connection is available or until a timeout is reached (default 30 seconds) at which point an `SQLException` is thrown. This also removed calling `Runtime.getRuntime().runFinalization();`. HikariCP is currently configured to detect / log leaks when a connection hasn't returned to the pool for longer then 5 minutes.
Loading of pool config properties was cleaned up. Defaults are now loaded from a single file instead of defaults coming from both file and hardcoded properties. It is now also possible to specify any HikariCP property in the user pool property file.
Initialization of the datasource must happen in the `getDataSource()` method because at object construction not all JDBC config is known. However this method could (as far as I could tell) be called concurrently from multiple threads but had no mechanism to prevent initializing the DB pool multiple times. The variable in which the pool itself was stored (`m_ds`) also was not marked volatile or immutable which could lead to visibility issues. Instead of lazy initialization of the pool in the `getDataSource()` method the pool could probably better be initialized at object construction. However I wasn't able to achieve that without breakage therefor I made the initialization mechanism work correctly with concurrent invocations.
Various config options such as the `MaxStatementsPerConnection` options were removed because HikariCP doesn't support them.
* (Re)added Sequence time-out.
* IDEMPIERE-5326: Parsing error for report view if where clause and virtual column used in print format
* IDEMPIERE-5326: Fixing Compilation error
* IDEMPIERE-5326: Adding method back for backward compitability
* IDEMPIERE-5326: Adding constructors for backward compitability
Removed the method MRole.loadTableInfo which loaded the arrays: m_tableAccessLevel, m_tableName, m_viewName, m_tableIdName
and replaced all usage with visits to cached information from tables or columns
* IDEMPIERE-5376 CConnection and DB clean up
* IDEMPIERE-5376 CConnection and DB clean up
- More clean up
* IDEMPIERE-5376 CConnection and DB clean up
- Fix @Deprecated annotation
* IDEMPIERE-5265 : Wizard for Chosen Multiple Selection List editor
Do not show Assistant for TableDir editors
Show Assistant for process parameters
* IDEMPIERE-5265 : Wizard for Chosen Multiple Selection List editor - Show Assistant for process parameters
Better code from @hengsin
* IDEMPIERE-5265 : Wizard for Chosen Multiple Selection List editor - only for MultipleSelectionList editors
Comment to explicitely state that the Assistant is for MultipleSelectionList editors only (ie not
for MultipleSelectionTable editors)
* IDEMPIERE-5392 Maven Build: add flag to skip auto clean
* IDEMPIERE-5392 Maven Build: add flag to skip auto clean
- Add -DmaterializeProduct flag. Use -DmaterializeProduct=none to turn
off part of org.idempiere.p2 build.
- Add parallel execution setting for test.
* IDEMPIERE-5392 Maven Build: add flag to skip auto clean
- handle potential multi threaded conflict on context property
* IDEMPIERE-5392 Maven Build: add flag to skip auto clean
- Fix maven error/warning in Eclipse for maven-antrun-plugin
* IDEMPIERE-5393 - Allow rendering status line as widget/gadget in dashboard
* IDEMPIERE-5393 - css class for status line
* IDEMPIERE-5393 - update default theme version
* IDEMPIERE-5392 Maven Build: add flag to skip auto clean
* IDEMPIERE-5392 Maven Build: add flag to skip auto clean
- Add -DmaterializeProduct flag. Use -DmaterializeProduct=none to turn
off part of org.idempiere.p2 build.
- Add parallel execution setting for test.
* IDEMPIERE-5392 Maven Build: add flag to skip auto clean
- handle potential multi threaded conflict on context property
* IDEMPIERE-5372 Wrong default for IsApproved column on C_Order, C_Invoice and C_CashPlan #resolve
* IDEMPIERE-5372 Wrong default for IsApproved column on C_Order, C_Invoice and C_CashPlan #resolve
* IDEMPIERE-5312: Allowing Drag and drop file in Attachment dialog
* IDEMPIERE-5312: Fixing as per Hengsin's code review comments
* IDEMPIERE-5312: Applying txt file uplaod issue fix from Carlos
* IDEMPIERE-5378 MFA must allow to select the mechanism when the user has several registered (FHCA-3808)
* IDEMPIERE-5378 auto select when TOTP is the only mechanism
* IDEMPIERE-5367 Logic expression IN doesn't works with quoted text
* IDEMPIERE-5367 Logic expression IN doesn't works with quoted text
- Fixed equal not working for quoted text with comma (e.g 'A,R,S')
Carlos Ruiz
Jasper Siepkes
Peter Takács
Deepak Pansheriya
hengsin
Nicolas Micoud
Layda Salas
Diego Ruiz
Fr Jeremy Krieg