Commit Graph

2684 Commits

Author SHA1 Message Date
Carlos Ruiz 4d5f74b682 FR [2962094] Finish implementation of weighted average costing
Fixing problem reported on [2982558] C_InvoiceLine and C_OrderLine's QtyInvoiced do not match
caused by revision 11710
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962094
2010-04-07 05:57:05 +00:00
trifonnt 7222028463 FR [2979756] - Touchscreen friendly POS
https://sourceforge.net/tracker/?func=detail&atid=879335&aid=2979756&group_id=176962
2010-04-06 11:47:38 +00:00
tspc fdf32a1370 Merge bug fixes from release to trunk
merge 11866, 11868, 11892

11866 -> Fix [2383795] DistributeLandedCost to a single line does not work - thanks to SCalderon
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2383795

11868 -> Fix [2383866] Distribute LandedCost to a single line, base is not set - thanks to SCalderon
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2383866

11892 -> Fix [2980523] create payment sets charge to 0
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2980523

Tony
2010-04-02 22:05:17 +00:00
vpj-cd c0a2ff58ff fix bug introduce with 11887 revision.
kind regards
Victor Perez
www.e-evolution.com
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2897194
2010-03-31 16:36:15 +00:00
redchris 58379717c8 FR [ 2897194 ] - Advanced Zoom and RelationTypes
- the translation language should be taken form context
Please review
2010-03-31 14:56:34 +00:00
Heng Sin Low 9685a343a4 Adempiere.startup should set Ini.isClient before initialized CLogMgt
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2979844
2010-03-31 08:30:10 +00:00
Heng Sin Low 5fb24d597b Print memory and thread info to log file to aid debugging and monitoring.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2979734
2010-03-31 03:12:03 +00:00
Heng Sin Low 4b2c766803 The previous implementation using 2 parallel list doesn't work well in our field testing, reimplemented using a hashmap cache and working fine in production environment now.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2913975
2010-03-31 02:58:36 +00:00
Carlos Ruiz c123ddfdfa Peer review 11845 - changing case of a columnname affects generated model
BF [2913291] - Fixed Assets Application dictionary stabilization
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2913291
2010-03-31 00:42:21 +00:00
redchris 43b2f11e9b BF[ 2945507 ] - Material Cost Element
http://sourceforge.net/tracker/?func=detail&aid=2945507&group_id=176962&atid=879332
-- refactoring code for using ADempiere Best Practices
Please review
2010-03-30 11:51:44 +00:00
redchris bd479d0470 BF[ 2945507 ] - Material Cost Element
http://sourceforge.net/tracker/?func=detail&aid=2945507&group_id=176962&atid=879332
Please review
2010-03-30 11:13:29 +00:00
Carlos Ruiz 0a44f15fc6 Peer review for 11830 - changed the whereClause not equivalent (the fix duplicated the bind variable)
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-30 05:01:16 +00:00
Carlos Ruiz 7af86a2af9 peer review 11821 / FR [2977050] - Read ADEMPIERE_HOME from web.xml
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2977050
2010-03-26 23:31:11 +00:00
tspc 704877109d Merge bug fixes from release to trunk
merge 11707, 11708, 11816, 11817

11707 -> Fix [2971934] DigestOfFile incosistent Base64 conversion - thanks to Silvano (freepath)
Adding raise of exceptions when the file cannot be written
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2971934

11708 -> Fix [2127565] - LOT Control Error
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2127565

11816 -> Fixing some errors found when building testadempiere
Link to /release commit: http://adempiere.svn.sourceforge.net/adempiere/?rev=11816&view=rev

11817 -> [2846601] - DB.isDatabaseOK() is not called / moving the validation some lines down - it breaks completely the usage of Adempiere
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2846601

Regards,
Tony
2010-03-26 23:10:30 +00:00
Carlos Ruiz 21212ed383 Peer review for 11755, 11756
BIG ERRORS:
- changed the whereClause not equivalent
- moved the logic of Update Ratio within the loop when it was out of the loop
FR: [ 2214883 ] Remove SQL code and Replace for Query

Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-26 18:53:47 +00:00
Carlos Ruiz 6e8d32a311 Peer review for 11751 - FR: [ 2214883 ] Remove SQL code and Replace for Query
minor refactoring
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-26 18:42:14 +00:00
Carlos Ruiz 0ef28240fd Peer review for 11749 - FR: [ 2214883 ] Remove SQL code and Replace for Query
raising an exception is very different than a log.warning
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-26 18:23:03 +00:00
Carlos Ruiz edcd061da7 Fix [2962244] - Future dated price list version used in order
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962244
2010-03-26 14:44:24 +00:00
trifonnt cbc9d926b2 FR [2977050] - Read ADEMPIERE_HOME from web.xml
https://sourceforge.net/tracker/?func=detail&aid=2977050&group_id=176962&atid=955896
2010-03-26 14:18:53 +00:00
trifonnt fa300d50d8 Minor. Fix Eclipse warnings. Add Parameter of Iterator. 2010-03-25 15:12:30 +00:00
Carlos Ruiz daea95abbf Fix [1722226] - Usability - Record_ID = 0 on 9 tables can't be modified
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=1722226
2010-03-25 04:34:27 +00:00
Carlos Ruiz 60ac16df14 BF [2138047] Reversed MM documents DocumentNo issues
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2138047
2010-03-25 02:38:34 +00:00
Redhuan D. Oon 88f1cd175a [B#2975997] ApplyAccessFilter Not Passing Both Booleans
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2975997
2010-03-25 00:52:11 +00:00
Carlos Ruiz e80958f2d5 * Update MatchInv ProcessedOn to happen after invoice ProcessedOn (for a better reposting process)
* Added ProcessedOn column to RV_Unposted view and window
* minor fix in MCost - printing wrong variable in log
FR [2962094] Finish implementation of weighted average costing
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962094
2010-03-25 00:25:21 +00:00
trifonnt 5663e534d1 Working Eclipse configuration which enables Developers to start ADempiere ZK Web Ui from Eclipse. 2010-03-24 23:35:42 +00:00
trifonnt de26bf1d00 FR [2975307] - AD_Menu_Trl overwritten by AD_Window
https://sourceforge.net/tracker/index.php?func=detail&aid=2975307&group_id=176962&atid=879335
2010-03-24 12:43:53 +00:00
trifonnt 6de8036d6d FR [2975307] - AD_Menu_Trl overwritten by AD_Window
https://sourceforge.net/tracker/index.php?func=detail&aid=2975307&group_id=176962&atid=879335
2010-03-24 09:30:10 +00:00
felixmoeller 92f9734f66 missing linebreak 2010-03-24 09:06:35 +00:00
trifonnt cde982394c FR [2965494] - Import Order: Import of Order Source
https://sourceforge.net/tracker/?func=detail&aid=2965494&group_id=176962&atid=883808
2010-03-23 16:58:48 +00:00
Redhuan D. Oon 0f3dfed4cf Reverting to original setApplyAccessFilter params
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-23 14:10:07 +00:00
Redhuan D. Oon 6950243e5b Extending setApplyAccessFilter to control params
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-23 13:35:21 +00:00
Carlos Ruiz 71fa1d0ad8 Fix [2889652] - Synchronize terminology fails
solving the root problem I changed the element index from columnname to upper(columnname)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2889652
2010-03-22 19:50:53 +00:00
Carlos Ruiz 91b2eca6b3 FR [2897194] Advanced Zoom and RelationTypes - Thanks to Tobias Schöneberg (tobi42)
minor fix and added connection between BP and return windows
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2897194
2010-03-22 19:13:32 +00:00
trifonnt 482bb9ad09 minor typo fixes. 2010-03-22 16:48:26 +00:00
trifonnt 8f79bb25de Bug Fix. Small typo in ImportOrder class, leads to issues during import.
FR [2965494] - Import Order: Import of Order Source
https://sourceforge.net/tracker/?func=detail&aid=2965494&group_id=176962&atid=883808
2010-03-22 14:54:42 +00:00
Redhuan D. Oon a0ede8fc6f FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in progress, require Teo's advice on how to set Role, User and tearDown() trxName
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-22 01:36:12 +00:00
Redhuan D. Oon d8cf0e8621 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-21 02:59:39 +00:00
Carlos Ruiz 93fbc42293 FR [2897194] Advanced Zoom and RelationTypes - Thanks to Tobias Schöneberg (tobi42)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2897194
2010-03-20 12:51:35 +00:00
Redhuan D. Oon 08c4a7090f FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-20 11:18:11 +00:00
Redhuan D. Oon 1175c2cab5 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-20 09:50:22 +00:00
Redhuan D. Oon 984f3085e5 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-20 05:46:48 +00:00
Carlos Ruiz 0e7a09116d Fix [2815046] ImportGLJournal lock on ad_sequence
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2815046
2010-03-19 19:27:35 +00:00
teo_sarca ecdd7276bd BF [ 2973298 ] NPE on CLogErrorBuffer
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2973298
2010-03-19 16:17:24 +00:00
Redhuan D. Oon aa0454f847 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit tests in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-19 07:32:01 +00:00
Redhuan D. Oon 8338c1f05c FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-18 23:02:06 +00:00
vpj-cd 424c34fe13 https://sourceforge.net/tracker/?func=detail&atid=879332&aid=2001910&group_id=176962
Now Physical Inventory can be completed avoid if the cost are in zero. it allow that the operation is not stop.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2001910
2010-03-18 20:15:24 +00:00
Redhuan D. Oon eb502e32a8 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-18 16:35:55 +00:00
Redhuan D. Oon af0d7d9cc4 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-18 11:28:31 +00:00
Redhuan D. Oon afc5065246 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-18 10:42:42 +00:00
Heng Sin Low b75ad04ac7 Implementing new Summary flag in Report View
- Replace use of context variable with API change to fixed that the summary flag value is global to all report windows.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2011569
2010-03-18 05:18:02 +00:00
Carlos Ruiz 8c1813b408 FR [2962094] Finish implementation of weighted average costing - found problems when committing immediate inout and invoice - the generated matchinv and matchpo must be posted after
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962094
2010-03-18 01:15:25 +00:00
trifonnt 41c1d5a2ad minor typo fix in java doc. 2010-03-18 00:04:34 +00:00
Carlos Ruiz 8e1b381e90 Peer review revision 11690 - refactoring, this version is more compact and uses the cache
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-17 19:17:46 +00:00
Carlos Ruiz d3741a31b2 Peer review revision 11673, 11675, 11688 - some refactoring
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-17 19:09:57 +00:00
Carlos Ruiz 9ddd353e0b Peer review revision 11671 - please read comments on tracker
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-17 18:56:04 +00:00
felixmoeller 43fc4108f7 just small typo 2010-03-17 17:33:18 +00:00
Redhuan D. Oon ecd27322e9 following Teo's advice about using firstOnly()
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-17 13:31:00 +00:00
Redhuan D. Oon 6de09769ff following Teo Sarca's advice to use 'false' instead of 'N'. Tested with JUnit, all values passed.
Thanks to Teo
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-17 13:28:24 +00:00
tspc 478075d45d Merge bug fixes from release into trunk
merge -r 11666:11670 -r 11677:11680 -r 11682:11684

11666-11670 -> Fix Eclipse warnings/ERROR
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2970867

11677 -> Fix - Firstof Function Week Constant
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2079794

11678 -> The revision 7509 introduced a bug because of bad programming
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2001910

11679 -> Integrate fix contributed by mcicchelli for [2514168] Port missing connect for Test.sql
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2514168

11680 -> minor - fix typos in comments

11682 -> [2971637] DB.executeUpdate working as autocommit if trx is not opened
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2971637

11683 -> Client Accounting Processor - fix a problem found, it was not updating Posted status on posting failure
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2857289

11684 -> Firstof Function Week Constant - scripts swapped - thanks to Armen by the peer review
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2079794
2010-03-17 10:57:46 +00:00
Redhuan D. Oon ae453e8948 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (unit tested ok but subject untested)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-17 09:37:15 +00:00
Redhuan D. Oon a25b4c6260 Following Carlos Ruiz advice on maintaining old methods as removed in revision 11673
JUnit test to follow.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-17 08:42:48 +00:00
Redhuan D. Oon 482a81f3f6 Following Carlos Ruiz advice on maintaining old methods as removed in revision 11673
JUnit test to follow.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-17 08:24:25 +00:00
trifonnt 0507908f58 Fixed ADempeire Eclipse launch configuration in multiple project setup.
Now Jasper reports can be started from inside Eclipse.
2010-03-16 15:12:11 +00:00
Redhuan D. Oon bcea2db3d8 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-16 10:04:31 +00:00
Redhuan D. Oon fe3a1ef173 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-16 09:42:45 +00:00
trifonnt 4b73c696ba FR [2970674] - Import Order: Import Delivery Rule
https://sourceforge.net/tracker/?func=detail&aid=2970674&group_id=176962&atid=883808
2010-03-15 14:15:12 +00:00
teo_sarca a1942f8043 BF [ 2970200 ] Enable Native Sequences not working
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2970200
2010-03-14 21:22:57 +00:00
Carlos Ruiz 1784eebf02 BF [2968442] - Post without Application Server - journals and Allocations / Deprecate old way of TESTING -> AD_Client.IsPostImmediate
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2968442
2010-03-14 05:23:15 +00:00
Carlos Ruiz a8d4ee3e05 Fix bug [1966880] - Scheduled Processes only run in System client
https://sourceforge.net/tracker/index.php?func=detail&aid=1966880&group_id=176962&atid=879332
Fix bug [1926032] - Schedule incorrectly identified variables
https://sourceforge.net/tracker/index.php?func=detail&aid=1926032&group_id=176962&atid=879332
See additional documentation on http://www.adempiere.com/index.php/ManPageW_Scheduler#Contributions
2010-03-14 00:39:16 +00:00
Carlos Ruiz 3b06eb7a0a Fix [1904717] Invoice reversing has incorrect doc status
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=1904717
2010-03-11 23:04:11 +00:00
Carlos Ruiz bdc810b343 Fix bug [2832350] Enabling trace log file create one file per line in /tmp
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2832350
2010-03-11 19:58:32 +00:00
Carlos Ruiz 2ce294bb10 BF [2897730] - Bank Transfer improvements and fixes - make DocumentNo mandatory
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2897730
2010-03-11 19:21:37 +00:00
Carlos Ruiz f59b902a34 FR [2962094] - Finish implementation of weighted average costing - Created the default account P_AverageCostVariance_Acct
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962094
2010-03-09 02:59:57 +00:00
trifonnt 2e49d21ca4 FR [2965494] - Import Order: Import of Order Source
https://sourceforge.net/tracker/?func=detail&aid=2965494&group_id=176962&atid=883808
Set proper Error message when Order Source is not found.
Thank's to Carlos for the review!
2010-03-08 23:49:32 +00:00
Carlos Ruiz fd63d9af1e Revert revision 11432 - comments in tracker
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2904144
2010-03-08 22:26:22 +00:00
Carlos Ruiz 8e2dc1b771 Revert revision 11419 - comments in tracker
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2949927
2010-03-08 22:17:46 +00:00
Carlos Ruiz 0392c5a175 Peer review revisions 11587, 11588, 11589, 11591, 11592, 11601, 11602, 11603, 11604, 11605, 11606, 11607 - just applying some best practices
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-08 22:10:23 +00:00
trifonnt ec9937f54e FR [2965494] - Import Order: Import of Order Source
https://sourceforge.net/tracker/?func=detail&aid=2965494&group_id=176962&atid=883808
2010-03-08 16:09:28 +00:00
trifonnt 19d419e47d Reverting usage of MQuery for MTable class.
ADemepire is not even able to start from Eclipse.
Please next time at least try to start ADemepire from Eclipse.
https://sourceforge.net/tracker/index.php?func=detail&aid=2214883&group_id=176962&atid=879335
2010-03-08 08:37:06 +00:00
vpj-cd 370a752666 FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-07 19:41:38 +00:00
vpj-cd 30225c49c9 Remove SQL code and Replace for Query
Red1 please review your code before to commitment, or commitment after the units test, some implementor are using trunk in production

kind regards
Victor Perez
www.e-evolution.com
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-07 18:52:18 +00:00
vpj-cd 691b689ee7 Remove SQL code and Replace for Query
Red1 please review your code before to commitment, or commitment after the units test, some implementor are using trunk in production

kind regards
Victor Perez
www.e-evolution.com
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-07 18:06:05 +00:00
Redhuan D. Oon 14046997c8 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-07 16:25:43 +00:00
Redhuan D. Oon f95f2f2f6d FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-06 16:22:12 +00:00
Redhuan D. Oon 3ad07bd33d FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-06 16:04:20 +00:00
Carlos Ruiz 04229f1a2e Second step: Implement AcctProcessor to post the documents in the order they were processed
FR [2962094] Finish implementation of weighted average costing
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962094
2010-03-06 01:09:26 +00:00
Redhuan D. Oon 305a239f1a FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 18:45:25 +00:00
Redhuan D. Oon 0ff7666a2b FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 18:38:40 +00:00
Redhuan D. Oon 64d83bfa5e FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 18:33:17 +00:00
Redhuan D. Oon c61ce5d86d FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 14:49:46 +00:00
Redhuan D. Oon 8d6cd95f50 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 14:34:10 +00:00
tspc bb529d9197 Merge bug fixes in release not committed to trunk
merge -c 11561 -c 11581 -c 11582

11561 -> Fix [2962787] Recursion in PO.set_ValueNoCheckE
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962787

11581 -> Fix [2948897] Fixed Assets Dictionary Errors - wrong reference to column A_Depreciation_Entry.A_Type_Entry
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2948897

11582 -> Fix [2948897] Fixed Assets Dictionary Errors - wrong reference on processed columns
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2948897
2010-03-04 23:11:37 +00:00
Carlos Ruiz fe13d23bb0 peer review for 11559, 11560 - refactor MRule.getModelValidatorLoginRules to avoid double array management
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-04 00:24:46 +00:00
Carlos Ruiz 21f04ba76f peer review for 11555
- refactorings to use setClientID and setOnlyActiveRecords
- check serialVersionUID on affected classes
- add final to whereClauses
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-04 00:06:16 +00:00
Carlos Ruiz 08e0deb5cd peer review for 11554
- incompatible objects in MMovement
- other refactorings
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 23:38:19 +00:00
Carlos Ruiz 1a06e21024 peer review for 11547 - minor changes
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 23:04:46 +00:00
Carlos Ruiz 98c74ef980 peer review for 11545 and 11546 - refactored getProductLot to have predictable results
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 22:40:26 +00:00
Carlos Ruiz ff9dffd082 peer review for 11541 - be careful with logic: an exception is not equivalent to a log.info
refactored to use .setClientID()
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 22:13:54 +00:00
Carlos Ruiz e7177049db peer review for 11533, 11537, 11540
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 21:43:37 +00:00
Carlos Ruiz d9b22ee7ed peer review for 11539
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 21:13:05 +00:00
Carlos Ruiz 791f4a8624 peer review for 11538 -> drop unused lines in ExportHelper - apply the same practice to ImportHelper, fix warning on ExportFormatGenerator
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 20:09:00 +00:00
Carlos Ruiz 6b59db69ed peer review for 11535 -> getBPartnerCashTrx refactored with junit test applied
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 19:47:16 +00:00
Redhuan D. Oon ab5b31fe9a FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 07:51:30 +00:00
Carlos Ruiz dfe03fabfa FR 2962094 - Finish implementation of weighted average costing
1st step -> create column to manage the processed date+time (in order to allow reposting of documents in the same order they were completed - this will be the second step)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962094
2010-03-03 01:31:36 +00:00
phib 5fdefd4be3 Future dated price list version used in order
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962244
2010-03-02 22:59:41 +00:00
vpj-cd d6e3780968 Apply ADempiere Best Practice and change the Collection by List as standard in ADempiere
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 17:15:59 +00:00
Redhuan D. Oon 3486415202 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:44:42 +00:00
Redhuan D. Oon 7fb5e6b54d Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:43:25 +00:00
Redhuan D. Oon d2333e9026 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:38:35 +00:00
Redhuan D. Oon 5fba554eab Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 07:18:20 +00:00
Redhuan D. Oon 83154f494f FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 06:39:45 +00:00
Redhuan D. Oon c0d989b240 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test included (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 00:42:03 +00:00
Redhuan D. Oon a3cf7e8d37 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 22:41:26 +00:00
Redhuan D. Oon b690a934d3 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 09:55:38 +00:00
Redhuan D. Oon 042083872b Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Heng Sin's advice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 05:12:58 +00:00
Redhuan D. Oon 490cb806df Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Heng Sin's advice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 04:39:28 +00:00
Redhuan D. Oon e80c558107 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 04:24:19 +00:00
Redhuan D. Oon 583954e3eb FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 02:01:59 +00:00
Carlos Ruiz 03153697fe Peer review 11500, minor - drop useless comment, organize imports
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 21:06:50 +00:00
Carlos Ruiz cc7809b482 Apply Best Practices to Promotions Code: Use Model Classes instead of X_ classes whenever possible 2010-02-27 20:38:11 +00:00
Carlos Ruiz 1210dab275 Peer review 11504, be careful, you need to check retValue for null to avoid NPE
refactored to use common MProduct constructor
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 19:54:34 +00:00
Carlos Ruiz 94812caebc Peer review 11501, be careful with the login being replaced
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 19:38:25 +00:00
Carlos Ruiz 4a552b9877 Peer review 11499, fix error reported by Mario
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 19:23:17 +00:00
mjudd baa578cdfb [ BF 2960239 ] - Promotion Minimum Amt > 0
In the promotion line if the minimum amount is 0.00 (default) then the line
is not fired because the Promotion rule only activates when the minimum
amount is > 0. This means if you always want the rule to fire - you need
to make the minimum 0.01 which is not logical if you want no minimum.
https://sourceforge.net/tracker/?func=detail&aid=2960239&group_id=176962&atid=879332
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2960239
2010-02-27 15:41:14 +00:00
mjudd 139f65a82e [ BF 2960231 ] - PromotionValidator not fired in correct client
The promotion validator document validator is not fired because the client
id in the listener is not set correctly before adding the table to the
Model Validation Engine
https://sourceforge.net/tracker/?func=detail&aid=2960231&group_id=176962&atid=879332
2010-02-27 15:21:37 +00:00
Redhuan D. Oon bb3a54da57 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 14:05:19 +00:00
Redhuan D. Oon 9aa3c31c35 Prevent SQL Injection (advice from Victor Perez)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 09:02:32 +00:00
mjudd 38396298cd [ FR 2836965 ] Group1 and Group2 fields are not considered in Schema Lines (Fixed)
http://sourceforge.net/tracker/index.php?func=detail&aid=2836965&group_id=176962&atid=879335
[ FR 1871403 ] Adding new field of product into Price List Schema (Fixed)
http://sourceforge.net/tracker/index.php?func=detail&aid=1871403&group_id=176962&atid=879335
Converted to CPrepraedStatement to avoid string injection and fixed "AND" logic
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2836965
2010-02-27 08:10:40 +00:00
tspc cd4c15c059 Merge bug fixes in release not committed to trunk
merge -c 11478 -c 11471 -c 11374
BF2958108	Answer in Workflow Activities keeps adding Yes/NO
https://sourceforge.net/tracker/?func=detail&atid=955896&aid=2958108&group_id=176962

BF2957689	Material Receipt -> Create From -> Only same wh not working
https://sourceforge.net/tracker/?func=detail&atid=955896&aid=2957689&group_id=176962

BF2815307 Default Tax Error
https://sourceforge.net/tracker/?func=detail&atid=879332&aid=2815307&group_id=176962
2010-02-27 06:16:16 +00:00
vpj-cd ec4e2f798a FR: [ 2214883 ] Remove SQL code and Replace for Query
Applying defensive programming approach and ABP.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 06:12:53 +00:00
Redhuan D. Oon 998d5c20f5 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Heng Sin's advice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 02:47:51 +00:00
Redhuan D. Oon 0da2f340e7 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 02:26:04 +00:00
Redhuan D. Oon 8df91cee04 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test included (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 11:39:31 +00:00
Redhuan D. Oon dd7b9b1341 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test included (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 10:21:04 +00:00
Redhuan D. Oon 5b537cf891 Typo error at MBOM 2010-02-26 07:27:43 +00:00
Redhuan D. Oon 7cd1ead853 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test included (no failures). Please clean up M_BOM test record afterwards.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 07:07:32 +00:00
Redhuan D. Oon 8cd9f28474 FR: [ 2214883 ] Remove SQL code and Replace for Query (implementing review by Carlos, Hengsin and Victor - call to interface rather than model class for tablename. JUnit tests carried out again before commit
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 02:51:35 +00:00
Heng Sin Low fa569115e1 The window context variable is share by all tab and can get mix up when user navigate from one tab to another. This patch recreate the window context variable before entering a tab to solve the potential conflict issue.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2959339
2010-02-26 02:07:55 +00:00
Heng Sin Low 1516f063b5 don't have to add setParameter(int), we just need to replace setParameters(Object[] parameters) with setParameters(Object ...parameters)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 01:02:06 +00:00
Carlos Ruiz 0725d135a9 Peer review of FR: [ 2214883 ] Remove SQL code and Replace for Query
revisions 11482, 11484, 11485, 11487, 11488, 11489, 11490
- Added method Query.getParameters(int) to improve readability (if most of the replacements just use one int parameter it makes sense to avoid the declaration of new Object[] all the times)
- drop unused imports
- check serialVersionUID
- what is the advantage of using I_M_Product_BOM.Table_Name instead of MProductBOM.Table_Name when defining a list of MProductBOM objects? and it's intended that MProductBOM must always implement the interface

Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 00:29:57 +00:00
vpj-cd 1603524916 Apply ABP http://www.adempiere.com/index.php/ADempiere_Best_Practices#How_to_use_Adempiere_Query_class.3F
//FR: [ 2214883 ] Remove SQL code and Replace for Query

Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-25 21:32:06 +00:00
Redhuan D. Oon 398eaf6f10 FR: [ 2214883 ] Remove SQL code and Replace for Query (thanks Trifon for the last review and correction.
-- JUnit test included (no failures)
2010-02-25 21:08:04 +00:00
trifonnt 025e667dd2 FR: [ 2214883 ] Remove SQL code and Replace for Query
Please keep transaction.
Old code used transaction, so new should also use transaction.
http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-25 19:30:58 +00:00
trifonnt fea9618e40 FR: [ 2214883 ] Remove SQL code and Replace for Query
Please keep transaction.
old code used transaction, so new should also use transaction.
http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-25 19:27:08 +00:00
Redhuan D. Oon 011ec4a4d6 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test included (no failures)
2010-02-25 16:03:58 +00:00
Redhuan D. Oon 5d0fe54df9 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test included (no failures)
2010-02-25 14:21:59 +00:00
mjudd d4834a9372 [ FR 2836965 ] Group1 and Group2 fields are not considered in Schema Lines (Fixed)
http://sourceforge.net/tracker/index.php?func=detail&aid=2836965&group_id=176962&atid=879335
[ FR 1871403 ] Adding new field of product into Price List Schema (Fixed)
http://sourceforge.net/tracker/index.php?func=detail&aid=1871403&group_id=176962&atid=879335
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2836965
2010-02-25 13:12:33 +00:00
Redhuan D. Oon 8aaa009751 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- I am begining to use JUnit test and commit them as i go along also. Please advice where need be, or
-- If OK, i shall remove more SQLs from ADempiere :)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-25 08:12:39 +00:00
Heng Sin Low 2a74599b51 Fixed postgresql bug for virtual table:
* postgresql need trx to use cursor based resultset
* must set fetchsize for postgresql otherwise it will load the whole resultset into memory

Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2913975
2010-02-24 06:27:04 +00:00
phib eb40b62629 FR 2957782: Add due date to Pay selection create
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2957782
2010-02-24 05:22:02 +00:00