Commit Graph

3689 Commits

Author SHA1 Message Date
Zuhri Utama e61eab3901
IDEMPIERE-2706 : auto validate invoice payment schedule when create new record (#2034) 2023-10-02 10:02:46 +08:00
hieplq e27b588754
IDEMPIERE-5867:autocomplete show different list for table and table dir (#2028)
* IDEMPIERE-5867:autocomplete show difference list for table and table dir

* IDEMPIERE-5867:fix for IDEMPIERE-5866

test case:
    go to "Reference" window and choose for record "M_Product BOM (stocked)"
    go to "Table Validation" tab and choose "Display Value" = true
2023-10-01 22:04:50 +08:00
Carlos Ruiz c994581aef
IDEMPIERE-5229 After migrate helper (FHCA-4070) (#2031)
- Improve validation of views
2023-09-30 11:44:25 +08:00
Zuhri Utama 34485f97f8
IDEMPIERE-5862 : Move Always Updatable Payment Rule to Dictionary (#2023)
* IDEMPIERE-5862 : Move Always Updatable Payment Rule to Dictionary

* Update oracle/202309261054_IDEMPIERE-5862.sql

* Update postgresql/202309261054_IDEMPIERE-5862.sql

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-09-26 13:49:25 +02:00
hieplq d28c6eb9d8
IDEMPIERE-5849:MRole.getDefault make phantom role on cache (#2020)
patch from Heng Sin

Co-authored-by: hengsin <hengsin@gmail.com>
2023-09-22 14:17:34 +08:00
hengsin 6840b8aeb6
IDEMPIERE-5346 : Adding SSO support (#2018)
- peer review
2023-09-21 16:48:30 +08:00
Deepak Pansheriya 680f9f3757
IDEMPIERE-5346 : Adding SSO support (#1571)
* IDEMPIERE-5346 : Adding SSO support

* IDEMPIERE-5346 : Fix as per peer review feedback.
Valid user should have password not null
removing #SSO_IS_ALREADY_AUTHENTICATE context variable due to security risk
Cross site scripting issue on error.htm
Making show role panel as system configurable
Adding language selection on role panel
Adding SSO support on iDempiere monitor and osgi console

* IDEMPIERE-5346: Redirect to console using static URL to avoid security vulenarabilit

* Committing patch from Carlos pr1571PR

* IDEMPIERE-5565: fixing NPE issue on Role change

* IDEMPIERE-5346: Appling pr1571PR2 from Carlos

* 1. IDEMPIERE-5346: Fix idempiereMonitor goes in a loop of sign-in
- Fix NPE when changing role
- Fix NPE when a user with single role & sysconfig: SSO_SELECT_ROLE is 'N'

* IDEMPIERE-5346 : IDempiere Monitor, use out of box login when SSO is not configured.

* IDEMPIERE-5346: Adding Authorization type on User and Tenant window. Created /webui/admin page for login with application credential.

* IDEMPIERE-5346: Implementing Hengsi's Code review comments
Showing meaning full error when Identity Provider returns error
In SSO filter, ignoreing css, zkau, images and resource URL
Correcting typo in Principal name.
Updated Documentation

* IDEMPIERE-5346 : Fixed documentation, typo and pending review comments

* IDEMPIERE-5346: Use token & SSO principal service to validate in Login.GetClient

* IDEMPIERE-5346: Remove the Domain URL column and refactor the code.

* IDEMPIERE-5346: Adding flag ENABLE_SSO_IDEMPIERE_MONITOR and ENABLE_SSO_OSGI_CONSOLE, using cache for SSOService, defaulting Authentication type on client to “Application and SSO”

* IDEMPIERE-5346: Fixed issue of User SSO type not respected and support for Zoom URL
2023-09-21 16:43:49 +08:00
Carlos Ruiz 7c486df524
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#2013)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

- Fix for MAttachment.get
- discovered while testing rest endpoing api/v1/models/testuu/{uuid}/attachments/zip

* - remove the deprecated message
- use UU just when there is no ID
2023-09-19 22:24:09 +08:00
Carlos Ruiz 7e5a1d89ee
Revert "IDEMPIERE-5826 iDempiere REST can insert/update an invalid foreign key (#1969)" (#2014)
This reverts commit db833e3665.
2023-09-19 22:21:08 +08:00
Nicolas Micoud 4c4981533e
IDEMPIERE-5856: MOrder.setBPartner is not using IsSOTrx for PaymentRule (#2012)
* IDEMPIERE-5856: MOrder.setBPartner is not using IsSOTrx for PaymentRule

* IDEMPIERE-5856: MOrder.setBPartner is not using IsSOTrx for PaymentRule

serial update

* IDEMPIERE-5856: MOrder.setBPartner is not using IsSOTrx for PaymentRule

 if getPaymentRulePO() is null, we fall back to getPaymentRule()
2023-09-19 21:04:18 +08:00
Zuhri Utama 1efe7a4ac5
IDEMPIERE-4697 : temporary filename "adempiere_" (#2000)
* IDEMPIERE-4697 : get temp filename based on config "TEMP_FILENAME" if exists

* IDEMPIERE-4697 : temporary filename "adempiere_"

* IDEMPIERE-4697 : set default value and change from adempiere to idempiere
2023-09-18 14:44:21 +02:00
Carlos Ruiz d665c2b051
IDEMPIERE-5854 Error when trying to call ServerReportCtl.runJasperProcess with a process info without a transaction name (#2009) 2023-09-15 14:21:34 +02:00
Carlos Ruiz 209663d32a
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#2008)
- MappedModelFactory check and register UUID constructor
2023-09-14 20:18:46 +08:00
Vitor Henrique Dos Santos d7d4504271
IDEMPIERE-5852 Change broadcastmessage column size (#2002)
* IDEMPIERE-5852 Change broadcastmessage column size

* IDEMPIERE-5852 Patch applied
2023-09-14 14:13:24 +02:00
hengsin 39d159d44a
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - AD_PInstance (#2005)
- Fix unit test errors
2023-09-13 12:48:54 +08:00
Carlos Ruiz 7c8fe24435
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - AD_PInstance (#2003)
- Implement support to run processes on UUID based tables
- Added SvrProcess.getRecord_UU and getRecord_UUs support
- Added TestUUChangeActive process as toolbar button on "Test UU Based Table" window - supports single and multi
- Added AD_PInstance.AD_Table_ID and AD_PInstance.Record_UU
- NOTE: the migration script tries the best to fill AD_PInstance.AD_Table_ID from different sources, but at the end is very possible that some records will be left with empty table
- The MPInstance constructors that don't manage AD_Table_ID were marked as deprecated to ease discovering the missing parts in plugins
2023-09-13 10:59:21 +08:00
Carlos Ruiz c0a1756043
IDEMPIERE-5843 System support users (like SuperUser) cannot see (fix) preferences on tenants (#1994)
* IDEMPIERE-5843 System support users (like SuperUser) cannot see (fix) preferences on tenants (#1992)

IDEMPIERE-5174 / Revert changes from IDEMPIERE-4386

* - remove the same now unnecessary method on MMFARegistration
2023-09-06 09:44:09 +08:00
Nicolas Micoud 51c3bf5e0c
IDEMPIERE-5827: AD_Preference.PreferenceFor should support Forms (#1970)
* IDEMPIERE-5827: AD_Preference.PreferenceFor should support Forms

https://idempiere.atlassian.net/browse/IDEMPIERE-5827

* IDEMPIERE-5827: AD_Preference.PreferenceFor should support Forms : scripts on iD11

* IDEMPIERE-5827: AD_Preference.PreferenceFor should support Forms - remove changes related to Info Window

* IDEMPIERE-5827: AD_Preference.PreferenceFor should support Forms : remove changes related to Info Window

* Update oracle/202308101331_IDEMPIERE-5827.sql

* Update postgresql/202308101331_IDEMPIERE-5827.sql

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-09-05 15:43:01 +02:00
Nicolas Micoud f0bdcbb913
IDEMPIERE-5844: Add missing field / code for AD_Preference.AD_InfoWin… (#1993)
* IDEMPIERE-5844: Add missing field / code for AD_Preference.AD_InfoWindow_ID

https://idempiere.atlassian.net/browse/IDEMPIERE-5844

* Update oracle/202309041344_IDEMPIERE-5844.sql

* Update postgresql/202309041344_IDEMPIERE-5844.sql

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-09-05 13:15:01 +02:00
hengsin db4f715537
IDEMPIERE-5841 AD_Note created by Request causing Cross Tenant (#1991) 2023-09-05 16:02:28 +08:00
Nicolas Micoud 562283fe48
IDEMPIERE-5760: Manage mail.smtp.timeout using SysConfig (#1982)
https://idempiere.atlassian.net/browse/IDEMPIERE-5760

https://github.com/idempiere/idempiere/pull/1883 + changes requested by Carlos (migration script)
2023-09-02 16:38:13 +02:00
Carlos Ruiz eee6f449c3
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1985)
- Fix issue caused by last changes - the *SelectionGrid fields are not working because they don't have a formal Reference
2023-09-01 10:41:41 +08:00
Carlos Ruiz fd986b4130
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - MigraID (#1986)
Fixes for the MigraID process:
- Add management for AD_Tree_Favorite_Node
- Add management for multi-IDs fields (comma separated IDs or UUIDs)
- Add management for AD_Package_UUID_Map
- Fix issues with UUID based tables
2023-09-01 10:40:25 +08:00
Carlos Ruiz 954b3b2fec
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1976)
- Fix 2Pack to work with UUID based tables
- Implement ability for PackOut/PackIn multi ID columns
2023-08-26 09:49:39 +08:00
Carlos Ruiz c1d8a50b12
IDEMPIERE-5837 Collect all System Properties of iDempiere in one class (#1980) 2023-08-26 09:39:53 +08:00
Deepak Pansheriya e902ce13bc
IDEMPIERE-5768 : committing osgi service definition XML file for default credit manager factory. (#1975) 2023-08-23 19:37:48 +08:00
Deepak Pansheriya 18f925fd2f
IDEMPIERE-5768 : Adding Credit manager factory to override or extend … (#1949)
* IDEMPIERE-5768 : Adding Credit manager factory to override or extend credit management

* IDEMPIERE-5768 : Fixing as as per code review comments from Hengsin

* IDEMPIERE-5768: Use component annotation instead of xml service definition

* IDEMPIERE-5768: Adding Unit tests and Making return type of CheckCreditStatus to be object instead of String.

* IDEMPIERE-5768: Fixing as per code review comment.

* IDEMPIERE-5768: Removed explicit rollback from test cases
2023-08-23 09:39:24 +08:00
Carlos Ruiz 5aba739d37
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1963)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

- fix issues with archive reporting on UU based tables

* - implement change log in time line mode for UUID based tables

* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

* Fixes and improvements for MoveClient
  * Fix for oracle not being able to insert AD_WF_Node (CLOB column)
  * Add management for UUID based tables
  * Add management for weak foreign key Fact_Acct.Line_ID
  * Add management for weak foreign key AD_Tree_Favorite_Node.Parent_ID
  * Add management for Record_UU columns
  * Add management for ChosenMultipleSelectionTable and ChosenMultipleSelectionSearch
  * Improve javadoc

* - Test and add support for SelectionGrid

* - fix error inserting a wrong UUID when it was set before by a Record_UU

* - Fix problem validating orphans in UUID based tables
2023-08-22 20:08:33 +08:00
Carlos Ruiz db833e3665
IDEMPIERE-5826 iDempiere REST can insert/update an invalid foreign key (#1969) 2023-08-15 16:51:44 +08:00
hengsin 66b7b20619
IDEMPIERE-5275 Tabular Report Re-Run button/close parameter window (#1962)
* IDEMPIERE-5275 Tabular Report Re-Run button/close parameter window

- Fix process info log & error not shown
- Fix re-run missing context variable from menu

* IDEMPIERE-5275 Tabular Report Re-Run button/close parameter window

- turn off auto close after zoom
2023-08-09 16:00:00 +02:00
Diego Ruiz f1a0f7aac1
IDEMPIERE-5823 - Improve MUserMail constructors to behave equally in every case (#1967) 2023-08-09 12:56:10 +08:00
hengsin e46d57e1ea
IDEMPIERE-5812 Reversal of Material Receipt for a Closed PO leave quantity ordered of product in a bad state (#1964) 2023-08-08 14:02:28 +02:00
hengsin 03c6187fde
IDEMPIERE-5813 Change Role must close session like Logout does (#1959)
* IDEMPIERE-5813 Change Role must close session like Logout does

* IDEMPIERE-5813 Change Role must close session like Logout does
2023-08-01 19:14:26 +02:00
Carlos Ruiz 159fbbd04c
IDEMPIERE-5732 Cache reset should happens after commit of transaction (#1850)
* IDEMPIERE-5732 Cache reset should happens after commit of transaction

* IDEMPIERE-5732 Cache reset should happens after commit of transaction

* - minor defensive programming

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-08-01 19:53:11 +08:00
Carlos Ruiz 6e0645f90c
IDEMPIERE-5818 AD_Session cache is not working (#1960) 2023-08-01 10:46:28 +08:00
hengsin 890862de47
IDEMPIERE-4416 invalidating a purchase order doesn't remove connectio… (#1942)
* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- refactoring, make MiniTableImpl usable outside of test

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- refactoring, move business and sql logic from Match to model class.
- add more unit test

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- set M_InOut.C_Order_ID to null

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- update unit test for setting of M_InOut.C_Order_ID to null.
2023-07-31 15:20:26 +02:00
Jasper Siepkes f689b0f630
IDEMPIERE-5807 Add ability to specify attribute set when importing products (#1950) 2023-07-29 10:13:07 +08:00
Carlos Ruiz 9206dda962
IDEMPIERE-5785 Review of tables/columns that should/should not be logged (#1943)
* IDEMPIERE-5785 Review of tables/columns that should/should not be logged

* - suggest to delete also logs from AD_Wlistbox_Customization
2023-07-17 09:43:16 +08:00
Peter Takács ca98a81671
IDEMPIERE-5772 - Quick Info Widget Support for Info Window (#1899)
* IDEMPIERE-5772 - Quick Info Widget Support for Info Window - initial commit

* IDEMPIERE-5772 - manage context variables in info window

Put the following values into the context:
- query criteria
- values of the selected row

* IDEMPIERE-5772 - fixes

- info window should not change context if isLookup() = true (popup window mode)
- parameter values should be put into context only on re-query
- values of KeyNamePair type should use the "key" in context (practically tat means the ID) instead of name (display value)

* IDEMPIERE-5772 - add prefix to row variables and Selected_ID to ctx

* IDEMPIERE-5772 - rename variable name Selected_ID -> ID_Selection

* IDEMPIERE-5772 - patch by Carlos

* IDEMPIERE-5772 - fixed reported issues

- support ctx variables in info windows without process (no multiselection)
- change ctx variable syntax/prefix
- fix issue with type IDColumn
2023-07-16 17:33:58 +02:00
hengsin 407b756cb8
IDEMPIERE-5800 Info Window Context Variables are not Cleared after Closing (#1937) 2023-07-16 16:02:44 +02:00
hengsin 8786d8a51f
IDEMPIERE-5525 GetWarehouse method ordering storage records by M_Locator_ID (#1941) 2023-07-16 15:12:59 +02:00
Peter Takács 750e38d3b2
IDEMPIERE-5799 - Storage Reservation Log does not set Organization Correctly (#1935)
* IDEMPIERE-5799 - Storage Reservation Los des not set Warehouse Correctly

* IDEMPIERE-5799 - requested changes by Heng Sin
2023-07-15 10:48:31 +08:00
Nicolas Micoud 3b055d30e0
IDEMPIERE-5796: Generate Model Template (#1931)
* IDEMPIERE-5796: Generate Model Template

Initial commit (migration scripts / model classes / process)

* IDEMPIERE-5796: Generate Model Template

update parameters value from template

* IDEMPIERE-5796: scripts in v10

Scripts must be set in v10

* IDEMPIERE-5796: Generate Model Template - fix scripts

* IDEMPIERE-5796: Generate Model Template - various fixes

Improve help, fix warning and change TableName parameter name

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-5796: Generate Model Template - remove System.out

* IDEMPIERE-5796: Generate Model Template : EntityType parameters as multitable

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-5796: Generate Model Template : parameters to generate interfaces and/or classes

and enhancement of help

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-07-13 15:59:41 +02:00
Elaine Tan eed078308c
IDEMPIERE-5757 immediate post: Payment REVERSE/CORRECT allocation document NOT posted (#1922)
* IDEMPIERE-5757 immediate post: Payment REVERSE/CORRECT allocation document NOT posted
2023-07-10 21:38:31 +08:00
Nicolas Micoud b28735509d
IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlud… (#1928)
* IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlude end date

https://idempiere.atlassian.net/browse/IDEMPIERE-5794

* IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlude end date - Unit tests

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2023-07-10 14:41:39 +08:00
Carlos Ruiz b7c089fc1d
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Implement support for Requests on UUID Based Tables (#1910)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Implement support for Requests on UUID Based Tables

* - minor typo

* - improve javadoc
2023-07-08 12:09:56 +08:00
Elaine Tan fce4d5cf9c
IDEMPIERE-5591 Payment allocation AP/AR GL postings not zero in alternative schema for invoice REVERSE/CORRECT (#1921) 2023-07-08 11:37:17 +08:00
Carlos Ruiz 34a33ba06f
IDEMPIERE-1437 Do not allow changing Table in Tab when there are Fields (#1927) 2023-07-08 11:17:37 +08:00
Nicolas Micoud 71a49baf00
IDEMPIERE-5795: DeveloperMode context variable (#1929)
https: //idempiere.atlassian.net/browse/IDEMPIERE-5795

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-07-08 10:42:57 +08:00
Zuhri Utama 00c4fec2f4
JIRA TICKET : https://idempiere.atlassian.net/browse/IDEMPIERE-1502 (#1926) 2023-07-06 12:15:39 +08:00
Zuhri Utama 9f55c76573
IDEMPIERE-5062 validation when run process and input min max value on process parameter (#1908)
* - added validation for min and max value when run process
- added validation when insert min and max value format

* - remove unused class
- change reference id to displayType
- translate error massage

* refactoring code by carlosRuiz-globalqss
2023-07-03 17:14:16 +02:00
Carlos Ruiz b7b0b16476
IDEMPIERE-5750 Error when switching to tab when choosing a language other than English (#1920)
* IDEMPIERE-5750 Error when switching to tab when choosing a language other than English

* - avoid usage of AdempiereIdGenerator.escapeId when not ZkUnitTest
2023-07-01 20:24:58 +08:00
Peter Takács f79dd5f22f
IDEMPIERE-5786 - Refactor ESC/Alt+X Shortcut for Closing Tabs (#1917)
* IDEMPIERE-5786 - ESC Shortcut for Closing Tabs

- remove duplicate registering of on_cancel event on InfoPanel
- register on_cancel event on WindowContainer

* IDEMPIERE-5786 - partially revert ESC Shortcut for Closing Tabs

* IDEMPIERE-5786 - improve closing tabs with shortcut

- info windows
- forms
- workflows
- find window

* IDEMPIERE-5786 - SysConfig to Use Esc For Tab Closing

* IDEMPIERE-5786 - fix MSysConfig order

* IDEMPIERE-5786 - requested changes by Carlos

- implement shortcut on missing forms
- allow Alt+X shortcut also when ESC is allowed with the SysConfig

* IDEMPIERE-5786 - PR1917pr patch by Carlos

- removed unnecessary fix for an old firefox issue
2023-06-30 11:08:38 +02:00
Carlos Ruiz 7bf225683c
IDEMPIERE-5781 Any user can destroy a configured SQL Query (#1913)
* IDEMPIERE-5781 Any user can destroy a configured SQL Query

* - fix problem not showing the advanced toolbar back

* - implement suggestion from Heng Sin
2023-06-29 10:58:55 +08:00
Carlos Ruiz 509e900a0a
IDEMPIERE-5782 Generated Shipments/MR and Invoices with Invalid Sales Rep (#1914) 2023-06-28 10:21:18 +08:00
hengsin 31b2907b0a
IDEMPIERE-5448 2023 June Platform Update (#1911)
* IDEMPIERE-5448 2023 June Platform Update

- update to final tycho 3.0.5 release.

* IDEMPIERE-5448 2023 June Platform Update

- remove obsolete junit dependency and test code.
2023-06-26 10:59:28 +02:00
Carlos Ruiz 7adbc91505
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Archive (#1895)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Archive

* - Support for master/detail reports on UUID based tables

* - Archive button

* - Add test print format for UU Based Table

* - backward compatibility on MArchive.getReportAndDocumentCountByRecordId

* - Backward compatibility with filesystem storage

* - Improve naming of temporary folder for 2Pack

* - Improve query to use correctly the index

* - Improve method to use ID when no UUID

* - Ensure the Record_UU is filled even when called from foreign sources

* - Implement the same provision for exceptional cases on MAttachment, MChat, MLabelAssignment, MPostIt to fill the UUID when not passed (f.e. when created by a plugin)
2023-06-23 11:17:51 +08:00
Carlos Ruiz 3641e398ca
IDEMPIERE-5776 Cannot generate shipment for an order with multiple lines for same product and Complete Order delivery rule (#1900) 2023-06-22 14:00:27 +08:00
hengsin 9c7713fa8d
IDEMPIERE-5448 2023 June Platform Update (#1531)
* IDEMPIERE-5448 Can't launch unit test with Eclipse 2022-09

- upgrade to tycho 3.1.0-SNAPSHOT
- set maven compiler source and target level to 11
- upgrade to junit 5.9.1

* IDEMPIERE-5448 Can't launch unit test with Eclipse 2022-09

- Change tycho version to 3.0.3

* IDEMPIERE-5448 2023 June Platform Update

* IDEMPIERE-5448 2023 June Platform Update

- Explicitly set target, source and release level to JavaSE 11

* IDEMPIERE-5448 2023 June Platform Update

- Use 3.0.5-SNAPSHOT to fix stack overflow error.

* IDEMPIERE-5448 2023 June Platform Update

- Change source, target and release level to JDK 17
- Update target platform name to idempiere-230620

* IDEMPIERE-5448 2023 June Platform Update

- Fix LogFactory ClassNotFound exception with Eclipse 2023-06
2023-06-21 13:44:18 +02:00
Carlos Ruiz 4f6b718ab1
IDEMPIERE-5560 Cannot save Material Receipt after filling Order if the User1_ID field is not displayed (#1896) 2023-06-14 16:30:49 +08:00
Carlos Ruiz 903e3859b2
IDEMPIERE-5746 Bank Statement and Production cannot use Overwrite Date/Seq on Complete (#1882)
* IDEMPIERE-5746 Bank Statement and Production cannot use Overwrite Date/Seq on Complete

* - Backward compatibility - assign mandatory default doc type
2023-06-09 14:04:45 +02:00
Peter Takács f0c87202b4
IDEMPIERE-5407 - Fix Wrong getIdColumnName Validation (#1893)
* IDEMPIERE-5407 - Fix Wrong getIdColumnName Validation

* IDEMPIERE-5407 - patch by Carlos
2023-06-09 10:36:18 +02:00
Carlos Ruiz b0dcdb85d7
IDEMPIERE-5567 - fix stack overflow logging changelog (#1888) 2023-06-08 11:36:12 +08:00
Carlos Ruiz 066cd52b8e
IDEMPIERE-5567 - refactor of some array related methods (#1889) 2023-06-08 11:35:27 +08:00
Carlos Ruiz 7e1bfa1334
IDEMPIERE-5766 Recreate Storage Reservation is creating records for non-stocked products (#1892) 2023-06-08 11:33:02 +08:00
Nicolas Micoud c9ccea5533
IDEMPIERE-5721: Fill AD_ZoomCondition.SeqNo (#1841) 2023-06-07 22:09:27 +02:00
Nicolas Micoud d5d7aa45a2
IDEMPIERE-5749: CreatedBy fields should not be forced to be Search if used from processes/info windows (#1870)
https://idempiere.atlassian.net/browse/IDEMPIERE-5749
2023-06-07 21:59:11 +02:00
Marcos Gabriel de Oliveira Favaretto 43800e2540
IDEMPIERE-5643 - Error during document's workflows are not displayed on Workflow Activities form. (#1756)
* IDEMPIERE-5643 - Allows Workflow Activities form to throw Exceptions if an error occurs after user's approval

* IDEMPIERE-5643 - show message in wf activity

---------

Co-authored-by: matheus.marcelino <matheus.marcelino@devcoffee.com.br>
2023-06-07 21:48:59 +02:00
Peter Takács f832d496e3
IDEMPIERE-5754 - Check PInstance_ID before Process Lock DB Update, PInstance 0 on createPricelist (#1874)
* IDEMPIERE-5754 - Check PInstance_ID before Process Lock DB Update, PInstance 0 on createPricelist

* IDEMPIERE-5754 - improve AD_PInstance_ID check on SvrProcess unlock

* IDEMPIERE-5754 - revert legacy check
2023-06-07 16:59:18 +08:00
Peter Takács 34aa34d55f
IDEMPIERE-5755 - Empty value preference logs false parsing error on Dates (#1875) 2023-06-07 06:33:39 +08:00
Diego Ruiz 5602a15f04
IDEMPIERE-5759 - Fixed potential NPE when sending a null orderclause (#1880) 2023-06-07 06:32:03 +08:00
Carlos Ruiz 08c6d0aaa0
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1881)
- Fix issues created with latest change - not able to create new records in Zero ID tables (C_DocType, AD_User, etc)
2023-06-06 15:19:46 +02:00
Peter Takács bb695cb79a
IDEMPIERE-5645 - fix NPE on report Script columns (#1871) 2023-06-02 10:57:48 +08:00
Peter Takács 66e0d4200e
IDEMPIERE-5697 - Improve Process Log for more advanced logging options for Processes (#1808)
* IDEMPIERE-5697 - Improve Process Log for more advanced logging options for Processes

* IDEMPIERE-5697 - fix javadoc

* IDEMPIERE-5697 - add PInstanceLogType to AD_PInstance_Log

* IDEMPIERE-5697 - implement Status Log Type

- implement Status Log Type
- fix javadoc

* IDEMPIERE-5697 - definition changes

- rename log type 'Tail' to 'Progress' as Chuck Boecking suggested
- make ad_pinstance_log_uu the primary key as Heng Sin suggested

* IDEMPIERE-5697 - updateLog method with UUID

* IDEMPIERE-5697 - requested changes

- split insert and update
- fix wrong javadoc
- small fixes

* IDEMPIERE-5697 - requested changes

- fix javadoc
- fix migration scripts

* IDEMPIERE-5697 - balance API

- rename methods in SvrProcess: saveLog -> saveProgress, saveStatus; updateLog -> updateStatus
- remove progress and status methods that take table and record id arguments, there is no need to save them in separate fields with there log types

* IDEMPIERE-5697 - balance API

- exchange logic between Progress and Status log types
- modify method names in ProcessInfo based on SvrProcess

* IDEMPIERE-5697 - pr 1808 patch by Heng Sin

- fix oracle migration script
2023-06-01 14:11:25 +08:00
hieplq dfe2fff6cd
IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (#1842)
* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice

base on patch from gauravsontakke

* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (fix code review)

https://github.com/idempiere/idempiere/pull/1842#pullrequestreview-1429618616

* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (check Accrual)

createInvoiceGainLoss isn't yet test for non accrual so at check for accrual to consistent with above code
2023-06-01 13:15:48 +08:00
Carlos Ruiz 116b5b4db1
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - fix issue reported by Murilo (#1868) 2023-06-01 11:52:35 +08:00
Carlos Ruiz fde6e0a1d1
IDEMPIERE-5687 Base Price List (#1858) 2023-05-31 17:24:14 +02:00
Carlos Ruiz 013ba190fd
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Toolbar (#1865)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Toolbar

- add support for AD_Attachment, CM_Chat, AD_PostIt and AD_LabelAssignment for UUID based tables

* - Better deprecated message
- Better deprecated management for constructors

* - Fix non unique exception on ad_changelog
- Fix to save changelog just ID on insert and not the UUID for ID based tables
2023-05-31 10:39:10 +08:00
hengsin 7336dc967d
IDEMPIERE-5744 MDashboardPreference.getForSessionQuery: add client filter and remove order by ad_client_id (#1866) 2023-05-31 00:36:42 +02:00
Carlos Ruiz d45c0fa248
IDEMPIERE-5735 Useless code in GridTable.dataSave (#1853)
* IDEMPIERE-5735 Useless code in GridTable.dataSave

* - Solve issue with saving zero ID records on UI

* - remove unnecessary row - don't need to read again PO because gridTable.getPO returns now correctly POs with zero ID
2023-05-29 22:27:40 +08:00
hengsin cc831e41d8
IDEMPIERE-5743 Info Window: Add Optional Auto Collapsed Parameter Panel option (#1862) 2023-05-29 15:41:37 +02:00
Peter Takács 8096d6e420
IDEMPIERE-5216 - HTML report Record ID Trl fix (#1840)
* IDEMPIERE-5216 - HTML report Record ID Trl fix

* IDEMPIERE-5216 - HTML report Record ID Trl fix

* IDEMPIERE-5216 - add fallback if Trl not found

* IDEMPIERE-5216 - fix inconsistancy in logic

- DataEngine.java uses the Env.isBaseLanguage method

* IDEMPIERE-5216 - fix inconsistancy in logic

* IDEMPIERE-5216 - fix javadoc
2023-05-29 20:56:55 +08:00
Peter Takács 31365e24e9
IDEMPIERE-5730 - Context is not parsed in exception message logs thrown from processes (#1845) 2023-05-29 16:22:03 +08:00
Carlos Ruiz 430823153f
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Recent Items (#1856)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Recent Items

- Implement support for recent items for UUID based tables
- Refactor MRecentItem for better performance

* - fixes
2023-05-29 16:16:18 +08:00
Carlos Ruiz 281333e8b9
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - ChangeLog - FKRules (#1852)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - ChangeLog - FKRules

* - change warning by IllegalArgumentException
- change package visibility to protected

* - remove unnecessary code - the Model Cascade is calling the deleteModelCascade for children too

* - Implement SysConfig AD_CHANGELOG_SAVE_UUID
- reorganize MSysConfig (there were entries out of order)

* - Add index for performance on AD_ChangeLog.Record_UU

* - Enable change log for tables with multi-key (like _Trl or _Access)

* - Enable saving change log for AD_ClientInfo

* - when updating a record that doesn't have UUID - assign one
2023-05-28 23:47:30 +08:00
Peter Takács 1ff182e605
IDEMPIERE-5737 - Change Report's "No Rows" log level (#1855) 2023-05-25 22:35:06 +08:00
Carlos Ruiz 4a1dcb265b
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1837)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

- Fix Record UUID editor

* - Separate WRecordEditor and WRecordUUIDEditor for ID and UUID

* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

- integrate patch from Heng Sin

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-05-21 19:39:08 +08:00
Carlos Ruiz df06938191
IDEMPIERE-5731 NPE when using Query.list() with a view (#1846) 2023-05-20 09:55:07 +08:00
Carlos Ruiz 531aa73ea1
IDEMPIERE-4639 Cross tenant issues with context help (#1848) 2023-05-20 09:53:49 +08:00
Carlos Ruiz d734cafd9b
IDEMPIERE-5712 Tests are leaving records in the database (#1827)
* IDEMPIERE-5712 Tests are leaving records in the database

* - add transaction

* - add cleanup for records committed out of transaction
2023-05-16 16:32:15 +08:00
hengsin cc90586aa0
IDEMPIERE-5717 MColumn.getForeignKeyConstraint doesn't always generate unique foreign key constraint name (#1830) 2023-05-11 12:43:00 +02:00
Peter Takács ae19cbe91a
IDEMPIERE-5683 - Ignore Views with Record ID and Record UU Model Constraints (#1828) 2023-05-11 12:24:09 +02:00
Carlos Ruiz af2d735cc5
IDEMPIERE-5683 Peer review (#1825) 2023-05-06 00:58:43 +02:00
Peter Takács 3bf447b009
IDEMPIERE-5683 - Improve Record ID and Record UU by Constraint Type (#1810)
* IDEMPIERE-5683 - Improve Record ID and Record UU by Constraint Type

* IDEMPIERE-5683 - replace direct sql with model classes

- rename deleteSetNull to setRecordIdNull
- replace direct sql with model classes in deleteCascade, setRecordIdNull
- remove unnecessary change from AD_Ref_List

* IDEMPIERE-5683 - cache tables arrays in PO_Record

* IDEMPIERE-5683 - fix Dynamic Validation

* IDEMPIERE-5683 - change CleanOrphanCascade

- IsCleanChangeLog process parameter removed
- replace direct sql with java model
- delete just on Model Cascade constraint
- new Set Null rule implemented

* IDEMPIERE-5683 - fix when Record_ID is mandatory
2023-05-06 00:57:09 +02:00
hengsin afcbf6e70f
IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR… (#1818)
* IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR UPDATE

* IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR UPDATE

- add trx timeout unit test
2023-05-05 19:41:43 +02:00
Nicolas Micoud 0553878431
IDEMPIERE-5701: Improve logs when role cannot report or export (#1811)
* IDEMPIERE-5701: Improve logs when role cannot report or export

https://idempiere.atlassian.net/browse/IDEMPIERE-5701

* IDEMPIERE-5701: Reduce log level when role cannot report or export and hide Report button when role cannot report

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>
2023-05-04 00:06:53 +02:00
Carlos Ruiz 969a2e66df
IDEMPIERE-5238 Fix checkRecordIDCrossTenant failing in multi-key table (#1821) 2023-05-03 20:32:59 +02:00
Carlos Ruiz 31779a7611
IDEMPIERE-5708 Show in grid value in dictionary cannot be overriden by customize (#1820) 2023-05-03 19:17:15 +02:00
Peter Takács d53570eb75
IDEMPIERE-5695 - Process audit doesn't set print language, format, print format on Forms/documents (#1805)
* IDEMPIERE-5695 - Process audit doesn't set print language, format, print format on Forms/documents

* IDEMPIERE-5695 - get language from print format

* IDEMPIERE-5695 - fix javadoc

* IDEMPIERE-5695 - implement in startStandardReport and startFinReport
2023-05-02 17:13:55 +08:00
Carlos Ruiz 1fb4248ab9
IDEMPIERE-5706 Improvements to Tab Editor in Window Customization (#1817) 2023-05-01 16:44:51 +02:00
Carlos Ruiz 07ecea1494
IDEMPIERE-5509 Implement readonly query without using Trx - fix issue with native sequences in PostgreSQL (#1815) 2023-05-01 19:26:16 +08:00
Jose Leite 61118b8877
IDEMPIERE-5698 - Improvement for display all events errors (#1807)
* IDEMPIERE-5698 - mprovement for display all events errors

* IDEMPIERE-5698 - Improvement for display all events errors in all methods of class
2023-04-28 22:55:43 +08:00
hengsin 7bd5e579ce
IDEMPIERE-5689 Make MLocatorLookup and WLocatorEditor more extensible (#1800)
* IDEMPIERE-5689 Add setValidationCode to MLocatorLookup

* IDEMPIERE-5689 Make MLocatorLookup and WLocatorEditor more extensible
2023-04-28 12:26:47 +02:00
hengsin f18bb88f4b
IDEMPIERE-5691 Add Table Direct type joint method to Query (#1802) 2023-04-28 12:16:13 +02:00
Nicolas Micoud 254dcb3955
IDEMPIERE-5696: Width of last column of reports exported as Xlsx is n… (#1806)
* IDEMPIERE-5696: Width of last column of reports exported as Xlsx is not correct

https://idempiere.atlassian.net/browse/IDEMPIERE-5696

* IDEMPIERE-5696: Width of last column of reports exported as Xlsx is not correct - patch from hengsin

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2023-04-27 13:34:11 +08:00
Peter Takács 23713f6461
IDEMPIERE-5669 - Report Row Count shows incorrect data (#1791)
* IDEMPIERE-5669 - Report Row Count shows incorrect data

2 issues fixed:
- row count in tab did not refresh on clicking the refresh button (only on re-run)
- row count included function rows too

* IDEMPIERE-5669 - fixes

- added private attribute to rowCount Label
- added null-check to updateRowCount() method
2023-04-25 16:24:18 +08:00
Carlos Ruiz 5bf9301764
Fixes IDEMPIERE-5673 Wrong character causes java.awt.IllegalComponentStateException: This component must have a parent in order to determine its locale on reports (#1785) 2023-04-24 18:14:28 +08:00
Carlos Ruiz 80347c0926
Fixes IDEMPIERE-2194 GL Journal Distribution writes no DocumentNo in Accounting Fact Description (#1795)
- Copy the information from the line being distributed
2023-04-23 17:12:50 +08:00
hengsin eb78bd4ee9
IDEMPIERE-5678 Unit Test is failing with PostgreSQL 15 (#1789) 2023-04-19 13:57:34 +02:00
Carlos Ruiz 449c124fe1
IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) (#1787)
* IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) - fix broken unit tests

* - Fix problem with unit test:
MTestTest.testReadingUpdatingTest:65 expected: <Test setting description> but was: <Test setting descriptionMTestEventDelegate>
2023-04-19 09:07:32 +08:00
Carlos Ruiz beed782d4e
IDEMPIERE-5675 MTable.getPO cache for model factory wrongly removing from cache when PO is not found (#1788) 2023-04-18 14:34:29 +02:00
Deepak Pansheriya 76daedf6ad
IDEMPIERE-5671: Fixing Line net amount has error due to rounding. (#1782)
* IDEMPIERE-5671: Fixing Line net amount has error due to rounding.

* IDEMPIERE-5671: on price calculation add 12 decimal rounding to avoid rounding error
Co-authored-by: carg67@gmail.com
2023-04-17 10:25:05 +02:00
Jefferson Dalfre dd0e6c95ea
IDEMPIERE-5665 - [Multi Selection] - Negate option in process parameter (#1779)
* IDEMPIERE-5665

* IDEMPIERE-5665 - Fix code
2023-04-14 16:07:40 +08:00
Carlos Ruiz c80d53674a
IDEMPIERE-5567 Support of UUID as Key - Generate Model Classes (FHCA-4195) (#1772)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

New generated model classes with new UUID constructor

* - In order to use UUID constructor M classes must implement the constructor too
- Adding the constructor on MTest and adding a JUnit test to test/show how it works

* - Remove warning caused by changes on this ticket

* - Add UUID constructor to factories

* - Set new UUID constructor in mapped/annotated test classes
- Preparation for the new UUID constructor

* - Add UUID constructor to core model classes
- WARNING: MPaymentBatch(Properties, String, String) already existed with Name as parameter, it was changed to UUID
2023-04-12 11:02:33 +08:00
Peter Takács 89a093ca49
IDEMPIERE-5482 - Field Style Scope HTML Element (#1572)
* IDEMPIERE-5482 - Field Style Scope HTML Element

* IDEMPIERE-5482 - implemented in report engine, removed the new field

* IDEMPIERE-5482 - add IsWrapWithSpan to AD_Style

* IDEMPIERE-5482 -  pr1572 patch
2023-04-11 22:22:10 +08:00
Carlos Ruiz b5cb64bc92
IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) (#1771)
* IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195)

* - Search editor now assigns the value correctly when selecting from Info Window
- Info Window shows correctly the first UU key column
- Added Record UUID new data type to work with record ID editor but with UU column
- Added column/field Test.Record_UU for testing

* - Fix opening Record ID editor after saved

* - Implement changes suggested by Heng Sin's peer review

* - Remove other unnecessary changes

* - safer comparison
2023-04-11 13:20:13 +08:00
Carlos Ruiz 2e9b1222d3
IDEMPIERE-5560 Fix broken unit tests (#1770) 2023-04-06 16:04:45 +08:00
Peter Takács b1bf9bc4e9
IDEMPIERE-5650 - Cannot Define Multiple Values for Dashboard Content Process Parameters (#1757)
* IDEMPIERE-5650 - Cannot Define Multiple Values for Dashboard Content Process Parameters

* IDEMPIERE-5650 - remove hardcoded condition

* IDEMPIERE-5650 - fix for reference list multiselection

- support for non-ID multiselection types (values were not rendered e.g. with DocType="IP,CO")

* IDEMPIERE-5650 - fix for reference list multiselection

* IDEMPIERE-5650 - bug fixes

- error use case: reference list with numeric values e.g. "10", "20",... (fix: check DisplayType instead of data type)
- error use case 2: defining more than one multi-selection caused parsing error (fixed parsing logic in MDashboardContent)

* IDEMPIERE-5650 - optimise parsing method

* IDEMPIERE-5650 - pr1757_PR0 patch
2023-04-05 13:00:00 +02:00
Carlos Ruiz a967069164
IDEMPIERE-5567 Support of UUID as Foreign Key (FHCA-4195) (#1741)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Foreign Keys

* - Table Direct working as read-only and link column

* - Fixes for Table with Reference

* - Add UUID FK management to Migrate ID process
- Add MColumn.beforeSave validation to force UUID columns to end with _UU
- Add table TestUUDet with two foreign keys pointing to TestUU (TableDir and Search)
- Add detail tab to Test UU Based Table window
- Add a new test window named Test UU Detail
- Generate model classes for the new test table
- Add test case for the detail test table
- Add MTable.isIDKeyTable method
- Add UU foreign key cross tenant validation to PO.validForeignKeys

* - Added a Chosen Multiple Selection Table with foreign UU for testing
- Changed reference in dictionary logic and sql to reflect new data types
- Disable SearchUU temporarily (will be worked in next step)
- Add validation to avoid encrypting UUID columns
- Avoid warning when searching for getPO method on UUID based tables
- Make Zoom Across button work with UUID foreign keys
- Enable zoom and zoom to detail for UUID foreign keys
- Enable Find Advanced on detail foreign UUID keys

* - Fix javadoc
- Quote properly UUID
- Validate null on return

* - Fix zoom logic - tested zooming to tab in first second and third level
2023-04-05 10:26:27 +08:00
Peter Takács 30d89378c8
IDEMPIERE-5659 - New Document Base Type Group Window (#1768)
* IDEMPIERE-5659 - New Document Base Type Group Window

* IDEMPIERE-5659 - fixes

- renaming the table, model and elements according to the ticket
- removing MDocBaseGroup beforeSave validation
- adding an unique index for the Line table
2023-04-04 13:04:41 +02:00
Peter Takács 33de756336
IDEMPIERE-5645 - Print Format Script Column cannot find Columns from context (#1760)
* IDEMPIERE-5645 - Print Format Script Column cannot find Columns from context

* IDEMPIERE-5645 - move script columnd parsing after 'all rows' loop

* IDEMPIERE-5645 - fixes
2023-04-04 14:32:57 +08:00
Carlos Ruiz 9e18bc725e
IDEMPIERE-5174 Disable System User - Set new System (#1769) 2023-04-04 11:36:30 +08:00
Peter Takács 3cb7d395e1
IDEMPIERE-5652 - Print Format: Format Pattern is not Applied on Grouping/Summary rows (#1762) 2023-04-02 15:40:10 +08:00
hengsin 65f565e542
IDEMPIERE-5528 Context parsing on process Parameter not considering tab no (#1765)
- implement parent Evaluatee for GridField and ProcessParameterPanel
2023-04-01 16:24:07 +02:00
hengsin ee1b6828f4
IDEMPIERE-5560 Cannot save more than one order line when an _ID field is not displayed (#1764) 2023-04-01 16:11:35 +02:00
Deepak Pansheriya 5199247a1e
IDEMPIERE-5602 : Adding PriceEntered in Expense report (#1759) 2023-03-30 13:29:38 +02:00
muriloht 1441b9095a
IDEMPIERE-5647 - allow define context variables by role (#1753)
* IDEMPIERE-5647 - allow define context variables by role

* IDEMPIERE-5647 - fix PR comment
2023-03-29 12:44:15 +02:00
Carlos Ruiz d9764ce54e
IDEMPIERE-5238 Record_ID editor - fix 2Pack broken (#1754) 2023-03-27 19:00:21 +08:00
Nicolas Micoud 59069f4cfe
IDEMPIERE-5644 : Allow to set an image per form (#1751)
* IDEMPIERE-5644 : Allow to set an image per form

https://idempiere.atlassian.net/browse/IDEMPIERE-5644

* IDEMPIERE-5644 : Allow to set an image per form - fix suggested by hengsin

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2023-03-27 18:26:20 +08:00
Jose Leite 45a8e18d32
IDEMPIERE-5640 - Fix Cross Tenant Sending BroadCast Message (#1750)
* IDEMPIERE-5640 - Fix Cross Tenant Sending BroadCast Message

* IDEMPIERE-5640 - Add validation in fix Cross Tenant Sending BroadCast Message
2023-03-24 14:20:21 +01:00
Carlos Ruiz 2d928ed37e
IDEMPIERE-5633 Check tableId <=0 in PO.checkRecordIDCrossTenant() (#1745)
IDEMPIERE-5238

Thanks to Ken Longnan
2023-03-24 11:24:47 +08:00
Diego Ruiz 89dfb22482
IDEMPIERE-5637 - Improve GridField to allow setting the default values of GridFieldVO programmatically with a method (#1746)
* IDEMPIERE-5637 - Improved GridField and GridFieldVO to allow setting default value programmatically

* IDEMPIERE-5637 - Minor refactor to improve code readibility

* IDEMPIERE-5637 - Defined constants for priority default order
2023-03-23 21:30:58 +08:00
Peter Takács bf7c9792af
IDEMPIERE-5588 - Multiselect Chosenbox Editor Doesn't Initialise its List when Tab First Opened (#1744)
* IDEMPIERE-5588 - Multiselect Chosenbox Editor Doesn't Initialise its List when Tab First Opened

* IDEMPIERE-5588 - pr1744 patch
2023-03-22 16:52:28 +08:00
Carlos Ruiz 51ceaacb43
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1727)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

* - Implement changes to support Model classes with UUID constructor

* - fix issue with tables with single parent key - like AD_Ref_Table

* - Create test table and JUnit test

* - fixes from Heng Sin

* - Improve performance on new methods in MTable
- Minor refinements in ModelClassGenerator
- Regenerate Test X classes
- Change Create Window from Table to receive the parent link as parameter (because tables can have now no keys at all)

* - Implement suggestions from Heng Sin

* - _UU column as primary key constraint for UUID based tables

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-03-21 21:30:45 +08:00
Nicolas Micoud 85af1ed2a1
IDEMPIERE-5608: Improve server logs by tenant and user data (#1715)
* IDEMPIERE-5608: Improve server logs by tenant and user data

* IDEMPIERE-5608: Improve server logs by tenant and user data - migration script

* IDEMPIERE-5680: Improve server logs by tenant and user data - use VM argument

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-5608: Improve server logs by tenant and user data: various fixes

* IDEMPIERE-5608: Improve server logs by tenant and user data - revert changes on server.product.launch

* IDEMPIERE-5608: Improve server logs by tenant and user data - Carlos's patch

tested: )
Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-03-21 12:08:44 +08:00
matheus-marcelinux b11b7bcf95
IDEMPIERE-5631 - ModelEventHandler findTableName by Model annotation (#1739) 2023-03-18 12:52:23 +08:00
hengsin e479eb5cfb
IDEMPIERE-5609 Dashboard Performance Indicators incrementally redrawed on DC drag and drop (#1736) 2023-03-17 11:45:56 +01:00
Carlos Ruiz eab0574dae
IDEMPIERE-5565 Cannot create report with virtual column where reference is table with display column = ID (#1735)
* IDEMPIERE-5565 Cannot create report with virtual column where reference is table with display column = ID

* - make it consistent with the actual approach
2023-03-17 14:27:00 +08:00
Peter Takács 47987c0314
IDEMPIERE-5538 - Add isValid to Drill Rule allow validate parameters with beforesave (#1632)
* IDEMPIERE-5538 - Add isValid to Drill Rule allow validate parameters with beforesave

* IDEMPIERE-5538 - beforeSave, capture process parameters

* IDEMPIERE-5538 - validate only through process

* IDEMPIERE-5538 - isValid check in getByTable method

* IDEMPIERE-5538 - add validation to before save/after delete

* IDEMPIERE-5538 - validate system drill rules

* IDEMPIERE-5538 - fix validation logic

The mandatory validation have to skip the key parameter since it is not loaded from Drill Rule Para.

* IDEMPIERE-5538 - fix Drill Rule window definition

* IDEMPIERE-5538 - bug fix scripts to iD10

* IDEMPIERE-5538 - fix missing read only logic

* IDEMPIERE-5538 - all scripts to iD10
2023-03-16 19:10:15 +08:00
Peter Takács b7b9a4d476
IDEMPIERE-5621 - Dashboard Report ignore if parameter is mandatory or not (#1714)
* IDEMPIERE-5621 - Dashboard Report ignore if parameter is mandatory or not

* IDEMPIERE-5621 - small fixes

* IDEMPIERE-5621 - missing javadoc for new methods

* IDEMPIERE-5621 - move scripts, list empty para, update css
2023-03-16 12:01:40 +08:00
Carlos Ruiz d4dd4585b6
IDEMPIERE-5611 Record ID Editor doesn't work with House Keeping (#1720)
* IDEMPIERE-5611 Record ID Editor doesn't work with House Keeping

- Fix zoom window on tables that have this field empty and have a window associated

* - Fix zoom and lookup without AD_Window_ID update

* - Add discovery for more tab levels

* - Fix zoom when AD_Table.AD_Window_ID is null.

* - use the new method also in InfoGeneralPanel

* - set zoom window just when is not defined (preserve potential customizations)

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-03-15 22:34:31 +08:00
Nicolas Micoud 075c41c63f
IDEMPIERE-5610: Improve layout of Password Validator translations (#1702)
https://idempiere.atlassian.net/browse/IDEMPIERE-5610
2023-03-15 19:00:38 +08:00
Carlos Ruiz f35585a96e
IDEMPIERE-5238 Record_ID editor (#1728)
- exclude AD_WF_Activity from the validation to avoid affecting performance
2023-03-14 21:53:06 +08:00
Carlos Ruiz c29184fbf1
IDEMPIERE-5616 Reverse Shipments don't post because of Not Balanced in special case (#1706)
* IDEMPIERE-5616 Reverse Shipments don't post because of Not Balanced in special case

* - Add case for Inventory Move
- Add explanatory comment

* - Add extra cases for other documents

* - uploaded a different approach

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-03-14 20:59:59 +08:00
Carlos Ruiz 4c77efecb4
IDEMPIERE-5613 Make filling of _UU column optional (#1719)
* IDEMPIERE-5613 Make filling of _UU column optional

* - clear _UU when column is made inactive

* - Add parameter IsClearUUID
- Fix issue with buffer log not being flushed
2023-03-14 20:20:57 +08:00
hengsin b188775e9a
IDEMPIERE-5624 Implement export data as SQL insert statement (#1721) 2023-03-13 15:57:45 +01:00
Peter Takács 1bc5370dbb
IDEMPIERE-5618 - Print Format Script Column does not show Data in correct Data Types (#1712)
* IDEMPIERE-5618 - Print Format Script Column does not show Data in correct Data Types

* IDEMPIERE-5618 - optimised and simplified the code

- get PrintFormatType from PrintDataColumn pdc
- getDisplayType(value) method to unify and simplify getting the display type
2023-03-13 21:40:09 +08:00
Carlos Ruiz e4b7c9e17d
IDEMPIERE-5628 Record ID Check Issue - implement setCrossTenantSafe (#1724)
* IDEMPIERE-5628 Record ID Check Issue - implement setCrossTenantSafe

* - remove table exceptions
2023-03-13 21:38:00 +08:00
Carlos Ruiz ef06b837d6
IDEMPIERE-5542 [DisplayType] - Cache issue (#1718)
Minor refactoring to use MTable.MAX_OFFICIAL_ID
2023-03-11 20:46:45 +08:00
Carlos Ruiz fb98b75ce9
IDEMPIERE-5542 [DisplayType] - Cache issue (#1717)
- Fix problem with the AbstractXLSXExporter going wild, the method getFormatString is trying to create a format with the number of digits supported by the NumberFormat, and as the MaximumIntegerDigits is not set, is trying to create a String with the default which is 2147483647
2023-03-11 01:01:09 +08:00