midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-5567 - refactor of some array related methods (#1889)

This commit is contained in:
Carlos Ruiz 2023-06-08 05:35:27 +02:00 committed by GitHub
parent 7e1bfa1334
commit 066cd52b8e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
org.adempiere.base/src/org/compiere/model/MChangeLog.java
View File

@ -16,15 +16,14 @@
*****************************************************************************/
package org.compiere.model;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Properties;
import java.util.logging.Level;
import org.compiere.util.CLogger;
import org.compiere.util.DB;
import org.compiere.util.Env;
import org.compiere.util.Util;
/**
@ -63,37 +62,10 @@ public class MChangeLog extends X_AD_ChangeLog
*/
private static void fillChangeLog()
{
ArrayList<Integer> list = new ArrayList<Integer>(40);
String sql = "SELECT t.AD_Table_ID FROM AD_Table t "
+ "WHERE t.IsChangeLog='Y'" // also inactive
+ " OR EXISTS (SELECT * FROM AD_Column c "
+ "WHERE t.AD_Table_ID=c.AD_Table_ID AND c.ColumnName='EntityType') "
+ "ORDER BY t.AD_Table_ID";
PreparedStatement pstmt = null;
ResultSet rs = null;
try
{
pstmt = DB.prepareStatement(sql, null);
rs = pstmt.executeQuery();
while (rs.next())
list.add(Integer.valueOf(rs.getInt(1)));
}
catch (Exception e)
{
s_log.log(Level.SEVERE, sql, e);
}
finally
{
DB.close(rs, pstmt);
rs = null; pstmt = null;
}
// Convert to Array
s_changeLog = new int [list.size()];
for (int i = 0; i < s_changeLog.length; i++)
{
Integer id = (Integer)list.get(i);
s_changeLog[i] = id.intValue();
}
final String where = "IsChangeLog='Y' OR EXISTS (SELECT * FROM AD_Column c WHERE AD_Table.AD_Table_ID=c.AD_Table_ID AND c.ColumnName='EntityType')";
s_changeLog = new Query(Env.getCtx(), MTable.Table_Name, where, null)
.setOrderBy(MTable.COLUMNNAME_AD_Table_ID)
.getIDs();
if (s_log.isLoggable(Level.INFO)) s_log.info("#" + s_changeLog.length);
} // fillChangeLog

6
org.adempiere.base/src/org/compiere/model/Query.java
View File

@ -1043,11 +1043,7 @@ public class Query
rs = null; pstmt = null;
}
// Convert to array
int[] retValue = new int[list.size()];
for (int i = 0; i < retValue.length; i++)
{
retValue[i] = list.get(i);
}
int[] retValue = list.stream().mapToInt(Integer::intValue).toArray();
return retValue;
} // get_IDs