Commit Graph

3677 Commits

Author SHA1 Message Date
Carlos Ruiz b0dcdb85d7
IDEMPIERE-5567 - fix stack overflow logging changelog (#1888) 2023-06-08 11:36:12 +08:00
Carlos Ruiz 066cd52b8e
IDEMPIERE-5567 - refactor of some array related methods (#1889) 2023-06-08 11:35:27 +08:00
Carlos Ruiz 7e1bfa1334
IDEMPIERE-5766 Recreate Storage Reservation is creating records for non-stocked products (#1892) 2023-06-08 11:33:02 +08:00
Nicolas Micoud c9ccea5533
IDEMPIERE-5721: Fill AD_ZoomCondition.SeqNo (#1841) 2023-06-07 22:09:27 +02:00
Nicolas Micoud d5d7aa45a2
IDEMPIERE-5749: CreatedBy fields should not be forced to be Search if used from processes/info windows (#1870)
https://idempiere.atlassian.net/browse/IDEMPIERE-5749
2023-06-07 21:59:11 +02:00
Marcos Gabriel de Oliveira Favaretto 43800e2540
IDEMPIERE-5643 - Error during document's workflows are not displayed on Workflow Activities form. (#1756)
* IDEMPIERE-5643 - Allows Workflow Activities form to throw Exceptions if an error occurs after user's approval

* IDEMPIERE-5643 - show message in wf activity

---------

Co-authored-by: matheus.marcelino <matheus.marcelino@devcoffee.com.br>
2023-06-07 21:48:59 +02:00
Peter Takács f832d496e3
IDEMPIERE-5754 - Check PInstance_ID before Process Lock DB Update, PInstance 0 on createPricelist (#1874)
* IDEMPIERE-5754 - Check PInstance_ID before Process Lock DB Update, PInstance 0 on createPricelist

* IDEMPIERE-5754 - improve AD_PInstance_ID check on SvrProcess unlock

* IDEMPIERE-5754 - revert legacy check
2023-06-07 16:59:18 +08:00
Peter Takács 34aa34d55f
IDEMPIERE-5755 - Empty value preference logs false parsing error on Dates (#1875) 2023-06-07 06:33:39 +08:00
Diego Ruiz 5602a15f04
IDEMPIERE-5759 - Fixed potential NPE when sending a null orderclause (#1880) 2023-06-07 06:32:03 +08:00
Carlos Ruiz 08c6d0aaa0
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1881)
- Fix issues created with latest change - not able to create new records in Zero ID tables (C_DocType, AD_User, etc)
2023-06-06 15:19:46 +02:00
Peter Takács bb695cb79a
IDEMPIERE-5645 - fix NPE on report Script columns (#1871) 2023-06-02 10:57:48 +08:00
Peter Takács 66e0d4200e
IDEMPIERE-5697 - Improve Process Log for more advanced logging options for Processes (#1808)
* IDEMPIERE-5697 - Improve Process Log for more advanced logging options for Processes

* IDEMPIERE-5697 - fix javadoc

* IDEMPIERE-5697 - add PInstanceLogType to AD_PInstance_Log

* IDEMPIERE-5697 - implement Status Log Type

- implement Status Log Type
- fix javadoc

* IDEMPIERE-5697 - definition changes

- rename log type 'Tail' to 'Progress' as Chuck Boecking suggested
- make ad_pinstance_log_uu the primary key as Heng Sin suggested

* IDEMPIERE-5697 - updateLog method with UUID

* IDEMPIERE-5697 - requested changes

- split insert and update
- fix wrong javadoc
- small fixes

* IDEMPIERE-5697 - requested changes

- fix javadoc
- fix migration scripts

* IDEMPIERE-5697 - balance API

- rename methods in SvrProcess: saveLog -> saveProgress, saveStatus; updateLog -> updateStatus
- remove progress and status methods that take table and record id arguments, there is no need to save them in separate fields with there log types

* IDEMPIERE-5697 - balance API

- exchange logic between Progress and Status log types
- modify method names in ProcessInfo based on SvrProcess

* IDEMPIERE-5697 - pr 1808 patch by Heng Sin

- fix oracle migration script
2023-06-01 14:11:25 +08:00
hieplq dfe2fff6cd
IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (#1842)
* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice

base on patch from gauravsontakke

* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (fix code review)

https://github.com/idempiere/idempiere/pull/1842#pullrequestreview-1429618616

* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (check Accrual)

createInvoiceGainLoss isn't yet test for non accrual so at check for accrual to consistent with above code
2023-06-01 13:15:48 +08:00
Carlos Ruiz 116b5b4db1
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - fix issue reported by Murilo (#1868) 2023-06-01 11:52:35 +08:00
Carlos Ruiz fde6e0a1d1
IDEMPIERE-5687 Base Price List (#1858) 2023-05-31 17:24:14 +02:00
Carlos Ruiz 013ba190fd
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Toolbar (#1865)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Toolbar

- add support for AD_Attachment, CM_Chat, AD_PostIt and AD_LabelAssignment for UUID based tables

* - Better deprecated message
- Better deprecated management for constructors

* - Fix non unique exception on ad_changelog
- Fix to save changelog just ID on insert and not the UUID for ID based tables
2023-05-31 10:39:10 +08:00
hengsin 7336dc967d
IDEMPIERE-5744 MDashboardPreference.getForSessionQuery: add client filter and remove order by ad_client_id (#1866) 2023-05-31 00:36:42 +02:00
Carlos Ruiz d45c0fa248
IDEMPIERE-5735 Useless code in GridTable.dataSave (#1853)
* IDEMPIERE-5735 Useless code in GridTable.dataSave

* - Solve issue with saving zero ID records on UI

* - remove unnecessary row - don't need to read again PO because gridTable.getPO returns now correctly POs with zero ID
2023-05-29 22:27:40 +08:00
hengsin cc831e41d8
IDEMPIERE-5743 Info Window: Add Optional Auto Collapsed Parameter Panel option (#1862) 2023-05-29 15:41:37 +02:00
Peter Takács 8096d6e420
IDEMPIERE-5216 - HTML report Record ID Trl fix (#1840)
* IDEMPIERE-5216 - HTML report Record ID Trl fix

* IDEMPIERE-5216 - HTML report Record ID Trl fix

* IDEMPIERE-5216 - add fallback if Trl not found

* IDEMPIERE-5216 - fix inconsistancy in logic

- DataEngine.java uses the Env.isBaseLanguage method

* IDEMPIERE-5216 - fix inconsistancy in logic

* IDEMPIERE-5216 - fix javadoc
2023-05-29 20:56:55 +08:00
Peter Takács 31365e24e9
IDEMPIERE-5730 - Context is not parsed in exception message logs thrown from processes (#1845) 2023-05-29 16:22:03 +08:00
Carlos Ruiz 430823153f
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Recent Items (#1856)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Recent Items

- Implement support for recent items for UUID based tables
- Refactor MRecentItem for better performance

* - fixes
2023-05-29 16:16:18 +08:00
Carlos Ruiz 281333e8b9
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - ChangeLog - FKRules (#1852)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - ChangeLog - FKRules

* - change warning by IllegalArgumentException
- change package visibility to protected

* - remove unnecessary code - the Model Cascade is calling the deleteModelCascade for children too

* - Implement SysConfig AD_CHANGELOG_SAVE_UUID
- reorganize MSysConfig (there were entries out of order)

* - Add index for performance on AD_ChangeLog.Record_UU

* - Enable change log for tables with multi-key (like _Trl or _Access)

* - Enable saving change log for AD_ClientInfo

* - when updating a record that doesn't have UUID - assign one
2023-05-28 23:47:30 +08:00
Peter Takács 1ff182e605
IDEMPIERE-5737 - Change Report's "No Rows" log level (#1855) 2023-05-25 22:35:06 +08:00
Carlos Ruiz 4a1dcb265b
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1837)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

- Fix Record UUID editor

* - Separate WRecordEditor and WRecordUUIDEditor for ID and UUID

* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

- integrate patch from Heng Sin

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-05-21 19:39:08 +08:00
Carlos Ruiz df06938191
IDEMPIERE-5731 NPE when using Query.list() with a view (#1846) 2023-05-20 09:55:07 +08:00
Carlos Ruiz 531aa73ea1
IDEMPIERE-4639 Cross tenant issues with context help (#1848) 2023-05-20 09:53:49 +08:00
Carlos Ruiz d734cafd9b
IDEMPIERE-5712 Tests are leaving records in the database (#1827)
* IDEMPIERE-5712 Tests are leaving records in the database

* - add transaction

* - add cleanup for records committed out of transaction
2023-05-16 16:32:15 +08:00
hengsin cc90586aa0
IDEMPIERE-5717 MColumn.getForeignKeyConstraint doesn't always generate unique foreign key constraint name (#1830) 2023-05-11 12:43:00 +02:00
Peter Takács ae19cbe91a
IDEMPIERE-5683 - Ignore Views with Record ID and Record UU Model Constraints (#1828) 2023-05-11 12:24:09 +02:00
Carlos Ruiz af2d735cc5
IDEMPIERE-5683 Peer review (#1825) 2023-05-06 00:58:43 +02:00
Peter Takács 3bf447b009
IDEMPIERE-5683 - Improve Record ID and Record UU by Constraint Type (#1810)
* IDEMPIERE-5683 - Improve Record ID and Record UU by Constraint Type

* IDEMPIERE-5683 - replace direct sql with model classes

- rename deleteSetNull to setRecordIdNull
- replace direct sql with model classes in deleteCascade, setRecordIdNull
- remove unnecessary change from AD_Ref_List

* IDEMPIERE-5683 - cache tables arrays in PO_Record

* IDEMPIERE-5683 - fix Dynamic Validation

* IDEMPIERE-5683 - change CleanOrphanCascade

- IsCleanChangeLog process parameter removed
- replace direct sql with java model
- delete just on Model Cascade constraint
- new Set Null rule implemented

* IDEMPIERE-5683 - fix when Record_ID is mandatory
2023-05-06 00:57:09 +02:00
hengsin afcbf6e70f
IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR… (#1818)
* IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR UPDATE

* IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR UPDATE

- add trx timeout unit test
2023-05-05 19:41:43 +02:00
Nicolas Micoud 0553878431
IDEMPIERE-5701: Improve logs when role cannot report or export (#1811)
* IDEMPIERE-5701: Improve logs when role cannot report or export

https://idempiere.atlassian.net/browse/IDEMPIERE-5701

* IDEMPIERE-5701: Reduce log level when role cannot report or export and hide Report button when role cannot report

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>
2023-05-04 00:06:53 +02:00
Carlos Ruiz 969a2e66df
IDEMPIERE-5238 Fix checkRecordIDCrossTenant failing in multi-key table (#1821) 2023-05-03 20:32:59 +02:00
Carlos Ruiz 31779a7611
IDEMPIERE-5708 Show in grid value in dictionary cannot be overriden by customize (#1820) 2023-05-03 19:17:15 +02:00
Peter Takács d53570eb75
IDEMPIERE-5695 - Process audit doesn't set print language, format, print format on Forms/documents (#1805)
* IDEMPIERE-5695 - Process audit doesn't set print language, format, print format on Forms/documents

* IDEMPIERE-5695 - get language from print format

* IDEMPIERE-5695 - fix javadoc

* IDEMPIERE-5695 - implement in startStandardReport and startFinReport
2023-05-02 17:13:55 +08:00
Carlos Ruiz 1fb4248ab9
IDEMPIERE-5706 Improvements to Tab Editor in Window Customization (#1817) 2023-05-01 16:44:51 +02:00
Carlos Ruiz 07ecea1494
IDEMPIERE-5509 Implement readonly query without using Trx - fix issue with native sequences in PostgreSQL (#1815) 2023-05-01 19:26:16 +08:00
Jose Leite 61118b8877
IDEMPIERE-5698 - Improvement for display all events errors (#1807)
* IDEMPIERE-5698 - mprovement for display all events errors

* IDEMPIERE-5698 - Improvement for display all events errors in all methods of class
2023-04-28 22:55:43 +08:00
hengsin 7bd5e579ce
IDEMPIERE-5689 Make MLocatorLookup and WLocatorEditor more extensible (#1800)
* IDEMPIERE-5689 Add setValidationCode to MLocatorLookup

* IDEMPIERE-5689 Make MLocatorLookup and WLocatorEditor more extensible
2023-04-28 12:26:47 +02:00
hengsin f18bb88f4b
IDEMPIERE-5691 Add Table Direct type joint method to Query (#1802) 2023-04-28 12:16:13 +02:00
Nicolas Micoud 254dcb3955
IDEMPIERE-5696: Width of last column of reports exported as Xlsx is n… (#1806)
* IDEMPIERE-5696: Width of last column of reports exported as Xlsx is not correct

https://idempiere.atlassian.net/browse/IDEMPIERE-5696

* IDEMPIERE-5696: Width of last column of reports exported as Xlsx is not correct - patch from hengsin

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2023-04-27 13:34:11 +08:00
Peter Takács 23713f6461
IDEMPIERE-5669 - Report Row Count shows incorrect data (#1791)
* IDEMPIERE-5669 - Report Row Count shows incorrect data

2 issues fixed:
- row count in tab did not refresh on clicking the refresh button (only on re-run)
- row count included function rows too

* IDEMPIERE-5669 - fixes

- added private attribute to rowCount Label
- added null-check to updateRowCount() method
2023-04-25 16:24:18 +08:00
Carlos Ruiz 5bf9301764
Fixes IDEMPIERE-5673 Wrong character causes java.awt.IllegalComponentStateException: This component must have a parent in order to determine its locale on reports (#1785) 2023-04-24 18:14:28 +08:00
Carlos Ruiz 80347c0926
Fixes IDEMPIERE-2194 GL Journal Distribution writes no DocumentNo in Accounting Fact Description (#1795)
- Copy the information from the line being distributed
2023-04-23 17:12:50 +08:00
hengsin eb78bd4ee9
IDEMPIERE-5678 Unit Test is failing with PostgreSQL 15 (#1789) 2023-04-19 13:57:34 +02:00
Carlos Ruiz 449c124fe1
IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) (#1787)
* IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) - fix broken unit tests

* - Fix problem with unit test:
MTestTest.testReadingUpdatingTest:65 expected: <Test setting description> but was: <Test setting descriptionMTestEventDelegate>
2023-04-19 09:07:32 +08:00
Carlos Ruiz beed782d4e
IDEMPIERE-5675 MTable.getPO cache for model factory wrongly removing from cache when PO is not found (#1788) 2023-04-18 14:34:29 +02:00
Deepak Pansheriya 76daedf6ad
IDEMPIERE-5671: Fixing Line net amount has error due to rounding. (#1782)
* IDEMPIERE-5671: Fixing Line net amount has error due to rounding.

* IDEMPIERE-5671: on price calculation add 12 decimal rounding to avoid rounding error
Co-authored-by: carg67@gmail.com
2023-04-17 10:25:05 +02:00
Jefferson Dalfre dd0e6c95ea
IDEMPIERE-5665 - [Multi Selection] - Negate option in process parameter (#1779)
* IDEMPIERE-5665

* IDEMPIERE-5665 - Fix code
2023-04-14 16:07:40 +08:00
Carlos Ruiz c80d53674a
IDEMPIERE-5567 Support of UUID as Key - Generate Model Classes (FHCA-4195) (#1772)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

New generated model classes with new UUID constructor

* - In order to use UUID constructor M classes must implement the constructor too
- Adding the constructor on MTest and adding a JUnit test to test/show how it works

* - Remove warning caused by changes on this ticket

* - Add UUID constructor to factories

* - Set new UUID constructor in mapped/annotated test classes
- Preparation for the new UUID constructor

* - Add UUID constructor to core model classes
- WARNING: MPaymentBatch(Properties, String, String) already existed with Name as parameter, it was changed to UUID
2023-04-12 11:02:33 +08:00
Peter Takács 89a093ca49
IDEMPIERE-5482 - Field Style Scope HTML Element (#1572)
* IDEMPIERE-5482 - Field Style Scope HTML Element

* IDEMPIERE-5482 - implemented in report engine, removed the new field

* IDEMPIERE-5482 - add IsWrapWithSpan to AD_Style

* IDEMPIERE-5482 -  pr1572 patch
2023-04-11 22:22:10 +08:00
Carlos Ruiz b5cb64bc92
IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) (#1771)
* IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195)

* - Search editor now assigns the value correctly when selecting from Info Window
- Info Window shows correctly the first UU key column
- Added Record UUID new data type to work with record ID editor but with UU column
- Added column/field Test.Record_UU for testing

* - Fix opening Record ID editor after saved

* - Implement changes suggested by Heng Sin's peer review

* - Remove other unnecessary changes

* - safer comparison
2023-04-11 13:20:13 +08:00
Carlos Ruiz 2e9b1222d3
IDEMPIERE-5560 Fix broken unit tests (#1770) 2023-04-06 16:04:45 +08:00
Peter Takács b1bf9bc4e9
IDEMPIERE-5650 - Cannot Define Multiple Values for Dashboard Content Process Parameters (#1757)
* IDEMPIERE-5650 - Cannot Define Multiple Values for Dashboard Content Process Parameters

* IDEMPIERE-5650 - remove hardcoded condition

* IDEMPIERE-5650 - fix for reference list multiselection

- support for non-ID multiselection types (values were not rendered e.g. with DocType="IP,CO")

* IDEMPIERE-5650 - fix for reference list multiselection

* IDEMPIERE-5650 - bug fixes

- error use case: reference list with numeric values e.g. "10", "20",... (fix: check DisplayType instead of data type)
- error use case 2: defining more than one multi-selection caused parsing error (fixed parsing logic in MDashboardContent)

* IDEMPIERE-5650 - optimise parsing method

* IDEMPIERE-5650 - pr1757_PR0 patch
2023-04-05 13:00:00 +02:00
Carlos Ruiz a967069164
IDEMPIERE-5567 Support of UUID as Foreign Key (FHCA-4195) (#1741)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Foreign Keys

* - Table Direct working as read-only and link column

* - Fixes for Table with Reference

* - Add UUID FK management to Migrate ID process
- Add MColumn.beforeSave validation to force UUID columns to end with _UU
- Add table TestUUDet with two foreign keys pointing to TestUU (TableDir and Search)
- Add detail tab to Test UU Based Table window
- Add a new test window named Test UU Detail
- Generate model classes for the new test table
- Add test case for the detail test table
- Add MTable.isIDKeyTable method
- Add UU foreign key cross tenant validation to PO.validForeignKeys

* - Added a Chosen Multiple Selection Table with foreign UU for testing
- Changed reference in dictionary logic and sql to reflect new data types
- Disable SearchUU temporarily (will be worked in next step)
- Add validation to avoid encrypting UUID columns
- Avoid warning when searching for getPO method on UUID based tables
- Make Zoom Across button work with UUID foreign keys
- Enable zoom and zoom to detail for UUID foreign keys
- Enable Find Advanced on detail foreign UUID keys

* - Fix javadoc
- Quote properly UUID
- Validate null on return

* - Fix zoom logic - tested zooming to tab in first second and third level
2023-04-05 10:26:27 +08:00
Peter Takács 30d89378c8
IDEMPIERE-5659 - New Document Base Type Group Window (#1768)
* IDEMPIERE-5659 - New Document Base Type Group Window

* IDEMPIERE-5659 - fixes

- renaming the table, model and elements according to the ticket
- removing MDocBaseGroup beforeSave validation
- adding an unique index for the Line table
2023-04-04 13:04:41 +02:00
Peter Takács 33de756336
IDEMPIERE-5645 - Print Format Script Column cannot find Columns from context (#1760)
* IDEMPIERE-5645 - Print Format Script Column cannot find Columns from context

* IDEMPIERE-5645 - move script columnd parsing after 'all rows' loop

* IDEMPIERE-5645 - fixes
2023-04-04 14:32:57 +08:00
Carlos Ruiz 9e18bc725e
IDEMPIERE-5174 Disable System User - Set new System (#1769) 2023-04-04 11:36:30 +08:00
Peter Takács 3cb7d395e1
IDEMPIERE-5652 - Print Format: Format Pattern is not Applied on Grouping/Summary rows (#1762) 2023-04-02 15:40:10 +08:00
hengsin 65f565e542
IDEMPIERE-5528 Context parsing on process Parameter not considering tab no (#1765)
- implement parent Evaluatee for GridField and ProcessParameterPanel
2023-04-01 16:24:07 +02:00
hengsin ee1b6828f4
IDEMPIERE-5560 Cannot save more than one order line when an _ID field is not displayed (#1764) 2023-04-01 16:11:35 +02:00
Deepak Pansheriya 5199247a1e
IDEMPIERE-5602 : Adding PriceEntered in Expense report (#1759) 2023-03-30 13:29:38 +02:00
muriloht 1441b9095a
IDEMPIERE-5647 - allow define context variables by role (#1753)
* IDEMPIERE-5647 - allow define context variables by role

* IDEMPIERE-5647 - fix PR comment
2023-03-29 12:44:15 +02:00
Carlos Ruiz d9764ce54e
IDEMPIERE-5238 Record_ID editor - fix 2Pack broken (#1754) 2023-03-27 19:00:21 +08:00
Nicolas Micoud 59069f4cfe
IDEMPIERE-5644 : Allow to set an image per form (#1751)
* IDEMPIERE-5644 : Allow to set an image per form

https://idempiere.atlassian.net/browse/IDEMPIERE-5644

* IDEMPIERE-5644 : Allow to set an image per form - fix suggested by hengsin

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2023-03-27 18:26:20 +08:00
Jose Leite 45a8e18d32
IDEMPIERE-5640 - Fix Cross Tenant Sending BroadCast Message (#1750)
* IDEMPIERE-5640 - Fix Cross Tenant Sending BroadCast Message

* IDEMPIERE-5640 - Add validation in fix Cross Tenant Sending BroadCast Message
2023-03-24 14:20:21 +01:00
Carlos Ruiz 2d928ed37e
IDEMPIERE-5633 Check tableId <=0 in PO.checkRecordIDCrossTenant() (#1745)
IDEMPIERE-5238

Thanks to Ken Longnan
2023-03-24 11:24:47 +08:00
Diego Ruiz 89dfb22482
IDEMPIERE-5637 - Improve GridField to allow setting the default values of GridFieldVO programmatically with a method (#1746)
* IDEMPIERE-5637 - Improved GridField and GridFieldVO to allow setting default value programmatically

* IDEMPIERE-5637 - Minor refactor to improve code readibility

* IDEMPIERE-5637 - Defined constants for priority default order
2023-03-23 21:30:58 +08:00
Peter Takács bf7c9792af
IDEMPIERE-5588 - Multiselect Chosenbox Editor Doesn't Initialise its List when Tab First Opened (#1744)
* IDEMPIERE-5588 - Multiselect Chosenbox Editor Doesn't Initialise its List when Tab First Opened

* IDEMPIERE-5588 - pr1744 patch
2023-03-22 16:52:28 +08:00
Carlos Ruiz 51ceaacb43
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1727)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

* - Implement changes to support Model classes with UUID constructor

* - fix issue with tables with single parent key - like AD_Ref_Table

* - Create test table and JUnit test

* - fixes from Heng Sin

* - Improve performance on new methods in MTable
- Minor refinements in ModelClassGenerator
- Regenerate Test X classes
- Change Create Window from Table to receive the parent link as parameter (because tables can have now no keys at all)

* - Implement suggestions from Heng Sin

* - _UU column as primary key constraint for UUID based tables

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-03-21 21:30:45 +08:00
Nicolas Micoud 85af1ed2a1
IDEMPIERE-5608: Improve server logs by tenant and user data (#1715)
* IDEMPIERE-5608: Improve server logs by tenant and user data

* IDEMPIERE-5608: Improve server logs by tenant and user data - migration script

* IDEMPIERE-5680: Improve server logs by tenant and user data - use VM argument

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-5608: Improve server logs by tenant and user data: various fixes

* IDEMPIERE-5608: Improve server logs by tenant and user data - revert changes on server.product.launch

* IDEMPIERE-5608: Improve server logs by tenant and user data - Carlos's patch

tested: )
Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-03-21 12:08:44 +08:00
matheus-marcelinux b11b7bcf95
IDEMPIERE-5631 - ModelEventHandler findTableName by Model annotation (#1739) 2023-03-18 12:52:23 +08:00
hengsin e479eb5cfb
IDEMPIERE-5609 Dashboard Performance Indicators incrementally redrawed on DC drag and drop (#1736) 2023-03-17 11:45:56 +01:00
Carlos Ruiz eab0574dae
IDEMPIERE-5565 Cannot create report with virtual column where reference is table with display column = ID (#1735)
* IDEMPIERE-5565 Cannot create report with virtual column where reference is table with display column = ID

* - make it consistent with the actual approach
2023-03-17 14:27:00 +08:00
Peter Takács 47987c0314
IDEMPIERE-5538 - Add isValid to Drill Rule allow validate parameters with beforesave (#1632)
* IDEMPIERE-5538 - Add isValid to Drill Rule allow validate parameters with beforesave

* IDEMPIERE-5538 - beforeSave, capture process parameters

* IDEMPIERE-5538 - validate only through process

* IDEMPIERE-5538 - isValid check in getByTable method

* IDEMPIERE-5538 - add validation to before save/after delete

* IDEMPIERE-5538 - validate system drill rules

* IDEMPIERE-5538 - fix validation logic

The mandatory validation have to skip the key parameter since it is not loaded from Drill Rule Para.

* IDEMPIERE-5538 - fix Drill Rule window definition

* IDEMPIERE-5538 - bug fix scripts to iD10

* IDEMPIERE-5538 - fix missing read only logic

* IDEMPIERE-5538 - all scripts to iD10
2023-03-16 19:10:15 +08:00
Peter Takács b7b9a4d476
IDEMPIERE-5621 - Dashboard Report ignore if parameter is mandatory or not (#1714)
* IDEMPIERE-5621 - Dashboard Report ignore if parameter is mandatory or not

* IDEMPIERE-5621 - small fixes

* IDEMPIERE-5621 - missing javadoc for new methods

* IDEMPIERE-5621 - move scripts, list empty para, update css
2023-03-16 12:01:40 +08:00
Carlos Ruiz d4dd4585b6
IDEMPIERE-5611 Record ID Editor doesn't work with House Keeping (#1720)
* IDEMPIERE-5611 Record ID Editor doesn't work with House Keeping

- Fix zoom window on tables that have this field empty and have a window associated

* - Fix zoom and lookup without AD_Window_ID update

* - Add discovery for more tab levels

* - Fix zoom when AD_Table.AD_Window_ID is null.

* - use the new method also in InfoGeneralPanel

* - set zoom window just when is not defined (preserve potential customizations)

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-03-15 22:34:31 +08:00
Nicolas Micoud 075c41c63f
IDEMPIERE-5610: Improve layout of Password Validator translations (#1702)
https://idempiere.atlassian.net/browse/IDEMPIERE-5610
2023-03-15 19:00:38 +08:00
Carlos Ruiz f35585a96e
IDEMPIERE-5238 Record_ID editor (#1728)
- exclude AD_WF_Activity from the validation to avoid affecting performance
2023-03-14 21:53:06 +08:00
Carlos Ruiz c29184fbf1
IDEMPIERE-5616 Reverse Shipments don't post because of Not Balanced in special case (#1706)
* IDEMPIERE-5616 Reverse Shipments don't post because of Not Balanced in special case

* - Add case for Inventory Move
- Add explanatory comment

* - Add extra cases for other documents

* - uploaded a different approach

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-03-14 20:59:59 +08:00
Carlos Ruiz 4c77efecb4
IDEMPIERE-5613 Make filling of _UU column optional (#1719)
* IDEMPIERE-5613 Make filling of _UU column optional

* - clear _UU when column is made inactive

* - Add parameter IsClearUUID
- Fix issue with buffer log not being flushed
2023-03-14 20:20:57 +08:00
hengsin b188775e9a
IDEMPIERE-5624 Implement export data as SQL insert statement (#1721) 2023-03-13 15:57:45 +01:00
Peter Takács 1bc5370dbb
IDEMPIERE-5618 - Print Format Script Column does not show Data in correct Data Types (#1712)
* IDEMPIERE-5618 - Print Format Script Column does not show Data in correct Data Types

* IDEMPIERE-5618 - optimised and simplified the code

- get PrintFormatType from PrintDataColumn pdc
- getDisplayType(value) method to unify and simplify getting the display type
2023-03-13 21:40:09 +08:00
Carlos Ruiz e4b7c9e17d
IDEMPIERE-5628 Record ID Check Issue - implement setCrossTenantSafe (#1724)
* IDEMPIERE-5628 Record ID Check Issue - implement setCrossTenantSafe

* - remove table exceptions
2023-03-13 21:38:00 +08:00
Carlos Ruiz ef06b837d6
IDEMPIERE-5542 [DisplayType] - Cache issue (#1718)
Minor refactoring to use MTable.MAX_OFFICIAL_ID
2023-03-11 20:46:45 +08:00
Carlos Ruiz fb98b75ce9
IDEMPIERE-5542 [DisplayType] - Cache issue (#1717)
- Fix problem with the AbstractXLSXExporter going wild, the method getFormatString is trying to create a format with the number of digits supported by the NumberFormat, and as the MaximumIntegerDigits is not set, is trying to create a String with the default which is 2147483647
2023-03-11 01:01:09 +08:00
hengsin 3877a672c6
IDEMPIERE-5586 Implement ID independent migration script (#1711)
- Update should use ID column for where clause if ID value is official id.
2023-03-10 12:16:26 +01:00
Carlos Ruiz fe72b671ab
IDEMPIERE-5238 Record_ID editor (#1705)
- fixes for the new cross-tenant validation
2023-03-09 10:16:25 +08:00
Deepak Pansheriya 09f524910c
IDEMPIERE-5594 : On detail panel grid, button not respect context par… (#1701)
* IDEMPIERE-5594 : On detail panel grid, button not respect context parsing for DispalyLogic, DefaultValue, MandatoryLogic. take context of previous row.

* IDEMPIERE-5594: Refactored code by Hengsin
Co-authored-by: hengsin@gmail.com
2023-03-08 20:01:10 +08:00
Carlos Ruiz ff4516c86c
IDEMPIERE-5238 Record_ID editor (#1703)
- exclude AD_ChangeLog and AD_RecentItem from the validation to avoid affecting performance
2023-03-08 19:58:59 +08:00
Carlos Ruiz 7f7617328a
IDEMPIERE-5238 Record_ID editor - Add safety validation in PO (#1700)
* IDEMPIERE-5238 Record_ID editor - Add safety validation in PO

* - get AD_Client_ID from current record instead of ctx
2023-03-08 11:07:31 +08:00
Peter Takács b9bed8690a
IDEMPIERE-5576 - Disallow "period close and permanent close" when unposted documents exists (#1678)
* IDEMPIERE-5576 - Disallow "period close and permanent close" when unposted documents exists

* IDEMPIERE-5576 - fixes

* IDEMPIERE-5576 - return message for process

* IDEMPIERE-5576 - added SysConfig

* IDEMPIERE-5576 - added DocStatus check

* IDEMPIERE-5576 - pr1678PR1 patch
2023-03-07 11:36:26 +01:00
hengsin 859dd1a723
IDEMPIERE-5600 Add Core.getDefaultAnnotationBasedEventManager() API (#1698)
* IDEMPIERE-5600 Add Core.getDefaultAnnotationBasedEventManager() API

* IDEMPIERE-5600 Add Core.getDefaultAnnotationBasedEventManager() API

- minor refinement
2023-03-06 20:40:48 +01:00
Nicolas Micoud 7417e1ce3c
IDEMPIERE-5595: Allow to deactivate negate option for "Chosen Multipl… (#1695)
* IDEMPIERE-5595: Allow to deactivate negate option for "Chosen Multiple Selection" components in processes

https://idempiere.atlassian.net/browse/IDEMPIERE-5595

* IDEMPIERE-5595: regenerate serial

* IDEMPIERE-5595: move scripts to iD10 / resolve conflict

* IDEMPIERE-5595: change position of the field / update existing data

* IDEMPIERE-5595: check ProcedureName is empty before enabling it

* IDEMPIERE-5595: update existing records missing in oracle

* Update 202303020910_IDEMPIERE-5595.sql

* Update 202303020910_IDEMPIERE-5595.sql

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-03-06 19:56:56 +01:00
hengsin 6a5d45cba7
IDEMPIERE-5542 [DisplayType] - Cache issue (#1687) 2023-03-06 18:33:57 +01:00
Peter Takács dbd024f78e
IDEMPIERE-5238 - Record_ID editor (#1610)
* IDEMPIERE-5238 - initial draft commit

* IDEMPIERE-5238 - fixes

* IDEMPIERE-5238 - popup window

* IDEMPIERE-5238 - renaming to Record ID

* IDEMPIERE-5238 - renaming to Record ID

* IDEMPIERE-5238 - fixes

* IDEMPIERE-5238 - fixes

* IDEMPIERE-5238 - fixes

* IDEMPIERE-5238 - technical fixes

* IDEMPIERE-5238 - pr1610_1 patch

* IDEMPIERE-5238 - bug fixes

* IDEMPIERE-5238 - set table to read only

* IDEMPIERE-5238 - fix parsing error

* IDEMPIERE-5238 - pr1610 patch

* IDEMPIERE-5238 - fix Find Window issue

* IDEMPIERE-5238 - Info Panel NPE patch

* IDEMPIERE-5238 - UI fix

In the Record ID Dialog the 'Record' label should be visible only when the corresponding editor is visible.

* IDEMPIERE-5238 - find window patch

* IDEMPIERE-5238 - clear Record ID when clearing AD_Table_ID

* IDEMPIERE-5238 - clear Record ID when clearing AD_Table_ID

* IDEMPIERE-5238 - move scripts to correct folder

All scripts to iD10
2023-03-06 15:10:51 +08:00
hengsin 6a66903ec6
IDEMPIERE-5586 Implement ID independent migration script (#1685)
* IDEMPIERE-5586 Implement ID independent migration script

* IDEMPIERE-5586 Implement ID independent migration script

- add Oracle script (99% converted by ChatGPT from PostgreSQL :)).

* IDEMPIERE-5586 Implement ID independent migration script

- handle official id value for foreign key reference .
- add back centralized id support.

* IDEMPIERE-5586 Implement ID independent migration script

- minor refactoring
- add support for AD_Table_ID+Record_ID usage

* IDEMPIERE-5586 Implement ID independent migration script

- add support for Delete
- add unit test

* IDEMPIERE-5586 Implement ID independent migration script

- add insert_accounting and insert_tree support.

* IDEMPIERE-5586 Implement ID independent migration script

- add ADSortTab support.

* IDEMPIERE-5586 Implement ID independent migration script

- move migration script from iD11 to iD10.
2023-03-02 18:24:41 +01:00
Peter Takács a53d87f714
IDEMPIERE-5563 - Font Icons not implemented on HTML Report column menu (#1689)
* IDEMPIERE-5563 - Font Icons not implemented on HTML Report column menu

* IDEMPIERE-5563 - Font Icons not implemented on HTML Report column menu

* IDEMPIERE-5563 - pr1689 patch
2023-03-02 20:48:17 +08:00
Peter Takács 36613c467e
IDEMPIERE-5470 - Date Range Fieldtype (Reference List) (#1552)
* IDEMPIERE-5470 - Date Range Fieldtype (Reference List)

* IDEMPIERE-5470 - autodetection, fixing concept

* IDEMPIERE-5470 - remove Date Range Picker reference

* IDEMPIERE-5470 - add IsDisplayDateInWords to Process Parameter

* IDEMPIERE-5470 - DateRangeOption dropdown

* IDEMPIERE-5470 - fixes

* IDEMPIERE-5470 - patch pr1552

* IDEMPIERE-5470 - patch pr1552_1
2023-03-02 12:27:36 +01:00
Peter Takács e7b9b72582
IDEMPIERE-5573 - Enable Showing Inactive Records through Reference (#1674)
* IDEMPIERE-5573 - Enable Showing Inactive Records through Reference

* IDEMPIERE-5573 - fixes
2023-02-17 10:47:39 +08:00
Carlos Ruiz 59ded47edf
IDEMPIERE-5578 Data corruption when copying order lines from a closed order (#1677)
* IDEMPIERE-5578 Data corruption when copying order lines from a closed order

* - refactor MOrderLine.getDescriptionStrippingCloseTag for optimization

* - regenerate serialVersionUID
2023-02-17 10:43:24 +08:00
Peter Takács 34163826f0
IDEMPIERE-5579 - Missing Period Control When Reactivating Orders (#1679) 2023-02-16 14:30:53 +01:00
Peter Takács 883edf8436
IDEMPIERE-5575 - Period Controll, new option - Period Document Close (#1676)
* IDEMPIERE-5575 - Period Controll, new option - Period Document Close

* IDEMPIERE-5575 - patch pr1676
2023-02-15 15:37:28 +01:00
hengsin 1daa1c70e2
IDEMPIERE-5572 Scheduler: Allow process to suppress auto sending of process execution result to scheduler recipients (#1668) 2023-02-10 14:13:40 +01:00
Carlos Ruiz 33f2ccf7b8
IDEMPIERE-5568 Allow Force in Sales Order Delivery Rule even if the warehouse doesn't accept negatives (#1665) 2023-02-10 14:08:16 +01:00
Carlos Ruiz 7e0202eedb
IDEMPIERE-5571 Shipment created by Drop Ship Material Receipt is not processing workflows (#1667) 2023-02-09 16:37:22 +01:00
Carlos Ruiz 801d1fb898
IDEMPIERE-5565 Cannot create report with virtual column where reference is table with display column = ID (#1662) 2023-02-08 15:48:46 +08:00
Carlos Ruiz 946730f1be
IDEMPIERE-5443 Date Range Filter Component / SystemIDs (#1664)
- minor change - reorganize SystemIDs
2023-02-08 15:47:05 +08:00
Carlos Ruiz 8ff1068184
IDEMPIERE-5566 Cross tenant PO writing on AD_System (#1663) 2023-02-08 15:42:32 +08:00
hengsin 2b24496d16
IDEMPIERE-5557 Dashboard Rendering Threads do not hold language set after login (#1659)
- add setup of thread local Locale to ContextRunnable
2023-02-05 11:21:48 +01:00
Diego Ruiz 291a4df19e
IDEMPIERE-5664 - Improve the message thrown by Import CSV Process when a field does not exist in the tab (#1660) 2023-02-03 10:13:33 +08:00
matheus-marcelinux 9f71eeadbc
IDEMPIERE-5458 - Timezone defined by Organization (#1568)
* # IDEMPIERE-5458 - Timezone defined by Organization

* # IDEMPIERE-5468 - improved unit test

* # IDEMPIERE-5458 - removing user/password from scriptg

* IDEMPIERE-5458 - fix migration script

* IDEMPIERE-5458 - adding field in org info tab
2023-02-01 11:43:06 +08:00
Carlos Ruiz 29f59e645f
IDEMPIERE-5515 Processes Generate "Unknown Parameter: ..." logs (#1646)
* IDEMPIERE-5515 Processes Generate "Unknown Parameter: ..." logs

* - Fix for the new PrintFormatItemSync
2023-01-26 13:09:11 +01:00
Carlos Ruiz d123de6452
IDEMPIERE-5548 Issues with Log Management (#1640)
* IDEMPIERE-5548 Issues with Log Management

- removed the button Reload Log Props from the About Dialog as is now being reloaded when changing level

* - set level also on handlers
- restore the button Reload Log Props
2023-01-21 13:04:06 +08:00
Carlos Ruiz c28655af5f
IDEMPIERE-5534 Make configurable the maximum records in lists (#1630)
* IDEMPIERE-5534 Make configurable the maximum records in lists

* - Impose hardcoded limit of 50.000 as suggested by Heng Sin

* - SysConfig name MAX_ROWS_IN_TABLE_COMBOLIST

* - change message
2023-01-19 19:16:07 +08:00
Carlos Ruiz 54659001ff
IDEMPIERE-5229 After migrate helper (FHCA-4070) (#1645)
- Fix NullPointerException when the customized record does not exist
- Fix reporting false positives on tables/columns not audited
2023-01-18 22:36:22 +01:00
Carlos Ruiz f2684bad08
IDEMPIERE-5229 After migrate helper (FHCA-4070) (#1638)
* IDEMPIERE-5229 After migrate helper (FHCA-4070)
* - remove useless comment
* - improve comment positioning
2023-01-18 13:01:40 +01:00
Deepak Pansheriya 7ab1e8c3d5
IDEMPIERE-5528 : Default logic on process dialog not getting value from tab. (#1634) 2023-01-15 10:43:58 +08:00
Ricardo Santana 5b464e18fc
IDEMPIERE-5544 - Fix orders being calculated with wrong tax provider (#1636) 2023-01-14 12:08:00 +01:00
Jose Leite 5bcf7178af
# IDEMPIERE-5533 - Changes MSequence to allow HTTPS on ID centralizer (#1629) 2023-01-07 14:54:06 +01:00
matheus-marcelinux 34fb9afa05
IDEMPIERE-5530 - adding ad_client_id to mworkflow cache key (#1625) 2023-01-05 20:04:33 +01:00
Carlos Ruiz dd7b63aa0d
IDEMPIERE-5523 Release 10 Peace (#1624)
- move master to release-11 development build
2022-12-24 00:20:49 +01:00
Carlos Ruiz 1d9d504801
IDEMPIERE-5523 Release 10 Peace (#1619)
* IDEMPIERE-5523 Release 10 Peace

* - generate model classes

* - Add release image contributed by Vanessa Castro
2022-12-23 14:27:27 +01:00
hengsin 773b7d7058
IDEMPIERE-5524 Slow Rendering of HTML Report (#1612) 2022-12-23 12:17:56 +01:00
Carlos Ruiz d074e173d1
IDEMPIERE-5295 Trial Balance Report creates wrong Opening Balance (#1614)
- Add column T_TrialBalance_UU / IDEMPIERE-5523
2022-12-23 11:38:54 +01:00
hengsin 06b02889f8
IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has incon… (#1598)
* IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs

* IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs

- refinement and added unit tests

* IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs

- add unit test for lot level costing

* IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs

- fix unit test error.

* IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs

- add unit test for cost adjustment

* IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs

- add unit test for physical inventory

* IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs

- add unit test for PO landed cost
2022-12-20 14:29:07 +01:00
Nicolas Micoud 047674b2a1
IDEMPIERE-5505 : Add Value and PrintName on GL_Category (#1594)
* IDEMPIERE-5505 : Add Value and PrintName on GL_Category
https://idempiere.atlassian.net/browse/IDEMPIERE-5505

* IDEMPIERE-5505 : Add Value and PrintName on GL_Category - Value is mandatory
* IDEMPIERE-5505 : Add Value and PrintName on GL_Category - set Value to 60 chars
* IDEMPIERE-5505: Add Value and PrintName on GL_Category - add Index on Value
* IDEMPIERE-5505 : Add Value and PrintName on GL_Category - Missing AD_Sequence for Value column

integrate patch from @CarlosRuiz-globalqss
Co-Authored-By: Carlos Ruiz <carg67@gmail.com>
2022-12-06 11:50:06 +01:00
hengsin 8ab72bcba2
IDEMPIERE-5509 Implement readonly query with using Trx (#1599) 2022-12-05 16:48:23 +01:00
Carlos Ruiz 816e57ec5a
IDEMPIERE-5371 : Adding user session reference on Process Instance (#1603)
* IDEMPIERE-5371 : Adding user session reference on Process Instance

* - Peer review

Co-authored-by: dpansheriya <deepakpansheriya@gmail.com>
2022-12-05 15:16:06 +01:00
Carlos Ruiz 23735316f9
IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823) (#1596)
* IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823)

Show MFA for support users in System, even if they have roles in several tenants, they can just have MFA defined in System tenant

* IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823)

- Change of approach, the MFA can be shown first when the client is defined, or when the user is defined to belong to a single tenant
  - on the contrary, when we have same user/password in two tenants, the MFA must be delayed until the tenant is identified

- Reviewing this noticed that the Login locking/inactivity logic is working on the full users array, even if the user has a different password (so is a different user)
  Fixed this to work just on the authenticated users - this is, those that have the same password in different tenants
2022-12-02 15:31:56 +08:00
matheus-marcelinux ac81f3529b
IDEMPIERE-5468 - Negate option in parameter panel when component is a Chosen Multiple Selection (#1567)
* # IDEMPIERE-5468 - implement negate option for chosen multiple selection components as process parameter

* # IDEMPIERE-5468 - Negate option in parameter panel when component is a Chosen Multiple Selection

* IDEMPIERE-5468 - ui improvements

* IDEMPIERE-5468 - adding old method signature

* IDEMPIERE-5468 - fix method comment

* # IDEMPIERE-5468 - fix missing methods

* IDEMPIERE-5468 - applying hengsins suggestion and translating tooltips
2022-12-01 13:20:25 +08:00
Elaine Tan e723456063
IDEMPIERE-5504 Very slow performance retrieving Product Costs > Cost Movement records (#1593) 2022-11-30 17:20:31 +08:00
Peter Takács b4aaabb8b4
IDEMPIERE-5490 - Dashboard Content->Report -> Allow specify Print Format (#1589)
* IDEMPIERE-5490 - Dashboard Content->Report -> Allow specify Print Format

* IDEMPIERE-5490 - add AD_PrintFormat_ID to Dashboard Content table
2022-11-30 11:46:34 +08:00
Carlos Ruiz 2fa0d49ac4
IDEMPIERE-5501 Misses in cache IDisplayTypeFactory (#1592) 2022-11-29 11:46:40 +08:00
Peter Takács 253125b60a
IDEMPIERE-5483 - Physical Inventory Doesn't Update Last Inventory Date on Specific Cases (#1575)
* IDEMPIERE-5483 - Physical Inventory Doesn't Update Last Inventory Date on Specific Cases

* IDEMPIERE-5483 - requested changes

* IDEMPIERE-5483 - fixes

* IDEMPIERE-5483 - fixed fallen test case
2022-11-29 10:39:21 +08:00
matheus-marcelinux 7621447500
# IDEMPIERE-5494 - enable zoom in WLocationEditor (#1586) 2022-11-27 14:06:39 +08:00
Deepak Pansheriya 2074e98616
IDEMPIERE-3334: Adding support for Readonly Logic, Set Pressed Logic … (#1244)
* IDEMPIERE-3334: Adding support for Readonly Logic, Set Pressed Logic on custom toolbar button

* IDEMPIERE-3334: Fix as per Hengsin suggestion

* IDEMPIERE-3334: Renaming migration scripts, changing VARCHAR2(2000) to VARCHAR2(2000 CHAR) and fixing sql have line starting with @

* IDEMPIERE-3334: SQL Logic evaluate by using Evaluator.parseSQLLogic()

* IDEMPIERE-3334 : Adding support for pressed and readonly logic on Window->Tab->toolbar

* IDEMPIERE-3334 : Adding Hengsin't patch

* IDEMPIERE-3334 : removing ParseContext call
2022-11-23 13:05:14 +08:00
Elaine Tan 2ff6378720
IDEMPIERE-5472 Unclosed resources (#1565)
* IDEMPIERE-5472 Unclosed resources

* IDEMPIERE-5472 Unclosed resources
2022-11-17 17:35:15 +08:00
Carlos Ruiz 4d9bc5340c
IDEMPIERE-5474 Fixed Assets don't allow depreciation on 18 months (#1562) 2022-11-16 15:47:36 +08:00
Carlos Ruiz 74e94cb77f
IDEMPIERE-5136 Set Messages at tenant level / Fix NPE (#1561) 2022-11-15 21:53:06 +08:00
hengsin 05bf9d6add
IDEMPIERE-5473 Refactoring of WArchive and MArchive (#1555) 2022-11-15 14:51:11 +01:00
hengsin c9f589c4d5
IDEMPIERE-5477 Concurrency issue for the use of OSGi Service Tracker (#1563) 2022-11-15 14:17:02 +01:00
Carlos Ruiz f84ca70440
IDEMPIERE-2398 Renamed FA_ProjectCreateAsset to "Create Asset from Project" and added/fixed broken parameters (#1556)
* IDEMPIERE-2398 Renamed FA_ProjectCreateAsset to "Create Asset from Project" and added/fixed broken parameters

* IDEMPIERE-2398 - improve error message of process

* - set asset value from project committed amount

* - set asset value back from project balance amount
- make the project balance amount editable
- add link to the asset addition at the end of the process

Co-authored-by: Chuck Boecking <chuck@chuboe.com>
2022-11-14 22:29:11 +01:00
hengsin da587235c7
IDEMPIERE-5476 Refactoring of WRequest and MRequest (#1560) 2022-11-14 22:02:14 +01:00
Carlos Ruiz be7fb240cb
IDEMPIERE-870 Fixed Assets using non-existant context variable (#1557)
* IDEMPIERE-870 Fixed Assets using non-existant context variable

* - Implement context variable #IsCanApproveOwnDoc
2022-11-12 21:48:46 +08:00
Carlos Ruiz fc6ae185b9
IDEMPIERE-5475 Fixed Assets - NPE when creating an asset addition withou invoice (#1558) 2022-11-12 09:15:48 +08:00
Peter Takács 6f737cacdd
IDEMPIERE-5467 - Implement IsRange for Info Window fields (#1550)
* IDEMPIERE-5467 - Implement IsRange for Info Window fields

* IDEMPIERE-5467 - refactor DateRangePicker, autodetect feature

* IDEMPIERE-5467 - fixes

* IDEMPIERE-5467 - pr1550 patch
2022-11-11 16:35:04 +08:00
hengsin d50a44c744
IDEMPIERE-5469 Refactoring of TimeUtil (#1549)
* IDEMPIERE-5469 Refactoring of TimeUtil
* IDEMPIERE-5469 Refactoring of TimeUtil
- Merge patch from Carlos
2022-11-10 14:36:53 +01:00
hengsin 5b5a957d87
IDEMPIERE-5471 Refactoring of Payment Selection and Payment Print/Exp… (#1554)
* IDEMPIERE-5471 Refactoring of Payment Selection and Payment Print/Export form

* IDEMPIERE-5471 Refactoring of Payment Selection and Payment Print/Export form

- merge patch from Carlos
2022-11-08 17:15:25 +01:00
Carlos Ruiz 193141324e
IDEMPIERE-5463 Help on Role Panel selection page (#1548)
* IDEMPIERE-5463 Help on Role Panel selection page

- SysConfig LOGIN_SELECTION_HELP_URL defaulting to https://wiki.idempiere.org/{lang}/Login_Selection_Help
- added WebUtil.isUrlOk
- verify if the login and selection help page exists before opening, otherwise default to english version

* - rename SysConfig LOGIN_SELECTION_HELP_URL to LOGIN_SELECT_ROLE_HELP_URL

* - fix wrong SysConfig name
2022-11-02 22:59:05 +08:00
Peter Takács ed7fb79cd7
IDEMPIERE-5460 - Process Audit doesn't set printing related attribute… (#1543)
* IDEMPIERE-5460 - Process Audit doesn't set printing related attributes when editors are not set

* IDEMPIERE-5460 - fixes
2022-11-02 13:31:29 +08:00
hengsin d76c6257fa
IDEMPIERE-5057 Implement Deductible and non deductible input tax for … (#1542)
* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

- Fix error when user change invoice/order line to use parent tax

* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

- Miss MRMATax in previous commit.

* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

- Fixed order/invoice tax lines not created after save
2022-11-01 14:48:17 +01:00
Carlos Ruiz dd77cc01cb
IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823) / fix issue with EMail MFA (#1545)
* When user login with EMail MFA the MFA panel is not shown and the Processing message just keep spinning
* Changed the message TenantNotFound by FailedLogin to avoid a brute force attack to discover which tenants are valid in the installation
2022-10-27 15:53:30 +02:00
Peter Takács 978be7a956
IDEMPIERE-5456 - Msg wrong arguments number Format (#1537) 2022-10-21 10:33:47 +08:00
Carlos Ruiz 67c9cb7abc
IDEMPIERE-5451 Create a form SQL Query - similar to SQL process to execute queries (FHCA-3849) (#1533)
* IDEMPIERE-5451 Create a form SQL Query - similar to SQL process to execute queries (FHCA-3849)

* - fix wrong default in SysConfig
* - remove unnecessary annotation
* - process the query in a read-only transaction
* - commit not needed since this is readonly
2022-10-20 15:37:28 +02:00
Nicolas Micoud 9b46986596
IDEMPIERE-5454 : Issue on TimeUtil.getBusinessDaysBetween with country based on language (#1534)
https://idempiere.atlassian.net/browse/IDEMPIERE-5454
2022-10-20 17:36:11 +08:00
Carlos Ruiz 45a1b4ba4d
IDEMPIERE-5450 Improve misleading name of SysConfig (#1532) 2022-10-17 16:58:19 +02:00
Carlos Ruiz 7ffb18b8e2
IDEMPIERE-5450 Form SQL Process has security issues (#1528)
* IDEMPIERE-5450 Form SQL Process has security issues

* - fix javadoc

* - remove unnecessary code

* - minor improvement

* - improve discovery of single word commands
- avoids the need of space in the SysConfig key
2022-10-16 22:21:05 +08:00
Carlos Ruiz d421dba94e
IDEMPIERE-5445 Implement multiplier and rounding for financial reports (#1524)
* IDEMPIERE-5445 Implement multiplier and rounding for financial reports

* - Improve loop
2022-10-16 11:29:12 +02:00
hengsin e6eb86a1c5
IDEMPIERE-5447 Add unit test for Merge form (#1523)
* IDEMPIERE-5447 Add unit test for Merge form

* IDEMPIERE-5447 Add unit test for Merge form

- Merge patch from Carlos
2022-10-12 16:02:56 +08:00
hengsin 62bbb83cb2
IDEMPIERE-5444 Refactoring of GridTabVO and GridFieldVO (#1519) 2022-10-11 16:00:08 +02:00
Nicolas Micoud 1646074a59
IDEMPIERE-5446 : Property to know an AttachmentEntry has been updated (#1522)
* IDEMPIERE-5446 : Property to know an AttachmentEntry has been updated

https://idempiere.atlassian.net/browse/IDEMPIERE-5446

* IDEMPIERE-5446 : Property to know an AttachmentEntry has been updated - fix javadoc
2022-10-10 14:59:07 +08:00
Peter Takács a96c6e482d
IDEMPIERE-5432 - Performance Measure Calculation - Improve SQL Definition (#1500)
* IDEMPIERE-5432 - Performance Measure Calculation - Improve SQL Definition

* IDEMPIERE-5432 - IDEMPIERE-5432_PR1 patch
2022-10-07 14:01:12 +08:00
Deepak Pansheriya abae9f221d
IDEMPIERE-5349: Adding AlwaysUpdatableLogic on Column and Field. (#1408)
* IDEMPIERE-5349: Adding AlwaysUpdatableLogic on Column and Field.

* IDEMPIERE-5349: Making Always Updatable logic to work when isAlwaysUpdatable is false and iAlwaysUpdatable made higher priority

* IDEMPIERE-5349: fixing error SP2-0027 in oracle

* IDEMPIERE-5349 : Fixing AlwaysUpdatableLogic not set when isAlwaysUpdatableLogic is null

* IDEMPIERE-5349 : renaming migration script and updatong AD_Field_V and AD_Field_VT
2022-10-06 13:53:32 +08:00
hengsin 476e9ab71c
IDEMPIERE-5396 Replace CreateFrom form with Info Window Process (#1514)
- Fix Default AD_InfoWindow_ID value of AD_Column
2022-10-05 11:00:42 +02:00
Carlos Ruiz c1a1045d87
IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823) (#1498)
* IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823)

- Add column AD_Client.LoginPrefix

* - Implement logic to manage login prefix
- Add SysConfig keys LOGIN_PREFIX_SEPARATOR and LOGIN_WITH_TENANT_PREFIX

* - Rename methods as suggested by Heng Sin

* IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823)

For security reasons is better to ask for MFA before showing additional information from the user.
Refactoring the panels to show the MFA panel as soon as the tenant is defined.

* - Add uniqueness validations on tenant creation

* - Fix the Forgot My Password functionality

* - Fix the Change Expired Password functionality

* - minor javadoc improvement
- remove a redundant comment, the method is already mark as deprecated

Co-authored-by: hengsin <hengsin@gmail.com>
2022-10-04 11:14:05 +02:00
Nicolas Micoud 98c9dfc844
IDEMPIERE-5434 : Allow to define db view component with DISTINCT (#1505)
https://idempiere.atlassian.net/browse/IDEMPIERE-5434
2022-09-30 13:52:43 +08:00
Diego Ruiz 8a51fb8f4a
IDEMPIERE-2205 - Ask for secret input from within a process (#1501) 2022-09-26 19:46:09 +08:00
Carlos Ruiz aef93fb113
IDEMPIERE-5430 UPDATE generating unnecessary settings for null columns (#1496) 2022-09-23 15:25:51 +08:00
hengsin 536eda3546
IDEMPIERE-5427 Upgrade to Tycho 2.7.5 (#1493)
- restore .classpath to remove Tycho Configurator m2e connector
dependency
2022-09-21 14:21:27 +02:00
Elaine Tan 0b8b7da8e5
IDEMPIERE-5396 Replace CreateFrom form with Info Window Process (#1469)
* IDEMPIERE-5396 Replace CreateFrom form with Info Window Process
2022-09-19 18:30:24 +08:00
Carlos Ruiz 45516c6c91
IDEMPIERE-5425 Chosen Multiple Selection fields are not being copied with the Copy button (#1489) 2022-09-17 11:47:47 +08:00
Carlos Ruiz 1229faab34
IDEMPIERE-2058 Fix problem reading wrong column (#1484) 2022-09-14 10:24:05 +08:00
Carlos Ruiz 52e5e17fed
IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757) (#1483)
* IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757)

* IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757)
2022-09-13 18:57:13 +02:00
Carlos Ruiz 3c69ba56a4
IDEMPIERE-5415 Incomplete process log when output is > 2000 chars (#1476) 2022-09-11 15:22:52 +08:00
Jasper Siepkes 861e3ad01f
IDEMPIERE-5013 Implement HikariCP as a replacement for c3p0 (#926)
* Replaced PostgreSQL and Oracle connection pools with HikariCP.

Replaced C3P0 with HikariCP. HikariCP is a Apache licensed connection pool with substantially better performance and better resilience to failure (DB disconnects, etc.) then C3P0. Read more about it here: https://github.com/brettwooldridge/HikariCP .

Cleaned up the `getCachedConnection` method. With HikariCP there is no need to retry to obtain a connection since getting an connection will block until a free connection is available or until a timeout is reached (default 30 seconds) at which point an `SQLException` is thrown. This also removed calling `Runtime.getRuntime().runFinalization();`. HikariCP is currently configured to detect / log leaks when a connection hasn't returned to the pool for longer then 5 minutes.

Loading of pool config properties was cleaned up. Defaults are now loaded from a single file instead of defaults coming from both file and hardcoded properties. It is now also possible to specify any HikariCP property in the user pool property file.

Initialization of the datasource must happen in the `getDataSource()` method because at object construction not all JDBC config is known. However this method could (as far as I could tell) be called concurrently from multiple threads but had no mechanism to prevent initializing the DB pool multiple times. The variable in which the pool itself was stored (`m_ds`) also was not marked volatile or immutable which could lead to visibility issues. Instead of lazy initialization of the pool in the `getDataSource()` method the pool could probably better be initialized at object construction. However I wasn't able to achieve that without breakage therefor I made the initialization mechanism work correctly with concurrent invocations.

Various config options such as the `MaxStatementsPerConnection` options were removed because HikariCP doesn't support them.

* (Re)added Sequence time-out.
2022-09-10 12:21:57 +02:00
Deepak Pansheriya 8c5c0ecbfa
IDEMPIERE-5326: Parsing error for report view if where clause and vir… (#1385)
* IDEMPIERE-5326: Parsing error for report view if where clause and virtual column used in print format

* IDEMPIERE-5326: Fixing Compilation error

* IDEMPIERE-5326: Adding method back for backward compitability

* IDEMPIERE-5326: Adding constructors  for backward compitability
2022-09-07 21:45:23 +08:00
Peter Takács 1f4a23657a
IDEMPIERE-5400 - Dashboard Goal Content should render as single Gauge Indicator (#1458)
* IDEMPIERE-5400 - Dashboard Goal Content should render as single Gauge Indicator

* IDEMPIERE-5400 - better css responsivity

* IDEMPIERE-5400 - add update goal

* IDEMPIERE-5400 - fixes

* IDEMPIERE-5400 - resolved conflict, migration fix

* IDEMPIERE-5400 - fix bad merge
2022-09-07 21:40:29 +08:00
Peter Takács ee3476c3eb
IDEMPIERE-5409 - Dashboard Content - Maximizable checkbox (#1467)
* IDEMPIERE-5409 - Dashboard Content - Maximizable checkbox

* IDEMPIERE-5409 - IsMaximizable default 'Y'

* IDEMPIERE-5393 - fixes

* IDEMPIERE-5409 - fixed script name
2022-09-07 17:00:18 +08:00
Carlos Ruiz 8748f11ddf
IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757) (#1464) 2022-09-06 13:58:17 +02:00
Carlos Ruiz 0e71fa9884
IDEMPIERE-5407 Heavy query in MRole repeated too often (FHCA-3883) (#1465)
Removed the method MRole.loadTableInfo which loaded the arrays: m_tableAccessLevel, m_tableName, m_viewName, m_tableIdName
and replaced all usage with visits to cached information from tables or columns
2022-09-06 15:01:06 +08:00
Nicolas Micoud 537cb8b9b8
IDEMPIERE-5403 : Misleading error message on TimeUtil.getDay(int, int, int) (#1460)
https://idempiere.atlassian.net/browse/IDEMPIERE-5403
2022-09-05 13:13:36 +02:00
Nicolas Micoud 79d9efb8f5
IDEMPIERE-5395 : Validation Rules at Client level (#1451) 2022-08-30 13:25:01 +02:00
Peter Takács e528c6f8cb
IDEMPIERE-5389 - Dashboard row layout (#1448)
* IDEMPIERE-5389 - Dashboard row layout

* IDEMPIERE-5389 - taking changes related to ticket 5393

* IDEMPIERE-5389 - added Flex Grow to Preference

* IDEMPIERE-5389 - fixing gadget heights

* IDEMPIERE-5389 - center alignment for Status Line

* IDEMPIERE-5389 - fall back to column layout

* IDEMPIERE-5389 - pr1448 patch

* IDEMPIERE-5389 - FixOracleMigration patch
2022-08-30 10:11:42 +02:00
hengsin c45005be41
IDEMPIERE-5376 CConnection and DB clean up (#1457)
* IDEMPIERE-5376 CConnection and DB clean up

* IDEMPIERE-5376 CConnection and DB clean up

- More clean up

* IDEMPIERE-5376 CConnection and DB clean up

- Fix @Deprecated annotation
2022-08-29 21:36:50 +02:00
Nicolas Micoud d0d42ffaf1
IDEMPIERE-5361 : Jasper reports with Charts are not working (#1452)
* IDEMPIERE-5361 : Jasper reports with Charts are not working

* IDEMPIERE-5361 : patch from hengsin
2022-08-26 09:35:54 +08:00
Peter Takács 0aaf904e34
IDEMPIERE-5393 - Allow rendering status line as widget/gadget in dashboard (#1449)
* IDEMPIERE-5393 - Allow rendering status line as widget/gadget in dashboard

* IDEMPIERE-5393 - css class for status line

* IDEMPIERE-5393 - update default theme version
2022-08-24 15:49:06 +08:00
Carlos Ruiz 2dab2d9882
IDEMPIERE-5394 Export to XLSX in Info Windows and Account Viewer (#1450)
* IDEMPIERE-5394 Export to XLSX in Info Windows and Account Viewer
2022-08-24 09:33:12 +08:00
hengsin ce22d1cc51
IDEMPIERE-5391 Unit Test: Fix support for parallel execution of test (#1446) 2022-08-17 18:34:51 +02:00
Carlos Ruiz a558644949
IDEMPIERE-3340 Fix cross tenant in Favourites (#1445) 2022-08-17 18:17:13 +08:00
Peter Takács e670ebbd14
IDEMPIERE-5302 - Drill Assistant Feature with re-generated migration scripts (#1390)
* IDEMPIERE-5302 - Drill Assistant Feature with re-generated migration scripts

* IDEMPIERE-5302 - added IsShowInDrillOptions, ID fixes

* IDEMPIERE-5302 - added IsShowInDrillOptions default Y

* IDEMPIERE-5302 - creating Table Print Formats on Run Report

* IDEMPIERE-5302 - applied pr1390_fixes patch

* IDEMPIERE-5302 - applied pr1390_badimports patch
2022-08-17 18:08:45 +08:00
hengsin 288e96fe8d
IDEMPIERE-5376 CConnection and DB clean up (#1441)
* IDEMPIERE-5376 CConnection and DB clean up

* IDEMPIERE-5376 CConnection and DB clean up

- More clean up
2022-08-13 12:05:52 +02:00
Carlos Ruiz 165229d2db
IDEMPIERE-5380 StackOverflowError when try to login in application with substitute user (FHCA-3828) (#1437) 2022-08-13 10:15:31 +08:00
Carlos Ruiz 5e5c977733
IDEMPIERE-5382 Allow just one MFA registration per mechanism (FHCA-3822) (#1439) 2022-08-12 17:15:28 +08:00
Carlos Ruiz bc9808eb14
IDEMPIERE-5381 System users cannot revoke MFA trusted devices in GardenWorld (FHCA-3824) (#1438) 2022-08-12 17:13:54 +08:00
hengsin 3a2f0ff64d
IDEMPIERE-5376 CConnection and DB clean up (#1432) 2022-08-10 14:52:53 +02:00
Carlos Ruiz 5bd3af0d2f
IDEMPIERE-236 Centralization of hardcoded IDs (#1429)
* IDEMPIERE-236 Centralization of hardcoded IDs

* IDEMPIERE-236 Centralization of hardcoded IDs
2022-08-09 22:12:54 +08:00
Carlos Ruiz 0cb7216599
IDEMPIERE-5375 Read-only windows are not shown in Favourites dashboard (#1430) 2022-08-09 15:09:03 +08:00