Commit Graph

2901 Commits

Author SHA1 Message Date
Carlos Ruiz 9ed69583e8
IDEMPIERE-4297 Improve test data (#444)
* IDEMPIERE-4297 Improve test data

Add new document types in Garden World:
- Warehouse Purchase Order -> creates and matches automatically material receipt
- Point of Purchase Order -> creates and matches automatically material receipt, invoice, it also creates a payment and allocation when payment rule is Cash

* Fix IsDefault=N
2020-12-09 20:48:34 +01:00
Carlos Ruiz 46bc0e022f
IDEMPIERE-4358 Processes to drop some objects from database (#448)
Add process to rename a column directly from the Table and Column window
2020-12-09 15:31:13 +01:00
Carlos Ruiz acf59cccbb
IDEMPIERE-4579 Function altercolumn fails when a role name has a dash (#429) 2020-12-02 15:34:25 +01:00
Carlos Ruiz 460f7116a2
IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong … (#414)
* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance

MAllocationHdr.updateBP was broken, the form Payment Allocation worked just because it was calling bpartner.setTotalOpenBalance() at the end
so, I refactored the MAllocationHdr.updateBP and before/afterDelete to call bpartner.setTotalOpenBalance instead if the broken algorithm

Unit test added for allocating and deleting a customer invoice, a vendor invoice, and a charge

* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance

- Fix peer review changes requested by @hengsin
- Detected double call to bpartner.setTotalOpenBalance in WAllocation
- Detected some business partners in GardenWorld with wrong TotalOpenBalance or SO_CreditUsed, added migration script to fix it, it made more complicate to write unit tests as the data was wrong
2020-11-26 17:08:05 +08:00
Carlos Ruiz 6eeabc49ba
IDEMPIERE-4566 Translation Import/Export - output message is not visible (#408)
- Deprecate zk form WTranslationDialog and controller TranslationController
- Move the logic to a java process org.idempiere.process.TranslationImpExp
- As a process works in mobile, can be called via webservices, tested with fitnesse, etc
- Importing leaves a better and readable log of each file processed
- Importing/Exporting gives feedback to the user about the file being processed

Side note:
- To standardize the menu - renamed the "Initial Client Setup Process" to "Initial Client Setup"

Improvements over the previous form:
- can process the files from the zip in root folder, or in internal folder with the name of the language
- can process a URL http/https to download the zip file
2020-11-26 16:20:17 +08:00
Carlos Ruiz 8576879f1f
IDEMPIERE-4572 NPE - Error posting Asset addition (#404)
IDEMPIERE-4207 Fill Testing Asset Data
IDEMPIERE-4297 Improve test data
2020-11-26 10:11:18 +08:00
Carlos Ruiz 0cc35e16f8
IDEMPIERE-4554 PO is immutable - Workflow editor (#393)
- fix the PO is immutable errors
- forbid that system nodes are changed by non-system users
- system nodes are shown in gray
- reorganize layout of system workflows in editor
- make the nodes smaller
- fix the layout problem of name and properties dialogs
2020-11-26 10:02:48 +08:00
Orlando Curieles ca2570e90e
IDEMPIERE-4569 Migration Script (#401)
* IDEMPIERE-4569 Migration Script

* Update 202011121122_IDEMPIERE-4569.sql

* Update 202011121122_IDEMPIERE-4569.sql

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-11-22 19:54:35 +08:00
Carlos Ruiz 09c5f0ca24
IDEMPIERE-4553 POS menu option throwing error (#394)
Inactivate the menu entry for POS - the swing client must activate it
2020-11-22 09:51:06 +08:00
Carlos Ruiz 837c04f063
IDEMPIERE-4542 Cannot report from window _My Unprocessed Documents_ (#376) 2020-11-13 18:07:07 +08:00
Carlos Ruiz 57fea708aa
IDEMPIERE-3862 ORACLE - Update datatype NCHAR to CHAR (#375) 2020-11-13 17:52:35 +08:00
Carlos Ruiz c58e96ce12
IDEMPIERE-4083 currency rate by document or by transaction (#381)
Fix jenkins build error
SQL> SP2-0027: Input is too long (> 2499 characters) - line ignored
2020-11-13 09:32:12 +01:00
Carlos Ruiz 86823a72e5
IDEMPIERE-4083 currency rate by document or by transaction (#372)
Found issue in _Bank/Cash Statement_ window, button _Create lines from_ is creating all lines (payments and receipts) positive, the correct behavior must be to create the receipts positive and payments negative.
To fix this:
* the function currencyConvertPayment was modified to use C_Payment_V instead of C_Payment
* the columns currencyrate, convertedamt and isoverridecurrencyrate were added to the view C_Payment_V
* the definition of the view C_Payment_V was moved from script to dictionary (easier to add new columns in future)
2020-11-12 09:59:03 +01:00
Carlos Ruiz 0a597943f5
IDEMPIERE-1117 Attachment -> Disable preview over certain size (#366)
* IDEMPIERE-1117 Attachment -> Disable preview over certain size

Add message Preview

* IDEMPIERE-1117 Attachment -> Disable preview over certain size

Move to correct folder
2020-11-10 10:03:16 +08:00
Carlos Ruiz 55023d7f23 IDEMPIERE-4521 Release 8.1 - RC
Create folders for new version
2020-11-03 21:59:12 +01:00
Carlos Ruiz 507f5c5feb IDEMPIERE-4521 Release 8.1 - RC
Migration scripts
2020-11-03 21:59:12 +01:00
Carlos Ruiz cdae126829
IDEMPIERE-4519 Zk: Implement optional defer rendering for Grid View (#352)
Add migration script for the SysConfig key
2020-11-03 15:51:54 +01:00
Carlos Ruiz 88dff840ac
IDEMPIERE-3340 (#351)
* Revert "IDEMPIERE-3340 Fixes for oracle migration scripts (#346)"

This reverts commit db7b9db43c.

* Revert "IDEMPIERE-3340: Tree Structurable User Favorite (#334)"

This reverts commit 01d52fbfef.
2020-11-03 15:40:17 +01:00
Carlos Ruiz f43883f795
IDEMPIERE-4517 Some messages missing - toolbar (#347) 2020-11-02 23:11:08 +08:00
Carlos Ruiz db7b9db43c
IDEMPIERE-3340 Fixes for oracle migration scripts (#346) 2020-11-02 13:17:12 +01:00
Deepak Pansheriya 01d52fbfef
IDEMPIERE-3340: Tree Structurable User Favorite (#334) 2020-11-02 19:28:03 +08:00
Carlos Ruiz c9a766c806
IDEMPIERE-4297 Improve test data (#344)
Fix error reported by @hengsin
Doc_Invoice.getValidCombination_ID: NO account Type=4

Make explicit the deprecation in code and hide the deprecated account fields on IDEMPIERE-362
2020-11-02 10:39:40 +08:00
hengsin e1cf1ada4d
IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on th… (#332)
* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

remove unuse code.

* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

add sysconfig record for ZK_TOOLBAR_SHOW_MORE_VERTICAL
2020-10-29 13:30:00 +01:00
Martin Schönbeck b8225276a2
Idempiere 4452 (#271)
* IDEMPIERE-4452 Allow pricelist schema lines to be dependent of vendor categories and to use entries in m_product_po not marked as current vendor if vendor is selected.

* IDEMPIERE-4452 modified update removed
* don't check for accidently set IsIgnoreIsCurrentVendor where it doesn't change anything.

* IDEMPIERE-4452 set IsIgnoreIsCurrentVendor to false ('N') when no business partner given.
2020-10-28 22:15:01 +08:00
Carlos Ruiz ee1bad9e9d
IDEMPIERE-4511 Drop ampersand & from messages (#330) 2020-10-28 21:30:14 +08:00
hengsin 00e94b12ef
IDEMPIERE-2902 UX: Implement Radio buttons (#326)
* IDEMPIERE-2902 UX: Implement Radio buttons

Integrate contribution from TrekGlobal
TC-188 Port RadioGroup field editor from AP2-19
added "Radio Group List" field type

* IDEMPIERE-2902 UX: Implement Radio buttons

Peer review
* Configure correctly wrong Validation Rule
* Fix wrong DisplayLogic from this ticket and also from other recently added features on fields:
Attribute > Attribute > Reference Key
Attribute > Attribute > Dynamic Validation
Info Window > Column > Reference Key
Info Window > Column > Dynamic Validation
Registration Attributes > Attribute > Reference Key
Table and Column > Column > Dynamic Validation
Table and Column > Column > Dynamic Validation (Lookup)
Table and Column > Column > Reference Key
Web Service Security > Web Service Field Input > Reference Key
Window Customization > Field Customization > Reference Key
Window Customization > Field Customization > Dynamic Validation
Window Customization > Field Customization > Dynamic Validation (Lookup)
Window, Tab & Field > Field > Reference Key
Window, Tab & Field > Field > Dynamic Validation
Window, Tab & Field > Field > Dynamic Validation (Lookup)
* For testing and UX, configure as Radio Group:
Broadcast Message > Broadcast Message > Target
Field Group > Field group > Field Group Type

* IDEMPIERE-2902 UX: Implement Radio buttons

* For testing and UX, configure as Radio Group in detail tab:
Info Window > Process > LayoutType

* IDEMPIERE-2902 UX: Implement Radio buttons

- Fix radio group editor lost track of selectedItem after page detached
and attached
- Standardized the construction of editors from editor factory
- Remove unnecessary refresh for list/lookup based readonly editors
created by grid view (fixed editor is not readonly during init())

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-10-27 19:17:56 +01:00
Diego Ruiz 78393af99d
IDEMPIERE-4510 Add New to the toolbar search query combobox (#325)
* IDEMPIERE-4510 Add New to the toolbar search query combobox

* IDEMPIERE-4510 changed the if for a more defensive programming style

* IDEMPIERE-4510 Change placeholder text to Select Query to improve UX

* IDEMPIERE-4510 Modify migration scripts
2020-10-27 19:07:22 +01:00
Carlos Ruiz fa86359570
IDEMPIERE-2999 Attribute, Table Direct and date field support (#320)
Fix security issue about non advanced roles
2020-10-26 14:18:33 +01:00
Carlos Ruiz 014b45246f
Idempiere 4058 (#312)
* IDEMPIERE-4058 - tab editor: new options for editing and customizing fields (window customization)

* IDEMPIERE-4058 tab editor: new options for editing and customizing fields (window customization)

Fix issues with migration scripts

Co-authored-by: muriloht <muriloht@devcoffee.com.br>
2020-10-21 15:47:56 +02:00
Carlos Ruiz 82a5897bb4
IDEMPIERE-3532 Remove hardcoded values for InfoInvoiceWindow (BPartnerID / IsSOTrx) and InfoPaymentWindow (IsSOTrx) (#309)
Fix log message -> GridField.defaultFromSQLExpression: (IsVendor) - Default SQL variable parse failed
2020-10-21 14:53:37 +02:00
Carlos Ruiz 350e9efe65
IDEMPIERE-4503 Hide non-working things in Window Customization (#310) 2020-10-21 14:49:02 +02:00
Deepak Pansheriya 78f388d450
IDempiere-2999: on Attribute adding all reference type support except… (#287)
* IDempiere-2999: on Attribute adding all reference type support except path, images.

* IDEMPIERE-2999 : Removing isQuickForm reference from migration script and fixing url issue.
2020-10-21 13:58:23 +02:00
Deepak Pansheriya 08f6fb17d3
IDEMPIERE-3981: FindWindow - Overwrite isSelection at field level, Va… (#249)
* IDEMPIERE-3981: FindWindow - Overwrite isSelection at field level, Validation Rule overwrite for Find window, Extended search and advanced hiding options.

* IDEMPIERE-3981: Correcting migration script as per Carlos' code review finding

* IDEMPIERE-3981: Fixing as per code review comment
Co-authored-by: muriloht muriloht@devcoffee.com.br

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-10-21 13:32:25 +02:00
Carlos Ruiz 00153d7c8d
IDEMPIERE-4494 Security - Tenant customization must be advanced (#304) 2020-10-18 11:47:34 +02:00
hengsin 2b9cb9bb2e
IDEMPIERE-4497 Mobile: Update PDF.JS (#306)
* IDEMPIERE-4497 Mobile: Update PDF.JS

* IDEMPIERE-4497 Mobile: Update PDF.JS

archive and simple pdf viewer

* IDEMPIERE-4497 Mobile: Update PDF.JS

change ZK_USE_PDF_JS_VIEWER sysconfig level to Client level (C)
2020-10-17 17:55:11 +02:00
Carlos Ruiz c0867c01ee
IDEMPIERE-4297 Improve test data (#303)
The GardenWorld Admin Not Advanced role was added as advanced by mistake
2020-10-17 07:16:06 +08:00
igorpojzl 3246bb8b1e
IDEMPIERE-4459 Info Window Customization (#259)
* IDEMPIERE-4459 Info Window Customization - Added Java Models

* IDEMPIERE-4459 Update Model AD_UserDef_Info_Column

* IDEMPIERE-4459 Added Migration scripts

* IDEMPIERE-4459 User Definition Info Column Added

Added Business Logic for Info Window Customization for Info Columns. Added InfoColumnVO for storing InfoColumn Data filtered with User Definition.

* IDEMPIERE-4459 Added Migration Scripts to Update Columns

Allow Update AD_Role_ID, AD_Language, AD_User_ID in AD_UserDef_Info table.

* IDEMPIERE-4459 Info Window Customisation - Updated Migration scripts

* IDEMPIERE-4459 Migration Script Fix

* IDEMPIERE-4459 Info Window Customization - Update Java Models

* IDEMPIERE-4459 Apply Migration Patch

* IDEMPIERE-4459 Info Window Customization - Update Models

* IDEMPIERE-4459 Apply Patch 2 fix.

* IDEMPIERE-4459 Info Related Cust. Added, Info Window Cust. Implementation..

* IDEMPIERE-4459 Info Related isDisplay added

* IDEMPIERE-4459 Added Display Logic for Info Related

* IDEMPIERE-4459 Fix SeqNo for InfoColumns

* IDEMPIERE-4459 Fix Patch 3
2020-10-16 11:41:50 +02:00
hengsin 91c72fd978
IDEMPIERE-4482 Mobile Improvements (#297)
* IDEMPIERE-4482 Mobile Improvements

* IDEMPIERE-4482 Mobile Improvements

minor line height fix for process dialog's message area

* IDEMPIERE-4482 Mobile Improvements

- fix issue with grid view column header height
- add customize grid view button to detail pane
- always show message as notifications for mobile
- fix some mobile layout issues
- default desktop font size to 14px
2020-10-14 11:07:18 +02:00
Diego Ruiz edf407614f
IDEMPIERE-4490 Set default Contact/User in SO, Invoice, M_InOut (#289)
* IDEMPIERE-4490 Set default Contact/User in SO, Invoice, M_InOut

* Ran modelgenerator again with the new field = null

* IDEMPIERE 4490 - Update the migration scripts to 7.1 and set Bill_User_ID to null

* IDEMPIERE 4490 - Update the migration scripts to 7.1

* Change field name from Invoice Address to Invoice Contact / Ship Address to Ship Contact

* IDEMPIERE-4490 Add logic to CalloutOrder.bpartnerBill
2020-10-08 12:17:07 +02:00
Carlos Ruiz e3dc0349ad
IDEMPIERE-4297 Improve test data (#282)
* IDEMPIERE-4297 Improve test data

Create a new accounting schema in Euros
Solve problems with documents not posting:
- Fix date for test conversion rates
- Reactivate price list
- Create required purchase order for matching
Create a default query for Unposted window to show Not Drafted documents
Set accounting to immediate (sync seed DBs - postgresql was immediate, oracle was not)
Reset accounting for GardenWorld, delete all facts and reset posted status of all documents
Inactivate cash journals not used anymore

* IDEMPIERE-4297 Improve test data

Leave the user query for unposted window shared - but not default
2020-10-04 17:15:18 +08:00
Carlos Ruiz c837ef28f0
IDEMPIERE-4481 Fix problem with oracle script lines starting with @ (#285) 2020-10-04 14:52:53 +08:00
Carlos Ruiz 0b35edfacf IDEMPIERE-3862 ORACLE - Update datatype NVARCHAR2 to VARCHAR2
Fix view to avoid compilation errors
2020-10-03 20:23:48 +02:00
Carlos Ruiz f106a61be3 IDEMPIERE-4083 currency rate by document or by transaction
Fix wrong pl/sql functions
2020-10-03 20:14:15 +02:00
Ricardo Santana 2199aa078c
IDEMPIERE-1604 - Extend features for Window Customization (#274)
* IDEMPIERE-1604 - Extend features for Window Customization

* change oracle data type

* oracle replace at sign to chr 64

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-09-28 14:53:33 +02:00
Carlos Ruiz 6ff5fed0ec
IDEMPIERE-4474 Automatic calculation of freight charges (#277)
* IDEMPIERE-4474 Automatic calculation of freight charges

* IDEMPIERE-4474 Keep the getShippingProcessor private - avoid NPE in all getters

* IDEMPIERE-4474 Improve error messages and error management
2020-09-28 14:50:58 +02:00
Carlos Ruiz 41513ba3b1
IDEMPIERE-3862 ORACLE - Update datatype NVARCHAR2 to VARCHAR2 (#276)
Minor required change detected testing on a custom database
2020-09-28 12:31:54 +02:00
Deepak Pansheriya 965048d168
IDEMPIERE-2955: Adding Attribute Set Type to use attribute set for di… (#264)
* IDEMPIERE-2955: Adding Attribute Set Type to use attribute set for different purpose

* IDEMPIERE-2955: Fixing migration files swept between Oracle and postgresql folder.

* IDEMPIERE-2955: Fixing oracle migration script having mistakenly deleted comments
2020-09-24 17:17:51 +02:00
Diego Ruiz 02a450a660
IDEMPIERE-4084 - Reposition default toolbar buttons (#272) 2020-09-22 16:48:53 +02:00
muriloht d875208a00
IDEMPIERE-3336 - Tables missing EntityType column (#258)
* IDEMPIERE-3336 - Tables missing EntityType column

* IDEMPIERE-3336 - fix PR review comments

* IDEMPIERE-3336 - fix PR review default value for entityType
2020-09-21 10:25:23 +02:00
Deepak Pansheriya e72dfd66c0
IDEMPIERE-4067 : Support for Under/Over line and Blank line in finaci… (#244)
* IDEMPIERE-4067 : Support for Under/Over line and Blank line in finacial report line.

* IDEMPIERE-4067 : Adding support for blank line export in CSV, HTML, Excel. Also allowing to show description if provided. fixed all review comments fron Carlos Ruiz
2020-09-08 12:59:19 +02:00