Commit Graph

13644 Commits

Author SHA1 Message Date
Carlos Ruiz 46bc0e022f
IDEMPIERE-4358 Processes to drop some objects from database (#448)
Add process to rename a column directly from the Table and Column window
2020-12-09 15:31:13 +01:00
Carlos Ruiz 4c66c0018d
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#443)
Implement thread safe mechanism
https://mattermost.idempiere.org/idempiere/pl/hmpd8freutbhbgcjr9tu6ntitr
2020-12-09 14:28:49 +01:00
Carlos Ruiz d7bac68f94
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#442)
Problem when creating a preference with SuperUser in System, and then trying to save the same preference in GardenWorld (for example changing the height of a window)
2020-12-07 23:00:14 +08:00
Carlos Ruiz 416d92a292
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#441)
Fix problem reported by ken.wang at
https://mattermost.idempiere.org/idempiere/pl/3wmpzg1o5i88dec5pifkjd3qfe
2020-12-07 22:59:23 +08:00
hieplq 58c6716253
IDEMPIERE-4360 exclude generate and test code to speed up (#440)
* IDEMPIERE-4360 add sonarcloud.io

* IDEMPIERE-4360 add sonarcloud.io (update properties)

* IDEMPIERE-4360 add sonarcloud.io (optimize)

1. when use matrix for codeql-action then job of javascript run same job of java (mvn, sonar)
so don't use matrix do define separate job let javascript job faster a lot
2. reduce maven log and sonar log from info to warn
3. move project info from pom to yml let fork central place customize CI

* IDEMPIERE-4360 turn off sonar at PR because not yet support

https://stackoverflow.com/a/39720346

* IDEMPIERE-4360 exclude generate and test code to speed up

* IDEMPIERE-4360 add sonarcloud.io (optimize)

1. parallel sonar and code QL
2. parameter for repository owner (org)
2020-12-06 16:50:14 +01:00
hengsin 9d02ecaadb
IDEMPIERE-4387 Cannot select C&W Business Partner in Multi Select Search (#438)
- base on patch from Carlos and hints from hieplq
2020-12-05 16:38:36 +01:00
hieplq fb053003a9
IDEMPIERE-4360 turn off sonar at PR because not yet support (#439)
* IDEMPIERE-4360 add sonarcloud.io

* IDEMPIERE-4360 add sonarcloud.io (update properties)

* IDEMPIERE-4360 add sonarcloud.io (optimize)

1. when use matrix for codeql-action then job of javascript run same job of java (mvn, sonar)
so don't use matrix do define separate job let javascript job faster a lot
2. reduce maven log and sonar log from info to warn
3. move project info from pom to yml let fork central place customize CI

* IDEMPIERE-4360 turn off sonar at PR because not yet support

https://stackoverflow.com/a/39720346
2020-12-05 16:33:26 +01:00
Carlos Ruiz 02ce1f3c1f
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#436)
Two more points found about cross tenant readin in MClient and MUser
2020-12-05 12:42:43 +08:00
hengsin 894ceb8c4f
IDEMPIERE-4101 [Chosenbox] Multi select don't work in Firefox (#435)
- add display of button
- fix dropdown doesn't render properly at Firefox
2020-12-04 17:52:10 +01:00
Carlos Ruiz b9964ce7ab
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#432)
Fixes:
org.adempiere.exceptions.AdempiereException: Cross tenant PO reading request detected from session 1009629 for table AD_UserDef_Win Record_ID=1000002
	at org.compiere.model.PO.checkValidClient(PO.java:5000)
	at org.compiere.model.PO.<init>(PO.java:212)
	at org.adempiere.model.GenericPO.<init>(GenericPO.java:81)
	at org.compiere.model.MTable.getPO(MTable.java:598)
	at org.compiere.model.Query.list(Query.java:286)
	at org.compiere.model.MUserDefWin.getAll(MUserDefWin.java:107)
	at org.compiere.model.MUserDefWin.getBestMatch(MUserDefWin.java:160)
2020-12-03 12:55:15 +01:00
hengsin c3aafb2a4f
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#431)
- Fix broken menu icon for html report
- Fix an issue with switching theme
2020-12-03 11:58:45 +01:00
Carlos Ruiz a833e778a6
IDEMPIERE-4468 Pass the current value of numberbox to the textfield of calculator (#430)
IDEMPIERE-2003 Capturing wrong numbers with numeric keypad when decimal separator is not dot

- Restore and improve functionality that process dot keypad within the number fields (deleted by mistake in c954a055b2)
2020-12-02 22:16:31 +01:00
Deepak Pansheriya 8b672a3a51
IDEMPIERE-2999 : refactoring as per Hengsin's review comments (#427)
* IDEMPIERE-2999 : refactoring as per Hengsin's review comments

* IDEMPIERE-2999: Fixing compilation issue

* IDEMPIERE-2999: Fixing as per Hengsin'e review
2020-12-02 22:59:23 +08:00
Carlos Ruiz acf59cccbb
IDEMPIERE-4579 Function altercolumn fails when a role name has a dash (#429) 2020-12-02 15:34:25 +01:00
Carlos Ruiz bf65636e22
IDEMPIERE-4577 Problem creating an invoice vendor negative after the … (#428)
* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment

* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment

Add unit test
2020-12-02 21:08:41 +08:00
hieplq 87e55ae08f
IDEMPIERE-4360 add sonarcloud.io (optimize) (#426)
* IDEMPIERE-4360 add sonarcloud.io

* IDEMPIERE-4360 add sonarcloud.io (update properties)

* IDEMPIERE-4360 add sonarcloud.io (optimize)

1. when use matrix for codeql-action then job of javascript run same job of java (mvn, sonar)
so don't use matrix do define separate job let javascript job faster a lot
2. reduce maven log and sonar log from info to warn
3. move project info from pom to yml let fork central place customize CI
2020-12-01 10:38:48 +01:00
Carlos Ruiz 8cf16ba137
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#425)
Implement cross tenant check on foreign keys for insert and update
2020-12-01 07:16:22 +08:00
Carlos Ruiz 42854cfb0f
IDEMPIERE-4561 Font Icons not used in several points (#423) 2020-12-01 07:12:28 +08:00
Carlos Ruiz 3a9b932df4
IDEMPIERE-4268 Fix recursive call to PO (#424)
* IDEMPIERE-4268 Fix recursive call to PO

Found a case where PO.checkValidClient fails, and then because of log.severe it tries to create a record with MIssue, and the PO.checkValidClient fails in MIssue, and is called recursively until it fails with a "Trx.run: Transaction timeout."

* IDEMPIERE-4268

- Improve error message
- Fix problem with valid cross-tenant reads in MRegion and MWorkflow
2020-11-30 21:36:51 +01:00
hengsin 5d236de30c
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#420)
* IDEMPIERE-4421 Html asset versioning should allow fluent deployment

use classpath loading and lang-addon versioning for theme resources

* IDEMPIERE-4421 Html asset versioning should allow fluent deployment

Incorporate backward compatibility patch from Carlos.
2020-11-30 15:33:23 +01:00
hieplq 60e584655c
Idempiere 4360 (#422)
* IDEMPIERE-4360 add sonarcloud.io

* IDEMPIERE-4360 add sonarcloud.io (update properties)
2020-11-30 19:19:49 +07:00
hieplq 5f30b001e0
IDEMPIERE-4360 add sonarcloud.io (#421) 2020-11-30 09:37:49 +07:00
Carlos Ruiz 0eb4986513
IDEMPIERE-4575 Cannot complete Material Receipt from negative PO (#419) 2020-11-28 07:09:39 +08:00
Carlos Ruiz 71a2ee3fe7
IDEMPIERE-4268 Fix issue with change client (#418)
Fix problem changing client in role panel when more than 2 clients
2020-11-27 20:24:21 +01:00
Diego Ruiz 386610f379
IDEMPIERE-4394 Date Field font color is not consistent with other readonly fields (#417) 2020-11-27 18:51:30 +01:00
hengsin 0d381faf99
IDEMPIERE-4187 implement the usage of workflows in processes (#416)
- incorporate suggestion from Martin Schönbeck to unit test
2020-11-26 14:17:40 +01:00
Carlos Ruiz d885aaf4e6
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#415)
Co-authored-by: Heng Sin Low <hlow@trekglobal.com>
2020-11-26 20:22:18 +08:00
Carlos Ruiz 460f7116a2
IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong … (#414)
* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance

MAllocationHdr.updateBP was broken, the form Payment Allocation worked just because it was calling bpartner.setTotalOpenBalance() at the end
so, I refactored the MAllocationHdr.updateBP and before/afterDelete to call bpartner.setTotalOpenBalance instead if the broken algorithm

Unit test added for allocating and deleting a customer invoice, a vendor invoice, and a charge

* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance

- Fix peer review changes requested by @hengsin
- Detected double call to bpartner.setTotalOpenBalance in WAllocation
- Detected some business partners in GardenWorld with wrong TotalOpenBalance or SO_CreditUsed, added migration script to fix it, it made more complicate to write unit tests as the data was wrong
2020-11-26 17:08:05 +08:00
Carlos Ruiz 6eeabc49ba
IDEMPIERE-4566 Translation Import/Export - output message is not visible (#408)
- Deprecate zk form WTranslationDialog and controller TranslationController
- Move the logic to a java process org.idempiere.process.TranslationImpExp
- As a process works in mobile, can be called via webservices, tested with fitnesse, etc
- Importing leaves a better and readable log of each file processed
- Importing/Exporting gives feedback to the user about the file being processed

Side note:
- To standardize the menu - renamed the "Initial Client Setup Process" to "Initial Client Setup"

Improvements over the previous form:
- can process the files from the zip in root folder, or in internal folder with the name of the language
- can process a URL http/https to download the zip file
2020-11-26 16:20:17 +08:00
Carlos Ruiz 363f21993f
IDEMPIERE-4285 Cannot send mail while creating RfQ Response (#413)
Co-authored-by: Ray Lee <ray@iroses.tw>
2020-11-26 12:55:10 +08:00
Carlos Ruiz 9c92286861
IDEMPIERE-1710 Receipt create lines from not update when change locator or purchase order, invoice (#412) 2020-11-26 12:53:25 +08:00
Carlos Ruiz 333d35a504
IDEMPIERE-4417 Cancel ASI selection not closing properly (#411)
Co-authored-by: Alan Lescano <alan.lesc1@gmail.com>
2020-11-26 12:41:49 +08:00
Carlos Ruiz 8576879f1f
IDEMPIERE-4572 NPE - Error posting Asset addition (#404)
IDEMPIERE-4207 Fill Testing Asset Data
IDEMPIERE-4297 Improve test data
2020-11-26 10:11:18 +08:00
Carlos Ruiz 56237276ad
IDEMPIERE-4557 Order document by DateTrx and Created on Auto Allocation process (#395)
- change the order by for payments from "DateTrx" to "DateTrx, Created, C_Payment_ID"
- change the order by for invoices from "DateInvoiced" to "DateInvoiced, Created, C_Invoice_ID"
- refactor four JDBC managed queries to use the Query function
2020-11-26 10:10:31 +08:00
Carlos Ruiz 0cc35e16f8
IDEMPIERE-4554 PO is immutable - Workflow editor (#393)
- fix the PO is immutable errors
- forbid that system nodes are changed by non-system users
- system nodes are shown in gray
- reorganize layout of system workflows in editor
- make the nodes smaller
- fix the layout problem of name and properties dialogs
2020-11-26 10:02:48 +08:00
Carlos Ruiz 808773aa9f
IDEMPIERE-4528 Update Js Library (#410)
Restore sendDeferLayoutEvent - deprecated, to avoid breaking some plugins out there
2020-11-25 12:18:17 +01:00
Carlos Ruiz 2735131285
IDEMPIERE-4520 Attribute Instance not Refreshed on Create only on Update (#409) 2020-11-25 10:59:32 +01:00
hengsin 72f991d7a6
IDEMPIERE 4528 Implement namespace and versioning for JS library (#405)
* IDEMPIERE-4528 Update Js Library

Update html2canvas to 1.0.0.rc7

* IDEMPIERE-4528 Update Js Library

Use namespace/package and versioning for all js codes.
2020-11-24 12:35:24 +01:00
hieplq 1558d4d6dc
IDEMPIERE-4537 java.lang.NoClassDefFoundError: org/apache/commons/math3/util/ArithmeticUtils - xls reporting (#406) 2020-11-24 11:58:57 +01:00
Orlando Curieles ca2570e90e
IDEMPIERE-4569 Migration Script (#401)
* IDEMPIERE-4569 Migration Script

* Update 202011121122_IDEMPIERE-4569.sql

* Update 202011121122_IDEMPIERE-4569.sql

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-11-22 19:54:35 +08:00
Carlos Ruiz 09c5f0ca24
IDEMPIERE-4553 POS menu option throwing error (#394)
Inactivate the menu entry for POS - the swing client must activate it
2020-11-22 09:51:06 +08:00
Orlando Curieles b05b26d9f1
IDEMPIERE-4572 Fix NPE (#402) 2020-11-22 09:49:29 +08:00
Carlos Ruiz 7a957d8148
IDEMPIERE-4556 Cannot synchronize columns with a Payment Reference (#398) 2020-11-21 14:36:19 +08:00
Carlos Ruiz 71049fa02b
IDEMPIERE-4465 Native Postgres - Error on Convert Layer (#400)
* IDEMPIERE-4465 Native Postgres - Error on Convert Layer

* IDEMPIERE-4465 Native Postgres - Error on Convert Layer
2020-11-21 14:28:35 +08:00
Carlos Ruiz b778904d42
IDEMPIERE-4558 Copy GardenWorld into a new Client using Copy Client - failing in postgresql native (#399)
Fix the problem in postgresql native
2020-11-21 14:21:45 +08:00
Carlos Ruiz d44fde9e08
IDEMPIERE-3566 shortcut key for process gear (alt + o) don't effect (#396) 2020-11-21 14:20:42 +08:00
AndreaCh83 530d5e7b9a
IDEMPIERE-4555 Incorrect price in intercompany document (#389)
* IDEMPIERE-4555 Incorrect price in intercompany document

* Update MOrder.java

* Update MOrder.java
2020-11-21 07:55:02 +08:00
Carlos Ruiz 611e1bbb8f
IDEMPIERE-4560 Autocomplete fills the value to be suggested to the user with the cache and does not support multilanguage (#397)
Fixes the problem about caching results from previously used language, breaking the usage of base language when another language was used previously
2020-11-21 07:49:57 +08:00
Carlos Ruiz 62bf1359ca
Update FUNDING.yml (#392)
* Update FUNDING.yml

* Update FUNDING.yml

* Update FUNDING.yml
2020-11-20 16:32:10 +01:00
Diego Ruiz 58e83d9faa
IDEMPIERE-4559 Customize and Process detail toolbar buttons are not clickable after creating a new record in the header (#390) 2020-11-19 13:41:36 +08:00