Commit Graph

3687 Commits

Author SHA1 Message Date
Carlos Ruiz 4af5caf944 IDEMPIERE-6040 Improvements for CSV import template (#2292)
- improve beforeSave validation of CSVHeader using SuperCSV library
- add validation for the CSVAliasHeader
2024-04-05 11:38:27 +02:00
hengsin 29b36f84e2 IDEMPIERE-6081 Import Csv by Template: Allow import from a detail tab into different parents (#2289) 2024-04-05 11:38:27 +02:00
Carlos Ruiz 5d04cc7728 IDEMPIERE-6064 Error when creating a table with a long name through CreateTable process (#2290)
* IDEMPIERE-6064: Error when creating a table with a long time through CreateTable process

* IDEMPIERE-6064: Error when creating a table with a long name through CreateTable process

* - set the length of tablename to 60 char, and other database object names to 63

* - minor javadoc clarification

* - Increase size of other columns and process parameters

* - fix wrong value for Old MAX_OBJECT_NAME_LENGTH

---------

Co-authored-by: Nicolas Micoud <58596990+nmicoud@users.noreply.github.com>
2024-04-05 11:38:27 +02:00
Carlos Ruiz d16538ae38 IDEMPIERE-6040 Improvements for CSV import template (#2279)
* IDEMPIERE-6040 Improvements for CSV import template

- Delimiter (Field Separator) configurable
- Quote delimiter configurable
- Fix issue when the UTF-8 file comes with BOM character

* - add support for preprocessing excel files

* - convert Excel to CSV in a proper format according to the column types
2024-04-05 11:37:28 +02:00
hengsin af10c3a674 IDEMPIERE-5847 Wrong Posting in Shipment (#2280)
* IDEMPIERE-5847 Wrong Posting in Shipment

* IDEMPIERE-5847 Wrong Posting in Shipment

- minor unit test refinement

* IDEMPIERE-5847 Wrong Posting in Shipment

- Fix intermittent unit test error
2024-04-05 11:37:28 +02:00
Nicolas Micoud 0ffcc794b3 IDEMPIERE-6077: Translation of QueryMoreThanOneRecordsFound (#2282)
https://idempiere.atlassian.net/browse/IDEMPIERE-6077
2024-04-05 11:37:28 +02:00
Carlos Ruiz 53e9c7161b IDEMPIERE-6068 Add C_UOM.UNCEFACT column (#2275) 2024-03-22 13:55:40 +01:00
hengsin 2f0baacfa0 IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs (#2273)
* IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs
* IDEMPIERE-5503 Product Costs > Cost Movement > Field AMOUNT has inconsistent +/- signs
- use safer approach
2024-03-22 13:55:40 +01:00
Carlos Ruiz 96898995ec IDEMPIERE-5578 Data corruption when copying order lines from a closed order (#2269)
- fix new problem reported by Martin Schönbeck
- fix issue found when rounding the unit price of UOM articles
2024-03-22 13:55:40 +01:00
Carlos Ruiz af00731696 IDEMPIERE-6046 Updates on C_Order via REST or webservices is leaving corrupted data (#2262)
* IDEMPIERE-6046 Updates on C_Order via REST or webservices is leaving corrupted data

* - improve performance
2024-03-15 17:38:44 +01:00
hengsin b8947f1f06 IDEMPIERE-6043 Upgrade Jasper Report to version 6.21.0 (#2245) 2024-03-04 21:24:04 +01:00
hengsin 2d18c90738 IDEMPIERE-5949 Datatables.js and Pivot.js Report Viewer (#2221)
- Fix NPE
2024-03-04 21:24:04 +01:00
hengsin 33c8210618 IDEMPIERE-5949 Datatables.js and Pivot.js Report Viewer (#2211)
* IDEMPIERE-5949 Datatables.js and Pivot.js Report Viewer

* IDEMPIERE-5949 Datatables.js and Pivot.js Report Viewer

* IDEMPIERE-5949 Datatables.js and Pivot.js Report Viewer

- fix launch configuration
2024-03-04 21:24:04 +01:00
Carlos Ruiz 7b210dbfbb IDEMPIERE-6062 Wrong query when importing translations / IDEMPIERE-5567 (#2259) 2024-03-04 21:21:38 +01:00
Carlos Ruiz 69121c5794 IDEMPIERE-6061 Performance - MPrintFormatItem loading MPrintFormat on constructor (#2258) 2024-03-04 21:21:38 +01:00
Carlos Ruiz 7ff0f2f2b9 IDEMPIERE-6052 Print Format: Format Pattern is not Applied on Grouping/Summary SCRIPT rows (#2252) 2024-03-04 21:21:38 +01:00
hieplq 4f3c18730d IDEMPIERE-4677: get client id from MRole instead of from context (#2250)
Calling Env.getAD_Client_ID(getCtx()) within the loadOrgAccessUser function can cause issues if the context is not yet logged in. To avoid this, it's recommended to use getAD_Client_ID() directly instead.
2024-03-04 21:21:38 +01:00
Carlos Ruiz 0a779db755 IDEMPIERE-5790 Improve Report Refresh functionality (#2246) 2024-03-04 21:19:09 +01:00
Carlos Ruiz b9736de0eb IDEMPIERE-4819 Private Lock - Allow Unlock other users Private Records (#2202)
* IDEMPIERE-4819 Private Lock - Allow Unlock other users Private Records

* - move scripts to r11
2024-03-04 21:19:09 +01:00
Carlos Ruiz fa09eb5187 IDEMPIERE-6013 Implement a way to filter dinamically records on MRole.addAccessSQL (#2209)
* IDEMPIERE-6013 Implement a way to filter dinamically records on MRole.addAccessSQL

* - do not create sequence

* - move scripts to r11
2024-03-04 21:19:09 +01:00
Nicolas Micoud 7f951ccd70 IDEMPIERE-5795: DeveloperMode context variable - System Property (#2243)
* IDEMPIERE-5795: DeveloperMode context variable - System Property

https://idempiere.atlassian.net/browse/IDEMPIERE-5795

* IDEMPIERE-5795: DeveloperMode context variable - System Property - simplify

Suggested by @hengsin

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2024-03-04 21:17:31 +01:00
Carlos Ruiz 16074d80ee IDEMPIERE-6039 MBPartnerLocation returning Location wrongly from cache when asked to requery (#2240) 2024-03-04 21:17:31 +01:00
Carlos Ruiz 26bdfc276f IDEMPIERE-6036 Apply same approach to MLotCtl (#2237) 2024-03-04 21:17:30 +01:00
hengsin 6302f6f5fd IDEMPIERE-6029 Extract @SQL= and @SQLFIND= to constant (#2230) 2024-03-04 21:17:30 +01:00
hengsin 7224009efc IDEMPIERE-6032 MPInstanceLog ResultSet constructor not getting all value from result set (#2233) 2024-03-04 21:17:30 +01:00
hengsin c2111b9ccd IDEMPIERE-6036 Serial number control has potential to generate duplicate serial number under heavy load (#2236) 2024-03-04 21:17:30 +01:00
hengsin 9eb83bfe31 IDEMPIERE-6034 MTaxCategory.getDefaultTax unnecessary create new MTax instance (#2234) 2024-03-04 21:17:30 +01:00
hengsin 91d757cf81 IDEMPIERE-6030 Potential infinite loop in MLocation.equals (Object) method (#2231) 2024-03-04 21:17:30 +01:00
hengsin 284b6f97f6 IDEMPIERE-6031 Redundant code in MSetup.createClient method (#2232) 2024-03-04 21:17:30 +01:00
hengsin 61e3e48c9a IDEMPIERE-6035 Use saveCrossTenantSafe instead of PO.setCrossTenantSafe (#2235) 2024-03-04 21:17:03 +01:00
hieplq 815e363882 IDEMPIERE-6016:test case to simulate transaction timeouts and ensure no open connections remain afterwards (#2219)
* IDEMPIERE-6016:allow transaction monitor's scan timeout to a short duration

* IDEMPIERE-6016:test case to simulate transaction timeouts and ensure no open connections remain afterwards

* IDEMPIERE-6016:trx timeout make leak connection by call Connection.about but not call Connection.close(Hengsin review)

replace abort with rollback
use shorter duration for timeout test 2
add Isolatead and same thread execution class annotation

* IDEMPIERE-6016:trx timeout make leak connection by call Connection.about but not call Connection.close(Hengsin review)

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2024-03-04 21:13:19 +01:00
hieplq b9fbd91571 IDEMPIERE-6016:trx timeout make leak connection by call Connection.about but not call Connection.close (#2210) 2024-03-04 21:13:19 +01:00
Carlos Ruiz 087b936e2b IDEMPIERE-3117 Wrong period validation on Bank Statement (#2225)
* IDEMPIERE-3117 Wrong period validation on Bank Statement - change statementDate to dateAcct on testPeriod

* - peer review

---------

Co-authored-by: zuhriutama <zuhriutama@gmail.com>
2024-02-06 10:11:10 +01:00
Peter Takács e5eebba4a6 IDEMPIERE-5992 - Move the getIdentifier methods from WRecordEditor to MLookup class (#2183)
* IDEMPIERE-5992 - Move the getIdentifier methods from WRecordEditor to MLookup class

* IDEMPIERE-5992 - refactor logic

* IDEMPIERE-5992 - replace keyColumn parameter with useUUIDKey
2024-02-06 10:11:10 +01:00
Carlos Ruiz 8422123487 IDEMPIERE-6017 Fix NPE in MoveClient when a column does not exist (#2218) 2024-02-06 10:11:10 +01:00
Carlos Ruiz 22e22fa976 IDEMPIERE-6017 Move/Copy Client failing when there are Record_ID references for AD_ClientInfo or AD_OrgInfo (#2214)
- improve discovery of key column
- improve avoiding block when the target column is bigger and can hold the source column
2024-02-06 10:11:10 +01:00
Carlos Ruiz 1ec37be854 IDEMPIERE-6015 Allow usage of _ID or _UU columns in print format item scripts (#2208) 2024-02-06 10:11:10 +01:00
Carlos Ruiz 2b785e3900 IDEMPIERE-5567 Insert Log not being created - fix wrong parenthesis (#2212) 2024-02-06 10:11:10 +01:00
Carlos Ruiz b5efecc282 IDEMPIERE-5567 Trl Export for table TestUU_Trl (#2207)
- fix throwing TestUU_Trl org.postgresql.util.PSQLException: ERROR: operator does not exist: character varying <= integer Hint: No operator matches the given name and argument types. You might need to add explicit type casts. Position: 268
- change the process to explicitly break when a DB exception happens
2024-02-06 10:11:10 +01:00
Carlos Ruiz fceb0614a5 IDEMPIERE-5996 Record Access is not being updated when a new record is added (#2194)
* IDEMPIERE-5996 Record Access is not being updated when a new record is added

* - correct CacheMgt.getElementCount

* - revert correction of CacheMgt.getElementCount

* - reset changes on MRole

* - implemnt suggestion from Heng Sin about validation of cache size

* - simpler approach, make the default role a cache instead of context

* - remove unnecessary code

* - implement suggestion from Heng Sin - keep instance of validation

* - revert changes on MRole to try a different approach

* - Implement approach suggested by Heng Sin - reset default role when is not in cache
2024-01-23 15:43:48 +01:00
Carlos Ruiz e33cadc2f9 IDEMPIERE-6002 Recent Items not working when UUID field is inactive (#2198)
* IDEMPIERE-6002 Recent Items not working when UUID field is inactive

* - add missing fields in core windows:
Product > BOM
Product > Components
Remuneration > Remuneration
Remuneration > Position Remuneration
Remuneration > Employee Remuneration
Revenue Recognition > Revenue Recognition
Revenue Recognition > Service
Revenue Recognition > Revenue Recognition Plan
Revenue Recognition > Revenue Recognition Run
Validation Rules > Used in Column (Lookup)

* - sync postgresql and oracle scripts
2024-01-23 15:43:48 +01:00
Carlos Ruiz bf89e009ab IDEMPIERE-6000 Reset AD_SysConfig cache automatically when configured (#2196)
* IDEMPIERE-6000 Reset AD_SysConfig cache automatically when configured

* - better comment
2024-01-23 15:43:48 +01:00
luzpaz a87de727af IDEMPIERE-5838 Fix various typos (#2188)
* Fix various typos
Fixes user-facing and non-user-facing typos. Found via `codespell -q 3 -S "*.map,./migration,./migration-historic"`
* Added requested revisions
* Added requested revision
* Added requested revisions
2024-01-23 15:43:48 +01:00
Carlos Ruiz 17b012c376 IDEMPIERE-5567 - Parallel unit tests fail frequently with deadlock (#2190)
* IDEMPIERE-5567 - Parallel unit tests fail frequently with deadlock

when executing unit tests in parallel, MTestUUTest fails frequently with error detected deadlock
this can be caused by testReadingUpdatingTestUU trying to update translations and at the same time
the testDeletingTestUU is deleting the same record and deleting the same translations

* - implement suggestion from Heng Sin

* - remove unnecessary code
2024-01-23 15:43:48 +01:00
Carlos Ruiz c9235a02b4 IDEMPIERE-5994 Connection leak when using DB.prepareStatement(badSql, null) (#2184)
* IDEMPIERE-5994 Connection leak when using DB.prepareStatement(badSql, null)

* - implement approach suggested by Heng Sin
2024-01-23 15:43:48 +01:00
Carlos Ruiz 0b5c7e2256 IDEMPIERE-5989 Attachments are not accessible after upgrade from Idempiere 10 to Idempiere 11 (#2185)
* IDEMPIERE-5989 Attachments are not accessible after upgrade from Idempiere 10 to Idempiere 11

IDEMPIERE-5567
Fix issue when the window doesn't have the UUID field

* - change for a more robust method (similar approach to other points)
2024-01-23 15:43:48 +01:00
Diego Ruiz 735a735fbb IDEMPIERE-5996 - Added the functionality of resetting cache after cre… (#2186)
* IDEMPIERE-5996 - Added the functionality of resetting cache after creating a record access restriction

* Update MRecordAccess.java

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2024-01-23 15:43:48 +01:00
hengsin b912996243 IDEMPIERE-5838 Base: Improve readability of code (#2179)
* IDEMPIERE-5838 Base: Improve readability of code

* IDEMPIERE-5838 Base: Improve readability of code
2024-01-23 15:43:47 +01:00
Carlos Ruiz 578e942f20 Revert "IDEMPIERE-4877 - Fix Footer is overlay on content (#2053)"
This reverts commit b8f1d6d2fb.
2024-01-23 15:33:22 +01:00
Carlos Ruiz da16af2a46 IDEMPIERE-5981 Misleading error when completing an auto-produce shipment (#2177)
* IDEMPIERE-5981 Misleading error when completing an auto-produce shipment

* - more robust fix
2024-01-23 15:33:22 +01:00