midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

IDEMPIERE-6046 Updates on C_Order via REST or webservices is leaving corrupted data (#2262) 

* IDEMPIERE-6046 Updates on C_Order via REST or webservices is leaving corrupted data

* - improve performance
This commit is contained in:
Carlos Ruiz 2024-03-08 10:51:14 +01:00
parent 55b63fd57e
commit af00731696
1 changed files with 34 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
org.adempiere.base/src/org/compiere/model/MOrder.java
View File

@ -1262,12 +1262,44 @@ public class MOrder extends X_C_Order implements DocAction
return false;
}
}
// IDEMPIERE-6046 - verify if the locations pertain to the BP
final String sqlBPIdFromLoc = "SELECT C_BPartner_ID FROM C_BPartner_Location WHERE C_BPartner_Location_ID=?";
final String sqlBPIdFromUser = "SELECT C_BPartner_ID FROM AD_User WHERE AD_User_ID=?";
if (is_new() || is_ValueChanged(COLUMNNAME_C_BPartner_ID)) {
if (getC_BPartner_Location_ID() > 0) {
int bpId = DB.getSQLValueEx(get_TrxName(), sqlBPIdFromLoc, getC_BPartner_Location_ID());
if (bpId != getC_BPartner_ID()) {
set_ValueNoCheck(COLUMNNAME_C_BPartner_Location_ID, null);
}
}
if (getAD_User_ID() > 0) {
int bpId = DB.getSQLValueEx(get_TrxName(), sqlBPIdFromUser, getAD_User_ID());
if (bpId != getC_BPartner_ID()) {
set_Value(COLUMNNAME_AD_User_ID, null);
}
}
}
if (is_new() || is_ValueChanged(COLUMNNAME_Bill_BPartner_ID)) {
if (getBill_Location_ID() > 0) {
int bpId = DB.getSQLValueEx(get_TrxName(), sqlBPIdFromLoc, getBill_Location_ID());
if (bpId != getBill_BPartner_ID()) {
set_Value(COLUMNNAME_Bill_Location_ID, null);
}
}
if (getBill_User_ID() > 0) {
int bpId = DB.getSQLValueEx(get_TrxName(), sqlBPIdFromUser, getBill_User_ID());
if (bpId != getBill_BPartner_ID()) {
setBill_User_ID(-1);
}
}
}
// No Partner Info - set Template
if (getC_BPartner_ID() == 0)
setBPartner(MBPartner.getTemplate(getCtx(), getAD_Client_ID()));
if (getC_BPartner_Location_ID() == 0)
setBPartner(new MBPartner(getCtx(), getC_BPartner_ID(), null));
setBPartner(new MBPartner(getCtx(), getC_BPartner_ID(), get_TrxName()));
// No Bill - get from Ship
if (getBill_BPartner_ID() == 0)
{