* IDEMPIERE-4581 Model generator should isn't dialog it should be window
use shutdown asyn to shutdown framework when close Model generator window
one unhappy thing remain:
when use -console then framework is shutdown but jdk still hang because "pipe-gosh --login --noshutdown" still live (for https://bugs.eclipse.org/bugs/show_bug.cgi?id=362412)
work-around: use -console 1234
by that way we can't access osgi command from console but can use "telnet localhost 1234" to use osgi command
* IDEMPIERE-4581 Model generator should isn't dialog it should be window
Fix problem about program not closing
Improve layout
Co-authored-by: hieplq <hieplq@hasuvimex.vn>
* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction
WIP - commit failing unit test
* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction
Implement solution suggested by @hengsin
* minor fix comment
* IDEMPIERE-4584 : InfoProduct throws "Attempted to access nonexistent ListModelTable field at 2, -1" if no IsInstanceAttribute column
* IDEMPIERE-4584 : fix test of column index
Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>
Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
* IDEMPIERE-4297 Improve test data
Add new document types in Garden World:
- Warehouse Purchase Order -> creates and matches automatically material receipt
- Point of Purchase Order -> creates and matches automatically material receipt, invoice, it also creates a payment and allocation when payment rule is Cash
* Fix IsDefault=N
Problem when creating a preference with SuperUser in System, and then trying to save the same preference in GardenWorld (for example changing the height of a window)
* IDEMPIERE-4360 add sonarcloud.io
* IDEMPIERE-4360 add sonarcloud.io (update properties)
* IDEMPIERE-4360 add sonarcloud.io (optimize)
1. when use matrix for codeql-action then job of javascript run same job of java (mvn, sonar)
so don't use matrix do define separate job let javascript job faster a lot
2. reduce maven log and sonar log from info to warn
3. move project info from pom to yml let fork central place customize CI
* IDEMPIERE-4360 turn off sonar at PR because not yet support
https://stackoverflow.com/a/39720346
* IDEMPIERE-4360 exclude generate and test code to speed up
* IDEMPIERE-4360 add sonarcloud.io (optimize)
1. parallel sonar and code QL
2. parameter for repository owner (org)
* IDEMPIERE-4360 add sonarcloud.io
* IDEMPIERE-4360 add sonarcloud.io (update properties)
* IDEMPIERE-4360 add sonarcloud.io (optimize)
1. when use matrix for codeql-action then job of javascript run same job of java (mvn, sonar)
so don't use matrix do define separate job let javascript job faster a lot
2. reduce maven log and sonar log from info to warn
3. move project info from pom to yml let fork central place customize CI
* IDEMPIERE-4360 turn off sonar at PR because not yet support
https://stackoverflow.com/a/39720346
Fixes:
org.adempiere.exceptions.AdempiereException: Cross tenant PO reading request detected from session 1009629 for table AD_UserDef_Win Record_ID=1000002
at org.compiere.model.PO.checkValidClient(PO.java:5000)
at org.compiere.model.PO.<init>(PO.java:212)
at org.adempiere.model.GenericPO.<init>(GenericPO.java:81)
at org.compiere.model.MTable.getPO(MTable.java:598)
at org.compiere.model.Query.list(Query.java:286)
at org.compiere.model.MUserDefWin.getAll(MUserDefWin.java:107)
at org.compiere.model.MUserDefWin.getBestMatch(MUserDefWin.java:160)
IDEMPIERE-2003 Capturing wrong numbers with numeric keypad when decimal separator is not dot
- Restore and improve functionality that process dot keypad within the number fields (deleted by mistake in c954a055b2)
* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment
* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment
Add unit test
* IDEMPIERE-4360 add sonarcloud.io
* IDEMPIERE-4360 add sonarcloud.io (update properties)
* IDEMPIERE-4360 add sonarcloud.io (optimize)
1. when use matrix for codeql-action then job of javascript run same job of java (mvn, sonar)
so don't use matrix do define separate job let javascript job faster a lot
2. reduce maven log and sonar log from info to warn
3. move project info from pom to yml let fork central place customize CI
* IDEMPIERE-4268 Fix recursive call to PO
Found a case where PO.checkValidClient fails, and then because of log.severe it tries to create a record with MIssue, and the PO.checkValidClient fails in MIssue, and is called recursively until it fails with a "Trx.run: Transaction timeout."
* IDEMPIERE-4268
- Improve error message
- Fix problem with valid cross-tenant reads in MRegion and MWorkflow
* IDEMPIERE-4421 Html asset versioning should allow fluent deployment
use classpath loading and lang-addon versioning for theme resources
* IDEMPIERE-4421 Html asset versioning should allow fluent deployment
Incorporate backward compatibility patch from Carlos.
* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance
MAllocationHdr.updateBP was broken, the form Payment Allocation worked just because it was calling bpartner.setTotalOpenBalance() at the end
so, I refactored the MAllocationHdr.updateBP and before/afterDelete to call bpartner.setTotalOpenBalance instead if the broken algorithm
Unit test added for allocating and deleting a customer invoice, a vendor invoice, and a charge
* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance
- Fix peer review changes requested by @hengsin
- Detected double call to bpartner.setTotalOpenBalance in WAllocation
- Detected some business partners in GardenWorld with wrong TotalOpenBalance or SO_CreditUsed, added migration script to fix it, it made more complicate to write unit tests as the data was wrong
- Deprecate zk form WTranslationDialog and controller TranslationController
- Move the logic to a java process org.idempiere.process.TranslationImpExp
- As a process works in mobile, can be called via webservices, tested with fitnesse, etc
- Importing leaves a better and readable log of each file processed
- Importing/Exporting gives feedback to the user about the file being processed
Side note:
- To standardize the menu - renamed the "Initial Client Setup Process" to "Initial Client Setup"
Improvements over the previous form:
- can process the files from the zip in root folder, or in internal folder with the name of the language
- can process a URL http/https to download the zip file
hengsin
Nicolas Micoud
Carlos Ruiz
hieplq
Deepak Pansheriya
Diego Ruiz