Commit Graph

13701 Commits

Author SHA1 Message Date
hengsin 5ceae6cbe3
IDEMPIERE-4515 Mobile: Paging control at detail pane overlapped with toolbar (#349)
- Use more compact layout for small width screen
- Always enable click to popup for status message for small width screen
2020-11-03 14:05:05 +01:00
hengsin d046842ef5
IDEMPIERE-4514 Grid View Layout Bug (#348) 2020-11-03 13:58:54 +01:00
Carlos Ruiz f43883f795
IDEMPIERE-4517 Some messages missing - toolbar (#347) 2020-11-02 23:11:08 +08:00
Carlos Ruiz db7b9db43c
IDEMPIERE-3340 Fixes for oracle migration scripts (#346) 2020-11-02 13:17:12 +01:00
Deepak Pansheriya 01d52fbfef
IDEMPIERE-3340: Tree Structurable User Favorite (#334) 2020-11-02 19:28:03 +08:00
hengsin 03d668bf51
IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer (#345)
- log errors from background init.
- add explicit Env Context init for AdempiereMonitor thread and
Background init thread.
2020-11-02 11:23:24 +01:00
Carlos Ruiz c9a766c806
IDEMPIERE-4297 Improve test data (#344)
Fix error reported by @hengsin
Doc_Invoice.getValidCombination_ID: NO account Type=4

Make explicit the deprecation in code and hide the deprecated account fields on IDEMPIERE-362
2020-11-02 10:39:40 +08:00
hieplq 6e96c43303
IDEMPIERE-4492 fix for rest api (#343)
* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 update atmosphere to 2.5.15

* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 (update configuration)

update to default jetty configuration
delete unused configuration (alpn, http2,..)

* IDEMPIERE-4492 update orbit eclipse repository to 4.17

* IDEMPIERE-4492 update orbit eclipse repository to 4.17 (on parent pom)

* IDEMPIERE-4492 update jasper to 6.15.0

* IDEMPIERE-4492 update jasper to 6.15.0 (IDEMPIERE-4504)

get rid of bundle "org.w3c.dom.events version 3.0.0" by use old version of org.w3c.dom.smil

note: on target platform a bundle has multi version then tycho can pickup correct version define on feature (tab included plugins, field version)
but on eclipse when sync launching from .product it don't respect that value, always set highest version to bundle
workaround: on target platform manual un-select bundle org.w3c.dom.smil 1.0.1

* IDEMPIERE-4492 update atmosphere to 2.6.4

* IDEMPIERE-4492 refine target platform

use targetplatform-dsl to generate target platform https://github.com/eclipse-cbi/targetplatform-dsl
   + don't need to care update bundle version when update repository
   + at moment org.idempiere.eclipse.platform-feature include some feature form eclipse repository
     so target has to include that feature so target platform will include all bundler request by feature and bundle request by plugins of that feature and so on (ever optional
     so it make target content has more plugins than what we use on project
     next step will convert include feature to include plugins to define only what we used

* IDEMPIERE-4492 refine target platform (continue)

don't include framework feature, use include plugins to void load transitive dependency so minimize target flatform
remove some unused feature from idempiere product

* IDEMPIERE-4492 update c3p0 and database jdbc (patch from Carlos)

* IDEMPIERE-4492 improve target platform (continue)

provide test bundle require to repository for use on offline
remove some unused bundle
also fix for IDEMPIERE-4475

* IDEMPIERE-4492 improve target platform (continue IDEMPIERE-4475)

add launch for unittest
add more require bundle for unit test

* IDEMPIERE-4492 fix for rest api

refer:https://github.com/eclipse-ee4j/jersey/issues/3588#issuecomment-720033467

* IDEMPIERE-4492 fix for rest api

refer:https://github.com/eclipse-ee4j/jersey/issues/3588#issuecomment-720033467
2020-11-01 13:22:11 +01:00
hengsin b4c93c76b3
IDEMPIERE-4516 InvoiceCustomerTest show NPE at console (#342)
* IDEMPIERE-4516 InvoiceCustomerTest show NPE at console

add NPE check

* IDEMPIERE-4516 InvoiceCustomerTest show NPE at console

- add way to defer the immediate posting of doc that's means to be
posted in the processing of docpostprocess of the source document.
- add severe log check to InvoiceCustomerTest
- DocumentEngine should skip Doc from DocPostProcess that have been
posted
2020-11-01 12:43:36 +01:00
hengsin 2c5362ec1f
IDEMPIERE-4514 Grid View Layout Bug (#339)
Fix NPE

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-10-31 17:18:07 +01:00
Carlos Ruiz c13dcc1d60
IDEMPIERE-4514 Grid View Layout Bug (#341)
Fix Null Pointer Exception
2020-10-31 17:12:35 +01:00
Carlos Ruiz 59bd3ab106
IDEMPIERE-2902 UX: Implement Radio buttons (#340)
Fix zoomable label decoration
2020-10-31 17:11:24 +01:00
hengsin c02dde975b
IDEMPIERE-2902 UX: Implement Radio buttons (#337)
Fix zoom
2020-10-31 17:07:11 +01:00
hengsin 904c8131be
IDEMPIERE-4514 Grid View Layout Bug (#336)
Fix issue with first time switching of detail tab.
2020-10-31 15:24:44 +01:00
hieplq d2a2e3d19f
Idempiere 4492 improve target platform (continue) (#335)
* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 update atmosphere to 2.5.15

* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 (update configuration)

update to default jetty configuration
delete unused configuration (alpn, http2,..)

* IDEMPIERE-4492 update orbit eclipse repository to 4.17

* IDEMPIERE-4492 update orbit eclipse repository to 4.17 (on parent pom)

* IDEMPIERE-4492 update jasper to 6.15.0

* IDEMPIERE-4492 update jasper to 6.15.0 (IDEMPIERE-4504)

get rid of bundle "org.w3c.dom.events version 3.0.0" by use old version of org.w3c.dom.smil

note: on target platform a bundle has multi version then tycho can pickup correct version define on feature (tab included plugins, field version)
but on eclipse when sync launching from .product it don't respect that value, always set highest version to bundle
workaround: on target platform manual un-select bundle org.w3c.dom.smil 1.0.1

* IDEMPIERE-4492 update atmosphere to 2.6.4

* IDEMPIERE-4492 refine target platform

use targetplatform-dsl to generate target platform https://github.com/eclipse-cbi/targetplatform-dsl
   + don't need to care update bundle version when update repository
   + at moment org.idempiere.eclipse.platform-feature include some feature form eclipse repository
     so target has to include that feature so target platform will include all bundler request by feature and bundle request by plugins of that feature and so on (ever optional
     so it make target content has more plugins than what we use on project
     next step will convert include feature to include plugins to define only what we used

* IDEMPIERE-4492 refine target platform (continue)

don't include framework feature, use include plugins to void load transitive dependency so minimize target flatform
remove some unused feature from idempiere product

* IDEMPIERE-4492 update c3p0 and database jdbc (patch from Carlos)

* IDEMPIERE-4492 improve target platform (continue)

provide test bundle require to repository for use on offline
remove some unused bundle
also fix for IDEMPIERE-4475

* IDEMPIERE-4492 improve target platform (continue IDEMPIERE-4475)

add launch for unittest
add more require bundle for unit test
2020-10-31 13:48:16 +01:00
hieplq 58258ad506
Idempiere-4492 update library (eclipse-4.17, jasper 6-15, jetty-9.4.33, atmosphere-2.6.4) (#331)
* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 update atmosphere to 2.5.15

* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 (update configuration)

update to default jetty configuration
delete unused configuration (alpn, http2,..)

* IDEMPIERE-4492 update orbit eclipse repository to 4.17

* IDEMPIERE-4492 update orbit eclipse repository to 4.17 (on parent pom)

* IDEMPIERE-4492 update jasper to 6.15.0

* IDEMPIERE-4492 update jasper to 6.15.0 (IDEMPIERE-4504)

get rid of bundle "org.w3c.dom.events version 3.0.0" by use old version of org.w3c.dom.smil

note: on target platform a bundle has multi version then tycho can pickup correct version define on feature (tab included plugins, field version)
but on eclipse when sync launching from .product it don't respect that value, always set highest version to bundle
workaround: on target platform manual un-select bundle org.w3c.dom.smil 1.0.1

* IDEMPIERE-4492 update atmosphere to 2.6.4

* IDEMPIERE-4492 refine target platform

use targetplatform-dsl to generate target platform https://github.com/eclipse-cbi/targetplatform-dsl
   + don't need to care update bundle version when update repository
   + at moment org.idempiere.eclipse.platform-feature include some feature form eclipse repository
     so target has to include that feature so target platform will include all bundler request by feature and bundle request by plugins of that feature and so on (ever optional
     so it make target content has more plugins than what we use on project
     next step will convert include feature to include plugins to define only what we used

* IDEMPIERE-4492 refine target platform (continue)

don't include framework feature, use include plugins to void load transitive dependency so minimize target flatform
remove some unused feature from idempiere product

* IDEMPIERE-4492 update c3p0 and database jdbc (patch from Carlos)
2020-10-31 06:53:36 +08:00
hengsin 8a1301b1fc
IDEMPIERE-4514 Grid View Layout Bug (#333) 2020-10-30 16:35:25 +01:00
hengsin e1cf1ada4d
IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on th… (#332)
* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

remove unuse code.

* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

add sysconfig record for ZK_TOOLBAR_SHOW_MORE_VERTICAL
2020-10-29 13:30:00 +01:00
Martin Schönbeck b8225276a2
Idempiere 4452 (#271)
* IDEMPIERE-4452 Allow pricelist schema lines to be dependent of vendor categories and to use entries in m_product_po not marked as current vendor if vendor is selected.

* IDEMPIERE-4452 modified update removed
* don't check for accidently set IsIgnoreIsCurrentVendor where it doesn't change anything.

* IDEMPIERE-4452 set IsIgnoreIsCurrentVendor to false ('N') when no business partner given.
2020-10-28 22:15:01 +08:00
Carlos Ruiz ee1bad9e9d
IDEMPIERE-4511 Drop ampersand & from messages (#330) 2020-10-28 21:30:14 +08:00
hengsin 70997ff85c
IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area (#329)
Change to use the mobile overflow popup
2020-10-28 21:26:44 +08:00
hengsin a6f451606d
IDEMPIERE-4482 Mobile Improvements - Font (#328)
For mobile, a uniform default font-size of 16 for everything (including
z-icon and z-group-icon) seems to work better.
2020-10-28 10:00:41 +08:00
Carlos Ruiz b005dd503f
IDEMPIERE-4482 Mobile Improvements - Font (#327)
Fix error on collapse icon on field groups
2020-10-27 19:23:58 +01:00
hengsin 00e94b12ef
IDEMPIERE-2902 UX: Implement Radio buttons (#326)
* IDEMPIERE-2902 UX: Implement Radio buttons

Integrate contribution from TrekGlobal
TC-188 Port RadioGroup field editor from AP2-19
added "Radio Group List" field type

* IDEMPIERE-2902 UX: Implement Radio buttons

Peer review
* Configure correctly wrong Validation Rule
* Fix wrong DisplayLogic from this ticket and also from other recently added features on fields:
Attribute > Attribute > Reference Key
Attribute > Attribute > Dynamic Validation
Info Window > Column > Reference Key
Info Window > Column > Dynamic Validation
Registration Attributes > Attribute > Reference Key
Table and Column > Column > Dynamic Validation
Table and Column > Column > Dynamic Validation (Lookup)
Table and Column > Column > Reference Key
Web Service Security > Web Service Field Input > Reference Key
Window Customization > Field Customization > Reference Key
Window Customization > Field Customization > Dynamic Validation
Window Customization > Field Customization > Dynamic Validation (Lookup)
Window, Tab & Field > Field > Reference Key
Window, Tab & Field > Field > Dynamic Validation
Window, Tab & Field > Field > Dynamic Validation (Lookup)
* For testing and UX, configure as Radio Group:
Broadcast Message > Broadcast Message > Target
Field Group > Field group > Field Group Type

* IDEMPIERE-2902 UX: Implement Radio buttons

* For testing and UX, configure as Radio Group in detail tab:
Info Window > Process > LayoutType

* IDEMPIERE-2902 UX: Implement Radio buttons

- Fix radio group editor lost track of selectedItem after page detached
and attached
- Standardized the construction of editors from editor factory
- Remove unnecessary refresh for list/lookup based readonly editors
created by grid view (fixed editor is not readonly during init())

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-10-27 19:17:56 +01:00
Diego Ruiz 78393af99d
IDEMPIERE-4510 Add New to the toolbar search query combobox (#325)
* IDEMPIERE-4510 Add New to the toolbar search query combobox

* IDEMPIERE-4510 changed the if for a more defensive programming style

* IDEMPIERE-4510 Change placeholder text to Select Query to improve UX

* IDEMPIERE-4510 Modify migration scripts
2020-10-27 19:07:22 +01:00
Carlos Ruiz 86732d69b7
IDEMPIERE-4482 Mobile Improvements - Font (#324)
* IDEMPIERE-4482 Mobile Improvements - Font

Change font to improve the L&F

* Move font-family to generic definition in theme.css.dsp

* Remove unnecessary font-family settings
2020-10-28 01:07:02 +08:00
hengsin 237df8203c
IDEMPIERE-4509 Grid View Horizontal scrolling is not working well (#323)
Disable the use of Frozen
2020-10-27 07:19:30 +08:00
hengsin 9162b60af7
IDEMPIERE-4498 Performance: add cache for osgi services factory (#321)
* IDEMPIERE-4498 Performance: add cache for osgi services factory

add cache for tableName -> IModelFactory

* IDEMPIERE-4498 Performance: add cache for osgi services factory

implement cache for the discovery of osgi services

* IDEMPIERE-4498 Performance: add cache for osgi services factory

added unit test
2020-10-26 18:53:10 +01:00
hieplq e7fda64110
IDEMPIERE-4504:[JR] can't show QR code on jasper report (org/apache/batik/bridge/UserAgent) (#314)
1. DynamicImport don't need anymore, it's done on jasper engine already
2. seem batik-11 don't exchange object org.w3c.dom.* with svg anymore, so don't need to force it (and jasper) to use "org.w3c.dom.events version 3.0.0"
with this change all batik lib use org.w3c.dom.* from jdk so jasper engine can wire to it, so can see org.apache.batik.bridge.UserAgent

change of (2) enough to resolve this issue, next time when we get it back then down org.w3c.dom.smil to 1.0.0 to get rid of "org.w3c.dom.events version 3.0.0" will help on complete that hell
2020-10-26 18:45:46 +01:00
hengsin 6e9a547049
IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency (#317)
- minor unit testing improvement
2020-10-26 18:24:57 +01:00
Carlos Ruiz fa86359570
IDEMPIERE-2999 Attribute, Table Direct and date field support (#320)
Fix security issue about non advanced roles
2020-10-26 14:18:33 +01:00
Deepak Pansheriya 17dd85d34d
IDEMPIERE-4505: Add new criteria after slected record on advanced tab on Lookp Dialog. (#315) 2020-10-26 11:21:07 +08:00
Deepak Pansheriya 692533fda5
IDEMPIERE-4506: When using font icon, changing Calendar theme to grey (#318) 2020-10-26 10:32:17 +08:00
hengsin 57e4e3fceb
IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency (#316)
- Fix error in setting the currency for source amount
- Improve unit test to check source amount precision as well
2020-10-22 20:48:07 +08:00
Elaine Tan c4b39eac8c
IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency (#313)
* IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency

* IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency - Added MatchInvTest.testMatReceiptPostingWithDiffCurrencyPrecision test case
2020-10-22 15:40:42 +08:00
Carlos Ruiz 014b45246f
Idempiere 4058 (#312)
* IDEMPIERE-4058 - tab editor: new options for editing and customizing fields (window customization)

* IDEMPIERE-4058 tab editor: new options for editing and customizing fields (window customization)

Fix issues with migration scripts

Co-authored-by: muriloht <muriloht@devcoffee.com.br>
2020-10-21 15:47:56 +02:00
Carlos Ruiz 82a5897bb4
IDEMPIERE-3532 Remove hardcoded values for InfoInvoiceWindow (BPartnerID / IsSOTrx) and InfoPaymentWindow (IsSOTrx) (#309)
Fix log message -> GridField.defaultFromSQLExpression: (IsVendor) - Default SQL variable parse failed
2020-10-21 14:53:37 +02:00
Carlos Ruiz 350e9efe65
IDEMPIERE-4503 Hide non-working things in Window Customization (#310) 2020-10-21 14:49:02 +02:00
Carlos Ruiz ea6e77b5dd
IDEMPIERE-4468 Pass the current value of numberbox to the textfield of calculator (#311)
Fix NPE
2020-10-21 14:48:24 +02:00
Deepak Pansheriya 78f388d450
IDempiere-2999: on Attribute adding all reference type support except… (#287)
* IDempiere-2999: on Attribute adding all reference type support except path, images.

* IDEMPIERE-2999 : Removing isQuickForm reference from migration script and fixing url issue.
2020-10-21 13:58:23 +02:00
Deepak Pansheriya 08f6fb17d3
IDEMPIERE-3981: FindWindow - Overwrite isSelection at field level, Va… (#249)
* IDEMPIERE-3981: FindWindow - Overwrite isSelection at field level, Validation Rule overwrite for Find window, Extended search and advanced hiding options.

* IDEMPIERE-3981: Correcting migration script as per Carlos' code review finding

* IDEMPIERE-3981: Fixing as per code review comment
Co-authored-by: muriloht muriloht@devcoffee.com.br

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-10-21 13:32:25 +02:00
Carlos Ruiz 00153d7c8d
IDEMPIERE-4494 Security - Tenant customization must be advanced (#304) 2020-10-18 11:47:34 +02:00
Carlos Ruiz a60dd24533
IDEMPIERE-4495 github code scanning alerts (#308)
* IDEMPIERE-4495 github code scanning alerts

Failure to use secure cookies

* Failure to use secure cookies - one more

* Fix: Arbitrary file write during archive extraction ("Zip Slip")

* Fix: Resolving XML external entity in user-controlled data
2020-10-18 11:04:54 +08:00
hengsin e06938cedc
IDEMPIERE 4211 (#307)
* IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer

add 1 to 3 minute delay to wait for hazelcast service

* IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer

move waiting to background thread
add MONITOR_INITIAL_WAIT_FOR_CLUSTER_IN_SECONDS and
MONITOR_MAX_WAIT_FOR_CLUSTER_IN_SECONDS sysconfig
2020-10-17 22:33:59 +02:00
hengsin 2b9cb9bb2e
IDEMPIERE-4497 Mobile: Update PDF.JS (#306)
* IDEMPIERE-4497 Mobile: Update PDF.JS

* IDEMPIERE-4497 Mobile: Update PDF.JS

archive and simple pdf viewer

* IDEMPIERE-4497 Mobile: Update PDF.JS

change ZK_USE_PDF_JS_VIEWER sysconfig level to Client level (C)
2020-10-17 17:55:11 +02:00
Carlos Ruiz 9075b6d84b
IDEMPIERE-4495 github code scanning alerts (#305)
* IDEMPIERE-4495 github code scanning alerts

Failure to use secure cookies

* Query built without neutralizing special characters
2020-10-17 14:11:12 +08:00
Carlos Ruiz c0867c01ee
IDEMPIERE-4297 Improve test data (#303)
The GardenWorld Admin Not Advanced role was added as advanced by mistake
2020-10-17 07:16:06 +08:00
Carlos Ruiz fcf7a168b4
IDEMPIERE-4287 Cache API not thread safe and inconsistent with context parameter (#302)
Fix issue with
java.lang.IllegalStateException: PO is Immutable: org.compiere.model.MRecentItem
	at org.compiere.model.PO.checkImmutable(PO.java:1573)
	at org.compiere.model.PO.set_Value(PO.java:733)
	at org.compiere.model.PO.set_Value(PO.java:721)
	at org.compiere.model.X_AD_RecentItem.setAD_Role_ID(X_AD_RecentItem.java:123)
	at org.compiere.model.MRecentItem.addModifiedField(MRecentItem.java:234)
2020-10-17 07:14:51 +08:00
Nicolas Micoud 4856ca67fc
IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility (#261)
* IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility

Search recipients in SysConfig and if not found, fallback on System.SupportEMail

* IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility

fixes suggested by @hengsin

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2020-10-16 23:22:19 +08:00
hengsin a21fe225e1
IDEMPIERE-4493 Mobile: Animation for Swipe Gesture (#301) 2020-10-16 11:46:48 +02:00