Commit Graph

156 Commits

Author SHA1 Message Date
hengsin f5a0a0a2f6
IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone (#1348)
- Fix unit test.
- Fix server monitor error out if AD_ClientInfo.TimeZone has invalid
value.
2022-05-28 10:54:16 +02:00
hengsin 6ba272a732
IDEMPIERE-5014 Improve efficiency of Query for large result sets - using Stream (#1334)
- remove iterable() and restore the POIterator base iterate()
implementation.
2022-05-18 16:20:10 +02:00
hengsin a41aeb2205
IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing (#1277)
* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

- Fix rounding error
2022-05-12 11:12:05 +02:00
hengsin 9e43a36862
IDEMPIERE-5260 Enhance Discount Schema for Fixed Pricing (#1313)
* IDEMPIERE-5260 Enhance Discount Schema for Fixed Pricing

* IDEMPIERE-5260 Enhance Discount Schema for Fixed Pricing

- Fix unit test error.
2022-05-11 18:39:58 +02:00
Carlos Ruiz b6191ecee3
IDEMPIERE-5063 Improve Unit Tests (#1315)
* IDEMPIERE-5063 Improve Unit Tests

- revert -> Close DB connections after each unit test class
- implement a different approach to close the transactions on tearDown even when not active

* Remove Adempiere.stop as suggested by Heng Sin
2022-05-06 17:56:10 +08:00
hengsin d2e52bbb86
IDEMPIERE-5262 Implement readonly protection for DB.getSQLValueEx call (#1287)
* IDEMPIERE-5262 Implement readonly protection for DB.getSQLValueEx call

* IDEMPIERE-5262 Implement readonly protection for DB.getSQLValueEx call
2022-05-06 11:14:11 +02:00
hengsin a8958bf29d
IDEMPIERE-5261 Workflow EMail notification enhancement (#1299)
* IDEMPIERE-5261 Workflow EMail notification enhancement

* Update 202204190945_IDEMPIERE-5261.sql

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-05-05 18:51:11 +02:00
Fr Jeremy Krieg 10db6177d0
IDEMPIERE-5014 Add stream interface to Query (#1298) 2022-04-29 10:27:26 +08:00
hengsin 321a65bd66
IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone (#1300)
Fix unit test failure
2022-04-23 11:50:56 +02:00
hengsin 13b37c4acc
IDEMPIERE-5093 Scheduler cron pattern scheduling is always using serv… (#1270)
* IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone

* minor fix for oracle/202203240830_IDEMPIERE-5093.sql

* IDEMPIERE-5093 cheduler cron pattern scheduling is always using server time zone

- add time zone comment for cronpattern field
- use fix format for elapsed time (day'hour:minutes:seconds.millisecond)
- use time zone formatting at server monitor
- include etc/gmt* timezone id. fix handling of invalid user input
- fix wrong editor (date) use for timestamp with time zone field

* IDEMPIERE-5093 cheduler cron pattern scheduling is always using server time zone

- Fix MSchedule.getNextRunMS call.

* IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone

- add T_Timestamp to Test table and window.
- fix date time editor doesn't capture seconds for timestamp with time
zone.
- date time editor: use tenant time zone (if set), fallback to browser
time zone.
- date time editor: fix processing of timestamp with time zone value.
- time zone editor: drop the confusing etc/gmt* entries and support
entry of GMT(+/-)hh:mm custom zone id.

* IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone

Fix NPE

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-04-22 21:28:51 +02:00
hengsin 3090f2384b
IDEMPIERE-5056 Order and Invoice: Tax lookup interface (#1253)
* IDEMPIERE-5056 Order and Invoice: Tax lookup interface

* IDEMPIERE-5056 Order and Invoice: Tax lookup interface

- add default value for MSysConfig.getValue call.
2022-03-23 15:00:08 +01:00
hengsin d4532196a2
IDEMPIERE-5083 add FREIGHTCOSTRULE_CustomerAccount (#1261) 2022-03-22 19:27:04 +01:00
hengsin 0f0ee411eb
IDEMPIERE-5089 Add MSysConfig.ALLOW_REVERSAL_OF_RECONCILED_PAYMENT (#1254) 2022-03-18 14:48:11 +01:00
Tony Snook 1f9141353c
IDEMPIERE-5063 Improve Unit Tests (#1232)
- Close DB connections after each unit test class
- POTest and QueryTest: use assert equals, use bigdecimal string constructor in preference to double
2022-03-09 11:00:29 +08:00
Carlos Ruiz a38aefe92e
IDEMPIERE-5198 Print Format Cache do not reload Print Format Items (#1197)
* IDEMPIERE-5198 Print Format Cache do not reload Print Format Items

* IDEMPIERE-5198 Print Format Cache do not reload Print Format Items / add reset(int id) for the cache

* IDEMPIERE-5198 Print Format Cache do not reload Print Format Items / change cache key from String to StringBuilder

Co-authored-by: hengsin <hengsin@gmail.com>
2022-02-25 16:45:33 +08:00
Carlos Ruiz 26aac62a4a
IDEMPIERE-5174 Disable System User (#1174) (#1182)
Fix wrong comparison changed in commit a9c4f7b - test case failing
Improve traceability of unit test
2022-02-12 12:29:20 +01:00
Tony Snook 0ee5faec8e
IDEMPIERE-5184 Cost Adjustment sets incorrect cost for other schema … (#1175)
* IDEMPIERE-5184 Cost Adjustment sets incorrect cost for other schema when currency blank on header
- also add check to unit test

* IDEMPIERE-5184 Cost Adjustment sets incorrect cost for other schema
- add currency id check to minventory before save
2022-02-12 11:27:15 +08:00
hengsin 661550375e
IDEMPIERE-5183 Update JUnit Test Coverage Configuration (#1163) 2022-02-07 11:32:15 +01:00
Tony Snook 78b7dc32d0
IDEMPIERE-5173 fix Accounting fact quantity incorrect (#1150)
* IDEMPIERE-5173 fix Accounting fact quantity incorrect
- also add unit tests

* IDEMPIERE-5173 remove c_uom_id check

* IDEMPIERE-5173 Use MMatchInv.isReversal() in preference to MMatch.getReversal_ID() > 0

* IDEMPIERE-5173 Update isReversal() method 
- add new test for is Reversal() when reversing a credit memo
2022-02-05 15:47:52 +08:00
Tony Snook 2ce19a23cb
IDEMPIERE-5155 fix intermittant Inventory Test failure by sorting MStorageOnHand return value (#1153) 2022-01-30 15:57:32 +08:00
Tony Snook bfecd412a2
IDEMPIERE-5063 Improve Unit Tests - MatchInv Tests (#1144)
- Add MatchInv test using standard costing and check Invoice Price Variance 
- General improvements using assertEquals where appropriate and
  comparing actual values rather than just >0
- minor fixes to MProduct test
2022-01-26 09:51:56 +08:00
hengsin 0db580a7a0
IDEMPIERE-5163 2022-01 Platform update (#1142) 2022-01-25 15:58:06 +01:00
hengsin f934d62efc
IDEMPIERE-5155 Inventory Document: Auto picking of storage record should ignore record with Serial (#1141)
* IDEMPIERE-5155 Inventory Document: Auto picking of storage record should ignore record with Serial

* IDEMPIERE-5155 Inventory Document: Auto picking of storage record should ignore record with Serial

add unit test
2022-01-21 12:10:30 +01:00
Carlos Ruiz 06e9071a82
IDEMPIERE-4962 Performance: change PostgreSQL native dialect mode default to true / revert partially f4894c4cb (#1138)
Regression for problem solved at IDEMPIERE-4465 Native Postgres - Error on Convert Layer
Revert the changes on Convert_PostgreSQL and Convert_PostgreSQLTest
Fix the Convert_PostgreSQLTest to allow testing native and non-native cases
2022-01-19 21:06:20 +08:00
Tony Snook c8c0ae317e
IDEMPIERE-5159 Remove hard coded rounding in Doc_Production (#1137)
- plus multiple improvements to production unit tests
2022-01-19 11:09:03 +08:00
hengsin f2b70f7747
IDEMPIERE-5153 Cost Adjument Line Before Save: Update current cost price (#1131) 2022-01-15 16:55:39 +01:00
Carlos Ruiz e9f85bd985
IDEMPIERE-5147 Fix QueryTest.testPaging failing - IDEMPIERE-5004 (#1129)
Co-authored-by: hengsin <hengsin@gmail.com>
2022-01-12 13:12:22 +01:00
hengsin 916a5a9233
IDEMPIERE-4849 Nonsensical code in MProduction.createLines() (#1116) 2022-01-11 17:15:25 +01:00
hengsin ccdb4868f1
IDEMPIERE-5138 Storage Cleanup Fixes (#1117)
* IDEMPIERE-5138 Storage Cleanup Fixes

* IDEMPIERE-5138 Storage Cleanup Fixes
2022-01-11 16:49:53 +01:00
hengsin 9fd648b3e8
IDEMPIERE-5145 MMatchInv: add IsReversal method (#1120) 2022-01-11 16:20:19 +01:00
igorpojzl 60f76d9edf
IDEMPIERE-5147 Improve Query.first() methods - performance (#1124)
* IDEMPIERE-5147  Improve Query.first() methods - performance

* IDEMPIERE-5147 Query Fix move buildSQL

* IDEMPIERE-5147 Query Fix sql value.

* IDEMPIERE-5147 DB paging Optimalizayion Patch

* IDEMPIERE-5147 Query test fix
2022-01-11 16:10:55 +01:00
Tony Snook 0cf1055692
IDEMPIERE-5063 Improve Unit Tests - fix ProductionTest RollUp test (#1115)
- set mulch product category to Standard Costing category, so that the standard cost of the component is compared to the standard cost of the parent, mulchx.
2022-01-06 09:57:41 +08:00
Saulo José Gil 0eb89932fd
IDEMPIERE-5126 Virtual column lazy loading (#1095)
* IDEMPIERE-5126 Virtual column lazy loading

Virtual columns are now loaded only whenever their respective getters are invoked. This functionality works irrespective of the PO constructor used.

Query class now uses lazy loading by default as well.

* IDEMPIERE-5126 Virtual column lazy loading

Have the model generator ignore virtual columns with the @SQL prefix, as
their generated getters would always return null.

* IDEMPIERE-5126 Virtual column lazy loading

Added quoting to virtual column names

* IDEMPIERE-5126 Virtual column lazy loading

Reload virtual columns if the record was reloaded.

* IDEMPIERE-5126 Virtual column lazy loading

Fixed class cast exception in unit test.

* IDEMPIERE-5126 Virtual column lazy loading

Support for loading selected virtual columns along with regular table
columns, skipping lazy loading.

* IDEMPIERE-5126 Virtual column lazy loading

Fine-grained virtual column loading support for Query.

* IDEMPIERE-5126 Virtual column lazy loading

Support for loading selected virtual columns along with regular table
columns, skipping lazy loading.

* IDEMPIERE-5126 Virtual column lazy loading

Improved support for the constructor PO.PO(Properties, int, String,
String...).

* IDEMPIERE-5126 Virtual column lazy loading

Refactoring. Reduced size of messages sent and received from database
engine when lazy loading virtual columns. Other minor changes.

* IDEMPIERE-5126 Virtual column lazy loading

Added testing assertions.

* IDEMPIERE-5126 Virtual column lazy loading

Silenced Eclipse warnings.
2022-01-05 21:14:50 +08:00
hengsin 55e9e87f0b
IDEMPIERE-5139 BOM validation for Deactivation of Product (#1111) 2022-01-04 15:24:07 +01:00
hengsin 349e0f35a6
IDEMPIERE-5134 Clean up storage records after deactivation of product (#1104) 2022-01-04 10:14:56 +08:00
hengsin b1446ecf65
IDEMPIERE-5127 MProduct: add IsSerial method (#1096)
* IDEMPIERE-5127 MProduct: add IsSerial method

* Update serialVersionUID

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-12-28 16:36:43 +01:00
hengsin 184d9c5603
IDEMPIERE-5128 JUnit test fail to launch with Eclipse 2021-12 (4.22) (#1097)
Update JUnit to 5.8.1 from Eclipse 4.22
2021-12-28 14:02:35 +01:00
Carlos Ruiz fa62f421b9
iIDEMPIERE-5109 Release 9 Horizon - set master in v10 (#1092) 2021-12-24 17:18:24 +01:00
Carlos Ruiz 9ae4a2636e
IDEMPIERE-4214 Javadoc: correct warnings on newest java version (#1082)
* iIDEMPIERE-4214 Javadoc: correct warnings on newest java version / fix problem to generate javadoc again

* IDEMPIERE-4214 Javadoc: correct warnings on newest java version / Fix javadoc warnings
2021-12-23 11:44:23 +01:00
Carlos Ruiz 6fb0f8f359
IDEMPIERE-4836 Adding Access tab on Document Status (Activity) (#1081)
* IDEMPIERE-4836 Adding Access tab on Document Status (Activity) / fix unit test

* IDEMPIERE-4836 Adding Access tab on Document Status (Activity) / fix condition for access (must be AND instead of OR for role and user)
2021-12-23 11:44:01 +01:00
hengsin b88a77ffec
IDEMPIERE-5118 MUOMConversion fix and improvements (#1075) 2021-12-23 10:21:26 +01:00
hengsin 93ebe43cbd
IDEMPIERE-5121 MStorageOnHand API enhancements (#1079) 2021-12-23 10:14:22 +01:00
hengsin 774ba1d427
IDEMPIERE-5114 MProjectTypePhase: getTasks() should return only active task records (#1069) 2021-12-20 11:11:48 +01:00
hengsin a950ba9f00
IDEMPIERE-5113 MInfoWindow: column access doesn't work if From clause is created without synonym/alias (#1064) 2021-12-19 15:01:25 +01:00
Carlos Ruiz 7b30ab343b
IDEMPIERE-4836 Adding Access tab on Document Status (Activity) / peer review - fix multi-tenant issue (#1061) 2021-12-18 16:05:58 +01:00
Deepak Pansheriya da97b08d2c
IDEMPIERE-4836 : Document status access tab (#1001)
* IDEMPIERE-4836 : Document status access tab

* IDEMPIERE-4836 : Adding unit test

* IDEMPIERE-4836 : Fixing as per review comment

* IDEMPIERE-4836 : Fixing review comments
2021-12-18 16:03:06 +01:00
hengsin 95924e8578
IDEMPIERE-5103 Clear Parent Tax ID if a Tax Rate record is Summary (#1056) 2021-12-17 19:25:40 +01:00
hengsin dc698ff655
IDEMPIERE-5073 M_InOutLineMA.DateMaterialPolicy should comes from MStorageOnHand or Shipment instead of through user entry (#1027) 2021-12-14 15:35:04 +01:00
Carlos Ruiz a12ba93869
IDEMPIERE-4186 allow workflow to be suspended until after commit of actual transaction (#1034)
* IDEMPIERE-4186 allow workflow to be suspended until after commit of actual  transaction / fix Split Join = AND

* Add unit test for Split AND

* Fix test case - commit and cleanup the changes to workflow
2021-12-14 10:53:43 +08:00
hengsin 74b6604d57
IDEMPIERE-5065 Material Receipt Line not available for matching after… (#1019)
* IDEMPIERE-5065 Material Receipt Line not available for matching after reversal of Match PO

* IDEMPIERE-5065 Material Receipt Line not available for matching after reversal of Match PO

Fix unit test

* IDEMPIERE-5065 Material Receipt Line not available for matching after reversal of Match PO

Remove unreliable and potentially dangerous match po consolidation
2021-12-13 18:48:48 +01:00