Commit Graph

2915 Commits

Author SHA1 Message Date
hengsin e06938cedc
IDEMPIERE 4211 (#307)
* IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer

add 1 to 3 minute delay to wait for hazelcast service

* IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer

move waiting to background thread
add MONITOR_INITIAL_WAIT_FOR_CLUSTER_IN_SECONDS and
MONITOR_MAX_WAIT_FOR_CLUSTER_IN_SECONDS sysconfig
2020-10-17 22:33:59 +02:00
hengsin 2b9cb9bb2e
IDEMPIERE-4497 Mobile: Update PDF.JS (#306)
* IDEMPIERE-4497 Mobile: Update PDF.JS

* IDEMPIERE-4497 Mobile: Update PDF.JS

archive and simple pdf viewer

* IDEMPIERE-4497 Mobile: Update PDF.JS

change ZK_USE_PDF_JS_VIEWER sysconfig level to Client level (C)
2020-10-17 17:55:11 +02:00
Carlos Ruiz 9075b6d84b
IDEMPIERE-4495 github code scanning alerts (#305)
* IDEMPIERE-4495 github code scanning alerts

Failure to use secure cookies

* Query built without neutralizing special characters
2020-10-17 14:11:12 +08:00
Carlos Ruiz fcf7a168b4
IDEMPIERE-4287 Cache API not thread safe and inconsistent with context parameter (#302)
Fix issue with
java.lang.IllegalStateException: PO is Immutable: org.compiere.model.MRecentItem
	at org.compiere.model.PO.checkImmutable(PO.java:1573)
	at org.compiere.model.PO.set_Value(PO.java:733)
	at org.compiere.model.PO.set_Value(PO.java:721)
	at org.compiere.model.X_AD_RecentItem.setAD_Role_ID(X_AD_RecentItem.java:123)
	at org.compiere.model.MRecentItem.addModifiedField(MRecentItem.java:234)
2020-10-17 07:14:51 +08:00
Nicolas Micoud 4856ca67fc
IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility (#261)
* IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility

Search recipients in SysConfig and if not found, fallback on System.SupportEMail

* IDEMPIERE-4461 : Feedback email recipient(s) : add flexibility

fixes suggested by @hengsin

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2020-10-16 23:22:19 +08:00
igorpojzl 3246bb8b1e
IDEMPIERE-4459 Info Window Customization (#259)
* IDEMPIERE-4459 Info Window Customization - Added Java Models

* IDEMPIERE-4459 Update Model AD_UserDef_Info_Column

* IDEMPIERE-4459 Added Migration scripts

* IDEMPIERE-4459 User Definition Info Column Added

Added Business Logic for Info Window Customization for Info Columns. Added InfoColumnVO for storing InfoColumn Data filtered with User Definition.

* IDEMPIERE-4459 Added Migration Scripts to Update Columns

Allow Update AD_Role_ID, AD_Language, AD_User_ID in AD_UserDef_Info table.

* IDEMPIERE-4459 Info Window Customisation - Updated Migration scripts

* IDEMPIERE-4459 Migration Script Fix

* IDEMPIERE-4459 Info Window Customization - Update Java Models

* IDEMPIERE-4459 Apply Migration Patch

* IDEMPIERE-4459 Info Window Customization - Update Models

* IDEMPIERE-4459 Apply Patch 2 fix.

* IDEMPIERE-4459 Info Related Cust. Added, Info Window Cust. Implementation..

* IDEMPIERE-4459 Info Related isDisplay added

* IDEMPIERE-4459 Added Display Logic for Info Related

* IDEMPIERE-4459 Fix SeqNo for InfoColumns

* IDEMPIERE-4459 Fix Patch 3
2020-10-16 11:41:50 +02:00
hengsin 91c72fd978
IDEMPIERE-4482 Mobile Improvements (#297)
* IDEMPIERE-4482 Mobile Improvements

* IDEMPIERE-4482 Mobile Improvements

minor line height fix for process dialog's message area

* IDEMPIERE-4482 Mobile Improvements

- fix issue with grid view column header height
- add customize grid view button to detail pane
- always show message as notifications for mobile
- fix some mobile layout issues
- default desktop font size to 14px
2020-10-14 11:07:18 +02:00
hengsin 5a83afb565
IDEMPIERE-4287 Fix for AD_Table caching (#296)
fix infinite loop
2020-10-13 12:01:39 +02:00
igorpojzl 4a0b44ac83
IDEMPIERE-4287 Fix for AD_Table caching. (#293) 2020-10-12 21:37:21 +08:00
Diego Ruiz edf407614f
IDEMPIERE-4490 Set default Contact/User in SO, Invoice, M_InOut (#289)
* IDEMPIERE-4490 Set default Contact/User in SO, Invoice, M_InOut

* Ran modelgenerator again with the new field = null

* IDEMPIERE 4490 - Update the migration scripts to 7.1 and set Bill_User_ID to null

* IDEMPIERE 4490 - Update the migration scripts to 7.1

* Change field name from Invoice Address to Invoice Contact / Ship Address to Ship Contact

* IDEMPIERE-4490 Add logic to CalloutOrder.bpartnerBill
2020-10-08 12:17:07 +02:00
hengsin e01e8a0f41 IDEMPIERE-3676 Incorrect stop of the schedulers
Base on patch from NikColonel<polkneket@gmail.com>
2020-10-01 17:23:40 +08:00
Ricardo Santana 2199aa078c
IDEMPIERE-1604 - Extend features for Window Customization (#274)
* IDEMPIERE-1604 - Extend features for Window Customization

* change oracle data type

* oracle replace at sign to chr 64

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-09-28 14:53:33 +02:00
Carlos Ruiz 6ff5fed0ec
IDEMPIERE-4474 Automatic calculation of freight charges (#277)
* IDEMPIERE-4474 Automatic calculation of freight charges

* IDEMPIERE-4474 Keep the getShippingProcessor private - avoid NPE in all getters

* IDEMPIERE-4474 Improve error messages and error management
2020-09-28 14:50:58 +02:00
Deepak Pansheriya 965048d168
IDEMPIERE-2955: Adding Attribute Set Type to use attribute set for di… (#264)
* IDEMPIERE-2955: Adding Attribute Set Type to use attribute set for different purpose

* IDEMPIERE-2955: Fixing migration files swept between Oracle and postgresql folder.

* IDEMPIERE-2955: Fixing oracle migration script having mistakenly deleted comments
2020-09-24 17:17:51 +02:00
igorpojzl 9cca6c08be
IDEMPIERE-4467 Window Customisation has not implemented caching (#268)
* IDEMPIERE-4467  Add caching to UserDefTab and UserDefField

* IDEMPIERE-4467 Change CCache to ImutablePOCache

* IDEMPIERE-4467 Window Customisation - Change cache Get and Put Methods

Change cache Get and Put methods to have consistency with ctx parameter.
2020-09-24 20:06:51 +08:00
Carlos Ruiz 1ddbe3eef5
IDEMPIERE-4213 Window Toolbar attached processes are doesn't validate role access (#265) 2020-09-22 10:52:46 +08:00
Carlos Ruiz c5079d5106
IDEMPIERE-4287 / minor - solve two deprecation warnings (#270) 2020-09-22 10:47:24 +08:00
hengsin 4c1ba12a3f
IDEMPIERE-3212 Quantity MatchPO wrong validation (#269)
Fix auto matching for matchpo and matchinv
2020-09-21 20:00:31 +02:00
Carlos Ruiz 1aa7565ad7
IDWS-8 Cannot update user info in WebStore (#267)
IDEMPIERE-4287
2020-09-21 18:01:21 +08:00
muriloht d875208a00
IDEMPIERE-3336 - Tables missing EntityType column (#258)
* IDEMPIERE-3336 - Tables missing EntityType column

* IDEMPIERE-3336 - fix PR review comments

* IDEMPIERE-3336 - fix PR review default value for entityType
2020-09-21 10:25:23 +02:00
hengsin dd2ef468b0
IDEMPIERE 4287 (#247)
* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
add support to make PO immutable

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added thread safe Immutable and Copy cache implementation for PO.
- migrate most of PO cache to immutable and copy cache.
- added pos sales order test.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- add test case for initial client setup and bank statement
- fix error for image editor, location editor, locator editor, initial
client setup, complete bank statement and migrate storage provider.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added ImmutablePOSupport interface. Model class implement this
interface for immutable PO support.
- remove usage of cache for transaction table (rfq, invoice, inventory).
- add getCopy method to some model class to support getting an
updateable copy of PO from the otherwise immutable PO cache.
- the added getCopy method is use to return updateable PO for indirect
PO reference, for e.g MColumn.getAD_Table() and MOrderLine.getProduct.
2020-09-21 14:03:00 +08:00
Nicolas Micoud 9509d95c7c
IDEMPIERE-4460 : User suggestions for field/context help : check perm… (#257)
* IDEMPIERE-4460 : User suggestions for field/context help : check permission

new method to check exclusion of a table for current role, used to determine if popups should be displayed or not

* IDEMPIERE-4460 : User suggestions for field/context help : check permission

Following @globalqss's recommandations : rename the method + add more controls inside

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-09-20 15:53:56 +02:00
Elaine Tan 79d6c1e903
IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line (#250)
* IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line
2020-09-18 20:58:14 +08:00
Carlos Ruiz 599e13dda3
IDEMPIERE-4462 (#263)
Integrate patch from Paul Bowden (Adaxa)

Co-authored-by: Paul Bowden <pbowden@adaxa.com>
2020-09-18 12:45:20 +02:00
Elaine Tan 236729e3f5
IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Re… (#239)
* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo

* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo - Added test case
2020-09-10 20:49:25 +08:00
Deepak Pansheriya e72dfd66c0
IDEMPIERE-4067 : Support for Under/Over line and Blank line in finaci… (#244)
* IDEMPIERE-4067 : Support for Under/Over line and Blank line in finacial report line.

* IDEMPIERE-4067 : Adding support for blank line export in CSV, HTML, Excel. Also allowing to show description if provided. fixed all review comments fron Carlos Ruiz
2020-09-08 12:59:19 +02:00
Deepak Pansheriya ee48ef2be4
Idempiere 4066 (#235)
* IDEMPIERE-4066: Adding 'Relative Period To' on financial report column which allow to specify period range to produce YoY. QoQ like comparision report.

* IDEMPIERE-4066: Fixing defaulting RelativePeriodTo to Null issue

* IDEMPIERE-4066: Fix as per Carlos review.
1. Fixing compilation issue
2. Moving Column ID constants to systemIDs
3. Updating serial version for MReportColumn.

* IDEMPIERE-4066: Reverted GridField class changes and configured defailt for RelativePeriodTo to be 'NULL'
2020-09-05 12:17:40 +02:00
Carlos Ruiz be525d178c
IDEMPIERE-4447 Add offset to Query (#243)
Add method Query.setRecordstoSkip
2020-09-04 21:42:14 +02:00
Carlos Ruiz e93cdcb38c
IDEMPIERE-4440 NPE in DocAllocationHdr (#241) 2020-09-04 21:38:20 +02:00
Carlos Ruiz dcd7d6a41e
IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confir… (#227)
* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Implement void for movement confirm

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Voiding the confirmation voids the inventory move too

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Similar case found in MInOut - cannot void because of catch-22
Allow to void MInOut -> it automatically voids all pending confirmations

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Set quantities in zero when voiding movement confirmation
2020-08-31 14:23:33 +08:00
Nicolas Micoud 3384819c49
IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo (#238)
* IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo

* IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo (javadoc)
2020-08-28 16:14:45 +02:00
hengsin 7324dde78e
IDEMPIERE-4187 implement the usage of workflows in processes (#236)
Implement chaining of workflow through the use of Process Action
Implement overwrite of Record_ID for Process through Node Parameter
2020-08-27 14:34:26 +02:00
hengsin 9d614b985e
IDEMPIERE-4424 (#222)
* IDEMPIERE-4424 Concurrent update not prevented in Grid View

Grid View - change click navigation to follow the same flow as toolbar
navigation.

* IDEMPIERE-4424 Concurrent update not prevented in Grid View

GridTable - added Updated and Processed concurrency checked against PO.

* IDEMPIERE-4424 Concurrent update not prevented in Grid View

Incorporate fix suggested by Carlos
2020-08-27 12:40:44 +02:00
igorpojzl f13313760c
IDEMPIERE-4433 - MTable error - ConcurrentModificationException (#237)
Fix Putting into Cache outside Synchronized methods.
2020-08-26 20:35:16 +08:00
Carlos Ruiz 02f4d526dc
IDEMPIERE-4429 BOM Drop to Invoice is throwing error (#228)
IDEMPIERE-1314 getDocumentInfo methods should return translated String
2020-08-26 15:49:22 +08:00
Carlos Ruiz 75dcde96b3
IDEMPIERE-1482 Invoice with Payment Schedule is not displayed in Invoice Not Realized Gain/Loss (#225)
Fix problem reported by Anozi Mada
Fix issue found when testing - postgresql was failing with error
   org.postgresql.util.PSQLException: ERROR: la columna «c_doctypereval_id» es de tipo numeric pero la expresión es de tipo text
Avoid creating empty journal
2020-08-26 14:50:10 +08:00
hengsin 0e9f36add9
IDEMPIERE-3197 Tab still keep editing indicator when move to next record (#229)
Update tab title after save
2020-08-24 18:39:27 +02:00
Carlos Ruiz b0fbbb7a16
IDEMPIERE-4425 Find Window improvements (#224)
* IDEMPIERE-4425 Find Window improvements

Fix for printing report parameters - it is printing OPERATOR_EQUAL on reports instead of =

* IDEMPIERE-4425 Find Window improvements

Previous commit broke the find function - must use SQL for Values
2020-08-24 23:08:07 +08:00
Carlos Ruiz 2ad8fdfb3e
IDEMPIERE-2216:when make a warehouse order (in counter document test)… (#226)
* IDEMPIERE-2216:when make a warehouse order (in counter document test). new document material receipt is link with warehouse order not link with purchase order. it's correct?

* IDEMPIERE-2240:when create "On Credit Order" in counter document mode. invoice vendor make wrong reference to sale order

* IDEMPIERE-2257:can't complete invoice (vendor) generate from "order credit" by counter.

Integrating patch from Hiep hieplq@hasuvimex.vn
Changed syntax to be more readable
Used Processed instead of checking list of DocStatus

Co-authored-by: hieplq@hasuvimex.vn <hieplq@hasuvimex.vn>
2020-08-22 20:55:44 +02:00
Carlos Ruiz a9d24a2d5b
IDEMPIERE-4427 Changelog window reference lists dksplayed in wrong language (#221)
Ref IDEMPIERE-1540 e9e7486473
2020-08-21 20:56:34 +08:00
Carlos Ruiz a68c5f1968
IDEMPIERE-4425 Find Window improvements (#219) 2020-08-21 13:07:01 +02:00
Nicolas Micoud 2322a79dda
IDEMPIERE-4422 : GL Distribution - add SeqNo (#217)
* IDEMPIERE-4422 : GL Distribution - add SeqNo

Add SeqNo column on GL Distribution to allow users to choose the lowest one when several records are retrieved.
Fix typo

* IDEMPIERE-4422 : GL Distribution - add SeqNo

Fix a missed typo
2020-08-21 11:20:33 +02:00
Carlos Ruiz 7892c54aa1
IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user (#188)
* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Allow saving Tab Customization for System user

* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Fix copy/paste error

* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Implement same suggestion on all the classes where setAD_User_ID must be allowed to explicitly set to System
There were already two classes with the Override approach: MUserPreference and MUserRoles, so this commit is to apply the same approach to all the classes with same approach
2020-08-13 18:20:59 +08:00
hengsin 60f4ea4215
IDEMPIERE-4406 Performance: PO Cache should not always reset all entr… (#212)
* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

PO update - reset cache by record id

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

refine unit test

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

add cache reset fix for delete

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

Fix exception when cache is empty
Expose hidden cache reset exception
2020-08-11 14:55:03 +02:00
hengsin 0ad8737829
IDEMPIERE-4405 Add basic cache statistics (#211)
fix wrong hit/miss count when cached value is null
2020-08-07 17:07:39 +02:00
hengsin 147eebb01b
IDEMPIERE-4405 Add basic cache statistics (#210)
add hit and miss count for cache
2020-08-07 13:05:34 +02:00
Carlos Ruiz a84adbad80
IDEMPIERE-4395 Cannot save valid strings in oracle - ORA-12899: value too large for column (#202) 2020-08-06 22:35:37 +08:00
hengsin c17f1ae733
IDEMPIERE-4389 (#206)
* IDEMPIERE-4389 Implement Copy Constructor support for PO

Implement PO support for copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

deprecate clone
replace clone with copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

add unit test for MPrintFormat copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

fix wrong import
2020-08-05 21:03:40 +02:00
Carlos Ruiz 59758e8a7e
IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation (#198)
* IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

* IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Add validations to avoid editing lines if there are pending confirmations, in movement and shipment/receipt
2020-08-03 20:45:08 +08:00
hengsin a3a86739c2
IDEMPIERE-4390 Error in the Workflow window (#201)
add keyword quote escape to gridtable and mquery
2020-08-03 13:43:38 +02:00
hengsin f010b10446
IDEMPIERE-4393 Replace Oracle outer join synax (+) with SQL standard outer join (#199)
add native postgresql unit test for GenericPaymentExport
remove unnecessary static and fix sql exception doesn't stop the export
replace Oracle (+) with standard sql outer joint
2020-08-03 12:04:53 +02:00
Carlos Ruiz 600d8efc70
IDEMPIERE-1804 Org of WF Process is Default(login) Organization. (#195)
Workflow org

Co-authored-by: Hideaki Hagiwara <hagiwara.hideaki@gmail.com>
2020-07-31 08:02:33 +08:00
Carlos Ruiz a143e63128
IDEMPIERE-1893 can't Reversed a complete document "move inventory with confirm" (#197)
Do not create confirmation for reversal
2020-07-31 07:58:10 +08:00
Carlos Ruiz 937eaaa6ce
IDEMPIERE-874 Suspense Account is Posted with Wrong Org on GL Journal (#190) 2020-07-30 23:06:14 +08:00
Carlos Ruiz 0fa717cf0a
IDEMPIERE-4083 currency rate by document or by transaction (#182)
Integrating a contribution from TrekGlobal developed by Heng Sin
2020-07-30 15:46:43 +08:00
Carlos Ruiz e79ef31cd5
IDEMPIERE-3897 export csv: reference column export like normal column (#189)
Fix issue that entity type and language are not being set when imported
2020-07-30 10:47:56 +08:00
hieplq 30ce8cc5be
IDEMPIERE-4376:order activity workflow by ID (also time it's created) (#187)
maybe order by seq-no of node link to activity is more stable than ID
2020-07-27 17:08:02 +02:00
hengsin 80146138ac
IDEMPIERE-4382 Locator Editor inconsistent in the application of filter (#183)
pass ValidationCode to MLocatorLookup
Fix dynamic display support
Fix filter for grid view
Fix locator dialog not open with the selected locator
2020-07-26 12:49:43 +02:00
hengsin 40efcea51e
IDEMPIERE-4381 Order Line QtyReserved not updated correctly for negative shipment (#180)
Fix update of QtyReserved
2020-07-26 10:48:55 +02:00
Carlos Ruiz 26d2e37339
IDEMPIERE-1848 can delete org, account record in "Account Schema Dime… (#150)
* IDEMPIERE-1848 can delete org, account record in "Account Schema Dimensions"

Set Accounting Schema > Account Schema Dimensions > Element Type readonly when the type is Account or Org

* IDEMPIERE-1848 can delete org, account record in "Account Schema Dimensions"

reverting https://github.com/idempiere/idempiere/commit/be8de78
from https://sourceforge.net/p/adempiere/bugs/773/
2020-07-22 15:22:23 +08:00
hengsin cc76e63d85
IDEMPIERE-4372 Performance: only add log record and sql statement to … (#172)
* IDEMPIERE-4372 Performance: only add log record and sql statement to context if trace/debug level <= debug/info

Minor clean up and thread safe fix for CLogErrorBuffer and MIssue
Only add LogRecord and SQL to context if TraceLevel is <= INFO

* IDEMPIERE-4372 Performance: only add log record and sql statement to context if trace/debug level <= debug/info

add back DB.isConnected check
remove redundant CLogErrorBuffer call from DB.isConnected
more fine grained synchronization
2020-07-21 12:25:20 +02:00
hengsin d3717bc1fa
IDEMPIERE-4373 Bug fixes for CSV Import loader (#174)
close trx in finally block.
m_directNullKey interfere with CSV Import Loader due to trx that's not
committed yet.
insert mode: update window/tab context after save.
2020-07-21 00:10:49 +02:00
igorpojzl dd2b24aafa
IDEMPIERE-4368: Allow Define Default Saved Query for User (#169)
* Update AD_UserQuery models

* Implementation of initializing Default User Queries

* Added Migration Scripts

* Update 202007161400_IDEMPIERE-4368.sql

Added missing register_migration_script.

* IDEMPIERE-4368 Added missing script.

* IDEMPIERE-4368 Allow Define Default Saved Query for User

Fix Load defaults only on Initialization.

* IDEMPIERE-4368

Move Migration Script to 7.1 folder

* IDEMPEIRE-4368

Apply of patch.
2020-07-20 14:51:48 +02:00
hengsin 31acb032ab
IDEMPIERE-4349 WTableDirEditor show inactive item (#167)
add back onlyActive logic when items is from cache.
2020-07-16 02:28:08 +07:00
Carlos Ruiz 4afaed6140
IDEMPIERE-3062 Unable to complete MR with qty >1 with Attribute Set of Always Mandatory (#144) 2020-07-15 11:05:49 +08:00
Carlos Ruiz 2d70a1a169
IDEMPIERE-1117 Attachment -> Disable preview over certain size (#145)
* IDEMPIERE-1117 Attachment -> Disable preview over certain size

New SysConfig key ZK_MAX_ATTACHMENT_PREVIEW_SIZE

* IDEMPIERE-1117 move scripts to 7.1
2020-07-14 21:51:17 +08:00
Carlos Ruiz e954df2abe
IDEMPIERE-4358 Processes to drop some objects from database (#161) 2020-07-09 19:50:29 +02:00
Nicolas Micoud c59f550293
IDEMPIERE-4359 : EMailTest process : customization of email sent (#162)
Ability to define a dedicated mail template for the EMailTest process (via a client level SysConfig).
Output of the process was wrong (always successful even when the email was not sent)
2020-07-07 16:44:44 +02:00
Nicolas Micoud 4c1236e938
IDEMPIERE-4356 : System properties shouldn't not be used when sending emails (#154)
* IDEMPIERE-4356

Using Hiep's idea

Co-Authored-By: hieplq <hieplq@users.noreply.github.com>

* IDEMPIERE-4356

Following Carlos's tests/advices, add current System Properties to the Properties initialized for the email

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: hieplq <hieplq@users.noreply.github.com>
Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-07-04 11:13:45 +02:00
hieplq 4f09cc5a7a
IDEMPIERE-4329:Cleanup eclipse warnings (un-use import and deprecate function) (#158) 2020-07-03 12:19:56 +02:00
Nicolas Micoud 08c3b3c1be
IDEMPIERE-4351 : MJournal/MJournalLine : fill mandatory values (if mi… (#152)
* IDEMPIERE-4351 : MJournal/MJournalLine : fill mandatory values (if missing) in beforeSave methods

GL_Journal.C_AcctSchema_ID
GL_Journal.C_ConversionType_ID
GL_JournalLine.C_Currency_ID
GL_JournalLine.C_ConversionType_ID

* IDEMPIERE-4351 : MJournal/MJournalLine : fill mandatory

Based on Carlos's patch :
Fix issues in PO.java that are not allowing the beforeSave methods that complete organization to work
* This also has the effect of checking and setting the organization restrictions after beforeSave and EventHandlers have finished, potentially fixing developer errors on org not respecting the configuration on Client Share

* In MJournalLine move the setting of org to the top because the getOrCreateCombination method works with the org value

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-07-01 21:34:51 +02:00
Nicolas Micoud fa3e9461e8
IDEMPIERE-4343 : records created by InitialClientSetup must be on Org * (#132)
* IDEMPIERE-4343 : records created by InitialClientSetup must be on Org *

* IDEMPIERE-4343 : GL_Category
2020-06-30 22:02:39 +02:00
Carlos Ruiz 6e2cf15fa9
IDEMPIERE-966 When Order document(Both PO and SO) close, I think that MOrder.closeIt() method should calculate tax again. (#136) 2020-06-30 13:40:38 +02:00
Carlos Ruiz e057072bc7
IDEMPIERE-829 Implement MInvoice.getOpenAmt with paymentDate (#135) 2020-06-30 12:45:14 +02:00
Carlos Ruiz bcd1fa67cd
IDEMPIERE-4318 Validation - Prepay Order must not allow Cash payment rule (#127) 2020-06-24 17:10:51 +02:00
Diego Ruiz f50425334f
IDEMPIERE-1026 Button on table to create automatically the window (#128)
* IDEMPIERE-1026 Button on table to create automatically the window

* IDEMPIERE-1026 Button on table to create automatically the window - Fixed script

* IDEMPIERE-1026 Button on table to create automatically the window - Header update

* IDEMPIERE-1026 Button on table to create automatically the window - Follow best practices, no hardcoded IDs, no mixed cache and transaction

* IDEMPIERE-1026 Button on table to create automatically the window - Carlos PR
2020-06-24 16:43:11 +02:00
Carlos Ruiz f5518a9b64
IDEMPIERE-4282 Error creating a Price List - using -DPostgreSQLNative=Y (#131)
Starting point is the open source version of Compiere org/compiere/process/PriceListCreate.java
This version adds column M_DiscountSchemaLine.Description and rounding options for Hundred and Thousand
Then added to this version the iDempiere changes related to use correctly the T_Selection with AD_PInstance_ID,
and the changes related to Ticket #1002354: Price List Enhancement - which added Product Costs as an option for getting the initial price
2020-06-24 11:53:49 +02:00
Carlos Ruiz 2a3224ea46
IDEMPIERE-4319 Cascade workflow activities (completing chained documents) exception problem (#122)
Implemented a better approach: save the first workflow savepoint and rollback to that one in case of cascade activities
2020-06-17 15:44:06 +02:00
Carlos Ruiz 36d6644879
IDEMPIERE-4324 Fix NPE on payment allocation (#115)
Co-authored-by: Orlando Curieles <orlando.curieles@ingeint.com>
2020-06-16 14:06:36 +02:00
Carlos Ruiz c0710da6cd
Cache without name #resolve IDEMPIERE-4333 (#116) 2020-06-16 14:06:24 +02:00
Carlos Ruiz 204b00c6f2
IDEMPIERE-4334 Fixed Assets wrong dictionary (#117)
Fixed many wrongly defined columns #resolve IDEMPIERE-4334
Added a fix to DisplayType - running synchronize column in C_Conversion_Rate.C_Currency_ID_To and A_Asset_Split.A_Asset_ID_To was throwing error
2020-06-16 14:06:11 +02:00
Carlos Ruiz fe69eb9dfa
IDEMPIERE-2753 Discount is not calculated when Price List Price <1 (#119)
Bring one more point of failure discovered by Elaine Tan
2020-06-16 13:55:40 +02:00
hengsin 2706026b85
IDEMPIERE-4331 Do not use Hazelcast Cache Service if it is standalone (#113)
Use normal map if hazelcast is stand alone
2020-06-13 16:00:04 +02:00
Carlos Ruiz aac7d81077
IDEMPIERE-4330 New tables are not logged - requires a server restart (#111)
* IDEMPIERE-4330 New tables are not logged - requires a server restart

* IDEMPIERE-4330 New tables are not logged - requires a server restart

Add synchronized to isLogged and resetLoggedList as advised by Heng Sin
2020-06-13 21:37:04 +08:00
hengsin 5adad12309
IDEMPIERE-4332 PO Serialization Optimization (#114)
Do not serialize context and POInfo
2020-06-13 15:21:31 +02:00
Carlos Ruiz 10771a7408
IDEMPIERE-4254 get oracle error ORA-01795 when has more than 1000 org (#109) 2020-06-09 23:26:44 +07:00
Diego Ruiz 0c918a973a
IDEMPIERE-4320 Wrong code found in MOrder.reactivateIt (#108)
Just remove useless code
2020-06-09 12:26:46 +02:00
Carlos Ruiz 37e82005b5
IDEMPIERE-4329 Cleanup eclipse warnings (#107)
* IDEMPIERE-4329 Cleanup eclipse warnings

Clean unused imports

* IDEMPIERE-4329 Cleanup eclipse warnings

Clean some additional warnings
Make org.adempiere.base to respect the Warnings/Errors level configuration from workspace

* IDEMPIERE-4329 Cleanup eclipse warnings

One more unused import caused by the previous commit
2020-06-09 12:26:36 +02:00
hengsin b50b533f43
IDEMPIERE-4327 MPeriod.isOpen - should not perform update with cache PO (#105)
Do not perform update with MAcctSchema from cache
2020-06-09 12:19:47 +02:00
Carlos Ruiz 637c021954 IDEMPIERE-4320 Wrong code found in MOrder.reactivateIt
Just remove useless code
2020-06-09 11:58:18 +02:00
Carlos Ruiz 3339d1395d
IDEMPIERE-4324 NPE - Allocation when the payment is Zero (#104) 2020-06-08 14:08:39 +02:00
Carlos Ruiz 35c64ce77f
IDEMPIERE-4319 Cascade workflow activities (completing chained docume… (#95)
* IDEMPIERE-4319 Cascade workflow activities (completing chained documents) exception problem

* IDEMPIERE-4319 Cascade workflow activities (completing chained documents) exception problem

correct patch - remove comment mark
2020-06-06 20:57:50 +08:00
hengsin 4c3521caa9
IDEMPIERE-4317 Add GridFieldVO list cache for GridTabVO.create (#94)
Add GridFieldVO list cache.
2020-06-02 19:28:11 +02:00
Carlos Ruiz e0980645d7
IDEMPIERE-4315 Allow showing Change Log for extension tables #resolves IDEMPIERE-4315 (#92) 2020-06-01 16:07:43 +02:00
hengsin f2cbbc662d
IDEMPIERE-1540 Autocomplete for field type "Search" (#91)
Refactoring
Fix table/tabledir auto refresh
Fix MLookupInfo.clone
2020-06-01 15:29:04 +02:00
hieplq 9a35f2054d
IDEMPIERE-4314:eclipse project setting independent JDK (#90) 2020-06-01 11:30:00 +08:00
hengsin fc56a2a205
IDEMPIERE-1540 Autocomplete for field type "Search" (#88)
Fix search column for auto complete
2020-05-29 18:08:39 +02:00
hengsin 3837a8e32b
IDEMPIERE-4312 Implement cache for list reference at MLookupFactory (#87)
Fix clone of MLookupInfo
Add list reference cache to MLookupFactory
2020-05-29 13:58:46 +02:00
hengsin fca0963fd9
IDEMPIERE-4311 Implement cache for MAccount(C_ValidCombination) (#84)
Implement cache for MAccount.get(ctx, C_ValidCombination_ID)
2020-05-29 13:53:32 +02:00
hengsin baac93f9e0
IDEMPIERE-4307 Quick Entry always retrieve all fields from db (#83)
add cache for MField
2020-05-29 13:38:15 +02:00
hengsin e9e7486473
IDEMPIERE-1540 Autocomplete for field type "Search" (#79)
* IDEMPIERE-1540 Autocomplete for field type "Search"

Implement auto complete for search field

* IDEMPIERE-1540 Autocomplete for field type "Search"

Add support for isAutoComplete flag (default is off).
Add isAutoComplete to AD_UserDef_Field, AD_InfoColumn and
AD_Process_Para.
Performance improvement - reduce number of queries for autocomplete and
added some cache.

* IDEMPIERE-1540 Autocomplete for field type "Search"

add constant for auto complete query timeout
use union all to further reduce the number of queries
2020-05-29 13:25:24 +02:00
Hideaki Hagiwara 4edd985ef8
IDEMPIERE-4305 Improve CSV Import file Loader validaFile mthod to specify be charset (#82) 2020-05-25 11:04:34 +02:00
Carlos Ruiz c5de6cf205
IDEMPIERE-1146 + IDEMPIERE-3234 (#76)
Avoid logging the update to ad_sequence caused by the previous fixes for IDEMPIERE-1146 + IDEMPIERE-3234
2020-05-23 13:10:50 +02:00
Carlos Ruiz eaf42afd84
#resolve IDEMPIERE-4301 Replace MSysConfig.getDouble with getBigDecimal (#71) 2020-05-23 12:52:46 +02:00
hengsin bf6fd2bb71
Idempiere 4300 (#78)
* IDEMPIERE-4300 DashboardPanel subclass should not cache Env Ctx

Remove Env.getCtx() cache

* IDEMPIERE-4300 DashboardPanel subclass should not cache Env Ctx

Fix usage of private ctx
2020-05-23 00:34:23 +02:00
Diego Ruiz 4eac03ba0f
IDEMPIERE-4304 Saved Query duplicates if use to save after sharing (#81)
* IDEMPIERE-4304 Saved Query duplicates if use to save after sharing

* IDEMPIERE-4304 Saved Query duplicates if use to save after sharing - Replaced JDBC call for Query
2020-05-23 00:23:42 +02:00
Carlos Ruiz 89faa3ac49
IDEMPIERE-2523 improve method to add comment to log script (#75)
#resolve IDEMPIERE-2523
2020-05-20 20:09:23 +02:00
hieplq 595e0df99c
Idempiere-4298:support update jdk (jdk 12 13 14) (#69)
* IDEMPIERE-4298: remove Bundle-RequiredExecutionEnvironment

when build by tycho value of Bundle-RequiredExecutionEnvironment and jdt need to compatibility
in case we use Bundle-RequiredExecutionEnvironment = 11 then can't build by jdk != 11
so stick on fix value isn't good

eclipse now also support Require-Capability, so don't need Bundle-RequiredExecutionEnvironment anymore

* IDEMPIERE-4298:support update jdk (jdk 12 13 14)

default environment still jdk-11 but you can build for any jdk by below command

export JAVA_HOME=path to jdk
mvn verify -Djdk.version=11

in case on JAVA_HOME is jdk 14 then can set jdk.version for 11, 12, 13, 14 and same for other jdk

at moment java 14 just support on eclipse 2020-03 with install plugin
Java 14 Support for Eclipse 2020-03 (4.15)
2020-05-20 11:18:31 +08:00
Carlos Ruiz d2c02c1bf0
#resolve IDEMPIERE-4302 Improve Schedule discovery (#74) 2020-05-19 23:20:29 +02:00
Nicolas Micoud c5038a33ca
IDEMPIERE-4150 : Right click / New/Update not visible with duplicated windows (#50)
Also use ZoomConditions for Table/TableDirect editors
2020-05-19 13:56:52 +02:00
Deepak Pansheriya 14c27c58ca Idempiere 3333 (#60)
* IDEMPIERE-3333: Respecting ReportView order by clause when there is no orderby field on print format configured.

* IDEMPIERE-3333: Adding cached method as per peer review comment.

* IDEMPIERE-3333: Refactoring as per feedback from Carlos Ruiz.
2020-05-14 18:57:25 +02:00
Carlos Ruiz 86ca0a9523
IDEMPIERE-235 Generate Shipments is generating partial for complete orders (#58) 2020-05-13 19:19:56 +02:00
Carlos Ruiz 1f3a83c96e
IDEMPIERE-1146 + IDEMPIERE-3234 / Centralized ID not working with na… (#44)
* IDEMPIERE-1146 + IDEMPIERE-3234  / Centralized ID not working with native sequence enabled / PROJECT_ID_USE_CENTRALIZED_ID should take priority higher than SYSTEM_NATIVE_SEQUENCE

* IDEMPIERE-1146 + IDEMPIERE-3234

improve performance not reading MTable and Columns but just a cache
list of tables with EntityType column

* IDEMPIERE-1146 + IDEMPIERE-3234

Remove deprecation as the method is now capable of managin all cases
2020-05-09 21:13:50 +08:00
hengsin 9a74e18e40
Idempiere 4168 (#40)
* IDEMPIERE-4168 Move Webstore out of core

Change EntityType of webstore table, column, field and menu from 'D' to
'WSTORE'

* IDEMPIERE-4168 Move Webstore out of core

Generate Model/Interface: filter column by EntityType. Update
AD_UserMail model class.

* IDEMPIERE-4168 Move Webstore out of core

Added optional column entity type filter.
2020-05-08 19:06:54 +02:00
Carlos Ruiz 58187cdc05
IDEMPIERE-4220 payment could not be committed due to wrong invoice date #resolve #comment Fixed trx issue (#26) 2020-05-03 15:38:47 +02:00
hengsin c3cad0d1e2
IDEMPIERE-4249 Platform Refresh for 7.1z (#19)
Upgrade to Tycho 1.7.0, Eclipse 2020-03, Zk 9.0.1 and Jetty 9.4.28
2020-04-30 16:01:19 +02:00
Carlos Ruiz 190ef9d75c Merge release-7.1 into master 2020-04-26 13:45:06 +02:00
Diego Ruiz ffb6388d3c IDEMPIERE-2794 Run process via web services does not validate inactive parameters 2020-04-23 19:30:36 +02:00
Carlos Ruiz 0b663af8ab IDEMPIERE-4220 payment could not be committed due to wrong invoice date 2020-04-23 00:30:12 +02:00
Carlos Ruiz 281912af45 IDEMPIERE-2767 Web Services not working with UUID / peer review - implement the same for ModelGetList AD_Reference_ID 2020-04-22 23:32:50 +02:00
Nicolas Micoud d3d7e57cf9 IDEMPIERE-4245 Set GL Category automatically for GL Journal 2020-04-22 19:57:42 +02:00
mschnbeck f1e9b23029 IDEMPIERE-4186 allow workflow to be suspended until after commit of actual transaction 2020-04-22 18:17:27 +02:00
Carlos Ruiz 43c8485b76 Merge release-7.1 into master 2020-04-18 18:44:51 +02:00
Carlos Ruiz e253900ee5 IDEMPIERE-308 Performance: Replace use of StringBuffer and String concatenation with StringBuilder 2020-04-13 22:02:48 +02:00
Carlos Ruiz 4966285971 IDEMPIERE-4168 Move Webstore out of core 2020-04-13 15:21:26 +02:00
Carlos Ruiz 455ed28e92 IDEMPIERE-308 Performance: Replace use of StringBuffer and String concatenation with StringBuilder 2020-04-13 14:47:46 +02:00
hieplq bb43c4edcd IDEMPIERE-4243:when key columns has date column then save record make error ORA-01861: literal does not match format string 2020-04-13 12:52:42 +02:00
Carlos Ruiz 680bb2090c Merge release-7.1 into master 2020-04-11 16:12:38 +02:00
hieplq ba380e114e IDEMPIERE-3416: Implement the ability to track open DB connections (NPE) 2020-04-11 16:10:57 +02:00
Ray Lee e7b227200e IDEMPIERE-4240 2020-04-11 14:55:33 +02:00
Carlos Ruiz e4544f8d1b IDEMPIERE-4236 Allow Mixed Invoice (Assets And Products) / drop localization code from core - that must go into a localization plugin 2020-04-08 16:30:05 +02:00
hengsin d5a82db8b1 IDEMPIERE-4232 Remove code for Media and Knowledge management 2020-04-06 16:45:52 +08:00
hengsin db0aafb3dc Merge branch 'origin/release-7.1' 2020-04-03 20:09:59 +08:00
Carlos Ruiz 9dcb12f394 IDEMPIERE-4229 Approval Workflow Node does not validate inactive UserRoles / integrate patch from Angel Lara 2020-04-02 19:02:13 +02:00
Carlos Ruiz e10a5c9425 Merge release-7.1 into master 2020-04-01 15:27:45 +02:00
hengsin 6e606799f9 IDEMPIERE-4225 Do not cache MSession that's not thread safe 2020-04-01 17:12:51 +08:00
hengsin 21cad08cbb IDEMPIERE-4200 AR Payment Allocation: Incorrect Currency Balancing Postings 2020-03-30 17:21:29 +08:00
Carlos Ruiz 790d96148f Merge release-7.1 into master 2020-03-29 14:37:39 +02:00
hengsin bfc5b13575 IDEMPIERE-4181 Replace CASE WHEN .. END CASE with CASE WHEN ... END 2020-03-27 15:10:01 +08:00
hengsin 41aa4102cd IDEMPIERE-4223 Model class generated with wrong datatype for Column with displaytype=button and columname ends with _ID 2020-03-27 11:35:47 +08:00
Nicolas Micoud 92cd714221 IDEMPIERE-4222 GL Distribution can't work with organization set on the Org_ID field 2020-03-25 14:57:57 +01:00
hengsin 132cc4036c IDEMPIERE-4200 AR Payment Allocation: Incorrect Currency Balancing Postings 2020-03-25 10:33:49 +08:00
Carlos Ruiz 6c56100724 IDEMPIERE-4221 PackOut type "Data Single" (FHCA-1198) 2020-03-24 21:23:09 +01:00
hengsin 41b8e0e62b IDEMPIERE-3947 Fixed Asset bugs and enhancements. Implement import fixed asset for multiple accounting schema. 2020-03-24 18:35:08 +08:00
Carlos Ruiz e32ed5c5cd IDEMPIERE-4218 Note and attachment from scheduler created in wrong client / also cross-tenant AD_UserMail 2020-03-23 20:39:11 +01:00
Carlos Ruiz b6898a8f99 Merge release-7.1 into master 2020-03-21 17:45:25 +01:00
Carlos Ruiz 43d77dee4e IDEMPIERE-4217 Improve DB exception traceability in PO saveEx and deleteEx (FHEG-1684) 2020-03-21 17:44:26 +01:00
Carlos Ruiz de41df7752 IDEMPIERE-4215 Allow subtype tables in context variables 2020-03-21 12:44:28 +01:00
Carlos Ruiz 4e6794b0a1 IDEMPIERE-4178 Add NVL PostgreSQL function 2020-03-15 10:03:50 +01:00
Carlos Ruiz 02647cc5ee Merge release-7.1 into master 2020-03-13 17:46:17 +01:00