midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[ BF 2960239 ] - Promotion Minimum Amt > 0 

In the promotion line if the minimum amount is 0.00 (default) then the line
is not fired because the Promotion rule only activates when the minimum
amount is > 0. This means if you always want the rule to fire - you need
to make the minimum 0.01 which is not logical if you want no minimum.
https://sourceforge.net/tracker/?func=detail&aid=2960239&group_id=176962&atid=879332
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2960239
This commit is contained in:
mjudd 2010-02-27 15:41:14 +00:00
parent 139f65a82e
commit baa578cdfb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
base/src/org/adempiere/model/PromotionRule.java
View File

@ -117,7 +117,7 @@ public class PromotionRule {
boolean mandatoryLineNotFound = false; boolean mandatoryLineNotFound = false;
List<Integer> validPromotionLineIDs = new ArrayList<Integer>(); List<Integer> validPromotionLineIDs = new ArrayList<Integer>();
for (X_M_PromotionLine promotionLine : promotionLines) { for (X_M_PromotionLine promotionLine : promotionLines) {
if (promotionLine.getM_PromotionGroup_ID() == 0 && promotionLine.getMinimumAmt() != null && promotionLine.getMinimumAmt().signum() > 0) { if (promotionLine.getM_PromotionGroup_ID() == 0 && promotionLine.getMinimumAmt() != null && promotionLine.getMinimumAmt().signum() >= 0) {
if (orderAmount.compareTo(promotionLine.getMinimumAmt()) >= 0) { if (orderAmount.compareTo(promotionLine.getMinimumAmt()) >= 0) {
orderAmount = orderAmount.subtract(promotionLine.getMinimumAmt()); orderAmount = orderAmount.subtract(promotionLine.getMinimumAmt());
validPromotionLineIDs.add(promotionLine.getM_PromotionLine_ID()); validPromotionLineIDs.add(promotionLine.getM_PromotionLine_ID());