From baa578cdfb67ee17fc835da7b9dd1a496f46c983 Mon Sep 17 00:00:00 2001 From: mjudd Date: Sat, 27 Feb 2010 15:41:14 +0000 Subject: [PATCH] [ BF 2960239 ] - Promotion Minimum Amt > 0 In the promotion line if the minimum amount is 0.00 (default) then the line is not fired because the Promotion rule only activates when the minimum amount is > 0. This means if you always want the rule to fire - you need to make the minimum 0.01 which is not logical if you want no minimum. https://sourceforge.net/tracker/?func=detail&aid=2960239&group_id=176962&atid=879332 Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2960239 --- base/src/org/adempiere/model/PromotionRule.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/base/src/org/adempiere/model/PromotionRule.java b/base/src/org/adempiere/model/PromotionRule.java index af1aa37f0c..437ce1566d 100644 --- a/base/src/org/adempiere/model/PromotionRule.java +++ b/base/src/org/adempiere/model/PromotionRule.java @@ -117,7 +117,7 @@ public class PromotionRule { boolean mandatoryLineNotFound = false; List validPromotionLineIDs = new ArrayList(); for (X_M_PromotionLine promotionLine : promotionLines) { - if (promotionLine.getM_PromotionGroup_ID() == 0 && promotionLine.getMinimumAmt() != null && promotionLine.getMinimumAmt().signum() > 0) { + if (promotionLine.getM_PromotionGroup_ID() == 0 && promotionLine.getMinimumAmt() != null && promotionLine.getMinimumAmt().signum() >= 0) { if (orderAmount.compareTo(promotionLine.getMinimumAmt()) >= 0) { orderAmount = orderAmount.subtract(promotionLine.getMinimumAmt()); validPromotionLineIDs.add(promotionLine.getM_PromotionLine_ID());