IDEMPIERE-455 Discover and fix FindBugs problems / Pattern SIC_INNER_SHOULD_BE_STATIC

This commit is contained in:
Richard Morales 2012-12-11 19:47:25 -05:00
parent 2035b8c7d3
commit 5662475b92
26 changed files with 28 additions and 28 deletions

View File

@ -601,7 +601,7 @@ public class InOutGenerate extends SvrProcess
/** /**
* InOutGenerate Parameter * InOutGenerate Parameter
*/ */
class SParameter static class SParameter
{ {
/** /**
* Parameter * Parameter

View File

@ -185,7 +185,7 @@ public class IndentedBOM extends SvrProcess
return list; return list;
} }
private class llCost { private static class llCost {
BigDecimal currentCost = Env.ZERO; BigDecimal currentCost = Env.ZERO;
BigDecimal futureCost = Env.ZERO; BigDecimal futureCost = Env.ZERO;
} }

View File

@ -399,7 +399,7 @@ public class InventoryCountCreate extends SvrProcess
* @author Karsten Thiemann, kthiemann@adempiere.org * @author Karsten Thiemann, kthiemann@adempiere.org
* *
*/ */
private class SimpleTreeNode { private static class SimpleTreeNode {
private int nodeId; private int nodeId;

View File

@ -785,7 +785,7 @@ public class M_PriceList_Create extends SvrProcess {
* @author Karsten Thiemann, kthiemann@adempiere.org * @author Karsten Thiemann, kthiemann@adempiere.org
* *
*/ */
private class SimpleTreeNode { private static class SimpleTreeNode {
private int nodeId; private int nodeId;

View File

@ -859,7 +859,7 @@ public final class Fact
* @author Jorg Janke * @author Jorg Janke
* @version $Id: Fact.java,v 1.2 2006/07/30 00:53:33 jjanke Exp $ * @version $Id: Fact.java,v 1.2 2006/07/30 00:53:33 jjanke Exp $
*/ */
public class Balance public static class Balance
{ {
/** /**
* New Balance * New Balance

View File

@ -782,7 +782,7 @@ public abstract class OFXBankStatementHandler extends DefaultHandler
* @author ET * @author ET
* @version $Id: OFXBankStatementHandler.java,v 1.3 2006/07/30 00:51:05 jjanke Exp $ * @version $Id: OFXBankStatementHandler.java,v 1.3 2006/07/30 00:51:05 jjanke Exp $
*/ */
class StatementLine static class StatementLine
{ {
protected String routingNo = null; protected String routingNo = null;
protected String bankAccountNo = null; protected String bankAccountNo = null;

View File

@ -389,7 +389,7 @@ public class AccessSqlParser
/** /**
* Table Info VO * Table Info VO
*/ */
public class TableInfo public static class TableInfo
{ {
/** /**
* Constructor * Constructor

View File

@ -512,7 +512,7 @@ public class GridWorkbench implements Serializable
/************************************************************************** /**************************************************************************
* Window Type * Window Type
*/ */
class WBWindow static class WBWindow
{ {
/** /**
* WBWindow * WBWindow

View File

@ -379,7 +379,7 @@ public class MMailText extends X_R_MailText
/** /**
* MailText Translation VO * MailText Translation VO
*/ */
class MMailTextTrl static class MMailTextTrl
{ {
/** Language */ /** Language */
String AD_Language = null; String AD_Language = null;

View File

@ -276,7 +276,7 @@ public class MProductCategory extends X_M_Product_Category
* @author Karsten Thiemann, kthiemann@adempiere.org * @author Karsten Thiemann, kthiemann@adempiere.org
* *
*/ */
private class SimpleTreeNode { private static class SimpleTreeNode {
/** id of the node */ /** id of the node */
private int nodeId; private int nodeId;
/** id of the nodes parent */ /** id of the nodes parent */

View File

@ -249,7 +249,7 @@ public class MPrintPaper extends X_AD_PrintPaper
/** /**
* Media Size Name * Media Size Name
*/ */
class CMediaSizeName extends MediaSizeName static class CMediaSizeName extends MediaSizeName
{ {
/** /**
* *

View File

@ -424,7 +424,7 @@ public class PackInHandler extends DefaultHandler {
} }
} }
class DeferEntry { static class DeferEntry {
Element element; Element element;
boolean startElement = false; boolean startElement = false;

View File

@ -1221,7 +1221,7 @@ public class ReportStarter implements ProcessCall, ClientProcess
} }
} }
class ReportData { static class ReportData {
private String reportFilePath; private String reportFilePath;
private boolean directPrint; private boolean directPrint;
@ -1275,7 +1275,7 @@ public class ReportStarter implements ProcessCall, ClientProcess
} }
} }
class FileFilter implements FilenameFilter { static class FileFilter implements FilenameFilter {
private String reportStart; private String reportStart;
private File directory; private File directory;
private String extension; private String extension;

View File

@ -456,7 +456,7 @@ public class HtmlDashboard extends JPanel implements MouseListener,
} }
} }
class PageLoader implements Runnable static class PageLoader implements Runnable
{ {
private JEditorPane html; private JEditorPane html;
private URL url; private URL url;

View File

@ -44,7 +44,7 @@ public class StatusBar extends CPanel implements IStatusBar
/****************************************************************************** /******************************************************************************
* Mouse Adapter for Status Bar (statusDB) * Mouse Adapter for Status Bar (statusDB)
*/ */
class StatusBar_mouseAdapter extends java.awt.event.MouseAdapter static class StatusBar_mouseAdapter extends java.awt.event.MouseAdapter
{ {
private StatusBar adaptee; private StatusBar adaptee;

View File

@ -1410,7 +1410,7 @@ public final class Find extends CDialog
* @author Karsten Thiemann, kthiemann@adempiere.org * @author Karsten Thiemann, kthiemann@adempiere.org
* *
*/ */
private class SimpleTreeNode { private static class SimpleTreeNode {
private int nodeId; private int nodeId;
@ -1728,7 +1728,7 @@ public final class Find extends CDialog
&& MColumn.isSuggestSelectionColumn(field.getColumnName(), true); && MColumn.isSuggestSelectionColumn(field.getColumnName(), true);
} }
private class ProxyRenderer implements TableCellRenderer private static class ProxyRenderer implements TableCellRenderer
{ {
/** /**
* Creates a Find.ProxyRenderer. * Creates a Find.ProxyRenderer.

View File

@ -1138,7 +1138,7 @@ DataStatusListener, IADTabpanel, IdSpace
Events.sendEvent(this, new Event(ON_SWITCH_VIEW_EVENT, this)); Events.sendEvent(this, new Event(ON_SWITCH_VIEW_EVENT, this));
} }
class ZoomListener implements EventListener<Event> { static class ZoomListener implements EventListener<Event> {
private IZoomableEditor searchEditor; private IZoomableEditor searchEditor;

View File

@ -641,7 +641,7 @@ public class GridTabRowRenderer implements RowRenderer<Object[]>, RowRendererExt
this.gridPanel = gridPanel; this.gridPanel = gridPanel;
} }
class RowListener implements EventListener<Event> { static class RowListener implements EventListener<Event> {
private Grid _grid; private Grid _grid;

View File

@ -79,7 +79,7 @@ public class Group extends org.zkoss.zul.Group {
m_rows.add(row); m_rows.add(row);
} }
public class GroupHeader extends Div implements EventListener<Event> public static class GroupHeader extends Div implements EventListener<Event>
{ {
/** /**
* *

View File

@ -584,7 +584,7 @@ public class CustomizeGridViewPanel extends Panel
* List Item * List Item
* @author Teo Sarca * @author Teo Sarca
*/ */
private class ListElement extends NamePair { private static class ListElement extends NamePair {
/** /**
* *
*/ */

View File

@ -318,7 +318,7 @@ public class WRC2FieldOrderPanel extends WRCTabPanel implements EventListener<Ev
/** /**
* List Item * List Item
*/ */
public class ListElement extends NamePair { public static class ListElement extends NamePair {
/** /**
* *
*/ */

View File

@ -427,7 +427,7 @@ public class WRC3SortCriteriaPanel extends WRCTabPanel implements EventListener
/** /**
* List Item * List Item
*/ */
public class ListElement extends NamePair { public static class ListElement extends NamePair {
/** /**
* *
*/ */

View File

@ -1954,7 +1954,7 @@ public class FindWindow extends Window implements EventListener<Event>, ValueCha
* @author Karsten Thiemann, kthiemann@adempiere.org * @author Karsten Thiemann, kthiemann@adempiere.org
* *
**/ **/
private class SimpleTreeNode { private static class SimpleTreeNode {
private int nodeId; private int nodeId;

View File

@ -435,7 +435,7 @@ public class PaySelect
/************************************************************************** /**************************************************************************
* Bank Account Info * Bank Account Info
*/ */
public class BankInfo public static class BankInfo
{ {
/** /**
* BankInfo * BankInfo

View File

@ -158,7 +158,7 @@ public class TreeMaintenance {
/************************************************************************** /**************************************************************************
* Tree Maintenance List Item * Tree Maintenance List Item
*/ */
public class ListItem public static class ListItem
{ {
/** /**
* ListItem * ListItem

View File

@ -20,7 +20,7 @@ import org.compiere.model.MQuery;
public class WWindowStatus public class WWindowStatus
{ {
public class AD_WrongTabException extends Exception public static class AD_WrongTabException extends Exception
{ {
public AD_WrongTabException( String msg ) { public AD_WrongTabException( String msg ) {
super(msg); super(msg);