From 5662475b92092f1444ebd4144f6424686398c9d4 Mon Sep 17 00:00:00 2001 From: Richard Morales Date: Tue, 11 Dec 2012 19:47:25 -0500 Subject: [PATCH] IDEMPIERE-455 Discover and fix FindBugs problems / Pattern SIC_INNER_SHOULD_BE_STATIC --- .../src/org/compiere/process/InOutGenerate.java | 2 +- .../src/org/compiere/process/IndentedBOM.java | 2 +- .../src/org/compiere/process/InventoryCountCreate.java | 2 +- .../src/org/compiere/process/M_PriceList_Create.java | 2 +- org.adempiere.base/src/org/compiere/acct/Fact.java | 2 +- .../src/org/compiere/impexp/OFXBankStatementHandler.java | 2 +- .../src/org/compiere/model/AccessSqlParser.java | 2 +- org.adempiere.base/src/org/compiere/model/GridWorkbench.java | 2 +- org.adempiere.base/src/org/compiere/model/MMailText.java | 2 +- .../src/org/compiere/model/MProductCategory.java | 2 +- org.adempiere.base/src/org/compiere/print/MPrintPaper.java | 2 +- org.adempiere.pipo/src/org/adempiere/pipo2/PackInHandler.java | 2 +- .../src/org/compiere/report/ReportStarter.java | 4 ++-- .../src/org/adempiere/apps/graph/HtmlDashboard.java | 2 +- org.adempiere.ui.swing/src/org/compiere/apps/StatusBar.java | 2 +- org.adempiere.ui.swing/src/org/compiere/apps/search/Find.java | 4 ++-- .../WEB-INF/src/org/adempiere/webui/adwindow/ADTabpanel.java | 2 +- .../src/org/adempiere/webui/adwindow/GridTabRowRenderer.java | 2 +- .../WEB-INF/src/org/adempiere/webui/component/Group.java | 2 +- .../src/org/adempiere/webui/panel/CustomizeGridViewPanel.java | 2 +- .../src/org/adempiere/webui/panel/WRC2FieldOrderPanel.java | 2 +- .../src/org/adempiere/webui/panel/WRC3SortCriteriaPanel.java | 2 +- .../WEB-INF/src/org/adempiere/webui/window/FindWindow.java | 2 +- org.adempiere.ui/src/org/compiere/apps/form/PaySelect.java | 2 +- .../src/org/compiere/apps/form/TreeMaintenance.java | 2 +- .../WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java | 2 +- 26 files changed, 28 insertions(+), 28 deletions(-) diff --git a/org.adempiere.base.process/src/org/compiere/process/InOutGenerate.java b/org.adempiere.base.process/src/org/compiere/process/InOutGenerate.java index 221cbbcb97..629b8e4b7c 100644 --- a/org.adempiere.base.process/src/org/compiere/process/InOutGenerate.java +++ b/org.adempiere.base.process/src/org/compiere/process/InOutGenerate.java @@ -601,7 +601,7 @@ public class InOutGenerate extends SvrProcess /** * InOutGenerate Parameter */ - class SParameter + static class SParameter { /** * Parameter diff --git a/org.adempiere.base.process/src/org/compiere/process/IndentedBOM.java b/org.adempiere.base.process/src/org/compiere/process/IndentedBOM.java index cfaf0631c8..8c29b4b643 100644 --- a/org.adempiere.base.process/src/org/compiere/process/IndentedBOM.java +++ b/org.adempiere.base.process/src/org/compiere/process/IndentedBOM.java @@ -185,7 +185,7 @@ public class IndentedBOM extends SvrProcess return list; } - private class llCost { + private static class llCost { BigDecimal currentCost = Env.ZERO; BigDecimal futureCost = Env.ZERO; } diff --git a/org.adempiere.base.process/src/org/compiere/process/InventoryCountCreate.java b/org.adempiere.base.process/src/org/compiere/process/InventoryCountCreate.java index 8dc4f07571..7dcedb7afc 100644 --- a/org.adempiere.base.process/src/org/compiere/process/InventoryCountCreate.java +++ b/org.adempiere.base.process/src/org/compiere/process/InventoryCountCreate.java @@ -399,7 +399,7 @@ public class InventoryCountCreate extends SvrProcess * @author Karsten Thiemann, kthiemann@adempiere.org * */ - private class SimpleTreeNode { + private static class SimpleTreeNode { private int nodeId; diff --git a/org.adempiere.base.process/src/org/compiere/process/M_PriceList_Create.java b/org.adempiere.base.process/src/org/compiere/process/M_PriceList_Create.java index 95474c617e..4f2dfc2491 100644 --- a/org.adempiere.base.process/src/org/compiere/process/M_PriceList_Create.java +++ b/org.adempiere.base.process/src/org/compiere/process/M_PriceList_Create.java @@ -785,7 +785,7 @@ public class M_PriceList_Create extends SvrProcess { * @author Karsten Thiemann, kthiemann@adempiere.org * */ - private class SimpleTreeNode { + private static class SimpleTreeNode { private int nodeId; diff --git a/org.adempiere.base/src/org/compiere/acct/Fact.java b/org.adempiere.base/src/org/compiere/acct/Fact.java index 9ddd5cbe10..edc2c8d543 100644 --- a/org.adempiere.base/src/org/compiere/acct/Fact.java +++ b/org.adempiere.base/src/org/compiere/acct/Fact.java @@ -859,7 +859,7 @@ public final class Fact * @author Jorg Janke * @version $Id: Fact.java,v 1.2 2006/07/30 00:53:33 jjanke Exp $ */ - public class Balance + public static class Balance { /** * New Balance diff --git a/org.adempiere.base/src/org/compiere/impexp/OFXBankStatementHandler.java b/org.adempiere.base/src/org/compiere/impexp/OFXBankStatementHandler.java index a9d70e2e82..549788e212 100644 --- a/org.adempiere.base/src/org/compiere/impexp/OFXBankStatementHandler.java +++ b/org.adempiere.base/src/org/compiere/impexp/OFXBankStatementHandler.java @@ -782,7 +782,7 @@ public abstract class OFXBankStatementHandler extends DefaultHandler * @author ET * @version $Id: OFXBankStatementHandler.java,v 1.3 2006/07/30 00:51:05 jjanke Exp $ */ - class StatementLine + static class StatementLine { protected String routingNo = null; protected String bankAccountNo = null; diff --git a/org.adempiere.base/src/org/compiere/model/AccessSqlParser.java b/org.adempiere.base/src/org/compiere/model/AccessSqlParser.java index 08466815ef..9b11a5b45b 100644 --- a/org.adempiere.base/src/org/compiere/model/AccessSqlParser.java +++ b/org.adempiere.base/src/org/compiere/model/AccessSqlParser.java @@ -389,7 +389,7 @@ public class AccessSqlParser /** * Table Info VO */ - public class TableInfo + public static class TableInfo { /** * Constructor diff --git a/org.adempiere.base/src/org/compiere/model/GridWorkbench.java b/org.adempiere.base/src/org/compiere/model/GridWorkbench.java index afefcf2b8d..080ce9544e 100644 --- a/org.adempiere.base/src/org/compiere/model/GridWorkbench.java +++ b/org.adempiere.base/src/org/compiere/model/GridWorkbench.java @@ -512,7 +512,7 @@ public class GridWorkbench implements Serializable /************************************************************************** * Window Type */ - class WBWindow + static class WBWindow { /** * WBWindow diff --git a/org.adempiere.base/src/org/compiere/model/MMailText.java b/org.adempiere.base/src/org/compiere/model/MMailText.java index 27c4843d7c..7d954b6b15 100644 --- a/org.adempiere.base/src/org/compiere/model/MMailText.java +++ b/org.adempiere.base/src/org/compiere/model/MMailText.java @@ -379,7 +379,7 @@ public class MMailText extends X_R_MailText /** * MailText Translation VO */ - class MMailTextTrl + static class MMailTextTrl { /** Language */ String AD_Language = null; diff --git a/org.adempiere.base/src/org/compiere/model/MProductCategory.java b/org.adempiere.base/src/org/compiere/model/MProductCategory.java index ca01c72f80..011001eb91 100644 --- a/org.adempiere.base/src/org/compiere/model/MProductCategory.java +++ b/org.adempiere.base/src/org/compiere/model/MProductCategory.java @@ -276,7 +276,7 @@ public class MProductCategory extends X_M_Product_Category * @author Karsten Thiemann, kthiemann@adempiere.org * */ - private class SimpleTreeNode { + private static class SimpleTreeNode { /** id of the node */ private int nodeId; /** id of the nodes parent */ diff --git a/org.adempiere.base/src/org/compiere/print/MPrintPaper.java b/org.adempiere.base/src/org/compiere/print/MPrintPaper.java index 81b650d3d1..70155232b2 100644 --- a/org.adempiere.base/src/org/compiere/print/MPrintPaper.java +++ b/org.adempiere.base/src/org/compiere/print/MPrintPaper.java @@ -249,7 +249,7 @@ public class MPrintPaper extends X_AD_PrintPaper /** * Media Size Name */ - class CMediaSizeName extends MediaSizeName + static class CMediaSizeName extends MediaSizeName { /** * diff --git a/org.adempiere.pipo/src/org/adempiere/pipo2/PackInHandler.java b/org.adempiere.pipo/src/org/adempiere/pipo2/PackInHandler.java index 64c4877dc4..772a63ccab 100644 --- a/org.adempiere.pipo/src/org/adempiere/pipo2/PackInHandler.java +++ b/org.adempiere.pipo/src/org/adempiere/pipo2/PackInHandler.java @@ -424,7 +424,7 @@ public class PackInHandler extends DefaultHandler { } } - class DeferEntry { + static class DeferEntry { Element element; boolean startElement = false; diff --git a/org.adempiere.report.jasper/src/org/compiere/report/ReportStarter.java b/org.adempiere.report.jasper/src/org/compiere/report/ReportStarter.java index 979158cc4f..70e74deb43 100644 --- a/org.adempiere.report.jasper/src/org/compiere/report/ReportStarter.java +++ b/org.adempiere.report.jasper/src/org/compiere/report/ReportStarter.java @@ -1221,7 +1221,7 @@ public class ReportStarter implements ProcessCall, ClientProcess } } - class ReportData { + static class ReportData { private String reportFilePath; private boolean directPrint; @@ -1275,7 +1275,7 @@ public class ReportStarter implements ProcessCall, ClientProcess } } - class FileFilter implements FilenameFilter { + static class FileFilter implements FilenameFilter { private String reportStart; private File directory; private String extension; diff --git a/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java b/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java index 19bbfc19f8..9b600eab1d 100644 --- a/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java +++ b/org.adempiere.ui.swing/src/org/adempiere/apps/graph/HtmlDashboard.java @@ -456,7 +456,7 @@ public class HtmlDashboard extends JPanel implements MouseListener, } } - class PageLoader implements Runnable + static class PageLoader implements Runnable { private JEditorPane html; private URL url; diff --git a/org.adempiere.ui.swing/src/org/compiere/apps/StatusBar.java b/org.adempiere.ui.swing/src/org/compiere/apps/StatusBar.java index 7c591949a5..725ed7b007 100644 --- a/org.adempiere.ui.swing/src/org/compiere/apps/StatusBar.java +++ b/org.adempiere.ui.swing/src/org/compiere/apps/StatusBar.java @@ -44,7 +44,7 @@ public class StatusBar extends CPanel implements IStatusBar /****************************************************************************** * Mouse Adapter for Status Bar (statusDB) */ - class StatusBar_mouseAdapter extends java.awt.event.MouseAdapter + static class StatusBar_mouseAdapter extends java.awt.event.MouseAdapter { private StatusBar adaptee; diff --git a/org.adempiere.ui.swing/src/org/compiere/apps/search/Find.java b/org.adempiere.ui.swing/src/org/compiere/apps/search/Find.java index a736952143..fe01049a3b 100644 --- a/org.adempiere.ui.swing/src/org/compiere/apps/search/Find.java +++ b/org.adempiere.ui.swing/src/org/compiere/apps/search/Find.java @@ -1410,7 +1410,7 @@ public final class Find extends CDialog * @author Karsten Thiemann, kthiemann@adempiere.org * */ - private class SimpleTreeNode { + private static class SimpleTreeNode { private int nodeId; @@ -1728,7 +1728,7 @@ public final class Find extends CDialog && MColumn.isSuggestSelectionColumn(field.getColumnName(), true); } - private class ProxyRenderer implements TableCellRenderer + private static class ProxyRenderer implements TableCellRenderer { /** * Creates a Find.ProxyRenderer. diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/ADTabpanel.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/ADTabpanel.java index 5938f41604..5115435eab 100644 --- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/ADTabpanel.java +++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/ADTabpanel.java @@ -1138,7 +1138,7 @@ DataStatusListener, IADTabpanel, IdSpace Events.sendEvent(this, new Event(ON_SWITCH_VIEW_EVENT, this)); } - class ZoomListener implements EventListener { + static class ZoomListener implements EventListener { private IZoomableEditor searchEditor; diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java index a7e2922786..ecc540b1ae 100644 --- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java +++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/adwindow/GridTabRowRenderer.java @@ -641,7 +641,7 @@ public class GridTabRowRenderer implements RowRenderer, RowRendererExt this.gridPanel = gridPanel; } - class RowListener implements EventListener { + static class RowListener implements EventListener { private Grid _grid; diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Group.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Group.java index b06403f39b..e4f8ec0241 100644 --- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Group.java +++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/component/Group.java @@ -79,7 +79,7 @@ public class Group extends org.zkoss.zul.Group { m_rows.add(row); } - public class GroupHeader extends Div implements EventListener + public static class GroupHeader extends Div implements EventListener { /** * diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java index 7a1169bc7e..a8faf65e56 100644 --- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java +++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/CustomizeGridViewPanel.java @@ -584,7 +584,7 @@ public class CustomizeGridViewPanel extends Panel * List Item * @author Teo Sarca */ - private class ListElement extends NamePair { + private static class ListElement extends NamePair { /** * */ diff --git a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC2FieldOrderPanel.java b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC2FieldOrderPanel.java index e4dd536322..b40b5df86f 100644 --- a/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC2FieldOrderPanel.java +++ b/org.adempiere.ui.zk/WEB-INF/src/org/adempiere/webui/panel/WRC2FieldOrderPanel.java @@ -318,7 +318,7 @@ public class WRC2FieldOrderPanel extends WRCTabPanel implements EventListener, ValueCha * @author Karsten Thiemann, kthiemann@adempiere.org * **/ - private class SimpleTreeNode { + private static class SimpleTreeNode { private int nodeId; diff --git a/org.adempiere.ui/src/org/compiere/apps/form/PaySelect.java b/org.adempiere.ui/src/org/compiere/apps/form/PaySelect.java index dfcfd0980f..93c82d4ed2 100644 --- a/org.adempiere.ui/src/org/compiere/apps/form/PaySelect.java +++ b/org.adempiere.ui/src/org/compiere/apps/form/PaySelect.java @@ -435,7 +435,7 @@ public class PaySelect /************************************************************************** * Bank Account Info */ - public class BankInfo + public static class BankInfo { /** * BankInfo diff --git a/org.adempiere.ui/src/org/compiere/apps/form/TreeMaintenance.java b/org.adempiere.ui/src/org/compiere/apps/form/TreeMaintenance.java index 33c80cd965..748e48732b 100644 --- a/org.adempiere.ui/src/org/compiere/apps/form/TreeMaintenance.java +++ b/org.adempiere.ui/src/org/compiere/apps/form/TreeMaintenance.java @@ -158,7 +158,7 @@ public class TreeMaintenance { /************************************************************************** * Tree Maintenance List Item */ - public class ListItem + public static class ListItem { /** * ListItem diff --git a/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java b/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java index 9afe6530b7..b2784b4ec6 100644 --- a/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java +++ b/org.idempiere.webservices/WEB-INF/src/com/_3e/ADInterface/WWindowStatus.java @@ -20,7 +20,7 @@ import org.compiere.model.MQuery; public class WWindowStatus { - public class AD_WrongTabException extends Exception + public static class AD_WrongTabException extends Exception { public AD_WrongTabException( String msg ) { super(msg);