midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update pull_request_template.md

This commit is contained in:
Carlos Ruiz 2023-03-08 19:23:08 +01:00 committed by GitHub
parent 09f524910c
commit 3c9c67ea51
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pull_request_template.md
View File

@ -1,17 +1,18 @@
# Pull Request Checklist # Pull Request Checklist
## Checklist:
- [ ] My code follows the [code guidelines](https://wiki.idempiere.org/en/Contributing_to_Trunk) of this project - [ ] My code follows the [code guidelines](https://wiki.idempiere.org/en/Contributing_to_Trunk) of this project
- [ ] My code follows the best practices of this project - [ ] My code follows the best practices of this project
- [ ] I have performed a self-review of my own code - [ ] I have performed a self-review of my own code
- [ ] My code is easy to understand and review. - [ ] My code is easy to understand and review.
- [ ] I have checked my code and corrected any misspellings
- [ ] In hard-to-understand areas, I have commented my code. - [ ] In hard-to-understand areas, I have commented my code.
- [ ] My changes generate no new warnings - [ ] My changes generate no new warnings
### Tests
- [ ] I have tested the direct scenario that my code is solving
- [ ] I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
- [ ] New and existing unit tests pass locally with my changes - [ ] New and existing unit tests pass locally with my changes
- [ ] I have added unit tests that prove my fix is effective or that my feature works - [ ] I have added unit tests that prove my fix is effective or that my feature works
- [ ] Any dependent changes have been merged and published in downstream modules ### Documentation
- [ ] I have checked my code and corrected any misspellings
- [ ] I have made corresponding changes to the documentation as follows: - [ ] I have made corresponding changes to the documentation as follows:
- - [ ] New feature (non-breaking change which adds functionality): I have created the New Feature page in the project wiki explaining the functionality and how to use it. If relevant, I have committed sample data to the core seed to have usable examples in GardenWorld. - - [ ] New feature (non-breaking change which adds functionality): I have created the New Feature page in the project wiki explaining the functionality and how to use it. If relevant, I have committed sample data to the core seed to have usable examples in GardenWorld.
- - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected): I have documented the change in a clear way that everyone in the community can understand the impact of the change. - - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected): I have documented the change in a clear way that everyone in the community can understand the impact of the change.