From 3c9c67ea51402ed94970d325f51dd95f6d5ea0b3 Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Wed, 8 Mar 2023 19:23:08 +0100 Subject: [PATCH] Update pull_request_template.md --- pull_request_template.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 22876be142..b577bb05ee 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,17 +1,18 @@ # Pull Request Checklist -## Checklist: - - [ ] My code follows the [code guidelines](https://wiki.idempiere.org/en/Contributing_to_Trunk) of this project - [ ] My code follows the best practices of this project - [ ] I have performed a self-review of my own code - [ ] My code is easy to understand and review. +- [ ] I have checked my code and corrected any misspellings - [ ] In hard-to-understand areas, I have commented my code. - [ ] My changes generate no new warnings +### Tests +- [ ] I have tested the direct scenario that my code is solving +- [ ] I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios - [ ] New and existing unit tests pass locally with my changes - [ ] I have added unit tests that prove my fix is effective or that my feature works -- [ ] Any dependent changes have been merged and published in downstream modules -- [ ] I have checked my code and corrected any misspellings +### Documentation - [ ] I have made corresponding changes to the documentation as follows: - - [ ] New feature (non-breaking change which adds functionality): I have created the New Feature page in the project wiki explaining the functionality and how to use it. If relevant, I have committed sample data to the core seed to have usable examples in GardenWorld. - - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected): I have documented the change in a clear way that everyone in the community can understand the impact of the change.