midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF [ 2530847 ] Report is displayed even if java process fails 

https://sourceforge.net/tracker/index.php?func=detail&aid=2530847&group_id=176962&atid=879332

Please help me with a review ;)
This commit is contained in:
teo_sarca 2009-01-23 11:00:29 +00:00
parent 5104231729
commit 17e5112943
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
base/src/org/adempiere/util/ProcessUtil.java
View File

@ -28,6 +28,7 @@ import org.compiere.wf.MWorkflow;
* @author Teo Sarca, SC ARHIPAC SERVICE SRL * @author Teo Sarca, SC ARHIPAC SERVICE SRL
* <li>BF [ 1757523 ] Server Processes are using Server's context * <li>BF [ 1757523 ] Server Processes are using Server's context
* <li>BF [ 2528297 ] Poor error message on jasper fail * <li>BF [ 2528297 ] Poor error message on jasper fail
* <li>BF [ 2530847 ] Report is displayed even if java process fails
*/ */
public final class ProcessUtil { public final class ProcessUtil {
@ -112,27 +113,33 @@ public final class ProcessUtil {
return false; return false;
} }
boolean success = false;
try try
{ {
process.startProcess(ctx, pi, trx); success = process.startProcess(ctx, pi, trx);
if (trx != null) if (success && trx != null)
{ {
trx.commit(true); trx.commit(true);
trx.close(); trx.close();
trx = null;
} }
} }
catch (Exception e) catch (Exception e)
{
pi.setSummary (Msg.getMsg(Env.getCtx(), "ProcessError") + " " + e.getLocalizedMessage(), true);
log.log(Level.SEVERE, pi.getClassName(), e);
return false;
}
finally
{ {
if (trx != null) if (trx != null)
{ {
trx.rollback(); trx.rollback();
trx.close(); trx.close();
trx = null;
} }
pi.setSummary (Msg.getMsg(Env.getCtx(), "ProcessError") + " " + e.getLocalizedMessage(), true);
log.log(Level.SEVERE, pi.getClassName(), e);
return false;
} }
return true; return success;
} }
public static boolean startScriptProcess(Properties ctx, ProcessInfo pi, Trx trx) { public static boolean startScriptProcess(Properties ctx, ProcessInfo pi, Trx trx) {