From 17e5112943c55fd0f356cd48fd90dd3473c5973e Mon Sep 17 00:00:00 2001
From: teo_sarca <devnull@localhost>
Date: Fri, 23 Jan 2009 11:00:29 +0000
Subject: [PATCH] BF [ 2530847 ] Report is displayed even if java process fails
 https://sourceforge.net/tracker/index.php?func=detail&aid=2530847&group_id=176962&atid=879332

Please help me with a review ;)
---
 base/src/org/adempiere/util/ProcessUtil.java | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/base/src/org/adempiere/util/ProcessUtil.java b/base/src/org/adempiere/util/ProcessUtil.java
index 3fcd6884f8..57b47ac5cf 100644
--- a/base/src/org/adempiere/util/ProcessUtil.java
+++ b/base/src/org/adempiere/util/ProcessUtil.java
@@ -28,6 +28,7 @@ import org.compiere.wf.MWorkflow;
  * @author Teo Sarca, SC ARHIPAC SERVICE SRL
  * 				<li>BF [ 1757523 ] Server Processes are using Server's context
  * 				<li>BF [ 2528297 ] Poor error message on jasper fail
+ * 				<li>BF [ 2530847 ] Report is displayed even if java process fails 
  */
 public final class ProcessUtil {
 
@@ -112,27 +113,33 @@ public final class ProcessUtil {
 			return false;
 		}
 		
+		boolean success = false;
 		try
 		{
-			process.startProcess(ctx, pi, trx);
-			if (trx != null)
+			success = process.startProcess(ctx, pi, trx);
+			if (success && trx != null)
 			{
 				trx.commit(true);
 				trx.close();
+				trx = null;
 			}
 		}
 		catch (Exception e)
+		{
+			pi.setSummary (Msg.getMsg(Env.getCtx(), "ProcessError") + " " + e.getLocalizedMessage(), true);
+			log.log(Level.SEVERE, pi.getClassName(), e);
+			return false;
+		}
+		finally
 		{
 			if (trx != null)
 			{
 				trx.rollback();
 				trx.close();
+				trx = null;
 			}
-			pi.setSummary (Msg.getMsg(Env.getCtx(), "ProcessError") + " " + e.getLocalizedMessage(), true);
-			log.log(Level.SEVERE, pi.getClassName(), e);
-			return false;
 		}
-		return true;
+		return success;
 	}
 	
 	public static boolean startScriptProcess(Properties ctx, ProcessInfo pi, Trx trx) {