midsuit
/
core-jgi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

BF [2989353] Slow scrolling in Gridview / strange DB access pattern - thanks to jmpiloq 

Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2989353
This commit is contained in:
Carlos Ruiz 2010-04-24 04:09:14 +00:00
parent fe42a1c7a9
commit 0ec48efce4
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
base/src/org/compiere/model/MLookup.java
View File

@ -199,7 +199,6 @@ public final class MLookup extends Lookup implements Serializable
} }
// Always check for parents - not if we SQL was validated and completely loaded // Always check for parents - not if we SQL was validated and completely loaded
/*
if (!m_info.IsParent && m_info.IsValidated && m_allLoaded) if (!m_info.IsParent && m_info.IsValidated && m_allLoaded)
{ {
log.finer(m_info.KeyColumn + ": <NULL> - " + key // + "(" + key.getClass() log.finer(m_info.KeyColumn + ": <NULL> - " + key // + "(" + key.getClass()
@ -207,25 +206,24 @@ public final class MLookup extends Lookup implements Serializable
// log.finest( m_lookup.keySet().toString(), "ContainsKey = " + m_lookup.containsKey(key)); // log.finest( m_lookup.keySet().toString(), "ContainsKey = " + m_lookup.containsKey(key));
// also for new values and inactive ones // also for new values and inactive ones
return getDirect(key, false, true); // cache locally return getDirect(key, false, true); // cache locally
}*/ }
log.finest (m_info.KeyColumn + ": " + key log.finest (m_info.KeyColumn + ": " + key
+ "; Size=" + m_lookup.size() + "; Validated=" + m_info.IsValidated + "; Size=" + m_lookup.size() + "; Validated=" + m_info.IsValidated
+ "; All Loaded=" + m_allLoaded + "; HasInactive=" + m_hasInactive); + "; All Loaded=" + m_allLoaded + "; HasInactive=" + m_hasInactive);
// never loaded // never loaded
/*
if (!m_allLoaded if (!m_allLoaded
&& m_lookup.size() == 0 && m_lookup.size() == 0
&& !m_info.IsCreadedUpdatedBy && !m_info.IsCreadedUpdatedBy
&& !m_info.IsParent && !m_info.IsParent
&& m_info.DisplayType != DisplayType.Search) && getDisplayType() != DisplayType.Search)
{ {
fillComboBox(isMandatory(), true, true, false); m_loader = new MLoader();
loadComplete(); m_loader.run(); // sync!
retValue = (NamePair)m_lookup.get(key); retValue = (NamePair)m_lookup.get(key);
if (retValue != null) if (retValue != null)
return retValue; return retValue;
}*/ }
// Try to get it directly // Try to get it directly
boolean cacheLocal = m_info.IsValidated ; boolean cacheLocal = m_info.IsValidated ;
return getDirect(key, false, cacheLocal); // do NOT cache return getDirect(key, false, cacheLocal); // do NOT cache