From 0ec48efce48b9f824bf8443617ad0e2a90b085a9 Mon Sep 17 00:00:00 2001 From: Carlos Ruiz Date: Sat, 24 Apr 2010 04:09:14 +0000 Subject: [PATCH] BF [2989353] Slow scrolling in Gridview / strange DB access pattern - thanks to jmpiloq Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2989353 --- base/src/org/compiere/model/MLookup.java | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/base/src/org/compiere/model/MLookup.java b/base/src/org/compiere/model/MLookup.java index 98e8abd9f9..2bd4a64967 100644 --- a/base/src/org/compiere/model/MLookup.java +++ b/base/src/org/compiere/model/MLookup.java @@ -199,7 +199,6 @@ public final class MLookup extends Lookup implements Serializable } // Always check for parents - not if we SQL was validated and completely loaded - /* if (!m_info.IsParent && m_info.IsValidated && m_allLoaded) { log.finer(m_info.KeyColumn + ": - " + key // + "(" + key.getClass() @@ -207,25 +206,24 @@ public final class MLookup extends Lookup implements Serializable // log.finest( m_lookup.keySet().toString(), "ContainsKey = " + m_lookup.containsKey(key)); // also for new values and inactive ones return getDirect(key, false, true); // cache locally - }*/ + } log.finest (m_info.KeyColumn + ": " + key + "; Size=" + m_lookup.size() + "; Validated=" + m_info.IsValidated + "; All Loaded=" + m_allLoaded + "; HasInactive=" + m_hasInactive); // never loaded - /* if (!m_allLoaded && m_lookup.size() == 0 && !m_info.IsCreadedUpdatedBy && !m_info.IsParent - && m_info.DisplayType != DisplayType.Search) + && getDisplayType() != DisplayType.Search) { - fillComboBox(isMandatory(), true, true, false); - loadComplete(); + m_loader = new MLoader(); + m_loader.run(); // sync! retValue = (NamePair)m_lookup.get(key); if (retValue != null) return retValue; - }*/ + } // Try to get it directly boolean cacheLocal = m_info.IsValidated ; return getDirect(key, false, cacheLocal); // do NOT cache