Commit Graph

77 Commits

Author SHA1 Message Date
hengsin e6eb86a1c5
IDEMPIERE-5447 Add unit test for Merge form (#1523)
* IDEMPIERE-5447 Add unit test for Merge form

* IDEMPIERE-5447 Add unit test for Merge form

- Merge patch from Carlos
2022-10-12 16:02:56 +08:00
Peter Takács a96c6e482d
IDEMPIERE-5432 - Performance Measure Calculation - Improve SQL Definition (#1500)
* IDEMPIERE-5432 - Performance Measure Calculation - Improve SQL Definition

* IDEMPIERE-5432 - IDEMPIERE-5432_PR1 patch
2022-10-07 14:01:12 +08:00
Deepak Pansheriya abae9f221d
IDEMPIERE-5349: Adding AlwaysUpdatableLogic on Column and Field. (#1408)
* IDEMPIERE-5349: Adding AlwaysUpdatableLogic on Column and Field.

* IDEMPIERE-5349: Making Always Updatable logic to work when isAlwaysUpdatable is false and iAlwaysUpdatable made higher priority

* IDEMPIERE-5349: fixing error SP2-0027 in oracle

* IDEMPIERE-5349 : Fixing AlwaysUpdatableLogic not set when isAlwaysUpdatableLogic is null

* IDEMPIERE-5349 : renaming migration script and updatong AD_Field_V and AD_Field_VT
2022-10-06 13:53:32 +08:00
Carlos Ruiz d33caf9807
IDEMPIERE-5259 fix "Msg.getMsg: NOT found: Label" error (#1516) 2022-10-06 11:47:35 +08:00
Carlos Ruiz bc9f0433a2
IDEMPIERE-5408 move scripts to release9 (#1513) 2022-10-04 18:03:25 +02:00
Carlos Ruiz c1a1045d87
IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823) (#1498)
* IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823)

- Add column AD_Client.LoginPrefix

* - Implement logic to manage login prefix
- Add SysConfig keys LOGIN_PREFIX_SEPARATOR and LOGIN_WITH_TENANT_PREFIX

* - Rename methods as suggested by Heng Sin

* IDEMPIERE-5408 Allow or enforce login with specific tenant (FHCA-3823)

For security reasons is better to ask for MFA before showing additional information from the user.
Refactoring the panels to show the MFA panel as soon as the tenant is defined.

* - Add uniqueness validations on tenant creation

* - Fix the Forgot My Password functionality

* - Fix the Change Expired Password functionality

* - minor javadoc improvement
- remove a redundant comment, the method is already mark as deprecated

Co-authored-by: hengsin <hengsin@gmail.com>
2022-10-04 11:14:05 +02:00
Layda Salas dbcfd9af14
IDEMPIERE-5437 Improve description for SysConfig SYSTEM_NATIVE_SEQUEN… (#1511)
* IDEMPIERE-5437 Improve description for SysConfig SYSTEM_NATIVE_SEQUENCE #resolve

* IDEMPIERE-5437 Improve description for SysConfig SYSTEM_NATIVE_SEQUENCE #resolve

* revert unwanted changes in launcher

* revert unwanted changes in launcher

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-09-30 12:31:33 +02:00
Nicolas Micoud c9005bd601
IDEMPIERE-5245: Fix missing capitals on first letter of elements starting with "Date..." (#1509)
https://idempiere.atlassian.net/browse/IDEMPIERE-5245
2022-09-30 12:04:13 +02:00
Nicolas Micoud 98c9dfc844
IDEMPIERE-5434 : Allow to define db view component with DISTINCT (#1505)
https://idempiere.atlassian.net/browse/IDEMPIERE-5434
2022-09-30 13:52:43 +08:00
Carlos Ruiz cdf36a785f
IDEMPIERE-4297 GardenWorld Periods 2023 to 2030 (#1491) 2022-09-21 13:44:56 +08:00
Elaine Tan 0b8b7da8e5
IDEMPIERE-5396 Replace CreateFrom form with Info Window Process (#1469)
* IDEMPIERE-5396 Replace CreateFrom form with Info Window Process
2022-09-19 18:30:24 +08:00
Carlos Ruiz 3c69ba56a4
IDEMPIERE-5415 Incomplete process log when output is > 2000 chars (#1476) 2022-09-11 15:22:52 +08:00
Jasper Siepkes 861e3ad01f
IDEMPIERE-5013 Implement HikariCP as a replacement for c3p0 (#926)
* Replaced PostgreSQL and Oracle connection pools with HikariCP.

Replaced C3P0 with HikariCP. HikariCP is a Apache licensed connection pool with substantially better performance and better resilience to failure (DB disconnects, etc.) then C3P0. Read more about it here: https://github.com/brettwooldridge/HikariCP .

Cleaned up the `getCachedConnection` method. With HikariCP there is no need to retry to obtain a connection since getting an connection will block until a free connection is available or until a timeout is reached (default 30 seconds) at which point an `SQLException` is thrown. This also removed calling `Runtime.getRuntime().runFinalization();`. HikariCP is currently configured to detect / log leaks when a connection hasn't returned to the pool for longer then 5 minutes.

Loading of pool config properties was cleaned up. Defaults are now loaded from a single file instead of defaults coming from both file and hardcoded properties. It is now also possible to specify any HikariCP property in the user pool property file.

Initialization of the datasource must happen in the `getDataSource()` method because at object construction not all JDBC config is known. However this method could (as far as I could tell) be called concurrently from multiple threads but had no mechanism to prevent initializing the DB pool multiple times. The variable in which the pool itself was stored (`m_ds`) also was not marked volatile or immutable which could lead to visibility issues. Instead of lazy initialization of the pool in the `getDataSource()` method the pool could probably better be initialized at object construction. However I wasn't able to achieve that without breakage therefor I made the initialization mechanism work correctly with concurrent invocations.

Various config options such as the `MaxStatementsPerConnection` options were removed because HikariCP doesn't support them.

* (Re)added Sequence time-out.
2022-09-10 12:21:57 +02:00
Peter Takács 005a1847e8
IDEMPIERE-5412 - Improve Dashboard Theme Look (#1471)
* IDEMPIERE-5412 - Improve Dashboard Theme Look

* IDEMPIERE-5412 - added message: NoDataAvailable

* IDEMPIERE-5412 - update default theme version
2022-09-09 14:55:54 +08:00
Peter Takács 27d01814e7
IDEMPIERE-5400 - Gauge Indicator Style and Color Improvement (#1470)
* IDEMPIERE-5400 - Gauge Indicator Style and Color Improvement

* IDEMPIERE-5400 - patch pr1470
2022-09-09 14:14:50 +08:00
Peter Takács 1f4a23657a
IDEMPIERE-5400 - Dashboard Goal Content should render as single Gauge Indicator (#1458)
* IDEMPIERE-5400 - Dashboard Goal Content should render as single Gauge Indicator

* IDEMPIERE-5400 - better css responsivity

* IDEMPIERE-5400 - add update goal

* IDEMPIERE-5400 - fixes

* IDEMPIERE-5400 - resolved conflict, migration fix

* IDEMPIERE-5400 - fix bad merge
2022-09-07 21:40:29 +08:00
Peter Takács ee3476c3eb
IDEMPIERE-5409 - Dashboard Content - Maximizable checkbox (#1467)
* IDEMPIERE-5409 - Dashboard Content - Maximizable checkbox

* IDEMPIERE-5409 - IsMaximizable default 'Y'

* IDEMPIERE-5393 - fixes

* IDEMPIERE-5409 - fixed script name
2022-09-07 17:00:18 +08:00
Peter Takács e528c6f8cb
IDEMPIERE-5389 - Dashboard row layout (#1448)
* IDEMPIERE-5389 - Dashboard row layout

* IDEMPIERE-5389 - taking changes related to ticket 5393

* IDEMPIERE-5389 - added Flex Grow to Preference

* IDEMPIERE-5389 - fixing gadget heights

* IDEMPIERE-5389 - center alignment for Status Line

* IDEMPIERE-5389 - fall back to column layout

* IDEMPIERE-5389 - pr1448 patch

* IDEMPIERE-5389 - FixOracleMigration patch
2022-08-30 10:11:42 +02:00
Peter Takács 0aaf904e34
IDEMPIERE-5393 - Allow rendering status line as widget/gadget in dashboard (#1449)
* IDEMPIERE-5393 - Allow rendering status line as widget/gadget in dashboard

* IDEMPIERE-5393 - css class for status line

* IDEMPIERE-5393 - update default theme version
2022-08-24 15:49:06 +08:00
Peter Takács e670ebbd14
IDEMPIERE-5302 - Drill Assistant Feature with re-generated migration scripts (#1390)
* IDEMPIERE-5302 - Drill Assistant Feature with re-generated migration scripts

* IDEMPIERE-5302 - added IsShowInDrillOptions, ID fixes

* IDEMPIERE-5302 - added IsShowInDrillOptions default Y

* IDEMPIERE-5302 - creating Table Print Formats on Run Report

* IDEMPIERE-5302 - applied pr1390_fixes patch

* IDEMPIERE-5302 - applied pr1390_badimports patch
2022-08-17 18:08:45 +08:00
Alan Lescano 11962e1713
IDEMPIERE-5259 Labels feature (#1357)
* IDEMPIERE-5259 Labels feature
* IDEMPIERE-5259 Update the theme version timestamp
* IDEMPIERE-5259 Better javadoc
* Update 202205131118_IDEMPIERE-5259.sql
* Update 202205131118_IDEMPIERE-5259.sql
* IDEMPIERE-5259 New window Label Assignment
* IDEMPIERE-5259 Toggle issue
* IDEMPIERE-5259 MSysConfig is ordered alphabetically
* IDEMPIERE-5259 Default SysConfig
* IDEMPIERE-5259 Avoid duplicated records
Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-08-01 21:51:38 +02:00
Peter Takács c62a9ad066
IDEMPIERE-1965 - Implement Generate Invoices (manual) as Info Window (#1400)
* IDEMPIERE-1965 - Implement Generate Invoices (manual) as Info Window
* IDEMPIERE-1965 - fixes
* IDEMPIERE-1965 - Deprecate Form
* IDEMPIERE-1965 - backwards compatibility
* IDEMPIERE-1965 - vendor RMA form legacy
* IDEMPIERE-1965 - merge patch
* IDEMPIERE-1965 - 1965_PR patch
2022-08-01 20:41:39 +02:00
hengsin 9f22430aad
IDEMPIERE-5359 Unit test not working with Oracle (#1414) 2022-07-31 19:22:06 +02:00
Peter Takács 5918702166
IDEMPIERE-1963 - vendor RMA form legacy (#1409) 2022-07-25 16:13:56 +08:00
Carlos Ruiz cd42ba5220
IDEMPIERE-5353 Entity type field in the Column tab becomes read-only when you enter a wrong value (#1405)
IDEMPIERE-5353 # resolve
2022-07-21 17:08:05 +02:00
Nicolas Micoud 58027792d8
IDEMPIERE-5342 : Ability to hide the title of the chart when displaye… (#1392)
* IDEMPIERE-5342 : Ability to hide the title of the chart when displayed on Home page
2022-07-21 20:09:11 +08:00
Carlos Ruiz b0e7389f0a
IDEMPIERE-1963 Implement Generate Shipments (manual) as Info Window / Oracle fix (#1404) 2022-07-20 20:10:53 +02:00
Carlos Ruiz 96e0870efd
IDEMPIERE-1963 Implement Generate Shipments (manual) as Info Window / fixes (#1403) 2022-07-20 14:48:50 +02:00
Peter Takács c001169a5f
Idempiere-1963 - Implement Generate Shipments (manual) as Info Window (#1394)
* IDEMPIERE-1963 - Implement Generate Shipments (manual) as Info Window

* IDEMPIERE-1963 - reverting changes commited by mistake

* IDEMPIERE-1963 - Implement Generate Shipments (manual) as Info Window

* IDEMPIERE-1963 - patches for fixes and deprecation
2022-07-20 14:47:32 +02:00
Deepak Pansheriya dc67ae816d
IDEMPIERE-5295: Correcting oracle migration script (#1389)
* IDEMPIERE-5295: Correcting oracle migration script

* Update 202206282000_IDEMPIERE-5295.sql

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-07-19 14:03:39 +02:00
Carlos Ruiz e4f4999220
IDEMPIERE-5295 Trial Balance Report creates wrong Opening Balance / fix oracle script - caused by mismatch in primary key name IDEMPIERE-5227 (#1387) 2022-07-08 13:48:56 +02:00
Carlos Ruiz 1846439e92 Revert "IDEMPIERE-5302 - Drill Assistant Feature (#1345)"
This reverts commit 809e3ae734.
2022-07-08 13:25:19 +02:00
Deepak Pansheriya 9a64a1a11c
IDEMPIERE-5295: Trial Balance Report creates Opening balance per orga… (#1378)
* IDEMPIERE-5295: Trial Balance Report creates Opening balance per organization and setting opening date day before from date.

* IDEMPIERE-5295: Correction as per Hengsin's code review vomment.

* IDEMPIERE-5295: Opening Balance should be on first day of Period

* IDEMPIERE-5295: Removed unused import

* IDEMPIERE-5295: Fixing report view is not set on default print format
Co-authored-by: hengsin@gmail.com
2022-07-06 19:53:15 +08:00
Peter Takács 809e3ae734
IDEMPIERE-5302 - Drill Assistant Feature (#1345)
* IDEMPIERE-5302 - Drill Assistant Feature
2022-06-30 20:08:22 +08:00
Peter Takács 5303a10da2
IDEMPIERE-5319 - Delete Record with Confirmation Logic (#1371)
* IDEMPIERE-5319 - Delete Record with Confirmation Logic

* IDEMPIERE-5319 - modified listener for more correct behavior

* IDEMPIERE-5319 - modified listener for more correct behavior

* IDEMPIERE-5319 - improved validation

* IDEMPIERE-5319 - exception, message translation, removed new buttons

* IDEMPIERE-5319 - merged validation on close
2022-06-27 11:26:38 +02:00
Peter Takács 1f9955fcc9
IDEMPIERE-2058 - ** New Report ** - improve for handling Forms too (#1335)
* IDEMPIERE-2058 - ** New Report ** - improve for handling Forms too

* IDEMPIERE-2058 - error fixed

* IDEMPIERE-2058 - dialogs added

* IDEMPIERE-2058 - latest WIP commit until final design stated

* IDEMPIERE-2058 - added cancel button, mandatory handling
2022-06-25 15:07:07 +02:00
iDempierePatch 06c41d2c68
IDEMPIERE-5300 ErrorMsg doesn't show full message + LifeTime Msg conf… (#1342)
* IDEMPIERE-5300 ErrorMsg doesn't show full message + LifeTime Msg configurable

* IDEMPIERE-5300 ErrorMsg doesn't show full message + LifeTime Msg configurable / peer review / solve issues requested by Heng Sin

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-06-24 16:34:19 +08:00
Layda Salas 34458fa8a1
IDEMPIERE-5245-ad_message Fix typos in dictionary (#1361)
* IDEMPIERE-5245-ad_message Fix typos in dictionary
2022-06-09 17:41:22 +02:00
PeterTakacs300 0dd6c2b4a9
IDEMPIERE-5304 - Missing Message from Payment (#1346)
* IDEMPIERE-5304 - Missing Message from Payment

* IDEMPIERE-5304 - replaced message type and Msg.translate method
2022-05-31 15:25:50 +08:00
PeterTakacs300 13e0c8e1a4
IDEMPIERE-5275 - Tabular Report Re-Query button/close paramater window (#1306)
* IDEMPIERE-5275 - Tabular Report Re-Query button/close paramater window

* IDEMPIERE-5275 - fix bug with asynch. threads

* IDEMPIERE-5275 - BusyMask not showing correctly fix

* IDEMPIERE-5275 - icons added

* IDEMPIERE-5275 - sysconfig added

* IDEMPIERE-5275 - patch 1306_PeerReview applied

* IDEMPIERE-5275 - requested changes applied

* IDEMPIERE-5275 - small fixes

* IDEMPIERE-5275 - fixed wrong merge
2022-05-13 22:14:59 +08:00
Carlos Ruiz 6edaf7374d
IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing / fix oracle script (#1330) 2022-05-13 11:21:50 +02:00
hengsin a41aeb2205
IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing (#1277)
* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

* IDEMPIERE-5057 Implement Deductible and non deductible input tax for purchasing and costing

- Fix rounding error
2022-05-12 11:12:05 +02:00
hengsin 9e43a36862
IDEMPIERE-5260 Enhance Discount Schema for Fixed Pricing (#1313)
* IDEMPIERE-5260 Enhance Discount Schema for Fixed Pricing

* IDEMPIERE-5260 Enhance Discount Schema for Fixed Pricing

- Fix unit test error.
2022-05-11 18:39:58 +02:00
hengsin a8958bf29d
IDEMPIERE-5261 Workflow EMail notification enhancement (#1299)
* IDEMPIERE-5261 Workflow EMail notification enhancement

* Update 202204190945_IDEMPIERE-5261.sql

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-05-05 18:51:11 +02:00
hengsin e91aa9d0d3
IDEMPIERE-5082 Drop Shipment: Pass shipper and tracking number from MR to Customer Shipment (#1284) 2022-05-04 23:05:54 +02:00
Layda Salas c648eafa05
IDEMPIERE-5245 Fix typos in dictionary #resolve (#1312)
* IDEMPIERE-5245 Fix typos in dictionary #resolve

* Update 202205031611_IDEMPIERE-5245.sql

* Update 202205031611_IDEMPIERE-5245.sql

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-05-04 12:36:06 +02:00
hengsin 3f6ec68f37
IDEMPIERE-5088 Implement Bank Transfer as Transactional Document like… (#1281)
* IDEMPIERE-5088 Implement Bank Transfer as Transactional Document like Payment

* IDEMPIERE-5088 Implement Bank Transfer as Transactional Document like Payment

- default to charge and to bpartner from the corresponding from fields
- add DateAcct, C_ConversionType_ID and IsOverrideCurrencyRate columns
- remove mandatory org linked bp requirement
- rename window to Bank/Cash Transfer and deactivate existing Bank/Cash
Transfer process.

* IDEMPIERE-5088 Change Bank Transfer Process to use (optionally) the new document

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-05-01 11:22:32 +08:00
hengsin 13b37c4acc
IDEMPIERE-5093 Scheduler cron pattern scheduling is always using serv… (#1270)
* IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone

* minor fix for oracle/202203240830_IDEMPIERE-5093.sql

* IDEMPIERE-5093 cheduler cron pattern scheduling is always using server time zone

- add time zone comment for cronpattern field
- use fix format for elapsed time (day'hour:minutes:seconds.millisecond)
- use time zone formatting at server monitor
- include etc/gmt* timezone id. fix handling of invalid user input
- fix wrong editor (date) use for timestamp with time zone field

* IDEMPIERE-5093 cheduler cron pattern scheduling is always using server time zone

- Fix MSchedule.getNextRunMS call.

* IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone

- add T_Timestamp to Test table and window.
- fix date time editor doesn't capture seconds for timestamp with time
zone.
- date time editor: use tenant time zone (if set), fallback to browser
time zone.
- date time editor: fix processing of timestamp with time zone value.
- time zone editor: drop the confusing etc/gmt* entries and support
entry of GMT(+/-)hh:mm custom zone id.

* IDEMPIERE-5093 Scheduler cron pattern scheduling is always using server time zone

Fix NPE

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-04-22 21:28:51 +02:00
Nicolas Micoud d6bd0b2247
IDEMPIERE-5247 : ReportLineSet_Copy do not copy Operands (#1271) 2022-03-31 19:33:56 +02:00
Layda Salas d949963135
IDEMPIERE-5243 More columns to increase length #resolve (#1272)
* IDEMPIERE-5243 More columns to increase length #resolve

* IDEMPIERE-5243 More columns to increase length - change field clob #resolve
2022-03-31 18:46:24 +02:00