Commit Graph

13917 Commits

Author SHA1 Message Date
Carlos Ruiz 2ab2211f81
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#468)
Extracting from @hengsin pull request 465
Fixes cross tenant readings in MUser MUserDefWin and MWorkflow
2020-12-16 09:08:11 +08:00
Carlos Ruiz 03b4a1e878
IDEMPIERE-4580 Refactor about credits (#433)
* IDEMPIERE-4580 Refactor about credits

Implement Credits as an HTML file visible in root folder
Change size of about window
2020-12-15 15:54:51 +01:00
hengsin 1df6f63341
IDEMPIERE-4598 Disable obsolete IsServer* fields (#467)
* IDEMPIERE-4598 Disable obsolete IsServer* fields

* IDEMPIERE-4598 Disable obsolete IsServer* fields

- Fix wrong migration script name
2020-12-14 15:10:29 +01:00
Nicolas Micoud d9f0c43af8
IDEMPIERE-4597 : Make sure ConvertLead process generates an active BPartner (#464) 2020-12-14 14:56:32 +01:00
hengsin 5e977d427c
IDEMPIERE-4287 Cache API not thread safe and inconsistent with context parameter (#466)
- Fix PO immutable exception with Workflow Validate process.
2020-12-14 14:53:55 +01:00
Carlos Ruiz 60007e07e6
IDEMPIERE-4521 Release 8.1 (#462)
Change IRC to mattermost
2020-12-13 17:00:04 +08:00
Carlos Ruiz fd947f4fef
IDEMPIERE-4581 Model generator should isn't dialog it should be window (#463)
* IDEMPIERE-4581 Model generator should isn't dialog it should be window

use shutdown asyn to shutdown framework when close Model generator window

one unhappy thing remain:
when use -console then framework is shutdown but jdk still hang because "pipe-gosh --login --noshutdown" still live (for https://bugs.eclipse.org/bugs/show_bug.cgi?id=362412)
work-around: use -console 1234
by that way we can't access osgi command from console but can use "telnet localhost 1234" to use osgi command

* IDEMPIERE-4581 Model generator should isn't dialog it should be window

Fix problem about program not closing
Improve layout

Co-authored-by: hieplq <hieplq@hasuvimex.vn>
2020-12-13 07:57:33 +08:00
Carlos Ruiz 5da1785572
IDEMPIERE-4596 Cannot create a product and an inventory document in t… (#459)
* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction

WIP - commit failing unit test

* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction

Implement solution suggested by @hengsin

* minor fix comment
2020-12-12 16:12:31 +01:00
hengsin bffb3166c6
IDEMPIERE-4528 Update Js Library (#461)
* IDEMPIERE-4528 Update Js Library

Fix session timeout page broken.

* IDEMPIERE-4528 Update Js Library

add version info for keylistener component
2020-12-12 12:18:36 +01:00
Nicolas Micoud a7fbe30441
IDEMPIERE-4584 : InfoProduct throws "Attempted to access nonexistent … (#460)
* IDEMPIERE-4584 : InfoProduct throws "Attempted to access nonexistent ListModelTable field at 2, -1" if no IsInstanceAttribute column

* IDEMPIERE-4584 : fix test of column index

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2020-12-12 13:47:06 +08:00
Carlos Ruiz 3013819d5a
IDEMPIERE-4595 Autofill process parameters with smart defaults (#458)
Implement same callouts as in AD_Column
2020-12-12 06:50:11 +08:00
Carlos Ruiz 9d6de521f2
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#456)
Extracting from @hengsin pull request 453
2020-12-11 16:48:16 +08:00
Carlos Ruiz f2c5ec429b
IDEMPIERE-4589 BUGS on PERFORMANCE ANALYSIS -> Accounting Rules ->Accounting Setup (#457) 2020-12-11 14:40:58 +08:00
hengsin 6abbc4c9da
IDEMPIERE-4594 Payment Selection (Manual) - NPE When Payment Date is empty (#455)
Fix NPE
2020-12-10 16:32:07 +01:00
Carlos Ruiz 4d96ac1f8e
IDEMPIERE-4593 Error completing a Standard Sales Order with Shipper and Calculated Freight Cost Rule (#454) 2020-12-10 13:57:25 +01:00
hengsin e017046dac
IDEMPIERE-4590 Scheduler Window: Start Scheduler action change AD_Client_ID to 0 when HazelCast Service is Down/Disable (#449) 2020-12-10 11:54:39 +01:00
hengsin 6e380b3dfb
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#451)
Fix missing downarrow for breadcrumb.
2020-12-10 11:26:36 +01:00
hieplq 1989c0c011
IDEMPIERE-4360 ignore file generate by sonarlint (#452)
* IDEMPIERE-4360 ignore file generate by sonarlint
2020-12-10 11:16:44 +01:00
Carlos Ruiz 350f101d0c
IDEMPIERE-4289 Implement Support for JUnit5 Unit Testing (#447)
Fix launcher to avoid adding all custom plugins every time I try to execute it
2020-12-10 06:25:30 +08:00
Carlos Ruiz 6fa0052834
IDEMPIERE-4588 Error in MOrder.setC_DocTypeTarget_ID (String DocSubTypeSO_x) when IsDefault=Y in a Purchase Order (#446) 2020-12-09 20:49:15 +01:00
Carlos Ruiz d654ed5791
IDEMPIERE-4587 Wrong ordered qty when reactivating a purchase order and setting a line to zero (#445) 2020-12-09 20:49:01 +01:00
Carlos Ruiz 9ed69583e8
IDEMPIERE-4297 Improve test data (#444)
* IDEMPIERE-4297 Improve test data

Add new document types in Garden World:
- Warehouse Purchase Order -> creates and matches automatically material receipt
- Point of Purchase Order -> creates and matches automatically material receipt, invoice, it also creates a payment and allocation when payment rule is Cash

* Fix IsDefault=N
2020-12-09 20:48:34 +01:00
Carlos Ruiz 34fec8c156
IDEMPIERE-4591 Load Bank Statement is not working in multi-tenant environments (#450)
IDEMPIERE-4268
2020-12-09 19:00:41 +01:00
Carlos Ruiz 46bc0e022f
IDEMPIERE-4358 Processes to drop some objects from database (#448)
Add process to rename a column directly from the Table and Column window
2020-12-09 15:31:13 +01:00
Carlos Ruiz 4c66c0018d
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#443)
Implement thread safe mechanism
https://mattermost.idempiere.org/idempiere/pl/hmpd8freutbhbgcjr9tu6ntitr
2020-12-09 14:28:49 +01:00
Carlos Ruiz d7bac68f94
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#442)
Problem when creating a preference with SuperUser in System, and then trying to save the same preference in GardenWorld (for example changing the height of a window)
2020-12-07 23:00:14 +08:00
Carlos Ruiz 416d92a292
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#441)
Fix problem reported by ken.wang at
https://mattermost.idempiere.org/idempiere/pl/3wmpzg1o5i88dec5pifkjd3qfe
2020-12-07 22:59:23 +08:00
hieplq 58c6716253
IDEMPIERE-4360 exclude generate and test code to speed up (#440)
* IDEMPIERE-4360 add sonarcloud.io

* IDEMPIERE-4360 add sonarcloud.io (update properties)

* IDEMPIERE-4360 add sonarcloud.io (optimize)

1. when use matrix for codeql-action then job of javascript run same job of java (mvn, sonar)
so don't use matrix do define separate job let javascript job faster a lot
2. reduce maven log and sonar log from info to warn
3. move project info from pom to yml let fork central place customize CI

* IDEMPIERE-4360 turn off sonar at PR because not yet support

https://stackoverflow.com/a/39720346

* IDEMPIERE-4360 exclude generate and test code to speed up

* IDEMPIERE-4360 add sonarcloud.io (optimize)

1. parallel sonar and code QL
2. parameter for repository owner (org)
2020-12-06 16:50:14 +01:00
hengsin 9d02ecaadb
IDEMPIERE-4387 Cannot select C&W Business Partner in Multi Select Search (#438)
- base on patch from Carlos and hints from hieplq
2020-12-05 16:38:36 +01:00
hieplq fb053003a9
IDEMPIERE-4360 turn off sonar at PR because not yet support (#439)
* IDEMPIERE-4360 add sonarcloud.io

* IDEMPIERE-4360 add sonarcloud.io (update properties)

* IDEMPIERE-4360 add sonarcloud.io (optimize)

1. when use matrix for codeql-action then job of javascript run same job of java (mvn, sonar)
so don't use matrix do define separate job let javascript job faster a lot
2. reduce maven log and sonar log from info to warn
3. move project info from pom to yml let fork central place customize CI

* IDEMPIERE-4360 turn off sonar at PR because not yet support

https://stackoverflow.com/a/39720346
2020-12-05 16:33:26 +01:00
Carlos Ruiz 02ce1f3c1f
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#436)
Two more points found about cross tenant readin in MClient and MUser
2020-12-05 12:42:43 +08:00
hengsin 894ceb8c4f
IDEMPIERE-4101 [Chosenbox] Multi select don't work in Firefox (#435)
- add display of button
- fix dropdown doesn't render properly at Firefox
2020-12-04 17:52:10 +01:00
Carlos Ruiz b9964ce7ab
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#432)
Fixes:
org.adempiere.exceptions.AdempiereException: Cross tenant PO reading request detected from session 1009629 for table AD_UserDef_Win Record_ID=1000002
	at org.compiere.model.PO.checkValidClient(PO.java:5000)
	at org.compiere.model.PO.<init>(PO.java:212)
	at org.adempiere.model.GenericPO.<init>(GenericPO.java:81)
	at org.compiere.model.MTable.getPO(MTable.java:598)
	at org.compiere.model.Query.list(Query.java:286)
	at org.compiere.model.MUserDefWin.getAll(MUserDefWin.java:107)
	at org.compiere.model.MUserDefWin.getBestMatch(MUserDefWin.java:160)
2020-12-03 12:55:15 +01:00
hengsin c3aafb2a4f
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#431)
- Fix broken menu icon for html report
- Fix an issue with switching theme
2020-12-03 11:58:45 +01:00
Carlos Ruiz a833e778a6
IDEMPIERE-4468 Pass the current value of numberbox to the textfield of calculator (#430)
IDEMPIERE-2003 Capturing wrong numbers with numeric keypad when decimal separator is not dot

- Restore and improve functionality that process dot keypad within the number fields (deleted by mistake in c954a055b2)
2020-12-02 22:16:31 +01:00
Deepak Pansheriya 8b672a3a51
IDEMPIERE-2999 : refactoring as per Hengsin's review comments (#427)
* IDEMPIERE-2999 : refactoring as per Hengsin's review comments

* IDEMPIERE-2999: Fixing compilation issue

* IDEMPIERE-2999: Fixing as per Hengsin'e review
2020-12-02 22:59:23 +08:00
Carlos Ruiz acf59cccbb
IDEMPIERE-4579 Function altercolumn fails when a role name has a dash (#429) 2020-12-02 15:34:25 +01:00
Carlos Ruiz bf65636e22
IDEMPIERE-4577 Problem creating an invoice vendor negative after the … (#428)
* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment

* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment

Add unit test
2020-12-02 21:08:41 +08:00
hieplq 87e55ae08f
IDEMPIERE-4360 add sonarcloud.io (optimize) (#426)
* IDEMPIERE-4360 add sonarcloud.io

* IDEMPIERE-4360 add sonarcloud.io (update properties)

* IDEMPIERE-4360 add sonarcloud.io (optimize)

1. when use matrix for codeql-action then job of javascript run same job of java (mvn, sonar)
so don't use matrix do define separate job let javascript job faster a lot
2. reduce maven log and sonar log from info to warn
3. move project info from pom to yml let fork central place customize CI
2020-12-01 10:38:48 +01:00
Carlos Ruiz 8cf16ba137
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#425)
Implement cross tenant check on foreign keys for insert and update
2020-12-01 07:16:22 +08:00
Carlos Ruiz 42854cfb0f
IDEMPIERE-4561 Font Icons not used in several points (#423) 2020-12-01 07:12:28 +08:00
Carlos Ruiz 3a9b932df4
IDEMPIERE-4268 Fix recursive call to PO (#424)
* IDEMPIERE-4268 Fix recursive call to PO

Found a case where PO.checkValidClient fails, and then because of log.severe it tries to create a record with MIssue, and the PO.checkValidClient fails in MIssue, and is called recursively until it fails with a "Trx.run: Transaction timeout."

* IDEMPIERE-4268

- Improve error message
- Fix problem with valid cross-tenant reads in MRegion and MWorkflow
2020-11-30 21:36:51 +01:00
hengsin 5d236de30c
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#420)
* IDEMPIERE-4421 Html asset versioning should allow fluent deployment

use classpath loading and lang-addon versioning for theme resources

* IDEMPIERE-4421 Html asset versioning should allow fluent deployment

Incorporate backward compatibility patch from Carlos.
2020-11-30 15:33:23 +01:00
hieplq 60e584655c
Idempiere 4360 (#422)
* IDEMPIERE-4360 add sonarcloud.io

* IDEMPIERE-4360 add sonarcloud.io (update properties)
2020-11-30 19:19:49 +07:00
hieplq 5f30b001e0
IDEMPIERE-4360 add sonarcloud.io (#421) 2020-11-30 09:37:49 +07:00
Carlos Ruiz 0eb4986513
IDEMPIERE-4575 Cannot complete Material Receipt from negative PO (#419) 2020-11-28 07:09:39 +08:00
Carlos Ruiz 71a2ee3fe7
IDEMPIERE-4268 Fix issue with change client (#418)
Fix problem changing client in role panel when more than 2 clients
2020-11-27 20:24:21 +01:00
Diego Ruiz 386610f379
IDEMPIERE-4394 Date Field font color is not consistent with other readonly fields (#417) 2020-11-27 18:51:30 +01:00
hengsin 0d381faf99
IDEMPIERE-4187 implement the usage of workflows in processes (#416)
- incorporate suggestion from Martin Schönbeck to unit test
2020-11-26 14:17:40 +01:00
Carlos Ruiz d885aaf4e6
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#415)
Co-authored-by: Heng Sin Low <hlow@trekglobal.com>
2020-11-26 20:22:18 +08:00