Commit Graph

10 Commits

Author SHA1 Message Date
Jasper Siepkes 861e3ad01f
IDEMPIERE-5013 Implement HikariCP as a replacement for c3p0 (#926)
* Replaced PostgreSQL and Oracle connection pools with HikariCP.

Replaced C3P0 with HikariCP. HikariCP is a Apache licensed connection pool with substantially better performance and better resilience to failure (DB disconnects, etc.) then C3P0. Read more about it here: https://github.com/brettwooldridge/HikariCP .

Cleaned up the `getCachedConnection` method. With HikariCP there is no need to retry to obtain a connection since getting an connection will block until a free connection is available or until a timeout is reached (default 30 seconds) at which point an `SQLException` is thrown. This also removed calling `Runtime.getRuntime().runFinalization();`. HikariCP is currently configured to detect / log leaks when a connection hasn't returned to the pool for longer then 5 minutes.

Loading of pool config properties was cleaned up. Defaults are now loaded from a single file instead of defaults coming from both file and hardcoded properties. It is now also possible to specify any HikariCP property in the user pool property file.

Initialization of the datasource must happen in the `getDataSource()` method because at object construction not all JDBC config is known. However this method could (as far as I could tell) be called concurrently from multiple threads but had no mechanism to prevent initializing the DB pool multiple times. The variable in which the pool itself was stored (`m_ds`) also was not marked volatile or immutable which could lead to visibility issues. Instead of lazy initialization of the pool in the `getDataSource()` method the pool could probably better be initialized at object construction. However I wasn't able to achieve that without breakage therefor I made the initialization mechanism work correctly with concurrent invocations.

Various config options such as the `MaxStatementsPerConnection` options were removed because HikariCP doesn't support them.

* (Re)added Sequence time-out.
2022-09-10 12:21:57 +02:00
hieplq 58258ad506
Idempiere-4492 update library (eclipse-4.17, jasper 6-15, jetty-9.4.33, atmosphere-2.6.4) (#331)
* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 update atmosphere to 2.5.15

* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 (update configuration)

update to default jetty configuration
delete unused configuration (alpn, http2,..)

* IDEMPIERE-4492 update orbit eclipse repository to 4.17

* IDEMPIERE-4492 update orbit eclipse repository to 4.17 (on parent pom)

* IDEMPIERE-4492 update jasper to 6.15.0

* IDEMPIERE-4492 update jasper to 6.15.0 (IDEMPIERE-4504)

get rid of bundle "org.w3c.dom.events version 3.0.0" by use old version of org.w3c.dom.smil

note: on target platform a bundle has multi version then tycho can pickup correct version define on feature (tab included plugins, field version)
but on eclipse when sync launching from .product it don't respect that value, always set highest version to bundle
workaround: on target platform manual un-select bundle org.w3c.dom.smil 1.0.1

* IDEMPIERE-4492 update atmosphere to 2.6.4

* IDEMPIERE-4492 refine target platform

use targetplatform-dsl to generate target platform https://github.com/eclipse-cbi/targetplatform-dsl
   + don't need to care update bundle version when update repository
   + at moment org.idempiere.eclipse.platform-feature include some feature form eclipse repository
     so target has to include that feature so target platform will include all bundler request by feature and bundle request by plugins of that feature and so on (ever optional
     so it make target content has more plugins than what we use on project
     next step will convert include feature to include plugins to define only what we used

* IDEMPIERE-4492 refine target platform (continue)

don't include framework feature, use include plugins to void load transitive dependency so minimize target flatform
remove some unused feature from idempiere product

* IDEMPIERE-4492 update c3p0 and database jdbc (patch from Carlos)
2020-10-31 06:53:36 +08:00
hieplq d7808da56a IDEMPIERE-3531:setting output build, jdk follow project convert from pure plugin to maven
a mavent project convert from plugin have flow default rule
   1. maven project prefer setting JRE to Execution environment, so .classpath is updated
   2. java class compliment to target/classes/, so build.propertie is updated
   3. JDK compliance configuration setting per project (only this option), so .settings/org.eclipse.jdt.core.prefs is created

extra setting about warning done manual to resolved
https://bugs.eclipse.org/bugs/show_bug.cgi?id=367431

   it happend on bundle use non-standard java package
      org.adempiere.base/.settings/org.eclipse.jdt.core.prefs
      org.adempiere.ui.swing/.settings/org.eclipse.jdt.core.prefs

   on org.adempiere.server, old method add accessrules to classpathentry don't work for maven build.
   so change to warning method make it consitent with other
      org.adempiere.server/.settings/org.eclipse.jdt.core.prefs
2018-02-03 01:39:47 +07:00
hieplq b6d9886732 IDEMPIERE-3531:standard lib folder
on all project, put library into lib folder, so easy apply parametrize
remove some unuse (don't see reference) library
2018-02-02 13:47:07 +07:00
hieplq 1e5df4c39a IDEMPIERE-2907:update library (zk, c3p0)
update c3p0 0.9.5
2015-10-25 22:43:08 +07:00
Carlos Ruiz 4803643ab2 IDEMPIERE-2245 Platform Upgrade for r3 2014-10-29 13:36:29 -05:00
Heng Sin Low e30bded686 IDEMPIERE-770 Upgrade c3p0 to 0.9.2 2013-03-19 13:31:55 +08:00
Carlos Ruiz 0646e28b82 IDEMPIERE-455 Discover and fix FindBugs problems / Eclipse warning -> build 2012-12-21 10:05:17 -05:00
Heng Sin Low d4e9ae0656 IDEMPIERE-359 Add OSGi Service support for existing extension point. Move more core services to OSGi service. 2012-11-08 17:36:50 +08:00
Heng Sin Low 83715fa436 Refactoring to make project and folder name the same as the bundle symbolic name. Migrate to use eclipse feature and product configuration ( build is broken, to fix later ) 2010-09-29 15:25:34 +08:00