Commit Graph

3586 Commits

Author SHA1 Message Date
Zuhri Utama 34485f97f8
IDEMPIERE-5862 : Move Always Updatable Payment Rule to Dictionary (#2023)
* IDEMPIERE-5862 : Move Always Updatable Payment Rule to Dictionary

* Update oracle/202309261054_IDEMPIERE-5862.sql

* Update postgresql/202309261054_IDEMPIERE-5862.sql

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-09-26 13:49:25 +02:00
hieplq d28c6eb9d8
IDEMPIERE-5849:MRole.getDefault make phantom role on cache (#2020)
patch from Heng Sin

Co-authored-by: hengsin <hengsin@gmail.com>
2023-09-22 14:17:34 +08:00
hengsin 6840b8aeb6
IDEMPIERE-5346 : Adding SSO support (#2018)
- peer review
2023-09-21 16:48:30 +08:00
Deepak Pansheriya 680f9f3757
IDEMPIERE-5346 : Adding SSO support (#1571)
* IDEMPIERE-5346 : Adding SSO support

* IDEMPIERE-5346 : Fix as per peer review feedback.
Valid user should have password not null
removing #SSO_IS_ALREADY_AUTHENTICATE context variable due to security risk
Cross site scripting issue on error.htm
Making show role panel as system configurable
Adding language selection on role panel
Adding SSO support on iDempiere monitor and osgi console

* IDEMPIERE-5346: Redirect to console using static URL to avoid security vulenarabilit

* Committing patch from Carlos pr1571PR

* IDEMPIERE-5565: fixing NPE issue on Role change

* IDEMPIERE-5346: Appling pr1571PR2 from Carlos

* 1. IDEMPIERE-5346: Fix idempiereMonitor goes in a loop of sign-in
- Fix NPE when changing role
- Fix NPE when a user with single role & sysconfig: SSO_SELECT_ROLE is 'N'

* IDEMPIERE-5346 : IDempiere Monitor, use out of box login when SSO is not configured.

* IDEMPIERE-5346: Adding Authorization type on User and Tenant window. Created /webui/admin page for login with application credential.

* IDEMPIERE-5346: Implementing Hengsi's Code review comments
Showing meaning full error when Identity Provider returns error
In SSO filter, ignoreing css, zkau, images and resource URL
Correcting typo in Principal name.
Updated Documentation

* IDEMPIERE-5346 : Fixed documentation, typo and pending review comments

* IDEMPIERE-5346: Use token & SSO principal service to validate in Login.GetClient

* IDEMPIERE-5346: Remove the Domain URL column and refactor the code.

* IDEMPIERE-5346: Adding flag ENABLE_SSO_IDEMPIERE_MONITOR and ENABLE_SSO_OSGI_CONSOLE, using cache for SSOService, defaulting Authentication type on client to “Application and SSO”

* IDEMPIERE-5346: Fixed issue of User SSO type not respected and support for Zoom URL
2023-09-21 16:43:49 +08:00
Carlos Ruiz 7c486df524
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#2013)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

- Fix for MAttachment.get
- discovered while testing rest endpoing api/v1/models/testuu/{uuid}/attachments/zip

* - remove the deprecated message
- use UU just when there is no ID
2023-09-19 22:24:09 +08:00
Carlos Ruiz 7e5a1d89ee
Revert "IDEMPIERE-5826 iDempiere REST can insert/update an invalid foreign key (#1969)" (#2014)
This reverts commit db833e3665.
2023-09-19 22:21:08 +08:00
Nicolas Micoud 4c4981533e
IDEMPIERE-5856: MOrder.setBPartner is not using IsSOTrx for PaymentRule (#2012)
* IDEMPIERE-5856: MOrder.setBPartner is not using IsSOTrx for PaymentRule

* IDEMPIERE-5856: MOrder.setBPartner is not using IsSOTrx for PaymentRule

serial update

* IDEMPIERE-5856: MOrder.setBPartner is not using IsSOTrx for PaymentRule

 if getPaymentRulePO() is null, we fall back to getPaymentRule()
2023-09-19 21:04:18 +08:00
Zuhri Utama 1efe7a4ac5
IDEMPIERE-4697 : temporary filename "adempiere_" (#2000)
* IDEMPIERE-4697 : get temp filename based on config "TEMP_FILENAME" if exists

* IDEMPIERE-4697 : temporary filename "adempiere_"

* IDEMPIERE-4697 : set default value and change from adempiere to idempiere
2023-09-18 14:44:21 +02:00
Carlos Ruiz d665c2b051
IDEMPIERE-5854 Error when trying to call ServerReportCtl.runJasperProcess with a process info without a transaction name (#2009) 2023-09-15 14:21:34 +02:00
Carlos Ruiz 209663d32a
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#2008)
- MappedModelFactory check and register UUID constructor
2023-09-14 20:18:46 +08:00
Vitor Henrique Dos Santos d7d4504271
IDEMPIERE-5852 Change broadcastmessage column size (#2002)
* IDEMPIERE-5852 Change broadcastmessage column size

* IDEMPIERE-5852 Patch applied
2023-09-14 14:13:24 +02:00
hengsin 39d159d44a
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - AD_PInstance (#2005)
- Fix unit test errors
2023-09-13 12:48:54 +08:00
Carlos Ruiz 7c8fe24435
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - AD_PInstance (#2003)
- Implement support to run processes on UUID based tables
- Added SvrProcess.getRecord_UU and getRecord_UUs support
- Added TestUUChangeActive process as toolbar button on "Test UU Based Table" window - supports single and multi
- Added AD_PInstance.AD_Table_ID and AD_PInstance.Record_UU
- NOTE: the migration script tries the best to fill AD_PInstance.AD_Table_ID from different sources, but at the end is very possible that some records will be left with empty table
- The MPInstance constructors that don't manage AD_Table_ID were marked as deprecated to ease discovering the missing parts in plugins
2023-09-13 10:59:21 +08:00
Carlos Ruiz c0a1756043
IDEMPIERE-5843 System support users (like SuperUser) cannot see (fix) preferences on tenants (#1994)
* IDEMPIERE-5843 System support users (like SuperUser) cannot see (fix) preferences on tenants (#1992)

IDEMPIERE-5174 / Revert changes from IDEMPIERE-4386

* - remove the same now unnecessary method on MMFARegistration
2023-09-06 09:44:09 +08:00
Nicolas Micoud 51c3bf5e0c
IDEMPIERE-5827: AD_Preference.PreferenceFor should support Forms (#1970)
* IDEMPIERE-5827: AD_Preference.PreferenceFor should support Forms

https://idempiere.atlassian.net/browse/IDEMPIERE-5827

* IDEMPIERE-5827: AD_Preference.PreferenceFor should support Forms : scripts on iD11

* IDEMPIERE-5827: AD_Preference.PreferenceFor should support Forms - remove changes related to Info Window

* IDEMPIERE-5827: AD_Preference.PreferenceFor should support Forms : remove changes related to Info Window

* Update oracle/202308101331_IDEMPIERE-5827.sql

* Update postgresql/202308101331_IDEMPIERE-5827.sql

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-09-05 15:43:01 +02:00
Nicolas Micoud f0bdcbb913
IDEMPIERE-5844: Add missing field / code for AD_Preference.AD_InfoWin… (#1993)
* IDEMPIERE-5844: Add missing field / code for AD_Preference.AD_InfoWindow_ID

https://idempiere.atlassian.net/browse/IDEMPIERE-5844

* Update oracle/202309041344_IDEMPIERE-5844.sql

* Update postgresql/202309041344_IDEMPIERE-5844.sql

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-09-05 13:15:01 +02:00
hengsin db4f715537
IDEMPIERE-5841 AD_Note created by Request causing Cross Tenant (#1991) 2023-09-05 16:02:28 +08:00
Nicolas Micoud 562283fe48
IDEMPIERE-5760: Manage mail.smtp.timeout using SysConfig (#1982)
https://idempiere.atlassian.net/browse/IDEMPIERE-5760

https://github.com/idempiere/idempiere/pull/1883 + changes requested by Carlos (migration script)
2023-09-02 16:38:13 +02:00
Carlos Ruiz eee6f449c3
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1985)
- Fix issue caused by last changes - the *SelectionGrid fields are not working because they don't have a formal Reference
2023-09-01 10:41:41 +08:00
Carlos Ruiz fd986b4130
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - MigraID (#1986)
Fixes for the MigraID process:
- Add management for AD_Tree_Favorite_Node
- Add management for multi-IDs fields (comma separated IDs or UUIDs)
- Add management for AD_Package_UUID_Map
- Fix issues with UUID based tables
2023-09-01 10:40:25 +08:00
Carlos Ruiz 954b3b2fec
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1976)
- Fix 2Pack to work with UUID based tables
- Implement ability for PackOut/PackIn multi ID columns
2023-08-26 09:49:39 +08:00
Carlos Ruiz c1d8a50b12
IDEMPIERE-5837 Collect all System Properties of iDempiere in one class (#1980) 2023-08-26 09:39:53 +08:00
Deepak Pansheriya e902ce13bc
IDEMPIERE-5768 : committing osgi service definition XML file for default credit manager factory. (#1975) 2023-08-23 19:37:48 +08:00
Deepak Pansheriya 18f925fd2f
IDEMPIERE-5768 : Adding Credit manager factory to override or extend … (#1949)
* IDEMPIERE-5768 : Adding Credit manager factory to override or extend credit management

* IDEMPIERE-5768 : Fixing as as per code review comments from Hengsin

* IDEMPIERE-5768: Use component annotation instead of xml service definition

* IDEMPIERE-5768: Adding Unit tests and Making return type of CheckCreditStatus to be object instead of String.

* IDEMPIERE-5768: Fixing as per code review comment.

* IDEMPIERE-5768: Removed explicit rollback from test cases
2023-08-23 09:39:24 +08:00
Carlos Ruiz 5aba739d37
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1963)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

- fix issues with archive reporting on UU based tables

* - implement change log in time line mode for UUID based tables

* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

* Fixes and improvements for MoveClient
  * Fix for oracle not being able to insert AD_WF_Node (CLOB column)
  * Add management for UUID based tables
  * Add management for weak foreign key Fact_Acct.Line_ID
  * Add management for weak foreign key AD_Tree_Favorite_Node.Parent_ID
  * Add management for Record_UU columns
  * Add management for ChosenMultipleSelectionTable and ChosenMultipleSelectionSearch
  * Improve javadoc

* - Test and add support for SelectionGrid

* - fix error inserting a wrong UUID when it was set before by a Record_UU

* - Fix problem validating orphans in UUID based tables
2023-08-22 20:08:33 +08:00
Carlos Ruiz db833e3665
IDEMPIERE-5826 iDempiere REST can insert/update an invalid foreign key (#1969) 2023-08-15 16:51:44 +08:00
hengsin 66b7b20619
IDEMPIERE-5275 Tabular Report Re-Run button/close parameter window (#1962)
* IDEMPIERE-5275 Tabular Report Re-Run button/close parameter window

- Fix process info log & error not shown
- Fix re-run missing context variable from menu

* IDEMPIERE-5275 Tabular Report Re-Run button/close parameter window

- turn off auto close after zoom
2023-08-09 16:00:00 +02:00
Diego Ruiz f1a0f7aac1
IDEMPIERE-5823 - Improve MUserMail constructors to behave equally in every case (#1967) 2023-08-09 12:56:10 +08:00
hengsin e46d57e1ea
IDEMPIERE-5812 Reversal of Material Receipt for a Closed PO leave quantity ordered of product in a bad state (#1964) 2023-08-08 14:02:28 +02:00
hengsin 03c6187fde
IDEMPIERE-5813 Change Role must close session like Logout does (#1959)
* IDEMPIERE-5813 Change Role must close session like Logout does

* IDEMPIERE-5813 Change Role must close session like Logout does
2023-08-01 19:14:26 +02:00
Carlos Ruiz 159fbbd04c
IDEMPIERE-5732 Cache reset should happens after commit of transaction (#1850)
* IDEMPIERE-5732 Cache reset should happens after commit of transaction

* IDEMPIERE-5732 Cache reset should happens after commit of transaction

* - minor defensive programming

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-08-01 19:53:11 +08:00
Carlos Ruiz 6e0645f90c
IDEMPIERE-5818 AD_Session cache is not working (#1960) 2023-08-01 10:46:28 +08:00
hengsin 890862de47
IDEMPIERE-4416 invalidating a purchase order doesn't remove connectio… (#1942)
* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- refactoring, make MiniTableImpl usable outside of test

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- refactoring, move business and sql logic from Match to model class.
- add more unit test

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- set M_InOut.C_Order_ID to null

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- update unit test for setting of M_InOut.C_Order_ID to null.
2023-07-31 15:20:26 +02:00
Jasper Siepkes f689b0f630
IDEMPIERE-5807 Add ability to specify attribute set when importing products (#1950) 2023-07-29 10:13:07 +08:00
Carlos Ruiz 9206dda962
IDEMPIERE-5785 Review of tables/columns that should/should not be logged (#1943)
* IDEMPIERE-5785 Review of tables/columns that should/should not be logged

* - suggest to delete also logs from AD_Wlistbox_Customization
2023-07-17 09:43:16 +08:00
Peter Takács ca98a81671
IDEMPIERE-5772 - Quick Info Widget Support for Info Window (#1899)
* IDEMPIERE-5772 - Quick Info Widget Support for Info Window - initial commit

* IDEMPIERE-5772 - manage context variables in info window

Put the following values into the context:
- query criteria
- values of the selected row

* IDEMPIERE-5772 - fixes

- info window should not change context if isLookup() = true (popup window mode)
- parameter values should be put into context only on re-query
- values of KeyNamePair type should use the "key" in context (practically tat means the ID) instead of name (display value)

* IDEMPIERE-5772 - add prefix to row variables and Selected_ID to ctx

* IDEMPIERE-5772 - rename variable name Selected_ID -> ID_Selection

* IDEMPIERE-5772 - patch by Carlos

* IDEMPIERE-5772 - fixed reported issues

- support ctx variables in info windows without process (no multiselection)
- change ctx variable syntax/prefix
- fix issue with type IDColumn
2023-07-16 17:33:58 +02:00
hengsin 407b756cb8
IDEMPIERE-5800 Info Window Context Variables are not Cleared after Closing (#1937) 2023-07-16 16:02:44 +02:00
hengsin 8786d8a51f
IDEMPIERE-5525 GetWarehouse method ordering storage records by M_Locator_ID (#1941) 2023-07-16 15:12:59 +02:00
Peter Takács 750e38d3b2
IDEMPIERE-5799 - Storage Reservation Log does not set Organization Correctly (#1935)
* IDEMPIERE-5799 - Storage Reservation Los des not set Warehouse Correctly

* IDEMPIERE-5799 - requested changes by Heng Sin
2023-07-15 10:48:31 +08:00
Nicolas Micoud 3b055d30e0
IDEMPIERE-5796: Generate Model Template (#1931)
* IDEMPIERE-5796: Generate Model Template

Initial commit (migration scripts / model classes / process)

* IDEMPIERE-5796: Generate Model Template

update parameters value from template

* IDEMPIERE-5796: scripts in v10

Scripts must be set in v10

* IDEMPIERE-5796: Generate Model Template - fix scripts

* IDEMPIERE-5796: Generate Model Template - various fixes

Improve help, fix warning and change TableName parameter name

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-5796: Generate Model Template - remove System.out

* IDEMPIERE-5796: Generate Model Template : EntityType parameters as multitable

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-5796: Generate Model Template : parameters to generate interfaces and/or classes

and enhancement of help

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-07-13 15:59:41 +02:00
Elaine Tan eed078308c
IDEMPIERE-5757 immediate post: Payment REVERSE/CORRECT allocation document NOT posted (#1922)
* IDEMPIERE-5757 immediate post: Payment REVERSE/CORRECT allocation document NOT posted
2023-07-10 21:38:31 +08:00
Nicolas Micoud b28735509d
IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlud… (#1928)
* IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlude end date

https://idempiere.atlassian.net/browse/IDEMPIERE-5794

* IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlude end date - Unit tests

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2023-07-10 14:41:39 +08:00
Carlos Ruiz b7c089fc1d
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Implement support for Requests on UUID Based Tables (#1910)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Implement support for Requests on UUID Based Tables

* - minor typo

* - improve javadoc
2023-07-08 12:09:56 +08:00
Elaine Tan fce4d5cf9c
IDEMPIERE-5591 Payment allocation AP/AR GL postings not zero in alternative schema for invoice REVERSE/CORRECT (#1921) 2023-07-08 11:37:17 +08:00
Carlos Ruiz 34a33ba06f
IDEMPIERE-1437 Do not allow changing Table in Tab when there are Fields (#1927) 2023-07-08 11:17:37 +08:00
Nicolas Micoud 71a49baf00
IDEMPIERE-5795: DeveloperMode context variable (#1929)
https: //idempiere.atlassian.net/browse/IDEMPIERE-5795

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-07-08 10:42:57 +08:00
Zuhri Utama 00c4fec2f4
JIRA TICKET : https://idempiere.atlassian.net/browse/IDEMPIERE-1502 (#1926) 2023-07-06 12:15:39 +08:00
Zuhri Utama 9f55c76573
IDEMPIERE-5062 validation when run process and input min max value on process parameter (#1908)
* - added validation for min and max value when run process
- added validation when insert min and max value format

* - remove unused class
- change reference id to displayType
- translate error massage

* refactoring code by carlosRuiz-globalqss
2023-07-03 17:14:16 +02:00
Carlos Ruiz b7b0b16476
IDEMPIERE-5750 Error when switching to tab when choosing a language other than English (#1920)
* IDEMPIERE-5750 Error when switching to tab when choosing a language other than English

* - avoid usage of AdempiereIdGenerator.escapeId when not ZkUnitTest
2023-07-01 20:24:58 +08:00
Peter Takács f79dd5f22f
IDEMPIERE-5786 - Refactor ESC/Alt+X Shortcut for Closing Tabs (#1917)
* IDEMPIERE-5786 - ESC Shortcut for Closing Tabs

- remove duplicate registering of on_cancel event on InfoPanel
- register on_cancel event on WindowContainer

* IDEMPIERE-5786 - partially revert ESC Shortcut for Closing Tabs

* IDEMPIERE-5786 - improve closing tabs with shortcut

- info windows
- forms
- workflows
- find window

* IDEMPIERE-5786 - SysConfig to Use Esc For Tab Closing

* IDEMPIERE-5786 - fix MSysConfig order

* IDEMPIERE-5786 - requested changes by Carlos

- implement shortcut on missing forms
- allow Alt+X shortcut also when ESC is allowed with the SysConfig

* IDEMPIERE-5786 - PR1917pr patch by Carlos

- removed unnecessary fix for an old firefox issue
2023-06-30 11:08:38 +02:00