Commit Graph

2779 Commits

Author SHA1 Message Date
hengsin 0e9f36add9
IDEMPIERE-3197 Tab still keep editing indicator when move to next record (#229)
Update tab title after save
2020-08-24 18:39:27 +02:00
Carlos Ruiz b0fbbb7a16
IDEMPIERE-4425 Find Window improvements (#224)
* IDEMPIERE-4425 Find Window improvements

Fix for printing report parameters - it is printing OPERATOR_EQUAL on reports instead of =

* IDEMPIERE-4425 Find Window improvements

Previous commit broke the find function - must use SQL for Values
2020-08-24 23:08:07 +08:00
Carlos Ruiz 2ad8fdfb3e
IDEMPIERE-2216:when make a warehouse order (in counter document test)… (#226)
* IDEMPIERE-2216:when make a warehouse order (in counter document test). new document material receipt is link with warehouse order not link with purchase order. it's correct?

* IDEMPIERE-2240:when create "On Credit Order" in counter document mode. invoice vendor make wrong reference to sale order

* IDEMPIERE-2257:can't complete invoice (vendor) generate from "order credit" by counter.

Integrating patch from Hiep hieplq@hasuvimex.vn
Changed syntax to be more readable
Used Processed instead of checking list of DocStatus

Co-authored-by: hieplq@hasuvimex.vn <hieplq@hasuvimex.vn>
2020-08-22 20:55:44 +02:00
Carlos Ruiz a9d24a2d5b
IDEMPIERE-4427 Changelog window reference lists dksplayed in wrong language (#221)
Ref IDEMPIERE-1540 e9e7486473
2020-08-21 20:56:34 +08:00
Carlos Ruiz a68c5f1968
IDEMPIERE-4425 Find Window improvements (#219) 2020-08-21 13:07:01 +02:00
Nicolas Micoud 2322a79dda
IDEMPIERE-4422 : GL Distribution - add SeqNo (#217)
* IDEMPIERE-4422 : GL Distribution - add SeqNo

Add SeqNo column on GL Distribution to allow users to choose the lowest one when several records are retrieved.
Fix typo

* IDEMPIERE-4422 : GL Distribution - add SeqNo

Fix a missed typo
2020-08-21 11:20:33 +02:00
Carlos Ruiz 7892c54aa1
IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user (#188)
* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Allow saving Tab Customization for System user

* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Fix copy/paste error

* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Implement same suggestion on all the classes where setAD_User_ID must be allowed to explicitly set to System
There were already two classes with the Override approach: MUserPreference and MUserRoles, so this commit is to apply the same approach to all the classes with same approach
2020-08-13 18:20:59 +08:00
hengsin 60f4ea4215
IDEMPIERE-4406 Performance: PO Cache should not always reset all entr… (#212)
* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

PO update - reset cache by record id

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

refine unit test

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

add cache reset fix for delete

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

Fix exception when cache is empty
Expose hidden cache reset exception
2020-08-11 14:55:03 +02:00
hengsin 0ad8737829
IDEMPIERE-4405 Add basic cache statistics (#211)
fix wrong hit/miss count when cached value is null
2020-08-07 17:07:39 +02:00
hengsin 147eebb01b
IDEMPIERE-4405 Add basic cache statistics (#210)
add hit and miss count for cache
2020-08-07 13:05:34 +02:00
Carlos Ruiz a84adbad80
IDEMPIERE-4395 Cannot save valid strings in oracle - ORA-12899: value too large for column (#202) 2020-08-06 22:35:37 +08:00
hengsin c17f1ae733
IDEMPIERE-4389 (#206)
* IDEMPIERE-4389 Implement Copy Constructor support for PO

Implement PO support for copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

deprecate clone
replace clone with copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

add unit test for MPrintFormat copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

fix wrong import
2020-08-05 21:03:40 +02:00
Carlos Ruiz 59758e8a7e
IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation (#198)
* IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

* IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Add validations to avoid editing lines if there are pending confirmations, in movement and shipment/receipt
2020-08-03 20:45:08 +08:00
hengsin a3a86739c2
IDEMPIERE-4390 Error in the Workflow window (#201)
add keyword quote escape to gridtable and mquery
2020-08-03 13:43:38 +02:00
hengsin f010b10446
IDEMPIERE-4393 Replace Oracle outer join synax (+) with SQL standard outer join (#199)
add native postgresql unit test for GenericPaymentExport
remove unnecessary static and fix sql exception doesn't stop the export
replace Oracle (+) with standard sql outer joint
2020-08-03 12:04:53 +02:00
Carlos Ruiz 600d8efc70
IDEMPIERE-1804 Org of WF Process is Default(login) Organization. (#195)
Workflow org

Co-authored-by: Hideaki Hagiwara <hagiwara.hideaki@gmail.com>
2020-07-31 08:02:33 +08:00
Carlos Ruiz a143e63128
IDEMPIERE-1893 can't Reversed a complete document "move inventory with confirm" (#197)
Do not create confirmation for reversal
2020-07-31 07:58:10 +08:00
Carlos Ruiz 937eaaa6ce
IDEMPIERE-874 Suspense Account is Posted with Wrong Org on GL Journal (#190) 2020-07-30 23:06:14 +08:00
Carlos Ruiz 0fa717cf0a
IDEMPIERE-4083 currency rate by document or by transaction (#182)
Integrating a contribution from TrekGlobal developed by Heng Sin
2020-07-30 15:46:43 +08:00
Carlos Ruiz e79ef31cd5
IDEMPIERE-3897 export csv: reference column export like normal column (#189)
Fix issue that entity type and language are not being set when imported
2020-07-30 10:47:56 +08:00
hieplq 30ce8cc5be
IDEMPIERE-4376:order activity workflow by ID (also time it's created) (#187)
maybe order by seq-no of node link to activity is more stable than ID
2020-07-27 17:08:02 +02:00
hengsin 80146138ac
IDEMPIERE-4382 Locator Editor inconsistent in the application of filter (#183)
pass ValidationCode to MLocatorLookup
Fix dynamic display support
Fix filter for grid view
Fix locator dialog not open with the selected locator
2020-07-26 12:49:43 +02:00
hengsin 40efcea51e
IDEMPIERE-4381 Order Line QtyReserved not updated correctly for negative shipment (#180)
Fix update of QtyReserved
2020-07-26 10:48:55 +02:00
Carlos Ruiz 26d2e37339
IDEMPIERE-1848 can delete org, account record in "Account Schema Dime… (#150)
* IDEMPIERE-1848 can delete org, account record in "Account Schema Dimensions"

Set Accounting Schema > Account Schema Dimensions > Element Type readonly when the type is Account or Org

* IDEMPIERE-1848 can delete org, account record in "Account Schema Dimensions"

reverting https://github.com/idempiere/idempiere/commit/be8de78
from https://sourceforge.net/p/adempiere/bugs/773/
2020-07-22 15:22:23 +08:00
hengsin cc76e63d85
IDEMPIERE-4372 Performance: only add log record and sql statement to … (#172)
* IDEMPIERE-4372 Performance: only add log record and sql statement to context if trace/debug level <= debug/info

Minor clean up and thread safe fix for CLogErrorBuffer and MIssue
Only add LogRecord and SQL to context if TraceLevel is <= INFO

* IDEMPIERE-4372 Performance: only add log record and sql statement to context if trace/debug level <= debug/info

add back DB.isConnected check
remove redundant CLogErrorBuffer call from DB.isConnected
more fine grained synchronization
2020-07-21 12:25:20 +02:00
hengsin d3717bc1fa
IDEMPIERE-4373 Bug fixes for CSV Import loader (#174)
close trx in finally block.
m_directNullKey interfere with CSV Import Loader due to trx that's not
committed yet.
insert mode: update window/tab context after save.
2020-07-21 00:10:49 +02:00
igorpojzl dd2b24aafa
IDEMPIERE-4368: Allow Define Default Saved Query for User (#169)
* Update AD_UserQuery models

* Implementation of initializing Default User Queries

* Added Migration Scripts

* Update 202007161400_IDEMPIERE-4368.sql

Added missing register_migration_script.

* IDEMPIERE-4368 Added missing script.

* IDEMPIERE-4368 Allow Define Default Saved Query for User

Fix Load defaults only on Initialization.

* IDEMPIERE-4368

Move Migration Script to 7.1 folder

* IDEMPEIRE-4368

Apply of patch.
2020-07-20 14:51:48 +02:00
hengsin 31acb032ab
IDEMPIERE-4349 WTableDirEditor show inactive item (#167)
add back onlyActive logic when items is from cache.
2020-07-16 02:28:08 +07:00
Carlos Ruiz 4afaed6140
IDEMPIERE-3062 Unable to complete MR with qty >1 with Attribute Set of Always Mandatory (#144) 2020-07-15 11:05:49 +08:00
Carlos Ruiz 2d70a1a169
IDEMPIERE-1117 Attachment -> Disable preview over certain size (#145)
* IDEMPIERE-1117 Attachment -> Disable preview over certain size

New SysConfig key ZK_MAX_ATTACHMENT_PREVIEW_SIZE

* IDEMPIERE-1117 move scripts to 7.1
2020-07-14 21:51:17 +08:00
Carlos Ruiz e954df2abe
IDEMPIERE-4358 Processes to drop some objects from database (#161) 2020-07-09 19:50:29 +02:00
Nicolas Micoud c59f550293
IDEMPIERE-4359 : EMailTest process : customization of email sent (#162)
Ability to define a dedicated mail template for the EMailTest process (via a client level SysConfig).
Output of the process was wrong (always successful even when the email was not sent)
2020-07-07 16:44:44 +02:00
Nicolas Micoud 4c1236e938
IDEMPIERE-4356 : System properties shouldn't not be used when sending emails (#154)
* IDEMPIERE-4356

Using Hiep's idea

Co-Authored-By: hieplq <hieplq@users.noreply.github.com>

* IDEMPIERE-4356

Following Carlos's tests/advices, add current System Properties to the Properties initialized for the email

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: hieplq <hieplq@users.noreply.github.com>
Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-07-04 11:13:45 +02:00
hieplq 4f09cc5a7a
IDEMPIERE-4329:Cleanup eclipse warnings (un-use import and deprecate function) (#158) 2020-07-03 12:19:56 +02:00
Nicolas Micoud 08c3b3c1be
IDEMPIERE-4351 : MJournal/MJournalLine : fill mandatory values (if mi… (#152)
* IDEMPIERE-4351 : MJournal/MJournalLine : fill mandatory values (if missing) in beforeSave methods

GL_Journal.C_AcctSchema_ID
GL_Journal.C_ConversionType_ID
GL_JournalLine.C_Currency_ID
GL_JournalLine.C_ConversionType_ID

* IDEMPIERE-4351 : MJournal/MJournalLine : fill mandatory

Based on Carlos's patch :
Fix issues in PO.java that are not allowing the beforeSave methods that complete organization to work
* This also has the effect of checking and setting the organization restrictions after beforeSave and EventHandlers have finished, potentially fixing developer errors on org not respecting the configuration on Client Share

* In MJournalLine move the setting of org to the top because the getOrCreateCombination method works with the org value

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-07-01 21:34:51 +02:00
Nicolas Micoud fa3e9461e8
IDEMPIERE-4343 : records created by InitialClientSetup must be on Org * (#132)
* IDEMPIERE-4343 : records created by InitialClientSetup must be on Org *

* IDEMPIERE-4343 : GL_Category
2020-06-30 22:02:39 +02:00
Carlos Ruiz 6e2cf15fa9
IDEMPIERE-966 When Order document(Both PO and SO) close, I think that MOrder.closeIt() method should calculate tax again. (#136) 2020-06-30 13:40:38 +02:00
Carlos Ruiz e057072bc7
IDEMPIERE-829 Implement MInvoice.getOpenAmt with paymentDate (#135) 2020-06-30 12:45:14 +02:00
Carlos Ruiz bcd1fa67cd
IDEMPIERE-4318 Validation - Prepay Order must not allow Cash payment rule (#127) 2020-06-24 17:10:51 +02:00
Diego Ruiz f50425334f
IDEMPIERE-1026 Button on table to create automatically the window (#128)
* IDEMPIERE-1026 Button on table to create automatically the window

* IDEMPIERE-1026 Button on table to create automatically the window - Fixed script

* IDEMPIERE-1026 Button on table to create automatically the window - Header update

* IDEMPIERE-1026 Button on table to create automatically the window - Follow best practices, no hardcoded IDs, no mixed cache and transaction

* IDEMPIERE-1026 Button on table to create automatically the window - Carlos PR
2020-06-24 16:43:11 +02:00
Carlos Ruiz f5518a9b64
IDEMPIERE-4282 Error creating a Price List - using -DPostgreSQLNative=Y (#131)
Starting point is the open source version of Compiere org/compiere/process/PriceListCreate.java
This version adds column M_DiscountSchemaLine.Description and rounding options for Hundred and Thousand
Then added to this version the iDempiere changes related to use correctly the T_Selection with AD_PInstance_ID,
and the changes related to Ticket #1002354: Price List Enhancement - which added Product Costs as an option for getting the initial price
2020-06-24 11:53:49 +02:00
Carlos Ruiz 2a3224ea46
IDEMPIERE-4319 Cascade workflow activities (completing chained documents) exception problem (#122)
Implemented a better approach: save the first workflow savepoint and rollback to that one in case of cascade activities
2020-06-17 15:44:06 +02:00
Carlos Ruiz 36d6644879
IDEMPIERE-4324 Fix NPE on payment allocation (#115)
Co-authored-by: Orlando Curieles <orlando.curieles@ingeint.com>
2020-06-16 14:06:36 +02:00
Carlos Ruiz c0710da6cd
Cache without name #resolve IDEMPIERE-4333 (#116) 2020-06-16 14:06:24 +02:00
Carlos Ruiz 204b00c6f2
IDEMPIERE-4334 Fixed Assets wrong dictionary (#117)
Fixed many wrongly defined columns #resolve IDEMPIERE-4334
Added a fix to DisplayType - running synchronize column in C_Conversion_Rate.C_Currency_ID_To and A_Asset_Split.A_Asset_ID_To was throwing error
2020-06-16 14:06:11 +02:00
Carlos Ruiz fe69eb9dfa
IDEMPIERE-2753 Discount is not calculated when Price List Price <1 (#119)
Bring one more point of failure discovered by Elaine Tan
2020-06-16 13:55:40 +02:00
hengsin 2706026b85
IDEMPIERE-4331 Do not use Hazelcast Cache Service if it is standalone (#113)
Use normal map if hazelcast is stand alone
2020-06-13 16:00:04 +02:00
Carlos Ruiz aac7d81077
IDEMPIERE-4330 New tables are not logged - requires a server restart (#111)
* IDEMPIERE-4330 New tables are not logged - requires a server restart

* IDEMPIERE-4330 New tables are not logged - requires a server restart

Add synchronized to isLogged and resetLoggedList as advised by Heng Sin
2020-06-13 21:37:04 +08:00
hengsin 5adad12309
IDEMPIERE-4332 PO Serialization Optimization (#114)
Do not serialize context and POInfo
2020-06-13 15:21:31 +02:00
Carlos Ruiz 10771a7408
IDEMPIERE-4254 get oracle error ORA-01795 when has more than 1000 org (#109) 2020-06-09 23:26:44 +07:00