Commit Graph

2514 Commits

Author SHA1 Message Date
Carlos Ruiz bdc810b343 Fix bug [2832350] Enabling trace log file create one file per line in /tmp
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2832350
2010-03-11 19:58:32 +00:00
Carlos Ruiz 2ce294bb10 BF [2897730] - Bank Transfer improvements and fixes - make DocumentNo mandatory
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2897730
2010-03-11 19:21:37 +00:00
Carlos Ruiz f59b902a34 FR [2962094] - Finish implementation of weighted average costing - Created the default account P_AverageCostVariance_Acct
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962094
2010-03-09 02:59:57 +00:00
trifonnt 2e49d21ca4 FR [2965494] - Import Order: Import of Order Source
https://sourceforge.net/tracker/?func=detail&aid=2965494&group_id=176962&atid=883808
Set proper Error message when Order Source is not found.
Thank's to Carlos for the review!
2010-03-08 23:49:32 +00:00
Carlos Ruiz fd63d9af1e Revert revision 11432 - comments in tracker
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2904144
2010-03-08 22:26:22 +00:00
Carlos Ruiz 8e2dc1b771 Revert revision 11419 - comments in tracker
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2949927
2010-03-08 22:17:46 +00:00
Carlos Ruiz 0392c5a175 Peer review revisions 11587, 11588, 11589, 11591, 11592, 11601, 11602, 11603, 11604, 11605, 11606, 11607 - just applying some best practices
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-08 22:10:23 +00:00
trifonnt ec9937f54e FR [2965494] - Import Order: Import of Order Source
https://sourceforge.net/tracker/?func=detail&aid=2965494&group_id=176962&atid=883808
2010-03-08 16:09:28 +00:00
trifonnt 19d419e47d Reverting usage of MQuery for MTable class.
ADemepire is not even able to start from Eclipse.
Please next time at least try to start ADemepire from Eclipse.
https://sourceforge.net/tracker/index.php?func=detail&aid=2214883&group_id=176962&atid=879335
2010-03-08 08:37:06 +00:00
vpj-cd 370a752666 FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-07 19:41:38 +00:00
vpj-cd 30225c49c9 Remove SQL code and Replace for Query
Red1 please review your code before to commitment, or commitment after the units test, some implementor are using trunk in production

kind regards
Victor Perez
www.e-evolution.com
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-07 18:52:18 +00:00
vpj-cd 691b689ee7 Remove SQL code and Replace for Query
Red1 please review your code before to commitment, or commitment after the units test, some implementor are using trunk in production

kind regards
Victor Perez
www.e-evolution.com
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-07 18:06:05 +00:00
Redhuan D. Oon 14046997c8 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-07 16:25:43 +00:00
Redhuan D. Oon f95f2f2f6d FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-06 16:22:12 +00:00
Redhuan D. Oon 3ad07bd33d FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-06 16:04:20 +00:00
Carlos Ruiz 04229f1a2e Second step: Implement AcctProcessor to post the documents in the order they were processed
FR [2962094] Finish implementation of weighted average costing
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962094
2010-03-06 01:09:26 +00:00
Redhuan D. Oon 305a239f1a FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 18:45:25 +00:00
Redhuan D. Oon 0ff7666a2b FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 18:38:40 +00:00
Redhuan D. Oon 64d83bfa5e FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 18:33:17 +00:00
Redhuan D. Oon c61ce5d86d FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 14:49:46 +00:00
Redhuan D. Oon 8d6cd95f50 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 14:34:10 +00:00
tspc bb529d9197 Merge bug fixes in release not committed to trunk
merge -c 11561 -c 11581 -c 11582

11561 -> Fix [2962787] Recursion in PO.set_ValueNoCheckE
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962787

11581 -> Fix [2948897] Fixed Assets Dictionary Errors - wrong reference to column A_Depreciation_Entry.A_Type_Entry
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2948897

11582 -> Fix [2948897] Fixed Assets Dictionary Errors - wrong reference on processed columns
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2948897
2010-03-04 23:11:37 +00:00
Carlos Ruiz fe13d23bb0 peer review for 11559, 11560 - refactor MRule.getModelValidatorLoginRules to avoid double array management
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-04 00:24:46 +00:00
Carlos Ruiz 21f04ba76f peer review for 11555
- refactorings to use setClientID and setOnlyActiveRecords
- check serialVersionUID on affected classes
- add final to whereClauses
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-04 00:06:16 +00:00
Carlos Ruiz 08e0deb5cd peer review for 11554
- incompatible objects in MMovement
- other refactorings
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 23:38:19 +00:00
Carlos Ruiz 1a06e21024 peer review for 11547 - minor changes
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 23:04:46 +00:00
Carlos Ruiz 98c74ef980 peer review for 11545 and 11546 - refactored getProductLot to have predictable results
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 22:40:26 +00:00
Carlos Ruiz ff9dffd082 peer review for 11541 - be careful with logic: an exception is not equivalent to a log.info
refactored to use .setClientID()
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 22:13:54 +00:00
Carlos Ruiz e7177049db peer review for 11533, 11537, 11540
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 21:43:37 +00:00
Carlos Ruiz d9b22ee7ed peer review for 11539
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 21:13:05 +00:00
Carlos Ruiz 791f4a8624 peer review for 11538 -> drop unused lines in ExportHelper - apply the same practice to ImportHelper, fix warning on ExportFormatGenerator
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 20:09:00 +00:00
Carlos Ruiz 6b59db69ed peer review for 11535 -> getBPartnerCashTrx refactored with junit test applied
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 19:47:16 +00:00
Redhuan D. Oon ab5b31fe9a FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 07:51:30 +00:00
Carlos Ruiz dfe03fabfa FR 2962094 - Finish implementation of weighted average costing
1st step -> create column to manage the processed date+time (in order to allow reposting of documents in the same order they were completed - this will be the second step)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962094
2010-03-03 01:31:36 +00:00
phib 5fdefd4be3 Future dated price list version used in order
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962244
2010-03-02 22:59:41 +00:00
vpj-cd d6e3780968 Apply ADempiere Best Practice and change the Collection by List as standard in ADempiere
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 17:15:59 +00:00
Redhuan D. Oon 3486415202 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:44:42 +00:00
Redhuan D. Oon 7fb5e6b54d Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:43:25 +00:00
Redhuan D. Oon d2333e9026 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:38:35 +00:00
Redhuan D. Oon 5fba554eab Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 07:18:20 +00:00
Redhuan D. Oon 83154f494f FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 06:39:45 +00:00
Redhuan D. Oon c0d989b240 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test included (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 00:42:03 +00:00
Redhuan D. Oon a3cf7e8d37 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 22:41:26 +00:00
Redhuan D. Oon b690a934d3 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 09:55:38 +00:00
Redhuan D. Oon 042083872b Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Heng Sin's advice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 05:12:58 +00:00
Redhuan D. Oon 490cb806df Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Heng Sin's advice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 04:39:28 +00:00
Redhuan D. Oon e80c558107 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 04:24:19 +00:00
Redhuan D. Oon 583954e3eb FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 02:01:59 +00:00
Carlos Ruiz 03153697fe Peer review 11500, minor - drop useless comment, organize imports
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 21:06:50 +00:00
Carlos Ruiz cc7809b482 Apply Best Practices to Promotions Code: Use Model Classes instead of X_ classes whenever possible 2010-02-27 20:38:11 +00:00