Commit Graph

3517 Commits

Author SHA1 Message Date
Peter Takács bb695cb79a
IDEMPIERE-5645 - fix NPE on report Script columns (#1871) 2023-06-02 10:57:48 +08:00
Peter Takács 66e0d4200e
IDEMPIERE-5697 - Improve Process Log for more advanced logging options for Processes (#1808)
* IDEMPIERE-5697 - Improve Process Log for more advanced logging options for Processes

* IDEMPIERE-5697 - fix javadoc

* IDEMPIERE-5697 - add PInstanceLogType to AD_PInstance_Log

* IDEMPIERE-5697 - implement Status Log Type

- implement Status Log Type
- fix javadoc

* IDEMPIERE-5697 - definition changes

- rename log type 'Tail' to 'Progress' as Chuck Boecking suggested
- make ad_pinstance_log_uu the primary key as Heng Sin suggested

* IDEMPIERE-5697 - updateLog method with UUID

* IDEMPIERE-5697 - requested changes

- split insert and update
- fix wrong javadoc
- small fixes

* IDEMPIERE-5697 - requested changes

- fix javadoc
- fix migration scripts

* IDEMPIERE-5697 - balance API

- rename methods in SvrProcess: saveLog -> saveProgress, saveStatus; updateLog -> updateStatus
- remove progress and status methods that take table and record id arguments, there is no need to save them in separate fields with there log types

* IDEMPIERE-5697 - balance API

- exchange logic between Progress and Status log types
- modify method names in ProcessInfo based on SvrProcess

* IDEMPIERE-5697 - pr 1808 patch by Heng Sin

- fix oracle migration script
2023-06-01 14:11:25 +08:00
hieplq dfe2fff6cd
IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (#1842)
* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice

base on patch from gauravsontakke

* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (fix code review)

https://github.com/idempiere/idempiere/pull/1842#pullrequestreview-1429618616

* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (check Accrual)

createInvoiceGainLoss isn't yet test for non accrual so at check for accrual to consistent with above code
2023-06-01 13:15:48 +08:00
Carlos Ruiz 116b5b4db1
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - fix issue reported by Murilo (#1868) 2023-06-01 11:52:35 +08:00
Carlos Ruiz fde6e0a1d1
IDEMPIERE-5687 Base Price List (#1858) 2023-05-31 17:24:14 +02:00
Carlos Ruiz 013ba190fd
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Toolbar (#1865)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Toolbar

- add support for AD_Attachment, CM_Chat, AD_PostIt and AD_LabelAssignment for UUID based tables

* - Better deprecated message
- Better deprecated management for constructors

* - Fix non unique exception on ad_changelog
- Fix to save changelog just ID on insert and not the UUID for ID based tables
2023-05-31 10:39:10 +08:00
hengsin 7336dc967d
IDEMPIERE-5744 MDashboardPreference.getForSessionQuery: add client filter and remove order by ad_client_id (#1866) 2023-05-31 00:36:42 +02:00
Carlos Ruiz d45c0fa248
IDEMPIERE-5735 Useless code in GridTable.dataSave (#1853)
* IDEMPIERE-5735 Useless code in GridTable.dataSave

* - Solve issue with saving zero ID records on UI

* - remove unnecessary row - don't need to read again PO because gridTable.getPO returns now correctly POs with zero ID
2023-05-29 22:27:40 +08:00
hengsin cc831e41d8
IDEMPIERE-5743 Info Window: Add Optional Auto Collapsed Parameter Panel option (#1862) 2023-05-29 15:41:37 +02:00
Peter Takács 8096d6e420
IDEMPIERE-5216 - HTML report Record ID Trl fix (#1840)
* IDEMPIERE-5216 - HTML report Record ID Trl fix

* IDEMPIERE-5216 - HTML report Record ID Trl fix

* IDEMPIERE-5216 - add fallback if Trl not found

* IDEMPIERE-5216 - fix inconsistancy in logic

- DataEngine.java uses the Env.isBaseLanguage method

* IDEMPIERE-5216 - fix inconsistancy in logic

* IDEMPIERE-5216 - fix javadoc
2023-05-29 20:56:55 +08:00
Peter Takács 31365e24e9
IDEMPIERE-5730 - Context is not parsed in exception message logs thrown from processes (#1845) 2023-05-29 16:22:03 +08:00
Carlos Ruiz 430823153f
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Recent Items (#1856)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Recent Items

- Implement support for recent items for UUID based tables
- Refactor MRecentItem for better performance

* - fixes
2023-05-29 16:16:18 +08:00
Carlos Ruiz 281333e8b9
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - ChangeLog - FKRules (#1852)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - ChangeLog - FKRules

* - change warning by IllegalArgumentException
- change package visibility to protected

* - remove unnecessary code - the Model Cascade is calling the deleteModelCascade for children too

* - Implement SysConfig AD_CHANGELOG_SAVE_UUID
- reorganize MSysConfig (there were entries out of order)

* - Add index for performance on AD_ChangeLog.Record_UU

* - Enable change log for tables with multi-key (like _Trl or _Access)

* - Enable saving change log for AD_ClientInfo

* - when updating a record that doesn't have UUID - assign one
2023-05-28 23:47:30 +08:00
Peter Takács 1ff182e605
IDEMPIERE-5737 - Change Report's "No Rows" log level (#1855) 2023-05-25 22:35:06 +08:00
Carlos Ruiz 4a1dcb265b
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1837)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

- Fix Record UUID editor

* - Separate WRecordEditor and WRecordUUIDEditor for ID and UUID

* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

- integrate patch from Heng Sin

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-05-21 19:39:08 +08:00
Carlos Ruiz df06938191
IDEMPIERE-5731 NPE when using Query.list() with a view (#1846) 2023-05-20 09:55:07 +08:00
Carlos Ruiz 531aa73ea1
IDEMPIERE-4639 Cross tenant issues with context help (#1848) 2023-05-20 09:53:49 +08:00
Carlos Ruiz d734cafd9b
IDEMPIERE-5712 Tests are leaving records in the database (#1827)
* IDEMPIERE-5712 Tests are leaving records in the database

* - add transaction

* - add cleanup for records committed out of transaction
2023-05-16 16:32:15 +08:00
hengsin cc90586aa0
IDEMPIERE-5717 MColumn.getForeignKeyConstraint doesn't always generate unique foreign key constraint name (#1830) 2023-05-11 12:43:00 +02:00
Peter Takács ae19cbe91a
IDEMPIERE-5683 - Ignore Views with Record ID and Record UU Model Constraints (#1828) 2023-05-11 12:24:09 +02:00
Carlos Ruiz af2d735cc5
IDEMPIERE-5683 Peer review (#1825) 2023-05-06 00:58:43 +02:00
Peter Takács 3bf447b009
IDEMPIERE-5683 - Improve Record ID and Record UU by Constraint Type (#1810)
* IDEMPIERE-5683 - Improve Record ID and Record UU by Constraint Type

* IDEMPIERE-5683 - replace direct sql with model classes

- rename deleteSetNull to setRecordIdNull
- replace direct sql with model classes in deleteCascade, setRecordIdNull
- remove unnecessary change from AD_Ref_List

* IDEMPIERE-5683 - cache tables arrays in PO_Record

* IDEMPIERE-5683 - fix Dynamic Validation

* IDEMPIERE-5683 - change CleanOrphanCascade

- IsCleanChangeLog process parameter removed
- replace direct sql with java model
- delete just on Model Cascade constraint
- new Set Null rule implemented

* IDEMPIERE-5683 - fix when Record_ID is mandatory
2023-05-06 00:57:09 +02:00
hengsin afcbf6e70f
IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR… (#1818)
* IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR UPDATE

* IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR UPDATE

- add trx timeout unit test
2023-05-05 19:41:43 +02:00
Nicolas Micoud 0553878431
IDEMPIERE-5701: Improve logs when role cannot report or export (#1811)
* IDEMPIERE-5701: Improve logs when role cannot report or export

https://idempiere.atlassian.net/browse/IDEMPIERE-5701

* IDEMPIERE-5701: Reduce log level when role cannot report or export and hide Report button when role cannot report

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>
2023-05-04 00:06:53 +02:00
Carlos Ruiz 969a2e66df
IDEMPIERE-5238 Fix checkRecordIDCrossTenant failing in multi-key table (#1821) 2023-05-03 20:32:59 +02:00
Carlos Ruiz 31779a7611
IDEMPIERE-5708 Show in grid value in dictionary cannot be overriden by customize (#1820) 2023-05-03 19:17:15 +02:00
Peter Takács d53570eb75
IDEMPIERE-5695 - Process audit doesn't set print language, format, print format on Forms/documents (#1805)
* IDEMPIERE-5695 - Process audit doesn't set print language, format, print format on Forms/documents

* IDEMPIERE-5695 - get language from print format

* IDEMPIERE-5695 - fix javadoc

* IDEMPIERE-5695 - implement in startStandardReport and startFinReport
2023-05-02 17:13:55 +08:00
Carlos Ruiz 1fb4248ab9
IDEMPIERE-5706 Improvements to Tab Editor in Window Customization (#1817) 2023-05-01 16:44:51 +02:00
Carlos Ruiz 07ecea1494
IDEMPIERE-5509 Implement readonly query without using Trx - fix issue with native sequences in PostgreSQL (#1815) 2023-05-01 19:26:16 +08:00
Jose Leite 61118b8877
IDEMPIERE-5698 - Improvement for display all events errors (#1807)
* IDEMPIERE-5698 - mprovement for display all events errors

* IDEMPIERE-5698 - Improvement for display all events errors in all methods of class
2023-04-28 22:55:43 +08:00
hengsin 7bd5e579ce
IDEMPIERE-5689 Make MLocatorLookup and WLocatorEditor more extensible (#1800)
* IDEMPIERE-5689 Add setValidationCode to MLocatorLookup

* IDEMPIERE-5689 Make MLocatorLookup and WLocatorEditor more extensible
2023-04-28 12:26:47 +02:00
hengsin f18bb88f4b
IDEMPIERE-5691 Add Table Direct type joint method to Query (#1802) 2023-04-28 12:16:13 +02:00
Nicolas Micoud 254dcb3955
IDEMPIERE-5696: Width of last column of reports exported as Xlsx is n… (#1806)
* IDEMPIERE-5696: Width of last column of reports exported as Xlsx is not correct

https://idempiere.atlassian.net/browse/IDEMPIERE-5696

* IDEMPIERE-5696: Width of last column of reports exported as Xlsx is not correct - patch from hengsin

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2023-04-27 13:34:11 +08:00
Peter Takács 23713f6461
IDEMPIERE-5669 - Report Row Count shows incorrect data (#1791)
* IDEMPIERE-5669 - Report Row Count shows incorrect data

2 issues fixed:
- row count in tab did not refresh on clicking the refresh button (only on re-run)
- row count included function rows too

* IDEMPIERE-5669 - fixes

- added private attribute to rowCount Label
- added null-check to updateRowCount() method
2023-04-25 16:24:18 +08:00
Carlos Ruiz 5bf9301764
Fixes IDEMPIERE-5673 Wrong character causes java.awt.IllegalComponentStateException: This component must have a parent in order to determine its locale on reports (#1785) 2023-04-24 18:14:28 +08:00
Carlos Ruiz 80347c0926
Fixes IDEMPIERE-2194 GL Journal Distribution writes no DocumentNo in Accounting Fact Description (#1795)
- Copy the information from the line being distributed
2023-04-23 17:12:50 +08:00
hengsin eb78bd4ee9
IDEMPIERE-5678 Unit Test is failing with PostgreSQL 15 (#1789) 2023-04-19 13:57:34 +02:00
Carlos Ruiz 449c124fe1
IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) (#1787)
* IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) - fix broken unit tests

* - Fix problem with unit test:
MTestTest.testReadingUpdatingTest:65 expected: <Test setting description> but was: <Test setting descriptionMTestEventDelegate>
2023-04-19 09:07:32 +08:00
Carlos Ruiz beed782d4e
IDEMPIERE-5675 MTable.getPO cache for model factory wrongly removing from cache when PO is not found (#1788) 2023-04-18 14:34:29 +02:00
Deepak Pansheriya 76daedf6ad
IDEMPIERE-5671: Fixing Line net amount has error due to rounding. (#1782)
* IDEMPIERE-5671: Fixing Line net amount has error due to rounding.

* IDEMPIERE-5671: on price calculation add 12 decimal rounding to avoid rounding error
Co-authored-by: carg67@gmail.com
2023-04-17 10:25:05 +02:00
Jefferson Dalfre dd0e6c95ea
IDEMPIERE-5665 - [Multi Selection] - Negate option in process parameter (#1779)
* IDEMPIERE-5665

* IDEMPIERE-5665 - Fix code
2023-04-14 16:07:40 +08:00
Carlos Ruiz c80d53674a
IDEMPIERE-5567 Support of UUID as Key - Generate Model Classes (FHCA-4195) (#1772)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

New generated model classes with new UUID constructor

* - In order to use UUID constructor M classes must implement the constructor too
- Adding the constructor on MTest and adding a JUnit test to test/show how it works

* - Remove warning caused by changes on this ticket

* - Add UUID constructor to factories

* - Set new UUID constructor in mapped/annotated test classes
- Preparation for the new UUID constructor

* - Add UUID constructor to core model classes
- WARNING: MPaymentBatch(Properties, String, String) already existed with Name as parameter, it was changed to UUID
2023-04-12 11:02:33 +08:00
Peter Takács 89a093ca49
IDEMPIERE-5482 - Field Style Scope HTML Element (#1572)
* IDEMPIERE-5482 - Field Style Scope HTML Element

* IDEMPIERE-5482 - implemented in report engine, removed the new field

* IDEMPIERE-5482 - add IsWrapWithSpan to AD_Style

* IDEMPIERE-5482 -  pr1572 patch
2023-04-11 22:22:10 +08:00
Carlos Ruiz b5cb64bc92
IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) (#1771)
* IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195)

* - Search editor now assigns the value correctly when selecting from Info Window
- Info Window shows correctly the first UU key column
- Added Record UUID new data type to work with record ID editor but with UU column
- Added column/field Test.Record_UU for testing

* - Fix opening Record ID editor after saved

* - Implement changes suggested by Heng Sin's peer review

* - Remove other unnecessary changes

* - safer comparison
2023-04-11 13:20:13 +08:00
Carlos Ruiz 2e9b1222d3
IDEMPIERE-5560 Fix broken unit tests (#1770) 2023-04-06 16:04:45 +08:00
Peter Takács b1bf9bc4e9
IDEMPIERE-5650 - Cannot Define Multiple Values for Dashboard Content Process Parameters (#1757)
* IDEMPIERE-5650 - Cannot Define Multiple Values for Dashboard Content Process Parameters

* IDEMPIERE-5650 - remove hardcoded condition

* IDEMPIERE-5650 - fix for reference list multiselection

- support for non-ID multiselection types (values were not rendered e.g. with DocType="IP,CO")

* IDEMPIERE-5650 - fix for reference list multiselection

* IDEMPIERE-5650 - bug fixes

- error use case: reference list with numeric values e.g. "10", "20",... (fix: check DisplayType instead of data type)
- error use case 2: defining more than one multi-selection caused parsing error (fixed parsing logic in MDashboardContent)

* IDEMPIERE-5650 - optimise parsing method

* IDEMPIERE-5650 - pr1757_PR0 patch
2023-04-05 13:00:00 +02:00
Carlos Ruiz a967069164
IDEMPIERE-5567 Support of UUID as Foreign Key (FHCA-4195) (#1741)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Foreign Keys

* - Table Direct working as read-only and link column

* - Fixes for Table with Reference

* - Add UUID FK management to Migrate ID process
- Add MColumn.beforeSave validation to force UUID columns to end with _UU
- Add table TestUUDet with two foreign keys pointing to TestUU (TableDir and Search)
- Add detail tab to Test UU Based Table window
- Add a new test window named Test UU Detail
- Generate model classes for the new test table
- Add test case for the detail test table
- Add MTable.isIDKeyTable method
- Add UU foreign key cross tenant validation to PO.validForeignKeys

* - Added a Chosen Multiple Selection Table with foreign UU for testing
- Changed reference in dictionary logic and sql to reflect new data types
- Disable SearchUU temporarily (will be worked in next step)
- Add validation to avoid encrypting UUID columns
- Avoid warning when searching for getPO method on UUID based tables
- Make Zoom Across button work with UUID foreign keys
- Enable zoom and zoom to detail for UUID foreign keys
- Enable Find Advanced on detail foreign UUID keys

* - Fix javadoc
- Quote properly UUID
- Validate null on return

* - Fix zoom logic - tested zooming to tab in first second and third level
2023-04-05 10:26:27 +08:00
Peter Takács 30d89378c8
IDEMPIERE-5659 - New Document Base Type Group Window (#1768)
* IDEMPIERE-5659 - New Document Base Type Group Window

* IDEMPIERE-5659 - fixes

- renaming the table, model and elements according to the ticket
- removing MDocBaseGroup beforeSave validation
- adding an unique index for the Line table
2023-04-04 13:04:41 +02:00
Peter Takács 33de756336
IDEMPIERE-5645 - Print Format Script Column cannot find Columns from context (#1760)
* IDEMPIERE-5645 - Print Format Script Column cannot find Columns from context

* IDEMPIERE-5645 - move script columnd parsing after 'all rows' loop

* IDEMPIERE-5645 - fixes
2023-04-04 14:32:57 +08:00
Carlos Ruiz 9e18bc725e
IDEMPIERE-5174 Disable System User - Set new System (#1769) 2023-04-04 11:36:30 +08:00