Commit Graph

768 Commits

Author SHA1 Message Date
Carlos Ruiz 52e5d28049 Fix [ 1890206 ] getLines without reload not assigning trx
Removing duplicated code left by the fix
2008-02-09 17:26:29 +00:00
Carlos Ruiz 232f2c383c Fix [ 1890206 ] getLines without reload not assigning trx
Implement suggestion from Teo
2008-02-09 17:23:00 +00:00
teo_sarca 23e35757c4 * java generics warning fix
* refactored duplicate JASPER_STARTER_CLASS constant (use ProcessUtil.JASPER_STARTER_CLASS)
2008-02-09 14:36:16 +00:00
Redhuan D. Oon 7a7bf13e74 *BF [ 1874419 ] JDBC Statement not close in a finally block - fixed in 2 spots 2008-02-09 12:34:32 +00:00
teo_sarca 4da0bc719d BF [ 1874419 ] JDBC Statement not close in a finally block - fixed for MQuery 2008-02-09 12:34:11 +00:00
Redhuan D. Oon 76ac6d191f *BF [ 1874419 ] JDBC Statement not close in a finally block - fixed in 2 spots
*Organize imports
2008-02-09 12:31:39 +00:00
Redhuan D. Oon c4f0c7a1fa *BF [ 1874419 ] JDBC Statement not close in a finally block - fixed in 2 spots
*Organize imports
2008-02-09 11:08:45 +00:00
Redhuan D. Oon d515236a61 *BF [ 1874419 ] JDBC Statement not close in a finally block - fixed in 3 spots
*Organize imports
2008-02-09 10:16:25 +00:00
Redhuan D. Oon 28c5fb4621 *BF [ 1874419 ] JDBC Statement not close in a finally block - fixed in 2 spots
*Organize imports
2008-02-09 10:12:24 +00:00
teo_sarca 6b2e33bb3b GridTab: minor java generics exception 2008-02-09 09:59:19 +00:00
Carlos Ruiz 72c8ce87c1 [ 1883270 ] Enhance Document No Formatting
Duplicating the number on document save
2008-02-09 05:59:44 +00:00
Carlos Ruiz fa68ad7513 Applying again changes from revision 4491 2008-02-09 05:54:43 +00:00
Carlos Ruiz 2d148d573e This is again MSequence from version 4489
The file MSequence.java was too changed in format in revision 4491 and don't allow good peer review or comparison with previous versions.
2008-02-09 05:46:52 +00:00
Carlos Ruiz 1f34545432 Deleting again MSequence to recreate version 4489 and apply changes after that.
The file MSequence.java was too changed in format in revision 4491 and don't allow good peer review or comparison with previous versions.
2008-02-09 05:45:48 +00:00
Carlos Ruiz 1ba1780c55 Fix [ 1789935 ] Wrong Sum Total Debit/Credit in GL Journal
Thanks to Colin
2008-02-09 05:09:41 +00:00
Carlos Ruiz 6a0b2f1ae3 Fix [ 1704203 ] Charges: Income accounts are also debited 2008-02-09 05:01:41 +00:00
Redhuan D. Oon 9a9eeda926 *BF [ 1874419 ] JDBC Statement not close in a finally block
*Organize imports
2008-02-08 19:33:21 +00:00
Redhuan D. Oon 02b352fdb4 forgot reorganize imports 2008-02-08 19:28:43 +00:00
Redhuan D. Oon 4aa01e3459 *BF [ 1874419 ] JDBC Statement not close in a finally block
*Organize imports
2008-02-08 19:25:19 +00:00
Redhuan D. Oon 70159b94bf left out one db.close 2008-02-08 19:21:31 +00:00
Redhuan D. Oon b46a2dd4ed *BF [ 1874419 ] JDBC Statement not close in a finally block
*Organize imports
2008-02-08 19:13:13 +00:00
Redhuan D. Oon 0eb0840aaa *BF [ 1874419 ] JDBC Statement not close in a finally block
*Organize imports

*Parameterized <T>
2008-02-08 10:26:59 +00:00
Redhuan D. Oon 918872fd8a *BF [ 1874419 ] JDBC Statement not close in a finally block
*Organize imports

*Comment Never Used variable
2008-02-08 10:20:30 +00:00
Redhuan D. Oon 8ebf127df3 forgot the organize imports not done! 2008-02-08 10:08:30 +00:00
Redhuan D. Oon 0446feffaf *BF [ 1874419 ] JDBC Statement not close in a finally block
Organize Imports
2008-02-08 10:07:35 +00:00
Redhuan D. Oon 6039fa88f2 *BF [ 1874419 ] JDBC Statement not close in a finally block
Organize Imports
2008-02-08 10:04:43 +00:00
Redhuan D. Oon 6400fd0d45 *BF [ 1874419 ] JDBC Statement not close in a finally block
Organize Imports
2008-02-08 10:02:07 +00:00
Redhuan D. Oon 7e51491b76 *BF [ 1874419 ] JDBC Statement not close in a finally block
Organize Imports
2008-02-08 09:59:52 +00:00
Redhuan D. Oon c9678e1527 *BF [ 1874419 ] JDBC Statement not close in a finally block
Organize Imports
2008-02-08 09:57:28 +00:00
Redhuan D. Oon f73b7e164b *BF [ 1874419 ] JDBC Statement not close in a finally block
Organize Imports
2008-02-08 09:54:56 +00:00
Redhuan D. Oon a1dec79980 *BF [ 1874419 ] JDBC Statement not close in a finally block
Organize Imports
2008-02-08 09:48:23 +00:00
Redhuan D. Oon 84ed404db1 *BF [ 1874419 ] JDBC Statement not close in a finally block 2008-02-08 09:46:03 +00:00
Redhuan D. Oon dc20d4e7b3 *BF [ 1874419 ] JDBC Statement not close in a finally block
Organize Imports
2008-02-08 09:40:53 +00:00
Redhuan D. Oon e9675e3e9d *BF [ 1874419 ] JDBC Statement not close in a finally block
Organize Imports
Parameterize ArrayList<String>
2008-02-08 09:36:22 +00:00
Redhuan D. Oon 434a2b8a7b left out many other *BF [ 1874419 ] JDBC Statement not close in a finally block
thanks to Teo for the tips
2008-02-08 09:32:10 +00:00
Redhuan D. Oon a82a15d41f *BF [ 1874419 ] JDBC Statement not close in a finally block
*Organize imports

*Parameterized entry <String>
2008-02-08 09:02:37 +00:00
Redhuan D. Oon 75a342b900 *BF [ 1874419 ] JDBC Statement not close in a finally block
*Organize imports

*Parameterized entry
2008-02-08 08:51:29 +00:00
Redhuan D. Oon 37bfc101b5 *BF [ 1874419 ] JDBC Statement not close in a finally block
*Organize imports
2008-02-08 08:43:21 +00:00
Redhuan D. Oon 4d6fcf009b *BF [ 1874419 ] JDBC Statement not close in a finally block
*Organize imports

*Parameterized - Iterator<Integer> it = set.iterator();
2008-02-08 07:49:23 +00:00
mark_o 4507624a86 [ 1883270 ] Enhance Document No Formatting
Adds Decimal Pattern for sequence number itself.
Solution provided by Tobi42 (Tobias Schöneberg). Sorry accidently removed MSequence instead of updating it.

Tested with PostgresSQL.

Please review for oracle.
2008-02-07 17:09:49 +00:00
Carlos Ruiz 8296c2c899 Fix [ 1888892 ] Possible BUG on FinReport.java
Thanks to Angelo - Genied

BF [ 1874419 ] JDBC Statement not close in a finally block
2008-02-07 17:07:30 +00:00
mark_o 37a6123696 [ 1883270 ] Enhance Document No Formatting
Adds Decimal Pattern for sequence number itself.
Solution provided by Tobi42 (Tobias Schöneberg)

Tested with PostgresSQL.

Please review for oracle.
2008-02-07 16:35:53 +00:00
Carlos Ruiz ba07d01b9d Fix [ 1888832 ] NPE starting adempiere 2008-02-07 15:11:24 +00:00
Redhuan D. Oon 71ee0da862 BF [ 1874419 ] JDBC Statement not close in a finally block - fixed
* reorganized imports
2008-02-07 14:52:40 +00:00
Carlos Ruiz f5fbec1f66 FR [ 1795384 ] Setup: create default accounts records is too rigid
Contributed by Teo

BF [ 1874419 ] JDBC Statement not close in a finally block
2008-02-07 05:03:23 +00:00
Carlos Ruiz d812e54ea8 Integrate contribution [ 1886164 ] Posting Doc_Issue from Expense Report
from Ivan Popov (johnniepop)

BF [ 1874419 ] JDBC Statement not close in a finally block
2008-02-07 03:48:58 +00:00
teo_sarca 931881e153 BF [ 1760482 ] New Dashboard broke old functionality 2008-02-06 20:12:05 +00:00
teo_sarca 9cef24d42a BF [ 1888085 ] One line location field not working
BF [ 1888094 ] PF: label & label suffix not working for location field
2008-02-06 18:32:52 +00:00
teo_sarca 4e1a51836b BF [ 1887674 ] Deadlock when try to modify PA Goal's Measure Target 2008-02-06 08:19:21 +00:00
teo_sarca 71bd400ba9 BF [ 1874419 ] JDBC Statement not close in a finally block - fixed for org.compiere.model.MMeasure 2008-02-06 08:02:35 +00:00
teo_sarca 2cd9802c0f BF [ 1874419 ] JDBC Statement not close in a finally block - fixed for org.compiere.model.MGoal 2008-02-06 07:55:53 +00:00
Carlos Ruiz 65bb91b9e5 Put again to false to allow running in Headless environment 2008-02-06 06:01:39 +00:00
Carlos Ruiz 9c85560ff3 Removing some unnecesary code after [ 1886013 ] MSequence.getNextId should be executed outside of trx 2008-02-06 05:30:22 +00:00
Carlos Ruiz 14deebdab7 Fix [ 1887608 ] SequenceCheck deadlock 2008-02-06 04:58:15 +00:00
Carlos Ruiz f9c0eaed7d More logging on nightly build scripts 2008-02-06 01:43:57 +00:00
Carlos Ruiz 58a3dfbd0a Logging to troubleshoot nightly build problem 2008-02-06 01:15:42 +00:00
Heng Sin Low e8da8ed403 [ 1706651 ] Fixed lookup behaviour on Ranged Parameters 2008-02-05 16:46:35 +00:00
Heng Sin Low 0c21b7f328 [ 1874419 ] JDBC Statement not close in a finally block 2008-02-05 08:52:24 +00:00
Carlos Ruiz 7032937dc6 Fix [ 1886773 ] isTradeDiscountPosted not working 2008-02-05 08:43:21 +00:00
Heng Sin Low 7891512128 [ 1874419 ] JDBC Statement not close in a finally block 2008-02-05 08:34:52 +00:00
Heng Sin Low 1873121a4e [ 1886731 ] org.compiere.model.MSequence looking for nonexistant columns 2008-02-05 07:56:12 +00:00
Carlos Ruiz 8c427dbb6c Fix [ 1876965 ] Wrong serial management on purchase process 2008-02-05 07:17:17 +00:00
teo_sarca 3eff6ddfe5 BF [ 1874419 ] JDBC Statement not close in a finally block - for ProductCost, Tax, Env, Msg 2008-02-04 23:50:24 +00:00
teo_sarca 432cfe0bc9 BF [ 1874419 ] JDBC Statement not close in a finally block - fixed for MChangeLog
* reorganize imports
2008-02-04 23:16:05 +00:00
teo_sarca b0a302589c BF [ 1874419 ] JDBC Statement not close in a finally block - fixed for MChangeLog
* reorganize imports
2008-02-04 23:12:49 +00:00
teo_sarca 751ef01796 BF [ 1874419 ] JDBC Statement not close in a finally block - fixed for MChangeLog 2008-02-04 21:09:33 +00:00
teo_sarca 8805fceef2 * reorganized imports
* commented some unused variables
* fixed java 5 warnings
2008-02-04 20:40:34 +00:00
Redhuan D. Oon 874cd059de BF [ 1874419 ] JDBC Statement not close in a finally block
this is a deep one to db.close, many stmt/rs closes in between removed. Need for review. Already done simple grid field entry test - ok.
2008-02-04 18:27:17 +00:00
teo_sarca e5d3c08749 BF [ 1886480 ] Print Format Item Trl not updated even if not multilingual 2008-02-04 18:23:07 +00:00
Redhuan D. Oon f8d99975df BF [ 1874419 ] JDBC Statement not close in a finally block
done.
2008-02-04 18:09:23 +00:00
teo_sarca 5e26c9cc02 * reorganize imports from MSequence 2008-02-04 12:27:56 +00:00
Carlos Ruiz 154a633c70 A little more on FR [ 1879470 ] Implement Table and Document ModelValidator script JSR 223 2008-02-04 06:57:34 +00:00
Heng Sin Low b67b5a1268 [ 1886013 ] MSequence.getNextId should be executed outside of trx 2008-02-04 03:38:19 +00:00
Redhuan D. Oon a5d9c4efff Done for all Callouts
1. Remove deprecated CalloutActive sets
2. BF [ 1874419 ] JDBC Statement not close in a finally block

Not tested, assume no new impact
2008-02-04 00:19:09 +00:00
teo_sarca 4bb15e12d2 BF [ 1874419 ] JDBC Statement not close in a finally block - fixed for Query 2008-02-03 10:20:36 +00:00
teo_sarca fba218d872 * minor message translation issue 2008-02-03 10:15:21 +00:00
teo_sarca 6608962f25 BF [ 1874419 ] JDBC Statement not close in a finally block - fixed for MLocator 2008-02-03 10:13:06 +00:00
teo_sarca e4152c7582 BF [ 1885260 ] MPAttributeLookup: throws SQLException sometimes
* reorganize imports
* commented out unused variables
2008-02-03 09:00:00 +00:00
Redhuan D. Oon 0ad10e90d3 1. Reorganize Imports
2. Remove deprecated CalloutActive sets
3. BF [ 1874419 ] JDBC Statement not close in a finally block

tested with single POS order, export pricelist, patio BP, invalid complete due to no cash book, change to Std Order, completes ok.

committing for review
2008-02-03 03:28:55 +00:00
Carlos Ruiz 0a15b4a374 [ 1755175 ] ad_changelog should capture insert too
[ 1755177 ] ad_changelog should have an 'action' field
2008-02-03 02:23:21 +00:00
Carlos Ruiz b2865c6d2f [ 1885417 ] Validate BP on Payment Prepare or BeforeSave 2008-02-03 00:25:18 +00:00
Carlos Ruiz c722164b1f [ 1854603 ] Prepare method is being called twice
Make main and children workflows run in the same thread as the window caller
2008-02-02 19:58:55 +00:00
Carlos Ruiz d7c31694e4 Fix [ 1773939 ] Processing button is treated as always updateable 2008-02-02 18:33:54 +00:00
teo_sarca 23c4031415 org.compiere.model.PO:
* BF [ 1874419 ] JDBC Statement not close in a finally block
* minor - PO.get_xmlString - was exporting xml without indentation
2008-02-02 09:39:22 +00:00
teo_sarca 92b24e05b8 BF [ 1878743 ] SvrProcess.getAD_User_ID 2008-02-02 07:41:54 +00:00
Heng Sin Low 0eb0137c73 [ 1883270 ] Enhance Document No Formatting 2008-02-02 04:49:59 +00:00
Redhuan D. Oon 4ffe1affbd BF [ 1874419 ] JDBC Statement not close in a finally block
ACTION: Done two db.close acts. Please review.
TESTS:
Tested in Eclipse debug to confirm methods called without incident.
Compiled deployed on desktop, looks OK.
Committing for higher level review.
2008-02-02 00:19:13 +00:00
Redhuan D. Oon 84b3b5b135 Reorganize Import of Base.java
After some runs for a day, now wishing to commit direct to trunk. Nothing to review
2008-02-02 00:15:17 +00:00
teo_sarca 5ded70c335 BF [ 1564496 ] Inventory Move should warn if insufficient stock on hand 2008-02-01 21:20:47 +00:00
teo_sarca f8d10212a8 BF [ 1874419 ] JDBC Statement not close in a finally block - fixed for MStorage 2008-02-01 21:06:15 +00:00
teo_sarca b323065f13 FR [ 1884435 ] Add more DB.getSQLValue helper methods 2008-02-01 20:34:30 +00:00
Carlos Ruiz 567288fbae Fix [ 1783036 ] Change log management inconsistent for update and delete 2008-02-01 18:34:00 +00:00
Carlos Ruiz 220c7b8580 Fix again [ 1686341 ] List Datatype bug 2008-02-01 18:13:02 +00:00
Carlos Ruiz 72632c33df Integrate fix [ 1773939 ] Processing button is treated as always updateable
Proposed by Bahman
2008-02-01 18:01:48 +00:00
Carlos Ruiz d19b2cd1ea Fix for [ 1884676 ] Fact not setting transaction 2008-02-01 17:25:45 +00:00
teo_sarca c97242420c org.compiere.util.DB:
* reorganize imports
* commented unused variables (from old connection code)
* minor cleanup
2008-02-01 17:14:56 +00:00
teo_sarca bd8324ebb9 FR [ 1884435 ] Add more DB.getSQLValue helper methods 2008-02-01 17:05:56 +00:00
Carlos Ruiz 071d9768d8 BF [ 1874419 ] JDBC Statement not close in a finally block 2008-02-01 16:33:58 +00:00
Carlos Ruiz 3d2bae2080 FR [ 1879470 ] Implement Table and Document ModelValidator script JSR 223 2008-02-01 08:48:22 +00:00
Heng Sin Low 9932a8538e * minor - missing image file shouldn't be log as error or warning. 2008-02-01 04:21:26 +00:00