Commit Graph

61 Commits

Author SHA1 Message Date
hengsin b22ceeabdf
IDEMPIERE-4747 Pass PO object from MWFProcess to MWFActivity (#646)
Fix unit test error.
2021-04-08 21:20:49 +08:00
Elaine Tan 27f21e0384
IDEMPIERE-4696 Wrong GL Currency Balancing in payment allocation for payment reverse/accrual (#621)
* IDEMPIERE-4696 Wrong GL Currency Balancing in payment allocation for payment reverse/accrual
2021-03-15 21:18:25 +08:00
Elaine Tan c7854316be
IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line (#619)
* IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line
2021-03-10 18:09:13 +08:00
hengsin 1971b4f0dc
IDEMPIERE-4488 Remove .classpath from repository (#607)
* IDEMPIERE-4488 Remove .classpath from repository

* IDEMPIERE-4488 Remove .classpath from repository

add ignore for .classpath

* IDEMPIERE-4488 Remove .classpath from repository

remove ".settings/org.eclipse.jdt.core.prefs"

* IDEMPIERE-4488 Remove .classpath from repository

fix false status report for /bin and .project
2021-03-03 00:02:03 +01:00
hengsin 3beccdf38e
IDEMPIERE-4722 Remove constraint that idempiere source folder must be… (#606)
* IDEMPIERE-4722 Remove constraint that idempiere source folder must be used as Eclipse workspace

use project_loc of org.adempiere.base instead of workspace_loc
integrate additional fix from Carlos
2021-03-02 20:51:20 +08:00
hengsin 4ebf81b1d2
IDEMPIERE-4704 Add base interface and class that uses generic type and lambda function for osgi factory that create new instance by class name or a string key (#595)
Fix unit test error when running through maven/jenkin (mvn verify
-DskipTests=false)
2021-02-18 18:22:07 +01:00
hengsin 5e60c443d2
IDEMPIERE-4704 Add base interface and class that uses generic type and lambda function for osgi factory that create new instance by class name or a string key (#585) 2021-02-16 11:24:31 +01:00
hengsin 4b20720932
IDEMPIERE-4690 Add column callout factory base class backed by Map and Lambda functional object (#587)
Refactoring. Add unit test for gridtab and callout.
2021-02-16 11:20:42 +01:00
hengsin dda6ede13d
IDEMPIERE-4694 Implement thread safe, annotation based osgi event handling (#581)
Fix testFactValidate unit test fail with seed db due to No Cost error
for Azalea Bush
2021-02-12 10:07:00 +01:00
hengsin ee77620186
IDEMPIERE-4694 Implement thread safe, annotation based osgi event han… (#571)
* IDEMPIERE-4694 Implement thread safe, annotation based osgi event handling

Make sure the component register in the event handler unit test cases
wouldn't have impact on other unit test cases.
2021-02-10 16:12:16 +01:00
hengsin c757fbaab7
IDEMPIERE-4695 Add document factory base class backed by Map and Lambda functional object (#576)
MappedDocumentFactoryTest fail when running idempiere.unit.test due to
document factory cache.
2021-02-10 16:02:13 +01:00
hengsin c159ce5325
IDEMPIERE-4695 Add document factory base class backed by Map and Lambda functional object (#572) 2021-02-09 19:17:15 +01:00
hengsin ddd1c40eb2
IDEMPIERE-4690 Add column callout factory base class backed by Map an… (#567)
* IDEMPIERE-4690 Add column callout factory base class backed by Map and Lambda functional object

Fix column callout factory cache.

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-02-06 14:53:59 +01:00
hengsin 1c5a28aa0a
IDEMPIERE-4689 Add process factory base class backed by Map and Lambda functional object (#566) 2021-02-06 14:37:04 +01:00
hengsin 0f263f1c79
IDEMPIERE-4675 Add model factory base class backed by Map and Lambda … (#555)
- added interface and default mapped model factory service
- added unit test for default mapped model factory service
2021-02-01 15:29:13 +01:00
hengsin f5e9cd9336
IDEMPIERE-4654 Sales Order After Receipt Delivery Rule is not working (#536)
* IDEMPIERE-4654 Sales Order After Receipt Delivery Rule is not working

create shipment if it is fully paid and stock is available
use currencyconvertpayment
- rename after receipt to after payment
- added unit test for invoice payment

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-01-26 19:34:38 +08:00
hengsin 9370dbb77e
IDEMPIERE-4659 MStorageOnHand and MStorageReservation api improvements (#545) 2021-01-24 17:30:51 +01:00
Elaine Tan f3741b8f31
IDEMPIERE-4656 Incorrect rate in the MR postings when the currency type of the order is 'Company' (#537)
* IDEMPIERE-4656 Incorrect rate in the MR postings when the currency type of the order is 'Company'
2021-01-21 11:58:50 +08:00
hengsin d96199a2b6
IDEMPIERE-4251 Constant definition for all Env Context (#519)
* IDEMPIERE-4251 Constant definition for all Env Context

replace "#Date" with Env.DATE

* IDEMPIERE-4251 Constant definition for all Env Context

replace "#.." with constant at Env

* IDEMPIERE-4251 Constant definition for all Env Context

Merge patch from Carlos
2021-01-12 21:29:50 +08:00
Carlos Ruiz 11dc7a391f
IDEMPIERE-4623 Cash POS Sales Order is leaving wrong BP balance (#504) 2021-01-03 20:08:16 +08:00
Diego Ruiz da6d6b83aa
IDEMPIERE-4607 Cannot export windows via 2pack if any field has a Fie… (#483)
* IDEMPIERE-4607 Cannot export windows via 2pack if any field has a Field Group

* IDEMPIERE-4607 Implement changes discussed in JIRA - Add a new isList method to DisplayType

* IDEMPIERE-4607 Fixed typo

* IDEMPIERE-4607 Implement default method to return false by default - PR CarlosRuiz
2020-12-26 16:35:50 +01:00
Carlos Ruiz 8103ab0732 IDEMPIERE-4604 Release 8.2
Change references to new version
Create new migration folder
2020-12-20 10:15:20 +01:00
Carlos Ruiz 6c5d54d7f7 IDEMPIERE-4604 Release 8.2
Fix import warnings
2020-12-20 09:53:49 +01:00
Carlos Ruiz 6390ce20cd IDEMPIERE-4604 Release 8.2
Fix warnings on MANIFEST.MF
2020-12-20 09:53:21 +01:00
Carlos Ruiz 5da1785572
IDEMPIERE-4596 Cannot create a product and an inventory document in t… (#459)
* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction

WIP - commit failing unit test

* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction

Implement solution suggested by @hengsin

* minor fix comment
2020-12-12 16:12:31 +01:00
Carlos Ruiz 350f101d0c
IDEMPIERE-4289 Implement Support for JUnit5 Unit Testing (#447)
Fix launcher to avoid adding all custom plugins every time I try to execute it
2020-12-10 06:25:30 +08:00
Carlos Ruiz d654ed5791
IDEMPIERE-4587 Wrong ordered qty when reactivating a purchase order and setting a line to zero (#445) 2020-12-09 20:49:01 +01:00
hieplq 58c6716253
IDEMPIERE-4360 exclude generate and test code to speed up (#440)
* IDEMPIERE-4360 add sonarcloud.io

* IDEMPIERE-4360 add sonarcloud.io (update properties)

* IDEMPIERE-4360 add sonarcloud.io (optimize)

1. when use matrix for codeql-action then job of javascript run same job of java (mvn, sonar)
so don't use matrix do define separate job let javascript job faster a lot
2. reduce maven log and sonar log from info to warn
3. move project info from pom to yml let fork central place customize CI

* IDEMPIERE-4360 turn off sonar at PR because not yet support

https://stackoverflow.com/a/39720346

* IDEMPIERE-4360 exclude generate and test code to speed up

* IDEMPIERE-4360 add sonarcloud.io (optimize)

1. parallel sonar and code QL
2. parameter for repository owner (org)
2020-12-06 16:50:14 +01:00
Carlos Ruiz bf65636e22
IDEMPIERE-4577 Problem creating an invoice vendor negative after the … (#428)
* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment

* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment

Add unit test
2020-12-02 21:08:41 +08:00
Carlos Ruiz 0eb4986513
IDEMPIERE-4575 Cannot complete Material Receipt from negative PO (#419) 2020-11-28 07:09:39 +08:00
hengsin 0d381faf99
IDEMPIERE-4187 implement the usage of workflows in processes (#416)
- incorporate suggestion from Martin Schönbeck to unit test
2020-11-26 14:17:40 +01:00
Carlos Ruiz 460f7116a2
IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong … (#414)
* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance

MAllocationHdr.updateBP was broken, the form Payment Allocation worked just because it was calling bpartner.setTotalOpenBalance() at the end
so, I refactored the MAllocationHdr.updateBP and before/afterDelete to call bpartner.setTotalOpenBalance instead if the broken algorithm

Unit test added for allocating and deleting a customer invoice, a vendor invoice, and a charge

* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance

- Fix peer review changes requested by @hengsin
- Detected double call to bpartner.setTotalOpenBalance in WAllocation
- Detected some business partners in GardenWorld with wrong TotalOpenBalance or SO_CreditUsed, added migration script to fix it, it made more complicate to write unit tests as the data was wrong
2020-11-26 17:08:05 +08:00
Carlos Ruiz 210e54b05f IDEMPIERE-4521 Release 8.1 - RC
Change versions in pom and manifest files
2020-11-03 21:59:12 +01:00
hieplq 6e96c43303
IDEMPIERE-4492 fix for rest api (#343)
* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 update atmosphere to 2.5.15

* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 (update configuration)

update to default jetty configuration
delete unused configuration (alpn, http2,..)

* IDEMPIERE-4492 update orbit eclipse repository to 4.17

* IDEMPIERE-4492 update orbit eclipse repository to 4.17 (on parent pom)

* IDEMPIERE-4492 update jasper to 6.15.0

* IDEMPIERE-4492 update jasper to 6.15.0 (IDEMPIERE-4504)

get rid of bundle "org.w3c.dom.events version 3.0.0" by use old version of org.w3c.dom.smil

note: on target platform a bundle has multi version then tycho can pickup correct version define on feature (tab included plugins, field version)
but on eclipse when sync launching from .product it don't respect that value, always set highest version to bundle
workaround: on target platform manual un-select bundle org.w3c.dom.smil 1.0.1

* IDEMPIERE-4492 update atmosphere to 2.6.4

* IDEMPIERE-4492 refine target platform

use targetplatform-dsl to generate target platform https://github.com/eclipse-cbi/targetplatform-dsl
   + don't need to care update bundle version when update repository
   + at moment org.idempiere.eclipse.platform-feature include some feature form eclipse repository
     so target has to include that feature so target platform will include all bundler request by feature and bundle request by plugins of that feature and so on (ever optional
     so it make target content has more plugins than what we use on project
     next step will convert include feature to include plugins to define only what we used

* IDEMPIERE-4492 refine target platform (continue)

don't include framework feature, use include plugins to void load transitive dependency so minimize target flatform
remove some unused feature from idempiere product

* IDEMPIERE-4492 update c3p0 and database jdbc (patch from Carlos)

* IDEMPIERE-4492 improve target platform (continue)

provide test bundle require to repository for use on offline
remove some unused bundle
also fix for IDEMPIERE-4475

* IDEMPIERE-4492 improve target platform (continue IDEMPIERE-4475)

add launch for unittest
add more require bundle for unit test

* IDEMPIERE-4492 fix for rest api

refer:https://github.com/eclipse-ee4j/jersey/issues/3588#issuecomment-720033467

* IDEMPIERE-4492 fix for rest api

refer:https://github.com/eclipse-ee4j/jersey/issues/3588#issuecomment-720033467
2020-11-01 13:22:11 +01:00
hengsin b4c93c76b3
IDEMPIERE-4516 InvoiceCustomerTest show NPE at console (#342)
* IDEMPIERE-4516 InvoiceCustomerTest show NPE at console

add NPE check

* IDEMPIERE-4516 InvoiceCustomerTest show NPE at console

- add way to defer the immediate posting of doc that's means to be
posted in the processing of docpostprocess of the source document.
- add severe log check to InvoiceCustomerTest
- DocumentEngine should skip Doc from DocPostProcess that have been
posted
2020-11-01 12:43:36 +01:00
hieplq d2a2e3d19f
Idempiere 4492 improve target platform (continue) (#335)
* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 update atmosphere to 2.5.15

* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 (update configuration)

update to default jetty configuration
delete unused configuration (alpn, http2,..)

* IDEMPIERE-4492 update orbit eclipse repository to 4.17

* IDEMPIERE-4492 update orbit eclipse repository to 4.17 (on parent pom)

* IDEMPIERE-4492 update jasper to 6.15.0

* IDEMPIERE-4492 update jasper to 6.15.0 (IDEMPIERE-4504)

get rid of bundle "org.w3c.dom.events version 3.0.0" by use old version of org.w3c.dom.smil

note: on target platform a bundle has multi version then tycho can pickup correct version define on feature (tab included plugins, field version)
but on eclipse when sync launching from .product it don't respect that value, always set highest version to bundle
workaround: on target platform manual un-select bundle org.w3c.dom.smil 1.0.1

* IDEMPIERE-4492 update atmosphere to 2.6.4

* IDEMPIERE-4492 refine target platform

use targetplatform-dsl to generate target platform https://github.com/eclipse-cbi/targetplatform-dsl
   + don't need to care update bundle version when update repository
   + at moment org.idempiere.eclipse.platform-feature include some feature form eclipse repository
     so target has to include that feature so target platform will include all bundler request by feature and bundle request by plugins of that feature and so on (ever optional
     so it make target content has more plugins than what we use on project
     next step will convert include feature to include plugins to define only what we used

* IDEMPIERE-4492 refine target platform (continue)

don't include framework feature, use include plugins to void load transitive dependency so minimize target flatform
remove some unused feature from idempiere product

* IDEMPIERE-4492 update c3p0 and database jdbc (patch from Carlos)

* IDEMPIERE-4492 improve target platform (continue)

provide test bundle require to repository for use on offline
remove some unused bundle
also fix for IDEMPIERE-4475

* IDEMPIERE-4492 improve target platform (continue IDEMPIERE-4475)

add launch for unittest
add more require bundle for unit test
2020-10-31 13:48:16 +01:00
hieplq 58258ad506
Idempiere-4492 update library (eclipse-4.17, jasper 6-15, jetty-9.4.33, atmosphere-2.6.4) (#331)
* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 update atmosphere to 2.5.15

* IDEMPIERE-4492 update jetty to 9.4.33.v20201020 (update configuration)

update to default jetty configuration
delete unused configuration (alpn, http2,..)

* IDEMPIERE-4492 update orbit eclipse repository to 4.17

* IDEMPIERE-4492 update orbit eclipse repository to 4.17 (on parent pom)

* IDEMPIERE-4492 update jasper to 6.15.0

* IDEMPIERE-4492 update jasper to 6.15.0 (IDEMPIERE-4504)

get rid of bundle "org.w3c.dom.events version 3.0.0" by use old version of org.w3c.dom.smil

note: on target platform a bundle has multi version then tycho can pickup correct version define on feature (tab included plugins, field version)
but on eclipse when sync launching from .product it don't respect that value, always set highest version to bundle
workaround: on target platform manual un-select bundle org.w3c.dom.smil 1.0.1

* IDEMPIERE-4492 update atmosphere to 2.6.4

* IDEMPIERE-4492 refine target platform

use targetplatform-dsl to generate target platform https://github.com/eclipse-cbi/targetplatform-dsl
   + don't need to care update bundle version when update repository
   + at moment org.idempiere.eclipse.platform-feature include some feature form eclipse repository
     so target has to include that feature so target platform will include all bundler request by feature and bundle request by plugins of that feature and so on (ever optional
     so it make target content has more plugins than what we use on project
     next step will convert include feature to include plugins to define only what we used

* IDEMPIERE-4492 refine target platform (continue)

don't include framework feature, use include plugins to void load transitive dependency so minimize target flatform
remove some unused feature from idempiere product

* IDEMPIERE-4492 update c3p0 and database jdbc (patch from Carlos)
2020-10-31 06:53:36 +08:00
hengsin 9162b60af7
IDEMPIERE-4498 Performance: add cache for osgi services factory (#321)
* IDEMPIERE-4498 Performance: add cache for osgi services factory

add cache for tableName -> IModelFactory

* IDEMPIERE-4498 Performance: add cache for osgi services factory

implement cache for the discovery of osgi services

* IDEMPIERE-4498 Performance: add cache for osgi services factory

added unit test
2020-10-26 18:53:10 +01:00
hengsin 6e9a547049
IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency (#317)
- minor unit testing improvement
2020-10-26 18:24:57 +01:00
hengsin 57e4e3fceb
IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency (#316)
- Fix error in setting the currency for source amount
- Improve unit test to check source amount precision as well
2020-10-22 20:48:07 +08:00
Elaine Tan c4b39eac8c
IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency (#313)
* IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency

* IDEMPIERE-4128 Matched invoice posting with wrong precision based on transaction currency instead of schema currency - Added MatchInvTest.testMatReceiptPostingWithDiffCurrencyPrecision test case
2020-10-22 15:40:42 +08:00
hengsin 4c1ba12a3f
IDEMPIERE-3212 Quantity MatchPO wrong validation (#269)
Fix auto matching for matchpo and matchinv
2020-09-21 20:00:31 +02:00
hengsin dd2ef468b0
IDEMPIERE 4287 (#247)
* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
add support to make PO immutable

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added thread safe Immutable and Copy cache implementation for PO.
- migrate most of PO cache to immutable and copy cache.
- added pos sales order test.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- add test case for initial client setup and bank statement
- fix error for image editor, location editor, locator editor, initial
client setup, complete bank statement and migrate storage provider.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added ImmutablePOSupport interface. Model class implement this
interface for immutable PO support.
- remove usage of cache for transaction table (rfq, invoice, inventory).
- add getCopy method to some model class to support getting an
updateable copy of PO from the otherwise immutable PO cache.
- the added getCopy method is use to return updateable PO for indirect
PO reference, for e.g MColumn.getAD_Table() and MOrderLine.getProduct.
2020-09-21 14:03:00 +08:00
Elaine Tan 79d6c1e903
IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line (#250)
* IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line
2020-09-18 20:58:14 +08:00
Carlos Ruiz 703ce7bda8
IDEMPIERE-4289 Implement Support for JUnit5 Unit Testing (#262)
Move the old Convert_PostgreSQLTest to the new structure
2020-09-18 12:17:40 +02:00
Elaine Tan 236729e3f5
IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Re… (#239)
* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo

* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo - Added test case
2020-09-10 20:49:25 +08:00
hengsin 7324dde78e
IDEMPIERE-4187 implement the usage of workflows in processes (#236)
Implement chaining of workflow through the use of Process Action
Implement overwrite of Record_ID for Process through Node Parameter
2020-08-27 14:34:26 +02:00
hengsin 60f4ea4215
IDEMPIERE-4406 Performance: PO Cache should not always reset all entr… (#212)
* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

PO update - reset cache by record id

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

refine unit test

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

add cache reset fix for delete

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

Fix exception when cache is empty
Expose hidden cache reset exception
2020-08-11 14:55:03 +02:00
hengsin c17f1ae733
IDEMPIERE-4389 (#206)
* IDEMPIERE-4389 Implement Copy Constructor support for PO

Implement PO support for copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

deprecate clone
replace clone with copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

add unit test for MPrintFormat copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

fix wrong import
2020-08-05 21:03:40 +02:00
hengsin f010b10446
IDEMPIERE-4393 Replace Oracle outer join synax (+) with SQL standard outer join (#199)
add native postgresql unit test for GenericPaymentExport
remove unnecessary static and fix sql exception doesn't stop the export
replace Oracle (+) with standard sql outer joint
2020-08-03 12:04:53 +02:00