* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance
MAllocationHdr.updateBP was broken, the form Payment Allocation worked just because it was calling bpartner.setTotalOpenBalance() at the end
so, I refactored the MAllocationHdr.updateBP and before/afterDelete to call bpartner.setTotalOpenBalance instead if the broken algorithm
Unit test added for allocating and deleting a customer invoice, a vendor invoice, and a charge
* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance
- Fix peer review changes requested by @hengsin
- Detected double call to bpartner.setTotalOpenBalance in WAllocation
- Detected some business partners in GardenWorld with wrong TotalOpenBalance or SO_CreditUsed, added migration script to fix it, it made more complicate to write unit tests as the data was wrong
- Deprecate zk form WTranslationDialog and controller TranslationController
- Move the logic to a java process org.idempiere.process.TranslationImpExp
- As a process works in mobile, can be called via webservices, tested with fitnesse, etc
- Importing leaves a better and readable log of each file processed
- Importing/Exporting gives feedback to the user about the file being processed
Side note:
- To standardize the menu - renamed the "Initial Client Setup Process" to "Initial Client Setup"
Improvements over the previous form:
- can process the files from the zip in root folder, or in internal folder with the name of the language
- can process a URL http/https to download the zip file
- fix the PO is immutable errors
- forbid that system nodes are changed by non-system users
- system nodes are shown in gray
- reorganize layout of system workflows in editor
- make the nodes smaller
- fix the layout problem of name and properties dialogs
Found issue in _Bank/Cash Statement_ window, button _Create lines from_ is creating all lines (payments and receipts) positive, the correct behavior must be to create the receipts positive and payments negative.
To fix this:
* the function currencyConvertPayment was modified to use C_Payment_V instead of C_Payment
* the columns currencyrate, convertedamt and isoverridecurrencyrate were added to the view C_Payment_V
* the definition of the view C_Payment_V was moved from script to dictionary (easier to add new columns in future)
* IDEMPIERE-1117 Attachment -> Disable preview over certain size
Add message Preview
* IDEMPIERE-1117 Attachment -> Disable preview over certain size
Move to correct folder
Carlos Ruiz
Orlando Curieles