Commit Graph

2883 Commits

Author SHA1 Message Date
Armen Hovhannisyan b8437b2c23
IDEMPIERE-4867 Updating moving node by PO (#810)
* Using PO update for all node that's being updated

* Using saveEx(trxName) when saving PO for all updated nodes

* Checking PO.is_Changed() and using saveEx(trxName) when saving PO for all updated nodes
2021-08-12 23:24:11 +08:00
Carlos Ruiz 5ede13acee
IDEMPIERE-4908 Not unique in the ID space of ... breadcrumb with same name tabs (FHEG-8847) (#822) 2021-08-11 19:37:44 +08:00
Carlos Ruiz e41fcdea2f
IDEMPIERE-4140 Improvement to the layout of the info Windows (#820)
Implement suggestion from Flemming Birch to fix find dialog status count
Co-authored-by: gsjeffen <public@birch-rasmussen.dk>
2021-08-07 12:15:39 +02:00
Carlos Ruiz 63c327dde4
IDEMPIERE-4902 : Record migration scripts with Dictionnary EntityType (#817)
minor - remove eclipse warning
2021-08-05 17:07:25 +02:00
Nicolas Micoud 997018233f
IDEMPIERE-4902 : Record migration scripts with Dictionnary EntityType (#816)
* IDEMPIERE-4902 : Record migration scripts with Dictionnary EntityType

* IDEMPIERE-4902 : Record migration scripts with Dictionnary EntityType - fix migration scripts

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-4902 : Record migration scripts with Dictionnary EntityType - move migration scripts to i8.2

* IDEMPIERE-2523

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-08-05 14:51:14 +02:00
Carlos Ruiz db22889fa1
IDEMPIERE-4140 cph::erp Improvement to the layout of the info Windows (#807)
Co-authored-by: gsjeffen <public@birch-rasmussen.dk>
2021-07-30 11:01:03 +02:00
hengsin 3e7dd1f7f7
IDEMPIERE-4410 Review Shortcuts (probably ESC) for all popovers, moda… (#795)
* IDEMPIERE-4410 Review Shortcuts (probably ESC) for all popovers, modals, dialogs

add esc shortcut for customize grid view, attachment, csv import loader,
export, file import loader, chat and post it dialogs.

* IDEMPIERE-4410 Review Shortcuts (probably ESC) for all popovers, modals, dialogs

- add esc handling to more dialog and popup.

* IDEMPIERE-4410 Review Shortcuts (probably ESC) for all popovers, modals, dialogs

- add esc shortcut to process modal dialog.

* IDEMPIERE-4410 Review Shortcuts (probably ESC) for all popovers, modals, dialogs

- Fix esc handling for numberbox, image dialog, email dialog, media
dialog and cloud upload dialog.
2021-07-27 21:43:28 +02:00
hengsin f5dc3ba2c8
IDEMPIERE-4059 Print format editor (#794) 2021-07-26 14:42:29 +02:00
hengsin 8f758ed904
IDEMPIERE-1994 Ability to organise process and report parameters by F… (#791)
* IDEMPIERE-1994 Ability to organise process and report parameters by Field Group functionality

* IDEMPIERE-1994 Ability to organise process and report parameters by Field Group functionality

Fix collapsed by default not working.
2021-07-24 11:05:49 +02:00
Nicolas Micoud a4dfd191ec
IDEMPIERE-4858 : CreateTable process (#774)
* IDEMPIERE-4858 : CreateTable process

* IDEMPIERE-4858 : CreateTable process - fixes

Changes following Carlos's remarks - see details in the ticket

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-4858 : CreateTable process - fixes migration scripts

See details in ticket

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-4858 : CreateTable process - various fixes

fix migration scripts names / constants in uppercase / remove check of table length

* IDEMPIERE-4858 : CreateTable process - various fixes

default value for EntityType param / replace numeric name/value params by boolean ones / enhance creation of system element (name/print name/description)
see https://idempiere.atlassian.net/browse/IDEMPIERE-4858?focusedCommentId=47325

* IDEMPIERE-4858 : CreateTable process : optional columns

* IDEMPIERE-4858 : CreateTable process : remove wrong temporary migration scripts

* IDEMPIERE-4858 : CreateTable process :

add org.adempiere.base.process as required plugin (and not as imported package)
add missing content on migration scripts

* IDEMPIERE-4858 : CreateTable process : fixes / reordering / renaming

Failed creating Description column: ** Fill mandatory fields: : Length
Value and DocumentNo are not usually mandatory
Some minor reordering and renaming of variables

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-4858 : CreateTable process : can be used to add columns on existing table

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-4858 : CreateTable process - fix default value for TableName parameter

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-4858 : CreateTable process  - restore default value for Description, Name and AccessLevel parameters

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-07-23 15:37:22 +02:00
hengsin 162c48ec4c
IDEMPIERE-4873 Jasper Report Starter Refactoring (#779) 2021-07-22 11:42:07 +02:00
hengsin 8d5cf4539d
IDEMPIERE-4887 Chosenbox: Make multi selection easier (#789) 2021-07-22 11:34:10 +02:00
hengsin c72d4609b1
IDEMPIERE-4864 Fix shortcut handling for combobox and ad window (#784)
Fix focus issue after closing of Process Info Dialog.
2021-07-20 11:17:54 +02:00
hengsin 3dcef18868
IDEMPIERE-4841 Info Window: Implement auto hide empty columns (#781) 2021-07-15 17:03:33 +02:00
Nicolas Micoud 19cfc2d07d
IDEMPIERE-4874 : Process customization must have effect on Menu and Tab title (#778) 2021-07-11 13:56:31 +08:00
Nicolas Micoud c9d7cb3afd
IDEMPIERE-4872 : Typo on form.css.dsp (pdding -> padding) (#777)
* IDEMPIERE-4872 : Typo on form.css.dsp (pdding -> padding)

Co-Authored-By: pmargery <87129041+pmargery@users.noreply.github.com>

* IDEMPIERE-4872: change in lang-addon.xml

Co-authored-by: pmargery <87129041+pmargery@users.noreply.github.com>
2021-07-10 15:46:49 +02:00
hengsin 4ed1b3b0ba
IDEMPIERE-4864 Fix shortcut handling for combobox and ad window (#769)
Fix toolbar shortcut is active when it is block by process log dialog
2021-07-06 13:25:12 +02:00
hengsin 7b55139ffa
IDEMPIERE-4864 Fix shortcut handling for combobox and ad window (#765)
* IDEMPIERE-4864 Fix shortcut handling for combobox and ad window

* IDEMPIERE-4864 Fix shortcut handling for combobox and ad window

- fix combobox keyboard navigation
- improve focus handling with mask
2021-07-06 10:40:07 +02:00
Deepak Pansheriya 72ba9fd9d3
IDEMPIERE-4837:on Product Info, only defaulting price list when window has UserPriceListInProductInfo ctx variable set. (#754) 2021-07-05 21:27:41 +02:00
hengsin 93bc73c257
IDEMPIERE-4865 Find window enhancements (#766) 2021-07-05 20:37:28 +02:00
hengsin 7d01f41f35
IDEMPIERE-4835 Grid View: Implement optional hide empty column feature (#767)
refine auto hide rule for new row
2021-07-05 20:29:15 +02:00
hengsin a5c52e1a0b
IDEMPIERE-4855 Records of Tab level 2 disappear in particular case. (#751)
* IDEMPIERE-4855 Records of Tab level 2 disappear in particular case.
2021-06-30 15:38:22 +02:00
hengsin 48f6e3b9d7
IDEMPIERE-4415 Window Toolbar, report popup flickering (#738)
* IDEMPIERE-4415 Window Toolbar, report popup flickering

- Fix an invalid css selector (z-row-over doesn't exists)
- Fix report popup flickering
2021-06-28 13:50:22 +02:00
Andreas Sumerauer 0bb5aa70f6
BUGFIX: Extensions.getQuickEntryService() - fixed cache management issue (#742)
Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-06-26 13:06:40 +08:00
Andreas Sumerauer 5f2f6364da
IDEMPIERE-4840: ConfirmPanel with Checkbox (#732)
* IDEMPIERE-4840: ConfigPanel with Checkbox

* removed checkbox vertical alignment hack

* corrected javadoc

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-06-23 11:50:02 +08:00
Carlos Ruiz 594c7bb437
IDEMPIERE-4844 Cross tenant issue on Forgot My Password (#737) 2021-06-23 11:14:21 +08:00
Andreas Sumerauer 9ad3f5ce46
IDEMPIERE-4839 IQuickForm interface (#731)
* IDEMPIERE-4839 IQuickEdit interface

* Added javadoc comments to IQuickForm method definitions.

* removed outcommented interfaces from class definition

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-06-22 14:35:58 +08:00
Carlos Ruiz 0ba9360cf0
IDEMPIERE-4514 Grid View Layout Bug (#735) 2021-06-22 14:33:25 +08:00
hengsin ded9693163
IDEMPIERE-4835 Grid View: Implement optional hide empty column feature (#727)
* IDEMPIERE-4835 Grid View: Implement optional hide empty column feature

* IDEMPIERE-4835 Grid View: Implement optional hide empty column feature

- fix issue with save width saving 0px width to
ad_tab_customization.custom
- added ad_tab_customization.IsAutoHideEmptyColumn
2021-06-19 09:24:08 +02:00
Nicolas Micoud fa7ddb7dd2
IDEMPIERE-4834 : Import Formats are not ordered on Import File Loader (#723) 2021-06-17 18:25:04 +08:00
Carlos Ruiz fa0b52abd6
IDEMPIERE-3980 (#711)
* IDEMPIERE-3980

* IDEMPIERE-3980

Restrict uploading just to valid safe image file types

* IDEMPIERE-3980
2021-06-08 22:42:47 +08:00
Carlos Ruiz a4f67eb852
IDEMPIERE-4782 Multi-factor authentication (FHCA-2034) (#705)
* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Implement suggestions from Heng Sin

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Fix security warning advised by github/CodeQL

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Implement an incremental delay in zk when the validation code is wrong (to avoid brute-force attacks)
As suggested by Ricardo Santana:
* ensures one-time only use of an OTP
* Log failures in AuthFailure.log

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

* Log failures in AuthFailure.log - add case for login with email
* Implement incremental delay also for login panel
2021-06-08 19:49:46 +08:00
Nicolas Micoud 98dc9e796c
IDEMPIERE-4808 : Payment Allocation should be IsSOTrx neutral (#703)
* IDEMPIERE-4808 : Payment Allocation should be IsSOTrx neutral

* IDEMPIERE-4808 : forms can use IsSOTrx from AD_Menu

* IDEMPIERE-4808 : add IgnoreIsSOTrxInBPInfo to be used on BPartner InfoWindow

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-06-04 09:29:37 +02:00
igorpojzl 5f2406695d
IDEMPIERE-4811 Custom Toolbar Buttons Dynamic Validation Fix (#704)
* IDEMPIERE-4811 Custom Tolbar Buttons Dynamic Validation on Detail Pane Fix

* IDEMPIERE-4811 ToolbarCustomButton - update old constructor
2021-06-03 16:38:07 +08:00
igorpojzl 01d199755b
IDEMPIERE-4803 Related Info Window Display Bug (#701)
* IDEMPIERE-4803 Related Info Window Display Bug

* IDEMPIERE-4803 Related Info Window check for CreatedBy and UpdatedBy
2021-06-01 13:45:31 +08:00
Carlos Ruiz b914083d31
IDEMPIERE-4804 Message in Reset Password Panel is misleading (#702) 2021-05-31 11:29:43 +02:00
hengsin b928043646
IDEMPIERE-4801 Add IMediaView interface and Keikai implementation (#700)
* IDEMPIERE-4801 Add IMediaView interface and Keikai implementation

* IDEMPIERE-4801 Add IMediaView interface and Keikai implementation

- Fixed some dependency issues
- Uses guava mediatype class

* minor - fix NPE when empty CSV

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-05-29 11:54:12 +02:00
Nicolas Micoud 9a21b84055
IDEMPIERE-4779 : Dashboard / Report : parameters are wrongly displayed (#690)
* IDEMPIERE-4779 : Dashboard / Report : parameters are wrongly displayed

* IDEMPIERE-4779 : Dashboard / Report : parameters are wrongly displayed

Avoid usage of DisplayType.IsID

* IDEMPIERE-4779 : Dashboard / Report : parameters are wrongly displayed

AD_Reference_Value_ID can be used for search/table/tabledir

* IDEMPIERE-4779 : Dashboard / Report : parameters are wrongly displayed

Use MLookupInfo.QueryDirect  to display value
2021-05-24 22:58:11 +08:00
igorpojzl cbfb704cb9
IDEMPIERE-434 Tab field group is not available in web (#695)
* IDEMPIERE-434  Tab field group support

* IDEMPIERE-434 Tabbox set Visible=false when no field with fieldgrouptype=tab
2021-05-24 19:51:03 +08:00
Andreas Sumerauer 3919827bc5
IDempiere-4794 (#694)
* IDEMPIERE-4794 IQuickEntry OSGI Service

* Interface IQuickeEntry replaced with abstract class AbstractWQuickEntry,
Refactorings

* QuickEntry Service used in InfoWindow. Redundant method removed.

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-05-22 15:58:02 +08:00
hengsin e8b76e24bb
IDEMPIERE-4793 Implement drag beyond page (scroll) in trees (Trek 1007493) (#693) 2021-05-20 20:31:45 +02:00
hengsin 4387b8986f
IDEMPIERE-4792 Bring back frozen column feature for desktop browser (#692)
Incorporate workaround from zk tracker and re-eanble grid frozen columns
for dekstop browser.
2021-05-20 12:10:32 +02:00
Carlos Ruiz a89a84f528
IDEMPIERE-4791 Pass PA_DashboardContent information to IDashboardGadgetFactory (#691) 2021-05-20 16:41:35 +08:00
Nicolas Micoud ca556b52ba
IDEMPIERE-4787 : Dashboard / Report : add Refresh button (#685)
* IDEMPIERE-4787 : Dashboard / Report : add Refresh button

* IDEMPIERE-4787 : Dashboard / Report : add Refresh button - applying hengsin's advices

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2021-05-17 20:06:15 +08:00
Nicolas Micoud 3b4d371fb6
IDEMPIERE-4790 : Deactivating ToolbarDetail Customize button throws NPE when using Toggle button (#689) 2021-05-17 17:43:29 +08:00
hengsin da96ecdc19
IDEMPIERE-4773 (#688)
* COF #10327 IDEMPIERE-4773 - add form factory base class backed by map and lambda functional object

Remove unnecessary white space only changes and fix wrong component name

Co-authored-by: muriloht <muriloht@devcoffee.com.br>
Co-authored-by: matheus.marcelino <matheus.marcelino@devcoffee.com.br>
2021-05-17 15:16:44 +08:00
hengsin beaaf31d9a
IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler (#679)
* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

Fix initial output type selection for csv. Fix handling of binary vs
text media type.

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

- Change AD_AuthorizationAccount scope from single value to multiple
selection list (AD_AuthorizationScopes replace AD_AuthorizationScope)

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

Fix isIntersectCSV db function

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

add back AD_AuthorizationScope Configured dynamic validation filter
2021-05-12 13:42:55 +02:00
Nicolas Micoud 8d234a8d49
IDEMPIERE-4786 : Link popup should not be opened at cursor location (#684) 2021-05-12 14:27:49 +08:00
Nicolas Micoud ad8de98fe5
IDEMPIERE-4781 : Dashboard / Report : use @SQL= syntax (#677)
* IDEMPIERE-4781 : Dashboard / Report : use @SQL= syntax

* IDEMPIERE-4781 : Dashboard / Report - be able to use Range parameters

* IDEMPIERE-4781 : Dashboard Content as Advanced

* Update DashboardController.java

Implement partial solution for IDEMPIERE-4779

Fix issue with Timestamp not working for IDEMPIERE-4781
it was throwing:
12:58:07.928-----------> DashboardController.render: Failed to create dashboard content [358]
java.lang.NumberFormatException: Error at index 6 in: "474671+02"
	at java.base/java.lang.NumberFormatException.forCharSequence(NumberFormatException.java:81)
	at java.base/java.lang.Integer.parseInt(Integer.java:735)
	at java.sql/java.sql.Timestamp.valueOf(Timestamp.java:239)
	at org.adempiere.webui.desktop.DashboardController.fillParameter(DashboardController.java:974)

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-05-11 13:10:25 +02:00
Saulo José Gil 63aec27abb
IDEMPIERE-4784 Support multiple selection lookups within process execution (#680) 2021-05-11 10:50:09 +02:00
Nicolas Micoud cdc867eb6d
IDEMPIERE-4780 : Dashboard / Report : hardcoded messages (#676) 2021-05-10 10:15:11 +08:00
Carlos Ruiz 759473f6ed
IDEMPIERE-4783 Changing the way number field with calculator are handled (#678)
* Fix not filling the box when the initial value is zero
* Fix removing  the leading zeroes to avoid octal calculations
2021-05-09 10:23:21 +02:00
Carlos Ruiz b5bcc3690e
COF #11523 / IDEMPIERE-4715 - attribute set instance: new qty available column and group results in select existing record dialog (#670)
Co-authored-by: muriloht <muriloht@devcoffee.com.br>
2021-04-28 15:28:50 +02:00
Carlos Ruiz 4e73c87e8f
IDEMPIERE-4769 False result in validation for pending changes (#661)
* IDEMPIERE-4769 False result in validation for pending changes

* * Fix also the case that changing detail is not decorating the window title with prefix *
2021-04-21 21:44:07 +08:00
Carlos Ruiz 3be5c0ac92
IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy (#660)
* IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy

* IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy

* Fix wrong selection of material date policy, must take into account isUseGuaranteeDateForMPolicy
* Fix wrong material receipt, assigning material date policy based on inventory instead of document/ASI

* * Unit tests
2021-04-21 21:42:10 +08:00
Carlos Ruiz a497e03b69
IDEMPIERE-4766 Record ID button would be more useful if it shows the ID (#658) 2021-04-19 20:48:01 +08:00
Carlos Ruiz 9d059b13fe
IDEMPIERE-1405 Locator Dialog allows to create locators without any check (#651)
IDEMPIERE-4442 Change Locator Dialog ListBox to Tabledirect (autocomplete)
* Fix an issue not setting the new locator created when returning
2021-04-19 20:45:21 +08:00
Carlos Ruiz 8f31506ac7
IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments (#655)
* IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments

- Change setting for all caches to be non-distributed

* IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments

* TC-324 Fix cache related monitoring and performance issues

- PO & GridTable call to CacheMgt reset should be async.

Co-authored-by: hengsin <hengsin@gmail.com>
2021-04-19 20:41:34 +08:00
Carlos Ruiz 1a5eb5ce22
IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex (#640)
* IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex

* Implementing suggestion from Andreas Sumerauer
* Fix issue in IDEMPIERE-3916 (Move Client) and IDEMPIERE-1026 (Create Window from Table)

* IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex

* Change approach to discover real columns

* * Rename method as suggested by Andreas Sumerauer
2021-04-07 21:34:37 +08:00
Carlos Ruiz 44edbf4b07
IDEMPIERE-4742 Delete button on detail tab is not disabled for processed records (#636) 2021-03-29 15:23:52 +02:00
Diego Ruiz da171627ed
IDEMPIERE-4743- Fixed Shift+Alt+N to save and create in detail (#639) 2021-03-25 20:30:49 +01:00
Carlos Ruiz c8fd9a8805
IDEMPIERE-4736 FHCA-2461 IDEMP - ad_column table - Framework query improvement (#628)
* IDEMPIERE-4736 FHCA-2461 IDEMP - ad_column table - Framework query improvement

* * Rename migration scripts to normal convention
2021-03-16 17:03:40 +08:00
Carlos Ruiz 43cbc2f297
IDEMPIERE-4738 Password for user System cannot be changed (#633)
IDEMPIERE-4287
2021-03-16 08:29:45 +08:00
Carlos Ruiz ba0cc46c6c
IDEMPIERE-4731 No default salesrep_id in PO/SO,Invoice when using 'Change Role' (#631) 2021-03-15 21:20:38 +08:00
Carlos Ruiz 2e4daa8930
IDEMPIERE-4566 Translation Import/Export - output message is not visible (#624)
* Fix problem with wrong management of parameters when changing from Import to Export
* Delete the deprecated class, this is unused (IDEMPIERE-4723)
2021-03-12 10:45:39 +01:00
Nicolas Micoud 1cab7864f5
IDEMPIERE-4732 : WSearchEditor - make lookup, infoPanel and adwindow (#623)
* IDEMPIERE-4732 : WSearchEditor - make lookup, infoPanel and adwindow protected
2021-03-11 17:37:14 +08:00
Carlos Ruiz c60f420cec
IDEMPIERE-4708 Context from ProcessParameterPanel is not cleared when closing the window (#618)
* IDEMPIERE-4708 Context from ProcessParameterPanel is not cleared when closing the window

* Revert "IDEMPIERE-4708 Context from ProcessParameterPanel is not cleared when closing the window"

This reverts commit 74d5d07bea748f6405bfb6988a01fab1f605f720.

* Implement suggestion from @hengsin
2021-03-10 20:09:55 +08:00
Deepak Pansheriya f8f17d5b85
IDEMPIERE-4729: Fixing cross tenant error reported issue when submitting field suggestion (#622) 2021-03-10 12:48:43 +01:00
Carlos Ruiz 8264a9abfa
IDEMPIERE-4692 Mandatory range parameters : "To" style not updated after being filled manually (#616)
* IDEMPIERE-4692 Mandatory range parameters : "To" style not updated after being filled manually

* based on patch from Anozi Mada
* Add javadoc explaining new columnname notation in IProcessParameterListener
* Change BankTransferParameterListener to illustrate better usage of columnname - as example
2021-03-09 10:56:38 +01:00
Carlos Ruiz 5f2d71347d
IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system) (#593)
* IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system)

WIP - initial version working on zk with google apps mail using OAuth2 Authorization Code Flow and Client Type = web application

* Enable imap reading with OAuth2 in RequestEMailProcessor
* Simplify the code - tested plain and OAuth2 can use the same methods
* Add +SCOPE parameter to AddAuthorizationForm according to IDEMPIERE-4713
* Rename the form AddAuthorizationMailForm to AddAuthorizationForm as is now more generic

* IDEMPIERE-4713
* Rename migration scripts to make it newer than IDEMPIERE-4713
* Add list of scopes attended by a credential
* Change form to accept other scopes, if no scope parameter is passed, then a list is shown, change the menu to fix the EMail scope
* Add MAuthorizationAccount.refreshAndGetAccessToken
* Add translation for messages

* make call generic oauth, avoid using specific google API

* Tests with microsoft as OAuth2 provider
* Add record for microsoft as provider
* Increase size of tokens
* Define mandatory and secure columns
* Update refresh token when it comes on the refresh call
* Revoke endpoint is optional

* Change the approach to a process instead of a form (WIP)
* Implement servlet to process the OAuth2 code

* Solve context suggestion from hengsin

* Implement the form in an automatic popup approach for running on zkwebui

* i18n - add translations for all messages that are shown to user
* on the form opted for click to avoid the problem with browsers forbidding popups
* clean spaces and tabs on line endings

* avoid logging and copy of the secure columns

* Fix problem reported by @d-ruiz about hidden NPE when SMTP Authentication is disabled

* Add writing to AD_PInstance_Para and AD_PInstance_Log the results of processing the servlet
* Control to avoid using the same authorization URL twice
2021-03-06 11:49:39 +01:00
hengsin 3beccdf38e
IDEMPIERE-4722 Remove constraint that idempiere source folder must be… (#606)
* IDEMPIERE-4722 Remove constraint that idempiere source folder must be used as Eclipse workspace

use project_loc of org.adempiere.base instead of workspace_loc
integrate additional fix from Carlos
2021-03-02 20:51:20 +08:00
Nicolas Micoud 2c340390cf
IDEMPIERE-4716 : set InfoPanel onDoubleClick method protected (#604) 2021-02-25 06:20:07 +08:00
Carlos Ruiz 47f7180eff
IDEMPIERE-4713 Allow definition of context variables to inject on menu and window definition (#600)
* IDEMPIERE-4713 Allow definition of context variables to inject on menu and window definition

* * Implement prefix "+" as suggested by @hengsin
* Clear the variable

* * Fix scope of methods and fix interface as suggested by @hengsin

* * Implement changes suggested by @hengsin
* Add control for clicking on new button on Favourites and menu
2021-02-23 16:24:39 +01:00
Diego Ruiz 60bcc24bb4
Idempiere 4084 (#599)
* IDEMPIERE-4084 Fixed DynamicDisplay on overflow buttons

* IDEMPIERE-4084 Clean unused code
2021-02-22 10:54:30 +08:00
Diego Ruiz 3c220b6681
IDEMPIERE-4084 Improve button access logic (#592) 2021-02-18 19:46:43 +01:00
hengsin b1d3f9c8fd
IDEMPIERE-4705 Add grid toggle button to Detail Pane (#594) 2021-02-18 19:38:46 +01:00
Andreas Sumerauer 6acc8e235d
IDEMPIERE-4702 Messagebox enhancement: Esc key closes Dialog with cancel (#586)
action

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-02-16 08:41:41 +08:00
Carlos Ruiz ff88459dc9
IDEMPIERE-4703 Cross tenant issue on sort tabs (#584) 2021-02-14 10:06:59 +08:00
hengsin 3a1d53ea4e
IDEMPIERE-4676 Browser hangs after restarting iDempiere or refreshing ui.zk, on macos sometimes during work (#574)
Immediately treat jqxhr.status=0 as server not available doesn't work
well on firefox. With Firefox both stop of server and navigate away to
another site provide same jqxhr.onerror event and jqxhr.status of 0.
2021-02-09 19:10:54 +01:00
Carlos Ruiz 0669760711
IDEMPIERE-3340 Adaxa's User Favorite which allow user to organize their menu, create folders (#569)
* Login Automatic Open Sequence -> buttons don't require names
* Login Automatic Open Sequence -> buttons look bad with non-font icons
* Clicking on + on an item of the favourites throws an NPE
* Implement same approach about checking for new button restricted on menu search, menu popup and quick entry popup
2021-02-04 21:39:15 +01:00
Deepak Pansheriya 373225a62c
Idempiere 3340 (#505)
* IDEMPIERE-3340 : User favorite with tree structure

* IDEMPIERE-3340: Marking write operation to safe for cross tenant safe

* IDEMPIERE-3340: Fixing Cross tenant access issue

* IDEMPIERE-3340: refactoring as review comment, Fixing renaming folder issue, Auto launch window shows all items irrespective of access

* Sync with IDEMPIERE-4251

* Sync with IDEMPIERE-4251

* IDEMPIERE-3340: Refactoring as review comment for caching,
 toolbar button restriction method with ID, tooltip messages, font base theme,
 remove double click event, etc.

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-02-04 21:36:25 +01:00
Carlos Ruiz c5c08a8b87
IDEMPIERE-4658 The operator Dropdown entries for a foreign ID column is corrupted when a search preset is loaded in any window's Advanced Search tab. (#564)
Fix issue discovered:
* Saving a query with LIKE operator, when restored it changes to = operator
2021-02-01 15:20:19 +01:00
hengsin 3d70b5dd63
IDEMPIERE-4676 Browser hangs after restarting iDempiere or refreshing… (#557)
* IDEMPIERE-4676 Browser hangs after restarting iDempiere or refreshing ui.zk, on macos sometimes during work

* IDEMPIERE-4678 Save log informing Notice created when background job

stop immediately when server is not reachable
2021-01-31 15:56:22 +08:00
Carlos Ruiz fd3fef9e7b
IDEMPIERE-4678 Save log informing Notice created when background job (#559)
* IDEMPIERE-4678 Save log informing Notice created when background job

* Added also a refactor for the INSERT INTO AD_PInstance_Log to use safer binding variables and add method saveEx

* - Implement suggestions from @hengsin
- Add some additional improvements
2021-01-29 08:57:15 +08:00
Diego Ruiz 245b471d06
IDEMPIERE-4672 Improve the StatusBar Menupopup to render HTML text (#553) 2021-01-25 17:01:14 +01:00
hengsin f233e29432
IDEMPIERE-4662 Some problems of sort at window before save (#551)
* IDEMPIERE-4662 Some problems of sort at window before save

* IDEMPIERE-4662 Some problems of sort at window before save

Fixed the sequence of edit field -> sort -> edit field will wrongly
trigger save automatically.
2021-01-25 09:31:21 +01:00
Diego Ruiz 2dbbc93485
IDEMPIERE-4665 SearchQuery should behave the same as the toolbar buttons - role access,advanced button,dynamic display (#548) 2021-01-23 12:32:19 +01:00
Nicolas Micoud 9413a8a2f5
IDEMPIERE-4665 : Toolbar: Select Query cannot be hidden (#546) 2021-01-22 11:05:27 +01:00
Carlos Ruiz 96393d2356
IDEMPIERE-4657 Search Dialog Columns are duplicated when table is present in multiple window tabs. (#540)
* IDEMPIERE-4657 Search Dialog Columns are duplicated when table is present in multiple window tabs.

* Improve query when different seqno (just check fields from first tab)
2021-01-21 17:27:47 +01:00
Carlos Ruiz 2d76f90f9c
IDEMPIERE-4660 Wrong code in virtual columns broke IDEMPIERE-2356 (#541)
IDEMPIERE-4087
IDEMPIERE-3760
2021-01-21 14:28:15 +01:00
Carlos Ruiz d81935a128
IDEMPIERE-4658 The operator Dropdown entries for a foreign ID column is corrupted when a search preset is loaded in any window's Advanced Search tab. (#538) 2021-01-20 21:46:35 +08:00
Carlos Ruiz 24ccb86f16
IDEMPIERE-4653 Improve timeout handling of window tab (#539)
* IDEMPIERE-4653 Improve timeout handling of window tab

* Fixed a problem with IDEMPIERE-4130 that was not using role max query records
* GridTable was throwing NPEs because the arrays were disposed before closing
* Lowered log level on MRole to avoid clogging the console (I was testing with INFO level)
* Added more points of control for the timeout exception to give meaningful errors to the user and allow refining the query without closing the Find dialog
* Implemented a control to avoid repeating a slow initial query every time the dialog is open
* Added dialog when the find criteria doesn't return rows and allows the user to refine the query
* When the initial number of records is unknown, show a question mark instead of the count

* * Fix wrong role level pushed in first commit
2021-01-20 21:45:33 +08:00
hengsin e1ba21360f
IDEMPIERE-4653 Improve timeout handling of window tab (#534)
* IDEMPIERE-4653 Improve timeout handling of window tab

* IDEMPIERE-4653 Improve timeout handling of window tab

Fix error with find and refresh.
2021-01-20 13:27:58 +01:00
HideakiHagiwara cdb21c0698
IDEMPIERE-4655 WTimeEditor display time picker button when read only. (#535)
Co-authored-by: HideakiHagiwara <h.hagiwara@gmail.com>
2021-01-20 20:05:16 +08:00
hengsin 59b83c3361
IDEMPIERE-4628 Implement configurable query timeout for info window (#532)
* IDEMPIERE-4628 Implement configurable query timeout for info window

* IDEMPIERE-4628 Implement configurable query timeout for info window

Move migration script from i8.2z to i8.2
2021-01-19 10:25:13 +08:00
hengsin 1afe4fe0c6
IDEMPIERE-4652 Remove Eclipse warnings (#533) 2021-01-18 17:32:25 +01:00
hengsin ebcf4b3e1c
IDEMPIERE-4651 Max records for Search autocomplete list should be configurable (#531) 2021-01-18 11:52:12 +01:00
Carlos Ruiz fa8b7f1807
IDEMPIERE-4645 Search by special field types failing (#524)
* IDEMPIERE-4645 Search by special field types failing

* Set the advanced operators for Search for the special cases
2021-01-17 18:05:06 +08:00
Carlos Ruiz efc3d98313
IDEMPIERE-4647 Plugin Manager improvement (#528)
Fix index out of bounds error - when selecting a plugin and then filtering for a number of items lower than the selected index
2021-01-15 19:03:23 +01:00
Nicolas Micoud e3c78d7501
IDEMPIERE-4647 : filter plugins using name (#527)
* IDEMPIERE-4647 : filter plugins using name

* Minor improvements

* Add translated message for Filter
* Use ON_CHANGE instead of ON_BLUR, allows to apply the filter with ENTER

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-01-15 18:39:55 +01:00
hengsin 6c6cbf932d
IDEMPIERE-4625 Login Page refresh cause error message, randomly when slow db response (#525)
Fix CLOSE-WAIT issue
(https://groups.google.com/g/idempiere/c/wppbB5jdByg/m/_VOzSZZyAQAJ)
2021-01-15 10:54:07 +01:00
HideakiHagiwara fb8c045de9
IDEMPIERE-4644 Heading only Field is the cause of NullPointerException Error on Find Window. I Added null check logic. (#523)
Co-authored-by: jpiere <h.hagiwara@compiere-distribution-lab.net>
2021-01-13 09:26:51 +01:00
Carlos Ruiz 402300a53e
IDEMPIERE-4639 Cross tenant issues with context help (#522) 2021-01-12 21:31:40 +08:00
hengsin d96199a2b6
IDEMPIERE-4251 Constant definition for all Env Context (#519)
* IDEMPIERE-4251 Constant definition for all Env Context

replace "#Date" with Env.DATE

* IDEMPIERE-4251 Constant definition for all Env Context

replace "#.." with constant at Env

* IDEMPIERE-4251 Constant definition for all Env Context

Merge patch from Carlos
2021-01-12 21:29:50 +08:00
hengsin bbb4c48b67
IDEMPIERE-4625 Login Page refresh cause error message, randomly when slow db response (#506)
Fix wrong stop server push flow.
2021-01-06 10:46:56 +01:00
hengsin 248612e24d
IDEMPIERE-4485 Info Window Columns has no Value preference (#510)
add back the line that's wrongly remove in the review of PR 501
2021-01-06 06:56:02 +08:00
igorpojzl 5a01ef2c07
IDEMPIERE-4630 Global Search, Tab Search has no scroll (#509) 2021-01-05 23:20:29 +08:00
igorpojzl 00f22bb30a
IDEMPIERE-4485 Info Window Columns has no Value preference (#501)
* IDEMPIERE-4485 Info Window Columns has no Value preference

* IDEMPIERE-4485 Fix Query Parameter SQLWhere build.

* IDEMPIERE-4485 Info Window Columns - shorter code.
2021-01-05 21:15:26 +08:00
hengsin 240b1b277c
IDEMPIERE-4612 Improve layout of Find Dialog (#495)
Base on pull request 487 from Flemming Birch (gsjeffen)
2021-01-02 17:56:59 +01:00
Diego Ruiz da6d6b83aa
IDEMPIERE-4607 Cannot export windows via 2pack if any field has a Fie… (#483)
* IDEMPIERE-4607 Cannot export windows via 2pack if any field has a Field Group

* IDEMPIERE-4607 Implement changes discussed in JIRA - Add a new isList method to DisplayType

* IDEMPIERE-4607 Fixed typo

* IDEMPIERE-4607 Implement default method to return false by default - PR CarlosRuiz
2020-12-26 16:35:50 +01:00
Carlos Ruiz 0485339377
IDEMPIERE-4604 Release 8.2 Phong (#480)
Changes to differentiate test servers 8.2 from 8.2z
2020-12-21 22:12:01 +01:00
Carlos Ruiz 6c5d54d7f7 IDEMPIERE-4604 Release 8.2
Fix import warnings
2020-12-20 09:53:49 +01:00
Carlos Ruiz a5d6a23f15
IDEMPIERE-4603 Find * character cause postgresql error (#476) 2020-12-20 07:30:40 +01:00
Carlos Ruiz 1ca179f121
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#470)
Fix cross-tenant problem about forcing to change a password expired in a multi-tenant environment
2020-12-16 11:38:53 +01:00
Carlos Ruiz a9a2aeeeed
IDEMPIERE-4601 Move Plugin manager from About to a Form (#469) 2020-12-16 09:10:00 +08:00
Carlos Ruiz 03b4a1e878
IDEMPIERE-4580 Refactor about credits (#433)
* IDEMPIERE-4580 Refactor about credits

Implement Credits as an HTML file visible in root folder
Change size of about window
2020-12-15 15:54:51 +01:00
hengsin 1df6f63341
IDEMPIERE-4598 Disable obsolete IsServer* fields (#467)
* IDEMPIERE-4598 Disable obsolete IsServer* fields

* IDEMPIERE-4598 Disable obsolete IsServer* fields

- Fix wrong migration script name
2020-12-14 15:10:29 +01:00
hengsin bffb3166c6
IDEMPIERE-4528 Update Js Library (#461)
* IDEMPIERE-4528 Update Js Library

Fix session timeout page broken.

* IDEMPIERE-4528 Update Js Library

add version info for keylistener component
2020-12-12 12:18:36 +01:00
Nicolas Micoud a7fbe30441
IDEMPIERE-4584 : InfoProduct throws "Attempted to access nonexistent … (#460)
* IDEMPIERE-4584 : InfoProduct throws "Attempted to access nonexistent ListModelTable field at 2, -1" if no IsInstanceAttribute column

* IDEMPIERE-4584 : fix test of column index

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2020-12-12 13:47:06 +08:00
hengsin 6abbc4c9da
IDEMPIERE-4594 Payment Selection (Manual) - NPE When Payment Date is empty (#455)
Fix NPE
2020-12-10 16:32:07 +01:00
hengsin e017046dac
IDEMPIERE-4590 Scheduler Window: Start Scheduler action change AD_Client_ID to 0 when HazelCast Service is Down/Disable (#449) 2020-12-10 11:54:39 +01:00
hengsin 6e380b3dfb
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#451)
Fix missing downarrow for breadcrumb.
2020-12-10 11:26:36 +01:00
Carlos Ruiz 4c66c0018d
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#443)
Implement thread safe mechanism
https://mattermost.idempiere.org/idempiere/pl/hmpd8freutbhbgcjr9tu6ntitr
2020-12-09 14:28:49 +01:00
Carlos Ruiz d7bac68f94
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#442)
Problem when creating a preference with SuperUser in System, and then trying to save the same preference in GardenWorld (for example changing the height of a window)
2020-12-07 23:00:14 +08:00
hengsin 9d02ecaadb
IDEMPIERE-4387 Cannot select C&W Business Partner in Multi Select Search (#438)
- base on patch from Carlos and hints from hieplq
2020-12-05 16:38:36 +01:00
hengsin 894ceb8c4f
IDEMPIERE-4101 [Chosenbox] Multi select don't work in Firefox (#435)
- add display of button
- fix dropdown doesn't render properly at Firefox
2020-12-04 17:52:10 +01:00
hengsin c3aafb2a4f
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#431)
- Fix broken menu icon for html report
- Fix an issue with switching theme
2020-12-03 11:58:45 +01:00
Carlos Ruiz a833e778a6
IDEMPIERE-4468 Pass the current value of numberbox to the textfield of calculator (#430)
IDEMPIERE-2003 Capturing wrong numbers with numeric keypad when decimal separator is not dot

- Restore and improve functionality that process dot keypad within the number fields (deleted by mistake in c954a055b2)
2020-12-02 22:16:31 +01:00
Deepak Pansheriya 8b672a3a51
IDEMPIERE-2999 : refactoring as per Hengsin's review comments (#427)
* IDEMPIERE-2999 : refactoring as per Hengsin's review comments

* IDEMPIERE-2999: Fixing compilation issue

* IDEMPIERE-2999: Fixing as per Hengsin'e review
2020-12-02 22:59:23 +08:00
Carlos Ruiz 42854cfb0f
IDEMPIERE-4561 Font Icons not used in several points (#423) 2020-12-01 07:12:28 +08:00
hengsin 5d236de30c
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#420)
* IDEMPIERE-4421 Html asset versioning should allow fluent deployment

use classpath loading and lang-addon versioning for theme resources

* IDEMPIERE-4421 Html asset versioning should allow fluent deployment

Incorporate backward compatibility patch from Carlos.
2020-11-30 15:33:23 +01:00
Carlos Ruiz 71a2ee3fe7
IDEMPIERE-4268 Fix issue with change client (#418)
Fix problem changing client in role panel when more than 2 clients
2020-11-27 20:24:21 +01:00
Carlos Ruiz d885aaf4e6
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#415)
Co-authored-by: Heng Sin Low <hlow@trekglobal.com>
2020-11-26 20:22:18 +08:00
Carlos Ruiz 6eeabc49ba
IDEMPIERE-4566 Translation Import/Export - output message is not visible (#408)
- Deprecate zk form WTranslationDialog and controller TranslationController
- Move the logic to a java process org.idempiere.process.TranslationImpExp
- As a process works in mobile, can be called via webservices, tested with fitnesse, etc
- Importing leaves a better and readable log of each file processed
- Importing/Exporting gives feedback to the user about the file being processed

Side note:
- To standardize the menu - renamed the "Initial Client Setup Process" to "Initial Client Setup"

Improvements over the previous form:
- can process the files from the zip in root folder, or in internal folder with the name of the language
- can process a URL http/https to download the zip file
2020-11-26 16:20:17 +08:00
Carlos Ruiz 333d35a504
IDEMPIERE-4417 Cancel ASI selection not closing properly (#411)
Co-authored-by: Alan Lescano <alan.lesc1@gmail.com>
2020-11-26 12:41:49 +08:00
Carlos Ruiz 0cc35e16f8
IDEMPIERE-4554 PO is immutable - Workflow editor (#393)
- fix the PO is immutable errors
- forbid that system nodes are changed by non-system users
- system nodes are shown in gray
- reorganize layout of system workflows in editor
- make the nodes smaller
- fix the layout problem of name and properties dialogs
2020-11-26 10:02:48 +08:00
Carlos Ruiz 808773aa9f
IDEMPIERE-4528 Update Js Library (#410)
Restore sendDeferLayoutEvent - deprecated, to avoid breaking some plugins out there
2020-11-25 12:18:17 +01:00
hengsin 72f991d7a6
IDEMPIERE 4528 Implement namespace and versioning for JS library (#405)
* IDEMPIERE-4528 Update Js Library

Update html2canvas to 1.0.0.rc7

* IDEMPIERE-4528 Update Js Library

Use namespace/package and versioning for all js codes.
2020-11-24 12:35:24 +01:00
Carlos Ruiz d44fde9e08
IDEMPIERE-3566 shortcut key for process gear (alt + o) don't effect (#396) 2020-11-21 14:20:42 +08:00
Diego Ruiz 58e83d9faa
IDEMPIERE-4559 Customize and Process detail toolbar buttons are not clickable after creating a new record in the header (#390) 2020-11-19 13:41:36 +08:00
Carlos Ruiz c954a055b2
IDEMPIERE-4468 Pass the current value of numberbox to the textfield of calculator (#385)
IDEMPIERE-2003 Capturing wrong numbers with numeric keypad when decimal separator is not dot

- Simplify the code for IDEMPIERE-4468 using Clients.evalJavaScript
- Fix IDEMPIERE-4468 to work in sync with IDEMPIERE-2003
- Improve IDEMPIERE-4468 to set the cursor at the end of the passed value
- Improve IDEMPIERE-2003 to insert the comma separator where the cursor is
- Simplify the code for IDEMPIERE-2003, there was a code calling setWidgetListener onKeyDown and doKeyPress_
  Probably required for old browsers, tested without that code with actual chromium and firefox and both worked perfect
2020-11-18 11:49:48 +08:00
Carlos Ruiz ca3da22f7b
IDEMPIERE-2418 Record Access Dialog Layout issue (#383)
Fix layout for desktop and mobile
Filter the role list to exclude System roles
2020-11-17 21:36:27 +08:00
hengsin 4125e5a10b
IDEMPIERE-4512 zk9.5 - Timeout page is not working (#386)
- Fix a javascript error when session timeout
- Add support for session timeout alert
2020-11-17 11:05:10 +01:00
hengsin 052a9e8474
IDEMPIERE-4512 zk9.5 - Timeout page is not working (#384) 2020-11-16 18:18:49 +01:00
Carlos Ruiz 3adbc9e00f
IDEMPIERE-4549 Detect broken theme configuration (#380)
* IDEMPIERE-4549 Detect broken theme configuration

* IDEMPIERE-4549 Detect broken theme configuration

make getTheme() synchronized

* Revert "IDEMPIERE-4549 Detect broken theme configuration"

This reverts commit 9044c7887064f217acea1051cd35c5c791ce47da.

Co-authored-by: hengsin <hengsin@gmail.com>
2020-11-15 06:32:33 +08:00
hengsin 9bb1836bcf
IDEMPIERE-4536 Allow minor customizations in default theme (#382)
only include fragment/custom.css.dsp if the file exists
2020-11-14 17:04:51 +01:00
Carlos Ruiz bf4935395a
IDEMPIERE-4544 Payment Selection cannot be used in mobile portrait (#377) 2020-11-13 18:15:52 +08:00
Carlos Ruiz 837c04f063
IDEMPIERE-4542 Cannot report from window _My Unprocessed Documents_ (#376) 2020-11-13 18:07:07 +08:00
Carlos Ruiz f3828f9cbf
IDEMPIERE-4545 Workflow activities - OK button cannot be reached in mobile (#378) 2020-11-13 04:55:01 +08:00
hengsin e58902ec5d
IDEMPIERE-2490 java.lang.IllegalStateException: Form too large (#363)
replace the now defunc setting at jetty.xml with jetty-web.xml
2020-11-09 12:26:39 +01:00