Commit Graph

247 Commits

Author SHA1 Message Date
Carlos Ruiz 26bdfc276f IDEMPIERE-6036 Apply same approach to MLotCtl (#2237) 2024-03-04 21:17:30 +01:00
hengsin 6302f6f5fd IDEMPIERE-6029 Extract @SQL= and @SQLFIND= to constant (#2230) 2024-03-04 21:17:30 +01:00
hengsin 7224009efc IDEMPIERE-6032 MPInstanceLog ResultSet constructor not getting all value from result set (#2233) 2024-03-04 21:17:30 +01:00
hengsin c2111b9ccd IDEMPIERE-6036 Serial number control has potential to generate duplicate serial number under heavy load (#2236) 2024-03-04 21:17:30 +01:00
hengsin 61e3e48c9a IDEMPIERE-6035 Use saveCrossTenantSafe instead of PO.setCrossTenantSafe (#2235) 2024-03-04 21:17:03 +01:00
hieplq 815e363882 IDEMPIERE-6016:test case to simulate transaction timeouts and ensure no open connections remain afterwards (#2219)
* IDEMPIERE-6016:allow transaction monitor's scan timeout to a short duration

* IDEMPIERE-6016:test case to simulate transaction timeouts and ensure no open connections remain afterwards

* IDEMPIERE-6016:trx timeout make leak connection by call Connection.about but not call Connection.close(Hengsin review)

replace abort with rollback
use shorter duration for timeout test 2
add Isolatead and same thread execution class annotation

* IDEMPIERE-6016:trx timeout make leak connection by call Connection.about but not call Connection.close(Hengsin review)

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2024-03-04 21:13:19 +01:00
hengsin cdcf5d47f3 IDEMPIERE-6005 Unit Test: Display the test method to be executed in t… (#2217)
* IDEMPIERE-6005 Unit Test: Display the test method to be executed in the console

* IDEMPIERE-6005 Unit Test: Display the test method to be executed in the console

- Fix wrong configuration that run unit test twice
- added assembleRepository flag

* IDEMPIERE-6005 Unit Test: Display the test method to be executed in the console

- print classname.methodname() instead of just methodname()
2024-02-06 10:11:10 +01:00
hengsin 6c744c88da IDEMPIERE-6027 Alter column fail with PostgreSQL 16.1 (#2222) 2024-02-06 10:11:10 +01:00
luzpaz a87de727af IDEMPIERE-5838 Fix various typos (#2188)
* Fix various typos
Fixes user-facing and non-user-facing typos. Found via `codespell -q 3 -S "*.map,./migration,./migration-historic"`
* Added requested revisions
* Added requested revision
* Added requested revisions
2024-01-23 15:43:48 +01:00
Carlos Ruiz 17b012c376 IDEMPIERE-5567 - Parallel unit tests fail frequently with deadlock (#2190)
* IDEMPIERE-5567 - Parallel unit tests fail frequently with deadlock

when executing unit tests in parallel, MTestUUTest fails frequently with error detected deadlock
this can be caused by testReadingUpdatingTestUU trying to update translations and at the same time
the testDeletingTestUU is deleting the same record and deleting the same translations

* - implement suggestion from Heng Sin

* - remove unnecessary code
2024-01-23 15:43:48 +01:00
hieplq 0ea6a0352b IDEMPIERE-5980:spring-jcl make conflict between an export and import (slow down start idempiere on some condition) (#2175)
* IDEMPIERE-5980:spring-jcl make conflict between an export and import (slow down start idempiere on some condition)
2024-01-06 12:06:44 +01:00
Carlos Ruiz 3f912767a3
IDEMPIERE-5943 Implement table partitioning support (#2151)
* IDEMPIERE-5943 Implement table partitioning support

* - make it compatible with user preference Use Similar To
2023-12-21 06:41:11 +08:00
hengsin 7878721bf3
IDEMPIERE-5943 Implement table partitioning support (#2145)
* IDEMPIERE-5943 Implement table partitioning support

Co-authored-by: etantg <etan@trekglobal.com>
2023-12-20 14:10:04 +08:00
Elaine Tan d068b1977e
IDEMPIERE-5915 Generate Invoices (manual) > RMA => AR Credit Memo created with system date instead of "Date Invoiced" (#2097)
* IDEMPIERE-5915 Generate Invoices (manual) > RMA => AR Credit Memo created with system date instead of "Date Invoiced"

* IDEMPIERE-5915 Generate Invoices (manual) > RMA => AR Credit Memo created with system date instead of "Date Invoiced"
2023-11-09 13:14:38 +01:00
hengsin d58fb15f18
IDEMPIERE-5922 Jasper Report: support loading of jasper report file from non-fragment bundle (#2096) 2023-11-08 13:29:20 +01:00
hieplq ee66699d4a
IDEMPIERE-5909:use jdbc library as bundle (#2092)
* IDEMPIERE-5909:use jdbc library as bundle

* IDEMPIERE-5909:use jdbc library as bundle (version up)

* IDEMPIERE-5909:use jdbc library as bundle (update target id as CarlosRuiz suggest)
2023-11-08 12:12:35 +01:00
Carlos Ruiz 0c831cd9c8
IDEMPIERE-5063 Improve Unit Tests - Add jasper test (#2093)
* IDEMPIERE-5063 Improve Unit Tests - Add jasper test

* - add asserts as recommended by Heng Sin
- create temporary folder based on AD_Session_ID

* - rename method
2023-11-07 21:43:01 +08:00
hieplq d217eb531e
IDEMPIERE-5903 support multiple webservice project (#2084)
* IDEMPIERE-5903:support multi webservice project (issue 1:There is an endpoint already running on/rest)

https://stackoverflow.com/a/49553239/4037367

* IDEMPIERE-5903:support multi webservice project (reuse resource)

* IDEMPIERE-5903:support multi webservice project (fix comment review)
2023-11-04 20:09:27 +08:00
Elaine Tan a061eeedb4
IDEMPIERE-5878 Wrong GL posting in allocation for payment REVERSE/ACCRUAL, if payment WITH charge (#2074) 2023-10-25 16:01:29 +08:00
Carlos Ruiz ef9ecb3490
IDEMPIERE-4639 simplify calls using saveCrossTenantSafeEx when possible (#2073)
* IDEMPIERE-4639 simplify calls using saveCrossTenantSafeEx when possible

* - integrate patch from Heng Sin
2023-10-22 21:23:23 +08:00
Carlos Ruiz bb3856dbb0
IDEMPIERE-5793 premature dunning when dunning run is done on exactly the due date (#2064)
* IDEMPIERE-5793 premature dunning when dunning run is done on exactly the due date

* - fix unit test
2023-10-18 14:44:43 +08:00
Deepak Pansheriya cb6c8b636d
IDEMPIERE-5836: Adding unit test cases for Non stocked expense curren… (#2024)
* IDEMPIERE-5836: Adding unit test cases for Non stocked expense current bhavior

* IDEMPIERE-5836: Refactoring as per code review comments.

* IDEMPIERE-5836: Corrected code comments as per peer review
2023-09-29 22:54:23 +08:00
Carlos Ruiz 7c8fe24435
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - AD_PInstance (#2003)
- Implement support to run processes on UUID based tables
- Added SvrProcess.getRecord_UU and getRecord_UUs support
- Added TestUUChangeActive process as toolbar button on "Test UU Based Table" window - supports single and multi
- Added AD_PInstance.AD_Table_ID and AD_PInstance.Record_UU
- NOTE: the migration script tries the best to fill AD_PInstance.AD_Table_ID from different sources, but at the end is very possible that some records will be left with empty table
- The MPInstance constructors that don't manage AD_Table_ID were marked as deprecated to ease discovering the missing parts in plugins
2023-09-13 10:59:21 +08:00
Deepak Pansheriya 18f925fd2f
IDEMPIERE-5768 : Adding Credit manager factory to override or extend … (#1949)
* IDEMPIERE-5768 : Adding Credit manager factory to override or extend credit management

* IDEMPIERE-5768 : Fixing as as per code review comments from Hengsin

* IDEMPIERE-5768: Use component annotation instead of xml service definition

* IDEMPIERE-5768: Adding Unit tests and Making return type of CheckCreditStatus to be object instead of String.

* IDEMPIERE-5768: Fixing as per code review comment.

* IDEMPIERE-5768: Removed explicit rollback from test cases
2023-08-23 09:39:24 +08:00
hengsin e46d57e1ea
IDEMPIERE-5812 Reversal of Material Receipt for a Closed PO leave quantity ordered of product in a bad state (#1964) 2023-08-08 14:02:28 +02:00
Carlos Ruiz 472032fa44
IDEMPIERE-5821 Credit Memos are commissioning positive (#1965) 2023-08-04 14:41:30 +08:00
Carlos Ruiz 159fbbd04c
IDEMPIERE-5732 Cache reset should happens after commit of transaction (#1850)
* IDEMPIERE-5732 Cache reset should happens after commit of transaction

* IDEMPIERE-5732 Cache reset should happens after commit of transaction

* - minor defensive programming

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-08-01 19:53:11 +08:00
hengsin 890862de47
IDEMPIERE-4416 invalidating a purchase order doesn't remove connectio… (#1942)
* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- refactoring, make MiniTableImpl usable outside of test

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- refactoring, move business and sql logic from Match to model class.
- add more unit test

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- set M_InOut.C_Order_ID to null

* IDEMPIERE-4416 invalidating a purchase order doesn't remove connection to receipt

- update unit test for setting of M_InOut.C_Order_ID to null.
2023-07-31 15:20:26 +02:00
Elaine Tan eed078308c
IDEMPIERE-5757 immediate post: Payment REVERSE/CORRECT allocation document NOT posted (#1922)
* IDEMPIERE-5757 immediate post: Payment REVERSE/CORRECT allocation document NOT posted
2023-07-10 21:38:31 +08:00
Nicolas Micoud b28735509d
IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlud… (#1928)
* IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlude end date

https://idempiere.atlassian.net/browse/IDEMPIERE-5794

* IDEMPIERE-5794: New param for getBusinessDaysBetween to include/exlude end date - Unit tests

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2023-07-10 14:41:39 +08:00
Carlos Ruiz b7c089fc1d
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Implement support for Requests on UUID Based Tables (#1910)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Implement support for Requests on UUID Based Tables

* - minor typo

* - improve javadoc
2023-07-08 12:09:56 +08:00
Elaine Tan fce4d5cf9c
IDEMPIERE-5591 Payment allocation AP/AR GL postings not zero in alternative schema for invoice REVERSE/CORRECT (#1921) 2023-07-08 11:37:17 +08:00
Carlos Ruiz 7adbc91505
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Archive (#1895)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Archive

* - Support for master/detail reports on UUID based tables

* - Archive button

* - Add test print format for UU Based Table

* - backward compatibility on MArchive.getReportAndDocumentCountByRecordId

* - Backward compatibility with filesystem storage

* - Improve naming of temporary folder for 2Pack

* - Improve query to use correctly the index

* - Improve method to use ID when no UUID

* - Ensure the Record_UU is filled even when called from foreign sources

* - Implement the same provision for exceptional cases on MAttachment, MChat, MLabelAssignment, MPostIt to fill the UUID when not passed (f.e. when created by a plugin)
2023-06-23 11:17:51 +08:00
Carlos Ruiz 3641e398ca
IDEMPIERE-5776 Cannot generate shipment for an order with multiple lines for same product and Complete Order delivery rule (#1900) 2023-06-22 14:00:27 +08:00
hengsin 9c7713fa8d
IDEMPIERE-5448 2023 June Platform Update (#1531)
* IDEMPIERE-5448 Can't launch unit test with Eclipse 2022-09

- upgrade to tycho 3.1.0-SNAPSHOT
- set maven compiler source and target level to 11
- upgrade to junit 5.9.1

* IDEMPIERE-5448 Can't launch unit test with Eclipse 2022-09

- Change tycho version to 3.0.3

* IDEMPIERE-5448 2023 June Platform Update

* IDEMPIERE-5448 2023 June Platform Update

- Explicitly set target, source and release level to JavaSE 11

* IDEMPIERE-5448 2023 June Platform Update

- Use 3.0.5-SNAPSHOT to fix stack overflow error.

* IDEMPIERE-5448 2023 June Platform Update

- Change source, target and release level to JDK 17
- Update target platform name to idempiere-230620

* IDEMPIERE-5448 2023 June Platform Update

- Fix LogFactory ClassNotFound exception with Eclipse 2023-06
2023-06-21 13:44:18 +02:00
hengsin 2911b1f421
IDEMPIERE-5762 org.idempiere.test-feature should include org.idempiere.test (#1884) 2023-06-07 21:30:34 +02:00
hieplq dfe2fff6cd
IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (#1842)
* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice

base on patch from gauravsontakke

* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (fix code review)

https://github.com/idempiere/idempiere/pull/1842#pullrequestreview-1429618616

* IDEMPIERE-5723 NPE when allocate has both AR and AP invoice (check Accrual)

createInvoiceGainLoss isn't yet test for non accrual so at check for accrual to consistent with above code
2023-06-01 13:15:48 +08:00
Carlos Ruiz d2426c5ebd
IDEMPIERE-5683 ModelForeignKeyTest throwing error when parallel tests (#1836)
* IDEMPIERE-5683 ModelForeignKeyTest throwing error when parallel tests

* - Add Isolated annotation as suggested by Heng Sin
2023-05-17 08:23:09 +08:00
Carlos Ruiz d734cafd9b
IDEMPIERE-5712 Tests are leaving records in the database (#1827)
* IDEMPIERE-5712 Tests are leaving records in the database

* - add transaction

* - add cleanup for records committed out of transaction
2023-05-16 16:32:15 +08:00
Carlos Ruiz 9372743735
IDEMPIERE-5683 Fix broken test (#1826)
* IDEMPIERE-5683 Fix broken test

* - Fix also MTest test leaving records in the database

* Revert "- Fix also MTest test leaving records in the database"

This reverts commit 39005e5e87e96ee3f4433ebb3567add8d1b0a62c.
2023-05-06 20:47:51 +08:00
Carlos Ruiz af2d735cc5
IDEMPIERE-5683 Peer review (#1825) 2023-05-06 00:58:43 +02:00
hengsin afcbf6e70f
IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR… (#1818)
* IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR UPDATE

* IDEMPIERE-5707 PostgreSQL should use FOR NO KEY UPDATE instead of FOR UPDATE

- add trx timeout unit test
2023-05-05 19:41:43 +02:00
hengsin f18bb88f4b
IDEMPIERE-5691 Add Table Direct type joint method to Query (#1802) 2023-04-28 12:16:13 +02:00
Carlos Ruiz 449c124fe1
IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) (#1787)
* IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) - fix broken unit tests

* - Fix problem with unit test:
MTestTest.testReadingUpdatingTest:65 expected: <Test setting description> but was: <Test setting descriptionMTestEventDelegate>
2023-04-19 09:07:32 +08:00
Carlos Ruiz c80d53674a
IDEMPIERE-5567 Support of UUID as Key - Generate Model Classes (FHCA-4195) (#1772)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

New generated model classes with new UUID constructor

* - In order to use UUID constructor M classes must implement the constructor too
- Adding the constructor on MTest and adding a JUnit test to test/show how it works

* - Remove warning caused by changes on this ticket

* - Add UUID constructor to factories

* - Set new UUID constructor in mapped/annotated test classes
- Preparation for the new UUID constructor

* - Add UUID constructor to core model classes
- WARNING: MPaymentBatch(Properties, String, String) already existed with Name as parameter, it was changed to UUID
2023-04-12 11:02:33 +08:00
Carlos Ruiz 2e9b1222d3
IDEMPIERE-5560 Fix broken unit tests (#1770) 2023-04-06 16:04:45 +08:00
Carlos Ruiz a967069164
IDEMPIERE-5567 Support of UUID as Foreign Key (FHCA-4195) (#1741)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Foreign Keys

* - Table Direct working as read-only and link column

* - Fixes for Table with Reference

* - Add UUID FK management to Migrate ID process
- Add MColumn.beforeSave validation to force UUID columns to end with _UU
- Add table TestUUDet with two foreign keys pointing to TestUU (TableDir and Search)
- Add detail tab to Test UU Based Table window
- Add a new test window named Test UU Detail
- Generate model classes for the new test table
- Add test case for the detail test table
- Add MTable.isIDKeyTable method
- Add UU foreign key cross tenant validation to PO.validForeignKeys

* - Added a Chosen Multiple Selection Table with foreign UU for testing
- Changed reference in dictionary logic and sql to reflect new data types
- Disable SearchUU temporarily (will be worked in next step)
- Add validation to avoid encrypting UUID columns
- Avoid warning when searching for getPO method on UUID based tables
- Make Zoom Across button work with UUID foreign keys
- Enable zoom and zoom to detail for UUID foreign keys
- Enable Find Advanced on detail foreign UUID keys

* - Fix javadoc
- Quote properly UUID
- Validate null on return

* - Fix zoom logic - tested zooming to tab in first second and third level
2023-04-05 10:26:27 +08:00
hengsin ee1b6828f4
IDEMPIERE-5560 Cannot save more than one order line when an _ID field is not displayed (#1764) 2023-04-01 16:11:35 +02:00
Carlos Ruiz 09df36a78f
IDEMPIERE-5528 IDEMPIERE-5560 Cannot save more than one order line when an _ID field is not displayed (#1763) 2023-04-01 11:18:09 +08:00
Carlos Ruiz 51ceaacb43
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1727)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

* - Implement changes to support Model classes with UUID constructor

* - fix issue with tables with single parent key - like AD_Ref_Table

* - Create test table and JUnit test

* - fixes from Heng Sin

* - Improve performance on new methods in MTable
- Minor refinements in ModelClassGenerator
- Regenerate Test X classes
- Change Create Window from Table to receive the parent link as parameter (because tables can have now no keys at all)

* - Implement suggestions from Heng Sin

* - _UU column as primary key constraint for UUID based tables

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-03-21 21:30:45 +08:00