Commit Graph

3356 Commits

Author SHA1 Message Date
hengsin 536eda3546
IDEMPIERE-5427 Upgrade to Tycho 2.7.5 (#1493)
- restore .classpath to remove Tycho Configurator m2e connector
dependency
2022-09-21 14:21:27 +02:00
Elaine Tan 0b8b7da8e5
IDEMPIERE-5396 Replace CreateFrom form with Info Window Process (#1469)
* IDEMPIERE-5396 Replace CreateFrom form with Info Window Process
2022-09-19 18:30:24 +08:00
Carlos Ruiz 45516c6c91
IDEMPIERE-5425 Chosen Multiple Selection fields are not being copied with the Copy button (#1489) 2022-09-17 11:47:47 +08:00
Carlos Ruiz 1229faab34
IDEMPIERE-2058 Fix problem reading wrong column (#1484) 2022-09-14 10:24:05 +08:00
Carlos Ruiz 52e5e17fed
IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757) (#1483)
* IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757)

* IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757)
2022-09-13 18:57:13 +02:00
Carlos Ruiz 3c69ba56a4
IDEMPIERE-5415 Incomplete process log when output is > 2000 chars (#1476) 2022-09-11 15:22:52 +08:00
Jasper Siepkes 861e3ad01f
IDEMPIERE-5013 Implement HikariCP as a replacement for c3p0 (#926)
* Replaced PostgreSQL and Oracle connection pools with HikariCP.

Replaced C3P0 with HikariCP. HikariCP is a Apache licensed connection pool with substantially better performance and better resilience to failure (DB disconnects, etc.) then C3P0. Read more about it here: https://github.com/brettwooldridge/HikariCP .

Cleaned up the `getCachedConnection` method. With HikariCP there is no need to retry to obtain a connection since getting an connection will block until a free connection is available or until a timeout is reached (default 30 seconds) at which point an `SQLException` is thrown. This also removed calling `Runtime.getRuntime().runFinalization();`. HikariCP is currently configured to detect / log leaks when a connection hasn't returned to the pool for longer then 5 minutes.

Loading of pool config properties was cleaned up. Defaults are now loaded from a single file instead of defaults coming from both file and hardcoded properties. It is now also possible to specify any HikariCP property in the user pool property file.

Initialization of the datasource must happen in the `getDataSource()` method because at object construction not all JDBC config is known. However this method could (as far as I could tell) be called concurrently from multiple threads but had no mechanism to prevent initializing the DB pool multiple times. The variable in which the pool itself was stored (`m_ds`) also was not marked volatile or immutable which could lead to visibility issues. Instead of lazy initialization of the pool in the `getDataSource()` method the pool could probably better be initialized at object construction. However I wasn't able to achieve that without breakage therefor I made the initialization mechanism work correctly with concurrent invocations.

Various config options such as the `MaxStatementsPerConnection` options were removed because HikariCP doesn't support them.

* (Re)added Sequence time-out.
2022-09-10 12:21:57 +02:00
Deepak Pansheriya 8c5c0ecbfa
IDEMPIERE-5326: Parsing error for report view if where clause and vir… (#1385)
* IDEMPIERE-5326: Parsing error for report view if where clause and virtual column used in print format

* IDEMPIERE-5326: Fixing Compilation error

* IDEMPIERE-5326: Adding method back for backward compitability

* IDEMPIERE-5326: Adding constructors  for backward compitability
2022-09-07 21:45:23 +08:00
Peter Takács 1f4a23657a
IDEMPIERE-5400 - Dashboard Goal Content should render as single Gauge Indicator (#1458)
* IDEMPIERE-5400 - Dashboard Goal Content should render as single Gauge Indicator

* IDEMPIERE-5400 - better css responsivity

* IDEMPIERE-5400 - add update goal

* IDEMPIERE-5400 - fixes

* IDEMPIERE-5400 - resolved conflict, migration fix

* IDEMPIERE-5400 - fix bad merge
2022-09-07 21:40:29 +08:00
Peter Takács ee3476c3eb
IDEMPIERE-5409 - Dashboard Content - Maximizable checkbox (#1467)
* IDEMPIERE-5409 - Dashboard Content - Maximizable checkbox

* IDEMPIERE-5409 - IsMaximizable default 'Y'

* IDEMPIERE-5393 - fixes

* IDEMPIERE-5409 - fixed script name
2022-09-07 17:00:18 +08:00
Carlos Ruiz 8748f11ddf
IDEMPIERE-5354 Manage use case for microsoft OAuth2 preferred_username (FHCA-3757) (#1464) 2022-09-06 13:58:17 +02:00
Carlos Ruiz 0e71fa9884
IDEMPIERE-5407 Heavy query in MRole repeated too often (FHCA-3883) (#1465)
Removed the method MRole.loadTableInfo which loaded the arrays: m_tableAccessLevel, m_tableName, m_viewName, m_tableIdName
and replaced all usage with visits to cached information from tables or columns
2022-09-06 15:01:06 +08:00
Nicolas Micoud 537cb8b9b8
IDEMPIERE-5403 : Misleading error message on TimeUtil.getDay(int, int, int) (#1460)
https://idempiere.atlassian.net/browse/IDEMPIERE-5403
2022-09-05 13:13:36 +02:00
Nicolas Micoud 79d9efb8f5
IDEMPIERE-5395 : Validation Rules at Client level (#1451) 2022-08-30 13:25:01 +02:00
Peter Takács e528c6f8cb
IDEMPIERE-5389 - Dashboard row layout (#1448)
* IDEMPIERE-5389 - Dashboard row layout

* IDEMPIERE-5389 - taking changes related to ticket 5393

* IDEMPIERE-5389 - added Flex Grow to Preference

* IDEMPIERE-5389 - fixing gadget heights

* IDEMPIERE-5389 - center alignment for Status Line

* IDEMPIERE-5389 - fall back to column layout

* IDEMPIERE-5389 - pr1448 patch

* IDEMPIERE-5389 - FixOracleMigration patch
2022-08-30 10:11:42 +02:00
hengsin c45005be41
IDEMPIERE-5376 CConnection and DB clean up (#1457)
* IDEMPIERE-5376 CConnection and DB clean up

* IDEMPIERE-5376 CConnection and DB clean up

- More clean up

* IDEMPIERE-5376 CConnection and DB clean up

- Fix @Deprecated annotation
2022-08-29 21:36:50 +02:00
Nicolas Micoud d0d42ffaf1
IDEMPIERE-5361 : Jasper reports with Charts are not working (#1452)
* IDEMPIERE-5361 : Jasper reports with Charts are not working

* IDEMPIERE-5361 : patch from hengsin
2022-08-26 09:35:54 +08:00
Peter Takács 0aaf904e34
IDEMPIERE-5393 - Allow rendering status line as widget/gadget in dashboard (#1449)
* IDEMPIERE-5393 - Allow rendering status line as widget/gadget in dashboard

* IDEMPIERE-5393 - css class for status line

* IDEMPIERE-5393 - update default theme version
2022-08-24 15:49:06 +08:00
Carlos Ruiz 2dab2d9882
IDEMPIERE-5394 Export to XLSX in Info Windows and Account Viewer (#1450)
* IDEMPIERE-5394 Export to XLSX in Info Windows and Account Viewer
2022-08-24 09:33:12 +08:00
hengsin ce22d1cc51
IDEMPIERE-5391 Unit Test: Fix support for parallel execution of test (#1446) 2022-08-17 18:34:51 +02:00
Carlos Ruiz a558644949
IDEMPIERE-3340 Fix cross tenant in Favourites (#1445) 2022-08-17 18:17:13 +08:00
Peter Takács e670ebbd14
IDEMPIERE-5302 - Drill Assistant Feature with re-generated migration scripts (#1390)
* IDEMPIERE-5302 - Drill Assistant Feature with re-generated migration scripts

* IDEMPIERE-5302 - added IsShowInDrillOptions, ID fixes

* IDEMPIERE-5302 - added IsShowInDrillOptions default Y

* IDEMPIERE-5302 - creating Table Print Formats on Run Report

* IDEMPIERE-5302 - applied pr1390_fixes patch

* IDEMPIERE-5302 - applied pr1390_badimports patch
2022-08-17 18:08:45 +08:00
hengsin 288e96fe8d
IDEMPIERE-5376 CConnection and DB clean up (#1441)
* IDEMPIERE-5376 CConnection and DB clean up

* IDEMPIERE-5376 CConnection and DB clean up

- More clean up
2022-08-13 12:05:52 +02:00
Carlos Ruiz 165229d2db
IDEMPIERE-5380 StackOverflowError when try to login in application with substitute user (FHCA-3828) (#1437) 2022-08-13 10:15:31 +08:00
Carlos Ruiz 5e5c977733
IDEMPIERE-5382 Allow just one MFA registration per mechanism (FHCA-3822) (#1439) 2022-08-12 17:15:28 +08:00
Carlos Ruiz bc9808eb14
IDEMPIERE-5381 System users cannot revoke MFA trusted devices in GardenWorld (FHCA-3824) (#1438) 2022-08-12 17:13:54 +08:00
hengsin 3a2f0ff64d
IDEMPIERE-5376 CConnection and DB clean up (#1432) 2022-08-10 14:52:53 +02:00
Carlos Ruiz 5bd3af0d2f
IDEMPIERE-236 Centralization of hardcoded IDs (#1429)
* IDEMPIERE-236 Centralization of hardcoded IDs

* IDEMPIERE-236 Centralization of hardcoded IDs
2022-08-09 22:12:54 +08:00
Carlos Ruiz 0cb7216599
IDEMPIERE-5375 Read-only windows are not shown in Favourites dashboard (#1430) 2022-08-09 15:09:03 +08:00
hengsin 5f8e7be3c5
IDEMPIERE-5367 Logic expression IN doesn't works with quoted text (#1423)
* IDEMPIERE-5367 Logic expression IN doesn't works with quoted text

* IDEMPIERE-5367 Logic expression IN doesn't works with quoted text

- Fixed equal not working for quoted text with comma (e.g 'A,R,S')
2022-08-05 13:21:50 +02:00
Carlos Ruiz 464de082a5
IDEMPIERE-5355 Improve default trx name (FHCA-3765) (#1427)
Improve performance using StackWalker instead of Throwable->getStackTrace
2022-08-05 09:46:11 +08:00
Carlos Ruiz 9b812a315f
IDEMPIERE-3340 Fix cross tenant in Favourites (#1426) 2022-08-05 00:11:06 +02:00
hengsin 1fcbd5ea07
IDEMPIERE-5358 Refactor CreateFrom (#1413)
* IDEMPIERE-5358 Refactor CreateFrom

* IDEMPIERE-5358 Refactor CreateFrom

- Fix java doc

* IDEMPIERE-5358 Refactor CreateFrom

- Fix SQL error for Oracle (SELECT without FROM only works for
PostgreSQL).

* IDEMPIERE-5358 Refactor CreateFrom

- revert change of protected method name.
2022-08-04 12:42:53 +02:00
Elaine Tan 27c5d0fa53
IDEMPIERE-5339 GL AP/AR and RLL/RLG facts posted on wrong side in allocation reversal document using Payment Reverse-Accrual (#1420)
* IDEMPIERE-5339 GL AP/AR and RLL/RLG facts posted on wrong side in allocation reversal document using Payment Reverse-Accrual
2022-08-04 16:52:41 +08:00
hengsin 58813e8e83
IDEMPIERE-5359 Unit test not working with Oracle (#1419)
* IDEMPIERE-5359 Unit test not working with Oracle

- Fix local trx not rollback for SQLException
- Add test for getSQLValueObjectsEx and getSQLArrayObjectsEx
2022-08-04 16:21:29 +08:00
Peter Takács 5931f6ce8f
IDEMPIERE-5356 - Add Printing Support to ProcessInfoDialog (#1412)
* IDEMPIERE-5356 - Add Printing Support to ProcessInfoDialog
2022-08-02 17:10:52 +08:00
Alan Lescano 11962e1713
IDEMPIERE-5259 Labels feature (#1357)
* IDEMPIERE-5259 Labels feature
* IDEMPIERE-5259 Update the theme version timestamp
* IDEMPIERE-5259 Better javadoc
* Update 202205131118_IDEMPIERE-5259.sql
* Update 202205131118_IDEMPIERE-5259.sql
* IDEMPIERE-5259 New window Label Assignment
* IDEMPIERE-5259 Toggle issue
* IDEMPIERE-5259 MSysConfig is ordered alphabetically
* IDEMPIERE-5259 Default SysConfig
* IDEMPIERE-5259 Avoid duplicated records
Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2022-08-01 21:51:38 +02:00
Peter Takács c62a9ad066
IDEMPIERE-1965 - Implement Generate Invoices (manual) as Info Window (#1400)
* IDEMPIERE-1965 - Implement Generate Invoices (manual) as Info Window
* IDEMPIERE-1965 - fixes
* IDEMPIERE-1965 - Deprecate Form
* IDEMPIERE-1965 - backwards compatibility
* IDEMPIERE-1965 - vendor RMA form legacy
* IDEMPIERE-1965 - merge patch
* IDEMPIERE-1965 - 1965_PR patch
2022-08-01 20:41:39 +02:00
Carlos Ruiz 097ca0569e
IDEMPIERE-5363 - fix MRefList cache (#1417)
Co-authored-by: matheus-marcelinux <matheusmarcelino1998@hotmail.com>
2022-08-01 14:52:19 +02:00
hengsin edc96cca12
IDEMPIERE-5153 Cost Adjument Line Before Save: Update current cost price (#1411)
- Fix always getting current cost from primary accounting schema.
2022-07-26 21:26:58 +08:00
Carlos Ruiz 486ae19cdc
IDEMPIERE-5355 Improve default trx name (FHCA-3765) (#1407)
* IDEMPIERE-5355 Improve default trx name (FHCA-3765)

* IDEMPIERE-5355 Improve default trx name (FHCA-3765)

Implement suggestions from Heng Sin
Added SysConfig TRX_AUTOSET_DISPLAY_NAME (default false)

* Delete test/debugging code committed by mistake

* IDEMPIERE-5355 fix method wrongly named
2022-07-26 14:08:32 +08:00
Nicolas Micoud 58027792d8
IDEMPIERE-5342 : Ability to hide the title of the chart when displaye… (#1392)
* IDEMPIERE-5342 : Ability to hide the title of the chart when displayed on Home page
2022-07-21 20:09:11 +08:00
Nicolas Micoud e8b2a94b3f
IDEMPIERE-5348 : Validation of filenames (#1398) 2022-07-18 15:26:34 +02:00
Carlos Ruiz 9ed8c950f7
IDEMPIERE-5345 Login.getClients not validating role type (#1391)
* IDEMPIERE-5345 Login.getClients not validating role type

* Add null validation for whereRoleType
2022-07-14 09:35:36 +08:00
hengsin 73aecb1145
IDEMPIERE-5347 Minor scheduler improvement (#1393) 2022-07-13 23:09:54 +02:00
Carlos Ruiz 1846439e92 Revert "IDEMPIERE-5302 - Drill Assistant Feature (#1345)"
This reverts commit 809e3ae734.
2022-07-08 13:25:19 +02:00
Carlos Ruiz 2ba935a393
IDEMPIERE-5340 Log the exception in EventHelper.addError for future use (FHCA-3426) (#1386) 2022-07-07 14:29:59 +08:00
Deepak Pansheriya 9a64a1a11c
IDEMPIERE-5295: Trial Balance Report creates Opening balance per orga… (#1378)
* IDEMPIERE-5295: Trial Balance Report creates Opening balance per organization and setting opening date day before from date.

* IDEMPIERE-5295: Correction as per Hengsin's code review vomment.

* IDEMPIERE-5295: Opening Balance should be on first day of Period

* IDEMPIERE-5295: Removed unused import

* IDEMPIERE-5295: Fixing report view is not set on default print format
Co-authored-by: hengsin@gmail.com
2022-07-06 19:53:15 +08:00
Peter Takács 809e3ae734
IDEMPIERE-5302 - Drill Assistant Feature (#1345)
* IDEMPIERE-5302 - Drill Assistant Feature
2022-06-30 20:08:22 +08:00
hengsin 278fde8f72
IDEMPIERE-5332 Refactoring of Archive Viewer (#1376)
* IDEMPIERE-5332 Refactoring of Archive Viewer

* IDEMPIERE-5332 Refactoring of Archive Viewer

- remove join to AD_Process_Access
2022-06-30 19:28:19 +08:00