Commit Graph

6102 Commits

Author SHA1 Message Date
Redhuan D. Oon 64d83bfa5e FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 18:33:17 +00:00
Redhuan D. Oon c61ce5d86d FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 14:49:46 +00:00
Redhuan D. Oon 8d6cd95f50 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test pending
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-05 14:34:10 +00:00
Heng Sin Low 025ed3e4e1 Improve IE8 support
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2898957
2010-03-05 11:06:05 +00:00
tspc bb529d9197 Merge bug fixes in release not committed to trunk
merge -c 11561 -c 11581 -c 11582

11561 -> Fix [2962787] Recursion in PO.set_ValueNoCheckE
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962787

11581 -> Fix [2948897] Fixed Assets Dictionary Errors - wrong reference to column A_Depreciation_Entry.A_Type_Entry
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2948897

11582 -> Fix [2948897] Fixed Assets Dictionary Errors - wrong reference on processed columns
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2948897
2010-03-04 23:11:37 +00:00
trifonnt f0915477fe FR [2940149] - Improve info product to query product in different languages
https://sourceforge.net/tracker/?func=detail&atid=879335&aid=2940149&group_id=176962
Revert SVN Revision: 11426
2010-03-04 08:37:07 +00:00
Heng Sin Low dc50ece192 When user press the print button on the toolbar, the current window no is not pass to the print dialog causing report parameter failed to get default value from current window context.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2963196
2010-03-04 08:33:28 +00:00
Carlos Ruiz fe13d23bb0 peer review for 11559, 11560 - refactor MRule.getModelValidatorLoginRules to avoid double array management
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-04 00:24:46 +00:00
Carlos Ruiz 21f04ba76f peer review for 11555
- refactorings to use setClientID and setOnlyActiveRecords
- check serialVersionUID on affected classes
- add final to whereClauses
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-04 00:06:16 +00:00
Carlos Ruiz 08e0deb5cd peer review for 11554
- incompatible objects in MMovement
- other refactorings
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 23:38:19 +00:00
Carlos Ruiz 1a06e21024 peer review for 11547 - minor changes
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 23:04:46 +00:00
Carlos Ruiz 98c74ef980 peer review for 11545 and 11546 - refactored getProductLot to have predictable results
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 22:40:26 +00:00
Carlos Ruiz ff9dffd082 peer review for 11541 - be careful with logic: an exception is not equivalent to a log.info
refactored to use .setClientID()
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 22:13:54 +00:00
Carlos Ruiz e7177049db peer review for 11533, 11537, 11540
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 21:43:37 +00:00
Carlos Ruiz d9b22ee7ed peer review for 11539
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 21:13:05 +00:00
Carlos Ruiz 791f4a8624 peer review for 11538 -> drop unused lines in ExportHelper - apply the same practice to ImportHelper, fix warning on ExportFormatGenerator
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 20:09:00 +00:00
Carlos Ruiz 6b59db69ed peer review for 11535 -> getBPartnerCashTrx refactored with junit test applied
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 19:47:16 +00:00
Redhuan D. Oon 63780c78b2 JUNIT TEST for http://adempiere.svn.sourceforge.net/adempiere/?rev=11559&view=rev
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 07:53:05 +00:00
Redhuan D. Oon ab5b31fe9a FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 07:51:30 +00:00
Carlos Ruiz dfe03fabfa FR 2962094 - Finish implementation of weighted average costing
1st step -> create column to manage the processed date+time (in order to allow reposting of documents in the same order they were completed - this will be the second step)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962094
2010-03-03 01:31:36 +00:00
phib 5fdefd4be3 Future dated price list version used in order
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962244
2010-03-02 22:59:41 +00:00
vpj-cd d6e3780968 Apply ADempiere Best Practice and change the Collection by List as standard in ADempiere
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 17:15:59 +00:00
Redhuan D. Oon 3486415202 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:44:42 +00:00
Redhuan D. Oon 7fb5e6b54d Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:43:25 +00:00
Redhuan D. Oon d2333e9026 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:38:35 +00:00
Carlos Ruiz 4d76cea47e Found the NOT EXISTS part of the validation is not needed as it's controlled in MRMALine.beforeSave - better drop the NOT EXISTS part for backporting compatibility with 343 and 355
Fix [2904257] wrong validation sql for "M_InOutShipment/Receipt (RMA)"
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2904257
2010-03-01 17:30:14 +00:00
Redhuan D. Oon 5fba554eab Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 07:18:20 +00:00
Redhuan D. Oon ce29e05125 JUNIT TEST for http://adempiere.svn.sourceforge.net/adempiere/?rev=11545&view=rev
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 06:42:06 +00:00
Redhuan D. Oon 83154f494f FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 06:39:45 +00:00
Heng Sin Low c3805382ae Prepare window context before entering a tab
- Fixed invalid context for tab 0
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2959339
2010-03-01 05:37:59 +00:00
Redhuan D. Oon bff8e97dd6 JUNIT TEST for http://adempiere.svn.sourceforge.net/adempiere/?rev=11541&view=rev
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 01:41:37 +00:00
Redhuan D. Oon c0d989b240 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test included (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 00:42:03 +00:00
Redhuan D. Oon a3cf7e8d37 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 22:41:26 +00:00
Redhuan D. Oon b690a934d3 Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 09:55:38 +00:00
Redhuan D. Oon 042083872b Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Heng Sin's advice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 05:12:58 +00:00
Redhuan D. Oon 490cb806df Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Heng Sin's advice. No unit testing done but compiler tested OK.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 04:39:28 +00:00
Redhuan D. Oon fdfe4fb8b1 JUNIT TEST for http://adempiere.svn.sourceforge.net/adempiere/?rev=11535&view=rev
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 04:26:18 +00:00
Redhuan D. Oon e80c558107 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 04:24:19 +00:00
Redhuan D. Oon ede3856d8f JUNIT TEST for http://adempiere.svn.sourceforge.net/adempiere/?rev=11533&view=rev
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 02:03:00 +00:00
Redhuan D. Oon 583954e3eb FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 02:01:59 +00:00
Carlos Ruiz 03153697fe Peer review 11500, minor - drop useless comment, organize imports
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 21:06:50 +00:00
Carlos Ruiz cc7809b482 Apply Best Practices to Promotions Code: Use Model Classes instead of X_ classes whenever possible 2010-02-27 20:38:11 +00:00
Carlos Ruiz 1210dab275 Peer review 11504, be careful, you need to check retValue for null to avoid NPE
refactored to use common MProduct constructor
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 19:54:34 +00:00
Carlos Ruiz 94812caebc Peer review 11501, be careful with the login being replaced
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 19:38:25 +00:00
Carlos Ruiz 4a552b9877 Peer review 11499, fix error reported by Mario
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 19:23:17 +00:00
mjudd baa578cdfb [ BF 2960239 ] - Promotion Minimum Amt > 0
In the promotion line if the minimum amount is 0.00 (default) then the line
is not fired because the Promotion rule only activates when the minimum
amount is > 0. This means if you always want the rule to fire - you need
to make the minimum 0.01 which is not logical if you want no minimum.
https://sourceforge.net/tracker/?func=detail&aid=2960239&group_id=176962&atid=879332
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2960239
2010-02-27 15:41:14 +00:00
mjudd 139f65a82e [ BF 2960231 ] - PromotionValidator not fired in correct client
The promotion validator document validator is not fired because the client
id in the listener is not set correctly before adding the table to the
Model Validation Engine
https://sourceforge.net/tracker/?func=detail&aid=2960231&group_id=176962&atid=879332
2010-02-27 15:21:37 +00:00
Redhuan D. Oon d940e4d3e9 JUNIT TEST for http://adempiere.svn.sourceforge.net/adempiere/?rev=11520&view=rev
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 15:05:00 +00:00
Redhuan D. Oon bb3a54da57 FR: [ 2214883 ] Remove SQL code and Replace for Query
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 14:05:19 +00:00
Redhuan D. Oon 9aa3c31c35 Prevent SQL Injection (advice from Victor Perez)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 09:02:32 +00:00