Commit Graph

2798 Commits

Author SHA1 Message Date
hengsin 4c1ba12a3f
IDEMPIERE-3212 Quantity MatchPO wrong validation (#269)
Fix auto matching for matchpo and matchinv
2020-09-21 20:00:31 +02:00
Carlos Ruiz 1aa7565ad7
IDWS-8 Cannot update user info in WebStore (#267)
IDEMPIERE-4287
2020-09-21 18:01:21 +08:00
muriloht d875208a00
IDEMPIERE-3336 - Tables missing EntityType column (#258)
* IDEMPIERE-3336 - Tables missing EntityType column

* IDEMPIERE-3336 - fix PR review comments

* IDEMPIERE-3336 - fix PR review default value for entityType
2020-09-21 10:25:23 +02:00
hengsin dd2ef468b0
IDEMPIERE 4287 (#247)
* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
add support to make PO immutable

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added thread safe Immutable and Copy cache implementation for PO.
- migrate most of PO cache to immutable and copy cache.
- added pos sales order test.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- add test case for initial client setup and bank statement
- fix error for image editor, location editor, locator editor, initial
client setup, complete bank statement and migrate storage provider.

* IDEMPIERE-4287 Cache API not thread safe and inconsistent with Context
- added ImmutablePOSupport interface. Model class implement this
interface for immutable PO support.
- remove usage of cache for transaction table (rfq, invoice, inventory).
- add getCopy method to some model class to support getting an
updateable copy of PO from the otherwise immutable PO cache.
- the added getCopy method is use to return updateable PO for indirect
PO reference, for e.g MColumn.getAD_Table() and MOrderLine.getProduct.
2020-09-21 14:03:00 +08:00
Nicolas Micoud 9509d95c7c
IDEMPIERE-4460 : User suggestions for field/context help : check perm… (#257)
* IDEMPIERE-4460 : User suggestions for field/context help : check permission

new method to check exclusion of a table for current role, used to determine if popups should be displayed or not

* IDEMPIERE-4460 : User suggestions for field/context help : check permission

Following @globalqss's recommandations : rename the method + add more controls inside

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-09-20 15:53:56 +02:00
Elaine Tan 79d6c1e903
IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line (#250)
* IDEMPIERE-4263 Wrong matched invoice GL posting (currency balancing) in alternate schema for vendor credit memo if > 1 credit memo line
2020-09-18 20:58:14 +08:00
Carlos Ruiz 599e13dda3
IDEMPIERE-4462 (#263)
Integrate patch from Paul Bowden (Adaxa)

Co-authored-by: Paul Bowden <pbowden@adaxa.com>
2020-09-18 12:45:20 +02:00
Elaine Tan 236729e3f5
IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Re… (#239)
* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo

* IDEMPIERE-4173 Wrong GL postings for matched invoice in RMA/Vendor Return/Credit Memo - Added test case
2020-09-10 20:49:25 +08:00
Deepak Pansheriya e72dfd66c0
IDEMPIERE-4067 : Support for Under/Over line and Blank line in finaci… (#244)
* IDEMPIERE-4067 : Support for Under/Over line and Blank line in finacial report line.

* IDEMPIERE-4067 : Adding support for blank line export in CSV, HTML, Excel. Also allowing to show description if provided. fixed all review comments fron Carlos Ruiz
2020-09-08 12:59:19 +02:00
Deepak Pansheriya ee48ef2be4
Idempiere 4066 (#235)
* IDEMPIERE-4066: Adding 'Relative Period To' on financial report column which allow to specify period range to produce YoY. QoQ like comparision report.

* IDEMPIERE-4066: Fixing defaulting RelativePeriodTo to Null issue

* IDEMPIERE-4066: Fix as per Carlos review.
1. Fixing compilation issue
2. Moving Column ID constants to systemIDs
3. Updating serial version for MReportColumn.

* IDEMPIERE-4066: Reverted GridField class changes and configured defailt for RelativePeriodTo to be 'NULL'
2020-09-05 12:17:40 +02:00
Carlos Ruiz be525d178c
IDEMPIERE-4447 Add offset to Query (#243)
Add method Query.setRecordstoSkip
2020-09-04 21:42:14 +02:00
Carlos Ruiz e93cdcb38c
IDEMPIERE-4440 NPE in DocAllocationHdr (#241) 2020-09-04 21:38:20 +02:00
Carlos Ruiz dcd7d6a41e
IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confir… (#227)
* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Implement void for movement confirm

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Voiding the confirmation voids the inventory move too

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Similar case found in MInOut - cannot void because of catch-22
Allow to void MInOut -> it automatically voids all pending confirmations

* IDEMPIERE-1709 / IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Set quantities in zero when voiding movement confirmation
2020-08-31 14:23:33 +08:00
Nicolas Micoud 3384819c49
IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo (#238)
* IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo

* IDEMPIERE-4435 : GL Distribution - add ValidFrom / ValidTo (javadoc)
2020-08-28 16:14:45 +02:00
hengsin 7324dde78e
IDEMPIERE-4187 implement the usage of workflows in processes (#236)
Implement chaining of workflow through the use of Process Action
Implement overwrite of Record_ID for Process through Node Parameter
2020-08-27 14:34:26 +02:00
hengsin 9d614b985e
IDEMPIERE-4424 (#222)
* IDEMPIERE-4424 Concurrent update not prevented in Grid View

Grid View - change click navigation to follow the same flow as toolbar
navigation.

* IDEMPIERE-4424 Concurrent update not prevented in Grid View

GridTable - added Updated and Processed concurrency checked against PO.

* IDEMPIERE-4424 Concurrent update not prevented in Grid View

Incorporate fix suggested by Carlos
2020-08-27 12:40:44 +02:00
igorpojzl f13313760c
IDEMPIERE-4433 - MTable error - ConcurrentModificationException (#237)
Fix Putting into Cache outside Synchronized methods.
2020-08-26 20:35:16 +08:00
Carlos Ruiz 02f4d526dc
IDEMPIERE-4429 BOM Drop to Invoice is throwing error (#228)
IDEMPIERE-1314 getDocumentInfo methods should return translated String
2020-08-26 15:49:22 +08:00
Carlos Ruiz 75dcde96b3
IDEMPIERE-1482 Invoice with Payment Schedule is not displayed in Invoice Not Realized Gain/Loss (#225)
Fix problem reported by Anozi Mada
Fix issue found when testing - postgresql was failing with error
   org.postgresql.util.PSQLException: ERROR: la columna «c_doctypereval_id» es de tipo numeric pero la expresión es de tipo text
Avoid creating empty journal
2020-08-26 14:50:10 +08:00
hengsin 0e9f36add9
IDEMPIERE-3197 Tab still keep editing indicator when move to next record (#229)
Update tab title after save
2020-08-24 18:39:27 +02:00
Carlos Ruiz b0fbbb7a16
IDEMPIERE-4425 Find Window improvements (#224)
* IDEMPIERE-4425 Find Window improvements

Fix for printing report parameters - it is printing OPERATOR_EQUAL on reports instead of =

* IDEMPIERE-4425 Find Window improvements

Previous commit broke the find function - must use SQL for Values
2020-08-24 23:08:07 +08:00
Carlos Ruiz 2ad8fdfb3e
IDEMPIERE-2216:when make a warehouse order (in counter document test)… (#226)
* IDEMPIERE-2216:when make a warehouse order (in counter document test). new document material receipt is link with warehouse order not link with purchase order. it's correct?

* IDEMPIERE-2240:when create "On Credit Order" in counter document mode. invoice vendor make wrong reference to sale order

* IDEMPIERE-2257:can't complete invoice (vendor) generate from "order credit" by counter.

Integrating patch from Hiep hieplq@hasuvimex.vn
Changed syntax to be more readable
Used Processed instead of checking list of DocStatus

Co-authored-by: hieplq@hasuvimex.vn <hieplq@hasuvimex.vn>
2020-08-22 20:55:44 +02:00
Carlos Ruiz a9d24a2d5b
IDEMPIERE-4427 Changelog window reference lists dksplayed in wrong language (#221)
Ref IDEMPIERE-1540 e9e7486473
2020-08-21 20:56:34 +08:00
Carlos Ruiz a68c5f1968
IDEMPIERE-4425 Find Window improvements (#219) 2020-08-21 13:07:01 +02:00
Nicolas Micoud 2322a79dda
IDEMPIERE-4422 : GL Distribution - add SeqNo (#217)
* IDEMPIERE-4422 : GL Distribution - add SeqNo

Add SeqNo column on GL Distribution to allow users to choose the lowest one when several records are retrieved.
Fix typo

* IDEMPIERE-4422 : GL Distribution - add SeqNo

Fix a missed typo
2020-08-21 11:20:33 +02:00
Carlos Ruiz 7892c54aa1
IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user (#188)
* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Allow saving Tab Customization for System user

* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Fix copy/paste error

* IDEMPIERE-4386 setAD_User_ID() breaks when logged in as System user

Implement same suggestion on all the classes where setAD_User_ID must be allowed to explicitly set to System
There were already two classes with the Override approach: MUserPreference and MUserRoles, so this commit is to apply the same approach to all the classes with same approach
2020-08-13 18:20:59 +08:00
hengsin 60f4ea4215
IDEMPIERE-4406 Performance: PO Cache should not always reset all entr… (#212)
* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

PO update - reset cache by record id

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

refine unit test

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

add cache reset fix for delete

* IDEMPIERE-4406 Performance: PO Cache should not always reset all entries after update of one record

Fix exception when cache is empty
Expose hidden cache reset exception
2020-08-11 14:55:03 +02:00
hengsin 0ad8737829
IDEMPIERE-4405 Add basic cache statistics (#211)
fix wrong hit/miss count when cached value is null
2020-08-07 17:07:39 +02:00
hengsin 147eebb01b
IDEMPIERE-4405 Add basic cache statistics (#210)
add hit and miss count for cache
2020-08-07 13:05:34 +02:00
Carlos Ruiz a84adbad80
IDEMPIERE-4395 Cannot save valid strings in oracle - ORA-12899: value too large for column (#202) 2020-08-06 22:35:37 +08:00
hengsin c17f1ae733
IDEMPIERE-4389 (#206)
* IDEMPIERE-4389 Implement Copy Constructor support for PO

Implement PO support for copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

deprecate clone
replace clone with copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

add unit test for MPrintFormat copy constructor

* IDEMPIERE-4389 Implement Copy Constructor support for PO

fix wrong import
2020-08-05 21:03:40 +02:00
Carlos Ruiz 59758e8a7e
IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation (#198)
* IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

* IDEMPIERE-2624 Cant confirm 0 qty on Movement Confirmation

Add validations to avoid editing lines if there are pending confirmations, in movement and shipment/receipt
2020-08-03 20:45:08 +08:00
hengsin a3a86739c2
IDEMPIERE-4390 Error in the Workflow window (#201)
add keyword quote escape to gridtable and mquery
2020-08-03 13:43:38 +02:00
hengsin f010b10446
IDEMPIERE-4393 Replace Oracle outer join synax (+) with SQL standard outer join (#199)
add native postgresql unit test for GenericPaymentExport
remove unnecessary static and fix sql exception doesn't stop the export
replace Oracle (+) with standard sql outer joint
2020-08-03 12:04:53 +02:00
Carlos Ruiz 600d8efc70
IDEMPIERE-1804 Org of WF Process is Default(login) Organization. (#195)
Workflow org

Co-authored-by: Hideaki Hagiwara <hagiwara.hideaki@gmail.com>
2020-07-31 08:02:33 +08:00
Carlos Ruiz a143e63128
IDEMPIERE-1893 can't Reversed a complete document "move inventory with confirm" (#197)
Do not create confirmation for reversal
2020-07-31 07:58:10 +08:00
Carlos Ruiz 937eaaa6ce
IDEMPIERE-874 Suspense Account is Posted with Wrong Org on GL Journal (#190) 2020-07-30 23:06:14 +08:00
Carlos Ruiz 0fa717cf0a
IDEMPIERE-4083 currency rate by document or by transaction (#182)
Integrating a contribution from TrekGlobal developed by Heng Sin
2020-07-30 15:46:43 +08:00
Carlos Ruiz e79ef31cd5
IDEMPIERE-3897 export csv: reference column export like normal column (#189)
Fix issue that entity type and language are not being set when imported
2020-07-30 10:47:56 +08:00
hieplq 30ce8cc5be
IDEMPIERE-4376:order activity workflow by ID (also time it's created) (#187)
maybe order by seq-no of node link to activity is more stable than ID
2020-07-27 17:08:02 +02:00
hengsin 80146138ac
IDEMPIERE-4382 Locator Editor inconsistent in the application of filter (#183)
pass ValidationCode to MLocatorLookup
Fix dynamic display support
Fix filter for grid view
Fix locator dialog not open with the selected locator
2020-07-26 12:49:43 +02:00
hengsin 40efcea51e
IDEMPIERE-4381 Order Line QtyReserved not updated correctly for negative shipment (#180)
Fix update of QtyReserved
2020-07-26 10:48:55 +02:00
Carlos Ruiz 26d2e37339
IDEMPIERE-1848 can delete org, account record in "Account Schema Dime… (#150)
* IDEMPIERE-1848 can delete org, account record in "Account Schema Dimensions"

Set Accounting Schema > Account Schema Dimensions > Element Type readonly when the type is Account or Org

* IDEMPIERE-1848 can delete org, account record in "Account Schema Dimensions"

reverting https://github.com/idempiere/idempiere/commit/be8de78
from https://sourceforge.net/p/adempiere/bugs/773/
2020-07-22 15:22:23 +08:00
hengsin cc76e63d85
IDEMPIERE-4372 Performance: only add log record and sql statement to … (#172)
* IDEMPIERE-4372 Performance: only add log record and sql statement to context if trace/debug level <= debug/info

Minor clean up and thread safe fix for CLogErrorBuffer and MIssue
Only add LogRecord and SQL to context if TraceLevel is <= INFO

* IDEMPIERE-4372 Performance: only add log record and sql statement to context if trace/debug level <= debug/info

add back DB.isConnected check
remove redundant CLogErrorBuffer call from DB.isConnected
more fine grained synchronization
2020-07-21 12:25:20 +02:00
hengsin d3717bc1fa
IDEMPIERE-4373 Bug fixes for CSV Import loader (#174)
close trx in finally block.
m_directNullKey interfere with CSV Import Loader due to trx that's not
committed yet.
insert mode: update window/tab context after save.
2020-07-21 00:10:49 +02:00
igorpojzl dd2b24aafa
IDEMPIERE-4368: Allow Define Default Saved Query for User (#169)
* Update AD_UserQuery models

* Implementation of initializing Default User Queries

* Added Migration Scripts

* Update 202007161400_IDEMPIERE-4368.sql

Added missing register_migration_script.

* IDEMPIERE-4368 Added missing script.

* IDEMPIERE-4368 Allow Define Default Saved Query for User

Fix Load defaults only on Initialization.

* IDEMPIERE-4368

Move Migration Script to 7.1 folder

* IDEMPEIRE-4368

Apply of patch.
2020-07-20 14:51:48 +02:00
hengsin 31acb032ab
IDEMPIERE-4349 WTableDirEditor show inactive item (#167)
add back onlyActive logic when items is from cache.
2020-07-16 02:28:08 +07:00
Carlos Ruiz 4afaed6140
IDEMPIERE-3062 Unable to complete MR with qty >1 with Attribute Set of Always Mandatory (#144) 2020-07-15 11:05:49 +08:00
Carlos Ruiz 2d70a1a169
IDEMPIERE-1117 Attachment -> Disable preview over certain size (#145)
* IDEMPIERE-1117 Attachment -> Disable preview over certain size

New SysConfig key ZK_MAX_ATTACHMENT_PREVIEW_SIZE

* IDEMPIERE-1117 move scripts to 7.1
2020-07-14 21:51:17 +08:00
Carlos Ruiz e954df2abe
IDEMPIERE-4358 Processes to drop some objects from database (#161) 2020-07-09 19:50:29 +02:00