Commit Graph

873 Commits

Author SHA1 Message Date
Heng Sin Low bc6078de46 IDEMPIERE-726 Financial Report: Add inverse operation option for credit/debit only column #resolve 2013-03-13 00:22:47 +08:00
Carlos Ruiz 171c5db67d IDEMPIERE-37 Make iDempiere safer using saveEx instead of save 2013-03-12 08:39:50 -05:00
Heng Sin Low 784b7c39dc Merge c1e2deccf768 2013-03-12 16:23:48 +08:00
Heng Sin Low 3d95f7f716 Merge 3101959123e6 2013-03-12 16:21:48 +08:00
Heng Sin Low b8bc2e4da7 IDEMPIERE-724 Zk: Make iDempiere theme more easily customizable. 2013-03-12 16:21:04 +08:00
Carlos Ruiz aecfe6fc5d IDEMPIERE-454 Easy import (Work in progress) 2013-03-12 00:43:00 -05:00
Juan David Arboleda 506f380141 IDEMPIERE-454 Easy import 2013-03-11 23:34:37 -05:00
Juan David Arboleda 78ed339b63 IDEMPIERE-712 Adding C_City_ID validation to beforeSave on MLocation 2013-03-11 20:59:41 -05:00
Carlos Ruiz 7626490d6c IDEMPIERE-679 inactivate client allow to log in / fix also for Change Role 2013-03-11 20:04:27 -05:00
Juliana Corredor 40e9cf974c IDEMPIERE-679 inactivate client allow to log in 2013-03-11 19:50:35 -05:00
Carlos Ruiz ed47ed7118 IDEMPIERE-716 #resolve can't use new role when "User Level" of the role is "system" 2013-03-11 09:40:29 -05:00
Heng Sin Low 7a5fd10add IDEMPIERE-694 ILookupFactory and DefaultLookupFactory to load subclasses of Lookup dynamically via OSGI components. Contributed by Jan Thielemann. 2013-03-11 17:32:48 +08:00
Carlos Ruiz c0025d8c70 IDEMPIERE-716 can't use new role when "User Level" of the role is "system" #resolve 2013-03-10 21:51:14 -05:00
Heng Sin Low ba8cc7463f IDEMPIERE-598 Different errors when running Groovy scripts from Swing or Webui. Peer review. 2013-03-09 08:47:01 +08:00
Heng Sin Low f073540046 IDEMPIERE-704 The Min. value and Max. value validation of column is not working. Fixed regression for reversal of document. 2013-03-09 07:17:14 +08:00
Heng Sin Low 3914864058 Merge 52294af1db66 2013-03-08 14:49:18 +08:00
Carlos Ruiz 0e09ac40e9 IDEMPIERE-678 Cannot copy a print format twice 2013-03-08 00:02:30 -05:00
Heng Sin Low fdacee09f9 Merge bf77ea2b354c 2013-03-08 12:59:01 +08:00
Heng Sin Low 502291a313 IDEMPIERE-704 The Min. value and Max. value validation of column is not working. 2013-03-08 12:57:51 +08:00
Elaine Tan 353b7f2602 Ticket #1002354: Price List Enhancement 2013-03-07 19:13:42 +08:00
Heng Sin Low 5b2f4a18e5 IDEMPIERE-698 AssetInvoiceWithMixedLines_LRO not translated. 2013-03-07 07:38:13 +08:00
Elaine Tan b825eab40d Merge with c436f1be02c998a2a0d1fcfe5c2a254be6c10693 2013-03-06 16:53:03 +08:00
Elaine Tan efa7aa1ec3 Ticket #1001758: FedEx & UPS - update C_Order.IsPriviledgedRate to match the parameter passed in during sales order rate inquiry process 2013-03-06 16:42:20 +08:00
Carlos Ruiz 1ff94d5337 IDEMPIERE-358 Login- how to make unique and safe / Implement same approach for fitnesse and webservices login 2013-03-05 19:14:29 -05:00
Carlos Ruiz 335bf8bc2f IDEMPIERE-372 Improve error messages 2013-03-05 17:31:25 -05:00
Carlos Ruiz a6a2da1295 IDEMPIERE-678 Cannot copy a print format twice 2013-03-05 15:21:05 -05:00
Carlos Ruiz cdabca7b4b Minor changes to SQL - to ease the peer review of generated migration scripts avoiding convert changes 2013-03-05 14:07:17 -05:00
Heng Sin Low b8851a6661 Merge deb80b3b3124 2013-03-05 18:28:38 +08:00
Heng Sin Low d45d5ce4a8 Merge a9912f5c2c56 2013-03-05 18:27:53 +08:00
Heng Sin Low e8f48f3ed7 IDEMPIERE-674 Financial Report: Percentage of column against line total. 2013-03-05 18:27:12 +08:00
Heng Sin Low 5d6675db11 IDEMPIERE-673 Financial Report: Option to include source with no transaction. 2013-03-05 15:59:55 +08:00
Elaine Tan e127c10184 Ticket #1001763: Standard Templates for Docs and Forms - Reporting - Copy Print Formats from QS 2013-03-04 16:56:56 +08:00
Richard Morales de9b233f88 IDEMPIERE-671 AD_ImpFormat.Name unique is wrong - must have AD_Client in the unique index 2013-03-03 13:49:06 -05:00
Carlos Ruiz 893530a9b9 IDEMPIERE-127 Implement Recent Items dashboard / Let modified items appear on top 2013-03-01 19:27:49 -05:00
Heng Sin Low a36ed8d030 IDEMPIERE-369 Master Detail layout improvements. Fixed unnecessary severe warning "Table Not Open". 2013-03-01 19:59:42 +08:00
jan thielemann 325f48f7ac IDEMPIERE-598 Different errors when running Groovy scripts from Swing or Webui 2013-02-28 12:50:36 -05:00
Carlos Ruiz ac93bd4473 IDEMPIERE-638 Check log level before calling logging method / log.info / Thanks to Richard Morales 2013-02-27 20:58:38 -05:00
Carlos Ruiz 4bf4364757 IDEMPIERE-207 GL Journal Generator / Fix NPE when simulate option 2013-02-27 19:05:06 -05:00
Carlos Ruiz 590faaf60a IDEMPIERE-668 In 'Client' window, the toolbar button 'Detail Record' doesn't work 2013-02-27 13:46:38 -05:00
Heng Sin Low e4cda7e0a8 Merge a308056929e6 2013-02-27 23:24:10 +08:00
Heng Sin Low cb21a92f13 IDEMPIERE-669 Zk: User Feedback Service. 2013-02-27 23:21:27 +08:00
Heng Sin Low 184f457783 IDEMPIERE-665 Server: setting logging level have no effect. 2013-02-27 07:58:08 +08:00
Carlos Ruiz b223b3a20c IDEMPIERE-638 Check log level before calling logging method / fix missing parenthesis / Thanks to Richard Morales 2013-02-26 17:24:09 -05:00
Heng Sin Low 002c3c474d IDEMPIERE-593 Save can empty location fields. 2013-02-26 11:45:52 +08:00
Heng Sin Low 78aa3ede3e Merge 62ea97ed940a 2013-02-26 11:18:27 +08:00
Heng Sin Low 8351ee7bd1 IDEMPIERE-638 Check log level before calling logging method / log.finer. Fix missing parenthesis. 2013-02-26 11:16:55 +08:00
Richard Morales ce7938424e IDEMPIERE-638 Check log level before calling logging method / log.fine 2013-02-25 19:00:59 -05:00
Richard Morales ada4a0f749 IDEMPIERE-638 Check log level before calling logging method / log.finer 2013-02-25 14:08:35 -05:00
Richard Morales a6b7473ff4 IDEMPIERE-638 Check log level before calling logging method / log.finest 2013-02-25 14:00:29 -05:00
Richard Morales e0b18312f8 IDEMPIERE-638 Check log level before calling logging method / log.config 2013-02-25 12:29:10 -05:00
Heng Sin Low 6ae0aaaa82 Merge f45f50571e52 2013-02-25 21:18:12 +08:00
Heng Sin Low 486201c8b1 IDEMPIERE-663 Zk: Remove the need of re-query for table editor after user have create a new record. 2013-02-25 19:57:24 +08:00
Richard Morales 74d197cb57 IDEMPIERE-638 Check log level before calling logging method / logger.info+fine 2013-02-22 17:17:40 -05:00
Richard Morales 427e8e08f2 IDEMPIERE-638 Check log level before calling logging method / s_log.info logger.config+info 2013-02-22 15:59:05 -05:00
Richard Morales 7c53aa5f4d IDEMPIERE-638 Check log level before calling logging method / s_log.fine 2013-02-22 15:50:25 -05:00
Richard Morales b5102829f1 IDEMPIERE-638 Check log level before calling logging method / s_log.finest+finer 2013-02-22 15:43:26 -05:00
Carlos Ruiz 9862bfb37f IDEMPIERE-372 Improve error messages 2013-02-22 10:05:33 -05:00
Elaine Tan f13a9484c9 Ticket #1001758: FedEx & UPS - Support 'Calculated', 'Fix price' and 'Freight included' freight cost rule 2013-02-22 17:29:17 +08:00
Heng Sin Low abf201f9b6 Merge 23e19de212b1 2013-02-22 14:48:46 +08:00
Heng Sin Low 9e10389533 IDEMPIERE-653 Window stay read-only if first record is System. 2013-02-22 14:30:16 +08:00
Richard Morales ecbe68a1c7 IDEMPIERE-638 Check log level before calling logging method / s_log.finest 2013-02-21 13:00:23 -05:00
Richard Morales fee2df24c9 IDEMPIERE-638 Check log level before calling logging method / s_log.config 2013-02-21 12:11:33 -05:00
Heng Sin Low 54883e258d Merge 2cdeca01ec39 2013-02-21 10:38:06 +08:00
Heng Sin Low bbff624ee6 IDEMPIERE-635 Reference validation behaving different than Dynamic Validation. Fixed regression for list reference. 2013-02-21 10:37:03 +08:00
Richard Morales 65a9dc9adc IDEMPIERE-568 Review proper closing of JDBC statements and resultsets 2013-02-20 20:31:16 -05:00
Carlos Ruiz c84e60ff1c IDEMPIERE-637 GL Journal: Accounting Dimension "User Element 1&2" not posted to Accounting Facts / Thanks to Thomas Bayen
Transplanted and modified from:
https://bitbucket.org/tbayen/idempiere/commits/e8c641c
2013-02-20 10:50:15 -05:00
Heng Sin Low 93ad118186 IDEMPIERE-635 Reference validation behaving different than Dynamic Validation. Previous revision break lookup direct for non base locale. 2013-02-20 21:52:46 +08:00
Heng Sin Low 4c6032b193 IDEMPIERE-635 Reference validation behaving different than Dynamic Validation. 2013-02-20 20:08:30 +08:00
Heng Sin Low d8e7b6ee67 Merge 49f33f4950c9 2013-02-20 17:56:44 +08:00
Heng Sin Low 066a7bc612 IDEMPIERE-639 Sequence field not display in Grid Model. 2013-02-20 17:50:55 +08:00
Richard Morales f737c1fc87 IDEMPIERE-568 Review proper closing of JDBC statements and resultsets 2013-02-19 18:17:37 -05:00
Carlos Ruiz cb10e71ad0 IDEMPIERE-568 Review proper closing of JDBC statements and resultsets 2013-02-19 16:16:17 -05:00
Richard Morales 9b0c13b9f5 IDEMPIERE-568 Review proper closing of JDBC statements and resultsets 2013-02-19 16:08:13 -05:00
Heng Sin Low d86e3e4e71 Merge ea73bc0ccc6c 2013-02-19 21:29:28 +08:00
Elaine Tan e31c3f0341 Ticket #1002211: Create Help pane for Bizidium - allow the same context help message to multiple instances (e.g. tabs, processes, and forms) 2013-02-19 18:57:53 +08:00
Carlos Ruiz 7cdcc71a41 IDEMPIERE-645 Fitnesse Recorder 2013-02-18 21:20:39 -05:00
Carlos Ruiz f06e6c1917 IDEMPIERE-616 VBinary improvement for swing client + bugfix in GridTable / Thanks to Jan Thielemann 2013-02-18 13:16:18 -05:00
Heng Sin Low 6a8ded433e Merge 04277f8ad9d3 2013-02-18 12:09:05 +08:00
Heng Sin Low 9865d517a9 IDEMPIERE-638 Check log level before calling logging method. 2013-02-18 12:08:05 +08:00
Richard Morales 7838f1bf04 IDEMPIERE-568 Review proper closing of JDBC statements and resultsets 2013-02-15 19:26:22 -05:00
Juan David Arboleda 63d34ee56e IDEMPIERE-454 Easy import / Version 3 Exporter - when exporting on a detail tab export parent and details 2013-02-14 13:48:47 -05:00
Heng Sin Low 8c7ba69090 IDEMPIERE-293 Support for Kill Session. Use dynamic service for access to IMessageService to avoid startup timing issue. 2013-02-14 21:07:31 +08:00
Heng Sin Low 1c718c74a9 IDEMPIERE-359 Add OSGi Service support for existing extension point. Remove obsolete xml file. 2013-02-14 21:01:31 +08:00
Heng Sin Low 0fa32d3826 IDEMPIERE-604 Error if window has more than 1000 rows. GridTab.getCurrentRow() should be a read only getter that doesn't modify the m_currentrow pointer. 2013-02-14 00:09:45 +08:00
Heng Sin Low 06ebc462b8 Merge 3b92d1d047fe 2013-02-13 17:36:22 +08:00
Heng Sin Low f4da72ef50 IDEMPIERE-359 Add OSGi Service support for existing extension point. 1) Separate osgi service and equinox extension locator API. Service.locator() for OSGi service and EquinoxExtensionLocator.instance() for equinox extension. 2) Use OSGi service for all singleton component ( all factories and most services ) and equinox extension for others ( UI object, Process instance and PIPO handlers). 2013-02-13 16:15:43 +08:00
Carlos Ruiz 1aaf64fa7b remove duplicate (altercolumn was there at functions and now is duplicated at procedures) 2013-02-08 10:52:01 -05:00
Heng Sin Low d26c8845b5 IDEMPIERE-613 Column Encryption Enhancement. Fixerd synchronization and release of resource . 2013-02-08 18:27:26 +08:00
Heng Sin Low 39a01cfed9 Merge c4249198a528 2013-02-08 11:18:04 +08:00
Heng Sin Low 416de5e925 Merge 64973314fe94 2013-02-08 11:17:14 +08:00
Heng Sin Low 8e8f0e1cd7 IDEMPIERE-604 Error if window has more than 1000 rows. 2013-02-08 11:13:33 +08:00
Carlos Ruiz 9af1992d05 IDEMPIERE-605 Error message when saving new Business Partner / related to IDEMPIERE-362 Hide things that don't work on iDempiere 2013-02-07 17:50:43 -05:00
Carlos Ruiz 0becbfbf3e IDEMPIERE-617 Enable logging of authentication failures 2013-02-07 13:20:27 -05:00
Elaine Tan e97f0463b6 Ticket #1002211: Create Help pane for Bizidium 2013-02-07 19:25:54 +08:00
Carlos Ruiz 1640fec333 IDEMPIERE-90 Restricted items on Combobox / refactor to avoid direct SQL and use cache 2013-02-06 10:50:35 -05:00
Carlos Ruiz 9d593123c9 Merged tbayen/idempiere-swing into development 2013-02-06 10:25:38 -05:00
Carlos Ruiz d84f3a77c6 Merged in tbayen/idempiere (pull request #59)
IDEMPIERE-596 Report hangs if column for "next line" does not exist
2013-02-06 10:13:27 -05:00
Carlos Ruiz 8d66ca7fe7 IDEMPIERE-610 Import of BankStatement does not work (can not create new bank statements) - thanks to Thomas Bayen 2013-02-06 10:10:26 -05:00
Heng Sin Low b6af6a3489 IDEMPIERE-613 Column Encryption Enhancement. 2013-02-06 18:03:42 +08:00
Heng Sin Low 8d5f668baf Merge 432b42c979ad 2013-02-04 18:11:05 +08:00
Heng Sin Low 01d80efbb5 IDEMPIERE-608 Zk InfoSchedule: Replace TimeLine with Calendar component. 2013-02-04 18:09:59 +08:00
Heng Sin Low ae6f9fb243 IDEMPIERE-325 Complete AD based info window ( AD_InfoWindow ) implementation. Ported InfoAssignment, InfoBPartner, InfoInOut, InfoInvoice, InfoOrder and InfoPayment. 2013-02-04 18:05:40 +08:00
Elaine Tan 2238b7d737 IDEMPIERE-60 - Bizidium must not save credit card number 2013-02-01 11:57:45 +08:00
Heng Sin Low ef393112e3 IDEMPIERE-325 Complete AD based info window ( AD_InfoWindow ) implementation. Added IsIdentifier and SeqnoSelection to AD_InfoColumn. Ported InfoOrderPanel. 2013-01-30 22:38:09 +08:00
Nicolas Micoud f584dcc1c5 Merged idempiere/idempiere into development 2013-01-30 15:19:59 +01:00
Carlos Ruiz 6b50b40a42 IDEMPIERE-600 Use User Org Access in Role didn't work - thanks to Juliana Corredor 2013-02-06 08:26:39 -05:00
Carlos Ruiz c1a0a80416 IDEMPIERE-597 Role Access Update is creating workflow access for other tenants workflows 2013-01-29 10:37:42 -08:00
Heng Sin Low 09269e1c78 Merge 8ea10ec5ce3f 2013-01-30 00:29:57 +08:00
Heng Sin Low 8a22f8c3e5 IDEMPIERE-325 Complete AD based info window ( AD_InfoWindow ) implementation. Ported InfoBPartnerPanel to InfoBPartnerWindow. 2013-01-30 00:28:27 +08:00
Elaine Tan d50e43d850 Ticket #1001569: Move receipts into batch from QS to Idempiere 2013-01-29 14:38:39 +08:00
Thomas Bayen 6efdf383dc IDEMPIERE-596 Report hangs if column for "next line" does not exist 2013-01-29 00:15:48 +01:00
Carlos Ruiz 5c55d46ad1 IDEMPIERE-594 Improve positioning on windows / Change DocAction button to have the name of the Document Action element 2013-01-25 17:28:38 -08:00
Carlos Ruiz df55f2e0cf IDEMPIERE-369 Master Detail layout improvements / Found an infinite loop when a child tab is defined in level 2 and the parent tab is defined in level 0 2013-01-25 16:20:00 -08:00
Nicolas Micoud 92a269f200 IDEMPIERE 90 2013-01-24 12:15:23 +01:00
Carlos Ruiz c2941041fe IDEMPIERE-568 Review proper closing of JDBC statements and resultsets 2013-01-23 16:05:42 -08:00
Heng Sin Low 66c7e2267e Merge 24fba97c4841 2013-01-23 18:21:41 +08:00
Heng Sin Low 7cc4052caf IDEMPIERE-325 Complete AD based info window ( AD_InfoWindow ) implementation. Ported existing info product panel to the new ad_infowindow implementation. 2013-01-23 18:20:49 +08:00
David Peñuela 5eb035dfac IDEMPIERE-373 Implement User Locking / Improve error messages 2013-01-22 21:55:48 -08:00
Elaine Tan 8add04b700 Ticket #1001770: RMA improvements - add callouts to populate the data when shipment/receipt line, product or charge field changed 2013-01-22 20:21:21 +08:00
Carlos Ruiz 1cc2094b3a IDEMPIERE-578 Zoom to detail broken on BP 2013-01-21 17:53:51 -08:00
Elaine Tan c3288cdd41 Ticket #1001770: RMA improvements - support optional shipment/receipt line in rma line 2013-01-21 19:45:11 +08:00
Heng Sin Low b0fe14d87e Merge ced6213e57fb 2013-01-21 12:53:09 +08:00
Carlos Ruiz 9001929ae1 IDEMPIERE-567 Move ProductUOMConversionRateValidate sysconfig key to be client configurable 2013-01-18 11:38:44 -08:00
Carlos Ruiz 2b3f71e48c IDEMPIERE-568 Review proper closing of JDBC statements and resultsetsHG: Enter commit message. Lines beginning with 'HG:' are removed. 2013-01-18 11:34:42 -08:00
Elaine Tan 5448d70f3f Ticket #1001770: RMA improvements - support optional shipment/receipt line in rma line and rma tax. 2013-01-18 19:16:40 +08:00
Heng Sin Low 78d846ccad Merge 280cf71dcd1b 2013-01-18 15:29:14 +08:00
Elaine Tan 5e97b03ebf Ticket #1001770: RMA improvements 2013-01-18 11:49:41 +08:00
Juan David Arboleda 0ebc6fab41 IDEMPIERE-454 Easy import / Version 2 - add update capatibility in 1 tab - it requires the key field(s) to be suffixed with /K 2013-01-16 16:24:03 -08:00
Heng Sin Low d91e1e41cb Merge e7949f8cecbd 2013-01-17 01:15:22 +08:00
Heng Sin Low 9d312ff605 IDEMPIERE-348 Zk Performance: remove use of polling background thread for update of dashboard. Use server side event to update calendar and recent items dashboard widget. Activities dashboard widget is still using polling but update of home tab label for activities count is now event driven. 2013-01-17 01:14:16 +08:00
Carlos Ruiz 229be1faf2 Merged in tbayen/idempiere (pull request #55: IDEMPIERE-539) 2013-01-16 06:49:10 -08:00
Carlos Ruiz da3e69fd34 IDEMPIERE-166 Rebranding of logo and product name 2013-01-16 06:44:38 -08:00
Thomas Bayen c1ef669512 Merge with bd14881f01d02cc8e4ea979e62c67b2c5373c0b4 2013-01-16 02:21:39 +01:00
Carlos Ruiz 8609a6a53b IDEMPIERE-553 Can not set Nullable Combobox fields to Null after setting them to a non-null value 2013-01-14 18:04:00 -08:00
Elaine Tan 28903d9672 Ticket #1001758: FedEx & UPS - Add back 'Name' column to M_Shipper, M_ShipperLabels, M_ShipperPackaging, M_ShipperPickupTypes and M_ShippingProcessor. Revise the shipping processor and shipper callouts. 2013-01-09 17:21:18 +08:00
Heng Sin Low efa9fa0a72 IDEMPIERE-325 Complete AD based info window ( AD_InfoWindow ) implementation. Added support for custom query operator and query function. Added support to open info window from menu. 2013-01-09 12:09:58 +08:00
Heng Sin Low 5fa0eb06de IDEMPIERE-325 Complete AD based info window ( AD_InfoWindow ) implementation. Fixed support for order by and group by. 2013-01-05 08:56:56 +08:00
Heng Sin Low 06362405e1 IDEMPIERE-325 Complete AD based info window ( AD_InfoWindow ) implementation. Still pending migration of existing custom InfoPanel implementation. 2013-01-04 16:59:50 +08:00
Heng Sin Low bf3f098726 IDEMPIERE-542 Zk: IColumnCallout extension doesn't work. Fixed org.compiere.model.Callout extension point not working. 2013-01-03 00:16:06 +08:00
Heng Sin Low 1a096ff10a Merge 3ec3918730fd 2012-12-28 00:30:38 +08:00
Elaine Tan f6a4dc5b88 Ticket #1001758: FedEx & UPS - Get Contact/User from order if shipment's Contact/User is not defined and fix the description of create package process 2012-12-27 18:59:13 +08:00
Thomas Bayen 81c60eba4c IDEMPIERE-539 Import GL Window does not allow Key Values for Activity, Campaign, Sales Region 2012-12-26 02:50:26 +01:00
Heng Sin Low 679b9ca1f9 IDEMPIERE-537 Zk: Dynamic Validation Rule for Advanced Query 2012-12-24 18:17:04 +08:00
Heng Sin Low 84af8c3d6a IDEMPIERE-455 Discover and fix FindBugs problems / Eclipse warning - Drop deprecated class AsyncProcess. 2012-12-23 15:16:09 +08:00
Heng Sin Low 7fcd2cba58 IDEMPIERE-455 Discover and fix FindBugs problems / Eclipse warning - Fixed generic type warning. Drop classes that's not used anywhere. 2012-12-23 15:08:57 +08:00
Elaine Tan 83153617a9 Ticket #1001758: FedEx & UPS 2012-12-21 18:49:07 +08:00
Elaine Tan d33e6319c9 Ticket #1001758: FedEx & UPS 2012-12-21 18:48:41 +08:00
Carlos Ruiz 49562e0b98 IDEMPIERE-455 Discover and fix FindBugs problems / Eclipse warning -> The import ___ is never used 2012-12-20 16:19:55 -05:00
Richard Morales d0c6f4127a IDEMPIERE-455 Discover and fix FindBugs problems / Eclipse warning -> suppress unchecked 2012-12-20 15:47:59 -05:00
Carlos Ruiz 740908e0c5 IDEMPIERE-455 Discover and fix FindBugs problems / Eclipse warning -> dead code 2012-12-20 15:46:40 -05:00