Commit Graph

2874 Commits

Author SHA1 Message Date
Diego Ruiz da6d6b83aa
IDEMPIERE-4607 Cannot export windows via 2pack if any field has a Fie… (#483)
* IDEMPIERE-4607 Cannot export windows via 2pack if any field has a Field Group

* IDEMPIERE-4607 Implement changes discussed in JIRA - Add a new isList method to DisplayType

* IDEMPIERE-4607 Fixed typo

* IDEMPIERE-4607 Implement default method to return false by default - PR CarlosRuiz
2020-12-26 16:35:50 +01:00
Carlos Ruiz 8103ab0732 IDEMPIERE-4604 Release 8.2
Change references to new version
Create new migration folder
2020-12-20 10:15:20 +01:00
Carlos Ruiz 6390ce20cd IDEMPIERE-4604 Release 8.2
Fix warnings on MANIFEST.MF
2020-12-20 09:53:21 +01:00
Carlos Ruiz 3b1e4f2735 IDEMPIERE-4604 Release 8.2
Model generate classes
2020-12-20 09:51:58 +01:00
Carlos Ruiz 00a08236fc IDEMPIERE-4604 Release 8.2
Credits and version number
2020-12-20 09:25:13 +01:00
hengsin b80ed34d9c
IDEMPIERE-4599 Remove obsolete org.compiere.interfaces.* interface (#473)
* IDEMPIERE-4599 Remove obsolete org.compiere.interfaces.* interface

* IDEMPIERE-4599 Remove obsolete org.compiere.interfaces.* interface

remove warning.
2020-12-18 14:52:11 +01:00
Carlos Ruiz 2ab2211f81
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#468)
Extracting from @hengsin pull request 465
Fixes cross tenant readings in MUser MUserDefWin and MWorkflow
2020-12-16 09:08:11 +08:00
hengsin 1df6f63341
IDEMPIERE-4598 Disable obsolete IsServer* fields (#467)
* IDEMPIERE-4598 Disable obsolete IsServer* fields

* IDEMPIERE-4598 Disable obsolete IsServer* fields

- Fix wrong migration script name
2020-12-14 15:10:29 +01:00
hengsin 5e977d427c
IDEMPIERE-4287 Cache API not thread safe and inconsistent with context parameter (#466)
- Fix PO immutable exception with Workflow Validate process.
2020-12-14 14:53:55 +01:00
Carlos Ruiz fd947f4fef
IDEMPIERE-4581 Model generator should isn't dialog it should be window (#463)
* IDEMPIERE-4581 Model generator should isn't dialog it should be window

use shutdown asyn to shutdown framework when close Model generator window

one unhappy thing remain:
when use -console then framework is shutdown but jdk still hang because "pipe-gosh --login --noshutdown" still live (for https://bugs.eclipse.org/bugs/show_bug.cgi?id=362412)
work-around: use -console 1234
by that way we can't access osgi command from console but can use "telnet localhost 1234" to use osgi command

* IDEMPIERE-4581 Model generator should isn't dialog it should be window

Fix problem about program not closing
Improve layout

Co-authored-by: hieplq <hieplq@hasuvimex.vn>
2020-12-13 07:57:33 +08:00
Carlos Ruiz 5da1785572
IDEMPIERE-4596 Cannot create a product and an inventory document in t… (#459)
* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction

WIP - commit failing unit test

* IDEMPIERE-4596 Cannot create a product and an inventory document in the same transaction

Implement solution suggested by @hengsin

* minor fix comment
2020-12-12 16:12:31 +01:00
Carlos Ruiz 9d6de521f2
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#456)
Extracting from @hengsin pull request 453
2020-12-11 16:48:16 +08:00
Carlos Ruiz f2c5ec429b
IDEMPIERE-4589 BUGS on PERFORMANCE ANALYSIS -> Accounting Rules ->Accounting Setup (#457) 2020-12-11 14:40:58 +08:00
Carlos Ruiz 4d96ac1f8e
IDEMPIERE-4593 Error completing a Standard Sales Order with Shipper and Calculated Freight Cost Rule (#454) 2020-12-10 13:57:25 +01:00
Carlos Ruiz 6fa0052834
IDEMPIERE-4588 Error in MOrder.setC_DocTypeTarget_ID (String DocSubTypeSO_x) when IsDefault=Y in a Purchase Order (#446) 2020-12-09 20:49:15 +01:00
Carlos Ruiz d654ed5791
IDEMPIERE-4587 Wrong ordered qty when reactivating a purchase order and setting a line to zero (#445) 2020-12-09 20:49:01 +01:00
Carlos Ruiz 34fec8c156
IDEMPIERE-4591 Load Bank Statement is not working in multi-tenant environments (#450)
IDEMPIERE-4268
2020-12-09 19:00:41 +01:00
Carlos Ruiz 46bc0e022f
IDEMPIERE-4358 Processes to drop some objects from database (#448)
Add process to rename a column directly from the Table and Column window
2020-12-09 15:31:13 +01:00
Carlos Ruiz 4c66c0018d
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#443)
Implement thread safe mechanism
https://mattermost.idempiere.org/idempiere/pl/hmpd8freutbhbgcjr9tu6ntitr
2020-12-09 14:28:49 +01:00
Carlos Ruiz 416d92a292
IDEMPIERE-4421 Html asset versioning should allow fluent deployment (#441)
Fix problem reported by ken.wang at
https://mattermost.idempiere.org/idempiere/pl/3wmpzg1o5i88dec5pifkjd3qfe
2020-12-07 22:59:23 +08:00
Carlos Ruiz 02ce1f3c1f
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#436)
Two more points found about cross tenant readin in MClient and MUser
2020-12-05 12:42:43 +08:00
Carlos Ruiz b9964ce7ab
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#432)
Fixes:
org.adempiere.exceptions.AdempiereException: Cross tenant PO reading request detected from session 1009629 for table AD_UserDef_Win Record_ID=1000002
	at org.compiere.model.PO.checkValidClient(PO.java:5000)
	at org.compiere.model.PO.<init>(PO.java:212)
	at org.adempiere.model.GenericPO.<init>(GenericPO.java:81)
	at org.compiere.model.MTable.getPO(MTable.java:598)
	at org.compiere.model.Query.list(Query.java:286)
	at org.compiere.model.MUserDefWin.getAll(MUserDefWin.java:107)
	at org.compiere.model.MUserDefWin.getBestMatch(MUserDefWin.java:160)
2020-12-03 12:55:15 +01:00
Deepak Pansheriya 8b672a3a51
IDEMPIERE-2999 : refactoring as per Hengsin's review comments (#427)
* IDEMPIERE-2999 : refactoring as per Hengsin's review comments

* IDEMPIERE-2999: Fixing compilation issue

* IDEMPIERE-2999: Fixing as per Hengsin'e review
2020-12-02 22:59:23 +08:00
Carlos Ruiz bf65636e22
IDEMPIERE-4577 Problem creating an invoice vendor negative after the … (#428)
* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment

* IDEMPIERE-4577 Problem creating an invoice vendor negative after the shipment

Add unit test
2020-12-02 21:08:41 +08:00
Carlos Ruiz 8cf16ba137
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#425)
Implement cross tenant check on foreign keys for insert and update
2020-12-01 07:16:22 +08:00
Carlos Ruiz 3a9b932df4
IDEMPIERE-4268 Fix recursive call to PO (#424)
* IDEMPIERE-4268 Fix recursive call to PO

Found a case where PO.checkValidClient fails, and then because of log.severe it tries to create a record with MIssue, and the PO.checkValidClient fails in MIssue, and is called recursively until it fails with a "Trx.run: Transaction timeout."

* IDEMPIERE-4268

- Improve error message
- Fix problem with valid cross-tenant reads in MRegion and MWorkflow
2020-11-30 21:36:51 +01:00
Carlos Ruiz 0eb4986513
IDEMPIERE-4575 Cannot complete Material Receipt from negative PO (#419) 2020-11-28 07:09:39 +08:00
Carlos Ruiz d885aaf4e6
IDEMPIERE-4268 Web Services : Read miss cross-tenant check (#415)
Co-authored-by: Heng Sin Low <hlow@trekglobal.com>
2020-11-26 20:22:18 +08:00
Carlos Ruiz 460f7116a2
IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong … (#414)
* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance

MAllocationHdr.updateBP was broken, the form Payment Allocation worked just because it was calling bpartner.setTotalOpenBalance() at the end
so, I refactored the MAllocationHdr.updateBP and before/afterDelete to call bpartner.setTotalOpenBalance instead if the broken algorithm

Unit test added for allocating and deleting a customer invoice, a vendor invoice, and a charge

* IDEMPIERE-4567 Resetting payment allocation to a charge leaves wrong BP Balance

- Fix peer review changes requested by @hengsin
- Detected double call to bpartner.setTotalOpenBalance in WAllocation
- Detected some business partners in GardenWorld with wrong TotalOpenBalance or SO_CreditUsed, added migration script to fix it, it made more complicate to write unit tests as the data was wrong
2020-11-26 17:08:05 +08:00
Carlos Ruiz 6eeabc49ba
IDEMPIERE-4566 Translation Import/Export - output message is not visible (#408)
- Deprecate zk form WTranslationDialog and controller TranslationController
- Move the logic to a java process org.idempiere.process.TranslationImpExp
- As a process works in mobile, can be called via webservices, tested with fitnesse, etc
- Importing leaves a better and readable log of each file processed
- Importing/Exporting gives feedback to the user about the file being processed

Side note:
- To standardize the menu - renamed the "Initial Client Setup Process" to "Initial Client Setup"

Improvements over the previous form:
- can process the files from the zip in root folder, or in internal folder with the name of the language
- can process a URL http/https to download the zip file
2020-11-26 16:20:17 +08:00
Carlos Ruiz 363f21993f
IDEMPIERE-4285 Cannot send mail while creating RfQ Response (#413)
Co-authored-by: Ray Lee <ray@iroses.tw>
2020-11-26 12:55:10 +08:00
Carlos Ruiz 2735131285
IDEMPIERE-4520 Attribute Instance not Refreshed on Create only on Update (#409) 2020-11-25 10:59:32 +01:00
Orlando Curieles b05b26d9f1
IDEMPIERE-4572 Fix NPE (#402) 2020-11-22 09:49:29 +08:00
Carlos Ruiz b778904d42
IDEMPIERE-4558 Copy GardenWorld into a new Client using Copy Client - failing in postgresql native (#399)
Fix the problem in postgresql native
2020-11-21 14:21:45 +08:00
AndreaCh83 530d5e7b9a
IDEMPIERE-4555 Incorrect price in intercompany document (#389)
* IDEMPIERE-4555 Incorrect price in intercompany document

* Update MOrder.java

* Update MOrder.java
2020-11-21 07:55:02 +08:00
Carlos Ruiz 611e1bbb8f
IDEMPIERE-4560 Autocomplete fills the value to be suggested to the user with the cache and does not support multilanguage (#397)
Fixes the problem about caching results from previously used language, breaking the usage of base language when another language was used previously
2020-11-21 07:49:57 +08:00
Carlos Ruiz 837c04f063
IDEMPIERE-4542 Cannot report from window _My Unprocessed Documents_ (#376) 2020-11-13 18:07:07 +08:00
Diego Ruiz ed7a7dcbde
IDEMPIERE-4525 Translate MailText in Print Invoices to the corresponding BP Language (#356) 2020-11-05 17:12:53 +01:00
Carlos Ruiz 210e54b05f IDEMPIERE-4521 Release 8.1 - RC
Change versions in pom and manifest files
2020-11-03 21:59:12 +01:00
Carlos Ruiz da49f81591 IDEMPIERE-4521 Release 8.1 - RC
Generate model - 4 steps:
"org.compiere.model" "D,EE05" "%"
"org.compiere.model" "D" "AD_UserMail" "D"
"org.eevolution.model" "EE01,EE04,EE02" "%"
"org.compiere.model" "D" "'AD_AllUsers_V','AD_AllClients_V'"
2020-11-03 21:59:12 +01:00
Carlos Ruiz 2753acac56 IDEMPIERE-4521 Release 8.1 - RC
Change references in files
2020-11-03 21:59:12 +01:00
hengsin 1e909ffb53
IDEMPIERE-4519 Zk: Implement optional defer rendering for Grid View (#350) 2020-11-03 15:40:36 +01:00
Carlos Ruiz 88dff840ac
IDEMPIERE-3340 (#351)
* Revert "IDEMPIERE-3340 Fixes for oracle migration scripts (#346)"

This reverts commit db7b9db43c.

* Revert "IDEMPIERE-3340: Tree Structurable User Favorite (#334)"

This reverts commit 01d52fbfef.
2020-11-03 15:40:17 +01:00
Deepak Pansheriya 01d52fbfef
IDEMPIERE-3340: Tree Structurable User Favorite (#334) 2020-11-02 19:28:03 +08:00
hengsin 03d668bf51
IDEMPIERE-4211 Schedulers launched twice - problem with RunOnlyOnIP null running on load balancer (#345)
- log errors from background init.
- add explicit Env Context init for AdempiereMonitor thread and
Background init thread.
2020-11-02 11:23:24 +01:00
Carlos Ruiz c9a766c806
IDEMPIERE-4297 Improve test data (#344)
Fix error reported by @hengsin
Doc_Invoice.getValidCombination_ID: NO account Type=4

Make explicit the deprecation in code and hide the deprecated account fields on IDEMPIERE-362
2020-11-02 10:39:40 +08:00
hengsin b4c93c76b3
IDEMPIERE-4516 InvoiceCustomerTest show NPE at console (#342)
* IDEMPIERE-4516 InvoiceCustomerTest show NPE at console

add NPE check

* IDEMPIERE-4516 InvoiceCustomerTest show NPE at console

- add way to defer the immediate posting of doc that's means to be
posted in the processing of docpostprocess of the source document.
- add severe log check to InvoiceCustomerTest
- DocumentEngine should skip Doc from DocPostProcess that have been
posted
2020-11-01 12:43:36 +01:00
hengsin e1cf1ada4d
IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on th… (#332)
* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

remove unuse code.

* IDEMPIERE-4499 zk9.5 - Popup menu disappear quickly for buttons on the More area

add sysconfig record for ZK_TOOLBAR_SHOW_MORE_VERTICAL
2020-10-29 13:30:00 +01:00
Martin Schönbeck b8225276a2
Idempiere 4452 (#271)
* IDEMPIERE-4452 Allow pricelist schema lines to be dependent of vendor categories and to use entries in m_product_po not marked as current vendor if vendor is selected.

* IDEMPIERE-4452 modified update removed
* don't check for accidently set IsIgnoreIsCurrentVendor where it doesn't change anything.

* IDEMPIERE-4452 set IsIgnoreIsCurrentVendor to false ('N') when no business partner given.
2020-10-28 22:15:01 +08:00
hengsin 00e94b12ef
IDEMPIERE-2902 UX: Implement Radio buttons (#326)
* IDEMPIERE-2902 UX: Implement Radio buttons

Integrate contribution from TrekGlobal
TC-188 Port RadioGroup field editor from AP2-19
added "Radio Group List" field type

* IDEMPIERE-2902 UX: Implement Radio buttons

Peer review
* Configure correctly wrong Validation Rule
* Fix wrong DisplayLogic from this ticket and also from other recently added features on fields:
Attribute > Attribute > Reference Key
Attribute > Attribute > Dynamic Validation
Info Window > Column > Reference Key
Info Window > Column > Dynamic Validation
Registration Attributes > Attribute > Reference Key
Table and Column > Column > Dynamic Validation
Table and Column > Column > Dynamic Validation (Lookup)
Table and Column > Column > Reference Key
Web Service Security > Web Service Field Input > Reference Key
Window Customization > Field Customization > Reference Key
Window Customization > Field Customization > Dynamic Validation
Window Customization > Field Customization > Dynamic Validation (Lookup)
Window, Tab & Field > Field > Reference Key
Window, Tab & Field > Field > Dynamic Validation
Window, Tab & Field > Field > Dynamic Validation (Lookup)
* For testing and UX, configure as Radio Group:
Broadcast Message > Broadcast Message > Target
Field Group > Field group > Field Group Type

* IDEMPIERE-2902 UX: Implement Radio buttons

* For testing and UX, configure as Radio Group in detail tab:
Info Window > Process > LayoutType

* IDEMPIERE-2902 UX: Implement Radio buttons

- Fix radio group editor lost track of selectedItem after page detached
and attached
- Standardized the construction of editors from editor factory
- Remove unnecessary refresh for list/lookup based readonly editors
created by grid view (fixed editor is not readonly during init())

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2020-10-27 19:17:56 +01:00