Found issue in _Bank/Cash Statement_ window, button _Create lines from_ is creating all lines (payments and receipts) positive, the correct behavior must be to create the receipts positive and payments negative.
To fix this:
* the function currencyConvertPayment was modified to use C_Payment_V instead of C_Payment
* the columns currencyrate, convertedamt and isoverridecurrencyrate were added to the view C_Payment_V
* the definition of the view C_Payment_V was moved from script to dictionary (easier to add new columns in future)
Fix add_months function in postgresql to make it consistent with its oracle version
Fix adddays function to behave consistent as the add_months in both oracle and postgresql
Fix adddays in postgresql to add managing fractional days (same as oracle does), so it can add hours, minutes, seconds
Fix subtractdays performance making it immutable
* Payment Selection Manual:
** WPaySelect.onEvent: improved to refresh lines on onlydue, paymentrule and paymentdate changes
** PaySelect.getPaymentRuleData: is getting also inactive payment rules
** WPaySelect is showing correctly the schedule records of an invoice, but the due date is wrong - leading to wrong schedule records shown with only due invoices flag
** PaySelect.getDocTypeData: Is just selecting API/APC, can also include AR documents
* Payment Selection Create (button on window)
** running PaySelectionCreateFrom repeated the invoices - must just add new
** issotrx set based on payment rule - direct debit Y, otherwise N
** The process is getting the records from C_Invoice instead of C_Invoice_V (as manual does) - this must be leading to error on selected schedule records for only due parameter (test required to confirm)
* Payment Print/Export
** deleted not used PayPrint.getPaySelectionData
Thorough review of the BOM verification process:
1 - changed the three BOMprice functions to not take into account unverified BOMs
2 - fixed four BOMQty functions to point to correct BOM structures
3 - dropped from DB unused BOMQty*ASI functions and deprecated M_Product_BOM_Check.java class
4 - Verify BOMs process inactivated (pointing to unused structures)
5 - set default and displaylogic for process parameters of Verify BOM Structure
6 - set product verified flag as readonly to allow modification just via process verify BOM
7 - BOM products are marked as not verified when lines are changed or last line deleted
This has suffered lot of modifications after the last commit in trunk:
svn revisions: 12968, 13190, 13206, 13208, 14172, 14175, 14200, 14201
hg changesets: 6356, 6360, 6361, 6362, 6394, 6395, 6396, 6397
It requires proper functional review and analysis of collaterals
We better revert from here and integrate later when it's more stable and we have proper description and QA over these new processes.
This is a slightly large commit affecting the core functionality of shipments
so I'm happy for all eyeballs I can get on this code. I've tested as thorough
one person can do.
If there are no undiscovered bugs this doesn't change current functionality unless
you change the new setting of "Delivery Policy" available on Client Info and
Organization Info.
See also http://www.adempiere.com/index.php/Delivery_Policy
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=3004020
Carlos Ruiz
hengsin
Diego Ruiz
Elaine Tan
Juan David Arboleda
usrdno
Redhuan D. Oon