Commit Graph

2956 Commits

Author SHA1 Message Date
Carlos Ruiz fa0b52abd6
IDEMPIERE-3980 (#711)
* IDEMPIERE-3980

* IDEMPIERE-3980

Restrict uploading just to valid safe image file types

* IDEMPIERE-3980
2021-06-08 22:42:47 +08:00
Carlos Ruiz a4f67eb852
IDEMPIERE-4782 Multi-factor authentication (FHCA-2034) (#705)
* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Implement suggestions from Heng Sin

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Fix security warning advised by github/CodeQL

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

Implement an incremental delay in zk when the validation code is wrong (to avoid brute-force attacks)
As suggested by Ricardo Santana:
* ensures one-time only use of an OTP
* Log failures in AuthFailure.log

* IDEMPIERE-4782 Multi-factor authentication (FHCA-2034)

* Log failures in AuthFailure.log - add case for login with email
* Implement incremental delay also for login panel
2021-06-08 19:49:46 +08:00
Nicolas Micoud 98dc9e796c
IDEMPIERE-4808 : Payment Allocation should be IsSOTrx neutral (#703)
* IDEMPIERE-4808 : Payment Allocation should be IsSOTrx neutral

* IDEMPIERE-4808 : forms can use IsSOTrx from AD_Menu

* IDEMPIERE-4808 : add IgnoreIsSOTrxInBPInfo to be used on BPartner InfoWindow

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-06-04 09:29:37 +02:00
igorpojzl 5f2406695d
IDEMPIERE-4811 Custom Toolbar Buttons Dynamic Validation Fix (#704)
* IDEMPIERE-4811 Custom Tolbar Buttons Dynamic Validation on Detail Pane Fix

* IDEMPIERE-4811 ToolbarCustomButton - update old constructor
2021-06-03 16:38:07 +08:00
igorpojzl 01d199755b
IDEMPIERE-4803 Related Info Window Display Bug (#701)
* IDEMPIERE-4803 Related Info Window Display Bug

* IDEMPIERE-4803 Related Info Window check for CreatedBy and UpdatedBy
2021-06-01 13:45:31 +08:00
Carlos Ruiz b914083d31
IDEMPIERE-4804 Message in Reset Password Panel is misleading (#702) 2021-05-31 11:29:43 +02:00
hengsin b928043646
IDEMPIERE-4801 Add IMediaView interface and Keikai implementation (#700)
* IDEMPIERE-4801 Add IMediaView interface and Keikai implementation

* IDEMPIERE-4801 Add IMediaView interface and Keikai implementation

- Fixed some dependency issues
- Uses guava mediatype class

* minor - fix NPE when empty CSV

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-05-29 11:54:12 +02:00
Nicolas Micoud 9a21b84055
IDEMPIERE-4779 : Dashboard / Report : parameters are wrongly displayed (#690)
* IDEMPIERE-4779 : Dashboard / Report : parameters are wrongly displayed

* IDEMPIERE-4779 : Dashboard / Report : parameters are wrongly displayed

Avoid usage of DisplayType.IsID

* IDEMPIERE-4779 : Dashboard / Report : parameters are wrongly displayed

AD_Reference_Value_ID can be used for search/table/tabledir

* IDEMPIERE-4779 : Dashboard / Report : parameters are wrongly displayed

Use MLookupInfo.QueryDirect  to display value
2021-05-24 22:58:11 +08:00
igorpojzl cbfb704cb9
IDEMPIERE-434 Tab field group is not available in web (#695)
* IDEMPIERE-434  Tab field group support

* IDEMPIERE-434 Tabbox set Visible=false when no field with fieldgrouptype=tab
2021-05-24 19:51:03 +08:00
Andreas Sumerauer 3919827bc5
IDempiere-4794 (#694)
* IDEMPIERE-4794 IQuickEntry OSGI Service

* Interface IQuickeEntry replaced with abstract class AbstractWQuickEntry,
Refactorings

* QuickEntry Service used in InfoWindow. Redundant method removed.

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-05-22 15:58:02 +08:00
hengsin e8b76e24bb
IDEMPIERE-4793 Implement drag beyond page (scroll) in trees (Trek 1007493) (#693) 2021-05-20 20:31:45 +02:00
hengsin 4387b8986f
IDEMPIERE-4792 Bring back frozen column feature for desktop browser (#692)
Incorporate workaround from zk tracker and re-eanble grid frozen columns
for dekstop browser.
2021-05-20 12:10:32 +02:00
Carlos Ruiz a89a84f528
IDEMPIERE-4791 Pass PA_DashboardContent information to IDashboardGadgetFactory (#691) 2021-05-20 16:41:35 +08:00
Nicolas Micoud ca556b52ba
IDEMPIERE-4787 : Dashboard / Report : add Refresh button (#685)
* IDEMPIERE-4787 : Dashboard / Report : add Refresh button

* IDEMPIERE-4787 : Dashboard / Report : add Refresh button - applying hengsin's advices

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2021-05-17 20:06:15 +08:00
Nicolas Micoud 3b4d371fb6
IDEMPIERE-4790 : Deactivating ToolbarDetail Customize button throws NPE when using Toggle button (#689) 2021-05-17 17:43:29 +08:00
hengsin da96ecdc19
IDEMPIERE-4773 (#688)
* COF #10327 IDEMPIERE-4773 - add form factory base class backed by map and lambda functional object

Remove unnecessary white space only changes and fix wrong component name

Co-authored-by: muriloht <muriloht@devcoffee.com.br>
Co-authored-by: matheus.marcelino <matheus.marcelino@devcoffee.com.br>
2021-05-17 15:16:44 +08:00
hengsin beaaf31d9a
IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler (#679)
* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

Fix initial output type selection for csv. Fix handling of binary vs
text media type.

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

- Change AD_AuthorizationAccount scope from single value to multiple
selection list (AD_AuthorizationScopes replace AD_AuthorizationScope)

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

Fix isIntersectCSV db function

* IDEMPIERE-4771 add Cloud Upload interface to report viewer and scheduler

add back AD_AuthorizationScope Configured dynamic validation filter
2021-05-12 13:42:55 +02:00
Nicolas Micoud 8d234a8d49
IDEMPIERE-4786 : Link popup should not be opened at cursor location (#684) 2021-05-12 14:27:49 +08:00
Nicolas Micoud ad8de98fe5
IDEMPIERE-4781 : Dashboard / Report : use @SQL= syntax (#677)
* IDEMPIERE-4781 : Dashboard / Report : use @SQL= syntax

* IDEMPIERE-4781 : Dashboard / Report - be able to use Range parameters

* IDEMPIERE-4781 : Dashboard Content as Advanced

* Update DashboardController.java

Implement partial solution for IDEMPIERE-4779

Fix issue with Timestamp not working for IDEMPIERE-4781
it was throwing:
12:58:07.928-----------> DashboardController.render: Failed to create dashboard content [358]
java.lang.NumberFormatException: Error at index 6 in: "474671+02"
	at java.base/java.lang.NumberFormatException.forCharSequence(NumberFormatException.java:81)
	at java.base/java.lang.Integer.parseInt(Integer.java:735)
	at java.sql/java.sql.Timestamp.valueOf(Timestamp.java:239)
	at org.adempiere.webui.desktop.DashboardController.fillParameter(DashboardController.java:974)

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-05-11 13:10:25 +02:00
Saulo José Gil 63aec27abb
IDEMPIERE-4784 Support multiple selection lookups within process execution (#680) 2021-05-11 10:50:09 +02:00
Nicolas Micoud cdc867eb6d
IDEMPIERE-4780 : Dashboard / Report : hardcoded messages (#676) 2021-05-10 10:15:11 +08:00
Carlos Ruiz 759473f6ed
IDEMPIERE-4783 Changing the way number field with calculator are handled (#678)
* Fix not filling the box when the initial value is zero
* Fix removing  the leading zeroes to avoid octal calculations
2021-05-09 10:23:21 +02:00
Carlos Ruiz b5bcc3690e
COF #11523 / IDEMPIERE-4715 - attribute set instance: new qty available column and group results in select existing record dialog (#670)
Co-authored-by: muriloht <muriloht@devcoffee.com.br>
2021-04-28 15:28:50 +02:00
Carlos Ruiz 4e73c87e8f
IDEMPIERE-4769 False result in validation for pending changes (#661)
* IDEMPIERE-4769 False result in validation for pending changes

* * Fix also the case that changing detail is not decorating the window title with prefix *
2021-04-21 21:44:07 +08:00
Carlos Ruiz 3be5c0ac92
IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy (#660)
* IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy

* IDEMPIERE-4768 Cannot ship in some cases when multiple ASI with different material policy

* Fix wrong selection of material date policy, must take into account isUseGuaranteeDateForMPolicy
* Fix wrong material receipt, assigning material date policy based on inventory instead of document/ASI

* * Unit tests
2021-04-21 21:42:10 +08:00
Carlos Ruiz a497e03b69
IDEMPIERE-4766 Record ID button would be more useful if it shows the ID (#658) 2021-04-19 20:48:01 +08:00
Carlos Ruiz 9d059b13fe
IDEMPIERE-1405 Locator Dialog allows to create locators without any check (#651)
IDEMPIERE-4442 Change Locator Dialog ListBox to Tabledirect (autocomplete)
* Fix an issue not setting the new locator created when returning
2021-04-19 20:45:21 +08:00
Carlos Ruiz 8f31506ac7
IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments (#655)
* IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments

- Change setting for all caches to be non-distributed

* IDEMPIERE-4764 Hazelcast distributed cache can be an issue in some environments

* TC-324 Fix cache related monitoring and performance issues

- PO & GridTable call to CacheMgt reset should be async.

Co-authored-by: hengsin <hengsin@gmail.com>
2021-04-19 20:41:34 +08:00
Carlos Ruiz 1a5eb5ce22
IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex (#640)
* IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex

* Implementing suggestion from Andreas Sumerauer
* Fix issue in IDEMPIERE-3916 (Move Client) and IDEMPIERE-1026 (Create Window from Table)

* IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex

* Change approach to discover real columns

* * Rename method as suggested by Andreas Sumerauer
2021-04-07 21:34:37 +08:00
Carlos Ruiz 44edbf4b07
IDEMPIERE-4742 Delete button on detail tab is not disabled for processed records (#636) 2021-03-29 15:23:52 +02:00
Diego Ruiz da171627ed
IDEMPIERE-4743- Fixed Shift+Alt+N to save and create in detail (#639) 2021-03-25 20:30:49 +01:00
Carlos Ruiz c8fd9a8805
IDEMPIERE-4736 FHCA-2461 IDEMP - ad_column table - Framework query improvement (#628)
* IDEMPIERE-4736 FHCA-2461 IDEMP - ad_column table - Framework query improvement

* * Rename migration scripts to normal convention
2021-03-16 17:03:40 +08:00
Carlos Ruiz 43cbc2f297
IDEMPIERE-4738 Password for user System cannot be changed (#633)
IDEMPIERE-4287
2021-03-16 08:29:45 +08:00
Carlos Ruiz ba0cc46c6c
IDEMPIERE-4731 No default salesrep_id in PO/SO,Invoice when using 'Change Role' (#631) 2021-03-15 21:20:38 +08:00
Carlos Ruiz 2e4daa8930
IDEMPIERE-4566 Translation Import/Export - output message is not visible (#624)
* Fix problem with wrong management of parameters when changing from Import to Export
* Delete the deprecated class, this is unused (IDEMPIERE-4723)
2021-03-12 10:45:39 +01:00
Nicolas Micoud 1cab7864f5
IDEMPIERE-4732 : WSearchEditor - make lookup, infoPanel and adwindow (#623)
* IDEMPIERE-4732 : WSearchEditor - make lookup, infoPanel and adwindow protected
2021-03-11 17:37:14 +08:00
Carlos Ruiz c60f420cec
IDEMPIERE-4708 Context from ProcessParameterPanel is not cleared when closing the window (#618)
* IDEMPIERE-4708 Context from ProcessParameterPanel is not cleared when closing the window

* Revert "IDEMPIERE-4708 Context from ProcessParameterPanel is not cleared when closing the window"

This reverts commit 74d5d07bea748f6405bfb6988a01fab1f605f720.

* Implement suggestion from @hengsin
2021-03-10 20:09:55 +08:00
Deepak Pansheriya f8f17d5b85
IDEMPIERE-4729: Fixing cross tenant error reported issue when submitting field suggestion (#622) 2021-03-10 12:48:43 +01:00
Carlos Ruiz 8264a9abfa
IDEMPIERE-4692 Mandatory range parameters : "To" style not updated after being filled manually (#616)
* IDEMPIERE-4692 Mandatory range parameters : "To" style not updated after being filled manually

* based on patch from Anozi Mada
* Add javadoc explaining new columnname notation in IProcessParameterListener
* Change BankTransferParameterListener to illustrate better usage of columnname - as example
2021-03-09 10:56:38 +01:00
Carlos Ruiz 5f2d71347d
IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system) (#593)
* IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system)

WIP - initial version working on zk with google apps mail using OAuth2 Authorization Code Flow and Client Type = web application

* Enable imap reading with OAuth2 in RequestEMailProcessor
* Simplify the code - tested plain and OAuth2 can use the same methods
* Add +SCOPE parameter to AddAuthorizationForm according to IDEMPIERE-4713
* Rename the form AddAuthorizationMailForm to AddAuthorizationForm as is now more generic

* IDEMPIERE-4713
* Rename migration scripts to make it newer than IDEMPIERE-4713
* Add list of scopes attended by a credential
* Change form to accept other scopes, if no scope parameter is passed, then a list is shown, change the menu to fix the EMail scope
* Add MAuthorizationAccount.refreshAndGetAccessToken
* Add translation for messages

* make call generic oauth, avoid using specific google API

* Tests with microsoft as OAuth2 provider
* Add record for microsoft as provider
* Increase size of tokens
* Define mandatory and secure columns
* Update refresh token when it comes on the refresh call
* Revoke endpoint is optional

* Change the approach to a process instead of a form (WIP)
* Implement servlet to process the OAuth2 code

* Solve context suggestion from hengsin

* Implement the form in an automatic popup approach for running on zkwebui

* i18n - add translations for all messages that are shown to user
* on the form opted for click to avoid the problem with browsers forbidding popups
* clean spaces and tabs on line endings

* avoid logging and copy of the secure columns

* Fix problem reported by @d-ruiz about hidden NPE when SMTP Authentication is disabled

* Add writing to AD_PInstance_Para and AD_PInstance_Log the results of processing the servlet
* Control to avoid using the same authorization URL twice
2021-03-06 11:49:39 +01:00
hengsin 1971b4f0dc
IDEMPIERE-4488 Remove .classpath from repository (#607)
* IDEMPIERE-4488 Remove .classpath from repository

* IDEMPIERE-4488 Remove .classpath from repository

add ignore for .classpath

* IDEMPIERE-4488 Remove .classpath from repository

remove ".settings/org.eclipse.jdt.core.prefs"

* IDEMPIERE-4488 Remove .classpath from repository

fix false status report for /bin and .project
2021-03-03 00:02:03 +01:00
hengsin 3beccdf38e
IDEMPIERE-4722 Remove constraint that idempiere source folder must be… (#606)
* IDEMPIERE-4722 Remove constraint that idempiere source folder must be used as Eclipse workspace

use project_loc of org.adempiere.base instead of workspace_loc
integrate additional fix from Carlos
2021-03-02 20:51:20 +08:00
Nicolas Micoud 2c340390cf
IDEMPIERE-4716 : set InfoPanel onDoubleClick method protected (#604) 2021-02-25 06:20:07 +08:00
Carlos Ruiz 47f7180eff
IDEMPIERE-4713 Allow definition of context variables to inject on menu and window definition (#600)
* IDEMPIERE-4713 Allow definition of context variables to inject on menu and window definition

* * Implement prefix "+" as suggested by @hengsin
* Clear the variable

* * Fix scope of methods and fix interface as suggested by @hengsin

* * Implement changes suggested by @hengsin
* Add control for clicking on new button on Favourites and menu
2021-02-23 16:24:39 +01:00
Diego Ruiz 60bcc24bb4
Idempiere 4084 (#599)
* IDEMPIERE-4084 Fixed DynamicDisplay on overflow buttons

* IDEMPIERE-4084 Clean unused code
2021-02-22 10:54:30 +08:00
Diego Ruiz 3c220b6681
IDEMPIERE-4084 Improve button access logic (#592) 2021-02-18 19:46:43 +01:00
hengsin b1d3f9c8fd
IDEMPIERE-4705 Add grid toggle button to Detail Pane (#594) 2021-02-18 19:38:46 +01:00
Andreas Sumerauer 6acc8e235d
IDEMPIERE-4702 Messagebox enhancement: Esc key closes Dialog with cancel (#586)
action

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-02-16 08:41:41 +08:00
Carlos Ruiz ff88459dc9
IDEMPIERE-4703 Cross tenant issue on sort tabs (#584) 2021-02-14 10:06:59 +08:00
hengsin 3a1d53ea4e
IDEMPIERE-4676 Browser hangs after restarting iDempiere or refreshing ui.zk, on macos sometimes during work (#574)
Immediately treat jqxhr.status=0 as server not available doesn't work
well on firefox. With Firefox both stop of server and navigate away to
another site provide same jqxhr.onerror event and jqxhr.status of 0.
2021-02-09 19:10:54 +01:00