Commit Graph

3487 Commits

Author SHA1 Message Date
hengsin 7bd5e579ce
IDEMPIERE-5689 Make MLocatorLookup and WLocatorEditor more extensible (#1800)
* IDEMPIERE-5689 Add setValidationCode to MLocatorLookup

* IDEMPIERE-5689 Make MLocatorLookup and WLocatorEditor more extensible
2023-04-28 12:26:47 +02:00
hengsin f18bb88f4b
IDEMPIERE-5691 Add Table Direct type joint method to Query (#1802) 2023-04-28 12:16:13 +02:00
Nicolas Micoud 254dcb3955
IDEMPIERE-5696: Width of last column of reports exported as Xlsx is n… (#1806)
* IDEMPIERE-5696: Width of last column of reports exported as Xlsx is not correct

https://idempiere.atlassian.net/browse/IDEMPIERE-5696

* IDEMPIERE-5696: Width of last column of reports exported as Xlsx is not correct - patch from hengsin

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2023-04-27 13:34:11 +08:00
Peter Takács 23713f6461
IDEMPIERE-5669 - Report Row Count shows incorrect data (#1791)
* IDEMPIERE-5669 - Report Row Count shows incorrect data

2 issues fixed:
- row count in tab did not refresh on clicking the refresh button (only on re-run)
- row count included function rows too

* IDEMPIERE-5669 - fixes

- added private attribute to rowCount Label
- added null-check to updateRowCount() method
2023-04-25 16:24:18 +08:00
Carlos Ruiz 5bf9301764
Fixes IDEMPIERE-5673 Wrong character causes java.awt.IllegalComponentStateException: This component must have a parent in order to determine its locale on reports (#1785) 2023-04-24 18:14:28 +08:00
Carlos Ruiz 80347c0926
Fixes IDEMPIERE-2194 GL Journal Distribution writes no DocumentNo in Accounting Fact Description (#1795)
- Copy the information from the line being distributed
2023-04-23 17:12:50 +08:00
hengsin eb78bd4ee9
IDEMPIERE-5678 Unit Test is failing with PostgreSQL 15 (#1789) 2023-04-19 13:57:34 +02:00
Carlos Ruiz 449c124fe1
IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) (#1787)
* IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) - fix broken unit tests

* - Fix problem with unit test:
MTestTest.testReadingUpdatingTest:65 expected: <Test setting description> but was: <Test setting descriptionMTestEventDelegate>
2023-04-19 09:07:32 +08:00
Carlos Ruiz beed782d4e
IDEMPIERE-5675 MTable.getPO cache for model factory wrongly removing from cache when PO is not found (#1788) 2023-04-18 14:34:29 +02:00
Deepak Pansheriya 76daedf6ad
IDEMPIERE-5671: Fixing Line net amount has error due to rounding. (#1782)
* IDEMPIERE-5671: Fixing Line net amount has error due to rounding.

* IDEMPIERE-5671: on price calculation add 12 decimal rounding to avoid rounding error
Co-authored-by: carg67@gmail.com
2023-04-17 10:25:05 +02:00
Jefferson Dalfre dd0e6c95ea
IDEMPIERE-5665 - [Multi Selection] - Negate option in process parameter (#1779)
* IDEMPIERE-5665

* IDEMPIERE-5665 - Fix code
2023-04-14 16:07:40 +08:00
Carlos Ruiz c80d53674a
IDEMPIERE-5567 Support of UUID as Key - Generate Model Classes (FHCA-4195) (#1772)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

New generated model classes with new UUID constructor

* - In order to use UUID constructor M classes must implement the constructor too
- Adding the constructor on MTest and adding a JUnit test to test/show how it works

* - Remove warning caused by changes on this ticket

* - Add UUID constructor to factories

* - Set new UUID constructor in mapped/annotated test classes
- Preparation for the new UUID constructor

* - Add UUID constructor to core model classes
- WARNING: MPaymentBatch(Properties, String, String) already existed with Name as parameter, it was changed to UUID
2023-04-12 11:02:33 +08:00
Peter Takács 89a093ca49
IDEMPIERE-5482 - Field Style Scope HTML Element (#1572)
* IDEMPIERE-5482 - Field Style Scope HTML Element

* IDEMPIERE-5482 - implemented in report engine, removed the new field

* IDEMPIERE-5482 - add IsWrapWithSpan to AD_Style

* IDEMPIERE-5482 -  pr1572 patch
2023-04-11 22:22:10 +08:00
Carlos Ruiz b5cb64bc92
IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195) (#1771)
* IDEMPIERE-5567 Support of UUID for Search (UU) data type (FHCA-4195)

* - Search editor now assigns the value correctly when selecting from Info Window
- Info Window shows correctly the first UU key column
- Added Record UUID new data type to work with record ID editor but with UU column
- Added column/field Test.Record_UU for testing

* - Fix opening Record ID editor after saved

* - Implement changes suggested by Heng Sin's peer review

* - Remove other unnecessary changes

* - safer comparison
2023-04-11 13:20:13 +08:00
Carlos Ruiz 2e9b1222d3
IDEMPIERE-5560 Fix broken unit tests (#1770) 2023-04-06 16:04:45 +08:00
Peter Takács b1bf9bc4e9
IDEMPIERE-5650 - Cannot Define Multiple Values for Dashboard Content Process Parameters (#1757)
* IDEMPIERE-5650 - Cannot Define Multiple Values for Dashboard Content Process Parameters

* IDEMPIERE-5650 - remove hardcoded condition

* IDEMPIERE-5650 - fix for reference list multiselection

- support for non-ID multiselection types (values were not rendered e.g. with DocType="IP,CO")

* IDEMPIERE-5650 - fix for reference list multiselection

* IDEMPIERE-5650 - bug fixes

- error use case: reference list with numeric values e.g. "10", "20",... (fix: check DisplayType instead of data type)
- error use case 2: defining more than one multi-selection caused parsing error (fixed parsing logic in MDashboardContent)

* IDEMPIERE-5650 - optimise parsing method

* IDEMPIERE-5650 - pr1757_PR0 patch
2023-04-05 13:00:00 +02:00
Carlos Ruiz a967069164
IDEMPIERE-5567 Support of UUID as Foreign Key (FHCA-4195) (#1741)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) - Foreign Keys

* - Table Direct working as read-only and link column

* - Fixes for Table with Reference

* - Add UUID FK management to Migrate ID process
- Add MColumn.beforeSave validation to force UUID columns to end with _UU
- Add table TestUUDet with two foreign keys pointing to TestUU (TableDir and Search)
- Add detail tab to Test UU Based Table window
- Add a new test window named Test UU Detail
- Generate model classes for the new test table
- Add test case for the detail test table
- Add MTable.isIDKeyTable method
- Add UU foreign key cross tenant validation to PO.validForeignKeys

* - Added a Chosen Multiple Selection Table with foreign UU for testing
- Changed reference in dictionary logic and sql to reflect new data types
- Disable SearchUU temporarily (will be worked in next step)
- Add validation to avoid encrypting UUID columns
- Avoid warning when searching for getPO method on UUID based tables
- Make Zoom Across button work with UUID foreign keys
- Enable zoom and zoom to detail for UUID foreign keys
- Enable Find Advanced on detail foreign UUID keys

* - Fix javadoc
- Quote properly UUID
- Validate null on return

* - Fix zoom logic - tested zooming to tab in first second and third level
2023-04-05 10:26:27 +08:00
Peter Takács 30d89378c8
IDEMPIERE-5659 - New Document Base Type Group Window (#1768)
* IDEMPIERE-5659 - New Document Base Type Group Window

* IDEMPIERE-5659 - fixes

- renaming the table, model and elements according to the ticket
- removing MDocBaseGroup beforeSave validation
- adding an unique index for the Line table
2023-04-04 13:04:41 +02:00
Peter Takács 33de756336
IDEMPIERE-5645 - Print Format Script Column cannot find Columns from context (#1760)
* IDEMPIERE-5645 - Print Format Script Column cannot find Columns from context

* IDEMPIERE-5645 - move script columnd parsing after 'all rows' loop

* IDEMPIERE-5645 - fixes
2023-04-04 14:32:57 +08:00
Carlos Ruiz 9e18bc725e
IDEMPIERE-5174 Disable System User - Set new System (#1769) 2023-04-04 11:36:30 +08:00
Peter Takács 3cb7d395e1
IDEMPIERE-5652 - Print Format: Format Pattern is not Applied on Grouping/Summary rows (#1762) 2023-04-02 15:40:10 +08:00
hengsin 65f565e542
IDEMPIERE-5528 Context parsing on process Parameter not considering tab no (#1765)
- implement parent Evaluatee for GridField and ProcessParameterPanel
2023-04-01 16:24:07 +02:00
hengsin ee1b6828f4
IDEMPIERE-5560 Cannot save more than one order line when an _ID field is not displayed (#1764) 2023-04-01 16:11:35 +02:00
Deepak Pansheriya 5199247a1e
IDEMPIERE-5602 : Adding PriceEntered in Expense report (#1759) 2023-03-30 13:29:38 +02:00
muriloht 1441b9095a
IDEMPIERE-5647 - allow define context variables by role (#1753)
* IDEMPIERE-5647 - allow define context variables by role

* IDEMPIERE-5647 - fix PR comment
2023-03-29 12:44:15 +02:00
Carlos Ruiz d9764ce54e
IDEMPIERE-5238 Record_ID editor - fix 2Pack broken (#1754) 2023-03-27 19:00:21 +08:00
Nicolas Micoud 59069f4cfe
IDEMPIERE-5644 : Allow to set an image per form (#1751)
* IDEMPIERE-5644 : Allow to set an image per form

https://idempiere.atlassian.net/browse/IDEMPIERE-5644

* IDEMPIERE-5644 : Allow to set an image per form - fix suggested by hengsin

Co-Authored-By: hengsin <152246+hengsin@users.noreply.github.com>

---------

Co-authored-by: hengsin <152246+hengsin@users.noreply.github.com>
2023-03-27 18:26:20 +08:00
Jose Leite 45a8e18d32
IDEMPIERE-5640 - Fix Cross Tenant Sending BroadCast Message (#1750)
* IDEMPIERE-5640 - Fix Cross Tenant Sending BroadCast Message

* IDEMPIERE-5640 - Add validation in fix Cross Tenant Sending BroadCast Message
2023-03-24 14:20:21 +01:00
Carlos Ruiz 2d928ed37e
IDEMPIERE-5633 Check tableId <=0 in PO.checkRecordIDCrossTenant() (#1745)
IDEMPIERE-5238

Thanks to Ken Longnan
2023-03-24 11:24:47 +08:00
Diego Ruiz 89dfb22482
IDEMPIERE-5637 - Improve GridField to allow setting the default values of GridFieldVO programmatically with a method (#1746)
* IDEMPIERE-5637 - Improved GridField and GridFieldVO to allow setting default value programmatically

* IDEMPIERE-5637 - Minor refactor to improve code readibility

* IDEMPIERE-5637 - Defined constants for priority default order
2023-03-23 21:30:58 +08:00
Peter Takács bf7c9792af
IDEMPIERE-5588 - Multiselect Chosenbox Editor Doesn't Initialise its List when Tab First Opened (#1744)
* IDEMPIERE-5588 - Multiselect Chosenbox Editor Doesn't Initialise its List when Tab First Opened

* IDEMPIERE-5588 - pr1744 patch
2023-03-22 16:52:28 +08:00
Carlos Ruiz 51ceaacb43
IDEMPIERE-5567 Support of UUID as Key (FHCA-4195) (#1727)
* IDEMPIERE-5567 Support of UUID as Key (FHCA-4195)

* - Implement changes to support Model classes with UUID constructor

* - fix issue with tables with single parent key - like AD_Ref_Table

* - Create test table and JUnit test

* - fixes from Heng Sin

* - Improve performance on new methods in MTable
- Minor refinements in ModelClassGenerator
- Regenerate Test X classes
- Change Create Window from Table to receive the parent link as parameter (because tables can have now no keys at all)

* - Implement suggestions from Heng Sin

* - _UU column as primary key constraint for UUID based tables

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-03-21 21:30:45 +08:00
Nicolas Micoud 85af1ed2a1
IDEMPIERE-5608: Improve server logs by tenant and user data (#1715)
* IDEMPIERE-5608: Improve server logs by tenant and user data

* IDEMPIERE-5608: Improve server logs by tenant and user data - migration script

* IDEMPIERE-5680: Improve server logs by tenant and user data - use VM argument

Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

* IDEMPIERE-5608: Improve server logs by tenant and user data: various fixes

* IDEMPIERE-5608: Improve server logs by tenant and user data - revert changes on server.product.launch

* IDEMPIERE-5608: Improve server logs by tenant and user data - Carlos's patch

tested: )
Co-Authored-By: Carlos Ruiz <carg67@gmail.com>

---------

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2023-03-21 12:08:44 +08:00
matheus-marcelinux b11b7bcf95
IDEMPIERE-5631 - ModelEventHandler findTableName by Model annotation (#1739) 2023-03-18 12:52:23 +08:00
hengsin e479eb5cfb
IDEMPIERE-5609 Dashboard Performance Indicators incrementally redrawed on DC drag and drop (#1736) 2023-03-17 11:45:56 +01:00
Carlos Ruiz eab0574dae
IDEMPIERE-5565 Cannot create report with virtual column where reference is table with display column = ID (#1735)
* IDEMPIERE-5565 Cannot create report with virtual column where reference is table with display column = ID

* - make it consistent with the actual approach
2023-03-17 14:27:00 +08:00
Peter Takács 47987c0314
IDEMPIERE-5538 - Add isValid to Drill Rule allow validate parameters with beforesave (#1632)
* IDEMPIERE-5538 - Add isValid to Drill Rule allow validate parameters with beforesave

* IDEMPIERE-5538 - beforeSave, capture process parameters

* IDEMPIERE-5538 - validate only through process

* IDEMPIERE-5538 - isValid check in getByTable method

* IDEMPIERE-5538 - add validation to before save/after delete

* IDEMPIERE-5538 - validate system drill rules

* IDEMPIERE-5538 - fix validation logic

The mandatory validation have to skip the key parameter since it is not loaded from Drill Rule Para.

* IDEMPIERE-5538 - fix Drill Rule window definition

* IDEMPIERE-5538 - bug fix scripts to iD10

* IDEMPIERE-5538 - fix missing read only logic

* IDEMPIERE-5538 - all scripts to iD10
2023-03-16 19:10:15 +08:00
Peter Takács b7b9a4d476
IDEMPIERE-5621 - Dashboard Report ignore if parameter is mandatory or not (#1714)
* IDEMPIERE-5621 - Dashboard Report ignore if parameter is mandatory or not

* IDEMPIERE-5621 - small fixes

* IDEMPIERE-5621 - missing javadoc for new methods

* IDEMPIERE-5621 - move scripts, list empty para, update css
2023-03-16 12:01:40 +08:00
Carlos Ruiz d4dd4585b6
IDEMPIERE-5611 Record ID Editor doesn't work with House Keeping (#1720)
* IDEMPIERE-5611 Record ID Editor doesn't work with House Keeping

- Fix zoom window on tables that have this field empty and have a window associated

* - Fix zoom and lookup without AD_Window_ID update

* - Add discovery for more tab levels

* - Fix zoom when AD_Table.AD_Window_ID is null.

* - use the new method also in InfoGeneralPanel

* - set zoom window just when is not defined (preserve potential customizations)

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-03-15 22:34:31 +08:00
Nicolas Micoud 075c41c63f
IDEMPIERE-5610: Improve layout of Password Validator translations (#1702)
https://idempiere.atlassian.net/browse/IDEMPIERE-5610
2023-03-15 19:00:38 +08:00
Carlos Ruiz f35585a96e
IDEMPIERE-5238 Record_ID editor (#1728)
- exclude AD_WF_Activity from the validation to avoid affecting performance
2023-03-14 21:53:06 +08:00
Carlos Ruiz c29184fbf1
IDEMPIERE-5616 Reverse Shipments don't post because of Not Balanced in special case (#1706)
* IDEMPIERE-5616 Reverse Shipments don't post because of Not Balanced in special case

* - Add case for Inventory Move
- Add explanatory comment

* - Add extra cases for other documents

* - uploaded a different approach

---------

Co-authored-by: hengsin <hengsin@gmail.com>
2023-03-14 20:59:59 +08:00
Carlos Ruiz 4c77efecb4
IDEMPIERE-5613 Make filling of _UU column optional (#1719)
* IDEMPIERE-5613 Make filling of _UU column optional

* - clear _UU when column is made inactive

* - Add parameter IsClearUUID
- Fix issue with buffer log not being flushed
2023-03-14 20:20:57 +08:00
hengsin b188775e9a
IDEMPIERE-5624 Implement export data as SQL insert statement (#1721) 2023-03-13 15:57:45 +01:00
Peter Takács 1bc5370dbb
IDEMPIERE-5618 - Print Format Script Column does not show Data in correct Data Types (#1712)
* IDEMPIERE-5618 - Print Format Script Column does not show Data in correct Data Types

* IDEMPIERE-5618 - optimised and simplified the code

- get PrintFormatType from PrintDataColumn pdc
- getDisplayType(value) method to unify and simplify getting the display type
2023-03-13 21:40:09 +08:00
Carlos Ruiz e4b7c9e17d
IDEMPIERE-5628 Record ID Check Issue - implement setCrossTenantSafe (#1724)
* IDEMPIERE-5628 Record ID Check Issue - implement setCrossTenantSafe

* - remove table exceptions
2023-03-13 21:38:00 +08:00
Carlos Ruiz ef06b837d6
IDEMPIERE-5542 [DisplayType] - Cache issue (#1718)
Minor refactoring to use MTable.MAX_OFFICIAL_ID
2023-03-11 20:46:45 +08:00
Carlos Ruiz fb98b75ce9
IDEMPIERE-5542 [DisplayType] - Cache issue (#1717)
- Fix problem with the AbstractXLSXExporter going wild, the method getFormatString is trying to create a format with the number of digits supported by the NumberFormat, and as the MaximumIntegerDigits is not set, is trying to create a String with the default which is 2147483647
2023-03-11 01:01:09 +08:00
hengsin 3877a672c6
IDEMPIERE-5586 Implement ID independent migration script (#1711)
- Update should use ID column for where clause if ID value is official id.
2023-03-10 12:16:26 +01:00
Carlos Ruiz fe72b671ab
IDEMPIERE-5238 Record_ID editor (#1705)
- fixes for the new cross-tenant validation
2023-03-09 10:16:25 +08:00