Commit Graph

2928 Commits

Author SHA1 Message Date
Carlos Ruiz 1a5eb5ce22
IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex (#640)
* IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex

* Implementing suggestion from Andreas Sumerauer
* Fix issue in IDEMPIERE-3916 (Move Client) and IDEMPIERE-1026 (Create Window from Table)

* IDEMPIERE-4746 Wrong usage of MTable.getColumnIndex

* Change approach to discover real columns

* * Rename method as suggested by Andreas Sumerauer
2021-04-07 21:34:37 +08:00
Carlos Ruiz 44edbf4b07
IDEMPIERE-4742 Delete button on detail tab is not disabled for processed records (#636) 2021-03-29 15:23:52 +02:00
Diego Ruiz da171627ed
IDEMPIERE-4743- Fixed Shift+Alt+N to save and create in detail (#639) 2021-03-25 20:30:49 +01:00
Carlos Ruiz c8fd9a8805
IDEMPIERE-4736 FHCA-2461 IDEMP - ad_column table - Framework query improvement (#628)
* IDEMPIERE-4736 FHCA-2461 IDEMP - ad_column table - Framework query improvement

* * Rename migration scripts to normal convention
2021-03-16 17:03:40 +08:00
Carlos Ruiz 43cbc2f297
IDEMPIERE-4738 Password for user System cannot be changed (#633)
IDEMPIERE-4287
2021-03-16 08:29:45 +08:00
Carlos Ruiz ba0cc46c6c
IDEMPIERE-4731 No default salesrep_id in PO/SO,Invoice when using 'Change Role' (#631) 2021-03-15 21:20:38 +08:00
Carlos Ruiz 2e4daa8930
IDEMPIERE-4566 Translation Import/Export - output message is not visible (#624)
* Fix problem with wrong management of parameters when changing from Import to Export
* Delete the deprecated class, this is unused (IDEMPIERE-4723)
2021-03-12 10:45:39 +01:00
Nicolas Micoud 1cab7864f5
IDEMPIERE-4732 : WSearchEditor - make lookup, infoPanel and adwindow (#623)
* IDEMPIERE-4732 : WSearchEditor - make lookup, infoPanel and adwindow protected
2021-03-11 17:37:14 +08:00
Carlos Ruiz c60f420cec
IDEMPIERE-4708 Context from ProcessParameterPanel is not cleared when closing the window (#618)
* IDEMPIERE-4708 Context from ProcessParameterPanel is not cleared when closing the window

* Revert "IDEMPIERE-4708 Context from ProcessParameterPanel is not cleared when closing the window"

This reverts commit 74d5d07bea748f6405bfb6988a01fab1f605f720.

* Implement suggestion from @hengsin
2021-03-10 20:09:55 +08:00
Deepak Pansheriya f8f17d5b85
IDEMPIERE-4729: Fixing cross tenant error reported issue when submitting field suggestion (#622) 2021-03-10 12:48:43 +01:00
Carlos Ruiz 8264a9abfa
IDEMPIERE-4692 Mandatory range parameters : "To" style not updated after being filled manually (#616)
* IDEMPIERE-4692 Mandatory range parameters : "To" style not updated after being filled manually

* based on patch from Anozi Mada
* Add javadoc explaining new columnname notation in IProcessParameterListener
* Change BankTransferParameterListener to illustrate better usage of columnname - as example
2021-03-09 10:56:38 +01:00
Carlos Ruiz 5f2d71347d
IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system) (#593)
* IDEMPIERE-3101 implement OAuth2 for mail (gmail, outlook and other mail system)

WIP - initial version working on zk with google apps mail using OAuth2 Authorization Code Flow and Client Type = web application

* Enable imap reading with OAuth2 in RequestEMailProcessor
* Simplify the code - tested plain and OAuth2 can use the same methods
* Add +SCOPE parameter to AddAuthorizationForm according to IDEMPIERE-4713
* Rename the form AddAuthorizationMailForm to AddAuthorizationForm as is now more generic

* IDEMPIERE-4713
* Rename migration scripts to make it newer than IDEMPIERE-4713
* Add list of scopes attended by a credential
* Change form to accept other scopes, if no scope parameter is passed, then a list is shown, change the menu to fix the EMail scope
* Add MAuthorizationAccount.refreshAndGetAccessToken
* Add translation for messages

* make call generic oauth, avoid using specific google API

* Tests with microsoft as OAuth2 provider
* Add record for microsoft as provider
* Increase size of tokens
* Define mandatory and secure columns
* Update refresh token when it comes on the refresh call
* Revoke endpoint is optional

* Change the approach to a process instead of a form (WIP)
* Implement servlet to process the OAuth2 code

* Solve context suggestion from hengsin

* Implement the form in an automatic popup approach for running on zkwebui

* i18n - add translations for all messages that are shown to user
* on the form opted for click to avoid the problem with browsers forbidding popups
* clean spaces and tabs on line endings

* avoid logging and copy of the secure columns

* Fix problem reported by @d-ruiz about hidden NPE when SMTP Authentication is disabled

* Add writing to AD_PInstance_Para and AD_PInstance_Log the results of processing the servlet
* Control to avoid using the same authorization URL twice
2021-03-06 11:49:39 +01:00
hengsin 1971b4f0dc
IDEMPIERE-4488 Remove .classpath from repository (#607)
* IDEMPIERE-4488 Remove .classpath from repository

* IDEMPIERE-4488 Remove .classpath from repository

add ignore for .classpath

* IDEMPIERE-4488 Remove .classpath from repository

remove ".settings/org.eclipse.jdt.core.prefs"

* IDEMPIERE-4488 Remove .classpath from repository

fix false status report for /bin and .project
2021-03-03 00:02:03 +01:00
hengsin 3beccdf38e
IDEMPIERE-4722 Remove constraint that idempiere source folder must be… (#606)
* IDEMPIERE-4722 Remove constraint that idempiere source folder must be used as Eclipse workspace

use project_loc of org.adempiere.base instead of workspace_loc
integrate additional fix from Carlos
2021-03-02 20:51:20 +08:00
Nicolas Micoud 2c340390cf
IDEMPIERE-4716 : set InfoPanel onDoubleClick method protected (#604) 2021-02-25 06:20:07 +08:00
Carlos Ruiz 47f7180eff
IDEMPIERE-4713 Allow definition of context variables to inject on menu and window definition (#600)
* IDEMPIERE-4713 Allow definition of context variables to inject on menu and window definition

* * Implement prefix "+" as suggested by @hengsin
* Clear the variable

* * Fix scope of methods and fix interface as suggested by @hengsin

* * Implement changes suggested by @hengsin
* Add control for clicking on new button on Favourites and menu
2021-02-23 16:24:39 +01:00
Diego Ruiz 60bcc24bb4
Idempiere 4084 (#599)
* IDEMPIERE-4084 Fixed DynamicDisplay on overflow buttons

* IDEMPIERE-4084 Clean unused code
2021-02-22 10:54:30 +08:00
Diego Ruiz 3c220b6681
IDEMPIERE-4084 Improve button access logic (#592) 2021-02-18 19:46:43 +01:00
hengsin b1d3f9c8fd
IDEMPIERE-4705 Add grid toggle button to Detail Pane (#594) 2021-02-18 19:38:46 +01:00
Andreas Sumerauer 6acc8e235d
IDEMPIERE-4702 Messagebox enhancement: Esc key closes Dialog with cancel (#586)
action

Co-authored-by: Andreas <sumerauer@kanzlei-wmv.de>
2021-02-16 08:41:41 +08:00
Carlos Ruiz ff88459dc9
IDEMPIERE-4703 Cross tenant issue on sort tabs (#584) 2021-02-14 10:06:59 +08:00
hengsin 3a1d53ea4e
IDEMPIERE-4676 Browser hangs after restarting iDempiere or refreshing ui.zk, on macos sometimes during work (#574)
Immediately treat jqxhr.status=0 as server not available doesn't work
well on firefox. With Firefox both stop of server and navigate away to
another site provide same jqxhr.onerror event and jqxhr.status of 0.
2021-02-09 19:10:54 +01:00
Carlos Ruiz 0669760711
IDEMPIERE-3340 Adaxa's User Favorite which allow user to organize their menu, create folders (#569)
* Login Automatic Open Sequence -> buttons don't require names
* Login Automatic Open Sequence -> buttons look bad with non-font icons
* Clicking on + on an item of the favourites throws an NPE
* Implement same approach about checking for new button restricted on menu search, menu popup and quick entry popup
2021-02-04 21:39:15 +01:00
Deepak Pansheriya 373225a62c
Idempiere 3340 (#505)
* IDEMPIERE-3340 : User favorite with tree structure

* IDEMPIERE-3340: Marking write operation to safe for cross tenant safe

* IDEMPIERE-3340: Fixing Cross tenant access issue

* IDEMPIERE-3340: refactoring as review comment, Fixing renaming folder issue, Auto launch window shows all items irrespective of access

* Sync with IDEMPIERE-4251

* Sync with IDEMPIERE-4251

* IDEMPIERE-3340: Refactoring as review comment for caching,
 toolbar button restriction method with ID, tooltip messages, font base theme,
 remove double click event, etc.

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-02-04 21:36:25 +01:00
Carlos Ruiz c5c08a8b87
IDEMPIERE-4658 The operator Dropdown entries for a foreign ID column is corrupted when a search preset is loaded in any window's Advanced Search tab. (#564)
Fix issue discovered:
* Saving a query with LIKE operator, when restored it changes to = operator
2021-02-01 15:20:19 +01:00
hengsin 3d70b5dd63
IDEMPIERE-4676 Browser hangs after restarting iDempiere or refreshing… (#557)
* IDEMPIERE-4676 Browser hangs after restarting iDempiere or refreshing ui.zk, on macos sometimes during work

* IDEMPIERE-4678 Save log informing Notice created when background job

stop immediately when server is not reachable
2021-01-31 15:56:22 +08:00
Carlos Ruiz fd3fef9e7b
IDEMPIERE-4678 Save log informing Notice created when background job (#559)
* IDEMPIERE-4678 Save log informing Notice created when background job

* Added also a refactor for the INSERT INTO AD_PInstance_Log to use safer binding variables and add method saveEx

* - Implement suggestions from @hengsin
- Add some additional improvements
2021-01-29 08:57:15 +08:00
Diego Ruiz 245b471d06
IDEMPIERE-4672 Improve the StatusBar Menupopup to render HTML text (#553) 2021-01-25 17:01:14 +01:00
hengsin f233e29432
IDEMPIERE-4662 Some problems of sort at window before save (#551)
* IDEMPIERE-4662 Some problems of sort at window before save

* IDEMPIERE-4662 Some problems of sort at window before save

Fixed the sequence of edit field -> sort -> edit field will wrongly
trigger save automatically.
2021-01-25 09:31:21 +01:00
Diego Ruiz 2dbbc93485
IDEMPIERE-4665 SearchQuery should behave the same as the toolbar buttons - role access,advanced button,dynamic display (#548) 2021-01-23 12:32:19 +01:00
Nicolas Micoud 9413a8a2f5
IDEMPIERE-4665 : Toolbar: Select Query cannot be hidden (#546) 2021-01-22 11:05:27 +01:00
Carlos Ruiz 96393d2356
IDEMPIERE-4657 Search Dialog Columns are duplicated when table is present in multiple window tabs. (#540)
* IDEMPIERE-4657 Search Dialog Columns are duplicated when table is present in multiple window tabs.

* Improve query when different seqno (just check fields from first tab)
2021-01-21 17:27:47 +01:00
Carlos Ruiz 2d76f90f9c
IDEMPIERE-4660 Wrong code in virtual columns broke IDEMPIERE-2356 (#541)
IDEMPIERE-4087
IDEMPIERE-3760
2021-01-21 14:28:15 +01:00
Carlos Ruiz d81935a128
IDEMPIERE-4658 The operator Dropdown entries for a foreign ID column is corrupted when a search preset is loaded in any window's Advanced Search tab. (#538) 2021-01-20 21:46:35 +08:00
Carlos Ruiz 24ccb86f16
IDEMPIERE-4653 Improve timeout handling of window tab (#539)
* IDEMPIERE-4653 Improve timeout handling of window tab

* Fixed a problem with IDEMPIERE-4130 that was not using role max query records
* GridTable was throwing NPEs because the arrays were disposed before closing
* Lowered log level on MRole to avoid clogging the console (I was testing with INFO level)
* Added more points of control for the timeout exception to give meaningful errors to the user and allow refining the query without closing the Find dialog
* Implemented a control to avoid repeating a slow initial query every time the dialog is open
* Added dialog when the find criteria doesn't return rows and allows the user to refine the query
* When the initial number of records is unknown, show a question mark instead of the count

* * Fix wrong role level pushed in first commit
2021-01-20 21:45:33 +08:00
hengsin e1ba21360f
IDEMPIERE-4653 Improve timeout handling of window tab (#534)
* IDEMPIERE-4653 Improve timeout handling of window tab

* IDEMPIERE-4653 Improve timeout handling of window tab

Fix error with find and refresh.
2021-01-20 13:27:58 +01:00
HideakiHagiwara cdb21c0698
IDEMPIERE-4655 WTimeEditor display time picker button when read only. (#535)
Co-authored-by: HideakiHagiwara <h.hagiwara@gmail.com>
2021-01-20 20:05:16 +08:00
hengsin 59b83c3361
IDEMPIERE-4628 Implement configurable query timeout for info window (#532)
* IDEMPIERE-4628 Implement configurable query timeout for info window

* IDEMPIERE-4628 Implement configurable query timeout for info window

Move migration script from i8.2z to i8.2
2021-01-19 10:25:13 +08:00
hengsin 1afe4fe0c6
IDEMPIERE-4652 Remove Eclipse warnings (#533) 2021-01-18 17:32:25 +01:00
hengsin ebcf4b3e1c
IDEMPIERE-4651 Max records for Search autocomplete list should be configurable (#531) 2021-01-18 11:52:12 +01:00
Carlos Ruiz fa8b7f1807
IDEMPIERE-4645 Search by special field types failing (#524)
* IDEMPIERE-4645 Search by special field types failing

* Set the advanced operators for Search for the special cases
2021-01-17 18:05:06 +08:00
Carlos Ruiz efc3d98313
IDEMPIERE-4647 Plugin Manager improvement (#528)
Fix index out of bounds error - when selecting a plugin and then filtering for a number of items lower than the selected index
2021-01-15 19:03:23 +01:00
Nicolas Micoud e3c78d7501
IDEMPIERE-4647 : filter plugins using name (#527)
* IDEMPIERE-4647 : filter plugins using name

* Minor improvements

* Add translated message for Filter
* Use ON_CHANGE instead of ON_BLUR, allows to apply the filter with ENTER

Co-authored-by: Carlos Ruiz <carg67@gmail.com>
2021-01-15 18:39:55 +01:00
hengsin 6c6cbf932d
IDEMPIERE-4625 Login Page refresh cause error message, randomly when slow db response (#525)
Fix CLOSE-WAIT issue
(https://groups.google.com/g/idempiere/c/wppbB5jdByg/m/_VOzSZZyAQAJ)
2021-01-15 10:54:07 +01:00
HideakiHagiwara fb8c045de9
IDEMPIERE-4644 Heading only Field is the cause of NullPointerException Error on Find Window. I Added null check logic. (#523)
Co-authored-by: jpiere <h.hagiwara@compiere-distribution-lab.net>
2021-01-13 09:26:51 +01:00
Carlos Ruiz 402300a53e
IDEMPIERE-4639 Cross tenant issues with context help (#522) 2021-01-12 21:31:40 +08:00
hengsin d96199a2b6
IDEMPIERE-4251 Constant definition for all Env Context (#519)
* IDEMPIERE-4251 Constant definition for all Env Context

replace "#Date" with Env.DATE

* IDEMPIERE-4251 Constant definition for all Env Context

replace "#.." with constant at Env

* IDEMPIERE-4251 Constant definition for all Env Context

Merge patch from Carlos
2021-01-12 21:29:50 +08:00
hengsin bbb4c48b67
IDEMPIERE-4625 Login Page refresh cause error message, randomly when slow db response (#506)
Fix wrong stop server push flow.
2021-01-06 10:46:56 +01:00
hengsin 248612e24d
IDEMPIERE-4485 Info Window Columns has no Value preference (#510)
add back the line that's wrongly remove in the review of PR 501
2021-01-06 06:56:02 +08:00
igorpojzl 5a01ef2c07
IDEMPIERE-4630 Global Search, Tab Search has no scroll (#509) 2021-01-05 23:20:29 +08:00