1a06e21024
peer review for 11547 - minor changes
...
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 23:04:46 +00:00
98c74ef980
peer review for 11545 and 11546 - refactored getProductLot to have predictable results
...
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 22:40:26 +00:00
ff9dffd082
peer review for 11541 - be careful with logic: an exception is not equivalent to a log.info
...
refactored to use .setClientID()
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 22:13:54 +00:00
e7177049db
peer review for 11533, 11537, 11540
...
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 21:43:37 +00:00
d9b22ee7ed
peer review for 11539
...
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 21:13:05 +00:00
791f4a8624
peer review for 11538 -> drop unused lines in ExportHelper - apply the same practice to ImportHelper, fix warning on ExportFormatGenerator
...
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 20:09:00 +00:00
6b59db69ed
peer review for 11535 -> getBPartnerCashTrx refactored with junit test applied
...
FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 19:47:16 +00:00
ab5b31fe9a
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-03 07:51:30 +00:00
dfe03fabfa
FR 2962094 - Finish implementation of weighted average costing
...
1st step -> create column to manage the processed date+time (in order to allow reposting of documents in the same order they were completed - this will be the second step)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962094
2010-03-03 01:31:36 +00:00
5fdefd4be3
Future dated price list version used in order
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2962244
2010-03-02 22:59:41 +00:00
d6e3780968
Apply ADempiere Best Practice and change the Collection by List as standard in ADempiere
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 17:15:59 +00:00
3486415202
Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:44:42 +00:00
7fb5e6b54d
Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:43:25 +00:00
d2333e9026
Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-02 15:38:35 +00:00
5fba554eab
Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 07:18:20 +00:00
83154f494f
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 06:39:45 +00:00
c0d989b240
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
-- JUnit test included (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-03-01 00:42:03 +00:00
a3cf7e8d37
Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 22:41:26 +00:00
b690a934d3
Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Best Practice. No unit testing done but compiler tested OK.
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 09:55:38 +00:00
042083872b
Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Heng Sin's advice. No unit testing done but compiler tested OK.
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 05:12:58 +00:00
490cb806df
Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Heng Sin's advice. No unit testing done but compiler tested OK.
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 04:39:28 +00:00
e80c558107
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 04:24:19 +00:00
583954e3eb
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-28 02:01:59 +00:00
03153697fe
Peer review 11500, minor - drop useless comment, organize imports
...
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 21:06:50 +00:00
cc7809b482
Apply Best Practices to Promotions Code: Use Model Classes instead of X_ classes whenever possible
2010-02-27 20:38:11 +00:00
1210dab275
Peer review 11504, be careful, you need to check retValue for null to avoid NPE
...
refactored to use common MProduct constructor
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 19:54:34 +00:00
94812caebc
Peer review 11501, be careful with the login being replaced
...
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 19:38:25 +00:00
4a552b9877
Peer review 11499, fix error reported by Mario
...
Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 19:23:17 +00:00
baa578cdfb
[ BF 2960239 ] - Promotion Minimum Amt > 0
...
In the promotion line if the minimum amount is 0.00 (default) then the line
is not fired because the Promotion rule only activates when the minimum
amount is > 0. This means if you always want the rule to fire - you need
to make the minimum 0.01 which is not logical if you want no minimum.
https://sourceforge.net/tracker/?func=detail&aid=2960239&group_id=176962&atid=879332
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2960239
2010-02-27 15:41:14 +00:00
139f65a82e
[ BF 2960231 ] - PromotionValidator not fired in correct client
...
The promotion validator document validator is not fired because the client
id in the listener is not set correctly before adding the table to the
Model Validation Engine
https://sourceforge.net/tracker/?func=detail&aid=2960231&group_id=176962&atid=879332
2010-02-27 15:21:37 +00:00
bb3a54da57
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 14:05:19 +00:00
9aa3c31c35
Prevent SQL Injection (advice from Victor Perez)
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 09:02:32 +00:00
38396298cd
[ FR 2836965 ] Group1 and Group2 fields are not considered in Schema Lines (Fixed)
...
http://sourceforge.net/tracker/index.php?func=detail&aid=2836965&group_id=176962&atid=879335
[ FR 1871403 ] Adding new field of product into Price List Schema (Fixed)
http://sourceforge.net/tracker/index.php?func=detail&aid=1871403&group_id=176962&atid=879335
Converted to CPrepraedStatement to avoid string injection and fixed "AND" logic
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2836965
2010-02-27 08:10:40 +00:00
cd4c15c059
Merge bug fixes in release not committed to trunk
...
merge -c 11478 -c 11471 -c 11374
BF2958108 Answer in Workflow Activities keeps adding Yes/NO
https://sourceforge.net/tracker/?func=detail&atid=955896&aid=2958108&group_id=176962
BF2957689 Material Receipt -> Create From -> Only same wh not working
https://sourceforge.net/tracker/?func=detail&atid=955896&aid=2957689&group_id=176962
BF2815307 Default Tax Error
https://sourceforge.net/tracker/?func=detail&atid=879332&aid=2815307&group_id=176962
2010-02-27 06:16:16 +00:00
ec4e2f798a
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
Applying defensive programming approach and ABP.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 06:12:53 +00:00
998d5c20f5
Review FR: [ 2214883 ] Remove SQL code and Replace for Query >> to incorporate Heng Sin's advice. No unit testing done but compiler tested OK.
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 02:47:51 +00:00
0da2f340e7
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
-- JUnit test in next commit (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-27 02:26:04 +00:00
8df91cee04
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
-- JUnit test included (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 11:39:31 +00:00
dd7b9b1341
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
-- JUnit test included (no failures)
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 10:21:04 +00:00
5b537cf891
Typo error at MBOM
2010-02-26 07:27:43 +00:00
7cd1ead853
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
-- JUnit test included (no failures). Please clean up M_BOM test record afterwards.
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 07:07:32 +00:00
8cd9f28474
FR: [ 2214883 ] Remove SQL code and Replace for Query (implementing review by Carlos, Hengsin and Victor - call to interface rather than model class for tablename. JUnit tests carried out again before commit
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 02:51:35 +00:00
fa569115e1
The window context variable is share by all tab and can get mix up when user navigate from one tab to another. This patch recreate the window context variable before entering a tab to solve the potential conflict issue.
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2959339
2010-02-26 02:07:55 +00:00
1516f063b5
don't have to add setParameter(int), we just need to replace setParameters(Object[] parameters) with setParameters(Object ...parameters)
...
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 01:02:06 +00:00
0725d135a9
Peer review of FR: [ 2214883 ] Remove SQL code and Replace for Query
...
revisions 11482, 11484, 11485, 11487, 11488, 11489, 11490
- Added method Query.getParameters(int) to improve readability (if most of the replacements just use one int parameter it makes sense to avoid the declaration of new Object[] all the times)
- drop unused imports
- check serialVersionUID
- what is the advantage of using I_M_Product_BOM.Table_Name instead of MProductBOM.Table_Name when defining a list of MProductBOM objects? and it's intended that MProductBOM must always implement the interface
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-26 00:29:57 +00:00
1603524916
Apply ABP http://www.adempiere.com/index.php/ADempiere_Best_Practices#How_to_use_Adempiere_Query_class.3F
...
//FR: [ 2214883 ] Remove SQL code and Replace for Query
Link to SF Tracker: http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-25 21:32:06 +00:00
398eaf6f10
FR: [ 2214883 ] Remove SQL code and Replace for Query (thanks Trifon for the last review and correction.
...
-- JUnit test included (no failures)
2010-02-25 21:08:04 +00:00
025e667dd2
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
Please keep transaction.
Old code used transaction, so new should also use transaction.
http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-25 19:30:58 +00:00
fea9618e40
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
Please keep transaction.
old code used transaction, so new should also use transaction.
http://sourceforge.net/support/tracker.php?aid=2214883
2010-02-25 19:27:08 +00:00
011ec4a4d6
FR: [ 2214883 ] Remove SQL code and Replace for Query
...
-- JUnit test included (no failures)
2010-02-25 16:03:58 +00:00
Carlos Ruiz
Redhuan D. Oon
phib
Heng Sin Low